7566 commits

Author	SHA1	Message	Date
Kara Diaby	68b45ae31d	modify instructeur procedures controller	2022-01-12 15:49:38 +01:00
Kara Diaby	e2caf5718f	modify instructeur model	2022-01-12 15:49:38 +01:00
Kara Diaby	4606650248	layout	2022-01-12 15:49:38 +01:00
Kara Diaby	894b065615	modify dossier model	2022-01-12 15:49:37 +01:00
Kara Diaby	006eac4240	modify controller	2022-01-12 15:49:37 +01:00
Paul Chavard	4a718eae92	fix(select): always show menu on click in the input ... fix #6655	2022-01-11 12:11:45 +01:00
Paul Chavard	967699c305	fix(select): improuve no results found message	2022-01-11 12:10:20 +01:00
Pierre de La Morinerie	062f52feb9	Fix ProcedureAdministrateursController#destroy ... - The "no remove oneself" rule wasn't actually enforced - `flash.error` is not a flash category	2022-01-07 15:39:58 +01:00
Martin	383a92bcd9	fix(parallel_download_queue): tophoeus does not like raise from a request handler [crash straight to first frame]	2022-01-07 14:24:37 +01:00
Pierre de La Morinerie	2e1a3c32cb	helpers: handle flash[:error] ... Errors generated by the `invisible-catcha` gem are reported as `flash[:error]` (which differs from Rail's usual `flash[:alert]`). We probably shouldn't use flash[:error] in our own codebase; but we can handle its use in third-party libraries.	2022-01-06 14:09:31 +01:00
Pierre de La Morinerie	68b112e00a	helpers: don't crash on unknown flash level ... Errors generated by the `invisible-catcha` gem are reported as `flash[:error]` (which differs from Rail's usual `flash[:alert]`). Avoid crashing when the flash level passed to this helper is not known.	2022-01-06 14:09:26 +01:00
Martin	f770ac4907	fix(users/champs/piece_justificative#update): ensure to bump dossier.last_champ_updated_at otherwise instructeurs are not notified when user update their piece_justificative	2022-01-06 13:09:57 +01:00
Martin	a9ffaf942e	feat(attestation): can enable/disable attestation no matter the state of the procedure	2022-01-05 18:20:11 +01:00
Paul Chavard	28c1763701	a11y(champs): generalize describedby and update to use new Combo props	2022-01-05 12:33:40 +01:00
Paul Chavard	3513182e7c	a11y(select): use new ComboMultiple component	2022-01-05 12:33:40 +01:00
Paul Chavard	d6b6bb0f2a	a11y(combobox): add support for describedby and labelledby and improuve external fields handling	2022-01-05 12:33:40 +01:00
Paul Chavard	fc058f721d	a11y(champs): expose ids for UI on champ	2022-01-05 12:33:40 +01:00
simon lehericey	00871cfe13	Fix ping controller in dev ... For an unknown reason, ActiveRecord::Base.connected? does not work anymore in dev. It returns false negative. This simple workaround can timeout. The caller has to monitor the response time.	2022-01-05 11:44:32 +01:00
Martin	3eb1c1a421	feat(async_backend): switch to typhoeus	2022-01-04 16:27:23 +01:00
Martin	ce1b189dcd	refactor(DownloadManager): extract parallel download in dedicated class. move error management in custom class for procedure exports using the didicated class	2022-01-04 16:17:03 +01:00
Martin	2ed9cccba0	extract download all attachments in dedicated class using async/async-http for better perf	2022-01-04 16:17:03 +01:00
Martin	252eee272b	feat(support#create): block with invisible captcha [avoid painful captcha]	2022-01-04 14:49:00 +01:00
Paul Chavard	7f0dde9be4	fix(a11y): add aria to tabs	2022-01-04 09:44:32 +01:00
Paul Chavard	6776a5e05a	fix(react): remove register component cache	2022-01-03 19:41:23 +01:00
Kara Diaby	1ca553e088	rename hidden_by_instructeur by hidden_by_administration	2022-01-03 11:51:25 +01:00
Paul Chavard	ad4be3c482	refactor(dossier): handle discard by admin and super admin	2022-01-03 11:51:25 +01:00
Kara Diaby	b408811c5a	l'expert ne voit pas les dossiers supprimés par l'instructeur	2022-01-03 11:51:25 +01:00
Kara Diaby	051d7b2028	change dossier method	2021-12-29 17:37:58 +01:00
Kara Diaby	37e991ccb8	User : delete the folder if the instructeur has hide it	2021-12-29 17:37:58 +01:00
Kara Diaby	7d7b847437	Instructeur : delete the folder if the user has hide it	2021-12-29 17:37:58 +01:00
Kara Diaby	22ac853815	add hidden_by_instructeur scope	2021-12-29 17:37:58 +01:00
Kara Diaby	f239d46a45	add hide_dossier method to instructeurs	2021-12-29 17:37:57 +01:00
Kara Diaby	cd95b730e0	add hidden_by_instructeur_at on dossiers	2021-12-29 17:37:57 +01:00
Martin	d0ab1711ff	fix(profil_controller#update_email): ensure we are not merging same account ... fix(profil_controller#update_email): changing email from current_user.email to current_user.email destroy current user. whoops ☠️' Update config/locales/en.yml Co-authored-by: Pierre de La Morinerie <pierre.de_la_morinerie@beta.gouv.fr> Update config/locales/fr.yml Co-authored-by: Pierre de La Morinerie <pierre.de_la_morinerie@beta.gouv.fr> Update spec/controllers/users/profil_controller_spec.rb Update config/locales/fr.yml Co-authored-by: Pierre de La Morinerie <pierre.de_la_morinerie@beta.gouv.fr> Update spec/controllers/users/profil_controller_spec.rb fix(spec): broken due to typo	2021-12-29 13:36:47 +01:00
Christophe Robillard	6e36fee7b3	superadmin can display list of procedures without zone	2021-12-23 19:18:46 +01:00
Christophe Robillard	90c971567d	superadmin can show zone for a procedure	2021-12-23 19:07:42 +01:00
Christophe Robillard	c7b5e57d2a	superadmin can get procedures from zone	2021-12-23 19:07:42 +01:00
Christophe Robillard	537e6066d8	add Zones dashboard for superadmin	2021-12-23 19:07:42 +01:00
Christophe Robillard	878f735a80	facilite le remplissage automatique de l'email	2021-12-23 19:00:10 +01:00
Paul Chavard	4e779f445d	fix(instructeur): copy notifications settings from previous groupe instructeur ... fix #6763	2021-12-23 13:55:25 +01:00
Paul Chavard	2f6cd317bf	fix(instructeur): set notification settings on all groupe instruteur for given procedure	2021-12-23 13:55:25 +01:00
Christophe Robillard	eda8aacfe4	fix a11y problem for support page ... L'interpolation de `support.index.product.answer_html` produisait des balises p vides, ce qui contrevenait au critère 8.9.1 RGAA (https://www.numerique.gouv.fr/publications/rgaa-accessibilite/methode/criteres/#test-8-9-1)	2021-12-23 10:49:52 +01:00
Pierre de La Morinerie	07230870d3	js: don't track external links ... This fixes an issue where, by default, links to private attachments are reported to Matomo. This is benign: attachments URLs can be filtered out server-side, and expire after one hour anyway. But we don't want to ship an insecure configuration by default.	2021-12-23 09:50:21 +01:00
Paul Chavard	f8d245d2f8	refactor(js): use dynamic import	2021-12-21 17:09:49 +00:00
Paul Chavard	26f65e250c	fix(a11y): better contrast on placeholders	2021-12-21 16:50:31 +00:00
Paul Chavard	1c6ff09c5b	fix(a11y): stop using th in presentation only tables	2021-12-21 16:50:31 +00:00
Paul Chavard	64104f9fc3	fix(a11y): criteria 11.1	2021-12-21 16:50:31 +00:00
Paul Chavard	fc90dca920	fix(a11y): criteria 10.5	2021-12-21 16:50:31 +00:00
Paul Chavard	e264472481	fix(procedures): fix check to enable procedure delete	2021-12-16 17:28:42 +00:00
Christophe Robillard	882f92268c	update zone to procedures	2021-12-16 17:20:06 +01:00
François Vantomme	14e0c68266	feat(api particulier): add MESRI field	2021-12-16 16:45:18 +01:00
François Vantomme	f08081abfe	fix(api particulier): remove $def key from pole emploi JSON schema	2021-12-16 16:45:18 +01:00
François Vantomme	115adbec70	style(api particulier): harmonize pole emploi resource name constant	2021-12-16 16:45:17 +01:00
François Vantomme	3d81d4b541	feat(api particulier): add MESRI adapter	2021-12-16 16:45:17 +01:00
François Vantomme	66a9109cd7	feat(api particulier): add MESRI support to sources service	2021-12-16 16:45:17 +01:00
Christophe Robillard	dec1f787a7	edit zone only if zonage feature enabled	2021-12-15 19:37:32 +01:00
Christophe Robillard	829d644c10	group related options in zone select box	2021-12-15 19:37:32 +01:00
simon lehericey	c7f7855f14	avoid phishing	2021-12-15 13:51:49 +01:00
Pierre de La Morinerie	be1ddb59ec	views: localize the stats partial ... Also rename 'procédure' to 'démarches'.	2021-12-14 15:03:22 +01:00
maatinito	0a31c8bc79	refactor date_trunc queries using groupdate gem	2021-12-14 08:50:11 +01:00
maatinito	573b3d39e2	Fix date_trunc sql queries for timezoned forks	2021-12-14 08:50:09 +01:00
Martin	721d926c0d	wip(fix): chdir	2021-12-13 16:37:04 +01:00
mfo	148be50c86	Update app/services/procedure_archive_service.rb ... Co-authored-by: LeSim <mail@simon.lehericey.net>	2021-12-13 16:37:04 +01:00
Martin	f7bc387e44	feat(flipper): use new way of generating archive only on some procedure flipped with new actor :zip_using_binary	2021-12-13 16:37:04 +01:00
simon lehericey	f0b0e7fd9a	Switch to usage of zip unix binary to create archive. Also use a dedicated queue for DelayedJob ... use dedicated archives queue As the used disk space will increase, we want a fined grain control move zip logic in dedicated method zip wip wip fix(spec): pass spec in green tech(improvements): avoid File.delete(folder), favor FileUtils.remove_entry_secure which is safer. Also wrap most of code that open file within blocks so it is cleaned when the block ends. Lastly use attachement.download to avoid big memory pressure [download in chunk, write in chunk] otherwise big file [124>1GO] are loaded in memory. what if we run multiple jobs/download in parallel ? fix(spec): try to retry with grace clean(procedure_archive_service_spec.rb): better retry [avoid to rewrite on open file] lint(things): everything	2021-12-13 16:37:04 +01:00
Martin	4b2e858a1a	fix(mon_avis_embed_validator): enhance regexp	2021-12-13 14:49:40 +01:00
maatinito	9df0d98109	Fix csv download of stats ... https://medium.com/@mitsun.chieh/activerecord-relation-with-raw-sql-argument-returns-a-warning-exception-raising-8999f1b9898a	2021-12-10 16:48:11 +01:00
Paul Chavard	c7b1dc7f87	fix(bulk_messages): destroy bulk messages with procedures	2021-12-09 16:16:40 +01:00
Pierre de La Morinerie	0e35bc609d	notifications: don't preload dossiers on instructeurs ... This request currently times out almost every night in production. It's because although Instructeurs are loaded in batches (default batch size is 1000), loading all dossiers for 1000 instructeurs is slow. Turns out the code executed after this query to compute notifications doesn't even use these dossiers. Indeed it is faster not to preload them: both the initial query and the total treatment time are shorter. Here's a quick benchmark made locally (but using production data): - Before this commit: Benchmark.measure { pp Instructeur.includes(assign_to: { procedure: :dossiers }).where(assign_tos: { daily_email_notifications_enabled: true }).limit(100).m ap(&:email_notification_data) } Only the initial query : 35s Total time : 97s - Without preloading dossiers: Benchmark.measure { pp Instructeur.includes(assign_to: :procedure).where(assign_tos: { daily_email_notifications_enabled: true }).limit(100).m ap(&:email_notification_data) } Only the initial query : 0.08s (400x faster) Total time : 29s (3,3x faster) Plus it doesn't timeout, of course.	2021-12-09 12:10:00 +01:00
Paul Chavard	b67818e425	feat(helpscout): add a tag to messages submited through contact form	2021-12-09 11:47:13 +01:00
Paul Chavard	efd8ddb99e	fix(graphql): do not crash if attestation is nil	2021-12-08 13:12:42 +01:00
simon lehericey	3bdf6b63d9	small wording fixes	2021-12-08 11:19:30 +01:00
François Vantomme	6ab8ac0662	feat (api particulier): add Pole emploi field	2021-12-08 10:36:25 +01:00
François Vantomme	4cfc9f7d86	feat(api particulier): add Pole Emploi adapter	2021-12-08 10:36:11 +01:00
François Vantomme	cfb8c184fe	perf(api particulier): use filter_map instead of map.compact ... https://docs.rubocop.org/rubocop-performance/cops_performance.html#performancemapcompact	2021-12-08 10:36:11 +01:00
François Vantomme	a24cf18c9d	feat (api particulier): add Pole Emploi support to sources service	2021-12-08 10:36:11 +01:00
Pierre de La Morinerie	c75dba701d	lib: replace URI.encode by CGI.escape ... URI.encode was removed in Ruby 3. Fix an error when adding a phone number to a Helpscout ticket.	2021-12-07 15:25:26 +01:00
Paul Chavard	5615baa985	Revert "Merge pull request #6724 from tchak/fix-approximative_expiration_date" ... This reverts commit c95a67d970, reversing changes made to 032989a400.	2021-12-07 13:32:39 +01:00
Paul Chavard	436569b08c	Revert "Merge pull request #6727 from tchak/fix-approximative_expiration_date-again" ... This reverts commit 951f974478, reversing changes made to c95a67d970.	2021-12-07 13:32:27 +01:00
Paul Chavard	48ee830586	fix(dossier): fix approximative_expiration_date again	2021-12-07 13:02:53 +01:00
Paul Chavard	60d4bcc4f7	fix(dossier): fix approximative_expiration_date	2021-12-07 12:47:27 +01:00
François Vantomme	2110ef072c	feat(api particulier): add DGFiP field	2021-12-07 11:03:05 +01:00
François Vantomme	f0913edebd	feat(api particulier): add DGFiP adapter	2021-12-07 11:03:05 +01:00
François Vantomme	97de7c197d	feat(api particulier): add DGFIP support to sources service	2021-12-07 11:03:05 +01:00
Paul Chavard	5e0f8a5816	task(type_de_champ): migrate type_de_champ parent_id	2021-12-06 21:45:54 +01:00
Paul Chavard	09c37435ad	feat(procedure_revision_types_de_champ): add parent_id	2021-12-06 21:45:54 +01:00
Paul Chavard	0036933425	feat(graphql): add commune and departement information to API	2021-12-06 21:01:28 +01:00
Paul Chavard	fcbe364ac8	feat(commune): display departement information on commune champ	2021-12-06 21:01:28 +01:00
Paul Chavard	ed2cbdc966	fix(champ): save departement name without code prefix	2021-12-06 20:58:08 +01:00
Paul Chavard	2ba05bfb4f	fix(dossier): use depose_at instead of en_construction_at	2021-12-06 15:49:17 +01:00
Martin	a9413f9b12	feat(manager): add procedure_expires_when_termine_enabled to administrate	2021-12-06 07:49:59 +01:00
Martin	2778b42f1a	feat(instructeurs/procedures#show): re-align tabs at the start of the container. re-align demander cell content verticaly	2021-12-06 07:20:01 +01:00
Martin	081d5094a9	feat(instructeurs/procedure/dossiers#extend_conservation): add extends duree conservation in action button list, also rewire this action for user [extend by procedure.duree_conservation_dans_ds by default] but force 1.month for instructeur. add new icon for standby based on https://en.wikipedia.org/wiki/Power_symbol	2021-12-06 07:20:01 +01:00
Martin	d8a8d1fdab	feat(instructeur/dossier/header/_expiration_banner): split trads and add dedicated expiration banner for instructeur. also enhance wording to include duree conservation + extension_conservation ... feat(expiration_banner): enhance wording of expiration feat(dossiers/expiration_banner): enhance wording regarding expiration to include duree_conservation_dossiers_dans_ds + extension_conservation, also add spec on expiration_banner for instructeur	2021-12-06 07:05:17 +01:00
Martin	22531560d8	feat(tabs.expirants): re-order so it comes before deleted dossiers	2021-12-06 07:05:17 +01:00
Martin	8e9b15aef4	clean(expiration_banner): dedicated to user not shared	2021-12-06 07:05:17 +01:00
Martin	1bb868714c	fix(spec/lint/review): lint and fix spec of previous commits, also fix based on tchak feedback	2021-12-06 07:05:17 +01:00
Martin	d87f8b57cc	feat(instructeurs/procedures#show): add dossier experiant in procedure#show	2021-12-06 07:05:17 +01:00
Martin	2dfbc70d41	feat(instructeur#dossiers_count_summary): add counter for expirants. ignore brouillon	2021-12-06 07:05:17 +01:00
Martin	ce87878ff0	refactor(traitement.process_expired): move process expired to procedure	2021-12-03 16:32:36 +01:00
Martin	f8a17b2cc4	feat(procedures#index): add dossiers-expirant to instructeur/procedure#index	2021-12-03 16:32:03 +01:00
Christophe Robillard	3265ac2d84	localize zone	2021-12-02 19:24:26 +01:00
Christophe Robillard	9341c787a1	administrateur can add zone to procedure	2021-12-02 19:24:26 +01:00
Christophe Robillard	561f6fb274	add belongs_to zone for procedure	2021-12-02 19:23:05 +01:00
Christophe Robillard	219eaf0d5e	add zone model	2021-12-02 19:16:11 +01:00
Pierre de La Morinerie	b7d17b0989	models: validate that no drop-downs are empty on publishing ... Disallow publishing a procedure containing drop-downs with no selectable values.	2021-12-02 09:00:37 +01:00
Pierre de La Morinerie	e219ec33d8	validators: rename no_empty_repetitions to no_empty_repetition	2021-12-02 09:00:37 +01:00
Pierre de La Morinerie	115ca5e24a	js: don't create invalid menus by default ... When a new "Menu" type de champ is added, it comes pre-filled with a menu title – and nothing else. Which is confusing, and invalid. Instead pre-fill the type de champ with actual values (no titles).	2021-12-02 09:00:37 +01:00
Pierre de La Morinerie	d524beee4e	app: remove :instructeur_bypass_email_login_token from Flipper	2021-12-02 08:51:52 +01:00
Pierre de La Morinerie	ac07f05771	app: use Instructeur.bypass_email_login_token	2021-12-02 08:51:52 +01:00
Paul Chavard	46e2e34b89	fix(stats): remove super admin stats	2021-12-01 18:10:05 +01:00
Martin	725521c3a1	fix(expiration_banner): only show expirations info when flip is enabled ... fix(lint): lint haml fix(spec): enable flipper and allow procedure to receive flipper check when checking banner presence fix(doc): add missing documentation on readme regarding system testing with a visual feedback fix(typo): add missing accent clean(PR): feedback from Tchak, better to wrap feature check for expirability by procedure within dossier.expirable? helper	2021-11-30 16:05:32 +01:00
Kara Diaby	f1525a798f	Avis : display introduction file to experts	2021-11-30 14:27:58 +01:00
Pierre de La Morinerie	28dfc6a1ba	manager: save bypass_email_login_token to both column and feature	2021-11-30 13:41:25 +01:00
Pierre de La Morinerie	99c77046d2	models: improve error message for invalid champs ... Avoid prepending the message with 'Draft revision '	2021-11-30 13:34:41 +01:00
Pierre de La Morinerie	b86dec8251	views: prevent procedure publication on validation error	2021-11-30 13:34:41 +01:00
Pierre de La Morinerie	9db62178d2	views: display revision errors on the procedure dashboard	2021-11-30 13:34:41 +01:00
Pierre de La Morinerie	52b0fbf9b7	models: validate repetitions on publishing	2021-11-30 13:34:41 +01:00
Pierre de La Morinerie	48133c2595	models: don't save the procedure before the state transition ... Otherwise a validation error occurs here instead of on save.	2021-11-30 13:34:41 +01:00
simon lehericey	c4cde500ce	fix acsv	2021-11-30 09:42:45 +01:00
simon lehericey	5a0fb6237f	😭 AASM does not support keyword arguments ... https://github.com/aasm/aasm/issues/672	2021-11-30 09:42:45 +01:00
Pierre de La Morinerie	184a401182	app: rename new_administrateur to administrateurs	2021-11-30 08:49:38 +01:00
simon lehericey	a0c0520502	avoid redirection to a deleted user	2021-11-29 15:27:17 +01:00
Kara Diaby	23677956f3	modify controller	2021-11-29 11:34:31 +01:00
Martin	cf82c030e8	hotfix(scoping): try to avoid requesting archived: false when using termine scope, use state_termine instead	2021-11-26 15:09:53 +01:00
Martin	970e43efb8	feat(stats#index): update Stat model to also query DossierDeleted in stats computation ... tech(question): discard_and_keep_track! ; are we really keeping track with default_scope { kept } ? feat(stats): add DeletedDossier in Stat computations Revert "tech(question): discard_and_keep_track! ; are we really keeping track with default_scope { kept } ?" This reverts commit d1155b7eeaaf1a9f80189e59667e109541fcb089. feat(stats): support deleted_dossiers for last_four_months_hash and cumulative_hash. extract sanitize query & merge hashes in methdos clean(rubocop): lint with rubocop Update db/migrate/20211126080118_add_index_to_deleted_at_to_deleted_dossiers.rb Co-authored-by: LeSim <mail@simon.lehericey.net> fix(rubocop): avoid uneeded allocation fix(migration): add concurrent index with expected synthax fix(brakeman): add ignore message since group date_trunc evaluation is used by only ourself	2021-11-26 13:29:40 +01:00
Kara Diaby	2103f09be1	layout	2021-11-26 09:45:13 +01:00
Kara Diaby	24ba7b6633	modify dossier projection service	2021-11-26 09:45:13 +01:00
kara Diaby	eaac293da3	add a new tab traités on user dossiers	2021-11-26 09:45:13 +01:00
Martin	fdf0f18fda	fix(i18n): wrap text under i18n.t ... i18n(france_connect/*): replace wording with i18n fix(lint): i18n key issue secu(views/france_connect/particulier/merge.html.haml): sanitize france_connect_email just in case fix(brakeman): sanitize FCI.email_france_connect when used with html_safe via an I18n.t, also add exception to brakeman	2021-11-25 17:34:37 +01:00
Martin	febe890d28	fixup! Add confirmation by email when merging DC/FC accounts	2021-11-25 17:34:37 +01:00
Martin	8a315a4ac1	feat(UserMailer.france_connect_merge_confirmation): in addition to distance_of_time_in_words, add exact expiration date	2021-11-25 17:34:37 +01:00
Martin	21894d0a0a	feat(france_connect/particulier#callback): in case the FC email exists as an DC account which is an instructor or and administrator, returns early to new_session_path so he can connect with this existing account	2021-11-25 17:34:36 +01:00
Martin	ff073f8884	Add confirmation by email when merging DC/FC accounts ... feat(fci.confirmation_code): add confirmation code to france_connect_informations feat(user_mailer.france_connect_confirmation_code): add confirmation by email mail method/preview/spec, pointing to merge_mail_with_existing_account (reuse existing method) feat(mail_merge): mail merge feat(merge.cannot_use_france_connect): same behaviour as callback clean(fci.confirmation_code): use same token for mail validation as merge feat(resend_france_connect/particulier/merge_confirmation): resend email with link. also enhance some trads, cleanup halfy finished refacto clean(tech): finalize story by plugging merge_with_new_account to email validation fix(deadspec): was removed fix(spec): broken after last refactoring lint(rubocop): space before parenthesis lint(haml-lint): yoohoooo space before = fix(lint): scss now :D Update app/assets/stylesheets/buttons.scss cleanup feat(france_connect): re-add confirm by email, with an option for confirmation by email instead of only confirmation by email fixup! Add confirmation by email when merging DC/FC accounts fix(lint): haml_spec failure	2021-11-25 17:34:34 +01:00
Paul Chavard	7d189575af	fix(commune): do not display foreign departement when selecting commune	2021-11-25 13:49:57 +03:00
mfo	91c3a8be19	fix(eslint): max columns	2021-11-25 13:43:28 +03:00
Martin	0d486981a6	fix(ComboCOmmunesSearch.typo): fix combo communes search typo	2021-11-25 13:43:28 +03:00
Paul Chavard	d847775c68	feat(traitements): add depose_at to dossiers	2021-11-25 12:57:55 +03:00
Paul Chavard	1f1dd9fce5	fix(traitements): add missing traitements to dossiers when reverting a decision	2021-11-25 12:57:55 +03:00
Pierre de La Morinerie	e5f5440663	models: explicitely save procedure's new revision ... Deep-cloned objects have all their relationships stale. Thus, for a newly deep-cloned revision, `revision.types_de_champs` returns `[]`, even when it actually has associated types de champ. This causes consecutive champs creations and re-ordering to fail in subtle ways, like: ``` procedure.draft_revision.add_type_de_champ(…) procedure.publish_revision! procedure.draft_revision.add_type_de_champ(…) procedure.draft_revision.move_type_de_champ(…) # this will fail ``` As `publish_revision!` created a new stale revision, moving the type de champ fails because not all existing champs are found until the object is refreshed. We don't hit this path in production, because usually only a single operation is made in a request. To fix this, save the new revision before associating it as the draft procedure. (Another option would be to `reload` the revision after creation, but this seems better contained and matches the name of the method.)	2021-11-25 08:49:17 +01:00
mfo	e7d9d047fe	Merge branch 'main' into 6649-etq-usager-instructeur-rendre-la-suppression-plus-visible	2021-11-24 14:07:32 +01:00
simon lehericey	bd4a5c419b	add title to agentconnect page	2021-11-24 12:50:47 +01:00
Paul Chavard	758e7d68e6	fix(graphql): fix and improuve query parsing for logs	2021-11-24 13:23:05 +03:00
Pierre de La Morinerie	60c2718f29	models: remove custom code for file size validation message ... With active_storage_validations 0.9.6, we can use the %{max_size} variable directly in the error message.	2021-11-24 10:06:45 +01:00
Martin	0fd9e15cc1	i18n(expiration_banner): extract test in i18n files	2021-11-23 15:23:22 +01:00
Pierre de La Morinerie	2227dcc1e7	app: remove leftovers of procedure path autocomplete ... We used to pre-validate the procedure, to display in advance if the path could be used. Now that the path autocomplete is long gone, we can remove this kludgy code.	2021-11-23 14:30:21 +01:00
simon lehericey	c5097451ef	add redirect	2021-11-23 14:17:59 +01:00
simon lehericey	5234a1854c	manage AgentConnect callback	2021-11-23 14:17:59 +01:00
simon lehericey	1926a630f9	add agent_connect_id to instructeur	2021-11-23 14:17:59 +01:00
simon lehericey	898df449d4	redirect to AgentConnect	2021-11-23 14:17:59 +01:00
simon lehericey	d2432e34eb	AgentConnect UI	2021-11-23 14:17:59 +01:00
mfo	49bb12a70e	Merge branch 'main' into 6649-etq-usager-instructeur-rendre-la-suppression-plus-visible	2021-11-23 11:05:51 +01:00
Martin	b6adf5fc72	feat(dossiers/show): enhance header with expirations message/banner. also ensure consistent design between dossier states ... fix(spec): broken due to last refactoring spec(dossier.extend_conservation): add system spec lint(ruby): still not yet ready for auto lint in IDE...	2021-11-23 05:50:25 +01:00
Martin	2a87b9bf89	feat(users/dossiers/*): rework header for consistent design, add some utils spacers	2021-11-22 14:46:10 +01:00
Pierre de La Morinerie	859a147c49	api: return error cause on parse error ... Currently, when a query can't be parsed, the error is: - logged to Sentry (which is useless to us), - returned as a generic 'Internal Server Error' (which is useless to the user who made the query). With this commit, the error is instead ignored from our logs (because it is a user error), but the parse error details are returned to the user, with the following format: > {'errors': [{'message': 'Parse error on ")" (RPAREN) at [3, 23]'}]}	2021-11-19 15:15:10 +01:00
Martin	3d1533dee9	feat(users/dossiers?statut=dossiers-expirant): add dossiers-expirant tab	2021-11-19 15:14:39 +01:00
Martin	a9978fb70b	clean(code): move mfo comment to its rightful place	2021-11-19 14:34:20 +01:00
Martin	608a85148f	feat(Dossier.close_to_expiration): add method to find any kind of dossier close to expiration [reuse previous scopes], add missing spec to termine_close_to_expiration, complement spec for each kind of expiration scope with general close_to_expiration spec	2021-11-19 14:28:54 +01:00
Martin	d8257284ef	tech(refactor): extract states close to expiration within their scope.	2021-11-19 14:07:47 +01:00
Martin	1d721f14a0	fix(spec): get back to stable state	2021-11-19 12:36:03 +01:00
Martin	646459a1da	fix(spec): at least let us start from a green suite	2021-11-18 18:15:57 +01:00
Paul Chavard	df474b60cf	WIP	2021-11-18 18:58:17 +03:00
Paul Chavard	ae09b37e72	fix(champs): save departement info on champ commune	2021-11-17 14:52:47 +03:00
mfo	82b23b92c0	Merge branch 'main' into 6624/etq-instructeur-je-souhaite-supprimer-des-messages-envoyes-par-erreur	2021-11-17 05:41:56 +01:00
Paul Chavard	716a859c93	fix(profile): prevent crashing on renew token action	2021-11-16 20:01:56 +03:00
Paul Chavard	e74d599042	feat(procedure): remove duree_conservation_dossiers_hors_ds	2021-11-16 19:55:56 +03:00
Paul Chavard	65e59b8dcd	fix(procedure): allow to modify duree_conservation_dossiers_dans_ds after publication	2021-11-16 19:55:56 +03:00
Paul Chavard	406c5a61cc	fix(dossier): fix dossier traitements display	2021-11-16 19:00:20 +03:00
Paul Chavard	04e67ea20a	fix(dossier): add instructeur email to traitements when available	2021-11-16 19:00:20 +03:00
mfo	1d174df2ec	Merge branch 'main' into 6624/etq-instructeur-je-souhaite-supprimer-des-messages-envoyes-par-erreur	2021-11-16 16:37:15 +01:00
Martin	f0950b592b	clean(CommentaireService): extract soft delete within controller. returning an instance with an error[:base] is not persisted with validation : avoid poluting stuff	2021-11-16 16:13:11 +01:00
Paul Chavard	3400c4c628	fix(champs): attach piece justificative	2021-11-16 17:57:41 +03:00
Martin	8bbd77f89f	refactor(mail.delay): use simplier implementation using after_action to prevent email delivery with delay	2021-11-16 15:12:05 +01:00
Martin	0aecc301c9	refactor(Commentarie.soft_delete): use discard	2021-11-16 14:28:38 +01:00
Paul Chavard	7914775809	feat(routage): administrateur can disable routage ... fix #6627	2021-11-16 11:49:51 +03:00
simon lehericey	e3c1e19424	include hidden dossier in merge	2021-11-15 23:14:41 +01:00
mfo	08350f394e	feat(mails): send it on mailer queue	2021-11-15 16:19:46 +01:00
Martin	ddabed0c7e	fix(refactor): continue to revert to past implementation. now use a job instead of calling deliver_later(wait: 5.minutes) [was not a satisfying implementation]	2021-11-15 15:45:48 +01:00
Martin	5534c3fbd6	fix(refactor): forgot to cleanup former implementation	2021-11-15 15:43:51 +01:00
Martin	5b6bb5171c	tech(lint): rubocopify	2021-11-15 15:42:20 +01:00
Martin	c68fa2d7f3	feat(Commentaire.notify_user): wait 5 minutes before sending email to user when instructor write a commentaire. leaving some space for instructor to destroy his message	2021-11-15 15:38:57 +01:00
Martin	46fc956de3	fix(refactor): forgot to pass var, classy	2021-11-15 15:01:56 +01:00
Martin	a74ca8ad39	fix(spec): scope out time as reference for time comparission, hope not a matter of precision	2021-11-15 14:55:35 +01:00
Martin	f1293814a3	fix(spec): apparently we do store time with zone	2021-11-15 14:35:43 +01:00
Martin	4042d51d1a	tech(lint): rubocopify	2021-11-15 14:17:57 +01:00
Martin	d4c74b5621	feat(rc.1): refine with better translations, better design	2021-11-15 14:15:05 +01:00
Martin	3b78a9d81a	feat(rc): first stable	2021-11-15 13:53:32 +01:00
simon lehericey	15d4c4c7b0	small fix on profil	2021-11-15 13:51:26 +01:00
Martin	8b931a57d4	feat(CommentairesController#destroy): implement destroy endpoint using CommentaireService	2021-11-15 13:18:10 +01:00
Martin	9a8ec1087c	feat(commentaire.soft_delete): wrap deletion behaviour in service	2021-11-15 12:43:53 +01:00
Martin	5b72bdec7e	fix(Commentaire.sent_by?): &.email compared to nil could sent by true when nil==nil, avoid this one	2021-11-15 12:01:56 +01:00
Martin	b03dc6ad5d	wip(dossiers/messages/_message): poc destroy button with expected ACL support	2021-11-15 11:30:41 +01:00
Paul Chavard	da47f491b3	fix(dossier): nullify close to expiration notice timestamps when changing state	2021-11-11 12:52:58 +01:00
Paul Chavard	faa235d205	fix(dossier): destroy operation logs when destroying an expired dossier	2021-11-11 09:37:09 +01:00
Paul Chavard	71939c650b	fix(export): remove wrong columns from repetition spreadsheets ... This fix prevent repetition children types de champ from being pulled from cloned procedures. stable_id is stable across revisions but also across cloned procedures.	2021-11-10 20:45:32 +01:00
Peng-Fei DONG	dc560479ec	clean css in page deleted_dossiers for show the dossier table	2021-11-09 12:45:41 +01:00
kara Diaby	9ee9389ba1	add the good retry_on StaleObjectError	2021-11-05 13:32:21 +01:00
simon lehericey	17d131b3cc	add has_may requested_merge_from	2021-11-04 16:10:09 +01:00
simon lehericey	9041e201e8	one merge at a time	2021-11-04 16:10:09 +01:00
simon lehericey	adfac5fb7b	improve ui	2021-11-04 16:10:09 +01:00
simon lehericey	b160086cc5	update update_email to allow merge	2021-11-04 16:10:09 +01:00
simon lehericey	652b8367be	accept or refuse merge	2021-11-04 16:10:09 +01:00
simon lehericey	6625c6bac3	add requested_merge_into column in user table	2021-11-04 16:10:09 +01:00
simon lehericey	894e8fdd47	move update_email check to before_action	2021-11-04 16:10:09 +01:00
Paul Chavard	ba0211ba52	feat(champ): ask for departement before asking for commune	2021-11-04 11:55:25 +01:00
Paul Chavard	122cdacbc2	fix(avis): destroy avis for discarded en_construction dossiers	2021-11-04 10:12:44 +01:00
Paul Chavard	f6b8689a97	fix(revisions): fix repetitions export with revisions	2021-11-03 18:20:48 +01:00
Paul Chavard	0e2f09dd6f	fix(dossiers): wrap dossier discard in a transaction ... By doing this we ensure that deleted_dossier are not created when dossier is not discarded	2021-11-02 18:17:35 +01:00
Paul Chavard	7ef73f13e4	fix(grope_instructeur): can not destroy groupe_instructeur with discarded dossiers	2021-11-02 12:15:24 +01:00
Paul Chavard	3c2515ce6d	feat(graphql): add graphql_operation to rails logs	2021-11-02 12:02:00 +01:00
kara Diaby	87ed764f9b	enlarge procedure title in user dossier	2021-10-29 14:05:49 +02:00
Paul Chavard	da49a6447f	refactor(repetition): optimize and add a transaction around repetition add row	2021-10-28 14:54:33 +02:00
Paul Chavard	f9a8fb4ada	fix(repetition): prevent rage clicks on add row button	2021-10-28 14:54:32 +02:00
Paul Chavard	c4b93f8d4a	fix(groupe_instructeur): unfollow dossiers when removed from groupe instructeur	2021-10-28 14:45:52 +02:00
simon lehericey	8fe1e2bf71	wrap merge in transaction	2021-10-28 14:39:13 +02:00
simon lehericey	7935e42109	Add merge log	2021-10-28 14:39:13 +02:00
simon lehericey	3328c9a132	merge move invite as well	2021-10-28 14:39:13 +02:00
simon lehericey	f2ccb39912	merge destroys the old role and account	2021-10-28 14:39:13 +02:00
simon lehericey	1401d163ba	add dependent_destroy to user instructeur / admin / expert roles	2021-10-28 14:39:13 +02:00
simon lehericey	c725999582	move merge method to user	2021-10-28 14:39:13 +02:00
Paul Chavard	1393b7b07b	fix(rebase): fix repetition champ rebase	2021-10-28 13:27:53 +02:00
Paul Chavard	d659595cde	fix(typo): addresse -> adresse	2021-10-27 18:59:18 +02:00
Paul Chavard	6599f9a992	fix(bulk_messages): disable pj on bulk messages	2021-10-27 15:41:53 +02:00
Paul Chavard	7ebc439630	refactor(drop_down_list_champ): other option	2021-10-27 12:01:15 +02:00
Paul Chavard	8154daf847	refactor(drop_down_list_champ): other option	2021-10-27 12:00:39 +02:00
kara Diaby	f1f2b76a3d	revisions	2021-10-27 12:00:39 +02:00
kara Diaby	c2fcd3992d	add other option for dropdown select	2021-10-26 16:11:15 +02:00
kara Diaby	0e65916e44	add other option for dropdown radio	2021-10-26 16:11:15 +02:00
kara Diaby	dc35d9521f	add other option to liste deroulante champ	2021-10-26 16:11:15 +02:00
Paul Chavard	6e8e0c7b6b	feat(type_de_champ): reflect changes of secondary labels and descriptions	2021-10-26 12:18:01 +02:00
Paul Chavard	d308448f02	feat(type_de_champ): add secondary label and description do linked drop downs	2021-10-26 12:18:01 +02:00
Paul Chavard	579dce8eb6	refactor(user): wrap user destruction in a transaction	2021-10-26 11:16:29 +02:00
Paul Chavard	d5d3995dad	fix(dossier): fix dossier.avis cascade	2021-10-26 11:16:29 +02:00
Paul Chavard	4aa573a75d	fix(transfer): remove discarded dossiers from transfers	2021-10-26 10:41:01 +02:00
Pierre de La Morinerie	d0e87a08cf	services: cache zxcvbn dictionaries per-thread ... Before, every time a password was tested, the dictionaries were parsed again by zxcvbn. Parsing dictionaries is slow: it may take up to ~1s. This doesn't matter that much in production, but it makes tests very slow (because we tend to create a lot of User records). With this changes, the initializer tester is shared between calls, class instances and threads. It is lazily loaded on first use, in order not to slow down the application boot sequence. This uses ~20 Mo of memory (only once for all threads), but makes tests more that twice faster. For instance, model tests go from **8m 21s** to **3m 26s**. NB: An additionnal optimization could be to preload the tester on boot, before workers are forked, to take advantage of Puma copy-on-write mechanism. In this way all forked workers would use the same cached instance. But: - We're not actually sure this would work properly. What if Ruby updates an interval ivar on the class, and this forces the OS to copy the whole data structure in each fork? - Puma phased restarts are not compatible with copy-on-write anyway. So we're avoiding this optimisation for now, and take the extra 20 Mo per worker.	2021-10-25 12:04:56 +02:00
Paul Chavard	1561ea82f6	fix(transfer): manually nullify staled transfers references	2021-10-21 13:54:26 +02:00
Paul Chavard	2a3a9dd822	feat(revisions): rebase dossiers brouillons	2021-10-20 17:26:09 +02:00
Paul Chavard	09a09d3fcf	feat(revisions): add rebased_at to champs	2021-10-20 17:26:09 +02:00
Paul Chavard	67e98f79c9	feat(revisions): add stable_id to changes	2021-10-20 17:25:34 +02:00
Paul Chavard	1ca8192864	perf(export): load dossiers.champs in batches	2021-10-20 16:52:38 +02:00
lydiasan	6f9c3abfbc	i18n: display language selector on non-french accept-languages	2021-10-19 16:41:36 +02:00
simon lehericey	d19ad2840c	rename preexisting to targeted, remove duplicated test	2021-10-19 16:12:42 +02:00
simon lehericey	52b7e85954	merge administrateur in user_controller	2021-10-19 16:12:42 +02:00
simon lehericey	866df74706	merge admin	2021-10-19 16:12:42 +02:00
simon lehericey	44c880adc4	allow instructeur and administrateur to change their email to legit domain (#6550)	2021-10-19 15:54:57 +02:00
Paul Chavard	8fa544e176	feat(manager): bring back add administrateur	2021-10-19 12:06:31 +02:00
simon lehericey	f54dfe6ead	Do not raise error if user is nil ... I do not get when it happens	2021-10-19 11:21:24 +02:00
simon lehericey	46fd15416b	add end to end test	2021-10-14 14:47:50 +02:00
simon lehericey	bb83fd2f18	To make an old test work, no idea	2021-10-14 14:47:50 +02:00
simon lehericey	933d7b8c8d	merge with another preexisting account	2021-10-14 14:47:50 +02:00
simon lehericey	ce40e1127d	merge with another new account	2021-10-14 14:47:50 +02:00
simon lehericey	19f81b594b	merge with an existing account by using the password	2021-10-14 14:47:50 +02:00
simon lehericey	218e4633a9	securely retrieve fci	2021-10-14 14:47:50 +02:00
simon lehericey	f7299da1e7	launch merge process if an unlinked DS account with the same email exists	2021-10-14 14:47:50 +02:00
simon lehericey	f6879eba60	associate_user take a target email	2021-10-14 14:47:50 +02:00
simon lehericey	09f828a6a2	create_merge_token!	2021-10-14 14:47:50 +02:00
simon lehericey	34862f41e0	Add fci valid_for_merge	2021-10-14 14:47:50 +02:00
simon lehericey	2e118a8f5b	allow unattached fci	2021-10-14 14:47:50 +02:00
simon lehericey	461b774188	a password input must not be that wide	2021-10-14 14:47:50 +02:00
simon lehericey	6e6635560f	Add merge token to FCI	2021-10-14 14:47:50 +02:00
simon lehericey	6826bf03b0	Sign in with a user linked by france connect sub (openid) ... instead of looking linked user by email because : - follows FC recommendation to fetch ds account by openid - the email is not a valid key as many user can share the same FCI email. The following scenario is now working A user A (email: 1@mail.com) uses FC to connect to DS => It is connected as 1@mail.com Another user B (email: generic@mail.com) uses FC to connect => It is connected as generic@mail.com The first user A change its FC email to generic@mail.com and connect to DS => It is still connected as 1@mail.com	2021-10-14 14:47:50 +02:00
simon lehericey	06dee2e023	refactor controller to avoid return	2021-10-14 14:47:50 +02:00
simon lehericey	5aaf46258a	remove obsolete devise scope	2021-10-14 14:47:50 +02:00
Paul Chavard	4caf2f9592	fix(champs): remove redundant description	2021-10-13 13:55:09 +02:00
Pierre de La Morinerie	9be16a1208	views: rename the procedure_publish_label helper ... The new text makes more sense.	2021-10-12 16:25:11 +02:00
Pierre de La Morinerie	50b1d4ce28	views: make france-connect-information more compact ... Otherwise it takes a lot of space in the form.	2021-10-12 16:25:01 +02:00
simon lehericey	87de9e38c6	allow draft to be saved with invalid cnaf champ	2021-10-12 14:27:20 +02:00
simon lehericey	35c7f05a0a	source service supports unknown scope	2021-10-12 14:27:20 +02:00
simon lehericey	ecc26897e2	add end to end spec	2021-10-12 14:27:20 +02:00
simon lehericey	7aee944daa	show cnaf tdc when procedure is compatible	2021-10-12 14:27:20 +02:00
simon lehericey	7072993721	a form can upload numero_allocataire and code_postal	2021-10-12 14:27:20 +02:00
simon lehericey	57a7f82a8f	add cnaf ui	2021-10-12 14:27:20 +02:00
simon lehericey	40d0cfcdc4	add champ validation	2021-10-12 14:27:20 +02:00
simon lehericey	c76d1043fa	add cnaf champ	2021-10-12 14:27:20 +02:00
simon lehericey	354735ace4	add champ value_json jsonb column	2021-10-12 14:27:20 +02:00
simon lehericey	d68129b34d	add cnaf type de champ	2021-10-12 14:26:40 +02:00
simon lehericey	b69dafc3d4	CNAF in lowercase	2021-10-12 14:26:40 +02:00
simon lehericey	17a2b5dc53	fix a strange encoding error	2021-10-12 14:26:40 +02:00
Pierre de La Morinerie	0b02fce5e4	jobs: move ActiveJobLogSubscriber out of initializers ... This is a class of its own, it doesn't need to be in the initializers.	2021-10-12 11:40:19 +02:00
simon lehericey	7c65571fca	add case when the old_expert or old_instructeur is nil	2021-10-12 11:04:06 +02:00
simon lehericey	d7e621d167	beef up the merge methods	2021-10-07 15:51:31 +02:00
simon lehericey	77d14d4a60	forbid admin merge yet	2021-10-07 15:51:31 +02:00
simon lehericey	5009c583ea	Add notice when merging account	2021-10-07 15:51:31 +02:00
simon lehericey	a480b31eb5	merge expert	2021-10-07 15:51:31 +02:00
simon lehericey	136f29524e	merge instructeur	2021-10-07 15:51:31 +02:00
simon lehericey	9a6a53349f	simple cases when the preexisting targeted account does not have instructeur or profile profile	2021-10-07 15:51:31 +02:00
Paul Chavard	4a947f9135	feat(manager): add become administrateur button in manager (with 24h expiration)	2021-10-07 11:32:12 +02:00
Paul Chavard	9d5c5447c2	fix(dossier): do not attempt to destroy transfers when a dossier is destroyed ... we had a dependent option on both sides of a relationship which created race conditions	2021-10-06 17:51:09 +02:00
kara Diaby	13883393eb	modify layout	2021-10-06 16:41:08 +02:00
Paul Chavard	d3c1941fbe	fix(dossier): never write dossier log on dossiers brouillons	2021-10-05 17:56:51 +02:00
kara Diaby	e4b61eae21	layout	2021-10-05 15:37:29 +02:00
kara Diaby	177074bf32	css	2021-10-05 15:37:29 +02:00
kara Diaby	9c9eeb8e76	modify groupe instructeurs controller$	2021-10-05 15:37:29 +02:00
kara Diaby	0bd879ec9b	modify pj service	2021-10-05 15:00:21 +02:00
kara Diaby	6ef5b5d474	modify downloable file	2021-10-05 15:00:21 +02:00
kara Diaby	bfee9c275c	layout	2021-10-05 15:00:21 +02:00
kara Diaby	6d89d914e2	modify expert avis controller	2021-10-05 15:00:21 +02:00
simon lehericey	d8112b9548	[Fix #6491] ui	2021-10-05 12:05:43 +02:00
simon lehericey	1000417bc9	update notifications_for_dossier used in dossier show	2021-10-05 12:05:43 +02:00
simon lehericey	65911b7680	update with_notifications dossiers scope (used in procedure index and show)	2021-10-05 12:05:43 +02:00
simon lehericey	f662b28baf	update identity_updated_at column when user identity change	2021-10-05 12:05:43 +02:00
simon lehericey	3a878dfc04	add identity_updated_at column to dossier	2021-10-05 12:05:43 +02:00
Pierre de La Morinerie	f854e3af63	controllers: use ACSV to import groupe instructeurs ... Unlike `CSV`, `ACSV` auto-detect the file encoding and separator type.	2021-10-05 10:58:15 +02:00
Peng-Fei DONG	dee536fca1	app: localize CSV import for groupe instructeurs	2021-10-05 10:58:15 +02:00
simon lehericey	9679e233cd	[Fix #6512] admin preview in new tab	2021-10-05 10:47:58 +02:00
simon lehericey	e4484eb6d9	discard expert not found job error	2021-10-04 12:57:37 +02:00
simon lehericey	64351d0287	[Fix #6504] Fix exception raised when deleting a transfer	2021-10-01 12:11:03 +02:00
Pierre de La Morinerie	b2774ed2f6	js: fix pays API request on older Edge and Safari ... The /api/pays API requires user authentication. However older versions of Edge and Safari don't transmit cookies by default during a `fetch` request. Use the `credentials: 'same-origin'` option explicitely to fix the countries list.	2021-09-30 16:21:24 +02:00
Pierre de La Morinerie	f01e4ed6ef	models: document upstream PR about file size validation	2021-09-30 15:45:30 +02:00
kara Diaby	7594d8470c	Fixe une faute d'orthographe dans une notification	2021-09-30 11:45:24 +02:00
Pierre de La Morinerie	2908f2bdba	assets: fix background of translate-icon ... The background was white, instead of being transparent.	2021-09-28 16:42:04 +02:00
kara Diaby	eb951c75e4	change stats colors	2021-09-28 14:49:24 +02:00
kara Diaby	b5e699e8b8	change svg icons color	2021-09-28 14:49:24 +02:00
kara Diaby	1f2935719c	change blue color on all the app	2021-09-28 12:33:01 +02:00
kara Diaby	99cfd4f42c	adapte la page d'accueil au design system de l'état	2021-09-28 12:33:01 +02:00
simon lehericey	6eb10ecde5	display tdc alphabetically 🎉	2021-09-27 15:45:37 +02:00
simon lehericey	f55db98e97	rework type de champ type	2021-09-27 15:45:37 +02:00
Paul Chavard	c288739f13	Update app/helpers/procedure_helper.rb ... Co-authored-by: LeSim <mail@simon.lehericey.net>	2021-09-27 15:06:17 +02:00
Paul Chavard	7deedf8245	feat(refactor): unify dossiers header	2021-09-27 15:06:17 +02:00
Paul Chavard	357c684688	feat(routage): self managing instructeurs	2021-09-27 15:06:17 +02:00
Paul Chavard	d4e8158887	feat(routing): add instructeurs_self_management_enabled to procedures	2021-09-27 15:06:17 +02:00
Paul Chavard	5933194149	feat(log): stop logging user emails ... fix #6485	2021-09-27 14:56:00 +02:00
simon lehericey	57604b9c89	add schema validations	2021-09-22 12:08:24 +02:00
simon lehericey	75043070da	add CNAFAdapter	2021-09-22 12:08:24 +02:00
simon lehericey	a7651e3772	add api composition_familiale	2021-09-22 12:08:24 +02:00
simon lehericey	ceb09c5967	api remove useless symbolize	2021-09-22 12:08:24 +02:00
simon lehericey	07962cc2c7	service: match remote keys	2021-09-22 12:08:24 +02:00
Ismael MOUSSA S	36dc9c2ca2	Add File Validation concern after refactoring	2021-09-21 12:11:20 -05:00
Ismael MOUSSA S	7c7c9c9ea4	Fix file size validation message	2021-09-21 12:11:20 -05:00
Ismael MOUSSA S	bdbb4deb87	ADD FILE_MAX_SIZE constant to set allow file size limit	2021-09-21 12:04:56 -05:00
simon lehericey	1446660ca3	an api_particulier_token change erases previous api_particulier_sources	2021-09-21 11:21:10 -05:00
simon lehericey	2e1bed8748	an admin can save its sources	2021-09-21 11:21:10 -05:00
simon lehericey	8d747ff16e	add sanitize method to service	2021-09-21 11:21:10 -05:00
Pierre de La Morinerie	6656d1130b	i18n: refactor admin support locales ... This allow i18n-tasks to better detect dynamic keys.	2021-09-21 10:44:20 -05:00
Pierre de La Morinerie	f9220891a7	i18n: refactor user support locales ... This allow i18n-tasks to better detect dynamic keys.	2021-09-21 10:44:20 -05:00
Pierre de La Morinerie	274b92c453	i18n: remove simple_form locale files ... We don't even use simple_form.	2021-09-21 10:44:20 -05:00
Pierre de La Morinerie	8748b6f494	i18n-tasks: add hint for default_i18n_subject in mailers	2021-09-21 10:44:20 -05:00
Pierre de La Morinerie	eef90efd49	app: fix exception during password reset when the token has expired	2021-09-21 10:30:09 -05:00
simon lehericey	a7ec77f0a8	do not display the action for instructeur	2021-09-20 13:58:11 +02:00
simon lehericey	75481a644c	Add confirm alert	2021-09-20 13:58:11 +02:00
simon lehericey	7239657a75	[Fix #6481] a user see its waiting transfers	2021-09-20 13:58:11 +02:00
simon lehericey	c34476a766	a user can transfer all its dossier	2021-09-20 13:58:11 +02:00
Paul Chavard	c9accbf5a5	refactor(i18n): localize routage description	2021-09-18 11:51:27 +02:00
Paul Chavard	4db059a54c	Update app/views/new_administrateur/groupe_instructeurs/_routing.html.haml ... Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com>	2021-09-18 11:22:35 +02:00
Paul Chavard	0c5c8faf16	feat(routage): enable routage for everyone	2021-09-18 11:22:35 +02:00
Paul Chavard	0ff62c5a5e	feat(routage): add routing_enabled to procedures	2021-09-18 11:22:35 +02:00
Paul Chavard	8b4bef2816	refactor(routage): simplify goupe_instructeur assign code	2021-09-18 11:21:26 +02:00
Paul Chavard	eea6b961d7	refactor(routage): remove administrateur_routage feature flag	2021-09-18 11:21:26 +02:00
simon lehericey	cfebc4698a	add link to sources UI	2021-09-17 13:50:23 +02:00
simon lehericey	2c13f70cd5	redirect to sources after updating token	2021-09-17 13:50:23 +02:00
simon lehericey	5dbd81ebeb	show api particulier sources	2021-09-17 13:50:23 +02:00
simon lehericey	8327c6fd0c	add ApiParticulier::Service::Sources	2021-09-17 13:50:23 +02:00
simon lehericey	b000590d81	add api particulier sources to procedure	2021-09-17 13:50:23 +02:00
Peng-Fei DONG	2b8f7f13a9	check SENDINBLUE_ENABLED when show the link	2021-09-16 15:37:31 +02:00
Pierre de La Morinerie	715b5ea6d8	i18n: move controller keys to the proper scope	2021-09-16 07:59:19 -05:00
Pierre de La Morinerie	423deb3c3a	i18n: fix invalid i18n key in the admin section	2021-09-16 07:51:56 -05:00
Pierre de La Morinerie	e6b044531d	i18n: fix invalid i18n-tasks-hint	2021-09-16 07:51:56 -05:00
Pierre de La Morinerie	f1fa84c12a	i18n: remove unused i18-tasks-hint	2021-09-16 07:51:56 -05:00
Pierre de La Morinerie	446738fbbf	i18n: make dynamic scopes explicit ... This fixes i18n-tasks not being able to recognize the scopes.	2021-09-16 07:51:56 -05:00
Pierre de La Morinerie	1eefc151bc	i18n: move locale scope just after the key name ... It helps i18n-tasks to understand the scope, and not report errors about a missing key.	2021-09-16 07:51:56 -05:00
Pierre de La Morinerie	95d1cd6992	i18n: cleanup gender locales ... The dot in the localized key messes up with i18n-tasks, and causes false positives for missing strings.	2021-09-16 07:51:56 -05:00
simon lehericey	1d06c15ac0	save api particulier scopes	2021-09-16 09:49:16 +02:00
simon lehericey	6c6205e188	a cloned procedure to a different admin does not keep api_particulier token and scopes	2021-09-16 09:30:11 +02:00
simon lehericey	2d2ae3a878	add api particulier scopes to procedure	2021-09-16 09:30:11 +02:00
simon lehericey	7ee360df30	add logic to detect empty scopes	2021-09-16 09:09:34 +02:00
Pierre de La Morinerie	745e19bb8e	localize	2021-09-16 09:07:47 +02:00
simon lehericey	69bb174e29	add feature flipped link to add api particulier token ... Co-authored-by: François VANTOMME <akarzim@gmail.com>	2021-09-15 14:56:42 +02:00
simon lehericey	ee6d19e3ee	an admin can save it's api particulier token ... Co-authored-by: François VANTOMME <akarzim@gmail.com>	2021-09-15 14:56:42 +02:00
simon lehericey	4c0dd43055	add jetons particulier index page ... Co-authored-by: François VANTOMME <akarzim@gmail.com>	2021-09-15 14:37:04 +02:00
simon lehericey	87cb16093f	fetch token introspection ... Co-authored-by: François VANTOMME <akarzim@gmail.com>	2021-09-15 14:37:04 +02:00
Peng-Fei DONG	1979c44f9c	set OTP: Enable or Disable	2021-09-09 10:25:15 -05:00
Pierre de La Morinerie	4a71b1d202	app: remove former password complexity views ... The old component is now unused and ca be removed.	2021-09-09 09:40:40 -05:00
Pierre de La Morinerie	e5f449b595	devise: unify password reset views ... By default, Devise will look for views: 1. First in `views/resource/passwords/…`, 2. Then in `views/devise/passwords/…` if not found. By moving the views to `views/devise`, we avoid having a partial in `views/shared` that we need to include manually, and instead let Devise do the job automatically.	2021-09-09 09:40:40 -05:00
Pierre de La Morinerie	80f9d4adc0	devise: use password_strength component in SuperAdmin::PasswordsController	2021-09-09 09:40:39 -05:00
Pierre de La Morinerie	62e4f7ee32	devise: use password_complexity in User::PasswordsController ... This fixes the password strength meter no longer being displayed when an admin changes their password.	2021-09-09 09:40:39 -05:00
Pierre de La Morinerie	ed8b19d2eb	app: use password_complexity in Administrateurs::ActivateController	2021-09-09 09:40:39 -05:00
Pierre de La Morinerie	428ca8755f	app: add a password_complexity component ... This component will replace the previous `password_field` component.	2021-09-09 09:40:39 -05:00
Pierre de La Morinerie	e97b7164dd	models: extract password complexity to a concern	2021-09-09 09:40:39 -05:00
Pierre de La Morinerie	02bdfef893	devise: cleanup Users::PasswordController	2021-09-09 08:03:34 -05:00
Paul Chavard	3235f42a63	feat(dossier): add dossier transfers UI	2021-09-08 15:10:43 +02:00
Paul Chavard	5985755229	feat(dossier): add purge stale dossier transfers job	2021-09-08 14:39:46 +02:00
Paul Chavard	46226b7930	fix(i18n): use size instead of count in dossier mailers	2021-09-08 14:39:46 +02:00
Paul Chavard	d6cbdf2a48	feat(dossier): add dossier transfer models	2021-09-08 14:39:46 +02:00
Paul Chavard	44eb0ada4f	fix(i18n): add Kosovo to countries list ... Kosovo is not part of ISO 3166 as of time of writing. https://en.wikipedia.org/wiki/ISO_3166-2:RS#cite_ref-1	2021-09-08 12:11:25 +02:00
Paul Chavard	a7ec43a21e	fix(i18n): fix email previews	2021-09-08 09:21:19 +02:00
Paul Chavard	ef12ded3ed	i18n: fix localization of notify_revert_to_instruction email	2021-09-08 09:21:19 +02:00
Paul Chavard	c8d8976a7c	i18n: fix localization of notify_new_answer email	2021-09-08 09:21:19 +02:00
Pierre de La Morinerie	f8d7b7b1e3	i18n: fix localization of notify_new_draft email	2021-09-08 09:21:19 +02:00
Pierre de La Morinerie	4f33a7b72e	js: improve auto-save-controller documentation	2021-09-07 16:45:52 -05:00
Pierre de La Morinerie	ad8dcc7f7d	js: don't report autosave failures that are timeouts ... This prevents spamming Sentry with "[Autosave] Error: 0" messages.	2021-09-07 16:45:52 -05:00
Pierre de La Morinerie	8dce7d59ed	js: redirect to sign-in when a ujs link_to receives a 401 ... Before, when a 401 was received by a ujs-enabled link (like `link_to …, method: :delete, data: { remote: true }`, rails-ujs tried to insert the response text as a Javascript script. As the script was something like `Please sign-in`, which is not valid Javascript, the browser would throw an "Unexpected token" error. The typical use-case is: 1. The user open a form in a tab, 2. The user disconnects in another tab, 3. In the first tab, the user clicks on a remote "Delete" link_to In that case the browser raised an error in the console (and in Sentry), but the user would see nothing. With this commit, all 401 ujs errors are turned into redirects to the sign-in page. Fix https://sentry.io/organizations/demarches-simplifiees/issues/2522512693/activity/	2021-09-07 16:45:52 -05:00
Pierre de La Morinerie	255c00c174	js: ignore a new variant of the same warning	2021-09-07 16:45:52 -05:00
Pierre de La Morinerie	905fca0bd3	models: ensure Champs::Pays#to_s is always a string ... Before this, the result of `Champs::Pays#to_s` could be `nil`, which would break various things (like the PDF rendering of these champs).	2021-09-07 10:47:18 -05:00
Paul Chavard	74e277d0a2	feat(graphql): add an option to dossier state change mutations to disable notifications	2021-09-07 14:21:48 +02:00
Paul Chavard	96cbbc0192	fix(virus scan): prevent virus scan on archives and signatures uploads	2021-09-07 14:21:48 +02:00
Paul Chavard	084e48c8e3	fix(dossier_projection_service): select external_id on champs	2021-09-07 14:07:55 +02:00
simon lehericey	367f508e2e	linked_drop_down_list: empty primary => empty secondary	2021-09-07 10:09:18 +02:00
Paul Chavard	6a5a8233b5	feat(i18n): send dossier emails with its user locale and improuve translations	2021-09-07 09:51:23 +02:00
Paul Chavard	cd9f7df502	feat(i18n): send dossier notifications with its user locale	2021-09-07 09:51:23 +02:00
Paul Chavard	34b1418868	feat(i18n): save locale on user	2021-09-07 09:51:23 +02:00
Paul Chavard	ff7fa4d895	feat(i18n): expose locale on dossier and deleted_dossier	2021-09-07 09:51:23 +02:00
Paul Chavard	f1ff6da81b	feat(i18n): add locale to user	2021-09-07 09:47:01 +02:00
Pierre de La Morinerie	8bb283d977	app: delete old Admin::ProceduresController	2021-09-02 14:51:31 -05:00
Pierre de La Morinerie	a004ac59df	app: move archive to NewAdministrateur::ProceduresController	2021-09-02 14:51:31 -05:00
Pierre de La Morinerie	e7c8a9fff5	app: move clone to NewAdministrateur::ProceduresController	2021-09-02 14:51:31 -05:00
Pierre de La Morinerie	3e83ad454f	app: move new_from_existing to NewAdministrateur::ProceduresController	2021-09-02 14:51:31 -05:00
Pierre de La Morinerie	7729385d89	controllers: remove dead code on Admin::ProceduresController ... This code has been migrated to NewAdministrateur::ProceduresController.	2021-09-02 14:51:26 -05:00
Pierre de La Morinerie	3fc934c8fb	app: remove leftovers of publish_validate route ... The correponding code and feature have been removed a while ago.	2021-09-02 14:50:41 -05:00
Pierre de La Morinerie	0f9d7d6b8c	app: remove old Admin::InstructeursController ... It was only hosting the deprecated "Instructeurs globally attached to this admin", which wasn't used anywhere in the app anymore.	2021-09-02 14:40:36 -05:00
Jérôme Desboeufs	7079af2fd4	Update photographies-aeriennes basemap URL	2021-09-01 21:58:12 +02:00
Pierre de La Morinerie	7380d27d78	js: fix null xhr in autosave error handling ... Sentry reports many cases of the xhr object being missing in the error handler. Ensure the error handling code doesn't crash because of the missing xhr.	2021-08-31 14:54:02 -05:00
Paul Chavard	5d63ced246	fix(eslint): fix eslint warnings	2021-08-31 18:14:04 +02:00
Paul Chavard	a3cc072bbd	feat(i18n): translate countries selector	2021-08-31 13:15:26 +02:00
Paul Chavard	241f564ecc	refactor(i18n): move signature translation keys to shared	2021-08-26 17:53:59 +02:00
Paul Chavard	c1c45613cc	feat(i18n): translate reexamin and new message emails	2021-08-26 17:53:59 +02:00
Paul Chavard	89d9a4a477	feat(i18n): translate notification emails actions	2021-08-26 17:53:59 +02:00
Paul Chavard	6eb072e69f	feat(i18n): translate email greetings	2021-08-26 17:53:59 +02:00
lydiasan	156b9894fe	ajout des traductions pour la demande de mdp	2021-08-26 17:43:00 +02:00
lydiasan	ff575db4b3	i18n: request new password translation	2021-08-26 14:56:12 +02:00
Paul Chavard	8c6978c0cb	feat(i18n): translate devise related emails	2021-08-26 12:08:40 +02:00
Paul Chavard	8e1bfb469f	fix(dossier): send expiration notifications 2 weeks prior to supression instead of a month	2021-08-26 11:28:57 +02:00
Paul Chavard	1399d9bba9	feat(graphql): expose demarche descriptor on dossier type ... We don't want to expose full demarche type on dossiers because it would open the door for recursive queries that we want to avoid. DemarcheDescriptorType is a lightweight representation of demarche metadata.	2021-08-25 11:12:24 +02:00
Pierre de La Morinerie	bb15d5fadc	i18n: put french first in the locales list ... Because French is the reference locale, and we should reflect this to users.	2021-08-24 12:57:51 -05:00
Pierre de La Morinerie	02a19587b7	i18n: display selected locale as active wit bold text	2021-08-24 12:57:51 -05:00
Pierre de La Morinerie	227b1dc462	i18n: remove language code from the locale dropdown	2021-08-24 12:57:51 -05:00
Pierre de La Morinerie	47e1555dce	i18n: properly translate the locale dropdown title	2021-08-24 12:57:51 -05:00
Pierre de La Morinerie	83b04aca59	i18n: move 'layouts' locales to their proper location	2021-08-24 12:57:51 -05:00
Pierre de La Morinerie	db803c2522	i18n: fix capitalization in the locale dropdown	2021-08-24 12:57:51 -05:00
Paul Chavard	ef16424fa8	fix(i18n): use correct translation namespace	2021-08-24 16:00:57 +02:00
Paul Chavard	3b6528decf	feat(i18n): enable localization by query param ... Providing a query param ("locale") will enable localization. A language picker will be shown once localization is activated. Locale is stored in a cookie "locale".	2021-08-24 12:42:40 +02:00
Ismael MOUSSA S. (T0194673)	330333aac4	6407 - Fix flash message typo in new administrateur/groupe instructeurs controller and its related spec	2021-08-20 20:10:44 +02:00
kara Diaby	8788d0e7dd	fix localstorage save message for bulk messages	2021-08-20 15:21:07 +02:00
Christophe Robillard	99c16e8dc0	i18n for header	2021-08-20 12:09:01 +02:00
Christophe Robillard	a5750ed4ce	i18n for registration page	2021-08-20 12:09:01 +02:00
Christophe Robillard	bf3580ca2f	i18n for page commencer	2021-08-20 09:19:25 +02:00
Christophe Robillard	ddea0b9a45	purge old sendinblue mails	2021-08-20 08:52:39 +02:00
Christophe Robillard	e06f11f33f	add code insee libelle for commune export	2021-08-19 08:04:47 +02:00
Christophe Robillard	4a6c22d6a6	export code insee for commune champ	2021-08-19 08:04:47 +02:00
Christophe Robillard	daa306859c	champ export can be an array of values	2021-08-19 08:04:47 +02:00
Paul Chavard	ffa8c0c80a	feat(dossiers): enable dossiers termine expiration behind feature flag ... feature flag "procedure_process_expired_dossiers_termine" controls if a procedure has expiration enabled on dossiers termine re #3796	2021-08-18 16:11:35 +01:00
Paul Chavard	b81cfea0e4	fix(combo-search): can input empty value	2021-08-18 15:48:37 +01:00
Paul Chavard	2a84f14521	Make generic	2021-08-18 12:09:20 +02:00
kara Diaby	90371bbb82	save instructeur commentaire local storage	2021-08-13 09:33:16 +02:00
Christophe Robillard	f6aed1782b	stats: précise légende et périodes considérées	2021-08-12 14:33:40 +02:00
Christophe Robillard	1c564bb744	homogeneise les couleurs utilisées pour les stats	2021-08-11 11:30:47 +02:00
Christophe Robillard	93ba0cc038	stats: rend plus explicite le graphe taux d'acceptation	2021-08-11 10:50:26 +02:00
Christophe Robillard	2ee505e9a9	stats: i18n pour legende repartition par semaine	2021-08-10 15:22:36 +02:00
Christophe Robillard	56ce4938d8	stats: rend plus explicite la répartition par semaine	2021-08-10 14:16:51 +02:00
Christophe Robillard	031b74759f	archives: move bugreport	2021-08-05 09:24:20 +02:00
kara Diaby	2c5f05e474	layout	2021-08-04 11:35:06 +02:00
kara Diaby	0300df9a35	add procedure to bulk messages	2021-08-04 11:35:06 +02:00
kara Diaby	ae0a3b9dd5	modify procedures controller instructeur	2021-08-04 11:35:06 +02:00
kara Diaby	3b8f2c8c1e	add css class	2021-08-04 11:35:06 +02:00
Christophe Robillard	38e3469e9a	add bug report to archive	2021-08-03 14:51:41 +02:00
simon lehericey	b29bae4707	a procedure has an encrypted api_particulier_token ... Co-authored-by: François VANTOMME <akarzim@gmail.com>	2021-07-30 11:18:44 +02:00
simon lehericey	66c35fdffe	add encryptable_concern ... Co-authored-by: François VANTOMME <akarzim@gmail.com>	2021-07-30 11:18:44 +02:00
François Vantomme	17b659539f	Feat (API Particulier): new encryption service	2021-07-30 11:18:44 +02:00
Christophe Robillard	67c0d93eae	Debugging archive generation ... debugging exception that occurs sometime when trying to download pj during archive generation	2021-07-29 11:12:07 +02:00
kara Diaby	1a3ae7d490	fix layout	2021-07-28 14:54:12 +02:00
kara Diaby	b6f931a968	add unique index on bulk messages join table	2021-07-27 20:32:28 +02:00
kara Diaby	69393c2921	modify groupe instructeur controller	2021-07-27 19:38:22 +02:00
kara Diaby	ab0782530c	create Bulk Message model and migration	2021-07-27 19:38:22 +02:00
kara Diaby	3869a848e9	fixup! layout	2021-07-27 19:38:21 +02:00
kara Diaby	9b1a522241	fixup! modify mailers	2021-07-27 19:38:21 +02:00
kara Diaby	c92b249340	fixup! modify models	2021-07-27 19:38:21 +02:00
kara Diaby	ed49d1b110	instructeur_procedures_controller	2021-07-27 19:38:21 +02:00
lydiasan	633d7cd8f2	correction des clés	2021-07-27 12:33:19 +02:00
Paul Chavard	64cfb4d64e	Fix sort with revisions	2021-07-23 10:57:04 +02:00
Pierre de La Morinerie	0fd23ebd43	db: fix schema.rb leftovers	2021-07-22 17:55:47 +02:00
Pierre de La Morinerie	e1909ed29f	brouillon: redirect to sign-in when disconnected ... There are two cases where the draft auto-save might fail because the user is no longer authenticated: - The user signed-out in another tab, - The brower quit and re-opened, so the Session cookie expired. In both cases, the auto-save will never succeed until the user authenticates again, so displaying a "Retry" button is cruel. Moreover, in plus of all auto-save requests failing with a small error, the actual hard failure only occurs after filling all the form and trying to submit it. Then the user is redirected to the sign-in page – but all their changes are lost. Instead, we now redirect to the sign-in page on the first 401 error during the auto-save, let the user sign-in, and then redirect back to the form.	2021-07-22 11:58:02 +02:00
Pierre de La Morinerie	7808f6dd4f	js: document utils.ajax()	2021-07-22 11:58:02 +02:00
Pierre de La Morinerie	c6fff58f38	js: fix typo in comment	2021-07-22 11:58:01 +02:00
Pierre de La Morinerie	071d9145ca	js: don't attempt to log unexistent statusText	2021-07-22 11:58:01 +02:00
Paul Chavard	388fb39eb5	Fix false positive blank champ warnings	2021-07-22 10:45:25 +02:00
Paul Chavard	ac0f50b488	Improuve champ blank check	2021-07-22 10:45:25 +02:00
Pierre de La Morinerie	32ab2f0a80	instructeur: limit the maximum size of a filter value ... This prevents the URL from exceeding the max size, and causing '414: Request-URI too large' errors.	2021-07-20 14:49:48 +02:00
lydiasan	7de10731a6	i18n: localize dossiers edition	2021-07-20 14:18:20 +02:00
Paul Chavard	c7b0b8495b	Get more results from communes API and use local matcher	2021-07-20 13:34:17 +02:00
Pierre de La Morinerie	831672391e	app: use a long-lived cookie for CSRF token ... See the ADR document for rationale.	2021-07-20 11:11:52 +02:00
Pierre de La Morinerie	a03d8d0705	controllers: remove useless handle_verified_request override ... This is a leftover of 09933454ff	2021-07-20 11:11:52 +02:00
Pierre de La Morinerie	63cde95fc9	js: ignore errors generated by a Microsoft crawler ... Sentry has a lot of Javacript errors stating: > UnhandledRejection: Non-Error promise rejection captured with value: Object Not Found Matching Id:2 This is apparently caused by a Microsoft crawler (maybe for scanning targets of email links), and can be safely ignored. See https://forum.sentry.io/t/unhandledrejection-non-error-promise-rejection-captured-with-value/14062/12	2021-07-20 09:21:59 +02:00
Pierre de La Morinerie	71741c5f98	views: fix checkbox wrongly selected in multiple_drop_down_list ... The check for whether the checkbox should be checked or not was made by matching the whole string. Thus, given two options 'valid' and 'invalid', the check for the presence of 'valid' would succeed even when only 'invalid' was present in the values (because `'valid'.includes?('invalid')`. The code now checks against the list of items in the selected_options.	2021-07-20 09:01:07 +02:00
kara Diaby	c731f8cf1f	add windows content type to avoid errors	2021-07-15 16:32:07 +02:00
Pierre de La Morinerie	40b3ea8ad6	Revert "Instructeurs : limitation de la valeur d'un filtre à 100 caractères"	2021-07-13 18:19:46 +02:00
kara Diaby	d2d046a39d	fix encoding problems with cherlock Holmes gem	2021-07-13 10:58:41 +02:00
Pierre de La Morinerie	3c8a88a660	instructeur: limit the maximum size of a filter value ... This prevents the URL from exceeding the max size, and causing '414: Request-URI too large' errors.	2021-07-08 16:17:22 +02:00
Paul Chavard	38fdaa7404	Trigger onStyleChange when leyers are toggled	2021-07-07 16:23:55 +02:00
Paul Chavard	1e4c943392	Fix map controls checkbox labels	2021-07-07 15:38:21 +02:00
Paul Chavard	65adce1e24	Fix cadastres layer	2021-07-07 15:38:21 +02:00
Christophe Robillard	03e98229c9	a user can now see stats for closed procedure	2021-07-07 15:00:38 +02:00
Paul Chavard	527db7631e	Add a point on map from coordinates input	2021-07-07 13:33:28 +02:00
Paul Chavard	ab31087f23	Hide cadastres if there is none	2021-07-07 12:28:27 +02:00
Pierre de La Morinerie	37c62ac0a3	app: display standard error page when no cookies are present ... This occurs mostly when Safari attempts to perform a POST request again (without sending any of the cookies). In that case, our custom `422.html` page is more helpful to the user (because it has a link to the previous page) than a "No cookies" blank text.	2021-07-06 16:29:22 +02:00
Christophe Robillard	bc07a875eb	integrate a mininum weight for the average dossier weight ... before this commit, the average dossier weight took account only pieces justificatives. With this commit, we add a minimum weight for other files included in an archive like pdf_export, log operations, attachments added to traitements. This minimum weight is set arbitrary, from the observation of some random procedures in production	2021-07-06 15:58:45 +02:00
Paul Chavard	0ce708028d	Prevent crashes in combo boxes	2021-07-06 15:06:38 +02:00
Pierre de La Morinerie	09933454ff	app: improve InvalidAuthenticityToken logging ... - Log on all controllers - Improve description of the controller action involved - Ignore Safari bogus requests	2021-07-06 12:42:01 +02:00
Paul Chavard	87fb98f5ed	Make IGN layers opacity configurable	2021-07-06 10:36:12 +02:00
Pierre de La Morinerie	97c8f76635	views: show the 'Avis' tab if needed on all profiles	2021-07-06 08:54:40 +02:00
Pierre de La Morinerie	4422d989a6	views: extract partial for the 'Avis' tab	2021-07-06 08:54:40 +02:00
Christophe Robillard	54d91335f2	remove the ability to download an 'everything' archive ... there are sometimes an error that happen when building an everything archive. The error explanation is not understood at the moment. To deliver the archive feature quickly, we remove the 'everything' archive for the moment	2021-07-05 11:05:07 +02:00
Paul Chavard	ce27999bc3	Refactor clone_attachments	2021-07-01 16:21:46 +02:00
Paul Chavard	280e54b59d	Enable test revisions	2021-07-01 15:59:07 +02:00
Paul Chavard	fc966a2761	IGN layers on maps can now be disabled by the user	2021-06-30 20:07:52 +02:00
Pierre de La Morinerie	1faf91bdbe	experts: protect password update as well as sign-up	2021-06-30 10:46:42 +02:00
Pierre de La Morinerie	6f7a2fde57	experts: fix saving password on sign-in	2021-06-30 10:46:42 +02:00
Christophe Robillard	cd36f2622f	fix download FakeAttachment	2021-06-24 21:02:55 +02:00
Christophe Robillard	66cc0dd08d	Revert "Revert "Expose dossier PDF export as IO"" ... This reverts commit 362093eff0.	2021-06-24 21:01:59 +02:00
krichtof	362093eff0	Revert "Expose dossier PDF export as IO"	2021-06-24 19:21:37 +02:00
Paul Chavard	f39944a02e	Create procedure sub folder in archives ... Co-authored-by: Christophe Robillard <christophe.robillard@beta.gouv.fr>	2021-06-24 17:50:17 +02:00
Paul Chavard	48dca8bad1	Execute AchiveCreationJob in exports queue ... Co-authored-by: Christophe Robillard <christophe.robillard@beta.gouv.fr>	2021-06-24 17:49:58 +02:00
Paul Chavard	b73d504f8d	Expose dossier PDF export as IO ... Co-authored-by: Christophe Robillard <christophe.robillard@beta.gouv.fr>	2021-06-24 17:49:24 +02:00
Paul Chavard	a4482233b8	[GraphQL] expose deleted dossiers	2021-06-24 11:51:37 +02:00
Paul Chavard	15ff046428	Improuve revision changes messages	2021-06-24 11:39:49 +02:00
Paul Chavard	241eff76a3	Enable publish new revision only if some changes are found	2021-06-24 11:39:49 +02:00
Paul Chavard	0ca5e1abe2	Preview should reflect revision changes	2021-06-24 11:39:49 +02:00
Paul Chavard	8b2c2c6466	Handle carte layers changes	2021-06-24 11:39:49 +02:00
Paul Chavard	35eccb5630	Show separate blocks for types de champ and annotation changes	2021-06-23 09:40:07 +02:00
Paul Chavard	19195008e8	Expose removed types_de_champ in exports	2021-06-23 09:40:07 +02:00
simon lehericey	eadae7af6b	show all available tdc for procedure presentation	2021-06-23 09:40:07 +02:00
Paul Chavard	e68441d573	Allow publishing revisions when feature flag is enabled	2021-06-23 09:40:07 +02:00
Paul Chavard	9d3416af53	Implement revision changes UI	2021-06-23 09:40:07 +02:00
Paul Chavard	0d25f52309	Add changed? and compare on ProcedureRevision	2021-06-23 09:40:07 +02:00
Paul Chavard	15e9013264	Set published_at on revision when publishing a procedure	2021-06-23 09:40:07 +02:00
Paul Chavard	f238710044	Add last_month export	2021-06-23 09:23:10 +02:00
kara Diaby	cf11b0c901	return error if the csv headers are wrong	2021-06-22 16:33:38 +02:00
Christophe Robillard	63ef3a08d7	archives: corrige une faute d'orthographe	2021-06-22 15:35:48 +02:00
Pierre de La Morinerie	a99a6cc49f	controllers: use default Rails settings for protecting against forgery ... Rails uses `config.action_controller.allow_forgery_protection` to enable or disable forgery protection globaly. This is disabled for tests by default. So our custom config is not required.	2021-06-22 13:21:55 +02:00
kara Diaby	87ce71f27d	fix import service	2021-06-21 14:11:05 +02:00
kara Diaby	06958cbdd1	fix service and utf-8 encoding	2021-06-21 13:54:01 +02:00
Paul Chavard	1f7d86d5a5	Add delete dossier action to dossiers list	2021-06-18 11:35:00 +02:00
Christophe Robillard	fdec9b2fd5	archives: don't update dossiers ... this fix avoid to touch dossier after attaching pdf_export_for_instructeur	2021-06-18 11:00:57 +02:00
Christophe Robillard	7851d6b1cc	archives: count archived dossiers	2021-06-18 08:59:13 +02:00
krichtof	4bda6600b1	explain what percentile constant means ... Co-authored-by: Pierre de La Morinerie <pierre.de_la_morinerie@beta.gouv.fr>	2021-06-17 16:31:53 +02:00
Christophe Robillard	896190b91e	return nil when no traitement time	2021-06-17 16:31:53 +02:00
Christophe Robillard	887c5cb4a9	correct rubocop offenses	2021-06-17 16:31:53 +02:00
Christophe Robillard	a5ae5af56a	extract NB_DAYS_RECENT_DOSSIERS and PERCENTILE	2021-06-17 16:31:53 +02:00
Christophe Robillard	f2deba733d	use traitement_times to compute usual_traitement_time for recent ... dossiers	2021-06-17 16:31:53 +02:00
Christophe Robillard	21dd05cc56	less sql queries for usual_traitement_time_by_month	2021-06-17 16:31:53 +02:00
Christophe Robillard	8cbbae8984	use cache for traitement time for instructeurs	2021-06-17 16:31:53 +02:00
Christophe Robillard	a8840faadb	move stats methods to appropriate concern class	2021-06-17 16:31:53 +02:00
Christophe Robillard	98f0eb5ba9	ajoute legende à la stat	2021-06-17 16:31:53 +02:00
Christophe Robillard	45ffae9eb3	affiche evolution temps de traitement	2021-06-17 16:31:53 +02:00
Christophe Robillard	701b72494d	compute usual traitement time for specific month	2021-06-17 16:31:53 +02:00
Pierre de La Morinerie	b5bde6608c	routes: replace the email param in the Avis URLs by a query param	2021-06-17 11:15:51 +02:00
Paul Chavard	10cdd2c77e	Apply suggestions from code review ... Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com>	2021-06-16 09:38:47 +02:00
Paul Chavard	7f28c49887	expand commune searches with multiple post codes	2021-06-16 09:29:25 +02:00
kara Diaby	f1a5eb0482	layout	2021-06-15 19:36:46 +02:00
kara Diaby	6353104ecb	modify service	2021-06-15 19:36:46 +02:00
kara Diaby	ab781204bc	modify groupe instructeur controller	2021-06-15 11:20:20 +02:00
kara Diaby	a1367301e9	add css utils	2021-06-15 11:20:20 +02:00
Paul Chavard	7575f50d25	Fix autocomplete on blur	2021-06-15 10:13:31 +02:00
Paul Chavard	7f4e174871	Declare useCallback dependencies	2021-06-15 10:13:31 +02:00
simon lehericey	4900ca16f2	makes whole admin card clickable	2021-06-15 09:54:32 +02:00
simon lehericey	6be0bbaa9c	Change bottom champs editor button from enregistrer to continuer	2021-06-15 09:54:32 +02:00
simon lehericey	9f50ead0fc	wrap link in header to avoid ugly display	2021-06-15 09:54:32 +02:00
simon lehericey	a407c0b2a0	top align th in dossier table	2021-06-15 09:54:32 +02:00
Paul Chavard	a2c53ce7ea	format phone numbers	2021-06-15 09:14:55 +02:00
François Vantomme	c9b1095d1e	Refactor (Rubocop): replace map{ … }.compact by filter_map ... In Ruby 2.7, Enumerable#filter_map has been added. This cop identifies places where map { … }.compact can be replaced by filter_map. See: https://docs.rubocop.org/rubocop-performance/cops_performance.html#performancemapcompact	2021-06-11 15:38:09 +02:00
Christophe Robillard	169f254c79	infer champ type from class	2021-06-09 10:52:38 +02:00
Christophe Robillard	6f845508b4	order archive by desc month	2021-06-09 10:52:38 +02:00
Christophe Robillard	5e180268cd	remove one sql query	2021-06-09 10:52:38 +02:00
Christophe Robillard	41569efe9d	extract estimate_weight ... and rename nb_dossiers by nb_dossiers_termines	2021-06-09 10:52:38 +02:00
simon lehericey	b8f01d06d7	more style ... Co-authored-by: Christophe Robillard <christophe.robillard@beta.gouv.fr>	2021-06-09 10:52:38 +02:00
simon lehericey	f2ba83a704	cout_dossier_termines_by_month for groupe_instructeurs ... Co-authored-by: Christophe Robillard <christophe.robillard@beta.gouv.fr>	2021-06-09 10:52:38 +02:00
simon lehericey	83d60c7b63	archive for all the groups ... Co-authored-by: Christophe Robillard <christophe.robillard@beta.gouv.fr>	2021-06-09 10:52:38 +02:00
simon lehericey	e933a80c55	remove useless archivable_months ... Co-authored-by: Christophe Robillard <christophe.robillard@beta.gouv.fr>	2021-06-09 10:52:38 +02:00
simon lehericey	d7ce26662f	capitalize month ... Co-authored-by: Christophe Robillard <christophe.robillard@beta.gouv.fr>	2021-06-09 10:52:38 +02:00
simon lehericey	a02c598a43	some style ... Co-authored-by: Christophe Robillard <christophe.robillard@beta.gouv.fr>	2021-06-09 10:52:38 +02:00
simon lehericey	7cce505dce	allow download whole procedure if small enough ... Co-authored-by: Christophe Robillard <christophe.robillard@beta.gouv.fr>	2021-06-09 10:52:38 +02:00
simon lehericey	1c1e990d2a	remove useless count ... Co-authored-by: Christophe Robillard <christophe.robillard@beta.gouv.fr>	2021-06-09 10:52:38 +02:00
simon lehericey	b5c1200bf1	disallow download archive button if to heavy ... Co-authored-by: Christophe Robillard <christophe.robillard@beta.gouv.fr>	2021-06-09 10:52:38 +02:00
simon lehericey	61b5085390	remove useless if ... Co-authored-by: Christophe Robillard <christophe.robillard@beta.gouv.fr>	2021-06-09 10:52:38 +02:00
simon lehericey	09b3cf98f6	use nb_dossiers to estimate total weight ... Co-authored-by: Christophe Robillard <christophe.robillard@beta.gouv.fr>	2021-06-09 10:52:38 +02:00
simon lehericey	1a6337cf37	remove useless if ... Co-authored-by: Christophe Robillard <christophe.robillard@beta.gouv.fr>	2021-06-09 10:52:38 +02:00
simon lehericey	f094c6c218	avoid useless count ... Co-authored-by: Christophe Robillard <christophe.robillard@beta.gouv.fr>	2021-06-09 10:52:38 +02:00
simon lehericey	895eed5a27	UI uses average_dossier_weight ... Co-authored-by: Christophe Robillard <christophe.robillard@beta.gouv.fr>	2021-06-09 10:52:38 +02:00
simon lehericey	9e43823f9a	add average_dossier_weight ... Co-authored-by: Christophe Robillard <christophe.robillard@beta.gouv.fr>	2021-06-09 10:52:38 +02:00
Christophe Robillard	7002811ba5	optim count nb_dossiers per month for archive ... `Traitement#count_dossiers_termines_by_month` removes n+1 queries Co-authored-by: LeSim <mail@simon.lehericey.net>	2021-06-09 10:52:38 +02:00
kara Diaby	b3c5fcb4c5	fix procedure not found	2021-06-08 17:55:38 +02:00
Christophe Robillard	9bb9462b3a	optimise les stats termines by week	2021-06-08 15:23:31 +02:00
Paul Chavard	44ebd0e8a5	Fix api education wrong data type	2021-06-08 12:25:24 +02:00
Christophe Robillard	1a8a394cb7	fix stats view for users	2021-06-06 19:35:48 +02:00
Paul Chavard	1888f74b10	Prevent double processing of declarative dossiers	2021-06-04 17:55:40 +02:00
kara Diaby	66f0fa35f2	layout	2021-06-04 15:29:08 +02:00
kara Diaby	3555c9696a	modify concern	2021-06-04 15:29:08 +02:00
kara Diaby	6ed339e7aa	modify controllers	2021-06-04 15:29:08 +02:00
Paul Chavard	3071af220a	Add revision date_publication	2021-06-03 13:11:16 +02:00
Paul Chavard	f526e303e8	Apply suggestions from code review ... Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com>	2021-06-03 13:11:16 +02:00
Paul Chavard	3fb10fb4b8	Set published_at on revision when publishing a procedure	2021-06-03 13:11:16 +02:00
Paul Chavard	306e5d228d	Add published_at to procedure_revisions	2021-06-03 13:11:16 +02:00
Paul Chavard	990ae10399	GraphQL byte_size should be BigInt	2021-06-03 10:53:17 +02:00
Paul Chavard	f076fa803e	Handle GeoJSON validation errors	2021-06-02 12:43:24 +02:00
Pierre de La Morinerie	188b89a3c8	manager: fix polymorphic route exception when viewing user emails ... Since the last Rails update, arguments to polymorphic routes must be symbols, otherwise an exception is raised.	2021-06-01 11:29:57 +02:00
Paul Chavard	05380b9520	Fix destoying discarded procedures	2021-05-27 18:48:56 +02:00
François Vantomme	bc6d5aca0e	Fix (Sentry): prefer Rails secrets over ENV variables	2021-05-27 11:12:27 +02:00
Paul Chavard	9b0dae4cc2	Fix apostrophes ‘ -> ’	2021-05-26 18:05:14 +02:00
Paul Chavard	bd7bb2d0d2	Fix apostrophes ‘ -> ’	2021-05-26 15:09:23 +02:00
Paul Chavard	4922bc88d6	Do not crash when properties is nil	2021-05-26 12:40:07 +02:00
Paul Chavard	dfc46a8736	Enable add descriptions to cadastres	2021-05-26 11:27:09 +02:00
Paul Chavard	18ce027b84	Update dossier serialize query to stop using deprecated fileds	2021-05-26 11:12:06 +02:00