DGNum/demarches-normaliennes
13
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

correct rubocop offenses

Browse source
This commit is contained in:
Christophe Robillard 2021-06-16 15:13:36 +02:00
parent a5ae5af56a
commit 887c5cb4a9
3 changed files with 16 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

15
app/models/concerns/procedure_stats_concern.rb
View file

@ -59,27 +59,28 @@ module ProcedureStatsConcern
Traitement.for_traitement_time_stats(self)
.where(processed_at: date_range)
.pluck('dossiers.en_construction_at', :processed_at)
.map{|en_construction_at, processed_at| { en_construction_at: en_construction_at, processed_at: processed_at }}
.map { |en_construction_at, processed_at| { en_construction_at: en_construction_at, processed_at: processed_at } }
end
def usual_traitement_time_by_month_in_days
traitement_times(first_processed_at..last_considered_processed_at)
.group_by {|t| t[:processed_at].beginning_of_month }
.transform_values{|month| month.map{|h| h[:processed_at] - h[:en_construction_at]}}
.transform_values{|traitement_times_for_month| traitement_times_for_month.percentile(PERCENTILE).ceil }
.transform_values{|seconds| convert_seconds_in_days(seconds)}
.transform_keys{|month| pretty_month(month)}
.group_by { |t| t[:processed_at].beginning_of_month }
.transform_values { |month| month.map { |h| h[:processed_at] - h[:en_construction_at] } }
.transform_values { |traitement_times_for_month| traitement_times_for_month.percentile(PERCENTILE).ceil }
.transform_values { |seconds| convert_seconds_in_days(seconds) }
.transform_keys { |month| pretty_month(month) }
end
def usual_traitement_time_for_recent_dossiers(nb_days)
now = Time.zone.now
traitement_times((now - nb_days.days)..now)
.map{|times| times[:processed_at] - times[:en_construction_at]}
.map { |times| times[:processed_at] - times[:en_construction_at] }
.percentile(PERCENTILE)
.ceil
end
private
def first_processed_at
Traitement.for_traitement_time_stats(self).pick(:processed_at)
end

2
app/models/traitement.rb
View file

@ -19,7 +19,7 @@ class Traitement < ApplicationRecord
.where("traitements.processed_at + (procedures.duree_conservation_dossiers_dans_ds * INTERVAL '1 month') - INTERVAL :expires_in < :now", { now: Time.zone.now, expires_in: Dossier::INTERVAL_BEFORE_EXPIRATION })
end
scope :for_traitement_time_stats, ->(procedure) do
scope :for_traitement_time_stats, -> (procedure) do
includes(:dossier)
.where(dossier: procedure.dossiers)
.where.not('dossiers.en_construction_at' => nil, :processed_at => nil)

12
spec/models/concern/procedure_stats_concern_spec.rb
View file

@ -70,11 +70,13 @@ describe ProcedureStatsConcern do
after { Timecop.return }
context 'when there are several processed dossiers' do
let(:delays_by_month) { [
[90.days, 90.days],
[1.day, 2.days, 2.days, 2.days, 2.days, 3.days, 3.days, 3.days, 3.days, 12.days],
[30.days, 60.days, 60.days, 60.days]
] }
let(:delays_by_month) {
[
[90.days, 90.days],
[1.day, 2.days, 2.days, 2.days, 2.days, 3.days, 3.days, 3.days, 3.days, 12.days],
[30.days, 60.days, 60.days, 60.days]
]
}
it 'computes a time representative of the dossier instruction delay for each month except current month' do
expect(procedure.usual_traitement_time_by_month_in_days['avril 2019']).to eq 60