4662 commits

Author	SHA1	Message	Date
simon lehericey	ea361643be	types_de_champ -> types_de_champs_public	2022-05-03 11:05:24 +02:00
Martin	2529773515	bug(commencer/test): with procedure without service nor organisation, it crashes	2022-04-28 14:19:55 +02:00
Paul Chavard	68ca9efba0	feat(dossier): use persisted dossier for preview	2022-04-28 12:20:41 +02:00
Martin	3c0e3f725d	feat(administrateur/procedures#publication): show dubious to administrateur ... Update app/views/administrateurs/procedures/publication.html.haml Co-authored-by: Paul Chavard <paul.chavard@beta.gouv.fr>	2022-04-27 15:13:22 +02:00
Martin	be090a1bec	feat(administrateur/procedure#create): allow admin to add a lien to the DPO, allow user to consult link to dpo. enhance spec on _procedure_footer.html ... Update spec/views/users/_procedure_footer.html.haml_spec.rb Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com>	2022-04-27 15:09:02 +02:00
Paul Chavard	d2ab8b5593	feat(message): replace message partial with MessageComponent	2022-04-26 14:54:58 +02:00
Paul Chavard	91879b89ce	fix(commentaire): unified destroy commentaire	2022-04-26 14:54:58 +02:00
Paul Chavard	009c44cc20	refactor(avis): remove unused controller action	2022-04-26 14:54:58 +02:00
Paul Chavard	86df16ebda	feat(view_components): add view_components	2022-04-26 14:54:58 +02:00
Martin	418d4ede17	test(commencer): test dossier_vide_pdf and dossier_vide_pdf_test	2022-04-25 15:00:48 +02:00
Paul Chavard	23b60c87e9	fix(procedure): cloned procedure should not have auto_archive_on ... fix #7149	2022-04-22 10:48:31 +02:00
Martin	79c473ecf9	fix(ProcedureExportService.to_zip): prebatch dossiers only for to_csv,to_xlsx,to_ods. also add spec around to_zip	2022-04-22 05:13:51 +02:00
Martin	a3c5bf58ac	bug(ProcedureExportService.to_zip): use in_batches on Array	2022-04-22 05:13:51 +02:00
Paul Chavard	cad63391db	refactor(turbo): use turbo in procedure administrateurs controller	2022-04-21 19:41:27 +02:00
Paul Chavard	69d5713c19	fix(turbo): fix anonymous controller RSpec test ... https://github.com/hotwired/hotwire-rails/issues/42	2022-04-21 19:41:27 +02:00
Paul Chavard	64c599e208	refactor(stimulus): initiate react components via stimulus	2022-04-20 14:08:47 +02:00
simon lehericey	9fd5219751	fix sort in procedure presentation	2022-04-15 12:21:39 +02:00
simon lehericey	23707d6033	ignore file not found error when cloning procedure	2022-04-14 13:46:16 +02:00
Paul Chavard	c671f25d34	fix(dossier): do not show unwanted closed procedure banners	2022-04-14 12:22:37 +02:00
Paul Chavard	83a8d87e95	i18n(procedure_presentation): translate fields	2022-04-14 11:38:01 +02:00
Paul Chavard	433c01b1e6	Revert "Merge pull request #7137 from betagouv/faster_pdf" ... This reverts commit 9da44bd913, reversing changes made to ebac71796c.	2022-04-12 19:22:07 +02:00
Paul Chavard	38a6b2db63	fix(graphql): fix AddressTypeType	2022-04-12 19:12:50 +02:00
Paul Chavard	d14e132305	feat(export): add zip format support	2022-04-12 14:54:54 +02:00
Paul Chavard	2832ea0286	refactor(export): return blob from to_* methods	2022-04-12 14:54:54 +02:00
Paul Chavard	561b83781e	refactor(archive): remove dependencie on archive from ArchiveUploader	2022-04-12 14:54:54 +02:00
Paul Chavard	cf8c084a59	refactor: extract download_and_zip in to a shared service	2022-04-12 14:54:54 +02:00
Paul Chavard	b6bb9552e6	fix(graphql): detect custom champs in fragment definitions	2022-04-12 14:24:15 +02:00
simon lehericey	579578cf0c	fix system spec	2022-04-12 12:05:08 +02:00
simon lehericey	4bbe2db668	only export safe pj	2022-04-12 12:05:08 +02:00
simon lehericey	4d3412daf5	batch it	2022-04-12 11:56:56 +02:00
simon lehericey	29dacb4686	remove env dependence in spec	2022-04-11 14:40:02 +02:00
simon lehericey	1dcfb2509f	check nonce	2022-04-11 14:40:02 +02:00
simon lehericey	9938586d96	check state	2022-04-11 13:56:27 +02:00
Paul Chavard	90dd5bc9c5	fix(dossiers): dossier extend_conservation actually works	2022-04-08 13:40:28 +02:00
simon lehericey	4f73c6105f	remove duplicate spec	2022-04-07 12:06:13 +02:00
simon lehericey	e2130cc2d3	add witness dossier	2022-04-07 12:06:13 +02:00
simon lehericey	951d964701	clean pj_service test	2022-04-07 12:06:13 +02:00
simon lehericey	34b0578d70	pj_and_path only take dossier id	2022-04-07 12:06:13 +02:00
simon lehericey	7ac1288905	pj_service take a dossier collection !	2022-04-07 12:06:13 +02:00
simon lehericey	51b71aaa01	always call create_list_from_dossiers	2022-04-07 12:06:13 +02:00
Martin	9bac5c65ba	feat(instructeurs/dossier#create_avis): only followed dossier receive notifications, so when an instructeur ask for an avis, he follows the dossier ... Update app/controllers/concerns/create_avis_concern.rb Co-authored-by: Paul Chavard <paul.chavard@beta.gouv.fr> Update spec/controllers/instructeurs/dossiers_controller_spec.rb Co-authored-by: Paul Chavard <paul.chavard@beta.gouv.fr>	2022-04-07 09:05:23 +02:00
Martin	a9769ae277	fix(instructeur/dossiers#create_avis): as an instructeur, when I ask an avis, i hope to be notified when the expert give his avis	2022-04-07 09:05:23 +02:00
Paul Chavard	e82dc9c8b5	feat(exports): add ability to create exports with filters	2022-04-06 17:08:38 +02:00
Paul Chavard	be1a2f916d	feat(exports): add statut and procedure_presentation to exports	2022-04-06 17:08:38 +02:00
Paul Chavard	ec3ed049ef	refactor(procedure_presentation): expose filtered_sorted_ids method	2022-04-05 15:50:53 +02:00
simon lehericey	200e8680d5	add uniq index on attestation dossier_id	2022-04-05 15:43:21 +02:00
Martin	9e8807d12a	feat(ArchiveUploader.upload_with_chunking_wrapper): retry once on error	2022-04-05 15:11:21 +02:00
Martin	c72ba43c55	feat(ArchiveUploader.upload_with_chunking_wrapper): expect to retry call to wrapper once	2022-04-05 15:11:21 +02:00
Martin	9484c4cdf4	fix(Dossier.processed_in_month): using PG between operator with a date does not play nicely when it is compared to DateTime in postgres. meaning given a Date as 2022/03/31, when compared with a DateTime in postgres, the casting of 2022/03/31 to Datetime becomes 2022/03/31 00:00. So we skiped all dossiers from last date in month	2022-04-05 13:54:36 +02:00
Martin	c1884f231c	Revert "Merge pull request #7105 from betagouv/US/fix-dossier.processed_in_month" ... This reverts commit a0e144b9a7, reversing changes made to 49848bd150.	2022-04-05 13:39:37 +02:00
Martin	c07e0fc13e	fix(Dossier.processed_in_month): ensure proper usage via method sig instead of defensive programming style	2022-04-05 12:14:07 +02:00
Martin	d6d9db9721	tech(Sorbet): prepare usage of sorbet to avoid defensive programming style [casting date to datetime]	2022-04-05 12:14:07 +02:00
Martin	ab777a790c	fix(Dossier.processed_in_month): using PG between operator with a date does not play nicely when it is compared to DateTime in postgres. meaning given a Date as 2022/03/31, when compared with a DateTime in postgres, the casting of 2022/03/31 to Datetime becomes 2022/03/31 00:00. So we skiped all dossiers from last date in month	2022-04-05 12:14:07 +02:00
simon lehericey	1f98f75ccc	remove unused method	2022-04-05 11:55:14 +02:00
simon lehericey	4c3b9979e9	fix test	2022-04-05 11:55:14 +02:00
Paul Chavard	0daae815d8	refactor(dossier): use by_statut	2022-04-05 09:42:23 +02:00
Paul Chavard	6da54936b7	refactor(procedure_presentation): use internal reference to instructeur	2022-04-05 09:42:23 +02:00
Paul Chavard	f71c89aa91	refactor(procedure): cleanup tests	2022-04-05 09:42:23 +02:00
Paul Chavard	706c648be8	refactor(procedure): remove unused code	2022-04-05 09:42:23 +02:00
simon lehericey	57f9e5bac3	always allow dossier pjs download (-9 queries)	2022-04-04 17:26:49 +02:00
Martin	1d99e21a27	tech(bug): identify	2022-04-04 16:28:25 +02:00
Kara Diaby	b2bcc34cfd	tests	2022-03-31 15:48:18 +02:00
Martin	dbcf21a555	feat(archive): extract archive status management within job to simplify the main service as well as to isolate this part for a merge with exports csv/xslx [maybe?] ... Update app/dashboards/archive_dashboard.rb Co-authored-by: LeSim <mail@simon.lehericey.net>	2022-03-31 13:35:49 +02:00
Martin	ab2caaa5f7	fix(ProcedureArchiveService.zip_root_folder): should take archive instance otherwise when we generate many archive for the same procedure, errors may occures	2022-03-30 16:29:54 +02:00
Martin	ab0a172488	feat(Archive.prepare_broader_reach): activate by default the archive button in the export dropdown. add a call to action to contact our support to enable the feature. increase estimated file size limit up to 100.gigabytes	2022-03-30 16:21:07 +02:00
Kara Diaby	71614d4ba3	tests	2022-03-29 12:30:52 +02:00
simon lehericey	7ecf20ce75	harden email validation	2022-03-24 13:00:54 +01:00
Paul Chavard	7aacb7565c	fix(dossiers): mark as read dossier on update_annotations	2022-03-22 09:19:24 +01:00
Pierre de La Morinerie	31bd05f835	models: inverse the direction of the User role associations	2022-03-22 07:58:44 +01:00
Pierre de La Morinerie	56edba37bc	specs: make the ProcedurePresentation#sorted_ids test more robust ... Before the Dossiers were already created in the correct order, so the sorting wasn't really tested.	2022-03-22 07:58:44 +01:00
Martin	98c1fb8abc	feat(archive): drop old feature	2022-03-18 14:26:09 +01:00
Kara Diaby	4bfcf4f9d9	tests	2022-03-17 13:57:49 +01:00
Martin	5739150f15	feat(service/archive_uploader): add an archive uploader class to upload files thru a custom script which handle file encryption of massive file (bigger than 4Go) ... Update doc/object-storange-and-data-encryption.md Co-authored-by: LeSim <mail@simon.lehericey.net> Update app/services/archive_uploader.rb Co-authored-by: LeSim <mail@simon.lehericey.net> Update doc/object-storange-and-data-encryption.md Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com> clean(doc): align document file name and document h1 clean(review): refactore based on various comments clean(review): refactore based on various comments	2022-03-16 14:56:21 +01:00
Pierre de La Morinerie	1eebc2f1e1	specs: make test migrations safer ... This will avoid strong_migrations to flag them as dangerous.	2022-03-16 10:30:25 +01:00
simon lehericey	0a3eb4a909	reinforce preview testing	2022-03-15 11:15:28 +01:00
Paul Chavard	ec2f2dc78c	feat(graphql): expose more dossier informations	2022-03-14 15:58:02 +01:00
Paul Chavard	a50d07400e	refactor(instructeur): cleanup destroy / restore routes	2022-03-11 14:06:34 +01:00
Paul Chavard	78bf1147d0	refactor(instructeur): use better fallback location	2022-03-11 13:55:36 +01:00
Paul Chavard	c60a8970f1	perf(dossier): memoize champ.sections on dossier	2022-03-11 00:15:53 +01:00
Paul Chavard	51d7fd6190	test(dossier): update spec to use visible_by_administration	2022-03-10 14:29:40 +01:00
Pierre de La Morinerie	3a16235868	db: Add a delete_orphans db helper	2022-03-08 14:47:43 +01:00
Paul Chavard	91caef0bfe	fix(dossier): ensure submitted dossiers always have groupe instructeur	2022-03-02 16:57:12 +00:00
Pierre de La Morinerie	087e438eb6	models: delete AdministrateursInstructeur when destroying Instructeur ... By default, `has_and_belongs_to_many` properly deletes the record in the join table. However, as the association is declared manually with a `has_many / through`, it doesn't delete the joined record automatically. As we also lack a foreign-key contraint on the join table, that means a dangling record remains in the join table. To fix this, let's declare it a proper `has_and_belongs_to_many` association, which will let the join record be deleted automatically on destroy.	2022-03-02 11:26:53 +01:00
Pierre de La Morinerie	e32c9a9f94	models: don't attempt to format invalid phone numbers ... This is a defensive-programming measure, because formatting an invalid phone number may truncate some leading numbers.	2022-03-02 09:57:03 +00:00
Pierre de La Morinerie	f35d18cd5c	models: stop truncating DROM phone numbers ... Fix #6996	2022-03-02 09:57:03 +00:00
Pierre de La Morinerie	5150e33212	models: ensure DROM phone numbers are valid ... They were accepted before, because they were 'possible' – but now they are explicitely considered as valid.	2022-03-02 09:57:03 +00:00
Pierre de La Morinerie	71e1b6c973	models: delete AdministrateursProcedure when destroying Administrateur ... By default, `has_and_belongs_to_many` properly deletes the record in the join table. However, as the association is declared manually with a `has_many / through`, it doesn't delete the joined record automatically. As we also lack a foreign-key contraint on the join table, that means a dangling record remains in the join table. To fix this, let's declare it a proper `has_and_belongs_to_many` association, which will let the join record be deleted automatically on destroy.	2022-03-01 16:58:04 +01:00
mfo	4346775169	Merge branch 'main' into US/fix-avis	2022-02-28 15:08:25 +01:00
Martin	48612028f4	fix(avis_controller#*): missing ACL	2022-02-28 14:24:41 +01:00
Martin	b808b4db00	fix(relation): avoid double association between procedure/procedure_revision/dossier_submitted_message	2022-02-25 14:01:18 +01:00
Martin	85a588541b	feat(dossier_submitted_message): add a new system to customize the standby page (/merci) after an user created his folder. this is a basic feature that will come with more options asap ... wip(dossier_created_hook): add tile to administrateurs/procedure#show in order to crud dossier_created_hook refactor(css.utilities): remove merge helpers.scss within utils.scss (same purpose). use scss each for spacer modifiers refactor(dossiers/_merci.html): extract partial _merci so we can re-use it in preview of dossier_created_hook. feat(wip): current progress	2022-02-25 14:01:18 +01:00
Pierre de La Morinerie	30d7cf634a	tasks: restore older after_party tasks ... Turns out deleting the tasks after 6 months only may not be enough for instances deploying only once a year, for instance. This reverts commit 77b65f3aa0.	2022-02-22 15:39:16 +01:00
Paul Chavard	2d396fcfb7	feat(dossier): rebase dossiers en construction and en instruction	2022-02-18 17:08:38 +01:00
Paul Chavard	50f095a5c6	test(user): fix unstable spec	2022-02-17 14:45:53 +01:00
Pierre de La Morinerie	c9f1a2b8ea	mailer: improve notify_new_answer wording ... And also insert the reply email address directly in the email body.	2022-02-16 18:35:30 +01:00
Pierre de La Morinerie	17c83b1ce2	mailer: fix notify_new_answer mailer preview	2022-02-16 18:26:45 +01:00
Pierre de La Morinerie	8786b60285	specs: fix flaky "dossier brouillon" spec ... When filling all the champs of a dossier, we skip the "Address" champ (because it would attempt to request a blocked URL). But that means the "Yes/No" radio buttons may be under the sticky bottom bar, and thus not register the click – which makes the test fail. Fix the issue by manually scrolling to the radio buttons.	2022-02-15 15:04:49 +01:00
Jon	97feca6305	feat(ClamAV): add config to disable clamav usage	2022-02-15 09:15:47 +01:00
Martin	f84b69276e	fix(expiration_banner.message): miss match when procedure was not expirable ; always showing expiration message	2022-02-11 15:49:37 +01:00
Paul Chavard	fac77d97ef	task(attestation_template): reassign_redundant_attestation_templates	2022-02-11 11:30:24 +01:00
Paul Chavard	08030bcdb7	fix(attestation_template): handle attestation changes on procedures without revisions	2022-02-11 11:12:10 +01:00
Paul Chavard	76b1b85fa7	fix(attestation_template): add revision diff support	2022-02-11 08:45:32 +01:00
Paul Chavard	e269077c40	refactor(attestation_template): cleanup relationships	2022-02-11 08:45:32 +01:00
Paul Chavard	88e80e9e32	Merge pull request #6901 from adullact/feature/6859-jwt-token-expiration ... [API Entreprise] Ajout du support des jetons JWT sans clé d'expiration	2022-02-10 11:48:39 +01:00
Kara Diaby	24ff41d2c0	tests	2022-02-09 14:43:36 +01:00
Paul Chavard	77e42dd0e2	Update spec/lib/tasks/deployment/20220112184331_revise_attestation_templates_spec.rb ... Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com>	2022-02-08 16:22:59 +01:00
Paul Chavard	1fc7db2562	fix(attestation_template): fix migration task	2022-02-08 16:22:59 +01:00
Paul Chavard	12151acb99	Revert "Revert "feat(attestation): revise attestations"" ... This reverts commit 4e7733e571.	2022-02-08 16:22:59 +01:00
François Vantomme	b9d6c32af7	Test (Universign): mock API URL constant ... Addressable::URI::InvalidURIError: Absolute URI missing hierarchical segment: 'http://'	2022-02-08 15:59:50 +01:00
Pierre de La Morinerie	847abca122	config: simplify mailer configuration again ... Move everything to initializers, and replace the email settings interceptor by a BalancerDeliveryMethod. It has the advantage that it can be configured entirely from the `config/environment.rb` file, without an extra file to look at.	2022-02-08 12:44:43 +01:00
François Vantomme	2bdf58cb79	style(rubocop): fix Layout/SpaceInsideBlockBraces offense	2022-02-08 12:35:08 +01:00
Paul Chavard	e87e8b2c26	Merge pull request #6899 from adullact/feature/6857-no-sandbox ... ETQ développeur, je voudrais pouvoir influer sur l'option --no-sandbox du pilote Selenium Chrome lors des tests	2022-02-08 12:29:51 +01:00
Paul Chavard	dad17ec2f8	Merge pull request #6906 from adullact/fix/6864-franceconnect-application-name ... [FranceConnect] les tests échouent quand la variable d'env APPLICATION_NAME a une autre valeur que celle par défaut	2022-02-08 11:53:16 +01:00
Paul Chavard	5b147e6d81	Merge pull request #6903 from adullact/fix/6861-feature-test-emails ... Les feature tests touchant aux emails échouent de manière aléatoire	2022-02-08 11:52:28 +01:00
Paul Chavard	2773e065ed	Merge pull request #6907 from adullact/fix/6865-instructeur-random-test ... Des tests sur les instructeurs échouent aléatoirement	2022-02-08 11:45:36 +01:00
Paul Chavard	0268511264	fix(manager): remove admins added for a day ... fix #6855	2022-02-08 11:18:44 +01:00
François Vantomme	eba9a87123	refactor(API Entreprise): raise an error on blank token	2022-02-07 15:18:16 +01:00
François Vantomme	dacc1dca68	fix(groupe instructeur): avoid false-negative tests due to array ordering	2022-02-04 17:43:08 +01:00
François Vantomme	27ccf6bbdd	fix(france connect): stub application name in tests	2022-02-04 17:42:02 +01:00
François Vantomme	9ff7fa73e4	Fix (Expert): clear emails before feature tests ... Failures: 1) Inviting an expert: as an Instructeur I can invite an expert Failure/Error: invitation_email = open_email(expert.email.to_s) Diff: -/procedures/2/avis/2/sign_up/email/expert1@expert.com +/procedures/1/avis/1/sign_up/email/expert1@expert.com	2022-02-04 17:40:03 +01:00
François Vantomme	2032eb8144	Test (Capybara): add no-sandbox option to headless chrome driver ... Activating this option fix the 'DevToolsActivePort file doesn't exist' error. https://stackoverflow.com/questions/50642308/webdriverexception-unknown-error-devtoolsactiveport-file-doesnt-exist-while-t	2022-02-04 17:34:10 +01:00
Christophe Robillard	447612abdf	fix a11y-8.9.1 ... no p tag when Champ text with no value	2022-02-02 19:03:40 +01:00
Pierre de La Morinerie	e6cf07b810	stats: move date formatting out of the Stat model ... Before this commit, the monthly dossiers count was serialized into the Stat record using human-formatted dates, as: ```ruby s.dossiers_in_the_last_4_months = { "octobre 2021"=>409592, "novembre 2021"=>497823, "décembre 2021"=>38170, "janvier 2022"=>0 } ``` Turns out the ordering of keys in a serialized hash is not guaranteed. After a round-trip to the database, the keys will be wrongly sorted. Instead we want to save raw Date objects, which will preserve the ordering. The date formatting can be applied at display-time by the controller. Fix #6848	2022-02-02 14:13:53 +01:00
Pierre de La Morinerie	ca58e60dc0	validators: rename revisions namespace to types_de_champ	2022-02-01 12:37:16 +01:00
Pierre de La Morinerie	d680602c84	models: validate private types_de_champ	2022-02-01 12:37:16 +01:00
Pierre de La Morinerie	e8e37cce15	models: refactor the types_de_champ validators ... Context: we want to validate public and private types_de_champ separately. Before we validated the whole revision (and then validators themselves enumerated all champs, public and private). Now we validate the actual public types_de_champ, which will let us validate separately the private types_de_champ.	2022-02-01 12:37:16 +01:00
Kara Diaby	842cc11689	tests	2022-01-31 10:03:44 +01:00
Kara Diaby	96556ca4b3	locales	2022-01-31 10:03:44 +01:00
Paul Chavard	4e7733e571	Revert "feat(attestation): revise attestations" ... This reverts commit e413872530.	2022-01-25 18:26:34 +01:00
Kara Diaby	c9f402aa5b	tests	2022-01-25 11:46:05 +01:00
Kara Diaby	2eb35065f8	fix dossier deletion mailers	2022-01-25 11:46:05 +01:00
Kara Diaby	7a49985e2c	tests	2022-01-24 16:47:47 +01:00
Martin	47fa95a577	feat(MonAvisEmbedValidator): allow mon avis button without title	2022-01-24 15:56:29 +01:00
Paul Chavard	e413872530	feat(attestation): revise attestations	2022-01-19 18:00:37 +01:00
Paul Chavard	c1cb89bb44	fix(revision): changed? conflicts with rails method	2022-01-19 18:00:37 +01:00
Paul Chavard	3d8471e064	fix(dossier): do not send notification on expiration when dossier is already deleted	2022-01-19 17:52:53 +01:00
Paul Chavard	403e71b41f	feat(procedure): only purge procedures without dossiers	2022-01-18 11:22:04 +01:00
Paul Chavard	7937e58caa	fix(archives): only export dossiers in archive groupe_instructeurs ... fix #6793	2022-01-18 11:16:20 +01:00
Paul Chavard	7e81b257b1	test(system): simplify select menu selector	2022-01-13 17:49:16 +01:00
Kara Diaby	bdcb0ca0e9	tests	2022-01-12 15:49:38 +01:00
Pierre de La Morinerie	062f52feb9	Fix ProcedureAdministrateursController#destroy ... - The "no remove oneself" rule wasn't actually enforced - `flash.error` is not a flash category	2022-01-07 15:39:58 +01:00
Pierre de La Morinerie	fb75a55b89	Add specs for Administrateurs::ProcedureAdministrateursController	2022-01-07 15:39:58 +01:00
Martin	383a92bcd9	fix(parallel_download_queue): tophoeus does not like raise from a request handler [crash straight to first frame]	2022-01-07 14:24:37 +01:00
Pierre de La Morinerie	2e1a3c32cb	helpers: handle flash[:error] ... Errors generated by the `invisible-catcha` gem are reported as `flash[:error]` (which differs from Rail's usual `flash[:alert]`). We probably shouldn't use flash[:error] in our own codebase; but we can handle its use in third-party libraries.	2022-01-06 14:09:31 +01:00
Pierre de La Morinerie	68b112e00a	helpers: don't crash on unknown flash level ... Errors generated by the `invisible-catcha` gem are reported as `flash[:error]` (which differs from Rail's usual `flash[:alert]`). Avoid crashing when the flash level passed to this helper is not known.	2022-01-06 14:09:26 +01:00
Martin	f770ac4907	fix(users/champs/piece_justificative#update): ensure to bump dossier.last_champ_updated_at otherwise instructeurs are not notified when user update their piece_justificative	2022-01-06 13:09:57 +01:00
Martin	a9ffaf942e	feat(attestation): can enable/disable attestation no matter the state of the procedure	2022-01-05 18:20:11 +01:00
Paul Chavard	cb66348916	a11y(select): cleanup select helpers in specs	2022-01-05 12:33:40 +01:00
Paul Chavard	968384952a	a11y(capybara): enable use of aria-label in spec	2022-01-05 12:33:40 +01:00
Paul Chavard	28c1763701	a11y(champs): generalize describedby and update to use new Combo props	2022-01-05 12:33:40 +01:00
simon lehericey	00871cfe13	Fix ping controller in dev ... For an unknown reason, ActiveRecord::Base.connected? does not work anymore in dev. It returns false negative. This simple workaround can timeout. The caller has to monitor the response time.	2022-01-05 11:44:32 +01:00
Martin	3eb1c1a421	feat(async_backend): switch to typhoeus	2022-01-04 16:27:23 +01:00
Martin	ce1b189dcd	refactor(DownloadManager): extract parallel download in dedicated class. move error management in custom class for procedure exports using the didicated class	2022-01-04 16:17:03 +01:00
Martin	2ed9cccba0	extract download all attachments in dedicated class using async/async-http for better perf	2022-01-04 16:17:03 +01:00
Martin	252eee272b	feat(support#create): block with invisible captcha [avoid painful captcha]	2022-01-04 14:49:00 +01:00
Paul Chavard	7f0dde9be4	fix(a11y): add aria to tabs	2022-01-04 09:44:32 +01:00
Kara Diaby	1ca553e088	rename hidden_by_instructeur by hidden_by_administration	2022-01-03 11:51:25 +01:00
Kara Diaby	598cb09c6d	tests	2021-12-29 17:37:58 +01:00
Martin	d0ab1711ff	fix(profil_controller#update_email): ensure we are not merging same account ... fix(profil_controller#update_email): changing email from current_user.email to current_user.email destroy current user. whoops ☠️' Update config/locales/en.yml Co-authored-by: Pierre de La Morinerie <pierre.de_la_morinerie@beta.gouv.fr> Update config/locales/fr.yml Co-authored-by: Pierre de La Morinerie <pierre.de_la_morinerie@beta.gouv.fr> Update spec/controllers/users/profil_controller_spec.rb Update config/locales/fr.yml Co-authored-by: Pierre de La Morinerie <pierre.de_la_morinerie@beta.gouv.fr> Update spec/controllers/users/profil_controller_spec.rb fix(spec): broken due to typo	2021-12-29 13:36:47 +01:00
Paul Chavard	4e779f445d	fix(instructeur): copy notifications settings from previous groupe instructeur ... fix #6763	2021-12-23 13:55:25 +01:00
Christophe Robillard	f9609b0b0b	fix zone specs ... by reenabling task before the next spec is run	2021-12-23 09:58:31 +01:00
Pierre de La Morinerie	4efc1053f9	specs: make dossiers deletion specs more robust ... It would fail when ran on some dates, like "21 Dec. 2021".	2021-12-21 17:20:32 +01:00
Christophe Robillard	822c754581	add namespace for populate_zones task	2021-12-16 17:20:06 +01:00
Christophe Robillard	882f92268c	update zone to procedures	2021-12-16 17:20:06 +01:00
François Vantomme	14e0c68266	feat(api particulier): add MESRI field	2021-12-16 16:45:18 +01:00
François Vantomme	3d81d4b541	feat(api particulier): add MESRI adapter	2021-12-16 16:45:17 +01:00
François Vantomme	66a9109cd7	feat(api particulier): add MESRI support to sources service	2021-12-16 16:45:17 +01:00
Martin	b9d13df483	fix(spec): avoid flacky test. 15.days ago is not always on the previous month. eg: this spec failed on 16 of december, stats is still in december	2021-12-16 15:02:17 +01:00
Christophe Robillard	84c648eef0	manual task for populating zones	2021-12-15 19:37:32 +01:00
simon lehericey	c7f7855f14	avoid phishing	2021-12-15 13:51:49 +01:00
Pierre de La Morinerie	be1ddb59ec	views: localize the stats partial ... Also rename 'procédure' to 'démarches'.	2021-12-14 15:03:22 +01:00
Martin	5ad0ee8ca9	fix(spec.flacky): try to use extractor in a more conventional way to extract file content	2021-12-14 14:18:59 +01:00
maatinito	0a31c8bc79	refactor date_trunc queries using groupdate gem	2021-12-14 08:50:11 +01:00
Martin	f7bc387e44	feat(flipper): use new way of generating archive only on some procedure flipped with new actor :zip_using_binary	2021-12-13 16:37:04 +01:00
simon lehericey	f0b0e7fd9a	Switch to usage of zip unix binary to create archive. Also use a dedicated queue for DelayedJob ... use dedicated archives queue As the used disk space will increase, we want a fined grain control move zip logic in dedicated method zip wip wip fix(spec): pass spec in green tech(improvements): avoid File.delete(folder), favor FileUtils.remove_entry_secure which is safer. Also wrap most of code that open file within blocks so it is cleaned when the block ends. Lastly use attachement.download to avoid big memory pressure [download in chunk, write in chunk] otherwise big file [124>1GO] are loaded in memory. what if we run multiple jobs/download in parallel ? fix(spec): try to retry with grace clean(procedure_archive_service_spec.rb): better retry [avoid to rewrite on open file] lint(things): everything	2021-12-13 16:37:04 +01:00
Martin	4b2e858a1a	fix(mon_avis_embed_validator): enhance regexp	2021-12-13 14:49:40 +01:00
Paul Chavard	c7b1dc7f87	fix(bulk_messages): destroy bulk messages with procedures	2021-12-09 16:16:40 +01:00
Paul Chavard	b67818e425	feat(helpscout): add a tag to messages submited through contact form	2021-12-09 11:47:13 +01:00
Paul Chavard	efd8ddb99e	fix(graphql): do not crash if attestation is nil	2021-12-08 13:12:42 +01:00
simon lehericey	3bdf6b63d9	small wording fixes	2021-12-08 11:19:30 +01:00
François Vantomme	6ab8ac0662	feat (api particulier): add Pole emploi field	2021-12-08 10:36:25 +01:00
François Vantomme	4cfc9f7d86	feat(api particulier): add Pole Emploi adapter	2021-12-08 10:36:11 +01:00
François Vantomme	a24cf18c9d	feat (api particulier): add Pole Emploi support to sources service	2021-12-08 10:36:11 +01:00
François Vantomme	2110ef072c	feat(api particulier): add DGFiP field	2021-12-07 11:03:05 +01:00
François Vantomme	08405226b7	style(api particulier): fix a typo in CNAF tests	2021-12-07 11:03:05 +01:00
François Vantomme	f0913edebd	feat(api particulier): add DGFiP adapter	2021-12-07 11:03:05 +01:00
François Vantomme	97de7c197d	feat(api particulier): add DGFIP support to sources service	2021-12-07 11:03:05 +01:00
Paul Chavard	5e0f8a5816	task(type_de_champ): migrate type_de_champ parent_id	2021-12-06 21:45:54 +01:00
Paul Chavard	2ba05bfb4f	fix(dossier): use depose_at instead of en_construction_at	2021-12-06 15:49:17 +01:00
Martin	a9413f9b12	feat(manager): add procedure_expires_when_termine_enabled to administrate	2021-12-06 07:49:59 +01:00
Martin	2778b42f1a	feat(instructeurs/procedures#show): re-align tabs at the start of the container. re-align demander cell content verticaly	2021-12-06 07:20:01 +01:00
Martin	081d5094a9	feat(instructeurs/procedure/dossiers#extend_conservation): add extends duree conservation in action button list, also rewire this action for user [extend by procedure.duree_conservation_dans_ds by default] but force 1.month for instructeur. add new icon for standby based on https://en.wikipedia.org/wiki/Power_symbol	2021-12-06 07:20:01 +01:00
Martin	d8a8d1fdab	feat(instructeur/dossier/header/_expiration_banner): split trads and add dedicated expiration banner for instructeur. also enhance wording to include duree conservation + extension_conservation ... feat(expiration_banner): enhance wording of expiration feat(dossiers/expiration_banner): enhance wording regarding expiration to include duree_conservation_dossiers_dans_ds + extension_conservation, also add spec on expiration_banner for instructeur	2021-12-06 07:05:17 +01:00
Martin	22531560d8	feat(tabs.expirants): re-order so it comes before deleted dossiers	2021-12-06 07:05:17 +01:00
Martin	8e9b15aef4	clean(expiration_banner): dedicated to user not shared	2021-12-06 07:05:17 +01:00
Martin	1bb868714c	fix(spec/lint/review): lint and fix spec of previous commits, also fix based on tchak feedback	2021-12-06 07:05:17 +01:00
Martin	d87f8b57cc	feat(instructeurs/procedures#show): add dossier experiant in procedure#show	2021-12-06 07:05:17 +01:00
Martin	2dfbc70d41	feat(instructeur#dossiers_count_summary): add counter for expirants. ignore brouillon	2021-12-06 07:05:17 +01:00
Martin	ce87878ff0	refactor(traitement.process_expired): move process expired to procedure	2021-12-03 16:32:36 +01:00
Christophe Robillard	9341c787a1	administrateur can add zone to procedure	2021-12-02 19:24:26 +01:00
Christophe Robillard	561f6fb274	add belongs_to zone for procedure	2021-12-02 19:23:05 +01:00
Christophe Robillard	5b8d872b6e	populate zones	2021-12-02 19:16:11 +01:00
Pierre de La Morinerie	b7d17b0989	models: validate that no drop-downs are empty on publishing ... Disallow publishing a procedure containing drop-downs with no selectable values.	2021-12-02 09:00:37 +01:00
Pierre de La Morinerie	8b3d31980a	specs: use Instructeur.bypass_email_login_token in the tests	2021-12-02 08:51:52 +01:00
Pierre de La Morinerie	ac07f05771	app: use Instructeur.bypass_email_login_token	2021-12-02 08:51:52 +01:00
Paul Chavard	46e2e34b89	fix(stats): remove super admin stats	2021-12-01 18:10:05 +01:00
François Vantomme	8fc14faa2a	fix(stat): enforce time travel when dealing with relative dates	2021-12-01 17:09:30 +01:00
Martin	725521c3a1	fix(expiration_banner): only show expirations info when flip is enabled ... fix(lint): lint haml fix(spec): enable flipper and allow procedure to receive flipper check when checking banner presence fix(doc): add missing documentation on readme regarding system testing with a visual feedback fix(typo): add missing accent clean(PR): feedback from Tchak, better to wrap feature check for expirability by procedure within dossier.expirable? helper	2021-11-30 16:05:32 +01:00
Kara Diaby	9d9ac54689	tests	2021-11-30 14:27:58 +01:00
Pierre de La Morinerie	99c77046d2	models: improve error message for invalid champs ... Avoid prepending the message with 'Draft revision '	2021-11-30 13:34:41 +01:00
Pierre de La Morinerie	b86dec8251	views: prevent procedure publication on validation error	2021-11-30 13:34:41 +01:00
Pierre de La Morinerie	9db62178d2	views: display revision errors on the procedure dashboard	2021-11-30 13:34:41 +01:00
Pierre de La Morinerie	52b0fbf9b7	models: validate repetitions on publishing	2021-11-30 13:34:41 +01:00
Pierre de La Morinerie	93124195fc	specs: refactor procedure_creation_spec.rb ... - Improve wording of specs description - Remove publication test (duplicate of procedure_publish_spec.rb)	2021-11-30 13:34:41 +01:00
Pierre de La Morinerie	8e69a9883b	specs: avoid using french in procedure_publish_spec.rb	2021-11-30 13:34:41 +01:00
simon lehericey	5a0fb6237f	😭 AASM does not support keyword arguments ... https://github.com/aasm/aasm/issues/672	2021-11-30 09:42:45 +01:00
Pierre de La Morinerie	184a401182	app: rename new_administrateur to administrateurs	2021-11-30 08:49:38 +01:00
simon lehericey	a0c0520502	avoid redirection to a deleted user	2021-11-29 15:27:17 +01:00
Kara Diaby	c75a9b6271	tests	2021-11-29 14:30:17 +01:00
Martin	970e43efb8	feat(stats#index): update Stat model to also query DossierDeleted in stats computation ... tech(question): discard_and_keep_track! ; are we really keeping track with default_scope { kept } ? feat(stats): add DeletedDossier in Stat computations Revert "tech(question): discard_and_keep_track! ; are we really keeping track with default_scope { kept } ?" This reverts commit d1155b7eeaaf1a9f80189e59667e109541fcb089. feat(stats): support deleted_dossiers for last_four_months_hash and cumulative_hash. extract sanitize query & merge hashes in methdos clean(rubocop): lint with rubocop Update db/migrate/20211126080118_add_index_to_deleted_at_to_deleted_dossiers.rb Co-authored-by: LeSim <mail@simon.lehericey.net> fix(rubocop): avoid uneeded allocation fix(migration): add concurrent index with expected synthax fix(brakeman): add ignore message since group date_trunc evaluation is used by only ourself	2021-11-26 13:29:40 +01:00
kara Diaby	06540c1b93	tests	2021-11-26 09:45:13 +01:00
Martin	fdf0f18fda	fix(i18n): wrap text under i18n.t ... i18n(france_connect/*): replace wording with i18n fix(lint): i18n key issue secu(views/france_connect/particulier/merge.html.haml): sanitize france_connect_email just in case fix(brakeman): sanitize FCI.email_france_connect when used with html_safe via an I18n.t, also add exception to brakeman	2021-11-25 17:34:37 +01:00
Martin	8a315a4ac1	feat(UserMailer.france_connect_merge_confirmation): in addition to distance_of_time_in_words, add exact expiration date	2021-11-25 17:34:37 +01:00
Martin	21894d0a0a	feat(france_connect/particulier#callback): in case the FC email exists as an DC account which is an instructor or and administrator, returns early to new_session_path so he can connect with this existing account	2021-11-25 17:34:36 +01:00
Martin	ff073f8884	Add confirmation by email when merging DC/FC accounts ... feat(fci.confirmation_code): add confirmation code to france_connect_informations feat(user_mailer.france_connect_confirmation_code): add confirmation by email mail method/preview/spec, pointing to merge_mail_with_existing_account (reuse existing method) feat(mail_merge): mail merge feat(merge.cannot_use_france_connect): same behaviour as callback clean(fci.confirmation_code): use same token for mail validation as merge feat(resend_france_connect/particulier/merge_confirmation): resend email with link. also enhance some trads, cleanup halfy finished refacto clean(tech): finalize story by plugging merge_with_new_account to email validation fix(deadspec): was removed fix(spec): broken after last refactoring lint(rubocop): space before parenthesis lint(haml-lint): yoohoooo space before = fix(lint): scss now :D Update app/assets/stylesheets/buttons.scss cleanup feat(france_connect): re-add confirm by email, with an option for confirmation by email instead of only confirmation by email fixup! Add confirmation by email when merging DC/FC accounts fix(lint): haml_spec failure	2021-11-25 17:34:34 +01:00
Paul Chavard	d847775c68	feat(traitements): add depose_at to dossiers	2021-11-25 12:57:55 +03:00
Pierre de La Morinerie	e5f5440663	models: explicitely save procedure's new revision ... Deep-cloned objects have all their relationships stale. Thus, for a newly deep-cloned revision, `revision.types_de_champs` returns `[]`, even when it actually has associated types de champ. This causes consecutive champs creations and re-ordering to fail in subtle ways, like: ``` procedure.draft_revision.add_type_de_champ(…) procedure.publish_revision! procedure.draft_revision.add_type_de_champ(…) procedure.draft_revision.move_type_de_champ(…) # this will fail ``` As `publish_revision!` created a new stale revision, moving the type de champ fails because not all existing champs are found until the object is refreshed. We don't hit this path in production, because usually only a single operation is made in a request. To fix this, save the new revision before associating it as the draft procedure. (Another option would be to `reload` the revision after creation, but this seems better contained and matches the name of the method.)	2021-11-25 08:49:17 +01:00
mfo	e7d9d047fe	Merge branch 'main' into 6649-etq-usager-instructeur-rendre-la-suppression-plus-visible	2021-11-24 14:07:32 +01:00
Paul Chavard	758e7d68e6	fix(graphql): fix and improuve query parsing for logs	2021-11-24 13:23:05 +03:00
simon lehericey	4efd15377c	spec	2021-11-23 14:17:59 +01:00
Pierre de La Morinerie	997c197980	specs: simplify the syntax of some factories	2021-11-23 08:07:07 +01:00
Pierre de La Morinerie	2203a7762f	specs: create dossier revision and individual declaratively	2021-11-23 08:07:07 +01:00
Pierre de La Morinerie	f2233300b6	specs: assign the default groupe instructeur declaratively	2021-11-23 08:07:07 +01:00
Pierre de La Morinerie	0e809ac1a2	specs: build the default groupe instructeur before the create callback ... This allows for better ergonomics, by having the default groupe instructeur available even before the procedure is saved.	2021-11-23 08:07:07 +01:00
Pierre de La Morinerie	032e3e2cb1	specs: create the procedure administrateur declaratively ... It seems better to create associations in an declarative fashion, rather than using imperative code. This also makes the attribute compatible with build_stubbed.	2021-11-23 08:07:07 +01:00
Pierre de La Morinerie	970c3e4b2b	specs: avoid executing business logic in Procedure factory ... Calling business logic in a factory is a code-smell, because it usually requires the object to be saved into database, and may have unintended consequences when the business logic is changed. Also, this allows to just build a published procedure, without saving it to the database.	2021-11-23 08:07:07 +01:00
Pierre de La Morinerie	d8fbcfe2e2	specs: explicitely pass the dossier to champs factories ... Otherwise the factory will not know in avance which procedure this champs belongs to.	2021-11-23 08:07:07 +01:00
Pierre de La Morinerie	ef2d9a3e86	specs: fix :champ_siret factory not using the procedure ... Unlike all other champs factories, :champ_siret would attempt to build a champ with a `nil` procedure (instead of using the dossier's one).	2021-11-23 08:07:07 +01:00
Pierre de La Morinerie	774ef00f8e	specs: improve dossier_spec#build_default_individual	2021-11-23 08:07:07 +01:00
Pierre de La Morinerie	8d89ae366b	specs: minor cleanups	2021-11-23 08:07:07 +01:00
Pierre de La Morinerie	09ca70eef0	specs: improve search controller specs	2021-11-23 08:07:07 +01:00
Martin	b6adf5fc72	feat(dossiers/show): enhance header with expirations message/banner. also ensure consistent design between dossier states ... fix(spec): broken due to last refactoring spec(dossier.extend_conservation): add system spec lint(ruby): still not yet ready for auto lint in IDE...	2021-11-23 05:50:25 +01:00
Martin	8368d62ed3	fix(spec): broken due to new view var	2021-11-19 15:53:15 +01:00
Martin	3d1533dee9	feat(users/dossiers?statut=dossiers-expirant): add dossiers-expirant tab	2021-11-19 15:14:39 +01:00
Martin	eecc0c38b6	lint(rubocop): come on, maybe i will find the inspiration to setup it up in my ide	2021-11-19 14:36:21 +01:00
Martin	608a85148f	feat(Dossier.close_to_expiration): add method to find any kind of dossier close to expiration [reuse previous scopes], add missing spec to termine_close_to_expiration, complement spec for each kind of expiration scope with general close_to_expiration spec	2021-11-19 14:28:54 +01:00
mfo	82b23b92c0	Merge branch 'main' into 6624/etq-instructeur-je-souhaite-supprimer-des-messages-envoyes-par-erreur	2021-11-17 05:41:56 +01:00
Paul Chavard	e74d599042	feat(procedure): remove duree_conservation_dossiers_hors_ds	2021-11-16 19:55:56 +03:00
mfo	1d174df2ec	Merge branch 'main' into 6624/etq-instructeur-je-souhaite-supprimer-des-messages-envoyes-par-erreur	2021-11-16 16:37:15 +01:00
Martin	f0950b592b	clean(CommentaireService): extract soft delete within controller. returning an instance with an error[:base] is not persisted with validation : avoid poluting stuff	2021-11-16 16:13:11 +01:00
Martin	8bbd77f89f	refactor(mail.delay): use simplier implementation using after_action to prevent email delivery with delay	2021-11-16 15:12:05 +01:00
Martin	e48b6e0c1f	tech(lint): rubocop	2021-11-16 14:30:06 +01:00
Martin	0aecc301c9	refactor(Commentarie.soft_delete): use discard	2021-11-16 14:28:38 +01:00
Martin	988fe34d0a	fix(spec): add missing double	2021-11-16 03:42:31 +01:00
simon lehericey	e3c1e19424	include hidden dossier in merge	2021-11-15 23:14:41 +01:00
Martin	c68fa2d7f3	feat(Commentaire.notify_user): wait 5 minutes before sending email to user when instructor write a commentaire. leaving some space for instructor to destroy his message	2021-11-15 15:38:57 +01:00
Martin	f8783c9f00	fix(spec): stop doing time comparisson, ensure it is not more nil	2021-11-15 15:23:57 +01:00
Martin	a74ca8ad39	fix(spec): scope out time as reference for time comparission, hope not a matter of precision	2021-11-15 14:55:35 +01:00
Martin	f1293814a3	fix(spec): apparently we do store time with zone	2021-11-15 14:35:43 +01:00
Martin	4042d51d1a	tech(lint): rubocopify	2021-11-15 14:17:57 +01:00
Martin	d4c74b5621	feat(rc.1): refine with better translations, better design	2021-11-15 14:15:05 +01:00
Martin	3b78a9d81a	feat(rc): first stable	2021-11-15 13:53:32 +01:00
Martin	8b931a57d4	feat(CommentairesController#destroy): implement destroy endpoint using CommentaireService	2021-11-15 13:18:10 +01:00
Martin	c7bfd1af04	feat(CommentaireService.soft_delete): ensure it purge piece_jointe later	2021-11-15 12:59:38 +01:00
Martin	9a8ec1087c	feat(commentaire.soft_delete): wrap deletion behaviour in service	2021-11-15 12:43:53 +01:00
Martin	5b72bdec7e	fix(Commentaire.sent_by?): &.email compared to nil could sent by true when nil==nil, avoid this one	2021-11-15 12:01:56 +01:00
Martin	b03dc6ad5d	wip(dossiers/messages/_message): poc destroy button with expected ACL support	2021-11-15 11:30:41 +01:00
Paul Chavard	da47f491b3	fix(dossier): nullify close to expiration notice timestamps when changing state	2021-11-11 12:52:58 +01:00
Paul Chavard	71939c650b	fix(export): remove wrong columns from repetition spreadsheets ... This fix prevent repetition children types de champ from being pulled from cloned procedures. stable_id is stable across revisions but also across cloned procedures.	2021-11-10 20:45:32 +01:00
Pierre de La Morinerie	9dd7806ae5	specs: add two missing fields to the brouillon spec	2021-11-09 15:22:20 +01:00
Pierre de La Morinerie	5dbb9f9e3c	specs: fix flaky "dossier brouillon" spec ... The previous fix (scrolling to the viewport) didn't actually worked, because the code tried to scroll the checkbox itself.	2021-11-09 15:21:59 +01:00
kara Diaby	1b27ab5aff	tests	2021-11-05 13:32:21 +01:00
simon lehericey	d1162d7493	add e2e spec	2021-11-04 16:10:09 +01:00
simon lehericey	9041e201e8	one merge at a time	2021-11-04 16:10:09 +01:00
simon lehericey	b160086cc5	update update_email to allow merge	2021-11-04 16:10:09 +01:00
simon lehericey	652b8367be	accept or refuse merge	2021-11-04 16:10:09 +01:00
Paul Chavard	ba0211ba52	feat(champ): ask for departement before asking for commune	2021-11-04 11:55:25 +01:00
Paul Chavard	122cdacbc2	fix(avis): destroy avis for discarded en_construction dossiers	2021-11-04 10:12:44 +01:00
Pierre de La Morinerie	0a541d678d	graphql_controller_spec: create several dossiers only when required ... Creating dossiers is faster than creating a procedure, but still slow. We can create a single dossier in the default case, and only create several others when the example requires it. Speeds up this spec from 0m 57s to 0m 49s.	2021-11-03 19:38:01 +01:00
Pierre de La Morinerie	f0e045ad25	graphql_controller_spec: create all types de champs only when required ... Creating a procedure with all available types de champ is slow. We can create a simpler procedure in the default case, and only create all types de champs when the example requires it. Speeds up this spec from 1m 55s to 0m 57s.	2021-11-03 19:38:01 +01:00
Pierre de La Morinerie	e02251c0e5	graphql_controller_spec: populate all champs only when required ... Creating a dossier with available champs populated is slow. We can create simpler dossiers in the default case, and only populate all champs when the example requires it. Speeds up this spec from 2mn 20s to 1m 55s.	2021-11-03 19:38:01 +01:00
Pierre de La Morinerie	bb1bc9140d	graphql_controller_spec: remove unused line	2021-11-03 19:38:01 +01:00
Pierre de La Morinerie	04159056af	specs: clarify spec by replacing some context by describe	2021-11-03 19:38:01 +01:00
Pierre de La Morinerie	b06183d7bf	specs: rename Dossier's with_all_champs to with_populated_champs ... This better reflects what the trait is used for, and disambiguate it from the similarly named trait in the Procedure factory.	2021-11-03 19:38:01 +01:00
Paul Chavard	f6b8689a97	fix(revisions): fix repetitions export with revisions	2021-11-03 18:20:48 +01:00
Paul Chavard	da49a6447f	refactor(repetition): optimize and add a transaction around repetition add row	2021-10-28 14:54:33 +02:00
Paul Chavard	c4b93f8d4a	fix(groupe_instructeur): unfollow dossiers when removed from groupe instructeur	2021-10-28 14:45:52 +02:00
simon lehericey	7935e42109	Add merge log	2021-10-28 14:39:13 +02:00
simon lehericey	3328c9a132	merge move invite as well	2021-10-28 14:39:13 +02:00
simon lehericey	f2ccb39912	merge destroys the old role and account	2021-10-28 14:39:13 +02:00
simon lehericey	c725999582	move merge method to user	2021-10-28 14:39:13 +02:00
simon lehericey	3d524e9488	Change factory user password to be compatible with admin pass constraint	2021-10-28 14:39:13 +02:00
Paul Chavard	1393b7b07b	fix(rebase): fix repetition champ rebase	2021-10-28 13:27:53 +02:00
kara Diaby	71aa13f468	tests	2021-10-27 12:00:39 +02:00
Pierre de La Morinerie	9fd38cae5e	specs: migrate from features to system specs ... System specs have been available since Rails 5.1, and are better integrated with the Rails framework. - Rename `spec/features` to `spec/system` - Rename `feature do` to `describe do` - Configure Capybara for system specs Steps mostly taken from https://medium.com/table-xi/a-quick-guide-to-rails-system-tests-in-rspec-b6e9e8a8b5f6	2021-10-26 12:24:46 +02:00
Pierre de La Morinerie	df9fa258ae	specs: remove database_cleaner ... This is not needed for integration tests since Rails 5.1. See https://www.nicholasjacques.io/blog/you-probably-dont-need-databasecleaner/	2021-10-26 12:24:46 +02:00
Pierre de La Morinerie	b1eee27dd7	specs: remove outdated workaround for silencing puma logs	2021-10-26 12:24:46 +02:00
Pierre de La Morinerie	cedbd31d39	specs: only build an admin when building a procedure ... This should slighly be faster than doing a create in the middle of the build.	2021-10-26 12:03:30 +02:00
Pierre de La Morinerie	a2b91c8ec6	factories: cleanup Administrateur, Instructeur and Expert factories ... This changes: - avoids relying on application code to create mock objects, - allows to build Administrateur or Instructeurs without saving them.	2021-10-26 12:03:30 +02:00
Pierre de La Morinerie	0ff95df221	specs: improve speed of phone_champ_spec ... Re-use the same champ for each test. This is safe, and makes the test go from 4s to 1s.	2021-10-26 12:03:30 +02:00
Pierre de La Morinerie	fccf75710a	specs: avoid creating uneeded champs on geo_area ... It makes the test much faster.	2021-10-26 12:03:30 +02:00
Pierre de La Morinerie	d0e87a08cf	services: cache zxcvbn dictionaries per-thread ... Before, every time a password was tested, the dictionaries were parsed again by zxcvbn. Parsing dictionaries is slow: it may take up to ~1s. This doesn't matter that much in production, but it makes tests very slow (because we tend to create a lot of User records). With this changes, the initializer tester is shared between calls, class instances and threads. It is lazily loaded on first use, in order not to slow down the application boot sequence. This uses ~20 Mo of memory (only once for all threads), but makes tests more that twice faster. For instance, model tests go from **8m 21s** to **3m 26s**. NB: An additionnal optimization could be to preload the tester on boot, before workers are forked, to take advantage of Puma copy-on-write mechanism. In this way all forked workers would use the same cached instance. But: - We're not actually sure this would work properly. What if Ruby updates an interval ivar on the class, and this forces the OS to copy the whole data structure in each fork? - Puma phased restarts are not compatible with copy-on-write anyway. So we're avoiding this optimisation for now, and take the extra 20 Mo per worker.	2021-10-25 12:04:56 +02:00
Paul Chavard	1561ea82f6	fix(transfer): manually nullify staled transfers references	2021-10-21 13:54:26 +02:00
Paul Chavard	2a3a9dd822	feat(revisions): rebase dossiers brouillons	2021-10-20 17:26:09 +02:00
Paul Chavard	67e98f79c9	feat(revisions): add stable_id to changes	2021-10-20 17:25:34 +02:00
Pierre de La Morinerie	7b6420d427	specs: set i18n cookie before running browser specs ... Otherwise the browser specs use the dault browser language, which may be English depending on the system language.	2021-10-19 16:41:36 +02:00
Pierre de La Morinerie	0de8fd23c7	specs: remove invalid js: true specifier ... Views specs cant't run Javascript.	2021-10-19 16:41:36 +02:00
simon lehericey	d19ad2840c	rename preexisting to targeted, remove duplicated test	2021-10-19 16:12:42 +02:00
simon lehericey	52b7e85954	merge administrateur in user_controller	2021-10-19 16:12:42 +02:00
simon lehericey	866df74706	merge admin	2021-10-19 16:12:42 +02:00
simon lehericey	44c880adc4	allow instructeur and administrateur to change their email to legit domain (#6550)	2021-10-19 15:54:57 +02:00
simon lehericey	f54dfe6ead	Do not raise error if user is nil ... I do not get when it happens	2021-10-19 11:21:24 +02:00
simon lehericey	46fd15416b	add end to end test	2021-10-14 14:47:50 +02:00
simon lehericey	933d7b8c8d	merge with another preexisting account	2021-10-14 14:47:50 +02:00
simon lehericey	ce40e1127d	merge with another new account	2021-10-14 14:47:50 +02:00
simon lehericey	19f81b594b	merge with an existing account by using the password	2021-10-14 14:47:50 +02:00
simon lehericey	218e4633a9	securely retrieve fci	2021-10-14 14:47:50 +02:00
simon lehericey	f7299da1e7	launch merge process if an unlinked DS account with the same email exists	2021-10-14 14:47:50 +02:00
simon lehericey	f6879eba60	associate_user take a target email	2021-10-14 14:47:50 +02:00
simon lehericey	09f828a6a2	create_merge_token!	2021-10-14 14:47:50 +02:00
simon lehericey	34862f41e0	Add fci valid_for_merge	2021-10-14 14:47:50 +02:00
simon lehericey	6826bf03b0	Sign in with a user linked by france connect sub (openid) ... instead of looking linked user by email because : - follows FC recommendation to fetch ds account by openid - the email is not a valid key as many user can share the same FCI email. The following scenario is now working A user A (email: 1@mail.com) uses FC to connect to DS => It is connected as 1@mail.com Another user B (email: generic@mail.com) uses FC to connect => It is connected as generic@mail.com The first user A change its FC email to generic@mail.com and connect to DS => It is still connected as 1@mail.com	2021-10-14 14:47:50 +02:00
simon lehericey	2f470b25aa	spec cleaning	2021-10-14 14:47:50 +02:00
simon lehericey	87de9e38c6	allow draft to be saved with invalid cnaf champ	2021-10-12 14:27:20 +02:00
simon lehericey	cd7bafaa0d	clean log_out spec helper	2021-10-12 14:27:20 +02:00
simon lehericey	35c7f05a0a	source service supports unknown scope	2021-10-12 14:27:20 +02:00
simon lehericey	ac60d6c5a1	homogennize api particulier endpoint test url	2021-10-12 14:27:20 +02:00
simon lehericey	ecc26897e2	add end to end spec	2021-10-12 14:27:20 +02:00
simon lehericey	40d0cfcdc4	add champ validation	2021-10-12 14:27:20 +02:00
simon lehericey	c76d1043fa	add cnaf champ	2021-10-12 14:27:20 +02:00
simon lehericey	d68129b34d	add cnaf type de champ	2021-10-12 14:26:40 +02:00
simon lehericey	b69dafc3d4	CNAF in lowercase	2021-10-12 14:26:40 +02:00
simon lehericey	7c65571fca	add case when the old_expert or old_instructeur is nil	2021-10-12 11:04:06 +02:00
simon lehericey	ec8ccad465	typo	2021-10-12 11:03:34 +02:00
simon lehericey	d7e621d167	beef up the merge methods	2021-10-07 15:51:31 +02:00
simon lehericey	77d14d4a60	forbid admin merge yet	2021-10-07 15:51:31 +02:00
simon lehericey	5009c583ea	Add notice when merging account	2021-10-07 15:51:31 +02:00
simon lehericey	a480b31eb5	merge expert	2021-10-07 15:51:31 +02:00
simon lehericey	136f29524e	merge instructeur	2021-10-07 15:51:31 +02:00
simon lehericey	9a6a53349f	simple cases when the preexisting targeted account does not have instructeur or profile profile	2021-10-07 15:51:31 +02:00
simon lehericey	c56199e8f7	spec cleaning	2021-10-07 15:51:31 +02:00
simon lehericey	195583c0bd	Enable manager specs	2021-10-07 15:51:31 +02:00
Paul Chavard	9d5c5447c2	fix(dossier): do not attempt to destroy transfers when a dossier is destroyed ... we had a dependent option on both sides of a relationship which created race conditions	2021-10-06 17:51:09 +02:00
kara Diaby	919d708ec4	tests	2021-10-05 15:37:30 +02:00
kara Diaby	cbedef996b	tests	2021-10-05 15:00:21 +02:00
simon lehericey	1000417bc9	update notifications_for_dossier used in dossier show	2021-10-05 12:05:43 +02:00
simon lehericey	65911b7680	update with_notifications dossiers scope (used in procedure index and show)	2021-10-05 12:05:43 +02:00
simon lehericey	f662b28baf	update identity_updated_at column when user identity change	2021-10-05 12:05:43 +02:00
Peng-Fei DONG	dee536fca1	app: localize CSV import for groupe instructeurs	2021-10-05 10:58:15 +02:00
simon lehericey	9679e233cd	[Fix #6512] admin preview in new tab	2021-10-05 10:47:58 +02:00
simon lehericey	64351d0287	[Fix #6504] Fix exception raised when deleting a transfer	2021-10-01 12:11:03 +02:00
Pierre de La Morinerie	b466fa7878	spec: ensure checkbox is visible before clicking it ... There's a random failure in this spec, where the CI triggers this error: > Failure/Error: check('checkbox') > > Selenium::WebDriver::Error::ElementClickInterceptedError: > element click intercepted: Element <input required="required" type="checkbox" value="on" name="dossier[champs_attributes][7][value]" id="dossier_champs_attributes_7_value"> is not clickable at point (205, 892). Other element would receive the click: <div class="send-dossier-actions-bar">...</div> That's because the checkbox is partially overlapped by the sticky action bar at the bottom of the screen – but only _some of the time_. This commit attempts to fix the issue by manually scrolling the checkbox at the center of the screen before clicking it.	2021-10-01 00:33:57 +02:00
simon lehericey	0cd9bcb1ab	fix #6495	2021-09-28 15:53:18 +02:00
Paul Chavard	5933194149	feat(log): stop logging user emails ... fix #6485	2021-09-27 14:56:00 +02:00
simon lehericey	57604b9c89	add schema validations	2021-09-22 12:08:24 +02:00
simon lehericey	75043070da	add CNAFAdapter	2021-09-22 12:08:24 +02:00
simon lehericey	07962cc2c7	service: match remote keys	2021-09-22 12:08:24 +02:00
Ismael MOUSSA S	bdbb4deb87	ADD FILE_MAX_SIZE constant to set allow file size limit	2021-09-21 12:04:56 -05:00
simon lehericey	1446660ca3	an api_particulier_token change erases previous api_particulier_sources	2021-09-21 11:21:10 -05:00
simon lehericey	c87f3f7fb6	faster jeton_particulier_controller_spec	2021-09-21 11:21:10 -05:00
simon lehericey	2e1bed8748	an admin can save its sources	2021-09-21 11:21:10 -05:00
simon lehericey	8d747ff16e	add sanitize method to service	2021-09-21 11:21:10 -05:00
Pierre de La Morinerie	eef90efd49	app: fix exception during password reset when the token has expired	2021-09-21 10:30:09 -05:00
simon lehericey	a7ec77f0a8	do not display the action for instructeur	2021-09-20 13:58:11 +02:00
simon lehericey	7239657a75	[Fix #6481] a user see its waiting transfers	2021-09-20 13:58:11 +02:00
simon lehericey	c34476a766	a user can transfer all its dossier	2021-09-20 13:58:11 +02:00
Paul Chavard	a8d04d6fc8	test(routing): fix routing feature spec	2021-09-18 11:22:35 +02:00
Paul Chavard	ad5279f4ab	test(groupe_instructeur): fix groupe_instructeur controller spec	2021-09-18 11:22:35 +02:00
Paul Chavard	eea6b961d7	refactor(routage): remove administrateur_routage feature flag	2021-09-18 11:21:26 +02:00
simon lehericey	5dbd81ebeb	show api particulier sources	2021-09-17 13:50:23 +02:00
simon lehericey	8327c6fd0c	add ApiParticulier::Service::Sources	2021-09-17 13:50:23 +02:00
simon lehericey	1d06c15ac0	save api particulier scopes	2021-09-16 09:49:16 +02:00
simon lehericey	6c6205e188	a cloned procedure to a different admin does not keep api_particulier token and scopes	2021-09-16 09:30:11 +02:00
simon lehericey	7ee360df30	add logic to detect empty scopes	2021-09-16 09:09:34 +02:00
simon lehericey	ee6d19e3ee	an admin can save it's api particulier token ... Co-authored-by: François VANTOMME <akarzim@gmail.com>	2021-09-15 14:56:42 +02:00
simon lehericey	4c0dd43055	add jetons particulier index page ... Co-authored-by: François VANTOMME <akarzim@gmail.com>	2021-09-15 14:37:04 +02:00
simon lehericey	87cb16093f	fetch token introspection ... Co-authored-by: François VANTOMME <akarzim@gmail.com>	2021-09-15 14:37:04 +02:00
Paul Chavard	4850c3b02d	fix(i18n): enable locale for email previews	2021-09-09 13:06:51 -05:00
Pierre de La Morinerie	407f46b7de	gems: remove smart_listing ... It was only used in the old design, which we recently removed completely.	2021-09-09 09:58:41 -05:00
Pierre de La Morinerie	5cbf939911	spec: fix syntax of get requests in archives_controller_spec ... Those were generating Ruby warnings: > warning: Using the last argument as keyword parameters is deprecated	2021-09-09 09:58:41 -05:00
Pierre de La Morinerie	e5f449b595	devise: unify password reset views ... By default, Devise will look for views: 1. First in `views/resource/passwords/…`, 2. Then in `views/devise/passwords/…` if not found. By moving the views to `views/devise`, we avoid having a partial in `views/shared` that we need to include manually, and instead let Devise do the job automatically.	2021-09-09 09:40:40 -05:00
Pierre de La Morinerie	80f9d4adc0	devise: use password_strength component in SuperAdmin::PasswordsController	2021-09-09 09:40:39 -05:00
Pierre de La Morinerie	62e4f7ee32	devise: use password_complexity in User::PasswordsController ... This fixes the password strength meter no longer being displayed when an admin changes their password.	2021-09-09 09:40:39 -05:00
Pierre de La Morinerie	ed8b19d2eb	app: use password_complexity in Administrateurs::ActivateController	2021-09-09 09:40:39 -05:00
Pierre de La Morinerie	428ca8755f	app: add a password_complexity component ... This component will replace the previous `password_field` component.	2021-09-09 09:40:39 -05:00
Pierre de La Morinerie	586f8ec543	models: improve password complexity specs	2021-09-09 09:40:39 -05:00
Paul Chavard	00c7c7c419	test(dossier): test dossier transfer	2021-09-08 15:49:04 +02:00
Paul Chavard	3235f42a63	feat(dossier): add dossier transfers UI	2021-09-08 15:10:43 +02:00
Paul Chavard	d6cbdf2a48	feat(dossier): add dossier transfer models	2021-09-08 14:39:46 +02:00
simon lehericey	9fc195f0e5	add test to dossier_projection_service	2021-09-07 15:17:06 +02:00
Paul Chavard	74e277d0a2	feat(graphql): add an option to dossier state change mutations to disable notifications	2021-09-07 14:21:48 +02:00
Paul Chavard	9e30d5fc22	fix(virus scan): prevent virus scans in specs	2021-09-07 14:21:48 +02:00
simon lehericey	367f508e2e	linked_drop_down_list: empty primary => empty secondary	2021-09-07 10:09:18 +02:00
Paul Chavard	6a5a8233b5	feat(i18n): send dossier emails with its user locale and improuve translations	2021-09-07 09:51:23 +02:00
Pierre de La Morinerie	8bb283d977	app: delete old Admin::ProceduresController	2021-09-02 14:51:31 -05:00
Pierre de La Morinerie	a004ac59df	app: move archive to NewAdministrateur::ProceduresController	2021-09-02 14:51:31 -05:00
Pierre de La Morinerie	e7c8a9fff5	app: move clone to NewAdministrateur::ProceduresController	2021-09-02 14:51:31 -05:00
Pierre de La Morinerie	56fa7e7cd6	app: move destroy to NewAdministrateur::ProceduresController ... The code was already moved; only the route and tests were not.	2021-09-02 14:51:31 -05:00
Pierre de La Morinerie	3e83ad454f	app: move new_from_existing to NewAdministrateur::ProceduresController	2021-09-02 14:51:31 -05:00
Pierre de La Morinerie	7729385d89	controllers: remove dead code on Admin::ProceduresController ... This code has been migrated to NewAdministrateur::ProceduresController.	2021-09-02 14:51:26 -05:00
Pierre de La Morinerie	0f9d7d6b8c	app: remove old Admin::InstructeursController ... It was only hosting the deprecated "Instructeurs globally attached to this admin", which wasn't used anywhere in the app anymore.	2021-09-02 14:40:36 -05:00
Paul Chavard	a3cc072bbd	feat(i18n): translate countries selector	2021-08-31 13:15:26 +02:00
Pierre de La Morinerie	b80f6a9f1b	spec: fix some manager tests not running	2021-08-26 11:44:47 -05:00
Paul Chavard	8e1bfb469f	fix(dossier): send expiration notifications 2 weeks prior to supression instead of a month	2021-08-26 11:28:57 +02:00
Paul Chavard	1399d9bba9	feat(graphql): expose demarche descriptor on dossier type ... We don't want to expose full demarche type on dossiers because it would open the door for recursive queries that we want to avoid. DemarcheDescriptorType is a lightweight representation of demarche metadata.	2021-08-25 11:12:24 +02:00
Pierre de La Morinerie	47e1555dce	i18n: properly translate the locale dropdown title	2021-08-24 12:57:51 -05:00
Pierre de La Morinerie	9741108094	lib: remove the 'migrated' key on filters ... In a9a4f6e2a8, a task to migrate ProcedurePresentation's filters was added. This task added a "migrated: true" key to all migrated filters. Now that this task has run, we can safely remove the extra key. In a previous version of this commit, the migration would fail for invalid ProcedurePresentation records. This is now fixed.	2021-08-24 08:42:22 -05:00
Christophe Robillard	83b6c5d7c7	replace deprecated axe-matchers by axe-core-spec	2021-08-24 08:09:17 -05:00
Paul Chavard	3b6528decf	feat(i18n): enable localization by query param ... Providing a query param ("locale") will enable localization. A language picker will be shown once localization is activated. Locale is stored in a cookie "locale".	2021-08-24 12:42:40 +02:00
Ismael MOUSSA S. (T0194673)	330333aac4	6407 - Fix flash message typo in new administrateur/groupe instructeurs controller and its related spec	2021-08-20 20:10:44 +02:00
Christophe Robillard	8f2e0660d3	add spec for dossier with commune	2021-08-19 08:04:47 +02:00
Christophe Robillard	e06f11f33f	add code insee libelle for commune export	2021-08-19 08:04:47 +02:00
Christophe Robillard	4a6c22d6a6	export code insee for commune champ	2021-08-19 08:04:47 +02:00
Paul Chavard	ffa8c0c80a	feat(dossiers): enable dossiers termine expiration behind feature flag ... feature flag "procedure_process_expired_dossiers_termine" controls if a procedure has expiration enabled on dossiers termine re #3796	2021-08-18 16:11:35 +01:00
Christophe Robillard	031b74759f	archives: move bugreport	2021-08-05 09:24:20 +02:00
Christophe Robillard	38e3469e9a	add bug report to archive	2021-08-03 14:51:41 +02:00
simon lehericey	b29bae4707	a procedure has an encrypted api_particulier_token ... Co-authored-by: François VANTOMME <akarzim@gmail.com>	2021-07-30 11:18:44 +02:00
François Vantomme	17b659539f	Feat (API Particulier): new encryption service	2021-07-30 11:18:44 +02:00
kara Diaby	69393c2921	modify groupe instructeur controller	2021-07-27 19:38:22 +02:00
kara Diaby	9c976c6b71	fixup! tests	2021-07-27 19:38:21 +02:00
Paul Chavard	64cfb4d64e	Fix sort with revisions	2021-07-23 10:57:04 +02:00
Pierre de La Morinerie	6475cdff7a	Revert "Suppression de la clef "migrated": true sur les filtres des ProcedurePresentation"	2021-07-23 09:26:13 +02:00
Pierre de La Morinerie	e1909ed29f	brouillon: redirect to sign-in when disconnected ... There are two cases where the draft auto-save might fail because the user is no longer authenticated: - The user signed-out in another tab, - The brower quit and re-opened, so the Session cookie expired. In both cases, the auto-save will never succeed until the user authenticates again, so displaying a "Retry" button is cruel. Moreover, in plus of all auto-save requests failing with a small error, the actual hard failure only occurs after filling all the form and trying to submit it. Then the user is redirected to the sign-in page – but all their changes are lost. Instead, we now redirect to the sign-in page on the first 401 error during the auto-save, let the user sign-in, and then redirect back to the form.	2021-07-22 11:58:02 +02:00
Paul Chavard	388fb39eb5	Fix false positive blank champ warnings	2021-07-22 10:45:25 +02:00
Paul Chavard	ac0f50b488	Improuve champ blank check	2021-07-22 10:45:25 +02:00
Pierre de La Morinerie	fd74d9a062	lib: remove the 'migrated' key on filters ... In a9a4f6e2a8, a task to migrate ProcedurePresentation's filters was added. This task added a "migrated: true" key to all migrated filters. Now that this task has run, we can safely remove the extra key.	2021-07-20 16:51:32 +02:00
Pierre de La Morinerie	fda59c9231	lib: remove outdated tasks	2021-07-20 15:34:31 +02:00
Pierre de La Morinerie	32ab2f0a80	instructeur: limit the maximum size of a filter value ... This prevents the URL from exceeding the max size, and causing '414: Request-URI too large' errors.	2021-07-20 14:49:48 +02:00
Pierre de La Morinerie	831672391e	app: use a long-lived cookie for CSRF token ... See the ADR document for rationale.	2021-07-20 11:11:52 +02:00
Pierre de La Morinerie	446c57ed63	specs: add a feature test for forgery protection	2021-07-20 11:11:52 +02:00
Pierre de La Morinerie	71741c5f98	views: fix checkbox wrongly selected in multiple_drop_down_list ... The check for whether the checkbox should be checked or not was made by matching the whole string. Thus, given two options 'valid' and 'invalid', the check for the presence of 'valid' would succeed even when only 'invalid' was present in the values (because `'valid'.includes?('invalid')`. The code now checks against the list of items in the selected_options.	2021-07-20 09:01:07 +02:00
kara Diaby	0b6c7dace7	tests	2021-07-15 16:32:07 +02:00
Pierre de La Morinerie	40b3ea8ad6	Revert "Instructeurs : limitation de la valeur d'un filtre à 100 caractères"	2021-07-13 18:19:46 +02:00
kara Diaby	d2d046a39d	fix encoding problems with cherlock Holmes gem	2021-07-13 10:58:41 +02:00
Pierre de La Morinerie	3c8a88a660	instructeur: limit the maximum size of a filter value ... This prevents the URL from exceeding the max size, and causing '414: Request-URI too large' errors.	2021-07-08 16:17:22 +02:00
Paul Chavard	527db7631e	Add a point on map from coordinates input	2021-07-07 13:33:28 +02:00
Paul Chavard	ab31087f23	Hide cadastres if there is none	2021-07-07 12:28:27 +02:00
Pierre de La Morinerie	37c62ac0a3	app: display standard error page when no cookies are present ... This occurs mostly when Safari attempts to perform a POST request again (without sending any of the cookies). In that case, our custom `422.html` page is more helpful to the user (because it has a link to the previous page) than a "No cookies" blank text.	2021-07-06 16:29:22 +02:00
Christophe Robillard	bc07a875eb	integrate a mininum weight for the average dossier weight ... before this commit, the average dossier weight took account only pieces justificatives. With this commit, we add a minimum weight for other files included in an archive like pdf_export, log operations, attachments added to traitements. This minimum weight is set arbitrary, from the observation of some random procedures in production	2021-07-06 15:58:45 +02:00
Pierre de La Morinerie	09933454ff	app: improve InvalidAuthenticityToken logging ... - Log on all controllers - Improve description of the controller action involved - Ignore Safari bogus requests	2021-07-06 12:42:01 +02:00
Christophe Robillard	54d91335f2	remove the ability to download an 'everything' archive ... there are sometimes an error that happen when building an everything archive. The error explanation is not understood at the moment. To deliver the archive feature quickly, we remove the 'everything' archive for the moment	2021-07-05 11:05:07 +02:00
Paul Chavard	280e54b59d	Enable test revisions	2021-07-01 15:59:07 +02:00
Pierre de La Morinerie	1faf91bdbe	experts: protect password update as well as sign-up	2021-06-30 10:46:42 +02:00
Pierre de La Morinerie	6f7a2fde57	experts: fix saving password on sign-in	2021-06-30 10:46:42 +02:00
Pierre de La Morinerie	4f5c5e26ae	spec: cleanup spec for Experts::AvisController	2021-06-30 10:46:42 +02:00
Christophe Robillard	66cc0dd08d	Revert "Revert "Expose dossier PDF export as IO"" ... This reverts commit 362093eff0.	2021-06-24 21:01:59 +02:00
krichtof	362093eff0	Revert "Expose dossier PDF export as IO"	2021-06-24 19:21:37 +02:00
Paul Chavard	b73d504f8d	Expose dossier PDF export as IO ... Co-authored-by: Christophe Robillard <christophe.robillard@beta.gouv.fr>	2021-06-24 17:49:24 +02:00
Paul Chavard	a4482233b8	[GraphQL] expose deleted dossiers	2021-06-24 11:51:37 +02:00
Paul Chavard	0ca5e1abe2	Preview should reflect revision changes	2021-06-24 11:39:49 +02:00
Paul Chavard	8b2c2c6466	Handle carte layers changes	2021-06-24 11:39:49 +02:00
Paul Chavard	35eccb5630	Show separate blocks for types de champ and annotation changes	2021-06-23 09:40:07 +02:00
Paul Chavard	19195008e8	Expose removed types_de_champ in exports	2021-06-23 09:40:07 +02:00
simon lehericey	eadae7af6b	show all available tdc for procedure presentation	2021-06-23 09:40:07 +02:00
Paul Chavard	8d49b5556a	test revision changes	2021-06-23 09:40:07 +02:00
Paul Chavard	f238710044	Add last_month export	2021-06-23 09:23:10 +02:00
kara Diaby	bcc23ae7a6	test file	2021-06-22 16:33:38 +02:00
kara Diaby	309b3414d6	tests	2021-06-22 16:33:38 +02:00
Pierre de La Morinerie	5908b8019a	specs: properly use xhr: true in javascript requests ... This avoids an unexpected `ActionController::InvalidCrossOriginRequest` exception to be raised when the forgery protection is disabled.	2021-06-22 13:21:55 +02:00
Paul Chavard	1f7d86d5a5	Add delete dossier action to dossiers list	2021-06-18 11:35:00 +02:00
Christophe Robillard	fdec9b2fd5	archives: don't update dossiers ... this fix avoid to touch dossier after attaching pdf_export_for_instructeur	2021-06-18 11:00:57 +02:00
Christophe Robillard	7851d6b1cc	archives: count archived dossiers	2021-06-18 08:59:13 +02:00
Pierre de La Morinerie	12d17bc245	spec: fix Timecop.freeze without Timecop.return ... Time was frozen without being un-frozen at the end of the spec. This caused a spec in `Procedure#publish_or_reopen!` to fail randomly. Fixed by using the `Timecop.freeze do` form, which unfreezes after the execution of the block.	2021-06-17 17:36:43 +02:00
Christophe Robillard	896190b91e	return nil when no traitement time	2021-06-17 16:31:53 +02:00
Christophe Robillard	887c5cb4a9	correct rubocop offenses	2021-06-17 16:31:53 +02:00
Christophe Robillard	a5ae5af56a	extract NB_DAYS_RECENT_DOSSIERS and PERCENTILE	2021-06-17 16:31:53 +02:00
Christophe Robillard	bdf2f47eb9	fix specs for procedure stats	2021-06-17 16:31:53 +02:00
Christophe Robillard	a8840faadb	move stats methods to appropriate concern class	2021-06-17 16:31:53 +02:00
Christophe Robillard	701b72494d	compute usual traitement time for specific month	2021-06-17 16:31:53 +02:00
Pierre de La Morinerie	b5bde6608c	routes: replace the email param in the Avis URLs by a query param	2021-06-17 11:15:51 +02:00
kara Diaby	cd030fd975	add csv fixture file	2021-06-15 19:36:47 +02:00
kara Diaby	6ebd57640c	tests	2021-06-15 19:36:46 +02:00
simon lehericey	6be0bbaa9c	Change bottom champs editor button from enregistrer to continuer	2021-06-15 09:54:32 +02:00
Paul Chavard	a2c53ce7ea	format phone numbers	2021-06-15 09:14:55 +02:00
François Vantomme	c9b1095d1e	Refactor (Rubocop): replace map{ … }.compact by filter_map ... In Ruby 2.7, Enumerable#filter_map has been added. This cop identifies places where map { … }.compact can be replaced by filter_map. See: https://docs.rubocop.org/rubocop-performance/cops_performance.html#performancemapcompact	2021-06-11 15:38:09 +02:00
Christophe Robillard	aee8db99d0	add spec for dossier weight estimation	2021-06-09 10:52:38 +02:00
Christophe Robillard	4fd0ad71c3	add spec for archive weight estimation	2021-06-09 10:52:38 +02:00
Christophe Robillard	f0b2327ec6	add spec for count dossiers termines by month	2021-06-09 10:52:38 +02:00
Christophe Robillard	41569efe9d	extract estimate_weight ... and rename nb_dossiers by nb_dossiers_termines	2021-06-09 10:52:38 +02:00
Paul Chavard	44ebd0e8a5	Fix api education wrong data type	2021-06-08 12:25:24 +02:00
kara Diaby	fab4a41c57	add tests regarding /users/statistiques view	2021-06-07 15:09:39 +02:00
Paul Chavard	1888f74b10	Prevent double processing of declarative dossiers	2021-06-04 17:55:40 +02:00
Paul Chavard	9819a5ff77	Update spec/models/procedure_spec.rb ... Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com>	2021-06-03 13:11:16 +02:00
Paul Chavard	a0d4c9d54c	Fix published revisions	2021-06-03 13:11:16 +02:00
Paul Chavard	990ae10399	GraphQL byte_size should be BigInt	2021-06-03 10:53:17 +02:00
Paul Chavard	f076fa803e	Handle GeoJSON validation errors	2021-06-02 12:43:24 +02:00
Paul Chavard	05380b9520	Fix destoying discarded procedures	2021-05-27 18:48:56 +02:00
Pierre de La Morinerie	929a556f9f	i18n: add feature spec for changing the language	2021-05-27 11:01:26 +02:00
François Vantomme	99086a63be	Fix (Instructeur): deal nicely with non-guaranteed elements order in arrays ... Use of one-dimension arrays comparison & `contain_exactly` RSpec matcher to avoid this behaviour: Failures: 1) InstructeursImportService#import when an email is malformed ignores or corrects Failure/Error: expect(procedure_groupes).to match_array([ ["Occitanie", ["paul@mccartney.uk", "ringo@starr.uk"]], ["défaut", []] ]) expected collection contained: [["Occitanie", ["paul@mccartney.uk", "ringo@starr.uk"]], ["défaut", []]] actual collection contained: [["Occitanie", ["ringo@starr.uk", "paul@mccartney.uk"]], ["défaut", []]] the missing elements were: [["Occitanie", ["paul@mccartney.uk", "ringo@starr.uk"]]] the extra elements were: [["Occitanie", ["ringo@starr.uk", "paul@mccartney.uk"]]] # ./spec/services/instructeurs_import_service_spec.rb:70:in `block (4 levels) in <main>'	2021-05-27 08:33:52 +02:00
Paul Chavard	9b0dae4cc2	Fix apostrophes ‘ -> ’	2021-05-26 18:05:14 +02:00
Paul Chavard	4922bc88d6	Do not crash when properties is nil	2021-05-26 12:40:07 +02:00
Paul Chavard	21ee79669d	Better labels in test	2021-05-25 11:43:38 +02:00
Paul Chavard	179bb5a9fe	Apply suggestions from code review ... Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com>	2021-05-25 11:43:38 +02:00
Paul Chavard	acb277e650	Use stable_id when replacing tags	2021-05-25 11:43:38 +02:00
kara Diaby	4b6196e6f6	verify avis privacy	2021-05-25 11:24:15 +02:00
Paul Chavard	c5f2faa3d2	add tests for backward compatibility of geo_areas	2021-05-24 11:57:00 +02:00
Paul Chavard	3b85ade440	Add compatibility cadsatre layer with old API GEO	2021-05-24 11:57:00 +02:00
Paul Chavard	01c558953b	Remove API GEO legacy adapter	2021-05-24 11:50:16 +02:00
simon lehericey	b620888597	show only dossier avis	2021-05-20 16:18:04 +02:00
kara Diaby	aaf943569a	rename avis confidential test	2021-05-20 11:13:24 +02:00
simon lehericey	17617fba43	address champ needs the data column	2021-05-19 15:59:18 +02:00
simon lehericey	a46000dc1f	ensure to_s is used on specialized champ	2021-05-19 09:39:20 +02:00
Paul Chavard	e043645a88	cleanup tests	2021-05-18 11:42:10 +02:00
kara Diaby	468e9e849a	tests	2021-05-18 11:42:10 +02:00
Paul Chavard	5f419954b4	Fix dossier deleted user display	2021-05-13 10:43:55 +02:00
Paul Chavard	3f7a2bea9b	Dossier without user should be valid	2021-05-11 17:50:10 +02:00
Paul Chavard	8a74438dc1	Use conservation_extension instead of en_construction_conservation_extension	2021-05-11 17:33:53 +02:00
simon lehericey	c5f6c9ae1e	fix missing state translation	2021-05-10 11:17:34 +02:00
François Vantomme	99ce5195bc	Fix (API Entreprise): test fails randomly ... Don't assume array order, just check that all values are present	2021-05-07 17:42:15 +02:00
Pierre de La Morinerie	77b65f3aa0	tasks: remove older after_party tasks	2021-05-06 15:19:37 +02:00
simon lehericey	55b80df29d	display count before text in tabs	2021-05-06 09:13:20 +02:00
simon lehericey	5124e08ccd	disable faulty manager spec	2021-05-05 21:34:57 +02:00
simon lehericey	ccce724976	refactor as created fci must have an user_id	2021-05-05 14:36:34 +02:00
simon lehericey	e18fb116c6	cannot create fci without user	2021-05-05 14:36:34 +02:00
simon lehericey	8d0082419c	do not know how it worked before	2021-05-05 14:36:34 +02:00
simon lehericey	9dc9e92c16	use the with_user trait in feature	2021-05-05 14:28:20 +02:00
simon lehericey	1cf59f722e	add :with_user trait to fci as user_id is mandatory	2021-05-05 14:28:20 +02:00
simon lehericey	ed404f129b	remove now falling spec of obsolete task	2021-05-05 14:28:20 +02:00
simon lehericey	9fd1c604a1	display follower instructeur emails in alphabetic order	2021-05-04 16:38:34 +02:00
simon lehericey	50f679746f	do not extract twice the same dossier_id if the dossier is followed twice	2021-05-04 16:38:34 +02:00
Paul Chavard	bcbfcdc537	Revert "Merge pull request #6142 from tchak/enable_brouillon_extend_conservation" ... This reverts commit 48eb4d9778, reversing changes made to 5539d5cb8c. # Conflicts: # app/models/dossier.rb # db/schema.rb	2021-05-04 16:03:29 +02:00
Christophe Robillard	01f180022b	prend en compte uniquement les pj pour estimer la taille d'un dossier	2021-05-04 12:50:12 +02:00
Paul Chavard	f6508899de	Refactor NotificationMailer	2021-05-04 12:05:06 +02:00
Paul Chavard	a4fd629f4a	Enable user destruction	2021-05-04 12:05:06 +02:00
Paul Chavard	b2a867266a	Allow users to extend conservation on drafts	2021-04-29 19:50:30 +02:00
Christophe Robillard	3d04221dab	generate pdf export for dossier only on demand	2021-04-29 17:30:38 +02:00
Christophe Robillard	f40d96fbd2	Revert "Revert "Export de tous les dossier d'une démarche"" ... This reverts commit d9a588b52e.	2021-04-29 17:29:47 +02:00
krichtof	d9a588b52e	Revert "Export de tous les dossier d'une démarche"	2021-04-29 16:07:18 +02:00
Pierre de La Morinerie	fbfe5c3817	jobs: also retry native ActiveStorage's jobs on transient errors	2021-04-29 14:08:12 +02:00
Pierre de La Morinerie	684af77e35	jobs: extract an RetryOnTranscientErrors concern	2021-04-29 14:08:12 +02:00
simon lehericey	7b94c2de88	remove extra Dossier call in projection	2021-04-29 11:46:00 +02:00
simon lehericey	db23a853a9	fetch all notification at once	2021-04-29 11:23:41 +02:00
simon lehericey	20fb756097	one less count	2021-04-29 11:23:41 +02:00
simon lehericey	8b73d8804c	fetch all exports at once by groupe_instructeurs_ids	2021-04-29 11:23:41 +02:00
Paul Chavard	f9fb6473b4	geo module is not really accessible :(	2021-04-28 15:34:53 +02:00
Paul Chavard	85b907807a	Improuve ComboMultipleDropdownList style	2021-04-28 12:54:45 +02:00
Christophe Robillard	09870c918d	prevent race conditions when creating archives	2021-04-28 11:40:58 +02:00
Christophe Robillard	dfbe004122	rename content_type to time_span_type for archives	2021-04-28 11:40:58 +02:00
Christophe Robillard	9134114c2e	fix rubocop offenses	2021-04-28 11:40:58 +02:00
Christophe Robillard	8bee53fe77	rend plus robuste la création de l'archive	2021-04-28 11:40:58 +02:00
Christophe Robillard	71a5e41e5b	add archive_zip_globale feature flag	2021-04-28 11:40:58 +02:00
Christophe Robillard	8b2849408c	instructeurs can create and download archives	2021-04-28 11:40:58 +02:00
Christophe Robillard	07cc4fa97f	add service to create procedure archive	2021-04-28 11:40:58 +02:00
Christophe Robillard	fba0d78153	generate pdf export inside pieces_justificatives_service	2021-04-28 11:40:58 +02:00
Christophe Robillard	c25f3c79d9	add archive model	2021-04-28 11:40:58 +02:00
Paul Chavard	2a068fb9b0	Remove user feedback buttons	2021-04-22 15:40:40 +01:00
Paul Chavard	c20ad5ca17	Remove the link between commentaire and user	2021-04-22 15:10:47 +01:00
Pierre de La Morinerie	d530b272a1	password: add specific page for reset instructions	2021-04-22 14:24:15 +02:00
simon lehericey	553e1d973c	remove old methods	2021-04-22 10:46:04 +02:00
simon lehericey	5bfd4ecbbf	add DossierProjectionService	2021-04-22 10:46:04 +02:00
Pierre de La Morinerie	7ee29b2190	spec: fix flaky expert test ... In this test, two Avis are created for each expert: - one for the original dossier, - one for the dossier linked to the original dossier. When we check for a sign-up link, we should do so using the Avis for the original dossier explicitely.	2021-04-20 12:06:12 +02:00
Pierre de La Morinerie	6b14420ffa	sign_in: improve "Forgot password?" appearance on mobile	2021-04-20 09:34:52 +02:00
Pierre de La Morinerie	0749d981ab	password: make the "Reset password" button clearer	2021-04-20 09:34:52 +02:00
Pierre de La Morinerie	fffb85987c	app: retain user email on sign-in error	2021-04-20 09:34:52 +02:00
kara Diaby	5982660c37	tests	2021-04-19 10:23:45 +02:00
François Vantomme	f747b0a46a	Chore(test): enable rspec only-failures support	2021-04-15 14:17:39 +02:00
kara Diaby	198e3ed3b8	expert mailer instead of avis mailer	2021-04-15 12:22:40 +02:00
kara Diaby	f4aa29a799	add expert mailer preview	2021-04-15 11:29:55 +02:00
Paul Chavard	6d37e1d133	Fix discarded procedures destruction	2021-04-14 12:24:16 +01:00
Paul Chavard	5b56ec425b	Fix discarded dossiers destruction	2021-04-14 12:24:16 +01:00
François Vantomme	a596df9a4a	Test: use APPLICATION_NAME to deal nicely with custom configuration	2021-04-13 22:46:33 +02:00
Pierre de La Morinerie	872f6b0153	lib: add migration helpers for making a column unique	2021-04-13 18:09:59 +02:00
simon lehericey	fde433a7cf	do not ask for avis if the dossier is absent	2021-04-13 12:04:45 +02:00
simon lehericey	c683fad3f3	[#6084] add after_party task to fill missing data	2021-04-13 09:59:28 +02:00
simon lehericey	52c8b60419	This is why you need to add a COUNT(DISTINCT dossiers.id) to make it work	2021-04-13 09:32:48 +02:00
simon lehericey	594cda3ee3	Remove previous attempt but steal its spec	2021-04-13 09:32:48 +02:00
simon lehericey	6055fd1b0b	remove for_procedure	2021-04-13 09:32:48 +02:00
simon lehericey	7567e51a3f	add ui for integrity error	2021-04-06 18:11:26 +02:00
simon lehericey	d552e364fc	retry 5 times on integrity error and then block processing	2021-04-06 18:03:39 +02:00
Pierre de La Morinerie	62051c926a	app: move update_allow_decision_access to ExpertsController	2021-04-06 14:54:18 +02:00
Pierre de La Morinerie	c82c72402d	app: move the experts list to ExpertsProceduresController	2021-04-06 14:29:02 +02:00
Pierre de La Morinerie	7acb4cee83	controllers: use standard action names in ExpertsProceduresController	2021-04-06 13:45:51 +02:00
Pierre de La Morinerie	3f25624a5a	routes: nest ExpertsProcedures routes in a resource	2021-04-06 13:18:51 +02:00
Pierre de La Morinerie	9096a3885c	specs: fix creating dossiers :en_construction	2021-04-06 12:12:56 +02:00
Pierre de La Morinerie	02743365eb	specs: make build and create consistent in downloadable_file_spec	2021-04-06 12:12:56 +02:00
kara Diaby	a8b30c0cdc	add react component (expert view) and block it when the flag is activated	2021-04-06 10:39:24 +02:00
kara Diaby	8a1cdf31e3	tests	2021-04-06 10:38:46 +02:00
Pierre de La Morinerie	6eadcf614d	spec: improve the dossier_controller timestamp specs ... Make the specs clearer, and better test the various timestamps.	2021-04-06 10:26:17 +02:00
Paul Chavard	fd48b86b7f	Simplify export unicity check and use create_or_find_by	2021-04-01 21:14:16 +01:00
simon lehericey	5b69e087c7	fix sentry test	2021-04-01 11:57:16 +02:00
Pierre de La Morinerie	f6f013e87f	specs: fix Avis query in specs	2021-03-25 13:24:53 +01:00
Pierre de La Morinerie	21356e42b8	specs: remove unused require	2021-03-25 13:24:53 +01:00
kara Diaby	18f89b0d83	adjust tests	2021-03-24 17:47:24 +01:00
maatinito	cc19453f68	views: fix warning message about incomplete fields for attestation ... The labels for the champs and private champs were inverted.	2021-03-23 16:56:02 +01:00
Paul Chavard	0b22788d60	experts_procedure should not be optional	2021-03-23 13:46:33 +01:00
Paul Chavard	224c7ec6c3	Update spec/models/dossier_spec.rb ... Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com>	2021-03-23 10:51:55 +01:00
Paul Chavard	84214f4bd4	Do not export non exportable champs on draft procedures	2021-03-23 09:55:37 +01:00
Paul Chavard	1449fbbe67	Fix multiple_drop_down_list mandatory check	2021-03-18 15:22:28 +01:00
kara Diaby	bb47c88c5f	fix expert spec feature	2021-03-18 14:36:08 +01:00
kara Diaby	64b94100f4	fix dossier link helper	2021-03-18 14:36:08 +01:00
kara Diaby	81f5a5254b	tests	2021-03-18 11:38:52 +01:00
Paul Chavard	866ae256a3	Add revision dossiers filters	2021-03-17 11:53:48 +01:00
Christophe Robillard	dfed8f32ae	update link to download dossier and all pjs	2021-03-16 15:13:17 +01:00
Christophe Robillard	60cc4d3697	add pdf to pjs export	2021-03-16 15:13:17 +01:00
Paul Chavard	76aa7bdfe3	Add default nil value for numero_tva_intracommunautaire	2021-03-16 12:57:10 +01:00
Paul Chavard	4f03c231a3	Add tests for GeoJSON validation	2021-03-16 12:27:28 +01:00
Pierre de La Morinerie	be58d82016	specs: clear jobs queue before each test ... This avoids `perform_enqueued_jobs` to execute jobs from the previous tests.	2021-03-16 11:49:14 +01:00
Pierre de La Morinerie	75a1046315	active_storage: refactor concerns ... Follow-up of #5953. Refactor the concerns with two goals: - Getting closer from the way ActiveStorage adds its own hooks. Usually ActiveStorage does this using an `Attachment#after_create` hook, which then delegates to the blob to enqueue the job. - Enqueuing each job only once. By hooking on `Attachment#after_create`, we guarantee each job will be added only once. We then let the jobs themselves check if they are relevant or not, and retry or discard themselves if necessary. We also need to update the tests a bit, because Rails' `perform_enqueued_jobs(&block)` test helper doesn't honor the `retry_on` clause of jobs. Instead it forwards the exception to the caller – which makes the test fail. Instead we use the inline version of `perform_enqueued_jobs()`, without a block, which properly ignores errors catched by retry_on.	2021-03-16 11:49:14 +01:00
Paul Chavard	00d7c3186a	fix indentation	2021-03-09 14:47:23 +01:00
Paul Chavard	70500e3d56	Groupe instructeur selector default blank	2021-03-09 14:47:23 +01:00
Pierre de La Morinerie	f9401cfbad	spec: better split spec_helper and rails_helper ... This fixes the > DEPRECATION WARNING: Initialization autoloaded the constants ActionText::ContentHelper and ActionText::TagHelper. error appearing when running specs. It also gets us closer from a newly-generated rails config.	2021-03-04 22:59:39 +01:00
Pierre de La Morinerie	2f948f7e46	active_storage: fix blob update hooks ... For some reason on Rails 6.1 the `after_update_commit` hook is properly registered – but disappears from the record later, and in the end is never run. Fix it by using the general `after_commit` hook instead.	2021-03-04 14:30:38 +01:00
Paul Chavard	5d4f025be0	Rename for consistency with defaut_groupe_instructeur	2021-03-04 10:45:02 +01:00
Paul Chavard	89ec3923f2	Defaut groupe instructeur ordered by label	2021-03-04 10:35:44 +01:00
Paul Chavard	96a832bc19	Add SerializerService	2021-03-02 12:42:22 +01:00
Pierre de La Morinerie	1c77f59f6b	specs: fix test failing on March 1st ... Because February only has 28 days.	2021-03-02 12:26:28 +01:00
Pierre de La Morinerie	473a86b861	gems: remove guard ... - It doesn't seem used a lot these days - It has some incompatibility with rspec 4 We need to explicitely add the 'listen' gem now though.	2021-02-25 10:45:42 +00:00
Paul Chavard	46a839e7f7	Remove a spec that was testing bug in libgeos ... we don’t use libgeos anymore	2021-02-23 10:35:30 +01:00
Pierre de La Morinerie	d9ea415d44	specs: fix rspec warning about raise_error specificity	2021-02-23 08:25:31 +01:00
Paul Chavard	75392272fb	Add champ address model	2021-02-17 19:10:16 +01:00
Paul Chavard	228a83f8a5	Add api address external data fetch	2021-02-17 19:10:16 +01:00
Paul Chavard	7eee14feef	Add ChampFetchExternalDataJob	2021-02-17 19:10:16 +01:00
Christophe Robillard	d55f156aec	admin: durée de conservation des données hors ds n'est plus demandée ... La colonne est tout de même gardée en base	2021-02-17 16:41:57 +01:00
Pierre de La Morinerie	98be7e2076	Fix new Rubocop warnings	2021-02-16 16:31:30 +00:00
Christophe Robillard	8b55f67964	accepte nouvelles valeurs pour ComboMultipleDropdownList	2021-02-16 16:47:15 +01:00
Christophe Robillard	7565a25b51	rend accessible l'affectation d'un instructeur ... en remplaçant select2 par ComboMultipleDropdownList	2021-02-16 16:47:14 +01:00
Christophe Robillard	3fc7b57b8c	rend accessible la personnalisation des filtres instructeurs ... en remplaçant select2 par ComboMultipleDropdownList	2021-02-16 16:47:14 +01:00
Christophe Robillard	c855d13994	rend accessible l'envoi de dossier par un instructeur ... en remplaçant select2 par ComboMultipleDropdownList	2021-02-16 16:47:14 +01:00
Christophe Robillard	b8097e782a	rend accessible la selection multiple usager ... en remplaçant select2 par ComboMultipleDropdownList	2021-02-16 16:47:14 +01:00
kara Diaby	8310dc48bf	tests	2021-02-16 09:46:18 +00:00
kara Diaby	7b4ec486ec	change active record request to get expert list	2021-02-16 09:46:18 +00:00
Paul Chavard	9ce07be1ee	[GraphQL] modifier annotation	2021-02-11 17:45:14 +01:00
Christophe Robillard	a288a13805	disable france connect authentication for admin and instructeurs	2021-02-10 18:13:47 +01:00
Paul Chavard	00e1d88a75	clean up download helper data before test run	2021-02-09 15:13:13 +01:00
Paul Chavard	c04077ca34	fix flaky test by imposing a stable sort order	2021-02-09 15:13:04 +01:00
Pierre de La Morinerie	150ddab660	zeitwerk: Api -> API	2021-02-09 13:07:30 +01:00
Pierre de La Morinerie	88ffa10a56	spec: fix rspec raise_error warning ... Rspec warns that if there is for example a SyntaxError, the test will pass (an error was raised, but it wasn't an ArgumentError, so this is fine). Instead check that no error occurs whatsoever.	2021-02-09 10:12:32 +01:00
Pierre de La Morinerie	0d94eacf32	spec: fix Ruby 2.7 arguments passing	2021-02-09 09:20:46 +01:00
Paul Chavard	a591d5528e	Add job exception log methods to champ and dossier	2021-02-05 18:56:27 +01:00
Pierre de La Morinerie	3b5617b123	mailers: remove dead AdministrationMailer code	2021-02-04 12:15:13 +01:00
Judith	6d89a83d14	unused locales clean-up	2021-02-04 12:15:13 +01:00
Pierre de La Morinerie	0d101f3f1a	views: remove old design's leftbars	2021-02-02 15:33:09 +01:00
Paul Chavard	a503417298	Remove old css and js	2021-02-02 15:26:11 +01:00
Paul Chavard	41c3a98d7d	Update Raven references to use Sentry	2021-01-28 19:46:36 +01:00
kara Diaby	9b8d2f6fd3	instead of call Avis table, we now call Experts Procedure table to see the experts list	2021-01-26 13:59:10 +01:00
Paul Chavard	4452b2cf45	fix order of types de champ on procedure	2021-01-26 10:45:34 +01:00
kara Diaby	2987139dd6	Link avis to an expert	2021-01-22 14:31:02 +01:00
kara Diaby	efbff0f2e0	add expert factory	2021-01-20 18:03:06 +01:00
kara Diaby	da067597ab	Add create expert method	2021-01-20 18:03:05 +01:00
kara Diaby	e0cb0eebab	Tests : add an expert to a procedure and put give him the access to see the dossier final decision	2021-01-20 18:03:05 +01:00
simon lehericey	d409a9a6c5	Procedure and expert link	2021-01-20 18:03:05 +01:00
Christophe Robillard	792b53beeb	import several instructeurs for a routee procedure ... Co-authored-by: simon lehericey <mail@simon.lehericey.net>	2021-01-20 15:03:17 +01:00
simon lehericey	650a598698	ensure a buggy procedure does not block the others from being closed	2021-01-19 10:42:16 +01:00
simon lehericey	d72f0c6dd2	Add authorized content type for pj	2021-01-18 17:23:08 +01:00
Paul Chavard	54f2084aef	Add annuaire_education champ	2021-01-14 17:57:48 +01:00
Paul Chavard	5c9f2e8783	Add api education adapter and job	2021-01-14 17:57:48 +01:00
Paul Chavard	dc08993a89	Add DateTime champ to GraphQL	2021-01-14 14:08:42 +01:00
Paul Chavard	f33544f067	Fix type_de_champ repetition revision after clone ... fix #5769	2021-01-12 10:57:34 +01:00
kara Diaby	8f6440f615	Admins can see the list of invited experts	2020-12-21 14:55:51 +01:00
kara Diaby	2b06ee95e1	Add a method to retrieve all invited experts for all procedure dossiers	2020-12-21 14:55:51 +01:00
Paul Chavard	d2bcbaa180	Fix stable filters migration	2020-12-17 17:10:56 +01:00
simon lehericey	4960eda5cb	use stable id	2020-12-17 10:51:09 +01:00
simon lehericey	cbccdea8e0	move displayed_fields for select to procedure_controller	2020-12-17 10:51:08 +01:00
simon lehericey	1159494d37	Add test to ensure no titre identite is exported	2020-12-16 17:31:38 +01:00
Paul Chavard	a2e87cbb56	Add attestation, justificatifs, operation_logs and bill_signatures to dossier export	2020-12-16 16:34:31 +01:00
simon lehericey	5bc4fab0c4	exhaustive test of discarded_dossier_deletion_job	2020-12-16 15:00:26 +01:00
kara Diaby	c7643154d1	final optims after sim review	2020-12-16 15:00:26 +01:00
kara Diaby	f3c4040d2d	add grace period to deleted dossiers	2020-12-16 15:00:26 +01:00
simon lehericey	d2f3bb18f9	instructeur can delete a dossier UI	2020-12-16 15:00:26 +01:00
kara Diaby	00b5ad7a10	EQT instructeur, je peux supprimer un dossier terminé	2020-12-16 15:00:26 +01:00
Christophe Robillard	15a395fbc7	superadmin: check complexity password server side	2020-12-15 16:26:09 +01:00
Christophe Robillard	94b3ec942b	super_admin: check password complexity client side	2020-12-15 16:26:09 +01:00
simon lehericey	bc4dc22aea	spec: use real signature to avoid mocking	2020-12-14 14:09:15 +01:00
simon lehericey	5a9cd71783	fix bill signature	2020-12-11 15:49:05 +01:00
Paul Chavard	fed300bfe1	Fix and test ActiveStorage::IntegrityError on upload	2020-12-11 10:30:17 +01:00
Paul Chavard	65d650eba6	Better graphql mutation error messages	2020-12-10 18:35:24 +01:00
kara Diaby	f748ccfc9e	Appelle l'API entreprise avec le token en Header	2020-12-10 17:49:49 +01:00
Paul Chavard	3c6e30a326	Show titre identite link only once watermark is added	2020-12-10 16:50:03 +01:00
Paul Chavard	48e7822e34	Remove titres identite after a dossier is processed	2020-12-10 15:21:25 +01:00
Christophe Robillard	23ae528c6b	affiche Madame ou Monsieur ... mais continue à enregistrer en base Mme ou M.	2020-12-08 21:30:54 +01:00
Christophe Robillard	2066e3db87	rend plus compréhensible la civilité	2020-12-08 18:31:38 +01:00
clemkeirua	513d4f6ff1	move all the cron jobs in a dedicated directory	2020-12-08 13:22:43 +00:00
Christophe Robillard	12d1a5bece	implement ComboPaysSearch	2020-12-08 13:09:08 +00:00
simon lehericey	b187244a29	extract and refactor api errors	2020-12-04 17:07:30 +01:00
simon lehericey	05e9130634	refator test	2020-12-03 11:52:01 +01:00
simon lehericey	f56235c7ee	retry exponentially on api entreprise timeout	2020-12-03 11:52:01 +01:00
simon lehericey	9eab310565	[#5675] for all api entreprise job, retry on 502, 503	2020-12-02 18:25:31 +01:00
Paul Chavard	cac981cf42	fix warning with ruby 2.7	2020-11-25 10:46:34 +01:00
Paul Chavard	b897e0cc1c	[GraphQL] add better errors when attachments are not properly used	2020-11-17 12:40:14 +01:00
Christophe Robillard	9347951cea	act as an saml identity provider	2020-11-16 12:19:54 +01:00
clemkeirua	64c964bf5e	fix broken nil values in france_connect_informatio	2020-11-11 15:40:44 +01:00
kara Diaby	bc0f77978f	add an api token verification for api entreprise	2020-11-09 16:58:24 +01:00
kara Diaby	c033ef0910	Ajoute a l'information de connexion France Connect dans les informations du dossier ainsi que sur la demande usager	2020-11-05 19:30:13 +01:00
kara Diaby	4b2e3b5be7	Revert "Merge pull request #5710 from betagouv/revert-5705-feat/5701" ... This reverts commit aae77c77b0, reversing changes made to 4c2c5c630c.	2020-11-05 19:30:13 +01:00
Christophe Robillard	5562e65bf3	refacto: rename administration to super_admin	2020-11-05 16:03:55 +01:00
Christophe Robillard	2a0ebd062a	enable 2FA for manager ... when trying to access manager, if superadmin did'nt enable otp, he/she is redirected to a page to enable 2FA. When superadmin is enabling 2FA, he has to to scan a qrcode with the 2FA application client. And afterwards, the superadmin has to log in with email, password and OTP code.	2020-11-05 16:03:55 +01:00
Christophe Robillard	305ccdc0cd	add recoverable and two_factor stragegy for administration	2020-11-05 16:03:55 +01:00
Christophe Robillard	6c2eb22960	remove github authentication for manager	2020-11-05 16:03:55 +01:00
Kara Diaby	f78e0ced3a	Revert "feat 5701 - Ajoute l'information lorsqu'un usager s'authentifie via France Connect"	2020-10-30 18:28:08 +01:00
kara Diaby	e6c1a20329	Ajoute l'information lorsqu'un usager s'authentifie via France Connect	2020-10-30 17:28:54 +01:00
simon lehericey	c563956a9f	retry each day during 5 days to fetch attestation social	2020-10-28 15:53:58 +00:00
clemkeirua	89316c0689	fix counter for dossiers suivis/à suivre when unfollow	2020-10-28 13:51:35 +00:00
clemkeirua	b4910c557d	ajout de procedure.dossiers_count_for_instructeur	2020-10-28 13:51:35 +00:00
Kara Diaby	0bd48999bd	Revert "feat/5635 - Supprime la possibilité pour l'expert invité d'envoyer un message"	2020-10-12 09:24:34 +02:00
Paul Chavard	7c58f06c60	always validate geometries returned from api	2020-10-08 16:03:28 +02:00
Paul Chavard	653270d02f	Update specs	2020-10-08 15:26:15 +02:00
kara Diaby	6636b7f14c	Supprime la possibilité pour l'expert invité d'envoyer un message à l'usager	2020-10-08 11:14:09 +02:00
Paul Chavard	0aa06d0197	[GraphQL] expose dossier pdf, geojson and attestation	2020-10-06 21:54:43 +02:00
kara Diaby	9207cc5aa5	Ajoute un flag pour qu'un expert ne puisse pas inviter une autre personne à donner son avis sur un dossier	2020-10-02 18:57:29 +02:00
Paul Chavard	59086cc728	Fix geo length computations	2020-10-01 15:09:38 +02:00
Paul Chavard	4dfc1c719f	Fix geo areas computations	2020-10-01 15:09:38 +02:00
kara Diaby	57adb90c8f	add the possibility for administrator to refuse external review on a specific procedure	2020-10-01 10:55:19 +02:00
clemkeirua	67b8bf4754	smaller font-size for large footers in attestation	2020-09-30 14:05:12 +02:00
Paul Chavard	1bd59c72e5	Include in exports types_de_champ from all revisions	2020-09-30 13:42:38 +02:00
kara Diaby	e174079850	fix send a copy link	2020-09-30 10:03:08 +02:00
kara Diaby	2a69e2fbeb	fix services choice into a procedure	2020-09-29 19:53:28 +02:00
Keirua	3fa628235e	Nettoyage de I18n.transliterate pour les noms de feuilles d'exports ... Co-authored-by: LeSim <mail@simon.lehericey.net>	2020-09-29 15:50:19 +00:00
clemkeirua	9714b607aa	ensure valid excel worksheet names	2020-09-29 15:50:19 +00:00
simon lehericey	1eb780b0c9	convert sheet_name to ascii before tuncate to 30 to ensure length < 31 bytes	2020-09-29 14:11:06 +02:00
clemkeirua	245e9e59c7	do not run ApiEntreprise jobs on missing etablissements	2020-09-28 17:36:38 +02:00
clemkeirua	f3e487bd9e	replace filter+first with find	2020-09-25 12:53:11 +00:00
clemkeirua	eb46cc6425	piecejusticative file validation focus on size	2020-09-25 09:35:16 +00:00
clemkeirua	c155de1d7e	ajout de la liste des extensions	2020-09-25 09:35:16 +00:00
clemkeirua	a465bad405	fix broken test in champ_serializer_spec	2020-09-25 09:35:16 +00:00
clemkeirua	31d48c2879	validation is enableed only for 'new' procedures	2020-09-25 09:35:16 +00:00
clemkeirua	8711e8f911	reenable validator on piece_justificative	2020-09-25 09:35:16 +00:00
clemkeirua	c19b653581	higher level length sanitization for worksheet length	2020-09-24 14:59:46 +02:00
Paul Chavard	26a6e18cb9	Do not crash when rgeo can’t calculate polygon area ... example are “hourglass” shaped polygons	2020-09-23 16:52:08 +02:00
Paul Chavard	61c315b276	Fix geo area point coordinates display	2020-09-23 16:52:08 +02:00
kara Diaby	cb4e91c405	Add iban type de champ	2020-09-23 15:56:26 +02:00
Paul Chavard	973973ab6a	Do not enqueue web hooks for empty urls	2020-09-22 17:03:19 +02:00
Paul Chavard	a3f3b8a8e0	procedure.dossiers through revisions	2020-09-22 10:55:17 +02:00
Paul Chavard	061a743759	[GraphQL] Add archiver mutation	2020-09-22 08:34:38 +00:00
clemkeirua	005c244438	fixup! add fix for nil values on numeroVoie and typeVoie	2020-09-22 10:17:54 +02:00
clemkeirua	7ba8ab9e6a	maj du schema json	2020-09-22 10:14:55 +02:00
clemkeirua	412a87e532	add fix for nil values on numeroVoie and typeVoie	2020-09-22 09:43:44 +02:00
clemkeirua	1173f1e459	add default values when nil	2020-09-22 09:43:44 +02:00
clemkeirua	adb2a91640	add a broken test case	2020-09-22 09:43:44 +02:00
clemkeirua	4c17acf349	ajout du code effectif entreprise dans une spec graphql nominale	2020-09-22 09:43:44 +02:00
clemkeirua	482bfdb059	fix tests for autosave_brouillon	2020-09-21 08:46:01 +00:00
clemkeirua	f9c4e967d6	remove :autosave_dossier_draft	2020-09-21 08:46:01 +00:00
clemkeirua	f96377d878	refactor Dossier#with_notifications	2020-09-21 08:28:42 +00:00
clemkeirua	d01a53eb72	remove :cached_notifications gate	2020-09-21 08:28:42 +00:00
kara Diaby	5c68d75107	add titre_identite champ	2020-09-18 14:57:08 +02:00
clemkeirua	2b23eefee2	fix tests that now requir an admin user to have a strong password	2020-09-18 11:16:34 +02:00
clemkeirua	d8b4cc67be	add a test scenario for users	2020-09-18 11:16:34 +02:00
clemkeirua	1e32a3c11f	add complexity check to admin account creation	2020-09-18 11:16:34 +02:00
clemkeirua	5a8fbde0e7	remove dead code in admin model	2020-09-18 11:16:34 +02:00
clemkeirua	de3118bc7b	force password reset on admin promotion or creation	2020-09-17 16:39:13 +02:00
clemkeirua	0307beecd6	Revert "Merge pull request #5576 from tchak/soft-delete-users" ... This reverts commit bf0d3914ce, reversing changes made to 503527459e.	2020-09-17 15:39:16 +02:00
clemkeirua	08d0fa80fa	remove old route	2020-09-17 14:03:31 +02:00
Paul Chavard	a0dd3604a4	User discard_and_anonymize!	2020-09-17 11:16:56 +02:00
clemkeirua	6643b598c3	remove :administrateur_graphql	2020-09-17 09:24:50 +02:00
clemkeirua	01ac4d7e19	remove operation_log_serialize_subject	2020-09-17 09:24:50 +02:00
kara Diaby	13e4589905	Publications page to the new UI (admin)	2020-09-16 09:15:44 +02:00
simon lehericey	e4de522b48	only retrieve id of procedures with notifications	2020-09-11 09:43:04 +00:00
simon lehericey	86b04d4275	Add a missing test on job retry to the excon err	2020-09-09 09:08:48 +00:00
clemkeirua	a62907f33b	add more tests for phone numbers	2020-09-09 09:00:03 +02:00
clemkeirua	52d5a52ff9	test fonctionnel notifications avis	2020-09-08 15:40:42 +00:00
clemkeirua	bfd24e8aee	test fonctionnel notification annotations privees	2020-09-08 15:40:42 +00:00
clemkeirua	b7b61e79ab	test fonctionnel notification champ	2020-09-08 15:40:42 +00:00
clemkeirua	1fafcad401	test fonctionnel notifications commentaire	2020-09-08 15:40:42 +00:00
clemkeirua	c7b96d3d43	add feature-flip for instructeurs on cached notifications	2020-09-08 15:40:42 +00:00
clemkeirua	52ea5ef89a	make Dossier#with_notifications great again ... Co-authored-by: Christophe Robillard <christophe.robillard@beta.gouv.fr>	2020-09-08 15:40:42 +00:00
Paul Chavard	91bc2db594	Expose revisions on GraphQL API	2020-09-08 10:54:13 +02:00
clemkeirua	61cf33e3ca	remove duplicate private champ	2020-09-04 15:40:23 +02:00
kara Diaby	ae61c279af	migrate emails text editor to new interface	2020-09-03 14:42:22 +02:00
Paul Chavard	36668403b6	cleanup feature helper	2020-09-02 11:26:26 +02:00
Paul Chavard	0a70291b90	update services specs to use revisions	2020-09-02 11:26:26 +02:00
Paul Chavard	4c0f9a4d61	update serializers specs to use revisions	2020-09-02 11:26:26 +02:00
Paul Chavard	d1e0b65658	update jobs specs to use revisions	2020-09-02 11:26:26 +02:00
Paul Chavard	6a33a8e48b	update controllers specs to use revisions	2020-09-02 11:26:26 +02:00
Paul Chavard	dee12a2b0b	update features specs to use revisions	2020-09-02 11:26:26 +02:00
Paul Chavard	1488e0964b	update models specs to use revisions	2020-09-02 11:26:26 +02:00
Paul Chavard	d1fb6c559e	Update factories to use revisions	2020-09-02 11:26:26 +02:00
Judith	7eee9beed7	adapting the specs	2020-09-01 16:48:41 +02:00
Judith	25a24ba7c8	removal of translation keys already present in the gem rails-i18n	2020-09-01 16:33:58 +02:00
Pierre de La Morinerie	0800bf68d0	views: allow unselecting all values from a multiple dropdown ... Currently, deselecting all values from a multiple dropdown rendered as checkboxes doesn't have any effect when submitting the form (the previous values are still there, instead of being deselected). This is because unchecked checkboxes are not sent by the browser – so the "empty selection" never gets sent. Rails `form.check_box` usually works around this by inserting an empty hidden checkbox element, that will be sent even if all others are de-selected. But the documentation warns that this is not possible when iterating over an array (rather than a model). Which is our case here. To fix this, this commit uses `collection_check_boxes` instead. It will insert the proper hidden checkboxes in all cases, and fix our use case. See https://api.rubyonrails.org/classes/ActionView/Helpers/FormOptionsHelper.html#method-i-collection_check_boxes	2020-08-27 11:13:40 +02:00
Pierre de La Morinerie	4bba1f0660	views: add a "None" option to optional radio lists ... After clicking on a radio button option, it is impossible to revert to the "None of the values selected" state. However on non-mandatory fields, reverting to the no-selection value should be possible. To fix this, add an explicit "N/A" option.	2020-08-25 11:42:30 +02:00
Christophe Robillard	090a247ba9	validates phone champ server side	2020-08-20 15:33:03 +02:00
Christophe Robillard	f77cc06a91	prend en compte le nom de l'enseigne pour l'établissement	2020-08-20 14:23:02 +02:00
Pierre de La Morinerie	a7361fdbd3	models: require belong_to associations on mail templates	2020-08-18 15:57:37 +02:00
Pierre de La Morinerie	29e8c43e5e	models: require belong_to associations on groupe_instructeur	2020-08-18 15:57:37 +02:00
Pierre de La Morinerie	5a7bd24fba	models: require belong_to associations on type_de_champ ... - Make `type_de_champ.procedure` a requirement; - Move the procedure_id assignation to `before_validation` (otherwise the record is invalid, and never gets saved);	2020-08-18 15:57:37 +02:00
Pierre de La Morinerie	6328011f60	models: require belong_to associations on champ ... - Make `champ.dossier` a requirement; - Move the dossier_id assignation to `before_validation` (otherwise the record is invalid, and never gets saved); - Allow specs to only build the champ (instead of saving it to the database), which bypasses the requirement to have a dossier.	2020-08-18 15:57:37 +02:00
Pierre de La Morinerie	71d9774d58	models: require belong_to associations on trusted_device_token	2020-08-18 15:57:37 +02:00
Pierre de La Morinerie	059c147ffc	models: require belong_to associations on service	2020-08-18 15:57:37 +02:00
Pierre de La Morinerie	ce53e219e0	models: require belong_to associations on procedure_presentation ... Some tests are still failing	2020-08-18 15:57:37 +02:00
Pierre de La Morinerie	802d3804f5	models: require belong_to associations on invite	2020-08-18 15:57:37 +02:00
Pierre de La Morinerie	fe8804f208	models: require belong_to associations on individual	2020-08-18 15:57:37 +02:00
Pierre de La Morinerie	afb1c33154	models: require belong_to associations on geo_area	2020-08-18 15:57:37 +02:00
Pierre de La Morinerie	aff2713032	models: require belong_to associations on follow	2020-08-18 15:57:37 +02:00
Pierre de La Morinerie	91619b16e8	models: require belong_to associations on feedback	2020-08-18 15:57:36 +02:00
Pierre de La Morinerie	51d392a1dc	models: require belong_to associations on dossier	2020-08-18 15:57:36 +02:00
Pierre de La Morinerie	dd1bed9340	models: require belong_to associations on commentaire	2020-08-18 15:57:36 +02:00
Pierre de La Morinerie	32e55a6d37	models: require belong_to associations on avis	2020-08-18 15:57:36 +02:00
Pierre de La Morinerie	aefdd5d2a1	models: require belong_to associations on attestation_template	2020-08-18 15:57:36 +02:00
Pierre de La Morinerie	1ea4c2aa36	models: require belong_to associations on attestation	2020-08-18 15:57:36 +02:00
Pierre de La Morinerie	c1e2928ce7	models: require belong_to associations on assign_to	2020-08-18 15:57:36 +02:00
Pierre de La Morinerie	df2429d7ad	factories: build type_de_champ instead of creating them ... This allows to minimize the number of actual creations when only a build is requested.	2020-08-13 17:39:49 +02:00
Pierre de La Morinerie	c8ec5c8846	factories: remove the Rubocop workaround	2020-08-13 17:39:49 +02:00
Judith	bfabd3b6a5	Specs adapted	2020-08-13 13:41:45 +00:00
Christophe Robillard	0b35619322	skip verify authenticity token for helpscout ... Co-authored-by: LeSim <mail@simon.lehericey.net>	2020-08-10 17:19:22 +02:00
kara Diaby	9b66c894b2	Adapt configuration email view to the new UI	2020-08-06 16:56:24 +02:00
Pierre de La Morinerie	65809f8ea0	config: flip action_dispatch_return_only_media_type_on_content_type ... This makes `ActionDispatch::Controller#content_type` return not only the MIME type, but also in some circumstances the charset. Example: ```ruby reponse.content_type == 'text/html; charset=utf-8' ``` The MIME type-only fragment can now be accessed using `#media_type`. Changes to the tests are not stricly necessary (because no charset is present in the actual value), but represent the intent better.	2020-08-05 16:48:36 +02:00
Pierre de La Morinerie	8962db38cc	models: render attestations in a simpler way ... The older method of instanciating an entire new rendering stack can be made simpler using Rails >= 5.0 methods. See https://api.rubyonrails.org/classes/ActionController/Renderer.html#method-i-render	2020-08-04 16:53:46 +02:00
clemkeirua	21221a7c49	fix missing alt	2020-08-04 13:41:10 +00:00
clemkeirua	101acafb65	fix hidden label	2020-08-04 13:41:10 +00:00
clemkeirua	cc9341a83c	fix missing header for account creation	2020-08-04 13:41:10 +00:00
jpoulvel	bf94cc021b	Merge pull request #5424 from betagouv/new_design_edit_attestation ... New design page admin/attestation_templates/edit	2020-07-31 11:18:22 +02:00
kara Diaby	db3e40ebf8	Fixe la non possibilité de cloner une démarche pour une procédure archivée (nouvelle interface administrateur)	2020-07-30 12:00:43 +02:00
clemkeirua	c772c3454c	update dossier after saving champ ... update last_champ_updated_at without hook update last_champ_private_updated_at without hook Co-authored-by: Christophe Robillard <christophe.robillard@beta.gouv.fr>	2020-07-30 10:18:44 +02:00
Christophe Robillard	b940d2e1b0	update dossier after saving avis ... update last_avis_updated_at without hook Co-authored-by: clemkeirua <clement@keiruaprod.fr>	2020-07-30 10:18:44 +02:00
clemkeirua	f3a675c3bc	update dossier after saving commentaire ... update last_commentaire_updated_at without hook Co-authored-by: Christophe Robillard <christophe.robillard@beta.gouv.fr>	2020-07-30 10:18:44 +02:00
jpoulvel	62e04a6ca9	Merge branch 'dev' into new_design_edit_attestation	2020-07-30 09:53:09 +02:00
Kara Diaby	5894a86bd8	Merge pull request #5423 from betagouv/feat/5402 ... Feat/5402 - [Admin] new UI for procedures listing	2020-07-29 17:38:49 +02:00
clemkeirua	c404f92107	graphql: possibility to filter dossiers by archived	2020-07-29 16:59:34 +02:00
kara Diaby	d4c6e501c6	Ajoute la liste des démarches de l'interface administrateur sur la nouvelle UI	2020-07-29 15:35:52 +02:00
Judith	0075b508a3	adaptation of specs	2020-07-29 13:15:07 +02:00
Judith	b8a49e9012	creation of attachment_upload_helpers and integration in the code	2020-07-29 12:26:27 +02:00
Judith	5df3838173	- tranferred controllers from admin to mew_administrateur ... - removed admin/attestation_templates views - changed routes accordingly	2020-07-29 12:26:27 +02:00
Keirua	347dbe4c87	Merge pull request #5417 from betagouv/cleanup-incident-janvier ... Suppression du message d'alerte suite aux problèmes d'upload	2020-07-29 11:00:12 +02:00
Paul Chavard	1fca481c6e	Cleanup after clone	2020-07-28 17:04:06 +02:00
clemkeirua	de1df85462	suppression du message d'alerte suite aux problèmes d'upload	2020-07-27 10:32:03 +02:00
LeSim	7f22cc86a9	Merge pull request #5405 from betagouv/set-app-name-as-parameter ... Rendre le nom d'application paramètrable	2020-07-24 10:33:54 +02:00
clemkeirua	c91e231347	spec: replace reference to ds in password	2020-07-23 16:20:16 +02:00
Paul Chavard	bb5a90da76	fix active_revision_id -> active_revision.id	2020-07-23 15:07:25 +02:00
Paul Chavard	a08e318617	Add implicit_order_column on revisions	2020-07-22 12:25:06 +02:00
Paul Chavard	69ab2e44fb	Insert type_de_champ with correct initial position	2020-07-22 11:09:51 +02:00
Paul Chavard	58535c6a35	Add procedure revisions spec	2020-07-21 19:35:30 +02:00
Paul Chavard	0338080430	Remove unused procedure move type_de_champ code	2020-07-21 19:35:30 +02:00
Paul Chavard	d18a9c8162	Migrate procedures “on demand”	2020-07-21 19:35:30 +02:00
Paul Chavard	0a0912503b	Add type_de_champ mutation methods to revision	2020-07-21 19:35:30 +02:00
Keirua	f583b16f92	Merge pull request #5400 from betagouv/add-test-for-zip-download ... Ajout d'un test pour le telechargement de zips de dossier	2020-07-21 17:39:39 +02:00
Keirua	b2aa90b729	Merge pull request #5392 from betagouv/fix-CI-accessibility-errors ... Fix CI accessibility errors	2020-07-21 17:15:45 +02:00
Keirua	1a53bfed62	renommage des tests ... Co-authored-by: Pierre de La Morinerie <pierre.de_la_morinerie@beta.gouv.fr>	2020-07-21 17:13:28 +02:00
clemkeirua	d31b4b6848	ajout d'un test sur le telechargement de zips	2020-07-21 15:45:57 +02:00
krichtof	8c5308b9dc	Merge pull request #5396 from betagouv/5395-relancer-expert ... 5395 instructeur : relance un expert pour une demande d'avis	2020-07-21 15:02:53 +02:00
Christophe Robillard	169b8c9b3e	explicite revive meaning	2020-07-21 10:51:53 +02:00
Paul Chavard	86f562e7ea	Expose repetitions and options on champ_descriptors	2020-07-21 10:37:33 +02:00
Christophe Robillard	d9cb5c067f	relance un expert	2020-07-20 16:26:16 +02:00
clemkeirua	c0cf8b1341	fix display of labels for datetime on screenreaders	2020-07-20 11:37:01 +02:00
clemkeirua	bc34905742	fix heading order by removing useless h4	2020-07-20 11:36:55 +02:00
Christophe Robillard	52e8f32e19	expert can only revoke avis claimed by him/her	2020-07-16 21:07:20 +02:00
Christophe Robillard	3ea34834a7	revoke expert avis	2020-07-16 21:05:11 +02:00
Paul Chavard	b628169053	Remove unsused drop_down_list model	2020-07-16 15:29:01 +02:00
kara Diaby	9dc542af09	Revert "Revert "Feat/5287 - New design for admin procedure detail"" ... This reverts commit cf5eb3f251.	2020-07-15 17:00:03 +02:00
krichtof	0c924be222	Merge pull request #5374 from betagouv/3451-revoquer-invite ... usager: revoque un invité sur un dossier	2020-07-15 15:46:16 +02:00
clemkeirua	8a2aa13b74	remove pending tests	2020-07-15 09:27:23 +00:00
clemkeirua	299c86141c	added before_save to PieceJustificativeChamp in order to set skip_pj_validation	2020-07-15 09:00:12 +00:00
clemkeirua	c93d17bcaa	add rake task to update typedechamp	2020-07-15 09:00:12 +00:00
Christophe Robillard	8111babdd6	user: revoque un invité sur un dossier	2020-07-14 18:25:31 +02:00
Pierre de La Morinerie	e34f82a6fb	mailers: ignore more SMTP errors ... Although we already ignore "invalid recipient" errors, a new type of error recently popped: the mail service responds with > Net::SMTPServerBusy '400 unexpected recipients: want atleast 1, got 0' We want to also ignore this kind of errors.	2020-07-13 16:17:55 +02:00
Pierre de La Morinerie	7a67f1a802	jobs: ignore missing blob during virus scan ... We currently have many failed VirusScannerJob enqueued, because the underlying blob is missing. This PR fixes the issue by discarding the job in those cases (because if the blob is gone, the job is never going to succeed). The implementation is based on a similar issue encoutered by the ActiveStorage::AnalyzeJob. See 06f8baf73c	2020-07-13 14:35:41 +02:00
Pierre de La Morinerie	b82c269cef	specs: test de-serialization of job arguments ... When the job is invoked directly, the serialization and de-serialization of the job arguments is not actually tested. Using `perform_later` inside a `perform_enqueued_jobs` allows to exercise the serialization.	2020-07-13 14:31:28 +02:00
kara Diaby	ba6b89743c	put pending testsz	2020-07-13 12:24:48 +02:00
Kara Diaby	cf5eb3f251	Revert "Feat/5287 - New design for admin procedure detail"	2020-07-13 11:36:42 +02:00
Pierre de La Morinerie	c41afc425e	tasks: remove old after_party tasks ... Fixes a task that since became invalid: > NameError: uninitialized constant SeekAndDestroyExpiredDossiersJob > /lib/tasks/deployment/20191203142402_enable_seek_and_destroy_job	2020-07-09 18:18:09 +02:00
kara Diaby	7f3b38cfee	Merge admin dashboard to new design for procedure details	2020-07-09 12:18:22 +02:00
Paul Chavard	cb8cac395b	fix spec name	2020-07-08 19:28:17 +02:00
Paul Chavard	3b9e6dba25	Update spec/models/type_de_champ_shared_example.rb ... Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com>	2020-07-08 19:28:17 +02:00
Paul Chavard	84ff75ed6b	Update spec/models/type_de_champ_shared_example.rb ... Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com>	2020-07-08 19:28:17 +02:00
Paul Chavard	a92320e246	Update spec/models/type_de_champ_shared_example.rb ... Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com>	2020-07-08 19:28:17 +02:00
Paul Chavard	d8e864a7d9	Update spec/models/type_de_champ_shared_example.rb ... Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com>	2020-07-08 19:28:17 +02:00
Paul Chavard	660c95356b	Update spec/models/type_de_champ_shared_example.rb ... Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com>	2020-07-08 19:28:17 +02:00
Paul Chavard	a74e52c828	Call remove_drop_down_list on before_save	2020-07-08 19:25:05 +02:00
Paul Chavard	3c9cc6c070	Remove repetition types_de_champ on type_champ change	2020-07-08 19:25:05 +02:00
Christophe Robillard	2c56511204	validate api_entreprise_token	2020-07-08 18:59:22 +02:00
Christophe Robillard	7fd4d46e8e	remove empty spec file	2020-07-08 18:15:15 +02:00
Christophe Robillard	1253bb5994	store instructeur_email in traitement	2020-07-08 18:15:15 +02:00
Christophe Robillard	8f9d6d2871	show which instructeur took decision and when ... and also replace "sans suite" by "classé sans suite"	2020-07-08 18:15:15 +02:00
Christophe Robillard	cea170e4a6	update stats with traitement model	2020-07-08 18:15:15 +02:00
Christophe Robillard	0be4b50ade	update usual_traitement_time with traitement model	2020-07-08 18:15:15 +02:00
Christophe Robillard	a072d35211	use traitement model ... when a dossier is terminated (accepte, refuse or classe_sans_suite), we store now `processed_at` and `motivation` in a traitement instance	2020-07-08 18:15:15 +02:00
Christophe Robillard	f631acd118	update state date in aasm after callbacks ... call aasm event methods, not state methods directly	2020-07-08 18:15:15 +02:00
Pierre de La Morinerie	2f7fbc8474	specs: fix shared/attachement/_update.html.haml spec ... Avoid purging a non-saved file.	2020-07-07 18:03:56 +02:00
Pierre de La Morinerie	04a6862fa6	spec: fix application_controller_spec ... Rails controllers now looks for `media_type` rather than `content_type`.	2020-07-07 18:03:56 +02:00
Pierre de La Morinerie	0a3b4f7476	specs: fix some test helpers	2020-07-07 18:03:56 +02:00
Pierre de La Morinerie	2261c6c5d2	specs: refactor dossiers_controller_spec	2020-07-07 18:03:56 +02:00
Pierre de La Morinerie	b8706757e3	controllers: disable explicit purge of invalid file	2020-07-07 18:03:56 +02:00
Pierre de La Morinerie	719915e69f	attestations: fix test of the logo preview ... Now that attaching the logo doesn't save it, we can safely display the preview without saving the logo first.	2020-07-07 18:03:56 +02:00
Pierre de La Morinerie	35240e2219	lint: fix Rubocop warnings ... The Rails/UniqueValidationWithoutIndex rule is disabled for now, but we'll need to re-enable it (and fix the underlying issues) after the migration to Rails 6.	2020-07-07 18:03:56 +02:00
Paul Chavard	6cc76cdf05	WIP	2020-07-07 18:03:56 +02:00
Paul Chavard	04feada77e	Use respond_to	2020-07-07 18:03:56 +02:00
Paul Chavard	c9ab80c880	WIP	2020-07-07 18:03:56 +02:00
Paul Chavard	13c21d89af	Fix attestation_template spec	2020-07-07 18:03:56 +02:00
Paul Chavard	6a24c3f812	Rails app:update	2020-07-07 18:03:56 +02:00
Judith	9793128f61	'Services' routes moved under 'new_administrateur' scope and '/admn' added in their url	2020-07-07 14:08:01 +00:00
Judith	782706537d	Changed the routes to pass all new design admin pages under ... 'new_administrateur' scope, except 'services'. As a result, the url of these pages will all include '/admin'.	2020-07-07 14:08:01 +00:00
Pierre de La Morinerie	975d1648d5	dossier: fix PDF rendering of effectif_mensuel ... The effectif_mensuel was a number, it needs to be converted explicitely into a string. As a bonus, `nil.to_s` is `""`, so we can remove the special case for nil.	2020-07-06 11:41:25 +02:00
Pierre de La Morinerie	060bf1f9ca	factories: flesh out the default etablissement for a dossier	2020-07-06 11:41:25 +02:00
clemkeirua	ca74ae5a5e	ajout d'une bannière de dépréciation pour IE11	2020-07-06 10:01:02 +02:00
Myriam	0f542527fb	Instructeur : add overview table with counts for files ... - changement du design - tableau visible seulement si plus d'une procédure	2020-07-02 09:02:49 +00:00
Myriam	a486fe9a2e	Instructeur : add overview table with counts for files ... nombre total de dossier : - 'à suivre' - 'suivi' - 'traité' - 'dossier' - 'archivé'	2020-07-02 09:02:49 +00:00
bors[bot]	a37dd3c8cf	Merge #5318 ... 5318: specs: use `fixture_file_upload` rather than `Rack::Test::UploadedFile` r=Keirua a=kemenaran This is mostly for consistency (both styles were used before). Note: we still have to use `Rack::Test::UploadedFile.new` in factories, because of thoughtbot/factory_bot#385. Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com>	2020-07-01 11:54:51 +00:00
bors[bot]	b135b5cfb0	Merge #5316 ... 5316: fix missing aria-labels in footer r=Keirua a=Keirua début du cleanup des exclusions d'accessibilité (et bon candidat pour tester si bors fonctionne comme prévu) Co-authored-by: clemkeirua <clement@keiruaprod.fr>	2020-07-01 09:28:02 +00:00
Pierre de La Morinerie	43569f687e	specs: use fixture_file_upload rather than Rack::Test::UploadedFile ... This is mostly for consistency (both styles were used before). Note: we still have to use `Rack::Test::UploadedFile.new` in factories, because of https://github.com/thoughtbot/factory_bot/issues/385.	2020-07-01 11:13:45 +02:00
Christophe Robillard	cce1435faf	remove precision for currency	2020-07-01 09:28:18 +02:00
Christophe Robillard	1d86f863d3	rename avis#all to avis#index	2020-06-30 09:17:27 +02:00
Christophe Robillard	bbec76d33b	rename avis#index to avis#procedure	2020-06-30 09:17:27 +02:00
Christophe Robillard	63dd71aed4	display all avis for an expert	2020-06-30 09:17:27 +02:00
Christophe Robillard	29e2d3d7eb	display all avis for a procedure for an expert	2020-06-30 09:17:27 +02:00
Christophe Robillard	c565c9c87b	refactor sign_up_instructeur_avis_url	2020-06-30 09:17:27 +02:00
Christophe Robillard	b0aa005769	remove dead code	2020-06-30 09:17:27 +02:00
Christophe Robillard	4839506374	refactor instructeur_avis_url	2020-06-30 09:17:27 +02:00
Christophe Robillard	b0cfb2c02a	refactor messagerie_instructeur_avis_url	2020-06-30 09:17:27 +02:00
Christophe Robillard	83fba55b29	refactor instruction_instructeur_avis_url	2020-06-30 09:17:27 +02:00
Christophe Robillard	72d27ffdb2	replace instructeur_avis_index url by instructeur_all_avis url	2020-06-30 09:17:27 +02:00
Christophe Robillard	dcb9afaf25	refactor expert avis url : fix avis_controller_spec	2020-06-30 09:17:27 +02:00
Christophe Robillard	3e1afa8bf9	fix avis spec	2020-06-30 09:17:27 +02:00
clemkeirua	1072bacb12	fix missing aria-labels in footer	2020-06-29 15:31:14 +02:00
kara Diaby	6b07cc0659	Move admin/assigns to the new UI like groupe_instructeurs	2020-06-29 14:44:28 +02:00
clemkeirua	f7d957e59a	rename 'Menu déroulant' in specs	2020-06-29 08:59:12 +00:00
clemkeirua	031f59c9e1	add wcag accessibility tests for usager pages using axe-core	2020-06-26 17:10:26 +02:00
Paul Chavard	210389d0f8	Remove admin creation notification email	2020-06-25 16:29:06 +02:00
Paul Chavard	97f91513c8	Store drop_down_list values as jsonb	2020-06-25 13:14:17 +02:00
Pierre de La Morinerie	acc1cb1abd	dossier: export PJs from private champs ... Fix #5297	2020-06-24 15:42:30 +02:00
Pierre de La Morinerie	b83a76a0a1	dossier: refactor piece_justificative specs ... Use `eq` rather than `be` for integers.	2020-06-24 15:42:30 +02:00
clemkeirua	465449e684	fix unit tests	2020-06-24 12:18:56 +02:00
Christophe Robillard	954d41ce4e	fetch effectifs mensuels for may month	2020-06-24 10:23:00 +02:00
Pierre de La Morinerie	af5b36ea6a	helpers: prevent some texts to be incorrectly detected as links ... Users were having issues with texts like: > Pour info: penser à faire cette action. where `info:` was detected as being an URI.	2020-06-22 14:42:41 +02:00
simon lehericey	fecad19b91	add maintenance mode	2020-06-22 11:17:22 +02:00
jpoulvel	adaf0753b0	Merge branch 'dev' into instruct-filter-yes-no	2020-06-16 14:53:22 +02:00
Paul Chavard	c4896b45ad	Prepare to remove dossier procedure_id	2020-06-11 16:13:44 +02:00
Christophe Robillard	8df9ae3a8d	ask only effectifs for april	2020-06-10 17:41:13 +02:00
Judith	9be58aa012	only downcasing search values for yes_no type_de_champs	2020-06-10 15:55:25 +02:00
Judith	ad53dfa84d	Instructeurs: Changed the filters from 'true/false' to 'oui/non' for yes_no type_de_champ	2020-06-10 15:50:41 +02:00
Paul Chavard	d099314e56	Add decription to geo_area	2020-06-09 18:45:45 +02:00
Christophe Robillard	2fd88e3a17	affiche uniquement l'année pour les bilans	2020-06-09 17:06:08 +02:00
Christophe Robillard	81fa1d0e89	utilise un ordre plus logique pour identite entreprise ... homogenise l'affichage des valeurs monétaires elargit la colonne libellé	2020-06-09 16:59:57 +02:00
Paul Chavard	901b6e23a8	Remove legacy carto	2020-06-04 16:03:23 +02:00
Christophe Robillard	cf9d6ccf34	export bilans in ods and xlsx	2020-06-04 15:31:16 +02:00
Christophe Robillard	75a268aed6	show some info from bilans	2020-06-04 12:33:33 +02:00
Christophe Robillard	d06867822b	reorder bilans bdf csv	2020-06-03 15:45:11 +02:00
Judith	d930124839	change procedure_auto_archive helper name and added a helper for 23 h 59	2020-05-28 13:22:02 +00:00
Judith	6b65ee8d15	mailers: display auto-archive date in notifications	2020-05-28 13:22:02 +00:00
Judith	38eb60f2ac	views: display auto-archive date on procedure description	2020-05-28 13:22:02 +00:00
Judith	59346ee868	mailers: mention the auto_archive in notify_new_draft	2020-05-28 13:22:02 +00:00
Paul Chavard	20705d6e30	Do not send draft norifications to users on inactive démarches	2020-05-27 16:36:46 +02:00
Christophe Robillard	fb87a09c02	doesn't update dossier etablissement for siret controller	2020-05-26 18:13:20 +02:00
Pierre de La Morinerie	2f509c2536	specs: remove unused test case ... Actual code was removed in 0ff6c793ae The spec was never executed, because it lacked the `_spec.rb` suffix.	2020-05-20 17:45:06 +02:00
Christophe Robillard	d92a0ba8f3	raise BadFormatRequest error ... L'intention est de distinguer ce type d'erreur avec les erreurs serveur 5xx. Lorsque l'api est appelé par un Job, les erreurs serveur seront retry, car éphémères. Alors que les erreurs de type BadFormatRequest ou ResourceNotFound n'ont pas être retried.	2020-05-20 11:09:54 +02:00
Christophe Robillard	f40123fee1	display only etablissement infos ... all the other infos are not yet available because the jobs which retrieve it are performed later	2020-05-20 11:09:54 +02:00
Christophe Robillard	013e78ce4e	fix creating dossier feature sprec	2020-05-20 11:09:54 +02:00
Christophe Robillard	637bde7326	update siret_controller when finding etablissement ... now, `ApiEntrepriseService` does'nt return a hash anymore but an etablissement which is already persisted.	2020-05-20 11:09:54 +02:00
Christophe Robillard	eebfb5ee5b	update dossiers_controller when updating siret ... now, `ApiEntrepriseService` does'nt return a hash anymore but an etablissement which is already persisted.	2020-05-20 11:09:54 +02:00
Christophe Robillard	ba5fa9aa4b	update ApiEntrepriseService ... There is now the `create_etablissement` method which create etablissement with EtablissementAdapter and enqueue api_entreprise jobs to retrieve all informations we can get based on SIRET	2020-05-20 11:09:54 +02:00
Christophe Robillard	f4ebb5d107	create api_entreprise jobs	2020-05-20 11:09:54 +02:00
Christophe Robillard	e3ee423197	call api_entreprise adapters with siret	2020-05-20 11:09:54 +02:00
Pierre de La Morinerie	9f1407b6d7	expiration: fix the mailer arguments ... The mailers expect serializable arguments, but were given ActiveRecord::Relation objects instead. This made the mailers throw an exception. But how was that possible ? This code is tested, and the tests were green. Well, the specs spy on the mailer implementation, in order to check that the mailers methods were properly called. Fair enough. But if the specs mock the mailer code (instead of calling the original implementation), we may not notice that the original implementation rejects our method parameters. Here this is the case: once we actually call the original implementation the tests start to fail, because some arguments are not converted from an ActiveRecord::Relation to a serializable array. This is fixed by ensuring that the mailer code is executed (and doesn't throw an exception).	2020-05-18 16:24:08 +02:00
Pierre de La Morinerie	b63fa0e6b8	dossier: remove "Birthdate" column from export	2020-05-18 13:14:28 +00:00
Pierre de La Morinerie	00adb006b4	specs: improve ProcedureExportService spec	2020-05-18 13:14:28 +00:00
clemkeirua	77101208a4	Anonymisation de l'instructeur dans la messagerie	2020-05-18 12:56:30 +00:00
Pierre de La Morinerie	93bb5283ff	app: remove the feature flag for pieces justificatives auto-upload ... The feature works as intended: we can remove the feature flag.	2020-05-14 17:39:07 +02:00
Pierre de La Morinerie	190548844a	dossiers: add piece justificative filename to spreadsheet export	2020-05-14 10:18:10 +00:00
Paul Chavard	f0148184ca	Remove legacy carto code	2020-05-13 12:17:04 +02:00
Pierre de La Morinerie	51cb3a04a3	app: fix JS redirection with Turbolinks disabled ... When Turbolinks is enabled, a `redirect_to` in a `format: :js` request will emit code that instructs Turbolinks to navigate to the page. Turbolinks will then load the redirection target as HTML, and display it. But with Turbolinks disabled, the same `redirect_to` will instead respond with a standard `302: redirect`. `Rails.ajax` will interpret this redirect as "Please perform the same call again to the redirected URL, in the same format" – and request our redirection target, but using `format: :js`. This breaks the "Publish procedure" button. In that case, we really want the page to be navigated to. Add an explicit JS redirect, so that the redirection occurs in HTML.	2020-05-13 11:04:16 +02:00
Pierre de La Morinerie	b5f1d97629	app: disable Turbolinks ... Fix #5039	2020-05-13 11:04:16 +02:00
Paul Chavard	dfc004d7bb	Unarchive dossier when repasser_en_instruction	2020-05-12 19:05:18 +02:00
Christophe Robillard	aab4bb81ee	return bilan bdf csv for expert	2020-05-11 13:05:50 +02:00
kara Diaby	1cc04092f4	import GPX file in browser [Carto]	2020-05-11 11:36:36 +02:00
Paul Chavard	4f2e504cc2	Add carto import api ... takes a FeatureCollection to import and returns an augmented champ FeatureCollection	2020-05-07 12:06:42 +02:00
clemkeirua	36f381a743	fix flacky test	2020-05-07 10:23:28 +02:00
Paul Chavard	05e408225b	Implement atomic operations on MapEditor	2020-05-06 16:46:14 +02:00
Christophe Robillard	dba77ec0b8	fix spec with not expired token ... and use of `ApiEntrepriseToken#roles`	2020-05-06 10:57:45 +02:00
Christophe Robillard	dbf04dd0d8	make api entreprise call only if token not expired	2020-05-06 10:57:45 +02:00
Christophe Robillard	f587e6600a	extract class ApiEntrepriseToken ... and check if token is expired	2020-05-06 10:57:45 +02:00
Paul Chavard	6556df2a85	Fix a crash in case of invalid geometry	2020-05-05 15:56:05 +02:00
Paul Chavard	4299c9dbea	Use a “safe” reference date in expiration tests	2020-05-05 12:41:45 +02:00
Christophe Robillard	9de2c7c85a	improve csv generation for bilans bdf	2020-04-30 16:15:16 +02:00
Christophe Robillard	b12226c667	fetch and store bilans bdf	2020-04-30 16:15:16 +02:00
Christophe Robillard	85b2e9ef44	create bilans_bdf_adapter	2020-04-30 16:15:16 +02:00
Paul Chavard	843e033c38	Allow instructeurs to download a GeoJSON document for a given dossier	2020-04-30 15:49:43 +02:00
Christophe Robillard	3ddb5a4cb4	store attestation fiscale and display	2020-04-30 11:39:54 +02:00
Christophe Robillard	38c68b16e3	create attestation_fiscale_adapter	2020-04-30 11:39:54 +02:00
Paul Chavard	b516cbc179	Enable republish on démarches dépubliée	2020-04-29 18:04:35 +02:00
Christophe Robillard	ddd3e6bb02	don't copy api_entreprise_token when cloning ... except for an admin who owns the parent procedure	2020-04-29 17:17:20 +02:00
Christophe Robillard	158b4802ab	store attestation sociale and display	2020-04-29 16:25:47 +02:00
Christophe Robillard	d74b14c205	fetch attestation sociale url	2020-04-29 14:25:55 +02:00
Christophe Robillard	b147956a92	create attestation_sociale_adapter	2020-04-29 14:01:48 +02:00
Christophe Robillard	4bd4524f67	fix api_entreprise specs	2020-04-28 15:17:11 +02:00
Christophe Robillard	e29af48420	call api_entreprise with specific token if exist	2020-04-28 15:17:11 +02:00
Christophe Robillard	14ff18ca80	store specific api-entreprise token for a procedure	2020-04-28 15:17:11 +02:00
clemkeirua	1ac7ec2dca	precision dans mail suppression dossier en construction	2020-04-28 12:42:00 +00:00
Christophe Robillard	339066778d	send notif only to the right instructeurs ... after a dossier creation, only the instructeurs that belong to the group instructeur of the dossier, and who want notif will be notified by mail	2020-04-23 13:01:57 +02:00
Paul Chavard	9cb612bb3d	Show area and length on champ carto selections utilisateur	2020-04-23 10:21:18 +02:00
Christophe Robillard	792e755af9	expose effectif_annuel dans api graphql	2020-04-23 09:53:27 +02:00
Christophe Robillard	453adf3c74	instructeurs: affiche l'effectif moyen annuel n-1	2020-04-23 09:53:27 +02:00
Pierre de La Morinerie	32ad152347	specs: ensure that discarded procedures are not shown	2020-04-22 19:01:26 +02:00
Pierre de La Morinerie	abe692ecc2	specs: refactor instructeur procedures controller specs	2020-04-22 19:01:16 +02:00
Paul Chavard	31943f7d9c	Add handeling of expired processed dossiers to deletion service	2020-04-22 15:39:10 +02:00
Paul Chavard	f1b531911b	Handle processed dossiers in deletion mailers	2020-04-22 15:39:10 +02:00
Pierre de La Morinerie	f29ec5c775	instucteurs: don't show discarded procedures in the list	2020-04-22 15:16:21 +02:00
Pierre de La Morinerie	15645e11e3	instructeur: improve InstructeurController#index test	2020-04-22 15:12:34 +02:00
Pierre de La Morinerie	1cb18e51ac	champ: return the parent dossier even when discarded ... Dossier has a `default_scope { kept }`. Because of that, when the parent dossier is discarded, `champ.dossier` will return nil. We should kill the default scope. But meanwhile, ensure that `champ.dossier` returns even a discarded dossier.	2020-04-22 11:46:42 +02:00
Christophe Robillard	149b98007f	add effectif mensuel to graphql api	2020-04-21 21:13:07 +02:00
Christophe Robillard	1165f8483d	rename effectif columns	2020-04-21 21:13:07 +02:00
Christophe Robillard	db3ef195ad	fetch and show effectif mensuel ... - fetch and store effectif mensuel (at the creation of the dossier or when updating a siret field - show effectif mensuel only for instructeurs	2020-04-21 14:22:11 +02:00
Christophe Robillard	599d8e33e8	create ApiEntreprise::EffectifsAdapter	2020-04-21 14:22:11 +02:00
clemkeirua	2d68d7dc59	fix to_tsquery disallowed chars	2020-04-20 15:15:22 +02:00
Paul Chavard	e512870fd2	Cleanup procedure duree_conservation_dossiers_dans_ds validations	2020-04-16 19:40:19 +02:00
Paul Chavard	bc8217e030	Carte Editor sends FeatureCollection to the server	2020-04-16 18:29:19 +02:00
Paul Chavard	22604013d0	Expose multiple user selections on champ carte	2020-04-15 18:07:09 +02:00
Paul Chavard	52d2ace823	Remove quartiers prioritaires	2020-04-14 10:29:59 +02:00
clemkeirua	8c2f589cbf	fix admin deletion of empty service with archived procedures	2020-04-10 20:01:40 +02:00
clemkeirua	7335500be4	tests for dossier_helper#demandeur_dossier	2020-04-10 13:14:39 +02:00
Christophe Robillard	f683b850c3	Notifie instructeurs le souhaitant lors depot dossier ... Notifie par mail uniquement les instructeurs qui le souhaitent à chaque dépôt de dossier	2020-04-09 15:02:05 +02:00
Christophe Robillard	ae18ff6627	Notifie tous les instructeurs lors dépôt dossier ... - envoie un mail à tous les instructeurs d'une procédure après le dépôt d'un nouveau dossier	2020-04-09 14:33:56 +02:00
Christophe Robillard	969478b706	Envoie une notif aux followers_instructeurs le souhaitant ... après chaque message déposé par l'usager	2020-04-09 14:17:07 +02:00
Christophe Robillard	415d5c765e	envoie une notification à chaque follower_instructeur après un commentaire déposé	2020-04-09 14:17:07 +02:00
Paul Chavard	61eaca928f	remove WarnExpiringDossiersJob	2020-04-09 11:11:51 +02:00
Pierre de La Morinerie	7ff381b6f0	attachments: remove the buggy fallback ... The fallback would fail on non-champ attachments.	2020-04-09 10:40:08 +02:00
Pierre de La Morinerie	7e19dd2cda	Revert "Revert "Fix middle-click on "Delete attachment" button"" ... This reverts commit 6e8bd6957f.	2020-04-09 10:40:08 +02:00
clemkeirua	590cee050f	add tests for dossier_search_service	2020-04-09 09:42:31 +02:00
clemkeirua	46e14f4033	add test for users/list_dossiers_spec	2020-04-09 09:42:31 +02:00
clemkeirua	8ff3d9ea47	update existing tests	2020-04-09 09:42:31 +02:00
Paul Chavard	32f783142c	[GraphQL] allow to query dossiers by groupe instructeur	2020-04-09 09:29:28 +02:00
Pierre de La Morinerie	6e8bd6957f	Revert "Fix middle-click on "Delete attachment" button"	2020-04-08 17:40:58 +02:00
Pierre de La Morinerie	b748e9773f	attachments: fix opening the delete link directly ... When cliking on the "Delete attachment" link, and opening the URL in a new tab, the `DELETE /attachements/:id` will become `GET /attachments/:id` – which will cause the `show` action to be routed with an html format (instead of JS). In that case, we don't want to throw an error at the user face. Instead simply re-render the dossier page (if any). Fix a long-standing error in Sentry.	2020-04-08 13:40:32 +02:00
Pierre de La Morinerie	0077ff4b75	attachments: refactor the controller specs	2020-04-08 12:05:55 +02:00
clemkeirua	ed45c88bdf	do not clone groups instructeurs for admin outside the procedure	2020-04-07 09:25:40 +02:00
pedong	7806a26e2c	copy groupe_instructeurs when clone	2020-04-07 09:22:33 +02:00
Christophe Robillard	dc31f41c26	fix tests for procedure_presentation	2020-04-06 17:39:51 +02:00
Christophe Robillard	5b6044803b	forbid to create champ with same type_de_champ and same row	2020-04-06 17:39:51 +02:00
Paul Chavard	ca6c97bf0f	Refactor expired dossiers deletion service	2020-04-02 15:24:02 +02:00
Pierre de La Morinerie	059e11601b	policies: fix champ policy for guest users	2020-04-02 11:27:14 +02:00
Pierre de La Morinerie	ac922c456e	policies: refactor champ_policy_spec ... Creating champs without attaching them to a procedure works only by chance.	2020-04-02 11:27:13 +02:00
Paul Chavard	c0bbfa42b7	Reassign discarded dossiers on group_instructeur ... fix #4851	2020-04-01 18:10:12 +02:00
Paul Chavard	7ba4c513e6	Refactor notify near deletion mailers	2020-04-01 17:40:52 +02:00
Paul Chavard	288ace2f34	Dossier on discarded procedure should have access to discarded procedure	2020-03-31 17:08:29 +02:00
Paul Chavard	bd81970f67	DeletedDossier should have access to discarded demarche	2020-03-31 17:08:29 +02:00
Paul Chavard	e4ab2574ce	Démarches discarded by administrateur can be reactivated in manager	2020-03-31 17:08:28 +02:00
Paul Chavard	58c126308c	Add DiscardedProceduresDeletionJob job	2020-03-31 17:08:28 +02:00
Paul Chavard	da52ec30bd	Undo discard dossiers and demarches from manager	2020-03-31 17:08:28 +02:00
Paul Chavard	876e05aed3	Discard demarches from manager	2020-03-31 17:08:28 +02:00
Paul Chavard	60cb9bcf09	Remove brouillons deleted dossiers	2020-03-31 16:54:33 +02:00
Pierre de La Morinerie	6417c0d2c0	dossiers: allow auto upload of attachments	2020-03-31 13:09:44 +02:00
Pierre de La Morinerie	7a27e78452	specs: remove unused wait-for-ajax helper ... This helper is: - no longer used; - buggy (not all requests increment it); - discouraged (we should instead match an UI change that signals the end of an ajax request). Good riddance.	2020-03-31 12:54:49 +02:00
Pierre de La Morinerie	cae256fd28	rspec: allow Rails to auto-migrate the test schema ... rails_helper already has `ActiveRecord::Migration.maintain_test_schema!` which automatically updates the test database if needed. However, if we raise **before** `maintain_test_schema` had the chance to do its job, the test database is never-automigrated. Thus by removing the check, we ensure the test database will be migrated as needed (and still an error will be raised if the schema cannot be applied).	2020-03-31 12:48:32 +02:00
Pierre de La Morinerie	4cb747fdb6	specs: always require rails_helper ... Test helpers are separated between two files: spec_helper and rails_helper. This separation is meant to allow tests that do not require Rails (like testing standalone libs) to boot faster. The spec_helper file is always loaded, through `--require spec_helper` in the `.rspec` config file. When needed, the rails_helper file is expected to be required manually. This is fine, but: - Many test files have a redundant `require 'spec_helper'` line; - Many test files should require `rails_helper`, but don't. Not requiring `rails_helper` will cause the Rails-concerned section of the test environment not to be configured–which may cause subtle bugs (like the test database not being properly initialized). Moreover, Spring loads all the Rails files on preloading anyway. So the gains from using only `spec_helper` are thin. To streamline this process, this commit: - Configures `.rspec` to require `rails_helper` by default; - Remove all manual requires to spec_helper or rails_helper. Reference: https://stackoverflow.com/questions/24145329/how-is-spec-rails-helper-rb-different-from-spec-spec-helper-rb-do-i-need-it	2020-03-31 12:48:32 +02:00
Paul Chavard	742cc15209	Use base CronJob	2020-03-31 12:25:46 +02:00
Paul Chavard	33bf2fe109	remove deprecated AutoReceiveDossiersForProcedureJob	2020-03-31 12:25:46 +02:00
Paul Chavard	c40d689edf	Use bigger deltas to allow for month length variations	2020-03-31 11:50:59 +02:00
Pierre de La Morinerie	ed5f2fa35f	attestation: fix preview of logos ... Turns out that assigning the params to the procedure calls `read` on the images files. Calling `read` moves the seek offset to the end of the file; which means that subsequent calls to `read` return an empty string. Fix the issue by calling `rewind` before attempting to `read` the file, to ensure the seek offset is at the beginning of the file. Fix #4958	2020-03-30 14:58:50 +02:00
Pierre de La Morinerie	b8c3d7c6bd	attestation: ensure the PDF is rendered successfully	2020-03-30 14:58:50 +02:00
Pierre de La Morinerie	fe13043efd	dossier: prepare validations to piece_justificative champs ... We can't yet enable the validations, because of an issue that will (hopefully) be solved with Rails 6. See https://github.com/betagouv/demarches-simplifiees.fr/issues/4926	2020-03-30 11:12:25 +02:00
Pierre de La Morinerie	245ef2befd	specs: fix an Rspec warning	2020-03-30 11:12:25 +02:00
Paul Chavard	a60b6b6776	Use ’ consistently instead of '	2020-03-26 17:27:48 +01:00
Paul Chavard	c763679b54	Remove non-existant columns from manager dashboards	2020-03-26 16:17:07 +01:00
Paul Chavard	c707a21f97	Rename delete_and_keep_track -> discard_and_keep_track	2020-03-26 14:23:23 +01:00
Paul Chavard	c086f6d580	Add a job to remove discarded dossiers	2020-03-25 17:28:25 +01:00
Paul Chavard	5b5ae5a7a5	Do not send notifications or create operation logs on brouillon demarches	2020-03-25 15:04:52 +01:00
Pierre de La Morinerie	f895570b00	dossier: make the upload label a real label	2020-03-25 14:43:09 +01:00
clemkeirua	a34b45e4f4	make the 'male' field selected by default during identity creation	2020-03-25 09:50:41 +00:00
Christophe Robillard	b4b92accf1	instructeur: show deleted dossiers for a procedure	2020-03-25 10:19:07 +01:00
maatinito	1af32b29fd	#4807 Use now() instead of Date.time.today (better code homogeneity)	2020-03-24 17:09:14 -10:00
maatinito	f5c2dc03c5	#4807 better method/variable naming	2020-03-24 16:46:23 -10:00
Christian Lautier	e61c53f267	Fix #4807 48h before closing a procedure, notify users their draft is not submitted	2020-03-24 16:46:23 -10:00
clemkeirua	e76870844e	update test for dossier#en_construction_close_to_expiration ... It now takes into account en_construction_conservation_extension	2020-03-24 18:10:51 +01:00
clemkeirua	d49f6e703e	fix tests for datetime	2020-03-24 16:54:35 +00:00