DGNum/demarches-normaliennes
14
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

fix broken nil values in france_connect_informatio

Browse source
This commit is contained in:
clemkeirua 2020-11-11 15:40:44 +01:00
parent f0f6fea8c5
commit 64c964bf5e
2 changed files with 37 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
app/views/shared/dossiers/_france_connect_informations.html.haml
View file

@ -1,4 +1,8 @@
.card.featured
.flex.justify-center
= image_tag "logo-france-connect.png", alt: "France Connect logo", width: 200, class: "mb-2"
.card-title Le dossier a été déposé par le compte de #{user_information.given_name} #{user_information.family_name}, authentifié par France Connect le #{user_information.updated_at.strftime('%d/%m/%Y')}.
.card-title
- if user_information.updated_at.present?
Le dossier a été déposé par le compte de #{user_information&.given_name} #{user_information&.family_name}, authentifié par France Connect le #{user_information.updated_at.strftime('%d/%m/%Y')}.
- else
Le dossier a été déposé par le compte de #{user_information&.given_name} #{user_information&.family_name}.

32
spec/views/shared/dossiers/_france_connect_information.html.haml_spec.rb Normal file
View file

@ -0,0 +1,32 @@
describe 'shared/dossiers/france_connect_informations.html.haml', type: :view do
subject do
render(
'shared/dossiers/france_connect_informations.html.haml',
user_information: user_information
)
end
context "with complete france_connect information" do
let(:user_information) { build(:france_connect_information, updated_at: Time.zone.now) }
it {
expect(subject).to have_text("Le dossier a été déposé par le compte de #{user_information.given_name} #{user_information.family_name}, authentifié par France Connect le #{user_information.updated_at.strftime('%d/%m/%Y')}")
}
end
context "with missing updated_at" do
let(:user_information) { build(:france_connect_information, updated_at: nil) }
it {
expect(subject).to have_text("Le dossier a été déposé par le compte de #{user_information.given_name} #{user_information.family_name}")
expect(subject).not_to have_text("authentifié par France Connect le ")
}
end
context "with missing given_name" do
let(:user_information) { build(:france_connect_information, given_name: nil) }
it {
expect(subject).to have_text("Le dossier a été déposé par le compte de #{user_information.family_name}")
}
end
end