demarches-normaliennes/spec
Pierre de La Morinerie 4cb747fdb6 specs: always require rails_helper
Test helpers are separated between two files: spec_helper and
rails_helper. This separation is meant to allow tests that do not
require Rails (like testing standalone libs) to boot faster.

The spec_helper file is always loaded, through `--require spec_helper`
in the `.rspec` config file. When needed, the rails_helper file is
expected to be required manually.

This is fine, but:
- Many test files have a redundant `require 'spec_helper'` line;
- Many test files should require `rails_helper`, but don't.

Not requiring `rails_helper` will cause the Rails-concerned section of
the test environment not to be configured–which may cause subtle bugs
(like the test database not being properly initialized).

Moreover, Spring loads all the Rails files on preloading anyway. So the
gains from using only `spec_helper` are thin.

To streamline this process, this commit:
- Configures `.rspec` to require `rails_helper` by default;
- Remove all manual requires to spec_helper or rails_helper.

Reference: https://stackoverflow.com/questions/24145329/how-is-spec-rails-helper-rb-different-from-spec-spec-helper-rb-do-i-need-it
2020-03-31 12:48:32 +02:00
..
controllers specs: always require rails_helper 2020-03-31 12:48:32 +02:00
factories affiche infos d'un usager entreprise uniquement si diffusable 2020-03-17 15:57:02 +00:00
features specs: always require rails_helper 2020-03-31 12:48:32 +02:00
fixtures récupère les infos d'établissement avec infos non diffusables 2020-03-17 15:57:02 +00:00
helpers specs: always require rails_helper 2020-03-31 12:48:32 +02:00
jobs specs: always require rails_helper 2020-03-31 12:48:32 +02:00
lib specs: always require rails_helper 2020-03-31 12:48:32 +02:00
mailers specs: always require rails_helper 2020-03-31 12:48:32 +02:00
middlewares specs: always require rails_helper 2020-03-31 12:48:32 +02:00
models specs: always require rails_helper 2020-03-31 12:48:32 +02:00
policies specs: always require rails_helper 2020-03-31 12:48:32 +02:00
serializers Fix tests involving attachment urls 2020-01-08 14:46:18 +01:00
services specs: always require rails_helper 2020-03-31 12:48:32 +02:00
support specs: always require rails_helper 2020-03-31 12:48:32 +02:00
views specs: always require rails_helper 2020-03-31 12:48:32 +02:00
rails_helper.rb specs: always require rails_helper 2020-03-31 12:48:32 +02:00
spec_helper.rb specs: always require rails_helper 2020-03-31 12:48:32 +02:00