DGNum/demarches-normaliennes
15
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

models: require belong_to associations on commentaire

Browse source
This commit is contained in:
Pierre de La Morinerie 2020-07-20 16:34:42 +02:00
parent 32e55a6d37
commit dd1bed9340
3 changed files with 9 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/models/commentaire.rb
View file

@ -12,7 +12,7 @@
# user_id :bigint
#
class Commentaire < ApplicationRecord
belongs_to :dossier, inverse_of: :commentaires, touch: true
belongs_to :dossier, inverse_of: :commentaires, touch: true, optional: false
belongs_to :user, optional: true
belongs_to :instructeur, optional: true

8
spec/factories/commentaire.rb
View file

@ -1,12 +1,8 @@
FactoryBot.define do
factory :commentaire do
body { 'plop' }
association :dossier, :en_construction
before(:create) do |commentaire, _evaluator|
if !commentaire.dossier
commentaire.dossier = create :dossier, :en_construction
end
end
body { 'plop' }
trait :with_file do
piece_jointe { Rack::Test::UploadedFile.new('spec/fixtures/files/logo_test_procedure.png', 'image/png') }

10
spec/lib/active_storage/downloadable_file_spec.rb
View file

@ -34,15 +34,17 @@ describe ActiveStorage::DownloadableFile do
end
context 'when there is a message with no attachment' do
let(:commentaire) { create(:commentaire) }
let(:dossier) { commentaire.dossier }
before do
dossier.commentaires << build(:commentaire, dossier: dossier)
end
it { expect(list.length).to eq 0 }
end
context 'when there is a message with an attachment' do
let(:commentaire) { create(:commentaire, :with_file) }
let(:dossier) { commentaire.dossier }
before do
dossier.commentaires << build(:commentaire, :with_file, dossier: dossier)
end
it { expect(list.length).to eq 1 }
end