4068 commits

Author	SHA1	Message	Date
kara Diaby	4b6196e6f6	verify avis privacy	2021-05-25 11:24:15 +02:00
Paul Chavard	c5f2faa3d2	add tests for backward compatibility of geo_areas	2021-05-24 11:57:00 +02:00
Paul Chavard	3b85ade440	Add compatibility cadsatre layer with old API GEO	2021-05-24 11:57:00 +02:00
Paul Chavard	01c558953b	Remove API GEO legacy adapter	2021-05-24 11:50:16 +02:00
simon lehericey	b620888597	show only dossier avis	2021-05-20 16:18:04 +02:00
kara Diaby	aaf943569a	rename avis confidential test	2021-05-20 11:13:24 +02:00
simon lehericey	17617fba43	address champ needs the data column	2021-05-19 15:59:18 +02:00
simon lehericey	a46000dc1f	ensure to_s is used on specialized champ	2021-05-19 09:39:20 +02:00
Paul Chavard	e043645a88	cleanup tests	2021-05-18 11:42:10 +02:00
kara Diaby	468e9e849a	tests	2021-05-18 11:42:10 +02:00
Paul Chavard	5f419954b4	Fix dossier deleted user display	2021-05-13 10:43:55 +02:00
Paul Chavard	3f7a2bea9b	Dossier without user should be valid	2021-05-11 17:50:10 +02:00
Paul Chavard	8a74438dc1	Use conservation_extension instead of en_construction_conservation_extension	2021-05-11 17:33:53 +02:00
simon lehericey	c5f6c9ae1e	fix missing state translation	2021-05-10 11:17:34 +02:00
François Vantomme	99ce5195bc	Fix (API Entreprise): test fails randomly ... Don't assume array order, just check that all values are present	2021-05-07 17:42:15 +02:00
Pierre de La Morinerie	77b65f3aa0	tasks: remove older after_party tasks	2021-05-06 15:19:37 +02:00
simon lehericey	55b80df29d	display count before text in tabs	2021-05-06 09:13:20 +02:00
simon lehericey	5124e08ccd	disable faulty manager spec	2021-05-05 21:34:57 +02:00
simon lehericey	ccce724976	refactor as created fci must have an user_id	2021-05-05 14:36:34 +02:00
simon lehericey	e18fb116c6	cannot create fci without user	2021-05-05 14:36:34 +02:00
simon lehericey	8d0082419c	do not know how it worked before	2021-05-05 14:36:34 +02:00
simon lehericey	9dc9e92c16	use the with_user trait in feature	2021-05-05 14:28:20 +02:00
simon lehericey	1cf59f722e	add :with_user trait to fci as user_id is mandatory	2021-05-05 14:28:20 +02:00
simon lehericey	ed404f129b	remove now falling spec of obsolete task	2021-05-05 14:28:20 +02:00
simon lehericey	9fd1c604a1	display follower instructeur emails in alphabetic order	2021-05-04 16:38:34 +02:00
simon lehericey	50f679746f	do not extract twice the same dossier_id if the dossier is followed twice	2021-05-04 16:38:34 +02:00
Paul Chavard	bcbfcdc537	Revert "Merge pull request #6142 from tchak/enable_brouillon_extend_conservation" ... This reverts commit 48eb4d9778, reversing changes made to 5539d5cb8c. # Conflicts: # app/models/dossier.rb # db/schema.rb	2021-05-04 16:03:29 +02:00
Christophe Robillard	01f180022b	prend en compte uniquement les pj pour estimer la taille d'un dossier	2021-05-04 12:50:12 +02:00
Paul Chavard	f6508899de	Refactor NotificationMailer	2021-05-04 12:05:06 +02:00
Paul Chavard	a4fd629f4a	Enable user destruction	2021-05-04 12:05:06 +02:00
Paul Chavard	b2a867266a	Allow users to extend conservation on drafts	2021-04-29 19:50:30 +02:00
Christophe Robillard	3d04221dab	generate pdf export for dossier only on demand	2021-04-29 17:30:38 +02:00
Christophe Robillard	f40d96fbd2	Revert "Revert "Export de tous les dossier d'une démarche"" ... This reverts commit d9a588b52e.	2021-04-29 17:29:47 +02:00
krichtof	d9a588b52e	Revert "Export de tous les dossier d'une démarche"	2021-04-29 16:07:18 +02:00
Pierre de La Morinerie	fbfe5c3817	jobs: also retry native ActiveStorage's jobs on transient errors	2021-04-29 14:08:12 +02:00
Pierre de La Morinerie	684af77e35	jobs: extract an RetryOnTranscientErrors concern	2021-04-29 14:08:12 +02:00
simon lehericey	7b94c2de88	remove extra Dossier call in projection	2021-04-29 11:46:00 +02:00
simon lehericey	db23a853a9	fetch all notification at once	2021-04-29 11:23:41 +02:00
simon lehericey	20fb756097	one less count	2021-04-29 11:23:41 +02:00
simon lehericey	8b73d8804c	fetch all exports at once by groupe_instructeurs_ids	2021-04-29 11:23:41 +02:00
Paul Chavard	f9fb6473b4	geo module is not really accessible :(	2021-04-28 15:34:53 +02:00
Paul Chavard	85b907807a	Improuve ComboMultipleDropdownList style	2021-04-28 12:54:45 +02:00
Christophe Robillard	09870c918d	prevent race conditions when creating archives	2021-04-28 11:40:58 +02:00
Christophe Robillard	dfbe004122	rename content_type to time_span_type for archives	2021-04-28 11:40:58 +02:00
Christophe Robillard	9134114c2e	fix rubocop offenses	2021-04-28 11:40:58 +02:00
Christophe Robillard	8bee53fe77	rend plus robuste la création de l'archive	2021-04-28 11:40:58 +02:00
Christophe Robillard	71a5e41e5b	add archive_zip_globale feature flag	2021-04-28 11:40:58 +02:00
Christophe Robillard	8b2849408c	instructeurs can create and download archives	2021-04-28 11:40:58 +02:00
Christophe Robillard	07cc4fa97f	add service to create procedure archive	2021-04-28 11:40:58 +02:00
Christophe Robillard	fba0d78153	generate pdf export inside pieces_justificatives_service	2021-04-28 11:40:58 +02:00
Christophe Robillard	c25f3c79d9	add archive model	2021-04-28 11:40:58 +02:00
Paul Chavard	2a068fb9b0	Remove user feedback buttons	2021-04-22 15:40:40 +01:00
Paul Chavard	c20ad5ca17	Remove the link between commentaire and user	2021-04-22 15:10:47 +01:00
Pierre de La Morinerie	d530b272a1	password: add specific page for reset instructions	2021-04-22 14:24:15 +02:00
simon lehericey	553e1d973c	remove old methods	2021-04-22 10:46:04 +02:00
simon lehericey	5bfd4ecbbf	add DossierProjectionService	2021-04-22 10:46:04 +02:00
Pierre de La Morinerie	7ee29b2190	spec: fix flaky expert test ... In this test, two Avis are created for each expert: - one for the original dossier, - one for the dossier linked to the original dossier. When we check for a sign-up link, we should do so using the Avis for the original dossier explicitely.	2021-04-20 12:06:12 +02:00
Pierre de La Morinerie	6b14420ffa	sign_in: improve "Forgot password?" appearance on mobile	2021-04-20 09:34:52 +02:00
Pierre de La Morinerie	0749d981ab	password: make the "Reset password" button clearer	2021-04-20 09:34:52 +02:00
Pierre de La Morinerie	fffb85987c	app: retain user email on sign-in error	2021-04-20 09:34:52 +02:00
kara Diaby	5982660c37	tests	2021-04-19 10:23:45 +02:00
François Vantomme	f747b0a46a	Chore(test): enable rspec only-failures support	2021-04-15 14:17:39 +02:00
kara Diaby	198e3ed3b8	expert mailer instead of avis mailer	2021-04-15 12:22:40 +02:00
kara Diaby	f4aa29a799	add expert mailer preview	2021-04-15 11:29:55 +02:00
Paul Chavard	6d37e1d133	Fix discarded procedures destruction	2021-04-14 12:24:16 +01:00
Paul Chavard	5b56ec425b	Fix discarded dossiers destruction	2021-04-14 12:24:16 +01:00
François Vantomme	a596df9a4a	Test: use APPLICATION_NAME to deal nicely with custom configuration	2021-04-13 22:46:33 +02:00
Pierre de La Morinerie	872f6b0153	lib: add migration helpers for making a column unique	2021-04-13 18:09:59 +02:00
simon lehericey	fde433a7cf	do not ask for avis if the dossier is absent	2021-04-13 12:04:45 +02:00
simon lehericey	c683fad3f3	[#6084] add after_party task to fill missing data	2021-04-13 09:59:28 +02:00
simon lehericey	52c8b60419	This is why you need to add a COUNT(DISTINCT dossiers.id) to make it work	2021-04-13 09:32:48 +02:00
simon lehericey	594cda3ee3	Remove previous attempt but steal its spec	2021-04-13 09:32:48 +02:00
simon lehericey	6055fd1b0b	remove for_procedure	2021-04-13 09:32:48 +02:00
simon lehericey	7567e51a3f	add ui for integrity error	2021-04-06 18:11:26 +02:00
simon lehericey	d552e364fc	retry 5 times on integrity error and then block processing	2021-04-06 18:03:39 +02:00
Pierre de La Morinerie	62051c926a	app: move update_allow_decision_access to ExpertsController	2021-04-06 14:54:18 +02:00
Pierre de La Morinerie	c82c72402d	app: move the experts list to ExpertsProceduresController	2021-04-06 14:29:02 +02:00
Pierre de La Morinerie	7acb4cee83	controllers: use standard action names in ExpertsProceduresController	2021-04-06 13:45:51 +02:00
Pierre de La Morinerie	3f25624a5a	routes: nest ExpertsProcedures routes in a resource	2021-04-06 13:18:51 +02:00
Pierre de La Morinerie	9096a3885c	specs: fix creating dossiers :en_construction	2021-04-06 12:12:56 +02:00
Pierre de La Morinerie	02743365eb	specs: make build and create consistent in downloadable_file_spec	2021-04-06 12:12:56 +02:00
kara Diaby	a8b30c0cdc	add react component (expert view) and block it when the flag is activated	2021-04-06 10:39:24 +02:00
kara Diaby	8a1cdf31e3	tests	2021-04-06 10:38:46 +02:00
Pierre de La Morinerie	6eadcf614d	spec: improve the dossier_controller timestamp specs ... Make the specs clearer, and better test the various timestamps.	2021-04-06 10:26:17 +02:00
Paul Chavard	fd48b86b7f	Simplify export unicity check and use create_or_find_by	2021-04-01 21:14:16 +01:00
simon lehericey	5b69e087c7	fix sentry test	2021-04-01 11:57:16 +02:00
Pierre de La Morinerie	f6f013e87f	specs: fix Avis query in specs	2021-03-25 13:24:53 +01:00
Pierre de La Morinerie	21356e42b8	specs: remove unused require	2021-03-25 13:24:53 +01:00
kara Diaby	18f89b0d83	adjust tests	2021-03-24 17:47:24 +01:00
maatinito	cc19453f68	views: fix warning message about incomplete fields for attestation ... The labels for the champs and private champs were inverted.	2021-03-23 16:56:02 +01:00
Paul Chavard	0b22788d60	experts_procedure should not be optional	2021-03-23 13:46:33 +01:00
Paul Chavard	224c7ec6c3	Update spec/models/dossier_spec.rb ... Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com>	2021-03-23 10:51:55 +01:00
Paul Chavard	84214f4bd4	Do not export non exportable champs on draft procedures	2021-03-23 09:55:37 +01:00
Paul Chavard	1449fbbe67	Fix multiple_drop_down_list mandatory check	2021-03-18 15:22:28 +01:00
kara Diaby	bb47c88c5f	fix expert spec feature	2021-03-18 14:36:08 +01:00
kara Diaby	64b94100f4	fix dossier link helper	2021-03-18 14:36:08 +01:00
kara Diaby	81f5a5254b	tests	2021-03-18 11:38:52 +01:00
Paul Chavard	866ae256a3	Add revision dossiers filters	2021-03-17 11:53:48 +01:00
Christophe Robillard	dfed8f32ae	update link to download dossier and all pjs	2021-03-16 15:13:17 +01:00
Christophe Robillard	60cc4d3697	add pdf to pjs export	2021-03-16 15:13:17 +01:00
Paul Chavard	76aa7bdfe3	Add default nil value for numero_tva_intracommunautaire	2021-03-16 12:57:10 +01:00
Paul Chavard	4f03c231a3	Add tests for GeoJSON validation	2021-03-16 12:27:28 +01:00
Pierre de La Morinerie	be58d82016	specs: clear jobs queue before each test ... This avoids `perform_enqueued_jobs` to execute jobs from the previous tests.	2021-03-16 11:49:14 +01:00
Pierre de La Morinerie	75a1046315	active_storage: refactor concerns ... Follow-up of #5953. Refactor the concerns with two goals: - Getting closer from the way ActiveStorage adds its own hooks. Usually ActiveStorage does this using an `Attachment#after_create` hook, which then delegates to the blob to enqueue the job. - Enqueuing each job only once. By hooking on `Attachment#after_create`, we guarantee each job will be added only once. We then let the jobs themselves check if they are relevant or not, and retry or discard themselves if necessary. We also need to update the tests a bit, because Rails' `perform_enqueued_jobs(&block)` test helper doesn't honor the `retry_on` clause of jobs. Instead it forwards the exception to the caller – which makes the test fail. Instead we use the inline version of `perform_enqueued_jobs()`, without a block, which properly ignores errors catched by retry_on.	2021-03-16 11:49:14 +01:00
Paul Chavard	00d7c3186a	fix indentation	2021-03-09 14:47:23 +01:00
Paul Chavard	70500e3d56	Groupe instructeur selector default blank	2021-03-09 14:47:23 +01:00
Pierre de La Morinerie	f9401cfbad	spec: better split spec_helper and rails_helper ... This fixes the > DEPRECATION WARNING: Initialization autoloaded the constants ActionText::ContentHelper and ActionText::TagHelper. error appearing when running specs. It also gets us closer from a newly-generated rails config.	2021-03-04 22:59:39 +01:00
Pierre de La Morinerie	2f948f7e46	active_storage: fix blob update hooks ... For some reason on Rails 6.1 the `after_update_commit` hook is properly registered – but disappears from the record later, and in the end is never run. Fix it by using the general `after_commit` hook instead.	2021-03-04 14:30:38 +01:00
Paul Chavard	5d4f025be0	Rename for consistency with defaut_groupe_instructeur	2021-03-04 10:45:02 +01:00
Paul Chavard	89ec3923f2	Defaut groupe instructeur ordered by label	2021-03-04 10:35:44 +01:00
Paul Chavard	96a832bc19	Add SerializerService	2021-03-02 12:42:22 +01:00
Pierre de La Morinerie	1c77f59f6b	specs: fix test failing on March 1st ... Because February only has 28 days.	2021-03-02 12:26:28 +01:00
Pierre de La Morinerie	473a86b861	gems: remove guard ... - It doesn't seem used a lot these days - It has some incompatibility with rspec 4 We need to explicitely add the 'listen' gem now though.	2021-02-25 10:45:42 +00:00
Paul Chavard	46a839e7f7	Remove a spec that was testing bug in libgeos ... we don’t use libgeos anymore	2021-02-23 10:35:30 +01:00
Pierre de La Morinerie	d9ea415d44	specs: fix rspec warning about raise_error specificity	2021-02-23 08:25:31 +01:00
Paul Chavard	75392272fb	Add champ address model	2021-02-17 19:10:16 +01:00
Paul Chavard	228a83f8a5	Add api address external data fetch	2021-02-17 19:10:16 +01:00
Paul Chavard	7eee14feef	Add ChampFetchExternalDataJob	2021-02-17 19:10:16 +01:00
Christophe Robillard	d55f156aec	admin: durée de conservation des données hors ds n'est plus demandée ... La colonne est tout de même gardée en base	2021-02-17 16:41:57 +01:00
Pierre de La Morinerie	98be7e2076	Fix new Rubocop warnings	2021-02-16 16:31:30 +00:00
Christophe Robillard	8b55f67964	accepte nouvelles valeurs pour ComboMultipleDropdownList	2021-02-16 16:47:15 +01:00
Christophe Robillard	7565a25b51	rend accessible l'affectation d'un instructeur ... en remplaçant select2 par ComboMultipleDropdownList	2021-02-16 16:47:14 +01:00
Christophe Robillard	3fc7b57b8c	rend accessible la personnalisation des filtres instructeurs ... en remplaçant select2 par ComboMultipleDropdownList	2021-02-16 16:47:14 +01:00
Christophe Robillard	c855d13994	rend accessible l'envoi de dossier par un instructeur ... en remplaçant select2 par ComboMultipleDropdownList	2021-02-16 16:47:14 +01:00
Christophe Robillard	b8097e782a	rend accessible la selection multiple usager ... en remplaçant select2 par ComboMultipleDropdownList	2021-02-16 16:47:14 +01:00
kara Diaby	8310dc48bf	tests	2021-02-16 09:46:18 +00:00
kara Diaby	7b4ec486ec	change active record request to get expert list	2021-02-16 09:46:18 +00:00
Paul Chavard	9ce07be1ee	[GraphQL] modifier annotation	2021-02-11 17:45:14 +01:00
Christophe Robillard	a288a13805	disable france connect authentication for admin and instructeurs	2021-02-10 18:13:47 +01:00
Paul Chavard	00e1d88a75	clean up download helper data before test run	2021-02-09 15:13:13 +01:00
Paul Chavard	c04077ca34	fix flaky test by imposing a stable sort order	2021-02-09 15:13:04 +01:00
Pierre de La Morinerie	150ddab660	zeitwerk: Api -> API	2021-02-09 13:07:30 +01:00
Pierre de La Morinerie	88ffa10a56	spec: fix rspec raise_error warning ... Rspec warns that if there is for example a SyntaxError, the test will pass (an error was raised, but it wasn't an ArgumentError, so this is fine). Instead check that no error occurs whatsoever.	2021-02-09 10:12:32 +01:00
Pierre de La Morinerie	0d94eacf32	spec: fix Ruby 2.7 arguments passing	2021-02-09 09:20:46 +01:00
Paul Chavard	a591d5528e	Add job exception log methods to champ and dossier	2021-02-05 18:56:27 +01:00
Pierre de La Morinerie	3b5617b123	mailers: remove dead AdministrationMailer code	2021-02-04 12:15:13 +01:00
Judith	6d89a83d14	unused locales clean-up	2021-02-04 12:15:13 +01:00
Pierre de La Morinerie	0d101f3f1a	views: remove old design's leftbars	2021-02-02 15:33:09 +01:00
Paul Chavard	a503417298	Remove old css and js	2021-02-02 15:26:11 +01:00
Paul Chavard	41c3a98d7d	Update Raven references to use Sentry	2021-01-28 19:46:36 +01:00
kara Diaby	9b8d2f6fd3	instead of call Avis table, we now call Experts Procedure table to see the experts list	2021-01-26 13:59:10 +01:00
Paul Chavard	4452b2cf45	fix order of types de champ on procedure	2021-01-26 10:45:34 +01:00
kara Diaby	2987139dd6	Link avis to an expert	2021-01-22 14:31:02 +01:00
kara Diaby	efbff0f2e0	add expert factory	2021-01-20 18:03:06 +01:00
kara Diaby	da067597ab	Add create expert method	2021-01-20 18:03:05 +01:00
kara Diaby	e0cb0eebab	Tests : add an expert to a procedure and put give him the access to see the dossier final decision	2021-01-20 18:03:05 +01:00
simon lehericey	d409a9a6c5	Procedure and expert link	2021-01-20 18:03:05 +01:00
Christophe Robillard	792b53beeb	import several instructeurs for a routee procedure ... Co-authored-by: simon lehericey <mail@simon.lehericey.net>	2021-01-20 15:03:17 +01:00
simon lehericey	650a598698	ensure a buggy procedure does not block the others from being closed	2021-01-19 10:42:16 +01:00
simon lehericey	d72f0c6dd2	Add authorized content type for pj	2021-01-18 17:23:08 +01:00
Paul Chavard	54f2084aef	Add annuaire_education champ	2021-01-14 17:57:48 +01:00
Paul Chavard	5c9f2e8783	Add api education adapter and job	2021-01-14 17:57:48 +01:00
Paul Chavard	dc08993a89	Add DateTime champ to GraphQL	2021-01-14 14:08:42 +01:00
Paul Chavard	f33544f067	Fix type_de_champ repetition revision after clone ... fix #5769	2021-01-12 10:57:34 +01:00
kara Diaby	8f6440f615	Admins can see the list of invited experts	2020-12-21 14:55:51 +01:00
kara Diaby	2b06ee95e1	Add a method to retrieve all invited experts for all procedure dossiers	2020-12-21 14:55:51 +01:00
Paul Chavard	d2bcbaa180	Fix stable filters migration	2020-12-17 17:10:56 +01:00
simon lehericey	4960eda5cb	use stable id	2020-12-17 10:51:09 +01:00
simon lehericey	cbccdea8e0	move displayed_fields for select to procedure_controller	2020-12-17 10:51:08 +01:00
simon lehericey	1159494d37	Add test to ensure no titre identite is exported	2020-12-16 17:31:38 +01:00
Paul Chavard	a2e87cbb56	Add attestation, justificatifs, operation_logs and bill_signatures to dossier export	2020-12-16 16:34:31 +01:00
simon lehericey	5bc4fab0c4	exhaustive test of discarded_dossier_deletion_job	2020-12-16 15:00:26 +01:00
kara Diaby	c7643154d1	final optims after sim review	2020-12-16 15:00:26 +01:00
kara Diaby	f3c4040d2d	add grace period to deleted dossiers	2020-12-16 15:00:26 +01:00
simon lehericey	d2f3bb18f9	instructeur can delete a dossier UI	2020-12-16 15:00:26 +01:00
kara Diaby	00b5ad7a10	EQT instructeur, je peux supprimer un dossier terminé	2020-12-16 15:00:26 +01:00
Christophe Robillard	15a395fbc7	superadmin: check complexity password server side	2020-12-15 16:26:09 +01:00
Christophe Robillard	94b3ec942b	super_admin: check password complexity client side	2020-12-15 16:26:09 +01:00
simon lehericey	bc4dc22aea	spec: use real signature to avoid mocking	2020-12-14 14:09:15 +01:00
simon lehericey	5a9cd71783	fix bill signature	2020-12-11 15:49:05 +01:00
Paul Chavard	fed300bfe1	Fix and test ActiveStorage::IntegrityError on upload	2020-12-11 10:30:17 +01:00
Paul Chavard	65d650eba6	Better graphql mutation error messages	2020-12-10 18:35:24 +01:00
kara Diaby	f748ccfc9e	Appelle l'API entreprise avec le token en Header	2020-12-10 17:49:49 +01:00
Paul Chavard	3c6e30a326	Show titre identite link only once watermark is added	2020-12-10 16:50:03 +01:00
Paul Chavard	48e7822e34	Remove titres identite after a dossier is processed	2020-12-10 15:21:25 +01:00
Christophe Robillard	23ae528c6b	affiche Madame ou Monsieur ... mais continue à enregistrer en base Mme ou M.	2020-12-08 21:30:54 +01:00
Christophe Robillard	2066e3db87	rend plus compréhensible la civilité	2020-12-08 18:31:38 +01:00
clemkeirua	513d4f6ff1	move all the cron jobs in a dedicated directory	2020-12-08 13:22:43 +00:00
Christophe Robillard	12d1a5bece	implement ComboPaysSearch	2020-12-08 13:09:08 +00:00
simon lehericey	b187244a29	extract and refactor api errors	2020-12-04 17:07:30 +01:00
simon lehericey	05e9130634	refator test	2020-12-03 11:52:01 +01:00
simon lehericey	f56235c7ee	retry exponentially on api entreprise timeout	2020-12-03 11:52:01 +01:00
simon lehericey	9eab310565	[#5675] for all api entreprise job, retry on 502, 503	2020-12-02 18:25:31 +01:00
Paul Chavard	cac981cf42	fix warning with ruby 2.7	2020-11-25 10:46:34 +01:00
Paul Chavard	b897e0cc1c	[GraphQL] add better errors when attachments are not properly used	2020-11-17 12:40:14 +01:00
Christophe Robillard	9347951cea	act as an saml identity provider	2020-11-16 12:19:54 +01:00
clemkeirua	64c964bf5e	fix broken nil values in france_connect_informatio	2020-11-11 15:40:44 +01:00
kara Diaby	bc0f77978f	add an api token verification for api entreprise	2020-11-09 16:58:24 +01:00
kara Diaby	c033ef0910	Ajoute a l'information de connexion France Connect dans les informations du dossier ainsi que sur la demande usager	2020-11-05 19:30:13 +01:00
kara Diaby	4b2e3b5be7	Revert "Merge pull request #5710 from betagouv/revert-5705-feat/5701" ... This reverts commit aae77c77b0, reversing changes made to 4c2c5c630c.	2020-11-05 19:30:13 +01:00
Christophe Robillard	5562e65bf3	refacto: rename administration to super_admin	2020-11-05 16:03:55 +01:00
Christophe Robillard	2a0ebd062a	enable 2FA for manager ... when trying to access manager, if superadmin did'nt enable otp, he/she is redirected to a page to enable 2FA. When superadmin is enabling 2FA, he has to to scan a qrcode with the 2FA application client. And afterwards, the superadmin has to log in with email, password and OTP code.	2020-11-05 16:03:55 +01:00
Christophe Robillard	305ccdc0cd	add recoverable and two_factor stragegy for administration	2020-11-05 16:03:55 +01:00
Christophe Robillard	6c2eb22960	remove github authentication for manager	2020-11-05 16:03:55 +01:00
Kara Diaby	f78e0ced3a	Revert "feat 5701 - Ajoute l'information lorsqu'un usager s'authentifie via France Connect"	2020-10-30 18:28:08 +01:00
kara Diaby	e6c1a20329	Ajoute l'information lorsqu'un usager s'authentifie via France Connect	2020-10-30 17:28:54 +01:00
simon lehericey	c563956a9f	retry each day during 5 days to fetch attestation social	2020-10-28 15:53:58 +00:00
clemkeirua	89316c0689	fix counter for dossiers suivis/à suivre when unfollow	2020-10-28 13:51:35 +00:00
clemkeirua	b4910c557d	ajout de procedure.dossiers_count_for_instructeur	2020-10-28 13:51:35 +00:00
Kara Diaby	0bd48999bd	Revert "feat/5635 - Supprime la possibilité pour l'expert invité d'envoyer un message"	2020-10-12 09:24:34 +02:00
Paul Chavard	7c58f06c60	always validate geometries returned from api	2020-10-08 16:03:28 +02:00
Paul Chavard	653270d02f	Update specs	2020-10-08 15:26:15 +02:00
kara Diaby	6636b7f14c	Supprime la possibilité pour l'expert invité d'envoyer un message à l'usager	2020-10-08 11:14:09 +02:00
Paul Chavard	0aa06d0197	[GraphQL] expose dossier pdf, geojson and attestation	2020-10-06 21:54:43 +02:00
kara Diaby	9207cc5aa5	Ajoute un flag pour qu'un expert ne puisse pas inviter une autre personne à donner son avis sur un dossier	2020-10-02 18:57:29 +02:00
Paul Chavard	59086cc728	Fix geo length computations	2020-10-01 15:09:38 +02:00
Paul Chavard	4dfc1c719f	Fix geo areas computations	2020-10-01 15:09:38 +02:00
kara Diaby	57adb90c8f	add the possibility for administrator to refuse external review on a specific procedure	2020-10-01 10:55:19 +02:00
clemkeirua	67b8bf4754	smaller font-size for large footers in attestation	2020-09-30 14:05:12 +02:00
Paul Chavard	1bd59c72e5	Include in exports types_de_champ from all revisions	2020-09-30 13:42:38 +02:00
kara Diaby	e174079850	fix send a copy link	2020-09-30 10:03:08 +02:00
kara Diaby	2a69e2fbeb	fix services choice into a procedure	2020-09-29 19:53:28 +02:00
Keirua	3fa628235e	Nettoyage de I18n.transliterate pour les noms de feuilles d'exports ... Co-authored-by: LeSim <mail@simon.lehericey.net>	2020-09-29 15:50:19 +00:00
clemkeirua	9714b607aa	ensure valid excel worksheet names	2020-09-29 15:50:19 +00:00
simon lehericey	1eb780b0c9	convert sheet_name to ascii before tuncate to 30 to ensure length < 31 bytes	2020-09-29 14:11:06 +02:00
clemkeirua	245e9e59c7	do not run ApiEntreprise jobs on missing etablissements	2020-09-28 17:36:38 +02:00
clemkeirua	f3e487bd9e	replace filter+first with find	2020-09-25 12:53:11 +00:00
clemkeirua	eb46cc6425	piecejusticative file validation focus on size	2020-09-25 09:35:16 +00:00
clemkeirua	c155de1d7e	ajout de la liste des extensions	2020-09-25 09:35:16 +00:00
clemkeirua	a465bad405	fix broken test in champ_serializer_spec	2020-09-25 09:35:16 +00:00
clemkeirua	31d48c2879	validation is enableed only for 'new' procedures	2020-09-25 09:35:16 +00:00
clemkeirua	8711e8f911	reenable validator on piece_justificative	2020-09-25 09:35:16 +00:00
clemkeirua	c19b653581	higher level length sanitization for worksheet length	2020-09-24 14:59:46 +02:00
Paul Chavard	26a6e18cb9	Do not crash when rgeo can’t calculate polygon area ... example are “hourglass” shaped polygons	2020-09-23 16:52:08 +02:00
Paul Chavard	61c315b276	Fix geo area point coordinates display	2020-09-23 16:52:08 +02:00
kara Diaby	cb4e91c405	Add iban type de champ	2020-09-23 15:56:26 +02:00
Paul Chavard	973973ab6a	Do not enqueue web hooks for empty urls	2020-09-22 17:03:19 +02:00
Paul Chavard	a3f3b8a8e0	procedure.dossiers through revisions	2020-09-22 10:55:17 +02:00
Paul Chavard	061a743759	[GraphQL] Add archiver mutation	2020-09-22 08:34:38 +00:00
clemkeirua	005c244438	fixup! add fix for nil values on numeroVoie and typeVoie	2020-09-22 10:17:54 +02:00
clemkeirua	7ba8ab9e6a	maj du schema json	2020-09-22 10:14:55 +02:00
clemkeirua	412a87e532	add fix for nil values on numeroVoie and typeVoie	2020-09-22 09:43:44 +02:00
clemkeirua	1173f1e459	add default values when nil	2020-09-22 09:43:44 +02:00
clemkeirua	adb2a91640	add a broken test case	2020-09-22 09:43:44 +02:00
clemkeirua	4c17acf349	ajout du code effectif entreprise dans une spec graphql nominale	2020-09-22 09:43:44 +02:00
clemkeirua	482bfdb059	fix tests for autosave_brouillon	2020-09-21 08:46:01 +00:00
clemkeirua	f9c4e967d6	remove :autosave_dossier_draft	2020-09-21 08:46:01 +00:00
clemkeirua	f96377d878	refactor Dossier#with_notifications	2020-09-21 08:28:42 +00:00
clemkeirua	d01a53eb72	remove :cached_notifications gate	2020-09-21 08:28:42 +00:00
kara Diaby	5c68d75107	add titre_identite champ	2020-09-18 14:57:08 +02:00
clemkeirua	2b23eefee2	fix tests that now requir an admin user to have a strong password	2020-09-18 11:16:34 +02:00
clemkeirua	d8b4cc67be	add a test scenario for users	2020-09-18 11:16:34 +02:00
clemkeirua	1e32a3c11f	add complexity check to admin account creation	2020-09-18 11:16:34 +02:00
clemkeirua	5a8fbde0e7	remove dead code in admin model	2020-09-18 11:16:34 +02:00
clemkeirua	de3118bc7b	force password reset on admin promotion or creation	2020-09-17 16:39:13 +02:00
clemkeirua	0307beecd6	Revert "Merge pull request #5576 from tchak/soft-delete-users" ... This reverts commit bf0d3914ce, reversing changes made to 503527459e.	2020-09-17 15:39:16 +02:00
clemkeirua	08d0fa80fa	remove old route	2020-09-17 14:03:31 +02:00
Paul Chavard	a0dd3604a4	User discard_and_anonymize!	2020-09-17 11:16:56 +02:00
clemkeirua	6643b598c3	remove :administrateur_graphql	2020-09-17 09:24:50 +02:00
clemkeirua	01ac4d7e19	remove operation_log_serialize_subject	2020-09-17 09:24:50 +02:00
kara Diaby	13e4589905	Publications page to the new UI (admin)	2020-09-16 09:15:44 +02:00
simon lehericey	e4de522b48	only retrieve id of procedures with notifications	2020-09-11 09:43:04 +00:00
simon lehericey	86b04d4275	Add a missing test on job retry to the excon err	2020-09-09 09:08:48 +00:00
clemkeirua	a62907f33b	add more tests for phone numbers	2020-09-09 09:00:03 +02:00
clemkeirua	52d5a52ff9	test fonctionnel notifications avis	2020-09-08 15:40:42 +00:00
clemkeirua	bfd24e8aee	test fonctionnel notification annotations privees	2020-09-08 15:40:42 +00:00
clemkeirua	b7b61e79ab	test fonctionnel notification champ	2020-09-08 15:40:42 +00:00
clemkeirua	1fafcad401	test fonctionnel notifications commentaire	2020-09-08 15:40:42 +00:00
clemkeirua	c7b96d3d43	add feature-flip for instructeurs on cached notifications	2020-09-08 15:40:42 +00:00
clemkeirua	52ea5ef89a	make Dossier#with_notifications great again ... Co-authored-by: Christophe Robillard <christophe.robillard@beta.gouv.fr>	2020-09-08 15:40:42 +00:00
Paul Chavard	91bc2db594	Expose revisions on GraphQL API	2020-09-08 10:54:13 +02:00
clemkeirua	61cf33e3ca	remove duplicate private champ	2020-09-04 15:40:23 +02:00
kara Diaby	ae61c279af	migrate emails text editor to new interface	2020-09-03 14:42:22 +02:00
Paul Chavard	36668403b6	cleanup feature helper	2020-09-02 11:26:26 +02:00
Paul Chavard	0a70291b90	update services specs to use revisions	2020-09-02 11:26:26 +02:00
Paul Chavard	4c0f9a4d61	update serializers specs to use revisions	2020-09-02 11:26:26 +02:00
Paul Chavard	d1e0b65658	update jobs specs to use revisions	2020-09-02 11:26:26 +02:00
Paul Chavard	6a33a8e48b	update controllers specs to use revisions	2020-09-02 11:26:26 +02:00
Paul Chavard	dee12a2b0b	update features specs to use revisions	2020-09-02 11:26:26 +02:00
Paul Chavard	1488e0964b	update models specs to use revisions	2020-09-02 11:26:26 +02:00
Paul Chavard	d1fb6c559e	Update factories to use revisions	2020-09-02 11:26:26 +02:00
Judith	7eee9beed7	adapting the specs	2020-09-01 16:48:41 +02:00
Judith	25a24ba7c8	removal of translation keys already present in the gem rails-i18n	2020-09-01 16:33:58 +02:00
Pierre de La Morinerie	0800bf68d0	views: allow unselecting all values from a multiple dropdown ... Currently, deselecting all values from a multiple dropdown rendered as checkboxes doesn't have any effect when submitting the form (the previous values are still there, instead of being deselected). This is because unchecked checkboxes are not sent by the browser – so the "empty selection" never gets sent. Rails `form.check_box` usually works around this by inserting an empty hidden checkbox element, that will be sent even if all others are de-selected. But the documentation warns that this is not possible when iterating over an array (rather than a model). Which is our case here. To fix this, this commit uses `collection_check_boxes` instead. It will insert the proper hidden checkboxes in all cases, and fix our use case. See https://api.rubyonrails.org/classes/ActionView/Helpers/FormOptionsHelper.html#method-i-collection_check_boxes	2020-08-27 11:13:40 +02:00
Pierre de La Morinerie	4bba1f0660	views: add a "None" option to optional radio lists ... After clicking on a radio button option, it is impossible to revert to the "None of the values selected" state. However on non-mandatory fields, reverting to the no-selection value should be possible. To fix this, add an explicit "N/A" option.	2020-08-25 11:42:30 +02:00
Christophe Robillard	090a247ba9	validates phone champ server side	2020-08-20 15:33:03 +02:00
Christophe Robillard	f77cc06a91	prend en compte le nom de l'enseigne pour l'établissement	2020-08-20 14:23:02 +02:00
Pierre de La Morinerie	a7361fdbd3	models: require belong_to associations on mail templates	2020-08-18 15:57:37 +02:00
Pierre de La Morinerie	29e8c43e5e	models: require belong_to associations on groupe_instructeur	2020-08-18 15:57:37 +02:00
Pierre de La Morinerie	5a7bd24fba	models: require belong_to associations on type_de_champ ... - Make `type_de_champ.procedure` a requirement; - Move the procedure_id assignation to `before_validation` (otherwise the record is invalid, and never gets saved);	2020-08-18 15:57:37 +02:00
Pierre de La Morinerie	6328011f60	models: require belong_to associations on champ ... - Make `champ.dossier` a requirement; - Move the dossier_id assignation to `before_validation` (otherwise the record is invalid, and never gets saved); - Allow specs to only build the champ (instead of saving it to the database), which bypasses the requirement to have a dossier.	2020-08-18 15:57:37 +02:00
Pierre de La Morinerie	71d9774d58	models: require belong_to associations on trusted_device_token	2020-08-18 15:57:37 +02:00
Pierre de La Morinerie	059c147ffc	models: require belong_to associations on service	2020-08-18 15:57:37 +02:00
Pierre de La Morinerie	ce53e219e0	models: require belong_to associations on procedure_presentation ... Some tests are still failing	2020-08-18 15:57:37 +02:00
Pierre de La Morinerie	802d3804f5	models: require belong_to associations on invite	2020-08-18 15:57:37 +02:00
Pierre de La Morinerie	fe8804f208	models: require belong_to associations on individual	2020-08-18 15:57:37 +02:00
Pierre de La Morinerie	afb1c33154	models: require belong_to associations on geo_area	2020-08-18 15:57:37 +02:00
Pierre de La Morinerie	aff2713032	models: require belong_to associations on follow	2020-08-18 15:57:37 +02:00
Pierre de La Morinerie	91619b16e8	models: require belong_to associations on feedback	2020-08-18 15:57:36 +02:00
Pierre de La Morinerie	51d392a1dc	models: require belong_to associations on dossier	2020-08-18 15:57:36 +02:00
Pierre de La Morinerie	dd1bed9340	models: require belong_to associations on commentaire	2020-08-18 15:57:36 +02:00
Pierre de La Morinerie	32e55a6d37	models: require belong_to associations on avis	2020-08-18 15:57:36 +02:00
Pierre de La Morinerie	aefdd5d2a1	models: require belong_to associations on attestation_template	2020-08-18 15:57:36 +02:00
Pierre de La Morinerie	1ea4c2aa36	models: require belong_to associations on attestation	2020-08-18 15:57:36 +02:00
Pierre de La Morinerie	c1e2928ce7	models: require belong_to associations on assign_to	2020-08-18 15:57:36 +02:00
Pierre de La Morinerie	df2429d7ad	factories: build type_de_champ instead of creating them ... This allows to minimize the number of actual creations when only a build is requested.	2020-08-13 17:39:49 +02:00
Pierre de La Morinerie	c8ec5c8846	factories: remove the Rubocop workaround	2020-08-13 17:39:49 +02:00
Judith	bfabd3b6a5	Specs adapted	2020-08-13 13:41:45 +00:00
Christophe Robillard	0b35619322	skip verify authenticity token for helpscout ... Co-authored-by: LeSim <mail@simon.lehericey.net>	2020-08-10 17:19:22 +02:00
kara Diaby	9b66c894b2	Adapt configuration email view to the new UI	2020-08-06 16:56:24 +02:00
Pierre de La Morinerie	65809f8ea0	config: flip action_dispatch_return_only_media_type_on_content_type ... This makes `ActionDispatch::Controller#content_type` return not only the MIME type, but also in some circumstances the charset. Example: ```ruby reponse.content_type == 'text/html; charset=utf-8' ``` The MIME type-only fragment can now be accessed using `#media_type`. Changes to the tests are not stricly necessary (because no charset is present in the actual value), but represent the intent better.	2020-08-05 16:48:36 +02:00
Pierre de La Morinerie	8962db38cc	models: render attestations in a simpler way ... The older method of instanciating an entire new rendering stack can be made simpler using Rails >= 5.0 methods. See https://api.rubyonrails.org/classes/ActionController/Renderer.html#method-i-render	2020-08-04 16:53:46 +02:00
clemkeirua	21221a7c49	fix missing alt	2020-08-04 13:41:10 +00:00
clemkeirua	101acafb65	fix hidden label	2020-08-04 13:41:10 +00:00
clemkeirua	cc9341a83c	fix missing header for account creation	2020-08-04 13:41:10 +00:00
jpoulvel	bf94cc021b	Merge pull request #5424 from betagouv/new_design_edit_attestation ... New design page admin/attestation_templates/edit	2020-07-31 11:18:22 +02:00
kara Diaby	db3e40ebf8	Fixe la non possibilité de cloner une démarche pour une procédure archivée (nouvelle interface administrateur)	2020-07-30 12:00:43 +02:00
clemkeirua	c772c3454c	update dossier after saving champ ... update last_champ_updated_at without hook update last_champ_private_updated_at without hook Co-authored-by: Christophe Robillard <christophe.robillard@beta.gouv.fr>	2020-07-30 10:18:44 +02:00
Christophe Robillard	b940d2e1b0	update dossier after saving avis ... update last_avis_updated_at without hook Co-authored-by: clemkeirua <clement@keiruaprod.fr>	2020-07-30 10:18:44 +02:00
clemkeirua	f3a675c3bc	update dossier after saving commentaire ... update last_commentaire_updated_at without hook Co-authored-by: Christophe Robillard <christophe.robillard@beta.gouv.fr>	2020-07-30 10:18:44 +02:00
jpoulvel	62e04a6ca9	Merge branch 'dev' into new_design_edit_attestation	2020-07-30 09:53:09 +02:00
Kara Diaby	5894a86bd8	Merge pull request #5423 from betagouv/feat/5402 ... Feat/5402 - [Admin] new UI for procedures listing	2020-07-29 17:38:49 +02:00
clemkeirua	c404f92107	graphql: possibility to filter dossiers by archived	2020-07-29 16:59:34 +02:00
kara Diaby	d4c6e501c6	Ajoute la liste des démarches de l'interface administrateur sur la nouvelle UI	2020-07-29 15:35:52 +02:00
Judith	0075b508a3	adaptation of specs	2020-07-29 13:15:07 +02:00
Judith	b8a49e9012	creation of attachment_upload_helpers and integration in the code	2020-07-29 12:26:27 +02:00
Judith	5df3838173	- tranferred controllers from admin to mew_administrateur ... - removed admin/attestation_templates views - changed routes accordingly	2020-07-29 12:26:27 +02:00
Keirua	347dbe4c87	Merge pull request #5417 from betagouv/cleanup-incident-janvier ... Suppression du message d'alerte suite aux problèmes d'upload	2020-07-29 11:00:12 +02:00
Paul Chavard	1fca481c6e	Cleanup after clone	2020-07-28 17:04:06 +02:00
clemkeirua	de1df85462	suppression du message d'alerte suite aux problèmes d'upload	2020-07-27 10:32:03 +02:00
LeSim	7f22cc86a9	Merge pull request #5405 from betagouv/set-app-name-as-parameter ... Rendre le nom d'application paramètrable	2020-07-24 10:33:54 +02:00
clemkeirua	c91e231347	spec: replace reference to ds in password	2020-07-23 16:20:16 +02:00
Paul Chavard	bb5a90da76	fix active_revision_id -> active_revision.id	2020-07-23 15:07:25 +02:00
Paul Chavard	a08e318617	Add implicit_order_column on revisions	2020-07-22 12:25:06 +02:00
Paul Chavard	69ab2e44fb	Insert type_de_champ with correct initial position	2020-07-22 11:09:51 +02:00
Paul Chavard	58535c6a35	Add procedure revisions spec	2020-07-21 19:35:30 +02:00
Paul Chavard	0338080430	Remove unused procedure move type_de_champ code	2020-07-21 19:35:30 +02:00
Paul Chavard	d18a9c8162	Migrate procedures “on demand”	2020-07-21 19:35:30 +02:00
Paul Chavard	0a0912503b	Add type_de_champ mutation methods to revision	2020-07-21 19:35:30 +02:00
Keirua	f583b16f92	Merge pull request #5400 from betagouv/add-test-for-zip-download ... Ajout d'un test pour le telechargement de zips de dossier	2020-07-21 17:39:39 +02:00
Keirua	b2aa90b729	Merge pull request #5392 from betagouv/fix-CI-accessibility-errors ... Fix CI accessibility errors	2020-07-21 17:15:45 +02:00
Keirua	1a53bfed62	renommage des tests ... Co-authored-by: Pierre de La Morinerie <pierre.de_la_morinerie@beta.gouv.fr>	2020-07-21 17:13:28 +02:00
clemkeirua	d31b4b6848	ajout d'un test sur le telechargement de zips	2020-07-21 15:45:57 +02:00
krichtof	8c5308b9dc	Merge pull request #5396 from betagouv/5395-relancer-expert ... 5395 instructeur : relance un expert pour une demande d'avis	2020-07-21 15:02:53 +02:00
Christophe Robillard	169b8c9b3e	explicite revive meaning	2020-07-21 10:51:53 +02:00
Paul Chavard	86f562e7ea	Expose repetitions and options on champ_descriptors	2020-07-21 10:37:33 +02:00
Christophe Robillard	d9cb5c067f	relance un expert	2020-07-20 16:26:16 +02:00
clemkeirua	c0cf8b1341	fix display of labels for datetime on screenreaders	2020-07-20 11:37:01 +02:00
clemkeirua	bc34905742	fix heading order by removing useless h4	2020-07-20 11:36:55 +02:00
Christophe Robillard	52e8f32e19	expert can only revoke avis claimed by him/her	2020-07-16 21:07:20 +02:00
Christophe Robillard	3ea34834a7	revoke expert avis	2020-07-16 21:05:11 +02:00
Paul Chavard	b628169053	Remove unsused drop_down_list model	2020-07-16 15:29:01 +02:00
kara Diaby	9dc542af09	Revert "Revert "Feat/5287 - New design for admin procedure detail"" ... This reverts commit cf5eb3f251.	2020-07-15 17:00:03 +02:00
krichtof	0c924be222	Merge pull request #5374 from betagouv/3451-revoquer-invite ... usager: revoque un invité sur un dossier	2020-07-15 15:46:16 +02:00
clemkeirua	8a2aa13b74	remove pending tests	2020-07-15 09:27:23 +00:00
clemkeirua	299c86141c	added before_save to PieceJustificativeChamp in order to set skip_pj_validation	2020-07-15 09:00:12 +00:00
clemkeirua	c93d17bcaa	add rake task to update typedechamp	2020-07-15 09:00:12 +00:00
Christophe Robillard	8111babdd6	user: revoque un invité sur un dossier	2020-07-14 18:25:31 +02:00
Pierre de La Morinerie	e34f82a6fb	mailers: ignore more SMTP errors ... Although we already ignore "invalid recipient" errors, a new type of error recently popped: the mail service responds with > Net::SMTPServerBusy '400 unexpected recipients: want atleast 1, got 0' We want to also ignore this kind of errors.	2020-07-13 16:17:55 +02:00
Pierre de La Morinerie	7a67f1a802	jobs: ignore missing blob during virus scan ... We currently have many failed VirusScannerJob enqueued, because the underlying blob is missing. This PR fixes the issue by discarding the job in those cases (because if the blob is gone, the job is never going to succeed). The implementation is based on a similar issue encoutered by the ActiveStorage::AnalyzeJob. See 06f8baf73c	2020-07-13 14:35:41 +02:00
Pierre de La Morinerie	b82c269cef	specs: test de-serialization of job arguments ... When the job is invoked directly, the serialization and de-serialization of the job arguments is not actually tested. Using `perform_later` inside a `perform_enqueued_jobs` allows to exercise the serialization.	2020-07-13 14:31:28 +02:00
kara Diaby	ba6b89743c	put pending testsz	2020-07-13 12:24:48 +02:00
Kara Diaby	cf5eb3f251	Revert "Feat/5287 - New design for admin procedure detail"	2020-07-13 11:36:42 +02:00
Pierre de La Morinerie	c41afc425e	tasks: remove old after_party tasks ... Fixes a task that since became invalid: > NameError: uninitialized constant SeekAndDestroyExpiredDossiersJob > /lib/tasks/deployment/20191203142402_enable_seek_and_destroy_job	2020-07-09 18:18:09 +02:00
kara Diaby	7f3b38cfee	Merge admin dashboard to new design for procedure details	2020-07-09 12:18:22 +02:00
Paul Chavard	cb8cac395b	fix spec name	2020-07-08 19:28:17 +02:00
Paul Chavard	3b9e6dba25	Update spec/models/type_de_champ_shared_example.rb ... Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com>	2020-07-08 19:28:17 +02:00
Paul Chavard	84ff75ed6b	Update spec/models/type_de_champ_shared_example.rb ... Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com>	2020-07-08 19:28:17 +02:00
Paul Chavard	a92320e246	Update spec/models/type_de_champ_shared_example.rb ... Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com>	2020-07-08 19:28:17 +02:00
Paul Chavard	d8e864a7d9	Update spec/models/type_de_champ_shared_example.rb ... Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com>	2020-07-08 19:28:17 +02:00
Paul Chavard	660c95356b	Update spec/models/type_de_champ_shared_example.rb ... Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com>	2020-07-08 19:28:17 +02:00
Paul Chavard	a74e52c828	Call remove_drop_down_list on before_save	2020-07-08 19:25:05 +02:00
Paul Chavard	3c9cc6c070	Remove repetition types_de_champ on type_champ change	2020-07-08 19:25:05 +02:00
Christophe Robillard	2c56511204	validate api_entreprise_token	2020-07-08 18:59:22 +02:00
Christophe Robillard	7fd4d46e8e	remove empty spec file	2020-07-08 18:15:15 +02:00
Christophe Robillard	1253bb5994	store instructeur_email in traitement	2020-07-08 18:15:15 +02:00
Christophe Robillard	8f9d6d2871	show which instructeur took decision and when ... and also replace "sans suite" by "classé sans suite"	2020-07-08 18:15:15 +02:00
Christophe Robillard	cea170e4a6	update stats with traitement model	2020-07-08 18:15:15 +02:00
Christophe Robillard	0be4b50ade	update usual_traitement_time with traitement model	2020-07-08 18:15:15 +02:00
Christophe Robillard	a072d35211	use traitement model ... when a dossier is terminated (accepte, refuse or classe_sans_suite), we store now `processed_at` and `motivation` in a traitement instance	2020-07-08 18:15:15 +02:00
Christophe Robillard	f631acd118	update state date in aasm after callbacks ... call aasm event methods, not state methods directly	2020-07-08 18:15:15 +02:00
Pierre de La Morinerie	2f7fbc8474	specs: fix shared/attachement/_update.html.haml spec ... Avoid purging a non-saved file.	2020-07-07 18:03:56 +02:00
Pierre de La Morinerie	04a6862fa6	spec: fix application_controller_spec ... Rails controllers now looks for `media_type` rather than `content_type`.	2020-07-07 18:03:56 +02:00
Pierre de La Morinerie	0a3b4f7476	specs: fix some test helpers	2020-07-07 18:03:56 +02:00
Pierre de La Morinerie	2261c6c5d2	specs: refactor dossiers_controller_spec	2020-07-07 18:03:56 +02:00
Pierre de La Morinerie	b8706757e3	controllers: disable explicit purge of invalid file	2020-07-07 18:03:56 +02:00
Pierre de La Morinerie	719915e69f	attestations: fix test of the logo preview ... Now that attaching the logo doesn't save it, we can safely display the preview without saving the logo first.	2020-07-07 18:03:56 +02:00
Pierre de La Morinerie	35240e2219	lint: fix Rubocop warnings ... The Rails/UniqueValidationWithoutIndex rule is disabled for now, but we'll need to re-enable it (and fix the underlying issues) after the migration to Rails 6.	2020-07-07 18:03:56 +02:00
Paul Chavard	6cc76cdf05	WIP	2020-07-07 18:03:56 +02:00
Paul Chavard	04feada77e	Use respond_to	2020-07-07 18:03:56 +02:00
Paul Chavard	c9ab80c880	WIP	2020-07-07 18:03:56 +02:00
Paul Chavard	13c21d89af	Fix attestation_template spec	2020-07-07 18:03:56 +02:00
Paul Chavard	6a24c3f812	Rails app:update	2020-07-07 18:03:56 +02:00
Judith	9793128f61	'Services' routes moved under 'new_administrateur' scope and '/admn' added in their url	2020-07-07 14:08:01 +00:00
Judith	782706537d	Changed the routes to pass all new design admin pages under ... 'new_administrateur' scope, except 'services'. As a result, the url of these pages will all include '/admin'.	2020-07-07 14:08:01 +00:00
Pierre de La Morinerie	975d1648d5	dossier: fix PDF rendering of effectif_mensuel ... The effectif_mensuel was a number, it needs to be converted explicitely into a string. As a bonus, `nil.to_s` is `""`, so we can remove the special case for nil.	2020-07-06 11:41:25 +02:00
Pierre de La Morinerie	060bf1f9ca	factories: flesh out the default etablissement for a dossier	2020-07-06 11:41:25 +02:00
clemkeirua	ca74ae5a5e	ajout d'une bannière de dépréciation pour IE11	2020-07-06 10:01:02 +02:00
Myriam	0f542527fb	Instructeur : add overview table with counts for files ... - changement du design - tableau visible seulement si plus d'une procédure	2020-07-02 09:02:49 +00:00
Myriam	a486fe9a2e	Instructeur : add overview table with counts for files ... nombre total de dossier : - 'à suivre' - 'suivi' - 'traité' - 'dossier' - 'archivé'	2020-07-02 09:02:49 +00:00
bors[bot]	a37dd3c8cf	Merge #5318 ... 5318: specs: use `fixture_file_upload` rather than `Rack::Test::UploadedFile` r=Keirua a=kemenaran This is mostly for consistency (both styles were used before). Note: we still have to use `Rack::Test::UploadedFile.new` in factories, because of thoughtbot/factory_bot#385. Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com>	2020-07-01 11:54:51 +00:00
bors[bot]	b135b5cfb0	Merge #5316 ... 5316: fix missing aria-labels in footer r=Keirua a=Keirua début du cleanup des exclusions d'accessibilité (et bon candidat pour tester si bors fonctionne comme prévu) Co-authored-by: clemkeirua <clement@keiruaprod.fr>	2020-07-01 09:28:02 +00:00
Pierre de La Morinerie	43569f687e	specs: use fixture_file_upload rather than Rack::Test::UploadedFile ... This is mostly for consistency (both styles were used before). Note: we still have to use `Rack::Test::UploadedFile.new` in factories, because of https://github.com/thoughtbot/factory_bot/issues/385.	2020-07-01 11:13:45 +02:00
Christophe Robillard	cce1435faf	remove precision for currency	2020-07-01 09:28:18 +02:00
Christophe Robillard	1d86f863d3	rename avis#all to avis#index	2020-06-30 09:17:27 +02:00
Christophe Robillard	bbec76d33b	rename avis#index to avis#procedure	2020-06-30 09:17:27 +02:00
Christophe Robillard	63dd71aed4	display all avis for an expert	2020-06-30 09:17:27 +02:00
Christophe Robillard	29e2d3d7eb	display all avis for a procedure for an expert	2020-06-30 09:17:27 +02:00
Christophe Robillard	c565c9c87b	refactor sign_up_instructeur_avis_url	2020-06-30 09:17:27 +02:00
Christophe Robillard	b0aa005769	remove dead code	2020-06-30 09:17:27 +02:00
Christophe Robillard	4839506374	refactor instructeur_avis_url	2020-06-30 09:17:27 +02:00
Christophe Robillard	b0cfb2c02a	refactor messagerie_instructeur_avis_url	2020-06-30 09:17:27 +02:00
Christophe Robillard	83fba55b29	refactor instruction_instructeur_avis_url	2020-06-30 09:17:27 +02:00
Christophe Robillard	72d27ffdb2	replace instructeur_avis_index url by instructeur_all_avis url	2020-06-30 09:17:27 +02:00
Christophe Robillard	dcb9afaf25	refactor expert avis url : fix avis_controller_spec	2020-06-30 09:17:27 +02:00
Christophe Robillard	3e1afa8bf9	fix avis spec	2020-06-30 09:17:27 +02:00
clemkeirua	1072bacb12	fix missing aria-labels in footer	2020-06-29 15:31:14 +02:00
kara Diaby	6b07cc0659	Move admin/assigns to the new UI like groupe_instructeurs	2020-06-29 14:44:28 +02:00
clemkeirua	f7d957e59a	rename 'Menu déroulant' in specs	2020-06-29 08:59:12 +00:00
clemkeirua	031f59c9e1	add wcag accessibility tests for usager pages using axe-core	2020-06-26 17:10:26 +02:00
Paul Chavard	210389d0f8	Remove admin creation notification email	2020-06-25 16:29:06 +02:00
Paul Chavard	97f91513c8	Store drop_down_list values as jsonb	2020-06-25 13:14:17 +02:00
Pierre de La Morinerie	acc1cb1abd	dossier: export PJs from private champs ... Fix #5297	2020-06-24 15:42:30 +02:00
Pierre de La Morinerie	b83a76a0a1	dossier: refactor piece_justificative specs ... Use `eq` rather than `be` for integers.	2020-06-24 15:42:30 +02:00
clemkeirua	465449e684	fix unit tests	2020-06-24 12:18:56 +02:00
Christophe Robillard	954d41ce4e	fetch effectifs mensuels for may month	2020-06-24 10:23:00 +02:00
Pierre de La Morinerie	af5b36ea6a	helpers: prevent some texts to be incorrectly detected as links ... Users were having issues with texts like: > Pour info: penser à faire cette action. where `info:` was detected as being an URI.	2020-06-22 14:42:41 +02:00
simon lehericey	fecad19b91	add maintenance mode	2020-06-22 11:17:22 +02:00
jpoulvel	adaf0753b0	Merge branch 'dev' into instruct-filter-yes-no	2020-06-16 14:53:22 +02:00
Paul Chavard	c4896b45ad	Prepare to remove dossier procedure_id	2020-06-11 16:13:44 +02:00
Christophe Robillard	8df9ae3a8d	ask only effectifs for april	2020-06-10 17:41:13 +02:00
Judith	9be58aa012	only downcasing search values for yes_no type_de_champs	2020-06-10 15:55:25 +02:00
Judith	ad53dfa84d	Instructeurs: Changed the filters from 'true/false' to 'oui/non' for yes_no type_de_champ	2020-06-10 15:50:41 +02:00
Paul Chavard	d099314e56	Add decription to geo_area	2020-06-09 18:45:45 +02:00
Christophe Robillard	2fd88e3a17	affiche uniquement l'année pour les bilans	2020-06-09 17:06:08 +02:00
Christophe Robillard	81fa1d0e89	utilise un ordre plus logique pour identite entreprise ... homogenise l'affichage des valeurs monétaires elargit la colonne libellé	2020-06-09 16:59:57 +02:00
Paul Chavard	901b6e23a8	Remove legacy carto	2020-06-04 16:03:23 +02:00
Christophe Robillard	cf9d6ccf34	export bilans in ods and xlsx	2020-06-04 15:31:16 +02:00
Christophe Robillard	75a268aed6	show some info from bilans	2020-06-04 12:33:33 +02:00
Christophe Robillard	d06867822b	reorder bilans bdf csv	2020-06-03 15:45:11 +02:00
Judith	d930124839	change procedure_auto_archive helper name and added a helper for 23 h 59	2020-05-28 13:22:02 +00:00
Judith	6b65ee8d15	mailers: display auto-archive date in notifications	2020-05-28 13:22:02 +00:00
Judith	38eb60f2ac	views: display auto-archive date on procedure description	2020-05-28 13:22:02 +00:00
Judith	59346ee868	mailers: mention the auto_archive in notify_new_draft	2020-05-28 13:22:02 +00:00
Paul Chavard	20705d6e30	Do not send draft norifications to users on inactive démarches	2020-05-27 16:36:46 +02:00
Christophe Robillard	fb87a09c02	doesn't update dossier etablissement for siret controller	2020-05-26 18:13:20 +02:00
Pierre de La Morinerie	2f509c2536	specs: remove unused test case ... Actual code was removed in 0ff6c793ae The spec was never executed, because it lacked the `_spec.rb` suffix.	2020-05-20 17:45:06 +02:00
Christophe Robillard	d92a0ba8f3	raise BadFormatRequest error ... L'intention est de distinguer ce type d'erreur avec les erreurs serveur 5xx. Lorsque l'api est appelé par un Job, les erreurs serveur seront retry, car éphémères. Alors que les erreurs de type BadFormatRequest ou ResourceNotFound n'ont pas être retried.	2020-05-20 11:09:54 +02:00
Christophe Robillard	f40123fee1	display only etablissement infos ... all the other infos are not yet available because the jobs which retrieve it are performed later	2020-05-20 11:09:54 +02:00
Christophe Robillard	013e78ce4e	fix creating dossier feature sprec	2020-05-20 11:09:54 +02:00
Christophe Robillard	637bde7326	update siret_controller when finding etablissement ... now, `ApiEntrepriseService` does'nt return a hash anymore but an etablissement which is already persisted.	2020-05-20 11:09:54 +02:00
Christophe Robillard	eebfb5ee5b	update dossiers_controller when updating siret ... now, `ApiEntrepriseService` does'nt return a hash anymore but an etablissement which is already persisted.	2020-05-20 11:09:54 +02:00
Christophe Robillard	ba5fa9aa4b	update ApiEntrepriseService ... There is now the `create_etablissement` method which create etablissement with EtablissementAdapter and enqueue api_entreprise jobs to retrieve all informations we can get based on SIRET	2020-05-20 11:09:54 +02:00
Christophe Robillard	f4ebb5d107	create api_entreprise jobs	2020-05-20 11:09:54 +02:00
Christophe Robillard	e3ee423197	call api_entreprise adapters with siret	2020-05-20 11:09:54 +02:00
Pierre de La Morinerie	9f1407b6d7	expiration: fix the mailer arguments ... The mailers expect serializable arguments, but were given ActiveRecord::Relation objects instead. This made the mailers throw an exception. But how was that possible ? This code is tested, and the tests were green. Well, the specs spy on the mailer implementation, in order to check that the mailers methods were properly called. Fair enough. But if the specs mock the mailer code (instead of calling the original implementation), we may not notice that the original implementation rejects our method parameters. Here this is the case: once we actually call the original implementation the tests start to fail, because some arguments are not converted from an ActiveRecord::Relation to a serializable array. This is fixed by ensuring that the mailer code is executed (and doesn't throw an exception).	2020-05-18 16:24:08 +02:00
Pierre de La Morinerie	b63fa0e6b8	dossier: remove "Birthdate" column from export	2020-05-18 13:14:28 +00:00
Pierre de La Morinerie	00adb006b4	specs: improve ProcedureExportService spec	2020-05-18 13:14:28 +00:00
clemkeirua	77101208a4	Anonymisation de l'instructeur dans la messagerie	2020-05-18 12:56:30 +00:00
Pierre de La Morinerie	93bb5283ff	app: remove the feature flag for pieces justificatives auto-upload ... The feature works as intended: we can remove the feature flag.	2020-05-14 17:39:07 +02:00
Pierre de La Morinerie	190548844a	dossiers: add piece justificative filename to spreadsheet export	2020-05-14 10:18:10 +00:00
Paul Chavard	f0148184ca	Remove legacy carto code	2020-05-13 12:17:04 +02:00
Pierre de La Morinerie	51cb3a04a3	app: fix JS redirection with Turbolinks disabled ... When Turbolinks is enabled, a `redirect_to` in a `format: :js` request will emit code that instructs Turbolinks to navigate to the page. Turbolinks will then load the redirection target as HTML, and display it. But with Turbolinks disabled, the same `redirect_to` will instead respond with a standard `302: redirect`. `Rails.ajax` will interpret this redirect as "Please perform the same call again to the redirected URL, in the same format" – and request our redirection target, but using `format: :js`. This breaks the "Publish procedure" button. In that case, we really want the page to be navigated to. Add an explicit JS redirect, so that the redirection occurs in HTML.	2020-05-13 11:04:16 +02:00
Pierre de La Morinerie	b5f1d97629	app: disable Turbolinks ... Fix #5039	2020-05-13 11:04:16 +02:00
Paul Chavard	dfc004d7bb	Unarchive dossier when repasser_en_instruction	2020-05-12 19:05:18 +02:00
Christophe Robillard	aab4bb81ee	return bilan bdf csv for expert	2020-05-11 13:05:50 +02:00
kara Diaby	1cc04092f4	import GPX file in browser [Carto]	2020-05-11 11:36:36 +02:00
Paul Chavard	4f2e504cc2	Add carto import api ... takes a FeatureCollection to import and returns an augmented champ FeatureCollection	2020-05-07 12:06:42 +02:00
clemkeirua	36f381a743	fix flacky test	2020-05-07 10:23:28 +02:00
Paul Chavard	05e408225b	Implement atomic operations on MapEditor	2020-05-06 16:46:14 +02:00
Christophe Robillard	dba77ec0b8	fix spec with not expired token ... and use of `ApiEntrepriseToken#roles`	2020-05-06 10:57:45 +02:00
Christophe Robillard	dbf04dd0d8	make api entreprise call only if token not expired	2020-05-06 10:57:45 +02:00
Christophe Robillard	f587e6600a	extract class ApiEntrepriseToken ... and check if token is expired	2020-05-06 10:57:45 +02:00
Paul Chavard	6556df2a85	Fix a crash in case of invalid geometry	2020-05-05 15:56:05 +02:00
Paul Chavard	4299c9dbea	Use a “safe” reference date in expiration tests	2020-05-05 12:41:45 +02:00
Christophe Robillard	9de2c7c85a	improve csv generation for bilans bdf	2020-04-30 16:15:16 +02:00
Christophe Robillard	b12226c667	fetch and store bilans bdf	2020-04-30 16:15:16 +02:00
Christophe Robillard	85b2e9ef44	create bilans_bdf_adapter	2020-04-30 16:15:16 +02:00
Paul Chavard	843e033c38	Allow instructeurs to download a GeoJSON document for a given dossier	2020-04-30 15:49:43 +02:00
Christophe Robillard	3ddb5a4cb4	store attestation fiscale and display	2020-04-30 11:39:54 +02:00
Christophe Robillard	38c68b16e3	create attestation_fiscale_adapter	2020-04-30 11:39:54 +02:00
Paul Chavard	b516cbc179	Enable republish on démarches dépubliée	2020-04-29 18:04:35 +02:00
Christophe Robillard	ddd3e6bb02	don't copy api_entreprise_token when cloning ... except for an admin who owns the parent procedure	2020-04-29 17:17:20 +02:00
Christophe Robillard	158b4802ab	store attestation sociale and display	2020-04-29 16:25:47 +02:00
Christophe Robillard	d74b14c205	fetch attestation sociale url	2020-04-29 14:25:55 +02:00
Christophe Robillard	b147956a92	create attestation_sociale_adapter	2020-04-29 14:01:48 +02:00
Christophe Robillard	4bd4524f67	fix api_entreprise specs	2020-04-28 15:17:11 +02:00
Christophe Robillard	e29af48420	call api_entreprise with specific token if exist	2020-04-28 15:17:11 +02:00
Christophe Robillard	14ff18ca80	store specific api-entreprise token for a procedure	2020-04-28 15:17:11 +02:00
clemkeirua	1ac7ec2dca	precision dans mail suppression dossier en construction	2020-04-28 12:42:00 +00:00
Christophe Robillard	339066778d	send notif only to the right instructeurs ... after a dossier creation, only the instructeurs that belong to the group instructeur of the dossier, and who want notif will be notified by mail	2020-04-23 13:01:57 +02:00
Paul Chavard	9cb612bb3d	Show area and length on champ carto selections utilisateur	2020-04-23 10:21:18 +02:00
Christophe Robillard	792e755af9	expose effectif_annuel dans api graphql	2020-04-23 09:53:27 +02:00
Christophe Robillard	453adf3c74	instructeurs: affiche l'effectif moyen annuel n-1	2020-04-23 09:53:27 +02:00
Pierre de La Morinerie	32ad152347	specs: ensure that discarded procedures are not shown	2020-04-22 19:01:26 +02:00
Pierre de La Morinerie	abe692ecc2	specs: refactor instructeur procedures controller specs	2020-04-22 19:01:16 +02:00
Paul Chavard	31943f7d9c	Add handeling of expired processed dossiers to deletion service	2020-04-22 15:39:10 +02:00
Paul Chavard	f1b531911b	Handle processed dossiers in deletion mailers	2020-04-22 15:39:10 +02:00
Pierre de La Morinerie	f29ec5c775	instucteurs: don't show discarded procedures in the list	2020-04-22 15:16:21 +02:00
Pierre de La Morinerie	15645e11e3	instructeur: improve InstructeurController#index test	2020-04-22 15:12:34 +02:00
Pierre de La Morinerie	1cb18e51ac	champ: return the parent dossier even when discarded ... Dossier has a `default_scope { kept }`. Because of that, when the parent dossier is discarded, `champ.dossier` will return nil. We should kill the default scope. But meanwhile, ensure that `champ.dossier` returns even a discarded dossier.	2020-04-22 11:46:42 +02:00
Christophe Robillard	149b98007f	add effectif mensuel to graphql api	2020-04-21 21:13:07 +02:00
Christophe Robillard	1165f8483d	rename effectif columns	2020-04-21 21:13:07 +02:00
Christophe Robillard	db3ef195ad	fetch and show effectif mensuel ... - fetch and store effectif mensuel (at the creation of the dossier or when updating a siret field - show effectif mensuel only for instructeurs	2020-04-21 14:22:11 +02:00
Christophe Robillard	599d8e33e8	create ApiEntreprise::EffectifsAdapter	2020-04-21 14:22:11 +02:00
clemkeirua	2d68d7dc59	fix to_tsquery disallowed chars	2020-04-20 15:15:22 +02:00
Paul Chavard	e512870fd2	Cleanup procedure duree_conservation_dossiers_dans_ds validations	2020-04-16 19:40:19 +02:00
Paul Chavard	bc8217e030	Carte Editor sends FeatureCollection to the server	2020-04-16 18:29:19 +02:00
Paul Chavard	22604013d0	Expose multiple user selections on champ carte	2020-04-15 18:07:09 +02:00
Paul Chavard	52d2ace823	Remove quartiers prioritaires	2020-04-14 10:29:59 +02:00
clemkeirua	8c2f589cbf	fix admin deletion of empty service with archived procedures	2020-04-10 20:01:40 +02:00
clemkeirua	7335500be4	tests for dossier_helper#demandeur_dossier	2020-04-10 13:14:39 +02:00
Christophe Robillard	f683b850c3	Notifie instructeurs le souhaitant lors depot dossier ... Notifie par mail uniquement les instructeurs qui le souhaitent à chaque dépôt de dossier	2020-04-09 15:02:05 +02:00
Christophe Robillard	ae18ff6627	Notifie tous les instructeurs lors dépôt dossier ... - envoie un mail à tous les instructeurs d'une procédure après le dépôt d'un nouveau dossier	2020-04-09 14:33:56 +02:00
Christophe Robillard	969478b706	Envoie une notif aux followers_instructeurs le souhaitant ... après chaque message déposé par l'usager	2020-04-09 14:17:07 +02:00
Christophe Robillard	415d5c765e	envoie une notification à chaque follower_instructeur après un commentaire déposé	2020-04-09 14:17:07 +02:00
Paul Chavard	61eaca928f	remove WarnExpiringDossiersJob	2020-04-09 11:11:51 +02:00
Pierre de La Morinerie	7ff381b6f0	attachments: remove the buggy fallback ... The fallback would fail on non-champ attachments.	2020-04-09 10:40:08 +02:00
Pierre de La Morinerie	7e19dd2cda	Revert "Revert "Fix middle-click on "Delete attachment" button"" ... This reverts commit 6e8bd6957f.	2020-04-09 10:40:08 +02:00
clemkeirua	590cee050f	add tests for dossier_search_service	2020-04-09 09:42:31 +02:00
clemkeirua	46e14f4033	add test for users/list_dossiers_spec	2020-04-09 09:42:31 +02:00
clemkeirua	8ff3d9ea47	update existing tests	2020-04-09 09:42:31 +02:00
Paul Chavard	32f783142c	[GraphQL] allow to query dossiers by groupe instructeur	2020-04-09 09:29:28 +02:00
Pierre de La Morinerie	6e8bd6957f	Revert "Fix middle-click on "Delete attachment" button"	2020-04-08 17:40:58 +02:00
Pierre de La Morinerie	b748e9773f	attachments: fix opening the delete link directly ... When cliking on the "Delete attachment" link, and opening the URL in a new tab, the `DELETE /attachements/:id` will become `GET /attachments/:id` – which will cause the `show` action to be routed with an html format (instead of JS). In that case, we don't want to throw an error at the user face. Instead simply re-render the dossier page (if any). Fix a long-standing error in Sentry.	2020-04-08 13:40:32 +02:00
Pierre de La Morinerie	0077ff4b75	attachments: refactor the controller specs	2020-04-08 12:05:55 +02:00
clemkeirua	ed45c88bdf	do not clone groups instructeurs for admin outside the procedure	2020-04-07 09:25:40 +02:00
pedong	7806a26e2c	copy groupe_instructeurs when clone	2020-04-07 09:22:33 +02:00
Christophe Robillard	dc31f41c26	fix tests for procedure_presentation	2020-04-06 17:39:51 +02:00
Christophe Robillard	5b6044803b	forbid to create champ with same type_de_champ and same row	2020-04-06 17:39:51 +02:00
Paul Chavard	ca6c97bf0f	Refactor expired dossiers deletion service	2020-04-02 15:24:02 +02:00
Pierre de La Morinerie	059e11601b	policies: fix champ policy for guest users	2020-04-02 11:27:14 +02:00
Pierre de La Morinerie	ac922c456e	policies: refactor champ_policy_spec ... Creating champs without attaching them to a procedure works only by chance.	2020-04-02 11:27:13 +02:00
Paul Chavard	c0bbfa42b7	Reassign discarded dossiers on group_instructeur ... fix #4851	2020-04-01 18:10:12 +02:00
Paul Chavard	7ba4c513e6	Refactor notify near deletion mailers	2020-04-01 17:40:52 +02:00
Paul Chavard	288ace2f34	Dossier on discarded procedure should have access to discarded procedure	2020-03-31 17:08:29 +02:00
Paul Chavard	bd81970f67	DeletedDossier should have access to discarded demarche	2020-03-31 17:08:29 +02:00
Paul Chavard	e4ab2574ce	Démarches discarded by administrateur can be reactivated in manager	2020-03-31 17:08:28 +02:00
Paul Chavard	58c126308c	Add DiscardedProceduresDeletionJob job	2020-03-31 17:08:28 +02:00
Paul Chavard	da52ec30bd	Undo discard dossiers and demarches from manager	2020-03-31 17:08:28 +02:00
Paul Chavard	876e05aed3	Discard demarches from manager	2020-03-31 17:08:28 +02:00
Paul Chavard	60cb9bcf09	Remove brouillons deleted dossiers	2020-03-31 16:54:33 +02:00
Pierre de La Morinerie	6417c0d2c0	dossiers: allow auto upload of attachments	2020-03-31 13:09:44 +02:00
Pierre de La Morinerie	7a27e78452	specs: remove unused wait-for-ajax helper ... This helper is: - no longer used; - buggy (not all requests increment it); - discouraged (we should instead match an UI change that signals the end of an ajax request). Good riddance.	2020-03-31 12:54:49 +02:00
Pierre de La Morinerie	cae256fd28	rspec: allow Rails to auto-migrate the test schema ... rails_helper already has `ActiveRecord::Migration.maintain_test_schema!` which automatically updates the test database if needed. However, if we raise **before** `maintain_test_schema` had the chance to do its job, the test database is never-automigrated. Thus by removing the check, we ensure the test database will be migrated as needed (and still an error will be raised if the schema cannot be applied).	2020-03-31 12:48:32 +02:00
Pierre de La Morinerie	4cb747fdb6	specs: always require rails_helper ... Test helpers are separated between two files: spec_helper and rails_helper. This separation is meant to allow tests that do not require Rails (like testing standalone libs) to boot faster. The spec_helper file is always loaded, through `--require spec_helper` in the `.rspec` config file. When needed, the rails_helper file is expected to be required manually. This is fine, but: - Many test files have a redundant `require 'spec_helper'` line; - Many test files should require `rails_helper`, but don't. Not requiring `rails_helper` will cause the Rails-concerned section of the test environment not to be configured–which may cause subtle bugs (like the test database not being properly initialized). Moreover, Spring loads all the Rails files on preloading anyway. So the gains from using only `spec_helper` are thin. To streamline this process, this commit: - Configures `.rspec` to require `rails_helper` by default; - Remove all manual requires to spec_helper or rails_helper. Reference: https://stackoverflow.com/questions/24145329/how-is-spec-rails-helper-rb-different-from-spec-spec-helper-rb-do-i-need-it	2020-03-31 12:48:32 +02:00
Paul Chavard	742cc15209	Use base CronJob	2020-03-31 12:25:46 +02:00
Paul Chavard	33bf2fe109	remove deprecated AutoReceiveDossiersForProcedureJob	2020-03-31 12:25:46 +02:00
Paul Chavard	c40d689edf	Use bigger deltas to allow for month length variations	2020-03-31 11:50:59 +02:00
Pierre de La Morinerie	ed5f2fa35f	attestation: fix preview of logos ... Turns out that assigning the params to the procedure calls `read` on the images files. Calling `read` moves the seek offset to the end of the file; which means that subsequent calls to `read` return an empty string. Fix the issue by calling `rewind` before attempting to `read` the file, to ensure the seek offset is at the beginning of the file. Fix #4958	2020-03-30 14:58:50 +02:00
Pierre de La Morinerie	b8c3d7c6bd	attestation: ensure the PDF is rendered successfully	2020-03-30 14:58:50 +02:00
Pierre de La Morinerie	fe13043efd	dossier: prepare validations to piece_justificative champs ... We can't yet enable the validations, because of an issue that will (hopefully) be solved with Rails 6. See https://github.com/betagouv/demarches-simplifiees.fr/issues/4926	2020-03-30 11:12:25 +02:00
Pierre de La Morinerie	245ef2befd	specs: fix an Rspec warning	2020-03-30 11:12:25 +02:00
Paul Chavard	a60b6b6776	Use ’ consistently instead of '	2020-03-26 17:27:48 +01:00
Paul Chavard	c763679b54	Remove non-existant columns from manager dashboards	2020-03-26 16:17:07 +01:00
Paul Chavard	c707a21f97	Rename delete_and_keep_track -> discard_and_keep_track	2020-03-26 14:23:23 +01:00
Paul Chavard	c086f6d580	Add a job to remove discarded dossiers	2020-03-25 17:28:25 +01:00
Paul Chavard	5b5ae5a7a5	Do not send notifications or create operation logs on brouillon demarches	2020-03-25 15:04:52 +01:00
Pierre de La Morinerie	f895570b00	dossier: make the upload label a real label	2020-03-25 14:43:09 +01:00
clemkeirua	a34b45e4f4	make the 'male' field selected by default during identity creation	2020-03-25 09:50:41 +00:00
Christophe Robillard	b4b92accf1	instructeur: show deleted dossiers for a procedure	2020-03-25 10:19:07 +01:00
maatinito	1af32b29fd	#4807 Use now() instead of Date.time.today (better code homogeneity)	2020-03-24 17:09:14 -10:00
maatinito	f5c2dc03c5	#4807 better method/variable naming	2020-03-24 16:46:23 -10:00
Christian Lautier	e61c53f267	Fix #4807 48h before closing a procedure, notify users their draft is not submitted	2020-03-24 16:46:23 -10:00
clemkeirua	e76870844e	update test for dossier#en_construction_close_to_expiration ... It now takes into account en_construction_conservation_extension	2020-03-24 18:10:51 +01:00
clemkeirua	d49f6e703e	fix tests for datetime	2020-03-24 16:54:35 +00:00
Paul Chavard	5c2eba1dd1	Always add a reason to dossier deletion	2020-03-24 09:30:11 +01:00
Paul Chavard	903cf0cef5	Keep operation logs after dossier removal	2020-03-24 09:18:45 +01:00
kara Diaby	1f27652cd3	add files validations to models	2020-03-23 11:28:13 +01:00
Christophe Robillard	884de51b94	Revert "Revert "go to procedure after cliking link"" ... This reverts commit 952bae32fe.	2020-03-20 10:41:36 +01:00
Pierre de La Morinerie	1b4a218b0e	specs: remove useless chrome argument ... The `options.add_argument('--headless')` above is sufficient.	2020-03-19 17:47:33 +01:00
Paul Chavard	cd0acb1344	Cleanup dossier mailers	2020-03-19 16:52:18 +01:00
simon lehericey	3e7cef63c6	add mailer preview	2020-03-18 15:25:02 +01:00
simon lehericey	3dd4ea26c7	add similar tests for send_brouillon_expiration_notices and delete_expired_brouillon_and_notify	2020-03-18 15:25:02 +01:00
simon lehericey	3f6012bff5	Delete complicated test	2020-03-18 15:25:02 +01:00
simon lehericey	74db7ab146	test for #send_en_construction_expiration_notices	2020-03-18 15:25:02 +01:00
simon lehericey	f35c0518b7	test for #delete_expired_en_construction_and_notify	2020-03-18 15:25:02 +01:00
simon lehericey	043847ae6e	change notify_automatic_deletion_to_administration signature	2020-03-18 15:25:02 +01:00
Paul Chavard	fe1cd2a47b	Delete and notify en_construction dossiers	2020-03-18 15:25:02 +01:00
Paul Chavard	77018b9e2b	Add expiration scopes to dossier	2020-03-18 15:25:02 +01:00
Paul Chavard	f35ccc9d92	Move process_expired_dossiers_brouillon to a service	2020-03-18 15:25:02 +01:00
Christophe Robillard	952bae32fe	Revert "go to procedure after cliking link" ... This reverts commit 795eabb1ea.	2020-03-18 14:45:39 +01:00
Christophe Robillard	795eabb1ea	go to procedure after cliking link ... even for an instructeur which is not signed in and unstrusted	2020-03-18 11:16:19 +01:00
Christophe Robillard	8e7f210216	affiche infos entreprise uniquement si diffusable ... le champ de type siret affiche les infos d'une entreprise dont les infos sont diffusables uniquement aux instructeurs	2020-03-17 15:57:02 +00:00
Christophe Robillard	c21dd3b830	affiche infos d'un usager entreprise uniquement si diffusable ... pour un usager de type entreprise qui a choisi de ne pas diffuser publiquement ses infos, elles sont affichées uniquement aux instructeurs	2020-03-17 15:57:02 +00:00
Christophe Robillard	91abcd7792	récupère les infos d'établissement avec infos non diffusables	2020-03-17 15:57:02 +00:00
kara Diaby	395af2fbb0	instructors : receive daily emails for declarative folders	2020-03-17 15:54:50 +01:00
Paul Chavard	3cd4597006	Update rubocop roules	2020-03-17 11:25:21 +01:00
Paul Chavard	c281347da1	Remove restclient	2020-03-17 11:12:14 +01:00
Christophe Robillard	d8d9b0922d	remove orphan services when destroying admin	2020-03-16 21:40:05 +01:00
Paul Chavard	e540dea929	Fix administrate pagination by pinning to an old version of kaminari	2020-03-05 14:01:09 +01:00
pedong	62f82cc83c	add dossierChangerGroupeInstructeur mutation	2020-03-05 12:28:16 +01:00
Christophe Robillard	b5030b8972	highlight demandes when groupe instructeur updated on procedure list	2020-03-04 14:56:59 +01:00
Christophe Robillard	50007b2aac	highlight demande tab when groupe instructeur updated	2020-03-04 14:56:59 +01:00
Christophe Robillard	924702699f	highlight routing criteria label when updated	2020-03-04 14:56:59 +01:00
kara Diaby	b32ed88f9b	add attachment when instructor asking for a review	2020-03-04 13:35:29 +00:00
Christophe Robillard	e8bef76772	fix test for procedure presentation	2020-03-03 18:07:50 +01:00
Paul Chavard	c46e012c10	Use dossier.assign_to_groupe_instructeur	2020-03-03 10:30:49 +01:00
Paul Chavard	1ed1aa75cd	[GraphQL] add groupeInstructeur on dossier	2020-03-03 10:23:18 +01:00
kara Diaby	4a70a7fcc8	remove email_notifications_enabled column because of the new daily_email_notifications_enabled	2020-02-27 11:09:19 +01:00
Christophe Robillard	2bd6f01009	log changer_groupe_instructeur	2020-02-26 11:25:07 +01:00
Christophe Robillard	e0f4957dfd	notify instructeur after groupe_instructeur changed	2020-02-26 11:25:07 +01:00
Christophe Robillard	fb3d7e45ba	unfollow stale instructeurs ... when the group instructeur of a dossier is changed, unfollow the instructeurs who don't belong to the new groupe instructeur	2020-02-26 11:25:07 +01:00
kara Diaby	6102ba6039	Do not permit to upload a GIF file via javascript	2020-02-25 23:33:15 +01:00
Paul Chavard	24d237de9e	A cloned procedure should not have canonical relationship	2020-02-25 15:26:43 +01:00
Pierre de La Morinerie	6664965961	mailers: add procedure context to the confirmation link ... This allows to redirect the user to the procedure they signed up for even when the browser session is not available (like if they changed of browser). Fix #4738	2020-02-25 11:45:36 +00:00
Pierre de La Morinerie	10c940c188	specs: small cosmetic cleanups in sign-up specs	2020-02-25 11:45:36 +00:00
Pierre de La Morinerie	dcc81d42dd	specs: ensure the procedure-less sign-up is tested	2020-02-25 11:45:36 +00:00
Paul Chavard	be66a8986c	Activate champ integer number on all the new procedures	2020-02-25 11:26:37 +01:00
clemkeirua	4343bb3918	Revert "openly fail when not delivering mail" ... This reverts commit 415cc2c2f1.	2020-02-20 15:31:43 +00:00
clemkeirua	48d2093577	tag 'groupe instructeur' uniquement si la procedure est routee	2020-02-20 14:48:14 +00:00
clemkeirua	059d80ea34	#4785 ajout d'une balise 'groupe instructeur'	2020-02-20 14:48:14 +00:00
Paul Chavard	b7051da278	Remove old export code	2020-02-19 18:19:17 +01:00
Christophe Robillard	bb61500f9b	recherche un administrateur par email dans manager	2020-02-19 15:17:36 +01:00
Christophe Robillard	ba3d2f1b9f	refactor	2020-02-19 15:17:36 +01:00
Christophe Robillard	32d1ebe565	add administrateur from manager	2020-02-19 15:17:36 +01:00
Paul Chavard	e931c0800d	Remove notify_unhide_to_user and notify_undelete_to_user mailers	2020-02-18 17:56:52 +01:00
Paul Chavard	318baf316e	Add notify_en_construction_near_deletion mailer	2020-02-18 17:18:14 +01:00
Paul Chavard	8c77d91e9f	Add notify_automatic_deletion_to_administration mailer	2020-02-18 17:18:06 +01:00
Paul Chavard	4e116f06a6	Add notify_automatic_deletion_to_user mailer	2020-02-18 17:15:32 +01:00
Pierre de La Morinerie	6afddd8647	spec: fix a flaky experts feature spec ... When "invite linked dossiers" is checked, the invitation will generate one avis per dossier (including the linked ones). So when we retrieve the email send to the expert, and try to match it with the avis record, we need to specify wich avis (the one for the main dossier, or for the linked dossier). Otherwise the test is flaky, and sometimes doesn't match the right avis with the sent email.	2020-02-18 10:44:44 +00:00
Pierre de La Morinerie	d6a9318d05	champ: fix siblings for repetition champs ... Fix a crash when requesting the `section_index` of a section header in a repetition champ.	2020-02-17 17:11:17 +01:00
Paul Chavard	1ce1c1e6d0	use discard	2020-02-13 12:31:59 +01:00
Paul Chavard	a3cf7fce3a	Remove old (< 2019) migration tasks	2020-02-13 11:42:11 +01:00
Pierre de La Morinerie	f8ed7ec051	form: display index of section in header	2020-02-13 11:18:46 +01:00
Pierre de La Morinerie	a8444927ab	specs: fix the sign-up with unconfirmed account test ... It was testing the sign-in instead of the sign-up.	2020-02-12 13:24:52 +00:00
Pierre de La Morinerie	e746d90016	mailers: add a link to the procedure when the account already exists	2020-02-12 13:24:52 +00:00
kara Diaby	0b8a59d5e9	Add the possibility to disable weekly email notifications (instructeur) && rename the column email_notifications_enabled to daily_email_notification_enabled	2020-02-12 13:02:31 +00:00
Pierre de La Morinerie	e3ba2ed96c	Revert "form: add number to section headers" ... This reverts commit f42977e40a.	2020-02-12 13:54:44 +01:00
Pierre de La Morinerie	3e1ba4eebc	specs: fix test failing because of unspecified types_de_champ order	2020-02-12 13:26:54 +01:00
Pierre de La Morinerie	d4574bade1	dossier: add a custom message for the dossier owner	2020-02-12 11:49:33 +01:00
Pierre de La Morinerie	7ba76c6658	dossier: add a notice when some attachments of the dossier were lost ... On the 22/01/2020, a technical error on the demarches-simplifees.fr instance made us delete some files attached to some dossiers. This PR adds a warning when browsing a dossier containing attachments that were deleted.	2020-02-12 11:49:33 +01:00
Paul Chavard	7afeae1408	remove dossier.linked_dossiers	2020-02-11 17:49:22 +01:00
Pierre de La Morinerie	5d0a8b567f	specs: improve description of Avis creation test cases	2020-02-11 17:38:58 +01:00
Paul Chavard	f0ea96772d	Only invite experts to dossiers instructeur have access to	2020-02-11 17:38:57 +01:00
Pierre de La Morinerie	f42977e40a	form: add number to section headers	2020-02-11 17:36:50 +01:00
Pierre de La Morinerie	2532091302	form: improve wording of repetition blocks controls	2020-02-11 17:36:50 +01:00
simon lehericey	4f317e84d1	Iterate over type_de_champ in repetition type_de_champ	2020-02-11 13:35:55 +00:00
Pierre de La Morinerie	52ea019ba9	app: replace remaining references of DINSIC by DINUM ... Fix #4488	2020-02-10 17:46:20 +00:00
Christophe Robillard	967e5e910f	test pending demandes	2020-02-10 14:59:03 +01:00
clemkeirua	415cc2c2f1	openly fail when not delivering mail	2020-02-05 10:46:01 +01:00
Christophe Robillard	cef776ff9e	admin: fix add administrateur to a procedure	2020-02-04 16:21:42 +01:00
Christophe Robillard	ed970d3f3c	admin: create without providing email	2020-02-04 16:21:42 +01:00
Christophe Robillard	055918aabc	admin: replace calls to Administrateur.find_by(email: ...)	2020-02-04 16:21:42 +01:00
Christophe Robillard	c137917396	fix typo	2020-02-04 16:07:01 +01:00
Christophe Robillard	5a46effcbc	remove useless condition to admin that can be deleted ... administrateur can be deleted only if he/she has a procedure where he/she is the only admin	2020-02-04 16:07:01 +01:00
Christophe Robillard	4bf020cb96	rend le test plus élégant	2020-02-04 16:07:01 +01:00
Christophe Robillard	6fc8a27bd7	destroys not all dossiers ... but only dossiers for a specific user	2020-02-04 16:07:01 +01:00
Christophe Robillard	cee4c5b8fb	Revert "Revert "4127 fix superadmin supprime compte usager"" ... This reverts commit 751f24f7bb.	2020-02-04 16:07:01 +01:00
clemkeirua	57a0973c99	added a test to show #4658 does not exist	2020-02-03 15:43:53 +01:00
Paul Chavard	08400cdd4c	Poll for export readiness updates	2020-01-29 22:52:03 +01:00
clemkeirua	1c3573c7db	fix DoubleRender error for brouillon pdf	2020-01-29 14:24:23 +01:00
clemkeirua	fcea7c4f85	remove invalid excel worksheet characters	2020-01-29 11:45:56 +01:00
Paul Chavard	6030409b2f	[GraphQL] Use GraphQL::Types::BigInt instead of Int	2020-01-28 21:48:00 +01:00
Pierre de La Morinerie	96932faa3f	models: add a Dossier#with_hidden scope, and remove unscoped usages	2020-01-28 17:32:38 +01:00
Pierre de La Morinerie	1448d5b098	models: add a Procedure#with_hidden scope, and remove unscoped usages ... This avoids the broad use of `unscoped` to remove the `hidden_at` clause.	2020-01-28 17:32:38 +01:00
Pierre de La Morinerie	4efea77280	specs: regroup dossier scope specs together	2020-01-28 17:32:38 +01:00
clemkeirua	5f65665b07	added a method for modifying a user email	2020-01-28 16:15:46 +01:00
Paul Chavard	f7c59cffc0	Fix tests for skylight	2020-01-28 15:39:37 +01:00
Pierre de La Morinerie	2c795a5ff4	Revert "app: hide IE11 deprecation banner during the strike" (#4713) ... Le bandeau indiquant qu'Internet Explorer 11 est très ancien est à nouveau affiché	2020-01-28 15:19:01 +01:00
Pierre de La Morinerie	745b00366f	Revert "app: hide IE11 deprecation banner during the strike" ... This reverts commit c2882b6cc3.	2020-01-28 15:18:18 +01:00
Paul Chavard	eec38bad73	Ajouter les informations de l’instructeur et de l’expert dans l’export des avis ... fix #4667	2020-01-28 15:09:41 +01:00
clemkeirua	65b4bcf3a1	Permet de déposer un dossier lorsqu'un menu déroulant lié obligatoire n'a pas de valeur (car la liste est légitimement vide) dans le second champ.	2020-01-28 14:30:26 +01:00
Paul Chavard	67dea1ee50	Update spec/models/procedure_spec.rb ... Co-Authored-By: Pierre de La Morinerie <kemenaran@gmail.com>	2020-01-28 12:49:53 +01:00
Paul Chavard	517ab25783	Register canonical procedure when demarche republished under existing path	2020-01-28 12:49:53 +01:00
Pierre de La Morinerie	aaaf6f393b	specs: add an actual test case to the Exercice spec ... This fixes the "No timing found for 'spec/models/exercice_spec.rb'" warning message during specs.	2020-01-28 12:00:34 +01:00
Pierre de La Morinerie	751f24f7bb	Revert "4127 fix superadmin supprime compte usager"	2020-01-21 18:57:54 +01:00
Pierre de La Morinerie	792ba73643	factories: ensure that dossiers with_entreprise are consistent	2020-01-21 17:24:56 +01:00
Pierre de La Morinerie	0efb62f03a	factories: ensure that dossiers with_individual are consistent	2020-01-21 17:24:56 +01:00
Pierre de La Morinerie	724ff50363	factories: rename dossier for_individual to with_individual ... This clarifies the distinction between ``` create :procedure, :for_individual ``` and ``` create :dossier, :with_individual ```	2020-01-21 17:24:56 +01:00
Pierre de La Morinerie	00e5b736fb	factories: mark the parent procedure as for_individual ... This ensures that we don't get an inconsistency, where a dossier is `for_individual` while its procedure is not `for_individual`.	2020-01-21 17:24:56 +01:00
Pierre de La Morinerie	6a47458112	specs: use order-insentitive matching for arrays ... The specs sometime failes locally, because the order of the returned objects is undefined. This is an acceptable behavior – but it means we should test for collection membership, rather than for a specific array order. Replace `match` by `match_array` to have unordered matching.	2020-01-21 17:24:56 +01:00
Christophe Robillard	675bbdad15	transfere les services lors de suppression admin ... Lorsqu'un administrateur est supprimé, ses services sont transférés à un autre administrateur pour chacune de ses procédures	2020-01-21 15:05:33 +01:00
Christophe Robillard	d9570eedc6	empêche suppression d'un user qui est instructeur	2020-01-21 15:05:33 +01:00
Christophe Robillard	a6d007dbd3	supprime un instructeur	2020-01-21 15:05:33 +01:00
Christophe Robillard	d4de5769ee	empêche la suppression d'un user qui est admin	2020-01-21 15:05:33 +01:00
Christophe Robillard	d8a51f986f	supprime un utilisateur qui a des dossiers cachés	2020-01-21 15:05:33 +01:00
clemkeirua	fb87a87f47	code review changes	2020-01-20 16:15:02 +01:00
clemkeirua	499f93aed3	ajout d'un test pour l'ecran de reaffectation des dossiers	2020-01-20 16:15:02 +01:00
clemkeirua	4e8ecb048c	ajout d'un test pour la suppression des groupes	2020-01-20 16:15:02 +01:00
clemkeirua	d6e7799370	removed routing condition in weekly summary	2020-01-20 14:23:19 +01:00
clemkeirua	7e15c6a4a4	add filtering by group in procedure_overview ... The weekly overview do not work for instructeurs in procedures with multiples groups ; they see dossiers that they do not have access to. Now the correct filter is added	2020-01-20 14:23:19 +01:00
Paul Chavard	4edc7b00cf	Use geocoder	2020-01-15 15:04:04 +01:00
Paul Chavard	14295db9ad	Revert "Revert "Merge pull request #4552 from tchak/champ-communes"" ... This reverts commit 4373cb22cb.	2020-01-14 18:46:07 +01:00
clemkeirua	0c2ccb4ae0	added automated tests for PDF rendering ... - as a user, it should not display the administration info - as an instructeur, it should display the administration info - it should render the proper view with no crash	2020-01-14 09:29:29 +01:00
clemkeirua	4373cb22cb	Revert "Merge pull request #4552 from tchak/champ-communes" ... This reverts commit 4cec26f73a, reversing changes made to 0ef25ef36c.	2020-01-13 16:26:27 +01:00
Christophe Robillard	d289c21a8b	speak english for test descriptions	2020-01-13 10:06:43 +01:00
Christophe Robillard	0f881f942b	raise if trying to del a user who can't be deleted	2020-01-13 10:06:43 +01:00
Christophe Robillard	696a058280	delete adminis with procs managed by other admins	2020-01-13 10:06:43 +01:00
Christophe Robillard	a0b4d97d08	fix rubocop offenses	2020-01-13 10:06:43 +01:00
Christophe Robillard	9a62d3fe0c	delete a user	2020-01-13 10:06:43 +01:00
Christophe Robillard	58ef36ff57	tells if a user can be deleted	2020-01-13 10:06:43 +01:00
Paul Chavard	c6326bfa77	Fix tests involving attachment urls	2020-01-08 14:46:18 +01:00
Pierre de La Morinerie	b3558c497d	dossiers: make build_default_individual explicit ... It avoid the use of callbacks, and may avoid situations where an empty individual is implicitely created.	2020-01-08 10:48:22 +01:00
Pierre de La Morinerie	5e05556ee8	dossiers: add a validation on dossier individual ... Validate that a dossier on a `for_individual?` procedure always has an `individual` associated record. For this, the individual needs to be built before the record is validated (i.e. even before the `before_create` callback is run). This should help with #4596: now if a dossier is created without an `individual`, or if the `invividual` record is later removed, the validation will fail.	2020-01-08 10:48:22 +01:00
Pierre de La Morinerie	7f5b0d8bf3	specs: don't create an implicit brouillon in all test cases	2020-01-07 17:59:11 +01:00
Pierre de La Morinerie	630c6de967	specs: move the query for individual to the individual context	2020-01-07 17:59:11 +01:00
Paul Chavard	e61e39d345	Remove unused code and tests	2020-01-07 11:52:51 +01:00
Paul Chavard	ff46ee366e	Fix user brouillon spec	2020-01-07 11:52:51 +01:00
Paul Chavard	4bbd16576b	Add champ communes	2020-01-07 11:52:51 +01:00
Pierre de La Morinerie	8eb295d67e	dossiers: avoid exceptions on invalid AASM transitions ... When attempting an invalid transition on a dossier, provide a meaningful error message (instead of letting an `AASM::InvalidTransition` exception propagate). This handles not only the case where the same state is applied twice (which was already handled manually), but all cases where the transition is invalid.	2019-12-19 13:25:32 +01:00
Pierre de La Morinerie	c7a307553c	helpers: allow dossier_display_state to take a state as input ... This allow to use either: - `dossier_display_state(dossier)` - `dossier_display_state(:en_construction)`	2019-12-19 13:22:40 +01:00
simon lehericey	60538c9c28	Controller use new export model	2019-12-18 13:13:15 +01:00
simon lehericey	745086cbb5	Simplify view	2019-12-18 13:13:15 +01:00
simon lehericey	d0939ae1a4	Add Export Model	2019-12-18 13:13:15 +01:00
simon lehericey	d0f0533a32	Remove unused code	2019-12-18 13:13:15 +01:00
simon lehericey	c02e8b9553	Routing: send emails to the right group	2019-12-16 17:47:08 +01:00
maatinito	a02a5edce3	Bug with time zone when testing sending of brouillon expiration notices	2019-12-11 17:34:10 +01:00
maatinito	9672d892e9	Bug with time zone: Time.zone.today looses time_zone and may breaks database comparisons	2019-12-11 17:34:10 +01:00
simon lehericey	058442c84e	[link to #4557] An instructeur cannot change its email on its own	2019-12-11 17:18:21 +01:00
simon lehericey	e06733d01b	Clean spec	2019-12-11 17:18:21 +01:00
Paul Chavard	6b5793f0b9	[GraphQL] fix a crash in mutations with an attachment	2019-12-11 13:22:32 +01:00
Paul Chavard	422b7f37ec	[GraphQL] expose file information	2019-12-11 12:34:49 +01:00
Pierre de La Morinerie	c2882b6cc3	app: hide IE11 deprecation banner during the strike ... Having two banners appearing in a few days may be overwhelming for users.	2019-12-04 17:32:04 +01:00
Paul Chavard	2f060fc30a	Add depubliee state to procedures	2019-12-04 16:52:41 +01:00
Paul Chavard	b5eafdab56	[GraphQL]: informations du service	2019-12-04 14:21:40 +01:00
Paul Chavard	fd42fafcb4	[GraphQL]: informations du demandeur du dossier	2019-12-04 12:39:29 +01:00
Christophe Robillard	4e7c779116	refuse les numéros de tel invalides ... rend facultatif les numéros de téléphone	2019-12-04 05:34:43 +01:00
simon lehericey	006e426a11	Work on deletion mail	2019-12-03 17:18:53 +01:00
simon lehericey	79bfb8b143	Delete expired dossiers	2019-12-03 17:18:53 +01:00
simon lehericey	6391f7ff9c	Work on notify_near_deletion mailer	2019-12-03 17:18:53 +01:00
simon lehericey	03b7e81ca4	Send deletion notice for near expired brouillon	2019-12-03 17:18:53 +01:00
Pierre de La Morinerie	3212dfddca	app: allow hiding the browser banner for one week	2019-12-03 16:09:18 +01:00
Pierre de La Morinerie	fb3f82074d	Hide the suggestions when the user corrects the address	2019-12-03 14:06:11 +01:00
Pierre de La Morinerie	1d1260060e	Fix the tests by using event delegation	2019-12-03 14:06:11 +01:00
clemkeirua	849008231c	ajout de test capybara	2019-12-03 14:06:11 +01:00
Paul Chavard	7b947feae4	Rename demarche archivée to demarche close	2019-11-28 15:07:16 +01:00
Paul Chavard	3e334a3306	Drop test_started_at ... # Conflicts: # spec/models/procedure_spec.rb	2019-11-28 14:17:47 +01:00
Pierre de La Morinerie	e7dd9e36d6	specs: fix Capybara warning ... Capybara logs several warnings during tests: > Locator Integer:243 for selector :link must be an instance of String > or Symbol. This will raise an error in a future version of Capybara. This is because we use selectors like `have_link(dossier.id)`, where the locator is a Number (instead of a String or Symbol).	2019-11-28 12:09:12 +01:00
simon lehericey	6657459f9c	Fix add instructeur with empty mail ... As select2 does not handle required attribute, we can only add server side logic	2019-11-27 14:39:16 +01:00
Paul Chavard	e9f993fe0c	[GraphQL]: normalize date names in French	2019-11-27 12:23:00 +01:00
Pierre de La Morinerie	a328e8d94a	features: refactor the editor specs ... - Add an `add_champ` helper - Stop relying on a default champ being created - Wait for all champs to be created by watching the "Add champ" button This should fix the flakiness of these tests. Refs #4417	2019-11-27 11:58:46 +01:00
Pierre de La Morinerie	d0cd875e91	features: add a leave_browser_open helper	2019-11-27 11:58:45 +01:00
Pierre de La Morinerie	0ef4a5253c	features: move feature matchers to their own file ... This allows to have the same syntax than native Capybara matchers.	2019-11-27 11:58:45 +01:00
maatinito	9de9a1fd71	Use time.zone functions instead of server time functions ... (Time.zone.today vs Date.today)	2019-11-26 14:26:36 +01:00
maatinito	14bc2b99b9	auto-archive badly occurs in UTC time and not in local time (1 hour too late in France, 10 hours before in Tahiti ;-)	2019-11-25 14:39:42 +01:00
clemkeirua	789fcf72ca	ajout d'un test automatisé	2019-11-25 10:37:10 +01:00
Pierre de La Morinerie	1de4ef8a9a	specs: fix error in routing feature test by waiting for Turbolinks	2019-11-21 18:37:51 +01:00
Pierre de La Morinerie	b78134c691	specs: make the routing feature test more robust ... - Use human-readable form labels - Always wait for the result of the previous action to be loaded before starting another action	2019-11-21 18:29:45 +01:00
Pierre de La Morinerie	68f5aae99d	autosave: add feature test	2019-11-21 14:00:06 +01:00
Paul Chavard	0c6705f7fd	Drop old export service	2019-11-21 10:25:40 +01:00
Christophe Robillard	b42f21264e	permet le suivi auto après envoi instructeur ... Close #4163	2019-11-20 16:41:30 +01:00
Pierre de La Morinerie	8b8a96abda	dossiers: save draft by default (instead of submitting) ... Make the default behavior of `update_brouillon` be to update the draft, instead of submitting the dossier. This makes all requests made to `update_brouillon` without specifying an extra `submit_draft` parameter to just save the draft. It will make autosaving the draft easier and safer.	2019-11-20 11:24:31 +01:00
simon lehericey	dae7a3bfd0	[fix #4529] Log user email in manager space	2019-11-19 12:15:03 +01:00
Paul Chavard	e600aceccc	[GraphQL]: add dossier state change mutations	2019-11-19 11:51:34 +01:00
simon lehericey	4b62c9267a	fix flaky test	2019-11-18 17:26:28 +01:00
simon lehericey	361e57355a	Spec: full_scenario use js	2019-11-18 17:08:51 +01:00
simon lehericey	8a42b9f97a	Add groupe instructeur mailer preview	2019-11-18 17:08:51 +01:00
simon lehericey	9ca026a630	Use a select2 box for looking to instructeurs	2019-11-18 17:08:51 +01:00
Paul Chavard	ba03dbf8dd	[GraphQL] Add dossierEnvoyerMessage mutation	2019-11-13 19:54:27 +01:00
Paul Chavard	f0ac01bf19	[GraphQL]: test unauthorized mutation	2019-11-13 19:54:27 +01:00
Paul Chavard	ea6667ff9f	[GraphQL]: démarche and dossier number should be a number	2019-11-13 15:53:56 +01:00
Paul Chavard	fa741c9bae	[GraphQL]: do not return dossiers brouillons	2019-11-07 22:07:42 +01:00
Paul Chavard	990c867c2e	[GraphQL] Add more filters to dossiers	2019-11-07 22:07:42 +01:00
Paul Chavard	f22b39b7c5	Handle non unique champ repetable labels ... fix #4466	2019-11-07 14:27:52 +01:00
Paul Chavard	2a61ed5b1c	Export etablissement information in csv ... fix #4440	2019-11-07 14:27:52 +01:00
Paul Chavard	4231b81727	[GraphQL] Add create direct upload mutation	2019-11-07 12:48:51 +01:00
simon lehericey	9469734f29	Follow flipper name convention to appears on manager admin page	2019-11-07 11:09:05 +01:00
clemkeirua	7f76ab6671	disable retry sending a mail with an invalid email adress	2019-11-07 10:11:48 +01:00
Paul Chavard	0562e2728f	Fix type_de_champ validation error	2019-11-06 12:54:07 +01:00
Pierre de La Morinerie	8df91df9fa	assigns: strip and lowercase the search filter	2019-11-06 12:16:30 +01:00
Pierre de La Morinerie	0eeac59ecd	assigns: fix search among the unassigned instructeurs ... This was broken since moving the email out of the Instructeur column.	2019-11-06 12:16:30 +01:00
Paul Chavard	efd03f0169	Use webdrivers gem to keep webdrivers updated	2019-11-06 11:20:40 +01:00
simon lehericey	395aba8bbc	Remove administrateur active notion	2019-11-05 14:10:39 +01:00
simon lehericey	5643e671a0	Code use user.active?	2019-11-05 14:10:39 +01:00
simon lehericey	b193dd1465	User get the active notion	2019-11-05 14:10:39 +01:00
simon lehericey	aeb44dd2aa	Cleaning spec	2019-11-05 10:29:39 +01:00
simon lehericey	e3d7688e66	[fix #4473] Invite_administrateur!: do not reset password if the user is active	2019-11-05 10:29:39 +01:00
simon lehericey	53c7997081	Invite_administrateur!: characterization test	2019-11-05 10:29:39 +01:00
Pierre de La Morinerie	f63cd86811	webhook: fix a crash when the Helpscout customer is unknown	2019-11-04 18:36:52 +01:00
Pierre de La Morinerie	a458693a19	specs: fix #usual_traitement_time tests when near the DST date	2019-11-04 10:56:15 +01:00
Pierre de La Morinerie	f8358b3ae9	instructeurs: create without providing the email	2019-11-04 10:44:24 +01:00
Pierre de La Morinerie	f131dbb80d	instructeurs: make the create form not using email directly ... Before the form attempted to read an email value from the Instructeur model, and failed (because the empty Instructeur had no user yet). We could let `Instructeur#email` return `nil` if there is no User – but as a created Instructeur is always supposed to have a User, this seems like a nice safeguard to keep. So instead this commit rewrites the create form, which now doesn’t depend on an Instructeur model. Seems easy enough for now.	2019-11-04 10:44:24 +01:00
Pierre de La Morinerie	d78d206544	instructeurs: fix expert creation not to use Instructeur.email ... It kind of worked until now, because the email field is disabled, and thus never accessed. But better make it clean, by accessing an object (User) where the email field actually exists.	2019-11-04 10:44:24 +01:00
Pierre de La Morinerie	38f994a151	instructeurs: fix mailer previews not to use Instructeur.email ... Mailers previews now create mock Instructeurs without directly accessing the email.	2019-11-04 10:44:24 +01:00
Pierre de La Morinerie	8e6930d257	instructeurs: fix ProcedurePresentation to use instructeur.user.email ... The `joins` are declared explicitely in order to associate a predictable name to the joined table. Otherwise, when the query is joined with `:users`, ActiveRecord will alias the join automatically to solve the conflict. Unfortunately, the automatic resolution means that the table name becomes unpredictable, and thus unsuitable to perform queries on.	2019-11-04 10:44:24 +01:00
Pierre de La Morinerie	a462edb9bc	instructeurs: alias instructeur.email ... This also means we need to replace instances of `pluck` on the email column.	2019-11-04 10:44:24 +01:00
Pierre de La Morinerie	cd478b489e	instructeurs: replace calls to Instructeur.find_by(email: …)	2019-11-04 10:44:23 +01:00
Paul Chavard	839b0d7e6d	Add Entreprise raison sociale to dossier export ... fix #4422	2019-10-31 17:11:46 +01:00
Pierre de La Morinerie	1c61f2de58	views: refactor the attachment/edit view ... Make it more reusable, by: - Renaming `attachment/update` to `attachment/edit` - Refactoring the CSS styles into their own stylesheet - Allow to specify the 'accept' option	2019-10-31 10:27:19 +01:00
Pierre de La Morinerie	5be83bd01e	procedure: make the layout more similar to the mockup	2019-10-31 10:27:19 +01:00
Nicolas Bouilleaud	72b7ff221c	move procedure to new design	2019-10-31 10:27:19 +01:00
simon lehericey	477f7c9837	Remove instructeur	2019-10-30 14:27:51 +01:00
simon lehericey	79b808470c	Add instructeur	2019-10-30 14:27:51 +01:00
simon lehericey	94081a3997	Show Groupe Instructeur	2019-10-30 14:27:51 +01:00
simon lehericey	4491dca19a	Index Groupe Instructeur	2019-10-30 14:27:51 +01:00
simon lehericey	07aefdd40b	Fix test in new_admin/groupe_instructeur_controller	2019-10-30 14:27:51 +01:00
simon lehericey	cba9ffb753	full_scenario extended with notifications controle	2019-10-25 09:42:17 +02:00
simon lehericey	4febf1851f	notifications_for_procedure is now based on instructeur.groupe_instructeurs	2019-10-25 09:42:17 +02:00
simon lehericey	e290fc3674	No need to update column as the sign_up process activates the user	2019-10-24 18:32:48 +02:00
simon lehericey	8ae592fe25	[fix #4361] administrateur active	2019-10-24 18:32:48 +02:00
Pierre de La Morinerie	5fc88eb6a2	specs: fix a flaky repetitions test ... The test would sometime fail when the two fields are created in a different order than expected.	2019-10-24 16:52:29 +02:00
simon lehericey	e97c705628	Add end to end spec	2019-10-23 21:47:20 +02:00
simon lehericey	90ae4181bf	fix dossier_linked_path in routed procedure	2019-10-23 21:47:20 +02:00
simon lehericey	35bba62297	Update routing critéria name	2019-10-23 21:47:20 +02:00
simon lehericey	a5ffe9f54b	Remove instructeur from the group	2019-10-23 21:47:20 +02:00
simon lehericey	a6deafd885	Add instructeurs to groupe	2019-10-23 21:47:20 +02:00
simon lehericey	3dd3af8482	Groupe instructeur update	2019-10-23 21:47:20 +02:00
simon lehericey	9a6336f508	Groupe instructeur create	2019-10-23 21:47:20 +02:00
simon lehericey	733e83cc54	Groupe instructeur show	2019-10-23 21:47:20 +02:00
simon lehericey	2749c00ce3	Groupe instructeur index	2019-10-23 21:47:20 +02:00
simon lehericey	1fa149575c	Add constraints to GroupeInstructeur	2019-10-23 21:47:20 +02:00
Paul Chavard	86b271997b	Invite experts to linked dossiers ... closes #3669	2019-10-23 13:10:09 +02:00
clemkeirua	ad785278af	add mailer test	2019-10-22 09:51:14 +02:00
clemkeirua	43424e4f4e	merge with the work of paul, using 3 links	2019-10-22 09:51:14 +02:00
Pierre de La Morinerie	f0c2599d18	specs: improve feature spec for experts ... - Move the avis feature spec to a separate file - Add more test cases	2019-10-21 12:57:10 +02:00
Pierre de La Morinerie	ec6ec6f4aa	specs: improve avis factory ... The instructeur, dossier and claimant where created regardless of wether they already existed or not. With this commit: - Associations are declarated in a more idiomatic way - They are correctly not created if they are provided when creating the object.	2019-10-21 12:57:10 +02:00
Pierre de La Morinerie	a56dc0f653	specs: re-order method in feature helpers	2019-10-21 11:45:03 +02:00
Pierre de La Morinerie	0807fed258	specs: rename instructeur_spec.rb to instruction_spec.rb ... This clarifies the difference between this spec and the other instructeur specs in the same directory.	2019-10-21 11:27:35 +02:00
simon lehericey	18de25fac7	Display the dossier.groupe_instructeur.label on various screens	2019-10-17 15:48:14 +02:00
Pierre de La Morinerie	db0fede521	views: improve the state button ... - Turn the "accepted" infos into standard dropdown sections - Display the justificatif even if there is no motivation	2019-10-15 12:48:14 +02:00
Pierre de La Morinerie	dd57953b76	views: refactor the state button ... Now that all states have a dropdown, we can simplify the code. This also brings the "Repasser en instruction" action for all states (including when no attestation or motivation is present).	2019-10-15 12:48:14 +02:00
Pierre de La Morinerie	07f75ff20e	views: fix missing attestation link ... - Fix the missing link to see attestations (see #4400) - Fix the "Repasser en instruction" wording being confusing for accepted state - Add lot of tests	2019-10-15 12:48:14 +02:00
Pierre de La Morinerie	0e5f66c5ba	views: make the "Voir l'attestation" UI simpler ... Instead of adding a button, just turn the "attestation" text into a link	2019-10-15 12:41:37 +02:00
Pierre de La Morinerie	0064c2c610	views: tell an attestation will be sent only if it is true ... Previously the message stating "an attestation will be sent" was displayed even when the attestation was disabled.	2019-10-15 12:41:37 +02:00
Pierre de La Morinerie	c2e82e4145	champ_policy: allow instructeurs to access private annotations ... Fix #4388	2019-10-08 14:34:12 +02:00
simon lehericey	725798da6a	[fix #4361] Update user table sign_in	2019-10-08 10:09:16 +02:00
Paul Chavard	e7ed408e08	Auto-link valeur des champs ... closes #2865	2019-10-07 21:20:24 +02:00
Paul Chavard	2c486b8fe2	Bump some javascript dependencies	2019-10-07 15:40:27 +02:00
clemkeirua	053cc5cfc5	[fix #4058] instructeur peut passer accepte → instruction	2019-10-07 15:17:33 +02:00
Paul Chavard	3f36153807	[GraphQL] Add groupe_instructeurs to demarche	2019-09-26 11:25:14 +02:00
Nicolas Bouilleaud	03c950ea97	Move followed_dossiers_with_notifications to a Dossier scope ... Instead of instructeur.followed_dossiers_with_notifications, we can now write instructeur.followed_dossiers.with_notifications. Yay composition!	2019-09-25 14:10:00 +02:00
Nicolas Bouilleaud	a4166d3c57	Refactor Instructeur.notifications_* methods ... - rename `dossiers_id_with_notifications` to `followed_dossiers_with_notifications`, - rename `notifications_per_procedure` to `procedures_with_notifications`, - return an ActiveRecord::Relation instead of the result of the query, so that the call place can compose it, - `merge` with the wanted Dossier scope in the call places, don’t bother passing it as a parameter, - use the “state” (now “scope”) parameter as a scope method that can be just applied on `Dossier`.	2019-09-25 14:10:00 +02:00
Paul Chavard	4b885f7a12	Add basic graphql test	2019-09-24 10:47:21 +02:00
Paul Chavard	5a7eb734ff	Dump graphql schema for reference	2019-09-24 10:47:21 +02:00
Nicolas Bouilleaud	f74fde3f80	Avoid sending notification emails about archived dossiers	2019-09-20 11:06:33 +02:00
Nicolas Bouilleaud	a2131d0fcc	Don’t unfollow when archiving ... It was slightly broken in two ways: - it doesn’t make other instructeurs unfollow the dossier - if the dossier is unarchived, instructeurs don’t refollow automatically.	2019-09-20 11:06:33 +02:00
Nicolas Bouilleaud	769621de46	Explicitly pass the “state” param in notifications_*_procedure methods	2019-09-20 11:06:33 +02:00
simon lehericey	a2f82ab8be	Add groupe_instructeur_label to export v2	2019-09-19 12:30:12 +02:00
simon lehericey	f577484aa2	Add groupe_instructeur_label to export v1	2019-09-19 12:30:12 +02:00
simon lehericey	8660d4af30	Instructeur: only export its dossiers	2019-09-19 12:24:40 +02:00
simon lehericey	e2acb0a946	ProcedurePresentation: can use groupe instructeur	2019-09-18 15:51:02 +02:00
simon lehericey	f5bbc9e2f9	InstructeurProcedureShow: show dossier for all the gi involved	2019-09-18 15:51:02 +02:00
simon lehericey	9b16bd2037	Dossier: retrieve all dossiers for a procedure	2019-09-18 15:51:02 +02:00
simon lehericey	21577a0f0b	Instructeur: dedup procedures with multiple gi	2019-09-18 15:51:02 +02:00
Paul Chavard	8fcf1353f3	Remove duplicated attachments	2019-09-17 18:12:53 +02:00
simon lehericey	dec42e4886	Instructeur procedure index: show stats by procedure ... Also sum the count from differents groupe_instructeur from the same procedure	2019-09-17 17:19:14 +02:00
simon lehericey	d338f9b9f3	Factory: can create a dossier with a defined gi	2019-09-17 17:19:14 +02:00
Paul Chavard	11b4698ef3	Fix test	2019-09-17 16:58:11 +02:00
pedong	d2a78abc3a	[fix #3975] set buttons floating in dossier page	2019-09-17 16:58:11 +02:00
Nicolas Bouilleaud	78da268ded	Improve feature tests for procedure cloning and creation	2019-09-17 16:30:48 +02:00
Nicolas Bouilleaud	543f9894c1	Make sure the “commencer” link uses the proper test path	2019-09-17 16:30:48 +02:00
Nicolas Bouilleaud	c26a701a17	Refactor and redesign publish modal ... * remove the autocomplete menu * use ujs to pre-validate the procedure * tweak the UI	2019-09-17 16:30:48 +02:00
Nicolas Bouilleaud	bd1e0aba38	Add Procedure path suggestion	2019-09-17 16:30:48 +02:00
Nicolas Bouilleaud	00c37eccb3	Simplify procedure.path and publish event ... * Get rid of the “reopen” event, merge it with “publish” (it’s the same code) * Remove the “availability” states; “available with brouillon” makes no sense since the brouillons path are always uuids * Instead of checking if publish can happen, just try it and handle the errors	2019-09-17 16:30:48 +02:00
Nicolas Bouilleaud	92e6032115	Remove path availability dead code when creating/editing a procedure ... There’s no “path” field anymore in the Procedure form, it can only be set when publishing.	2019-09-17 16:30:48 +02:00
Nicolas Bouilleaud	8fa630d2bb	Remove Gestionnaire.visible_procedures ... It is actually the same thing as Gestionnaire.procedures. It already included the procedures with paths as well as the archived procedures, and in production, there were no Gestionnaire for who procedures was returning a different result than visible_procedures (expect for two baddata brouillon procedures with a nil path). In addition, Procedure.path is now nonnull, which means the Procedure.avec_lien scope is pointless. Finally, the current spec showed that the only procedure not visible to the gestion was the one he was not assigned to.	2019-09-17 16:30:48 +02:00
Nicolas Bouilleaud	e9c6ed80e4	Migration: Index and make Procedure.path nonnull	2019-09-17 16:30:48 +02:00
Nicolas Bouilleaud	fc416ee2ec	Fix procedure_locked_spec ... `login_as administrateur, scope: :administrateur` doesn’t seem to actually do anything, but testing for the _absence_ of content can’t break. - Make the test fail if login fails, - Fix the login, - Write the opposite test, - Update the searched content to the actual text used in the partial	2019-09-17 14:50:37 +02:00
clemkeirua	949a0c21e6	gestion des 2 formats de bouton monavis	2019-09-17 13:39:45 +02:00
Paul Chavard	ff2b6ca3ea	Fix service controller	2019-09-17 12:37:37 +02:00
Paul Chavard	8a691d534a	Fix AdministrateurUsageStatisticsService	2019-09-17 12:37:37 +02:00
Paul Chavard	adfa80142a	Cleanup application_controller and current_user	2019-09-17 12:37:37 +02:00
Paul Chavard	b97cbd3402	Serialize champ repetition for tags ... closes #4272	2019-09-12 17:23:18 +02:00
Paul Chavard	3b8d3b7967	Add Style/CollectionMethods to rubocop	2019-09-12 14:48:18 +02:00
Pierre de La Morinerie	503c393a87	helpscout: use replies_sent to compute contact rate ... The `conversations_count` we previously used counts replies, but also all conversations that were tagged or re-tagged during the month – with made counting the actual work spent on user support brittle. Counting the replies is a better estimation of what we get. Unfortunately this also removes the filtering-by-tag feature. To mitigate this, the reports are now scoped to a specific mailbox. This allows to create extra mailboxes for conversations that should't be counted in the stats.	2019-09-11 17:26:10 +02:00
Paul Chavard	c370c2f475	Cleanup FlipFlop	2019-09-10 23:52:44 +02:00
Pierre de La Morinerie	d94a5cee8e	spec: during js specs, cleanup database using deletion ... This attempts to solve the database deadlock on cleanup by fiddling with the settings. Ref #4293	2019-09-10 16:40:02 +02:00
Paul Chavard	65e227c44b	Migrate to flipper	2019-09-10 16:10:14 +02:00
clemkeirua	feb9c32537	search attachments inside bloc repetables	2019-09-10 15:30:44 +02:00
Paul Chavard	347f03d2a9	Redirect to pdf attachement old name if not attached	2019-09-10 15:06:47 +02:00
Paul Chavard	3eb3ae001e	Rename “Passé en construction le” to 'Déposé le' for clarity	2019-09-10 14:59:10 +02:00
Chaïb Martinez	dd6c6bfe7a	mailers: add a NO_REPLY address to transactional emails	2019-09-10 13:37:28 +02:00
Pierre de La Morinerie	aa1cf6788b	mailers: turn revert_to_instruction into a notification email	2019-09-10 13:29:06 +02:00
pedong	25596ca2f2	[fix #4181] add service to procedure API	2019-09-10 11:06:28 +02:00
Paul Chavard	7ffb98e616	Remove carrierwave uploaders	2019-09-10 10:49:12 +02:00
Pierre de La Morinerie	2724f4667b	groupe_instructeur: unsassign instructeurs on group destroy ... Fix #4282	2019-09-09 17:29:29 +02:00
simon lehericey	b9f35a9763	ensure that the task is idempotent	2019-09-09 14:08:09 +02:00
simon lehericey	875313e01e	add defaut groupe instructeur to hidden procedure	2019-09-09 13:41:08 +02:00
simon lehericey	3ead6bde9d	AfterParty: link dossier and groupe_instructeur	2019-09-03 06:51:38 +02:00
simon lehericey	ad7ef6c739	Link assign_to and procedure by groupe_instructeur	2019-09-03 06:47:02 +02:00
simon lehericey	d582af0962	Fix Instructeur Procedure Index	2019-09-03 06:47:02 +02:00
simon lehericey	d0bfb62fec	Procedure Factory: use procedure.new_dossier	2019-09-03 06:47:02 +02:00
simon lehericey	6cbdba2665	Dossier Factory: link procedure by defaut_groupe_instructeur ... Oblige to create procedure or dossier to access groupe_instructeur	2019-09-03 06:47:02 +02:00
simon lehericey	74096b6b3a	Assign Factory: automatically link to procedure.defaut_groupe_factory	2019-09-03 06:47:02 +02:00
simon lehericey	a0555bc820	Remove obsolete tasks	2019-09-03 06:47:02 +02:00
simon lehericey	3cc8f0c792	Link Dossier and GroupeInstructeur	2019-09-03 06:47:02 +02:00
simon lehericey	eb75a563b8	Fix old after_party spec	2019-09-02 11:41:12 +02:00
simon lehericey	a2061fba79	wording	2019-09-02 11:41:12 +02:00
simon lehericey	caf1fbca44	Use assign_to	2019-09-02 11:41:12 +02:00
simon lehericey	31cb056351	Procedure: remove direct instructeurs access ... Add shortcut for the spec to assign instructeurs directly to the defaut groupe	2019-09-02 11:41:12 +02:00
simon lehericey	b541ef0b41	Procedure has many instructeurs with defaut_groupe_instructeur	2019-09-02 11:41:12 +02:00
simon lehericey	ba24958035	Procedure add missing_instructeurs?	2019-09-02 11:41:12 +02:00
simon lehericey	85499365a0	Instructeur has_many procedures through groupe_instructeur	2019-09-02 11:41:12 +02:00
simon lehericey	25991c2892	Assign a procedure assign a group as well	2019-09-02 11:41:12 +02:00
simon lehericey	115d91387c	A procedure has a default groupe instructeur	2019-09-02 11:41:12 +02:00
clemkeirua	4032fc61e3	move to only one pipedrive account	2019-08-28 12:16:25 +02:00
Paul Chavard	15148a4fe1	Fix invalid characters in repetition champs sheet_name for xls export	2019-08-28 10:47:58 +02:00
Paul Chavard	079ffadfce	Attestation files migration task	2019-08-27 17:43:06 +02:00
Paul Chavard	a19b10b118	Migrate attestation files to active_storage	2019-08-27 17:42:52 +02:00
clemkeirua	188e0fd6b2	removed ask_birthday for new procedures & dossiers	2019-08-27 15:32:17 +02:00
simon lehericey	7b9b90a3e0	[fix #4238] When the token does not exist, redirect to home page without sending a new link	2019-08-27 15:01:46 +02:00
simon lehericey	7ffad1e6ae	Spec: factorize	2019-08-27 15:01:46 +02:00
simon lehericey	e9cabafcc5	Spec: resend token if it's invalid	2019-08-27 15:01:46 +02:00
Chaïb Martinez	8ad79d3235	New signup test ... Signed-off-by: Chaïb Martinez <chaibax@gmail.com>	2019-08-27 10:45:26 +02:00
Paul Chavard	d02e0fc556	Fix and test migrate_procedure_logo task	2019-08-22 11:28:03 +02:00
simon lehericey	fc7ce3fe61	Fix capybara on linux ubuntu ... Otherwise, it appears fullscreen	2019-08-21 17:38:54 +02:00
Paul Chavard	cc35a04e26	Migrate procedure logo to active_storage	2019-08-21 11:15:00 +02:00
simon lehericey	eb2ebee16e	fix flaky spec in ip_service_spec	2019-08-20 16:41:32 +02:00
simon lehericey	86d968bb8e	Use rack_attack_enabled? ... We cannot enable rack attack during the tests as it interferes with features spec. So we add a flag to enable it during the runtime.	2019-08-20 13:29:29 +02:00
simon lehericey	0f0fecdb25	RackAttack: use remote ip and test it !	2019-08-20 13:29:29 +02:00
simon lehericey	b7f8bb2fea	Simplify ip_service	2019-08-20 13:29:29 +02:00
simon lehericey	e0e29d741f	Simplify instructeur and administrateur factory	2019-08-20 12:20:12 +02:00
simon lehericey	97d0855d47	add User.create_or_promote_to_instructeur	2019-08-20 12:20:12 +02:00
simon lehericey	ebe871819d	Fix admin deletion by an administration	2019-08-20 12:01:36 +02:00
simon lehericey	77c11d8b79	fix_procedure_presentation	2019-08-20 11:28:18 +02:00
Paul Chavard	e9ba7700d4	Remove commentaire file uploader	2019-08-20 10:24:13 +02:00
simon lehericey	80cb8b87fe	Keep only the FC logic and use devise for the rest	2019-08-16 16:48:22 +02:00
simon lehericey	54d7effe28	Spec: specify france_connect logic	2019-08-16 16:48:22 +02:00
simon lehericey	4be9c79e03	Spec : specify remember me	2019-08-16 16:48:22 +02:00
simon lehericey	08bb393ced	Spec: specify locked logic	2019-08-16 16:48:22 +02:00
simon lehericey	1b14d85c77	Rerender if wrong credentials	2019-08-16 16:48:22 +02:00
simon lehericey	9a6b3c3757	Spec: specify the redirections when logged in	2019-08-16 16:48:22 +02:00
simon lehericey	56d34173e6	Spec: remove multi devise account tests	2019-08-16 12:04:54 +02:00
simon lehericey	95cd301d0d	Spec: remove superfluous code	2019-08-16 11:47:53 +02:00
simon lehericey	f87e316a5d	Spec: remove outdated trusted_device logic ... This is tested on the application controller	2019-08-16 11:45:40 +02:00
simon lehericey	58ecf18390	ActivateController: add tests and clean a bit	2019-08-16 11:22:36 +02:00
simon lehericey	972b6793f7	Remove useless sessions_controller	2019-08-14 18:04:26 +02:00
simon lehericey	7fbedb78fb	Add feature spec about managing passwords (with the courtesy of kemenaran)	2019-08-14 17:27:10 +02:00
simon lehericey	149b0b5797	Fix Sign out	2019-08-14 16:58:50 +02:00
simon lehericey	e3e6bc7689	! NEED JOB REBOOT Move remind activation logic to user	2019-08-14 16:34:50 +02:00
simon lehericey	dc816472e9	Stub administrateur devise methods in spec	2019-08-14 16:34:50 +02:00
simon lehericey	d0ac1c3301	Fix manager invite administrateur	2019-08-14 16:34:50 +02:00
simon lehericey	c08e356367	Remove or fix nonsense code	2019-08-14 15:08:14 +02:00
simon lehericey	c380d807ab	Spec: sign_in with administrateur.user	2019-08-14 15:08:14 +02:00
simon lehericey	1b38d4071d	temporary remove password complexity check	2019-08-14 15:06:16 +02:00
simon lehericey	27c81c1992	Update administrateur factory	2019-08-14 15:06:16 +02:00
Paul Chavard	e68d2cf5e2	Enable champ repetition for all	2019-08-14 12:53:51 +01:00
Paul Chavard	0969b1f85f	Enable email_login_token for all gestionnaires	2019-08-14 12:53:51 +01:00
simon lehericey	a9128895a2	Something wrong with stored location which prevent instructeur to be redirected to user procedure path	2019-08-13 15:15:16 +02:00
simon lehericey	640e3668a8	Strange session ...	2019-08-13 15:15:16 +02:00
simon lehericey	8fa3c9e4f7	Fix expert invitation	2019-08-13 15:15:16 +02:00
simon lehericey	fdbfd3bb42	Add feature spec on instructeur invitation	2019-08-13 15:15:16 +02:00
simon lehericey	5fdac38cb2	Fix instructeur invitation	2019-08-13 15:15:16 +02:00
simon lehericey	ad31822a68	Spec: sign_in with instructeur.user	2019-08-13 15:15:16 +02:00
simon lehericey	65a53909e1	Update instructeur factory	2019-08-13 15:15:16 +02:00
simon lehericey	47b7dc368b	Remove or fix now nonsense code	2019-08-13 15:15:16 +02:00
simon lehericey	0d71a820a8	Stub instructeur devise methods in spec	2019-08-13 15:15:16 +02:00
simon lehericey	e3fd1cc33a	Remove weird switch_devise_profile_service	2019-08-13 15:15:16 +02:00
Pierre de La Morinerie	79784089a4	dossiers: refresh the whole header actions bar on status change ... This ensure the other state-dependant buttons get updated to–like the "Follow" or "Archive" button. Fix #4186	2019-08-13 15:07:22 +02:00
simon lehericey	5bda753735	Remove all devise route and controller for instructeur and administrateur	2019-08-13 14:13:48 +02:00
simon lehericey	a4b9eecded	Remove unused devise session controller	2019-08-13 14:13:48 +02:00
simon lehericey	3fde2a6f70	Rename gestionnaire in code to instructeur	2019-08-12 13:47:01 +02:00
simon lehericey	6902f84b85	Brutally rename gestionnaire filename to instructeur	2019-08-12 13:47:01 +02:00
simon lehericey	bb8d65c6b4	Subtly rename admin/instructeurs to admin/assigns	2019-08-12 13:47:01 +02:00
simon lehericey	f7528f70ac	add admin creation spec	2019-08-12 13:43:03 +02:00
clemkeirua	6c56fc73d7	used new constant for genders	2019-08-01 20:46:58 +02:00
clemkeirua	d7105cb6f8	added spec for dossier#update_with_france_connect	2019-08-01 17:42:32 +02:00
clemkeirua	6c52c71eee	add redirection spec for dossier_controller#new	2019-08-01 17:42:32 +02:00
maatinito	44efa5a1b1	#3928 administrator tests handle password constants	2019-08-01 17:12:14 +02:00
maatinito	8d3e3baabc	#3928 administrator new & edit pwd pages	2019-08-01 17:12:14 +02:00
Paul Chavard	02904f55b1	Fix champ policy	2019-08-01 16:41:53 +02:00
Paul Chavard	b8d3e4c41b	Fix attestation url for dossiers with no attestation	2019-08-01 15:53:50 +02:00
Pierre de La Morinerie	6459e9cf37	tasks: fix the commentaires migration task to work with hidden dossiers ... By default `commentaire.dossier` doesn't return the dossier if it is hidden.	2019-08-01 15:43:09 +02:00
Paul Chavard	c75e39884e	Save selection utilisateur as geo area	2019-08-01 11:38:09 +02:00
clemkeirua	f5d3818e3c	remove unnecessary retransition methods	2019-08-01 10:40:08 +02:00
Keirua	2f82dd9a3d	improve typography and texts ... Co-Authored-By: Nicolas Bouilleaud <nico@bou.io>	2019-08-01 10:29:51 +02:00
clemkeirua	38b48f4217	transition from accepte to instruction as superadmin	2019-08-01 10:29:51 +02:00
Paul Chavard	b266915892	Add repetitions to api	2019-08-01 10:04:35 +02:00
Paul Chavard	fba195c0b5	Add attestation url to dossier on api	2019-07-31 18:30:40 +02:00