simon lehericey
9c8020b05c
feat(admin): add initiation procedure for a new admin
2023-05-03 15:08:21 +02:00
Colin Darie
eabc9069f8
test(super-admin): more explicit disable otp test
2023-05-03 11:37:28 +02:00
Colin Darie
4c162a64d9
test: fix missing explicit rspec type
2023-05-03 11:35:32 +02:00
Colin Darie
ae88c1de6b
fix(devise): default config for devise and turbo stream as navigational format
2023-05-03 11:35:32 +02:00
Colin Darie
61ebb27e86
fix(redirect): allow other hosts when required
2023-05-03 11:35:31 +02:00
Nicolas Cavigneaux
7e0fbcf672
fix: ensure procedure used in remove_instructeur spec has routing_enabled set to true
2023-05-03 11:35:29 +02:00
Nicolas Cavigneaux
06296e933a
fix: super admin test where attribute was not reloaded
2023-05-03 11:35:28 +02:00
Nicolas Cavigneaux
faad8abaf6
fix: add missing file content type in fixture blob creation
2023-05-03 11:35:28 +02:00
Lisa Durand
1ab3dbb864
fix spec adding click on dropdown
2023-05-03 11:04:15 +02:00
Nicolas Cavigneaux
b478168e23
fix: remove hardcoded .pdf.prawn from describe calls since it no longer works
2023-05-03 10:10:38 +02:00
Nicolas Cavigneaux
e483bfbc76
fix: remove hardcoded .html.haml from render calls since it no longer works
2023-05-03 10:10:38 +02:00
Nicolas Cavigneaux
7e245c0b70
fix: add required argument for SMTP errors instanciation in application_mailer_spec
2023-05-03 10:10:38 +02:00
Martin
c8ab1e8e03
amelioration(dossier#submit_brouillon): ETQ usager, je souhaite pouvoir acceder aux champs en erreur facilement
2023-05-03 07:36:42 +02:00
Lisa Durand
cfce0075ce
fix view spec adding fake params
2023-05-02 19:24:30 +02:00
Lisa Durand
6113c0b75e
improve/add translations
2023-05-02 15:10:36 +02:00
Lisa Durand
24eca40f66
add from_depose_at filter
2023-05-02 10:32:38 +02:00
Lisa Durand
21ed6abcad
add from_created_at filter
2023-05-02 09:37:03 +02:00
Paul Chavard
46f9148fa4
Merge pull request #8984 from tchak/fix-api-entreprise-status
...
ETQ usager, je veux être avertie si l'API entreprise est HS
2023-04-28 14:25:02 +00:00
Paul Chavard
f2c1c071b4
Revert "Merge pull request #8899 from demarches-simplifiees/8738-validate-adresse-electronique"
...
This reverts commit d3eda28f356394996e7f
2023-04-28 16:10:20 +02:00
Lisa Durand
39f534b3d7
add states filter for usager
2023-04-28 15:28:04 +02:00
simon lehericey
47bae606f1
spec: remove weird now obsolete spec which pollute global namespace with logic helper
...
and make spread_architect tests fail
2023-04-28 10:42:09 +02:00
Paul Chavard
99abdf45e7
fix(api-entreprise): use new status endpoint
2023-04-27 22:39:44 +02:00
Lisa Durand
aac1cc7161
Merge pull request #8971 from demarches-simplifiees/add-filter-for-usagers
...
[fix] Pagination interface usager - onglets disparaissent si pas sur la page 1
2023-04-27 13:46:15 +00:00
Lisa Durand
b76c0a36e8
fix specs
2023-04-27 15:26:10 +02:00
Paul Chavard
1d10e59e63
fix(commune): fix ‘undefined’ departement codes
2023-04-27 12:07:43 +02:00
Paul Chavard
cb752d1857
fix(dossier): do not bypass depositaire check on modifier path
2023-04-27 09:52:10 +02:00
simon lehericey
86e0538425
keep test active_storage service
2023-04-26 22:46:16 +02:00
LeSim
4c5e903673
Merge pull request #8887 from demarches-simplifiees/8839-filter-by-siret
...
Filtrer les démarches par service
2023-04-26 19:44:08 +00:00
Paul Chavard
a41713c837
Merge pull request #8968 from demarches-simplifiees/fix_defaut_groupe_instructeur_again
...
Correctif: definit le groupe instructeur par defaut pour certaines procedure clonées
2023-04-26 17:59:13 +00:00
Paul Chavard
d3eda28f35
Merge pull request #8899 from demarches-simplifiees/8738-validate-adresse-electronique
...
ETQ usager, je veux que les champs de type adresse électronique soit validé
2023-04-26 16:52:02 +00:00
simon lehericey
fcb11e49e1
spec: fix flaky test
2023-04-26 16:51:10 +02:00
Lisa Durand
e393132fd8
Merge pull request #8936 from demarches-simplifiees/add-yes-no-column-for-instructeurs
...
[instructeur] ajout du nb de réponses oui/non aux avis dans le tableau d'une procedure
2023-04-26 09:05:58 +00:00
simon lehericey
0934a672fe
fix: defaut_groupe_instructeur for a cloned procedure from another admin without a group with default label
2023-04-26 10:52:31 +02:00
simon lehericey
dce2bf3209
spec: move procedure.clone in subject, to enable future before
2023-04-26 10:47:51 +02:00
LeSim
1a704f0479
Merge pull request #8966 from mfo/US/fix-avis-remind-with-question
...
ETQ instructeur, je peux relancer une demande d'avis meme si celui ci contient une question
2023-04-26 08:09:41 +00:00
LeSim
c8ed0532ed
Merge pull request #8948 from colinux/fix-geoarea-geometry-blank
...
ETQ Usager, champ carte: ne permet pas d'enregistrer une geometry null pour ne pas casser les exports
2023-04-26 10:15:25 +02:00
Colin Darie
21a829ec1e
fix(conditionel): error when using operator eq/not_eq with a multi dropdown
2023-04-26 09:58:00 +02:00
simon lehericey
f1bcb84832
fix: replace ds_eq operator by ds_include when targeted_champ is a multiple_drop_down_list
2023-04-26 09:37:03 +02:00
Martin
6a2d2ae0a7
bug(instructeurs/avis_controller#remind): ETQ instructeur, je peux relancer une demande d'avis meme si celui ci contient une question
2023-04-26 07:46:21 +02:00
Lisa Durand
26ff82dbe4
Merge branch 'main' of github.com:betagouv/demarches-simplifiees.fr into user-dashboard/add-alert-WIP-last-dossier
2023-04-25 13:01:40 +02:00
simon lehericey
ae1fd3f30b
linter
2023-04-24 10:59:42 +02:00
Martin
8c78008b4d
correctif(usager.depot-dossier): ETQ usager, les titres de section conditionnés etait visible meme si la condition n'etait pas remplie
2023-04-24 10:47:20 +02:00
simon lehericey
c189115757
fix defaut_groupe_instructeur for mismatching label
2023-04-24 10:16:09 +02:00
simon lehericey
995858e124
fix defaut_groupe_instructeur_id for (hidden) procedure with an (hidden) parent
2023-04-24 10:16:09 +02:00
Colin Darie
f7880352f0
Merge pull request #8941 from mfo/US/fixed-dossier-stalled-auto-processing
...
correctif(procedure.declarative): ETQ administrateur d'une procedure declarative, certains de mes dossiers restent en construction [ex: l'object storage est down, le dossier reste bloqué]
2023-04-22 16:13:01 +00:00
Colin Darie
25956c5141
fix(geoarea): geometry must not be nil
2023-04-22 16:23:39 +02:00
Martin
9dec6f1611
correctif(procedure.declarative): ETQ administrateur d'une procedure declarative, certains de mes dossiers restent en construction [ex: l'object storage est down, le dossier reste bloqué]
2023-04-21 15:45:45 +02:00
Colin Darie
925ebef551
Merge pull request #8934 from colinux/fix-markdown-in-url
...
ETQ utilisateur je ne veux pas perdre les _ au sein d'urls dans mes messages
2023-04-21 13:28:56 +00:00
Colin Darie
2775158052
Merge pull request #8943 from tchak/fix-dossier-can-create-new-dossiers
...
ETQ usager, je peux créer de nouveaux dossiers sur la démarche qui remplace la démarche fermée
2023-04-21 13:18:43 +00:00
simon lehericey
439447b343
fix defaut_groupe_instructeur_id and change dossier.groupe_instructeur_id
2023-04-21 15:08:07 +02:00
Colin Darie
fb54ca1469
fix(markdown): don't convert underscore within urls or emails
2023-04-21 14:07:10 +02:00
simon lehericey
a202a57988
fix: defaut_groupe_instructeur_id for a cloned procedure
2023-04-21 12:20:50 +02:00
Paul Chavard
52d63a1b02
fix(dossier): user can create new dossiers when closed procedure is replaced
2023-04-21 11:18:27 +01:00
Lisa Durand
b52a2ca972
fix spec
2023-04-21 10:21:54 +02:00
Martin
6739bfc665
bug(instructeurs.annotations): ETQ instructeurs, lorsque je saisie une autre valeur dans un champ de type choix simple, celle ci n'est pas sauvegardé
2023-04-21 09:35:16 +02:00
krichtof
c2461f230c
validate value for email champ
2023-04-20 18:27:02 +02:00
Paul Chavard
88f680a265
Merge pull request #8930 from tchak/fix-champ-commune-spaces
...
ETQ usager, je voudrai pouvoir remplir un code postal avec des espaces
2023-04-20 08:40:38 +00:00
Paul Chavard
586286cb08
Merge pull request #8916 from demarches-simplifiees/can-update-defaut-groupe-instructeur-2
...
feat(routage): permet de changer le groupe par défaut
2023-04-20 08:28:46 +00:00
Paul Chavard
4a2e499679
fix(commune): should accept postal codes with spaces
2023-04-20 10:16:48 +02:00
simon lehericey
e64ac79f05
tech(refactor): much nicer code, thx LeSim
...
root -> rooted_tree
depth_cach -> walk
smal refactor
comment
remove form for header_section
remove seen_at from header section
header_section: champ -> header_section
champ_subree: remove if not
remove root_depth use header_section_level_value instead
remove unused include
remove ChampTreeComponent
rename ChampsSubtreeComponent to SectionComponent
use TreeableConcern only in section component
remove fields_for_champ_component
champs -> tail
add split_section_champ helper
refactor(editable_champ::header_section): keep same interface everywhere
fix(repetition): add spec for SectionComponent on repetitions
2023-04-20 08:22:02 +02:00
Martin
cc2c856ec2
amelioration(bloc-repetable): wrap les blocs repetatable dans des fieldsets
2023-04-20 08:22:02 +02:00
Martin
88abefb370
tech(remaniement): isole la logique de rendu au champs_subtree_component
2023-04-20 08:22:02 +02:00
Martin
3b5d1bd55b
tech(remaniement): extraction du passage d'une liste de champs a un simili arbre
2023-04-20 08:22:02 +02:00
Martin
ad77b9321b
amelioration(formulaire-usager): groupes les champs suivant un titre de section dans une balise html de type <fieldset> de sorte a améliorer l'accessibilite de la plateforme
2023-04-20 08:22:02 +02:00
Martin
b9faa26560
amelioration(editeur-de-champs): permet de choisir un niveau de titre (de 1 à 3) pour les champs de type Champs::HeaderSectionChamp. Gère les erreurs dans le cas ou un administrateur supprimerait un HeaderSection qui casserait l'ordre des titre [ex: titre 1,2,3. et l'admin supprime le titre 1 et il reste que 2,3].
2023-04-20 08:22:02 +02:00
Paul Chavard
418d3b55d0
feat(stats): give access to stats on closed procedures
2023-04-19 18:31:58 +02:00
Colin Darie
9728493bda
Merge pull request #8924 from colinux/rubocop-upgrades
...
Tech: update rubocop, active nouveaux cops Rails/*
2023-04-19 13:37:10 +00:00
Eric Leroy-Terquem
aecd7559d2
feat(groupe instructeur): cannot disable default groupe instructeur
2023-04-19 13:52:42 +02:00
Eric Leroy-Terquem
09b05550ab
feat(groupe instructeur): cannot delete defaut_groupe_instructeur
2023-04-19 13:52:42 +02:00
simon lehericey
79131cc294
fix spec
2023-04-19 13:52:42 +02:00
simon lehericey
b38470368b
feat(routing): can change defaut groupe
2023-04-19 13:52:41 +02:00
mfo
73184c6dac
Merge pull request #8907 from mfo/US/dolist-silence-some-errors
...
amelioration(dolist): ne log erreurs pas les erreurs dans sentry lorsque le contact chez dolist est injoingable ou hardbounce
2023-04-19 11:49:01 +00:00
Colin Darie
516ffc68ba
chore(rubocop): fix Rails/I18nLocaleAssignment
2023-04-19 12:55:14 +02:00
Colin Darie
7aba5ccc3e
chore(rubocop): fix Rails/DurationArithmetic
2023-04-19 12:55:13 +02:00
Colin Darie
999f06075b
chore(rubocop): fix Rails/ResponseParsedBody
2023-04-19 12:55:13 +02:00
Colin Darie
b273e7b67e
chore(rubocop): fix Rails/RootPathnameMethods and assimiled cops
2023-04-19 12:55:13 +02:00
Paul Chavard
05cfb4055d
fix(dossier): improuve dossier state display
2023-04-19 12:27:16 +02:00
Paul Chavard
7bf31c6278
Merge pull request #8850 from tchak/feat-refactor-drop-downs
...
Simplifie l'implémentation des champs "liste d'options" et "listes d'options liées"
2023-04-19 09:59:10 +00:00
Martin
8fa2bbb67d
amelioration(dolist): ne log erreurs pas les erreurs dans sentry lorsque le contact chez dolist est injoingable ou hardbounce
2023-04-19 11:22:13 +02:00
github-merge-queue[bot]
a286af8a70
Merge pull request #8918 from tchak/graphql-add-error-codes
...
ETQ intégrateur API, je voudrais avoir des codes d'erreur plus précis
2023-04-19 09:00:32 +00:00
Paul Chavard
0912a30eb0
feat(dossier): use turbo on select with other
2023-04-18 15:24:23 +02:00
Paul Chavard
ae1ec87397
feat(graphql): add code to timeout errors
2023-04-18 15:22:11 +02:00
Paul Chavard
f70532a844
feat(graphql): global not found error handling
2023-04-18 15:22:11 +02:00
Paul Chavard
fbae6d941d
feat(graphql): add error codes to graphql errors
2023-04-18 15:22:11 +02:00
Paul Chavard
2a09f1d505
fix(graphql): return empty arrays from loaders when loading collections
2023-04-18 15:20:43 +02:00
Lisa Durand
c565ed415b
change scope and alert location after UI modification
2023-04-18 12:03:10 +02:00
Paul Chavard
bf6cc25063
feat(graphql): expose pendingDeletedDossiers on groupe instructeur
2023-04-17 18:43:00 +02:00
LeSim
c252748833
Merge pull request #8836 from demarches-simplifiees/improve-routing-rules-ux
...
feat(routing): nicer and safer ?
2023-04-17 08:23:15 +00:00
Paul Chavard
5abb6a8f12
chore(spec): remove memory store cache from tests
2023-04-13 13:10:23 +02:00
Paul Chavard
98caf41a36
fix(dossier): find communes outside of departement
2023-04-13 13:09:56 +02:00
Paul Chavard
21b548d32b
fix(dossier): delete all champs starting with children
2023-04-13 11:08:10 +02:00
simon lehericey
a5200a569f
feat(routing): task to backfill procedure.defaut_groupe_instructeur_id
2023-04-13 10:44:06 +02:00
simon lehericey
f6948cfd5e
feat(routing): record first groupe as default_groupe_instructeur
2023-04-13 10:36:42 +02:00
simon lehericey
c02319aa56
feat(routing): reset value if target as changed
2023-04-13 10:28:53 +02:00
simon lehericey
8b832396a3
feat(routing): server side: prevent changing tdc type if used for routing
2023-04-13 10:28:52 +02:00
Eric Leroy-Terquem
9ea75a5bd1
feat(routing): ui side: prevent changing tdc type if used for routing
2023-04-13 10:28:52 +02:00
simon lehericey
c1f67499aa
feat(routing): server side: prevent tdc deletion if used for routing
2023-04-13 10:28:52 +02:00
simon lehericey
213d463ff4
feat(routing): small UI polish
2023-04-13 10:28:52 +02:00
Eric Leroy-Terquem
c4d64d9775
feat(routing): add message if no type de champs routable
2023-04-13 10:28:52 +02:00
simon lehericey
80b5f6bc1d
feat(champ_component): add errors banner
2023-04-13 10:28:52 +02:00
simon lehericey
362c220587
fix(champ_component): enable preview
2023-04-13 10:28:52 +02:00
krichtof
78938b5a07
filter demarches by siret service
2023-04-12 18:53:57 +02:00
Lisa Durand
bc3e67ab94
add alert on user dashboard to edit last editable dossier
2023-04-11 15:50:17 +02:00
Paul Chavard
def32a3615
chore(dossier): remove fallback from commune champ
2023-04-11 10:49:01 +02:00
Colin Darie
54c9690289
Merge pull request #8886 from colinux/fix-delete-admin-without-published-procedure
...
fix(admin): peut supprimer un admin sans démarche publiée, sans service
2023-04-11 07:17:54 +00:00
Colin Darie
a413d2fa9c
fix(admin): can delete an admin without published procedure
2023-04-07 16:10:10 +02:00
Paul Chavard
a6e3ea4839
fix(dossier): normalize champs commune data
2023-04-07 16:02:13 +02:00
Paul Chavard
0d1aa5cf96
Merge pull request #8867 from tchak/feat-graphql-commune-type
...
feat(graphql): expose commune and departement information on address
2023-04-07 10:35:32 +00:00
Paul Chavard
aaae3f461d
feat(graphql): expose commune and departement information on address
2023-04-07 12:13:41 +02:00
Paul Chavard
207ce21327
fix(dossier): instructeur actions should be buttons and not links
2023-04-07 12:12:15 +02:00
Paul Chavard
0b95a912c6
Merge pull request #8858 from tchak/feat-refactor-dossier-link-champ
...
feat(dossier): use turbo to select linked dossier
2023-04-07 08:49:11 +00:00
Paul Chavard
79fee39888
Merge pull request #8872 from tchak/fix-champ-multiselect
...
fix(dossier): selecting blank option should not empty selection
2023-04-06 14:32:35 +00:00
Paul Chavard
ffb332159f
fix(dossier): selecting blank option should not empty selection
2023-04-06 15:24:52 +02:00
Paul Chavard
a2f7d1df72
fix(graphql): pendingDeletedSince should not crash
2023-04-06 15:07:48 +02:00
Paul Chavard
6511836f2d
Merge pull request #8865 from tchak/graphql-improuve-logs
...
feat(graphql): improuve logs
2023-04-05 12:34:36 +00:00
Paul Chavard
a5733002ed
feat(graphql): improuve logs
2023-04-05 13:56:26 +02:00
Paul Chavard
b8f639721e
Merge pull request #8864 from colinux/fix-date-not-parseable
...
fix(date): ne crash pas lorsqu'un champ date n'as pas une date standard
2023-04-05 11:48:48 +00:00
Colin Darie
5e62aa7d21
fix(date): don't crash when date value is not parseable
2023-04-05 12:42:28 +02:00
Paul Chavard
52c8b0b297
feat(dossier): use turbo to select linked dossier
2023-04-05 11:40:03 +02:00
Paul Chavard
dee0952b2a
fix(graphql): demandeur personne morale can be in degraded mode
2023-04-05 11:20:18 +02:00
Paul Chavard
a778e1083b
fix(graphql): return better errors when dossiers cannot change state
2023-04-04 17:24:30 +02:00
Martin
6039539727
bug(administrateur.merge): la fusion de compte entre admin devrait aussi dissocier les services des procedures supprimées
2023-04-04 16:29:24 +02:00
Paul Chavard
2a48228552
fix(dossier): improuve commune champ rendering in pdf
2023-04-04 16:01:16 +02:00
Paul Chavard
12f0c03bac
Merge pull request #8847 from tchak/feat-improuve-dossier-remove
...
fix(dossier): an invited user can remove (leave) a dossier
2023-04-04 13:10:18 +00:00
mfo
2c32e38383
Merge pull request #8851 from demarches-simplifiees/fix_condtion_check_on_children
...
fix(condition_check_on_children): give proper upper tdc to child cond…
2023-04-04 08:48:02 +00:00
simon lehericey
fd927fd116
fix(condition_check_on_children): give proper upper tdc to child condition check
2023-04-04 10:24:11 +02:00
Lisa Durand
dde64415ae
Merge pull request #8845 from demarches-simplifiees/remove-dossiers-termines-from-avis-views
...
[bug] retirer les notifications + compteur des avis pour les dossiers terminés
2023-04-04 08:20:48 +00:00
Paul Chavard
0864666d0a
fix(dossier): an invited user can remove (leave) a dossier
2023-04-03 20:10:44 +02:00
Lisa Durand
2f012578eb
remove dossier termine from avis views
2023-04-03 18:20:17 +02:00
Paul Chavard
fce78bbf30
feat(dossier): multiselect without react
2023-04-03 16:54:50 +02:00
Paul Chavard
b3f58a24cb
fix(dossier): add value_json to dossier projection
2023-04-03 16:25:32 +02:00
Paul Chavard
8945777b56
Merge pull request #8835 from tchak/fix-champ-commune
...
fix(commune): improuve label and error message
2023-04-03 09:56:57 +00:00
Paul Chavard
b0673c0127
Merge pull request #8837 from demarches-simplifiees/bug-special-character-in-email
...
[fix] bug dans le sujet des mails de notification si le libelle de la procedure contient un apostrophe
2023-04-03 09:39:13 +00:00
Paul Chavard
ed62d171ce
fix(commune): improuve label and error message
2023-04-03 11:24:32 +02:00
mfo
4336184fc8
Merge pull request #8833 from mfo/US/fix-valid-conditions-on-repetition
...
correctif(revision.validation-des-conditions): les conditions dans un bloc répétable ne remontenpt pas dans le composant ErrorsSummary
2023-03-31 15:03:12 +00:00
Lisa Durand
e1260a3df8
fix wrong encoding of special character in email notification subject
2023-03-31 16:58:41 +02:00
mfo
54d88e7dd0
Merge pull request #8699 from mfo/US/8661
...
a11y(bloc-repetable): amélioration des interactions avec les répétitions d'un bloc répétable
2023-03-31 14:39:23 +00:00
LeSim
b003fd8be8
Merge pull request #8774 from E-L-T/add-routing-to-groupe-instructeurs
...
Add routing rules to groupe instructeurs
2023-03-31 10:16:51 +00:00
Martin
92f5e7663e
bug(validation-des-conditions): les conditions dans un bloc repetable ne remontent pas dans la liste des erreurs de la page formulaire ou sur les changements du formulaire
2023-03-31 10:31:34 +02:00
Martin
a3f1e1926a
a11y(bloc-repetable): ETQ usager qui navigue au clavier, lorsque j'ajoute un champs repetable, le focus vient sur le 1er champs du bloc repetable
2023-03-31 08:51:39 +02:00
Lisa Durand
630742ee94
fix test
2023-03-30 17:54:14 +02:00
Colin Darie
e36dc19cc4
fix(explication): render collapsible text into collapse element
2023-03-30 12:46:31 +02:00
simon lehericey
41cb62b5c7
add full system spec
2023-03-30 12:31:48 +02:00
Eric Leroy-Terquem
6f6bbd6ca1
feat(routing): put routing logic behind a feature flag
2023-03-30 10:52:53 +02:00
Eric Leroy-Terquem
6dfe54479d
test(routing): can route from a dropdown list
2023-03-30 10:51:48 +02:00
simon lehericey
3cede55d41
feat(routing): add routing engine
2023-03-30 10:51:20 +02:00
simon lehericey
b93e3776c4
feat(routing): add controller
2023-03-30 10:51:20 +02:00
simon lehericey
f6738be454
fix(spec): small refactor
2023-03-30 10:51:20 +02:00
Paul Chavard
01602101f1
spec(commune): improuve spec
2023-03-29 15:42:33 +02:00
Paul Chavard
00fc2f519f
chore(spec): fix commune spec
2023-03-29 15:42:33 +02:00
Colin Darie
f274748acd
Merge pull request #8820 from colinux/fix-autolink-renderer
...
Fix: autolink manuellement les liens qui ne sont pas des urls
2023-03-29 15:42:33 +02:00
mfo
8efd191e0f
Merge pull request #8817 from mfo/US/fix-expert-export
...
correctif(export.pdf): ETQ expert, lorsque j'exporte un dossier au format PDF, celui ci contenient les avis non confidentiels ainsi que mes avis
2023-03-29 15:42:33 +02:00
Colin Darie
49e016ba58
fix: handle all autolinks manually
...
On ne peut pas appeler super() qui est en méthode en C, pas en ruby.
Donc on doit gérer manuellement les cas possibles.
2023-03-29 15:42:33 +02:00
Colin Darie
6ddbda34a2
fix(avis): don't list question_answer radios on empty question
2023-03-29 15:42:33 +02:00
Martin
c6e9674de2
correctif(export.pdf): ETQ expert, lorsque j'exporte un dossier au format PDF, celui ci contenient les avis non confidentiels ainsi que mes avis
2023-03-28 17:16:34 +02:00
Martin
4f9c45c489
bug(export.pdf): ETQ expert, lorsque j'exporte un dossier, celui ci devrait contenir les avis non confidentiels ainsi que mes avis
2023-03-28 16:55:12 +02:00
Paul Chavard
76da68c3fb
feat(commune): prefill by postal code and insee
2023-03-28 16:34:19 +02:00
Paul Chavard
a4e96d5256
feat(apigeo): add communes_by_postal_code method
2023-03-28 16:34:19 +02:00
Colin Darie
4865fb368f
fix(avis): don't list question_answer radios on empty question
2023-03-28 15:38:13 +02:00
Colin Darie
b26f477fe1
Merge pull request #8810 from demarches-simplifiees/ask-avis-remove-specific-css-v2
...
[UX] améliorer UX de la demande d'avis - partie 2 CSS
2023-03-27 14:02:13 +00:00
Lisa Durand
0424f9dff8
merge avis_list view expert and instructeur
2023-03-27 14:59:49 +02:00
Kara Diaby
4a13c64b38
tests
2023-03-27 14:14:18 +02:00
Lisa Durand
d079f3ac98
Merge pull request #8770 from demarches-simplifiees/ask-question-in-avis-ux-part
...
[UX] améliorer UX de la demande d'avis
2023-03-24 10:50:33 +00:00
Paul Chavard
275150d727
feat(graphql): expose pendingDeletedDossiers
...
fix #8785
2023-03-22 19:40:43 +01:00
Colin Darie
a96ccba92c
Merge pull request #8798 from colinux/fix-simple-renderer-missing-title
...
a11y: ajoute l'attribut title précisant l'ouverture dans un nouvel onglet dans le simple renderer
2023-03-22 15:47:17 +00:00
Colin Darie
40a303f6a6
fix(a11y): add a title in simple renderer links and autolinks
...
Closes #8095
2023-03-22 14:05:06 +01:00
Paul Chavard
6b8f7a0c73
Merge pull request #8795 from tchak/fix-flaky-test
...
fix(api_token): improuve flaky test
2023-03-22 11:01:25 +00:00
Lisa Durand
aa9c94a20e
fix display in view and export if answer is 'no'
2023-03-22 11:56:52 +01:00
Paul Chavard
ee1df3f05f
fix(dossier): fix rebasing submitted dossiers private champs type changes
2023-03-22 11:43:08 +01:00
Paul Chavard
48733a1d15
fix(api_token): improuve flaky test
2023-03-22 11:18:49 +01:00
Lisa Durand
4a2982dc37
fix tests and linter
2023-03-22 09:30:26 +01:00
Lisa Durand
c1b5daadef
remove unused view and routes from instructeurs avis
2023-03-22 09:30:26 +01:00
Lisa Durand
f27e362cae
fix validation of yes-no question in avis
2023-03-21 17:07:05 +01:00
Colin Darie
954652fcf5
fix(champ): may fix pg deadlocks: autosave already saves value at the same time
2023-03-20 14:32:14 +01:00
Lisa Durand
893ee5801e
Merge pull request #8743 from demarches-simplifiees/ask-question-in-avis
...
[instructeurs] Je peux poser une question dans une demande d'avis
2023-03-17 15:10:51 +00:00
simon lehericey
ca63cc34ab
feat(token depreciation): add mail alert
2023-03-16 16:16:45 +01:00
Lisa Durand
ee2f795dec
pr feedbacks - add validation for yes/no answer - improve locales use
2023-03-16 11:32:05 +01:00
Lisa Durand
3b3d5182bf
add new column to spreadsheets
2023-03-16 11:32:05 +01:00
Lisa Durand
38c84115e6
reorganise file order for more consistency
2023-03-16 11:32:05 +01:00
Lisa Durand
eddd7a2192
add flash alert if email field empty
2023-03-16 11:32:05 +01:00
Lisa Durand
01afa998b6
add specs
2023-03-16 11:32:05 +01:00
Paul Chavard
4ba3c0e650
fix(graphql): return empty array when no attachments
2023-03-16 10:59:08 +01:00
Paul Chavard
8ee13f1719
feat(api_token): add allowed_procedure_ids and write_access
2023-03-15 19:09:49 +01:00
Colin Darie
b628cf85cd
feat(siret): render siret formatted like INSEE
2023-03-15 12:43:56 +01:00
Colin Darie
37afd142cb
fix(entreprise): don't leak entreprise name if it's not diffusable
2023-03-15 12:43:56 +01:00
Paul Chavard
cbaa77fca7
feat(annotations): activate autosave
2023-03-14 15:22:13 +01:00
mfo
df05c4fbc5
Merge pull request #8754 from mfo/US/fix-duree-conservation-dans-ds
...
correctif(procedure.maj): quand la duree conservation dans ds est supérieur a 12, on ne pouvait plus mettre a jour la procedure
2023-03-10 09:28:31 +00:00
Lisa Durand
1f03130d52
Merge pull request #8728 from demarches-simplifiees/revoke-usager-transfert-demande
...
[usager] peut révoquer une demande de transfert
2023-03-10 09:21:59 +00:00
Martin
4ac498392c
bug(procedure.maj): impossible de mettre a jour une procedure avec une duree de conservation supérieur a 12 mois
2023-03-10 10:16:36 +01:00
Colin Darie
6a2a7fa2d0
Merge pull request #8753 from colinux/fix-auto-numering-in-repetition
...
Fix(dossier): ne numérote pas automatiquement les titres de section dans les répétitions
2023-03-09 15:41:57 +00:00
Colin Darie
88efef0718
Merge pull request #8749 from colinux/fix-tags-persistence
...
Administrateur: ne supprime pas les tags quand on n'interagit pas avec la liste de sélection
2023-03-09 15:25:15 +00:00
Colin Darie
6243e5fb92
Merge pull request #8748 from colinux/fix-clone-estimated-dossier
...
Administrateur: le clone d'une démarche ne copie pas le cache du nombre de dossiers
2023-03-09 15:25:08 +00:00
Colin Darie
f33d192142
fix(dossier): don't auto-number header sections in repetitions
2023-03-09 16:15:56 +01:00
Lisa Durand
6ba47b731b
refacto destroy action and add spec for unauthorized user
2023-03-09 14:58:47 +01:00
Lisa Durand
efcb783c8c
fix system spec with trad
2023-03-09 14:58:47 +01:00
Lisa Durand
3d5bf40c0f
allow transfer sender to revoke a transfer
2023-03-09 14:57:59 +01:00
Eric Leroy-Terquem
72b6dacfbd
fix(API): remove notification to group when instructeurs removed
2023-03-08 11:59:58 +01:00
Eric Leroy-Terquem
a150aa33ef
feat(GroupeInstructeurSupprimerInstructeurs): add notification for removed instructeurs via API
2023-03-08 11:59:58 +01:00
Eric Leroy-Terquem
ac0d7a67a1
feat(GroupeInstructeurAjouterInstructeurs): add notification for added instructeurs via API
2023-03-08 11:59:58 +01:00
Eric Leroy-Terquem
b2f3a7af4c
feat(GroupeInstructeurSupprimerInstructeurs): enable emailing for unrouted procedures
2023-03-08 11:59:55 +01:00
Colin Darie
c112018ec3
fix(administrateur): tags persistence when non interacting with tags combobox
2023-03-08 11:27:31 +01:00
Eric Leroy-Terquem
9e0753a710
fix(groupe instructeur mailer): do not notify if no added instructeurs
2023-03-08 11:03:33 +01:00
Eric Leroy-Terquem
f317f28ff5
test(groupe instructeurs): use right data (a routed procedure has at
...
least two active groups)
2023-03-08 10:48:02 +01:00
Eric Leroy-Terquem
e1906febcc
feat(groupe instructeur): can enable routing from import
2023-03-08 10:48:02 +01:00
Eric Leroy-Terquem
9f0f5b0dc5
feat(groupe instructeur): allow import of many groups when procedure is not routed yet
2023-03-08 10:48:02 +01:00
Colin Darie
d6887f8aa4
fix(procedure): clone reset estimated_dossiers_count
2023-03-07 19:11:30 +01:00
Martin
401ead47f0
bug(dossier.export.pdf): l'export au format pdf d'un dossier ayant un champ de type repetition contenant un titre est bizarre
2023-03-07 07:00:28 +01:00
mfo
6e86a0e622
Merge pull request #8744 from mfo/US/8737/correctif-export-sans-avis-expert
...
correctif(export.zip): integre les avis dans l'export au format pdf du dossier
2023-03-06 15:35:57 +00:00
Colin Darie
d87495c5fc
Merge pull request #8723 from colinux/fix-failing-jobs
...
Attempts to fix timeout and errors cron jobs
2023-03-06 14:02:55 +00:00
Martin
c470cca9ab
correctif(export.zip): integre les avis dans l'export au format pdf du dossier
2023-03-06 14:58:26 +01:00
Colin Darie
43613009d6
fix(job): Cron::WeeklyOverviewJob simplified and respect dolist API rate limiting
2023-03-06 14:39:55 +01:00
Lisa Durand
875d5b7ce5
Merge pull request #8710 from demarches-simplifiees/use-DSFR-class-badge-for-dossier-states
...
[Design] Implémentation des classes DSFR pour les badges d'état des dossiers
2023-03-06 11:45:42 +00:00
Lisa Durand
d65050ff44
Merge pull request #8701 from demarches-simplifiees/improve-instruction-dropdown
...
[instructeurs] amelioration UX du bouton d'instruction
2023-03-06 10:45:00 +00:00
Colin Darie
35674838d1
Merge pull request #8720 from demarches-simplifiees/feat/8549
...
ETQ administrateur, je souhaite filtrer avec plusieurs tags
2023-03-06 10:19:22 +00:00
Colin Darie
8722ee028d
Merge pull request #8729 from colinux/fix-groupe-instructeur-wrongly-invalid
...
fix(groupe-instructeur): un groupe instructeur inactif est valide tant qu'il reste un groupe actif
2023-03-06 10:13:16 +00:00
Kara Diaby
4ea7bb2f1c
tests
2023-03-03 11:50:47 +01:00
Lisa Durand
72667cb49a
fix tests
2023-03-02 16:37:05 +01:00
Lisa Durand
3aac56042e
fix tests
2023-03-02 16:34:58 +01:00
Lisa Durand
7130ea7e99
fix specs
2023-03-02 16:34:58 +01:00
Colin Darie
20d4a8153d
fix(groupe-instructeur): a closed groupe with an active groupe is a valid record
2023-03-02 16:34:18 +01:00
Damien Le Thiec
687c05e6d1
Merge pull request #8622 from demarches-simplifiees/fix/stored_query_issue
...
Dossier prefill get without stored queries
2023-03-02 14:01:04 +00:00
Lisa Durand
54f17ad3c7
Merge pull request #8630 from demarches-simplifiees/harmonize-actions-for-instructeurs
...
[instructeurs] Uniformiser les actions pour les instructeurs sur la page tableau et dossier
2023-03-02 13:28:23 +00:00
Paul Chavard
6647be216b
Merge pull request #8722 from E-L-T/do-not-notify-group-when-instructeurs-removed
...
feat(groupe instructeur): do not notify group when instructeurs removed
2023-03-02 12:51:23 +00:00
Paul Chavard
ac00a91984
fix(graphql): fix etablissement in degraded mode
2023-03-02 13:32:17 +01:00
Eric Leroy-Terquem
f6c4986e86
feat(groupe instructeur mailer): do not notify group when instructeurs removed
2023-03-02 09:46:58 +01:00
sebastiencarceles
157a2d8cae
feature spec cover
2023-03-01 14:05:18 +01:00
sebastiencarceles
00fa8dc895
transform value to also populate external id
2023-03-01 14:03:54 +01:00
sebastiencarceles
a7b21fcd7c
let address champ be prefillable
2023-03-01 14:03:54 +01:00
Christophe Robillard
6851a9ee52
falsify opendata flag for some procedures
...
`procedures:falsify_opendata_procedures` rake task allows to falsify
opndata flag for procedures listed in csv file given in input (with only
one column : id column)
2023-03-01 11:47:11 +01:00
krichtof
5840c8c7f9
Merge pull request #8711 from demarches-simplifiees/8708-demarches-publiques
...
Ne pas publier le descriptif de toutes les procedures sur datagouv
2023-03-01 10:09:47 +00:00
Damien Le Thiec
8a7cb3f1fe
Merge branch 'main' into fix/stored_query_issue
2023-03-01 10:22:40 +01:00
Damien Le Thiec
01f142183e
Add and correct tests
2023-03-01 10:21:22 +01:00
Sébastien Carceles
3c0eaae24c
Merge pull request #8625 from demarches-simplifiees/prefill/annuaire-education
...
feat(dossier): prefill annuaire education champ
2023-03-01 08:20:59 +00:00
Paul Chavard
d3f504271c
Merge branch 'harmonize-actions-for-instructeurs' of github.com:demarches-simplifiees/demarches-simplifiees.fr into harmonize-actions-for-instructeurs
2023-02-28 17:28:36 +01:00
Paul Chavard
d8ee4cb360
fix(test): dossiers_controller_spec
2023-02-28 17:28:17 +01:00
Christophe Robillard
9ff88db48c
publish only some opendata procedures for datagouv
...
- only published or closed procedures
- only procedures with flag opendata
- only procedures with 4 or more dossiers
- only procedures without word "mail" in lien_site_web
- only procedures without word "intra" in lien_site_web
2023-02-28 17:02:08 +01:00
Paul Chavard
294a5135ce
feat(public/api): add dossier state api
2023-02-28 16:35:25 +01:00
sebastiencarceles
f52554b5a3
review: update value with async fetch
...
1 - spec cover the job which fetches external data
2 - refactor the job with guard clauses
3 - delegate update operation to the champ itself
4 - annuaire education: override the update operation
to let the value be populated by the fetched data
5 - prefilling: don't fetch data synchronously
2023-02-28 14:53:08 +01:00
sebastiencarceles
8b25503f7e
feature spec cover
2023-02-28 14:23:38 +01:00
sebastiencarceles
447ea1b9a8
don't prefill with an incorrect value
2023-02-28 14:23:38 +01:00
sebastiencarceles
d7bfb9dc18
enrich value from education api
2023-02-28 14:23:38 +01:00
sebastiencarceles
71f1e785ab
let annuaire education champ be prefillable
2023-02-28 13:26:35 +01:00
Colin Darie
7e13d58db2
Merge pull request #8703 from govpf/feature/fix-dossier-controller-spec
...
Fix dossier controller spec
2023-02-28 12:11:30 +00:00
krichtof
dee499d386
Merge pull request #8706 from demarches-simplifiees/all_demarches_even_without_zones
...
liste toutes les démarches, même celles non associées à des zones
2023-02-28 10:58:07 +00:00
sebastiencarceles
a08bb1bddc
fix epci: all possible values
2023-02-28 08:37:52 +01:00
sebastiencarceles
2ae2d99e93
fix communes: all possible values
2023-02-28 08:36:43 +01:00
Lisa Durand
07bb27a3af
add repasser_en_instruction to dossiers expirants
2023-02-27 17:57:46 +01:00
Colin Darie
ae93d3927e
refactor(dossier): extract sections logic in a concern
2023-02-27 17:29:22 +01:00
Colin Darie
1981bfc88e
feat(tdc): strip libelle so header section titles always start with something
2023-02-27 17:29:22 +01:00
Colin Darie
d7880f7e58
feat(dossier/pdf): header sections numbering
2023-02-27 17:29:22 +01:00
Colin Darie
3de089d6c7
fix(conditional): dynamic title counters using css
...
Closes #8086
2023-02-27 17:29:22 +01:00
Paul Chavard
7076d6d99e
fix(turbo): rerender only top part of the header
2023-02-27 16:06:11 +01:00
sebastiencarceles
8f12467168
feature spec cover
2023-02-27 15:18:37 +01:00
sebastiencarceles
35f4874b69
allow integers only
2023-02-27 15:16:40 +01:00
sebastiencarceles
13229158bd
let dossier link champ be prefillable
2023-02-27 15:14:39 +01:00
sebastiencarceles
1caf56d943
fix lint
2023-02-27 14:48:46 +01:00
sebastiencarceles
efd5464bd5
cover use case with feature spec
2023-02-27 14:43:48 +01:00
sebastiencarceles
39545671f3
refacto: better error management
2023-02-27 14:35:11 +01:00
sebastiencarceles
33fa40eda2
don't clean the rna champ value
...
Cleaning the value is useless, when fetching the association,
as the value will be re-written by the dossier update, when the user
fills in the dossier.
Furthermore we need the value to persist when prefilling the champ.
2023-02-27 14:35:11 +01:00
Sébastien Carceles
7e55aca107
allow rna prefill
2023-02-27 14:35:11 +01:00
sebastiencarceles
7d65a34bc6
rna champ can fetch it's own association
2023-02-27 14:31:58 +01:00
Lisa Durand
636e6aa6cb
fix broken tabs with turbostream
2023-02-27 14:30:10 +01:00
sebastiencarceles
becf4da70a
fix raison social fetch
2023-02-27 13:54:35 +01:00
sebastiencarceles
498e5d7487
cover use case with a feature spec
2023-02-27 13:53:18 +01:00
sebastiencarceles
5dce401a14
review: add missing spec
2023-02-27 13:47:56 +01:00
sebastiencarceles
30eef3e128
review: detailled error message
2023-02-27 13:45:16 +01:00
Sébastien Carceles
2ad4e4c01f
refacto: better error management
2023-02-27 13:45:16 +01:00
Sébastien Carceles
b6c74b0e83
fetch etablissement when editing the dossier
2023-02-27 13:45:16 +01:00
Sébastien Carceles
df2eaa9542
don't clean the siret champ value
...
Cleaning the value is useless, when fetching the etablissement,
as the value will be re-written by the dossier update, when the user
fills in the dossier.
2023-02-27 13:45:16 +01:00
Sébastien Carceles
3eb76d8a43
allow siret prefilling
2023-02-27 13:45:16 +01:00
Sébastien Carceles
5876dab096
siret champ can fetch it's own etablissement
2023-02-27 13:39:31 +01:00
sebastiencarceles
bd1bed940c
feature spec cover
2023-02-27 12:20:11 +01:00
sebastiencarceles
da6ce0f528
add example
2023-02-27 12:20:11 +01:00
sebastiencarceles
76c9d1ada5
add possible values
2023-02-27 11:53:25 +01:00
sebastiencarceles
40b7ea3af2
transform the input value to assignable attributes
2023-02-27 11:51:24 +01:00
sebastiencarceles
46091cb6b4
let communes champ be prefillable
2023-02-27 11:50:25 +01:00
sebastiencarceles
83802a507a
return communes with the APIGeoService
2023-02-27 11:47:34 +01:00
Damien Le Thiec
67bbacbb05
Merge pull request #8513 from demarches-simplifiees/feature/prefill_repetible
...
Prefill repeatable
2023-02-27 09:58:53 +00:00
Christian Lautier
704dbf94db
Fix dossier controller spec
2023-02-25 08:32:21 -10:00
Lisa Durand
6487e2c27e
implement turbostream back for state change in dossier view
2023-02-24 17:54:53 +01:00
Christophe Robillard
1d6c2fd7eb
display procedures without zones
2023-02-24 17:27:28 +01:00
mfo
3b51654024
Merge pull request #8680 from tchak/more-communes
...
feat(apigeo): enable all zones on departements api
2023-02-24 10:49:46 +01:00
Paul Chavard
bdb15aaa4a
feat(apigeo): enable all zones on departements api
2023-02-23 17:28:02 +01:00
Paul Chavard
21f47dcb01
feat(procedure): include deleted dossiers in stats
2023-02-23 17:14:25 +01:00
Lisa Durand
b03748d3dd
fix actions rules for archived and expirant dossiers
2023-02-23 17:03:55 +01:00
Paul Chavard
eb3039aeca
fix(demarche): exclude preview and deleted dossiers from stats
2023-02-23 16:38:40 +01:00
Lisa Durand
76947a5ccf
add mention if user_deleted and move dossier info back to info_generales
2023-02-23 16:05:43 +01:00
Lisa Durand
90a7ecef52
rename state button to instruction button
2023-02-23 16:05:38 +01:00
Martin
a584279020
chore(deadcode): drop deadcode
2023-02-23 15:23:20 +01:00
Martin
c00c4936b2
correctif(a11y): traite aussi les avis d'expert avec la nouvelle methode de rendu des textes saisis par des admin/instructeur/expert
2023-02-23 15:23:20 +01:00
Martin
4d8b4e078b
amelioration(a11y): extrait un nouveau composant pour rendre du texte saisi par un humain accessible
2023-02-23 15:23:20 +01:00
Eric Leroy-Terquem
4ea1d7d33b
feat(groupe instructeurs import): notify added instructeurs
2023-02-23 10:56:55 +01:00
Eric Leroy-Terquem
a6e01d98ea
feat(instructeurs import): notify added instructeurs
2023-02-23 10:56:55 +01:00
Damien Le Thiec
731cd56594
Merge branch 'main' into feature/prefill_repetible
2023-02-22 19:49:06 +01:00
Damien Le Thiec
ca29079c27
Fix rubocop
2023-02-22 19:40:52 +01:00
Damien Le Thiec
fbe4fe251a
Fix format prefill repetition
2023-02-22 19:32:25 +01:00
Lisa Durand
fddcce8b7b
fix specs
2023-02-22 18:17:06 +01:00
Sébastien Carceles
28c6fd8cfc
Improve EPCI specs ( #8634 )
...
* fix nonsense spec
* refactor spec
2023-02-22 09:16:58 +00:00
Eric Leroy-Terquem
25df48f255
feat(groupe_instructeurs): import instructeurs in unrouted procedure with a proper CSV
2023-02-22 09:49:26 +01:00
Eric Leroy-Terquem
3aa7793ed3
fix(groupe_instructeurs): can parse a monocolumn csv file
2023-02-22 09:49:26 +01:00
Colin Darie
8a3bb0c38e
fix(instructeurs): combobox layout in "personnes impliquees" tab
...
Closes #8527
2023-02-21 18:20:30 +01:00
Damien Le Thiec
cc2ec995d6
Fix tests
2023-02-21 17:32:24 +01:00
Paul Chavard
9c0cd8979a
fix(graphql): context should correctly preserve demarche authorization state
2023-02-21 16:06:39 +01:00
Damien Le Thiec
2052bc7840
Remove dependency type_de_champ -> procedure
2023-02-21 16:00:58 +01:00
Paul Chavard
e56d51e0f6
fix(graphql): fix demarcheUrl
2023-02-21 10:57:43 +01:00
Christophe Robillard
c5acd82e6e
update dossiers count when passing to construction
2023-02-21 10:06:07 +01:00
Christophe Robillard
bd92291f8a
cache dossiers count
2023-02-21 10:06:07 +01:00
Martin
eca44ce60e
correctif(a11y): il est recommandé d'utilser un boutton pour la suppression d'un element. le bouton etant deja dans un form, nous ne pouvons pas utiliser le button_to. Extraction d'un form pour soumettre la suppression des pjs par des input pointant sur ce form
...
Update app/components/attachment/edit_component/edit_component.html.haml
Co-authored-by: Paul Chavard <github@paul.chavard.net>
Update app/views/shared/dossiers/_edit.html.haml
Co-authored-by: Paul Chavard <github@paul.chavard.net>
amelioration(attachment.destroy): force l'usage de turbo
2023-02-21 08:22:50 +01:00
Damien Le Thiec
a9f342d09e
Fix tests
2023-02-20 15:51:18 +01:00
Eric Leroy-Terquem
343cb5fce6
feat(groupe instructeur mailer): add emailing to added instructeurs
2023-02-20 15:41:19 +01:00
Damien Le Thiec
deb51e3880
Manage GET prefill by creating a dossier
2023-02-20 15:35:14 +01:00
Martin
5e10e680dc
chore(spec): corrige les spec cassées et remanie un peu des specs ecrites
2023-02-20 11:47:14 +01:00
Martin
a89f5d373f
amelioration(procedures#filtres): filtre par regions avec un enum sur la collection des regions normalisés
2023-02-20 11:47:14 +01:00
Martin
68de0c6566
correctif(procedures#filtres): le filtre par departement ne fonctionnait plus. utilise un enum sur la collection des departements possible normalisés
2023-02-20 11:47:14 +01:00
sebastiencarceles
b85eeedd6c
remove departements and regions migration specs
2023-02-20 09:01:04 +01:00
Damien Le Thiec
d2452980fe
Fix merge conflict spec
2023-02-16 20:17:05 +01:00
Damien Le Thiec
dce4c84f9a
Merge branch 'main' into feature/prefill_repetible
2023-02-16 17:08:30 +01:00
Damien Le Thiec
6231c75e07
Fix tests conflicts
2023-02-16 16:58:55 +01:00
Colin Darie
4f7839039d
refactor(password-complexity): as component for better form integration
2023-02-16 16:15:40 +01:00
Paul Chavard
c0ad7853cb
fix(administrateur): procedure page n+1
2023-02-16 11:29:21 +01:00
sebastiencarceles
a3ca79076e
cover the use case with feature specs
2023-02-16 10:49:15 +01:00
sebastiencarceles
d5ffd61ab6
validate values inclusion
2023-02-16 10:49:15 +01:00
sebastiencarceles
d648ac31c2
add prefill decorator for multiple drop down list
2023-02-16 10:49:15 +01:00
sebastiencarceles
cbe2dc9c2d
let the multiple drop down list be prefillable
2023-02-16 10:49:15 +01:00
Eric Leroy-Terquem
4926fbff19
fix(groupe instructeur mailer): fix mailers preview
2023-02-16 10:37:04 +01:00
Eric Leroy-Terquem
a46faf8cdf
feat(groupe instructeur mailer): make two kind of notifications for removed instructeur
2023-02-16 10:37:04 +01:00
Eric Leroy-Terquem
5be58c8223
refactor(groupe instructeur mailer): rename mailer methods
2023-02-16 10:37:04 +01:00
Eric Leroy-Terquem
cbf072961c
feat(groupe instructeur mailer): add emailing to removed instructeurs
2023-02-16 10:37:04 +01:00
Damien Le Thiec
96b9ec3f42
First fix tests
2023-02-15 18:13:16 +01:00
Damien Le Thiec
539b9e4f10
Merge branch 'main' into feature/prefill_repetible
2023-02-15 17:53:06 +01:00
Damien Le Thiec
4876d583b6
Merge branch 'main' into feature/prefill_repetible
2023-02-15 17:39:19 +01:00
Damien Le Thiec
4b3d403d7e
fix spec
2023-02-15 17:14:29 +01:00
Damien Le Thiec
5a89a2dbe4
Use Stable ID for repetitions prefill
2023-02-15 12:15:34 +01:00
sebastiencarceles
8aa31522b6
cover feature with specs
2023-02-15 12:14:11 +01:00
sebastiencarceles
07b5a3b4b5
manage types de champ with multiple example values
2023-02-15 12:14:11 +01:00
sebastiencarceles
edf90a77f3
validate epci to reject incorrect prefill values
2023-02-15 12:14:11 +01:00
sebastiencarceles
5ac80f968a
add possible and example values
2023-02-15 12:14:11 +01:00
sebastiencarceles
f836f57e98
transform the input value to assignable attributes
...
Use the prefill decorator to transform the input value (for example
['01', '200042935']) into assignables attributes (for example
{ code_departement: '01', value: '200042935' }), in order to let the
champ be prefilled successfully.
2023-02-15 12:14:11 +01:00
sebastiencarceles
0f483668cf
let epci champ be prefillable
2023-02-15 12:14:11 +01:00
Paul Chavard
8b74a6f39b
fix(geometry): implement our own bbox to replace rgeo
2023-02-15 11:58:59 +01:00
Martin
c45f15ff61
correctif(procedure/all.xsls): deconnecte le lien de telechargement de toutes les demarche de turbo
2023-02-15 11:26:21 +01:00
Damien Le Thiec
2533ca50d4
Merge branch 'main' into feature/prefill_repetible
2023-02-15 11:07:56 +01:00
sebastiencarceles
681e1cf518
♻️ refactor possible_values impl for clarity
2023-02-14 13:45:30 +01:00
sebastiencarceles
0159a10969
🐛 make possible_values_list method public
2023-02-14 11:41:35 +01:00
sebastiencarceles
67ef3a16fa
review: put example values in translation yamls
2023-02-14 09:23:52 +01:00
Sébastien Carceles
12abf9045b
add external_id and value validation
2023-02-14 09:23:11 +01:00
Sébastien Carceles
a235829ddd
add possible and example values
2023-02-14 09:19:55 +01:00
Sébastien Carceles
cd3a72ddce
make departements champ prefillable
2023-02-14 09:19:19 +01:00
Damien Le Thiec
802a23057b
Microtest dossier prefill get without stored queries
2023-02-13 18:15:24 +01:00
mfo
76ef4ae96e
Merge pull request #8613 from colinux/email-template-subject-length
...
Email: limite le sujet généré à 100 caractères et utilise le sujet par défaut si le modèle est vide
2023-02-13 17:31:04 +01:00
sebastiencarceles
f0ffae8320
migrate(champs): normalize departements
2023-02-13 16:32:34 +01:00
Damien Le Thiec
899c8a6589
Add documentation json parse rescue repetition
2023-02-13 14:17:53 +01:00
mfo
e0da997a9b
Merge pull request #8593 from demarches-simplifiees/migration/normalize-regions
...
migrate(champs): normalize regions
2023-02-13 09:22:34 +01:00
Sébastien Carceles
1a72b80f8f
fix: "remove" a champ to prefill ( #8612 )
...
* fix: "remove" a champ to prefill
Removing a champ to prefill on /preremplir used to fail, because of a
collusion (having the same form multiple times on un page looks like a
bad idea, when it comes to multiple input fields).
* fix specs
2023-02-13 08:17:22 +00:00
Damien Le Thiec
ea126612a1
Refacto to_assignable_attributes for prefill_repetition
2023-02-12 13:02:30 +01:00
Damien Le Thiec
fc94aaaa21
Use "to_assignable_attributes"
2023-02-12 11:55:28 +01:00
Damien Le Thiec
dbb92e7fd3
Merge branch 'main' into feature/prefill_repetible
2023-02-11 22:40:56 +01:00
Damien Le Thiec
2a3ba28343
Fix tests possible value prefill
2023-02-11 22:27:16 +01:00
Damien Le Thiec
a4d707f942
Improve format prefill possible_values (tests missing)
2023-02-09 18:08:51 +01:00
Colin Darie
aeb602a63d
fix(mail): default subject fallback when subject template is empty
...
Closes #8448
2023-02-09 17:49:43 +01:00
Colin Darie
5526cb5173
fix(mail): limit generated subjects to 100 characters
2023-02-09 17:39:56 +01:00
Damien Le Thiec
4b0e6ea382
Convert datetime field to datetime_local ( #8572 )
...
* Convert datetime field to datetime_local
* Fix tests
* Add value formatting view datetime component
* Add helper datetime component value
2023-02-09 15:18:38 +01:00
sebastiencarceles
6c5b82ebbf
filter out locale from stored query params
...
As 'locale' isn't a param we want to prefill a dossier, we ignore it
and remove it from the stored query params.
2023-02-09 13:51:52 +01:00
sebastiencarceles
7a254d124f
feature spec cover
2023-02-09 13:51:52 +01:00
sebastiencarceles
b3af9108cb
harmonize get and post: go to prefilled file
2023-02-09 13:51:52 +01:00
sebastiencarceles
e212055ef8
tell when query params have been stored
2023-02-09 13:51:52 +01:00
sebastiencarceles
73fa572236
spec cover
2023-02-09 13:51:52 +01:00
Colin Darie
e626eb69ce
feat(admin): import groupe instructeurs csv when procedure is closed
2023-02-09 11:17:13 +01:00
sebastiencarceles
d2f5fe5ff5
migrate(champs): normalize regions
2023-02-09 10:46:17 +01:00
Kara Diaby
f212fa1008
Permet de cloner une démarche depuis la page toutes les démarches
2023-02-09 08:28:30 +00:00
Damien Le Thiec
c5f1f80d25
Add prefill params tests repetition
2023-02-08 17:38:51 +01:00
Paul Chavard
f22cc8812b
secu(graphql): log full queries and variables
2023-02-08 15:10:27 +01:00
Paul Chavard
dc9a455d22
fix(dossier): prevent crash in rebase
2023-02-08 11:11:14 +01:00
Eric Leroy-Terquem
22089efa12
test(groupe instructeurs): add test and preview when removing instructeurs
2023-02-08 10:36:42 +01:00
Eric Leroy-Terquem
6cbc514d56
feat(groupe instructeurs): remove mailing when add instructeurs
2023-02-08 10:36:42 +01:00
Damien Le Thiec
a51ed0094b
Fix tests
2023-02-07 00:28:21 +01:00
Damien Le Thiec
b9c2d1251b
Add missing tests repetition prefill
2023-02-06 17:38:59 +01:00
Colin Darie
51338eebb1
fix(admin/conditional): don't break when target champ is empty but a value is still referenced
2023-02-06 16:49:39 +01:00
Martin
14494255be
Revert "migrate(champs): normalize departements ( #8505 )"
...
This reverts commit 6800bb8cec
2023-02-06 15:57:26 +01:00
Martin
db36397bc5
Revert "migration: normalize regions ( #8521 )"
...
This reverts commit 8fee658eba
2023-02-06 14:49:51 +01:00
Paul Chavard
6924b8e46d
feat(dossier): optional repetition champ should not add first row
2023-02-06 11:53:32 +01:00
simon lehericey
a1487e9923
fix: allow a tag in various admin text
2023-02-06 11:01:28 +01:00
Martin
f4cc8078b4
amelioration(EmailEvent): purge les email_events vieux de plus de un mois
...
Update app/models/email_event.rb
Co-authored-by: Colin Darie <colin@darie.eu>
Update app/jobs/cron/purge_old_email_event_job.rb
Co-authored-by: Colin Darie <colin@darie.eu>
2023-02-06 10:35:57 +01:00
Martin
6a25120f80
amelioration(dolist_api): echoue avec un fail pour remonter dans notre gestion des retry
2023-02-03 17:19:36 +01:00
Martin
2de9026c13
amelioration(dolist_api): forward le message_id afin de faciliter les investigations
2023-02-03 17:19:36 +01:00
Lisa Durand
f80fe9680f
corrections from Sim review
2023-02-03 15:13:06 +01:00
Lisa Durand
fcd5b38a28
fix spec broken because new line in html table
2023-02-03 15:13:06 +01:00
Lisa Durand
f1a378bf03
dont'use DSFR component - add a line inside the table instead
2023-02-03 15:13:06 +01:00
Lisa Durand
9aa6c55d1f
replace partial by component
2023-02-03 15:13:06 +01:00
Lisa Durand
1a79eb9717
change checkbox tag to hidden field
2023-02-03 15:13:06 +01:00
Lisa Durand
93a85ca4b0
add limit of 500 dossiers
2023-02-03 15:13:06 +01:00
mfo
48503e0743
Merge pull request #8533 from colinux/feat-dolist-send-mail-api
...
Email: API Dolist pour envoyer des emails transactionnels
2023-02-03 14:36:53 +01:00
Eric Leroy-Terquem
ff5fecef25
fix(dossiers_transfers): can destroy dossiers_transfers
2023-02-03 13:48:39 +01:00
Damien Le Thiec
63e7c17fda
First tests for prefill repetition
2023-02-03 12:14:18 +01:00
Colin Darie
380a4232c6
fix(mailer): preview for DossierMailer#notify_new_draft
2023-02-02 15:58:53 +01:00
Colin Darie
b0b7114c3b
feat: jsv support for primitives
2023-02-02 14:55:46 +01:00
Sébastien Carceles
8fee658eba
migration: normalize regions ( #8521 )
2023-02-02 10:19:33 +00:00
Sébastien Carceles
6800bb8cec
migrate(champs): normalize departements ( #8505 )
...
* migration: normalize departements
* rename update_all methods to avoid collusions
* simplify scopes
2023-02-02 10:00:56 +00:00
Paul Chavard
2971100081
fix(dossier): do not try to rebase if procedure is not published
2023-02-02 10:11:46 +01:00
Paul Chavard
fc31ef6da3
chore(dossier): move concern spec to concern folder
2023-02-02 10:11:29 +01:00
Lisa Durand
120fbb0ef7
Overload the finished_at
2023-02-01 17:06:04 +01:00
Lisa Durand
d0a131dc55
change the way we set the finished_at on batch operation job to fix alert display bug
2023-02-01 17:06:04 +01:00
Damien Le Thiec
e7c78321d9
Fix new failing tests
2023-02-01 13:35:32 +01:00
Damien Le Thiec
a4645855d3
Fix tests prefillable repetition
2023-02-01 12:02:09 +01:00
Colin Darie
fa0f72aaba
feat(procedure): hide estimated fill duration when super admin disabled it
...
Closes #8466
2023-02-01 11:02:55 +01:00
Colin Darie
eb9cd90ee8
chore(schema): +procedure#estimated_duration_visible
2023-02-01 11:02:55 +01:00
Paul Chavard
9c83939431
fix(dossier): fix adding repetition in a new revision
2023-02-01 10:36:46 +01:00
Eric Leroy-Terquem
b306dea5cf
refactor(avis): rename revive by remind
2023-02-01 09:55:46 +01:00
Eric Leroy-Terquem
004bf5be38
feat(avis): add remind_by! method
2023-02-01 09:55:46 +01:00
Martin
4f4791a864
bug(liens-invitation): ne devrait pas pointer sur l'avis ayant le même id que l'invitation
2023-01-31 16:33:31 +01:00
Martin
88553eec9b
correctif(dossier_transfer): le transfer de dossier vers un email contenant des majuscule ne fonctionnait pas
2023-01-31 14:52:57 +01:00
Colin Darie
5cddb1c74e
fix(procedure_presentation): options groupe_instructeur for that procedure only
2023-01-31 13:55:06 +01:00
Paul Chavard
dcbe16603a
fix(dossier): fix parser with dashes
2023-01-31 10:40:48 +01:00
Paul Chavard
ca05fb753b
fix(only_present_on_draft?): broken when type_de_champ is removed from later revisions
2023-01-31 09:26:50 +01:00
Colin Darie
36d5569114
fix(instructeurs): pdf in exports include info administration
2023-01-30 18:38:54 +01:00
Colin Darie
ef864021f7
refactor(pj_service): explicit options with_{bills,champs_private} because expert & instructeurs does not need the same
2023-01-30 18:04:09 +01:00
Martin
dbe64cf0c8
correctif(date_champ): renforce la validation avec le parsing de la date plutot qu'une approche par regexp
2023-01-30 13:01:24 +01:00
Martin
78f9910fd0
bug(date): la validation est trop lache
2023-01-30 13:01:24 +01:00
Colin Darie
3265fff30e
fix(dropdown): wait "other" input to be disabled before autosave
...
Fix le workflow suivant pour un champ drop down avec option "autre" :
- on choisit la valeur "autre" avec une valeur => ça autosave la bonne valeur
- on choisit finalement une autre valeur proposée => l'autosave envoyait
la nouvelle valeur, et toujours la valeur "other" car l'input n'était pas encore
`disabled`. Par conséquent la valeur other overridait la valeur choisie
et ça provoquait des erreurs en cascade, notamment dans le conditionnel.
2023-01-30 12:16:25 +01:00
Paul Chavard
2f4e85f163
fix(dossier): set rebased_at only on changed champs
2023-01-30 12:01:11 +01:00
Paul Chavard
298721f90d
fix(dossier): fix clone with data
2023-01-30 10:58:26 +01:00
Colin Darie
923ee59e92
refactor(instructeurs/perf): don't load anymore geo areas for each champ because of header
...
Economise 1 requête par champ sur chaque page instructeur d'un dossier
à cause du header juste pour savoir s'il faut afficher
le bouton d'export GeoJSON.
2023-01-26 14:57:45 +01:00
Martin
9a12b97424
amelioration(expert/avis/header): passe d'un dropdown avec un element pour telecharger le dossier au composant dsfr de telechargement de fichier
2023-01-26 11:13:23 +01:00
Martin
2be0f5aa99
amelioration(menu): extraction des menu dans un composant ruby pour ne pas dupliquer les changements aria partout ds la codebase
2023-01-26 11:13:23 +01:00
Colin Darie
51c1736d00
refactor(conditional): extract in a ChampConditionalConcern with tests
2023-01-26 09:06:30 +01:00
Colin Darie
81f00774af
feat(logic): operators sources
2023-01-26 09:06:30 +01:00
Paul Chavard
5b9e534b3f
chore(turbo): morph all the things
2023-01-25 13:45:26 +01:00
Sébastien Carceles
49ce255e29
feat(dossier): prefill region champ ( #8442 )
...
* make regions champ prefillable
* add possible and example value
* add external_id and value validation
2023-01-24 11:25:17 +00:00
Martin
4990c448b1
amelioration(mail.prioritaire): en plus des mails de device, ajoute la gestion du routage des autres mails critique
2023-01-24 11:49:53 +01:00
mfo
84a667b8bd
Merge pull request #8454 from tchak/feat-epci
...
feat(types de champ): add EPCI champ
2023-01-23 16:56:18 +01:00
Sébastien Carceles
92c769de4f
fix(prefill): code pays display ( #8477 )
...
* show translated text AND possible values
* show less possible values
* show countries possible values
2023-01-23 14:08:20 +00:00
mfo
1926aa283d
Merge pull request #8425 from adullact/fix/procedure-custom-retention
...
Fix du support d'une durée personnalisée de conservation des dossiers
2023-01-23 12:11:29 +01:00
Damien Le Thiec
962016e32e
Schema graph_ql ( #8406 )
...
* First draft schema graph_ql
* Add tests for json schema procedures
2023-01-23 11:31:06 +01:00
Sébastien Carceles
68ddae7382
feat(demarche): prefilling stats ( #8436 )
...
* force json content type for POST / PATCH / PUT
* add specs about stats dossiers funnel
* new endpoint to render stats about a procedure
2023-01-20 13:28:02 +00:00
Paul Chavard
a4cbbe721e
feat(types de champ): add EPCI champ
2023-01-20 11:32:36 +01:00
Paul Chavard
8f1ae99413
fix(graphql): remove deprecated options from introspection query
2023-01-20 09:54:50 +01:00
Martin
52380d5249
fix(api): on fixe avec avec des tests le prob de token
2023-01-19 17:40:19 +01:00
Martin
7206f1b298
bug(api): token, not checked
2023-01-19 17:33:19 +01:00
simon lehericey
84d08d4d24
fix(expert_export): an expert export excludes annotation and avis
2023-01-19 12:09:16 +01:00
Sébastien Carceles
0046338e6a
fix(prefill): don't mark the dossier as prefilled when it's not ( #8464 )
...
A dossier should not be marked as prefilled when it's not, meaning
when no prefill params are given.
2023-01-19 10:51:56 +00:00
Martin
8528939b75
correctif(champs/repetitions#remove): les row id etant des ulid commence par un int. utiliser l'ulid comme selecteur css n'est pas valide. il faut donc avoir un selecteur CSS 'safe', et envoyer le row_id
2023-01-19 10:48:01 +01:00
Martin
f59354f787
tech(champs/repetitions#remove): ajout d'un test pour s'assurer que l'action de suppression d'un bloc repetable fonctionne
2023-01-19 10:38:30 +01:00
Martin
3dc26efc61
infra(monitoring): ajoute le webhook pour les notifier des incidents cote sib
2023-01-19 09:50:25 +01:00
Colin Darie
428dd9bf1a
fix(dossier): we can't terminer any dossier having etablissements in degraded mode
...
Closes #8449
2023-01-18 19:23:25 +01:00
Kara Diaby
063059d6f0
tests
2023-01-18 18:46:42 +01:00
Paul Chavard
b5dc71e975
fix(graphql): demarche with pj should return schema
2023-01-18 18:06:10 +01:00
Paul Chavard
cdb3ce65cb
feat(graphql): expose more information on demarche descriptor
2023-01-18 13:46:40 +01:00
Damien Le Thiec
3a8a50a216
Allow prefill pays type de champs ( #8344 )
...
* Allow prefill pays type de champs
* Avoid conditional prefil params for pays champ
* Clean pays data with batch update
* Fix bug and add test batch update pays value
* Improve performance batch_update_pays
* Fix associated country code problem
* Fix after party task name
* Format country name if needed in batch update
2023-01-18 12:52:38 +01:00
Colin Darie
784b0458fe
feat(dolist): consolidate dispatched events with delivered emails
2023-01-18 09:56:40 +01:00
Sébastien Carceles
5c7b2ba1f3
feat(dossier): prefill drop down list champ ( #8361 )
...
* feat(dossier): prefill drop down list champ
* decorate the types de champ to avoid if / else
In order to avoid doing if this a drop down ? / else at several places,
we decorate the types de champ and let the decorator give the possible
and example values.
* show all possible values when there are too many
* allow to prefill 'other' option
* review: remove duplicate
* review: refactor for readability
* validate that value is in options
* review: exclude disabled options
2023-01-18 09:47:22 +01:00
