DGNum/demarches-normaliennes
15
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

change checkbox tag to hidden field

Browse source
This commit is contained in:
Lisa Durand 2023-01-24 17:59:39 +01:00
parent 93a85ca4b0
commit 1a79eb9717
3 changed files with 8 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/javascript/controllers/batch_operation_controller.ts
View file

@ -98,7 +98,7 @@ function displayNotice(inputs) {
deleteSelection();
};
document.querySelector('#dynamic_number').textContent = (inputs.length - 1);
document.querySelector('#dynamic_number').textContent = (inputs.length);
}
function deleteSelection() {

2
app/views/instructeurs/procedures/_notice_dossier_select_all.html.haml
View file

@ -20,4 +20,4 @@
%a{ :href => "#", data: { action: "batch-operation#onDeleteSelection" } }
= "Effacer la sélection"
= check_box_tag :"batch_operation[dossier_ids][]", [], false, class: 'hidden', data: { batch_operation_target: "input", action: "batch-operation#onCheckOne", operations: BatchOperation.operations.values.join(',') }, form: dom_id(BatchOperation.new), id: dom_id(BatchOperation.new, "checkbox_multiple"), aria: { label: t('views.instructeurs.dossiers.batch_operation.enabled') }
= hidden_field_tag :"batch_operation[dossier_ids][]", "", form: dom_id(BatchOperation.new), id: dom_id(BatchOperation.new, "checkbox_multiple")

11
spec/system/instructeurs/batch_operation_spec.rb
View file

@ -92,19 +92,20 @@ describe 'BatchOperation a dossier:', js: true do
# click on check_all make the notice appear
find("##{dom_id(BatchOperation.new, :checkbox_all)}").check
expect(page).to have_selector('.fr-notice')
expect(page).to have_content('Les 2 dossiers de cette pages sont sélectionnés. Sélectionner les 3 dossiers.')
expect(page).to have_content('Les 2 dossiers de cette page sont sélectionnés. Sélectionner les 3 dossiers.')
# click on selection link fill checkbox value with dossier_ids
click_on("Sélectionner les 3 dossiers")
expect(page).to have_content('3 dossiers sont sélectionnés. Effacer la sélection ')
expect(page).to have_selector('#checkbox_multiple_batch_operation', visible: false)
expect(find_field("batch_operation[dossier_ids][]", match: :first).value).to eq "#{dossier_3.id},#{dossier_2.id},#{dossier_1.id}"
expect(find_field("batch_operation[dossier_ids][]", type: :hidden).value).to eq "#{dossier_3.id},#{dossier_2.id},#{dossier_1.id}"
# click on delete link empty checkbox value and hide notice
click_on("Effacer la sélection")
expect(page).to have_selector('.fr-notice', visible: false)
expect(page).to have_button("Suivre les dossiers", disabled: true)
expect(find_field("batch_operation[dossier_ids][]", match: :first).value).to eq ""
expect(find_field("batch_operation[dossier_ids][]", type: :hidden).value).to eq ""
# click on check_all + notice link and submit
find("##{dom_id(BatchOperation.new, :checkbox_all)}").check
@ -136,7 +137,7 @@ describe 'BatchOperation a dossier:', js: true do
# click on selection link fill checkbox value with dossier_ids
click_on("Sélectionner les 3 premiers dossiers sur les 4")
expect(page).to have_content('3 dossiers sont sélectionnés. Effacer la sélection')
expect(find_field("batch_operation[dossier_ids][]", match: :first).value).to eq "#{dossier_4.id},#{dossier_3.id},#{dossier_2.id}"
expect(find_field("batch_operation[dossier_ids][]", type: :hidden).value).to eq "#{dossier_4.id},#{dossier_3.id},#{dossier_2.id}"
# create batch
expect { click_on "Suivre les dossiers" }