DGNum/demarches-normaliennes
15
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

Merge pull request #8837 from demarches-simplifiees/bug-special-character-in-email

Browse source 
[fix] bug dans le sujet des mails de notification si le libelle de la procedure contient un apostrophe
This commit is contained in:
Paul Chavard 2023-04-03 09:39:13 +00:00 committed by GitHub
commit b0673c0127
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 18 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/mailers/notification_mailer.rb
View file

@ -26,7 +26,7 @@ class NotificationMailer < ApplicationMailer
attachments[@attachment[:filename]] = @attachment[:content] if @attachment.present?
I18n.with_locale(@dossier.user_locale) do
mail(subject: @subject, to: @email, template_name: 'send_notification')
mail(subject: Nokogiri::HTML.parse(@subject).text, to: @email, template_name: 'send_notification')
end
end

17
spec/mailers/notification_mailer_spec.rb
View file

@ -124,4 +124,21 @@ RSpec.describe NotificationMailer, type: :mailer do
it { expect(mail.subject.length).to be <= 100 }
end
end
describe 'subject with apostrophe' do
let(:procedure) { create(:simple_procedure, libelle: "Mon titre avec l'apostrophe") }
let(:dossier) { create(:dossier, :en_instruction, :with_individual, :with_service, user: user, procedure: procedure) }
let(:email_template) { create(:closed_mail, subject:, body: 'Your dossier was accepted. Thanks.') }
before do
dossier.procedure.closed_mail = email_template
end
subject(:mail) { described_class.send_accepte_notification(dossier) }
context "subject has a special character" do
let(:subject) { '--libellé démarche--' }
it { expect(mail.subject).to eq("Mon titre avec l'apostrophe") }
end
end
end