DGNum/demarches-normaliennes
15
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

fix(date): don't crash when date value is not parseable

Browse source
This commit is contained in:
Colin Darie 2023-04-05 12:16:52 +02:00
parent 96740152c8
commit 5e62aa7d21
2 changed files with 15 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
app/models/champs/date_champ.rb
View file

@ -30,11 +30,11 @@ class Champs::DateChamp < Champ
def to_s
value.present? ? I18n.l(Time.zone.parse(value), format: '%d %B %Y') : ""
rescue ArgumentError
value.presence || "" # old dossiers can have not parseable dates
end
def for_tag
value.present? ? I18n.l(Time.zone.parse(value), format: '%d %B %Y') : ""
end
alias for_tag to_s
private

12
spec/models/champs/date_champ_spec.rb
View file

@ -45,6 +45,18 @@ describe Champs::DateChamp do
end
end
describe "#to_s" do
it "format the date" do
champ_with_value("2020-06-20")
expect(date_champ.to_s).to eq("20 juin 2020")
end
it "does not fail when value is not iso" do
champ_with_value("2023-30-01")
expect(date_champ.to_s).to eq("2023-30-01")
end
end
def champ_with_value(number)
date_champ.tap { |c| c.value = number }
end