2217 commits

Author	SHA1	Message	Date
Colin Darie	b626714610	fix(dossier): submit en_construction render views in error with dossier origin	2023-05-09 18:49:53 +02:00
Paul Chavard	08a2a2c9aa	feat(dossier): fork dossier when editing en construction	2023-05-09 17:16:47 +02:00
mfo	2374ced5d2	Merge pull request #8987 from mfo/US/link-to-errored-champs ... amelioration(dossier#submit_brouillon): ETQ usager, je souhaite pouvoir acceder aux champs en erreur facilement	2023-05-09 07:06:36 +00:00
Colin Darie	ae88c1de6b	fix(devise): default config for devise and turbo stream as navigational format	2023-05-03 11:35:32 +02:00
Colin Darie	61ebb27e86	fix(redirect): allow other hosts when required	2023-05-03 11:35:31 +02:00
Nicolas Cavigneaux	7e0fbcf672	fix: ensure procedure used in remove_instructeur spec has routing_enabled set to true	2023-05-03 11:35:29 +02:00
Martin	c8ab1e8e03	amelioration(dossier#submit_brouillon): ETQ usager, je souhaite pouvoir acceder aux champs en erreur facilement	2023-05-03 07:36:42 +02:00
Paul Chavard	99abdf45e7	fix(api-entreprise): use new status endpoint	2023-04-27 22:39:44 +02:00
Paul Chavard	cb752d1857	fix(dossier): do not bypass depositaire check on modifier path	2023-04-27 09:52:10 +02:00
LeSim	4c5e903673	Merge pull request #8887 from demarches-simplifiees/8839-filter-by-siret ... Filtrer les démarches par service	2023-04-26 19:44:08 +00:00
Martin	6a2d2ae0a7	bug(instructeurs/avis_controller#remind): ETQ instructeur, je peux relancer une demande d'avis meme si celui ci contient une question	2023-04-26 07:46:21 +02:00
Lisa Durand	26ff82dbe4	Merge branch 'main' of github.com:betagouv/demarches-simplifiees.fr into user-dashboard/add-alert-WIP-last-dossier	2023-04-25 13:01:40 +02:00
Martin	6739bfc665	bug(instructeurs.annotations): ETQ instructeurs, lorsque je saisie une autre valeur dans un champ de type choix simple, celle ci n'est pas sauvegardé	2023-04-21 09:35:16 +02:00
Paul Chavard	586286cb08	Merge pull request #8916 from demarches-simplifiees/can-update-defaut-groupe-instructeur-2 ... feat(routage): permet de changer le groupe par défaut	2023-04-20 08:28:46 +00:00
Paul Chavard	418d3b55d0	feat(stats): give access to stats on closed procedures	2023-04-19 18:31:58 +02:00
Colin Darie	9728493bda	Merge pull request #8924 from colinux/rubocop-upgrades ... Tech: update rubocop, active nouveaux cops Rails/*	2023-04-19 13:37:10 +00:00
Eric Leroy-Terquem	aecd7559d2	feat(groupe instructeur): cannot disable default groupe instructeur	2023-04-19 13:52:42 +02:00
Eric Leroy-Terquem	09b05550ab	feat(groupe instructeur): cannot delete defaut_groupe_instructeur	2023-04-19 13:52:42 +02:00
simon lehericey	b38470368b	feat(routing): can change defaut groupe	2023-04-19 13:52:41 +02:00
Colin Darie	999f06075b	chore(rubocop): fix Rails/ResponseParsedBody	2023-04-19 12:55:13 +02:00
Colin Darie	b273e7b67e	chore(rubocop): fix Rails/RootPathnameMethods and assimiled cops	2023-04-19 12:55:13 +02:00
Paul Chavard	05cfb4055d	fix(dossier): improuve dossier state display	2023-04-19 12:27:16 +02:00
github-merge-queue[bot]	a286af8a70	Merge pull request #8918 from tchak/graphql-add-error-codes ... ETQ intégrateur API, je voudrais avoir des codes d'erreur plus précis	2023-04-19 09:00:32 +00:00
Paul Chavard	ae1ec87397	feat(graphql): add code to timeout errors	2023-04-18 15:22:11 +02:00
Paul Chavard	f70532a844	feat(graphql): global not found error handling	2023-04-18 15:22:11 +02:00
Paul Chavard	fbae6d941d	feat(graphql): add error codes to graphql errors	2023-04-18 15:22:11 +02:00
Lisa Durand	c565ed415b	change scope and alert location after UI modification	2023-04-18 12:03:10 +02:00
Paul Chavard	bf6cc25063	feat(graphql): expose pendingDeletedDossiers on groupe instructeur	2023-04-17 18:43:00 +02:00
LeSim	c252748833	Merge pull request #8836 from demarches-simplifiees/improve-routing-rules-ux ... feat(routing): nicer and safer ?	2023-04-17 08:23:15 +00:00
Paul Chavard	5abb6a8f12	chore(spec): remove memory store cache from tests	2023-04-13 13:10:23 +02:00
simon lehericey	c02319aa56	feat(routing): reset value if target as changed	2023-04-13 10:28:53 +02:00
simon lehericey	8b832396a3	feat(routing): server side: prevent changing tdc type if used for routing	2023-04-13 10:28:52 +02:00
simon lehericey	c1f67499aa	feat(routing): server side: prevent tdc deletion if used for routing	2023-04-13 10:28:52 +02:00
krichtof	78938b5a07	filter demarches by siret service	2023-04-12 18:53:57 +02:00
Lisa Durand	bc3e67ab94	add alert on user dashboard to edit last editable dossier	2023-04-11 15:50:17 +02:00
Paul Chavard	0b95a912c6	Merge pull request #8858 from tchak/feat-refactor-dossier-link-champ ... feat(dossier): use turbo to select linked dossier	2023-04-07 08:49:11 +00:00
Paul Chavard	a2f7d1df72	fix(graphql): pendingDeletedSince should not crash	2023-04-06 15:07:48 +02:00
Paul Chavard	a5733002ed	feat(graphql): improuve logs	2023-04-05 13:56:26 +02:00
Paul Chavard	52c8b0b297	feat(dossier): use turbo to select linked dossier	2023-04-05 11:40:03 +02:00
Paul Chavard	dee0952b2a	fix(graphql): demandeur personne morale can be in degraded mode	2023-04-05 11:20:18 +02:00
Paul Chavard	a778e1083b	fix(graphql): return better errors when dossiers cannot change state	2023-04-04 17:24:30 +02:00
Paul Chavard	2a48228552	fix(dossier): improuve commune champ rendering in pdf	2023-04-04 16:01:16 +02:00
Paul Chavard	12f0c03bac	Merge pull request #8847 from tchak/feat-improuve-dossier-remove ... fix(dossier): an invited user can remove (leave) a dossier	2023-04-04 13:10:18 +00:00
Paul Chavard	0864666d0a	fix(dossier): an invited user can remove (leave) a dossier	2023-04-03 20:10:44 +02:00
Paul Chavard	fce78bbf30	feat(dossier): multiselect without react	2023-04-03 16:54:50 +02:00
simon lehericey	b93e3776c4	feat(routing): add controller	2023-03-30 10:51:20 +02:00
mfo	60d41029de	Merge pull request #8817 from mfo/US/fix-expert-export ... correctif(export.pdf): ETQ expert, lorsque j'exporte un dossier au format PDF, celui ci contenient les avis non confidentiels ainsi que mes avis	2023-03-29 12:00:14 +00:00
Martin	c6e9674de2	correctif(export.pdf): ETQ expert, lorsque j'exporte un dossier au format PDF, celui ci contenient les avis non confidentiels ainsi que mes avis	2023-03-28 17:16:34 +02:00
Martin	4f9c45c489	bug(export.pdf): ETQ expert, lorsque j'exporte un dossier, celui ci devrait contenir les avis non confidentiels ainsi que mes avis	2023-03-28 16:55:12 +02:00
Kara Diaby	4a13c64b38	tests	2023-03-27 14:14:18 +02:00
Lisa Durand	d079f3ac98	Merge pull request #8770 from demarches-simplifiees/ask-question-in-avis-ux-part ... [UX] améliorer UX de la demande d'avis	2023-03-24 10:50:33 +00:00
Paul Chavard	275150d727	feat(graphql): expose pendingDeletedDossiers ... fix #8785	2023-03-22 19:40:43 +01:00
Lisa Durand	4a2982dc37	fix tests and linter	2023-03-22 09:30:26 +01:00
Colin Darie	954652fcf5	fix(champ): may fix pg deadlocks: autosave already saves value at the same time	2023-03-20 14:32:14 +01:00
Lisa Durand	ee2f795dec	pr feedbacks - add validation for yes/no answer - improve locales use	2023-03-16 11:32:05 +01:00
Lisa Durand	eddd7a2192	add flash alert if email field empty	2023-03-16 11:32:05 +01:00
Lisa Durand	01afa998b6	add specs	2023-03-16 11:32:05 +01:00
Paul Chavard	8ee13f1719	feat(api_token): add allowed_procedure_ids and write_access	2023-03-15 19:09:49 +01:00
Paul Chavard	cbaa77fca7	feat(annotations): activate autosave	2023-03-14 15:22:13 +01:00
Lisa Durand	6ba47b731b	refacto destroy action and add spec for unauthorized user	2023-03-09 14:58:47 +01:00
Lisa Durand	3d5bf40c0f	allow transfer sender to revoke a transfer	2023-03-09 14:57:59 +01:00
Eric Leroy-Terquem	72b6dacfbd	fix(API): remove notification to group when instructeurs removed	2023-03-08 11:59:58 +01:00
Eric Leroy-Terquem	a150aa33ef	feat(GroupeInstructeurSupprimerInstructeurs): add notification for removed instructeurs via API	2023-03-08 11:59:58 +01:00
Eric Leroy-Terquem	ac0d7a67a1	feat(GroupeInstructeurAjouterInstructeurs): add notification for added instructeurs via API	2023-03-08 11:59:58 +01:00
Eric Leroy-Terquem	b2f3a7af4c	feat(GroupeInstructeurSupprimerInstructeurs): enable emailing for unrouted procedures	2023-03-08 11:59:55 +01:00
Eric Leroy-Terquem	9e0753a710	fix(groupe instructeur mailer): do not notify if no added instructeurs	2023-03-08 11:03:33 +01:00
Eric Leroy-Terquem	f317f28ff5	test(groupe instructeurs): use right data (a routed procedure has at ... least two active groups)	2023-03-08 10:48:02 +01:00
Eric Leroy-Terquem	e1906febcc	feat(groupe instructeur): can enable routing from import	2023-03-08 10:48:02 +01:00
Eric Leroy-Terquem	9f0f5b0dc5	feat(groupe instructeur): allow import of many groups when procedure is not routed yet	2023-03-08 10:48:02 +01:00
Kara Diaby	4ea7bb2f1c	tests	2023-03-03 11:50:47 +01:00
Damien Le Thiec	687c05e6d1	Merge pull request #8622 from demarches-simplifiees/fix/stored_query_issue ... Dossier prefill get without stored queries	2023-03-02 14:01:04 +00:00
Lisa Durand	54f17ad3c7	Merge pull request #8630 from demarches-simplifiees/harmonize-actions-for-instructeurs ... [instructeurs] Uniformiser les actions pour les instructeurs sur la page tableau et dossier	2023-03-02 13:28:23 +00:00
Damien Le Thiec	8a7cb3f1fe	Merge branch 'main' into fix/stored_query_issue	2023-03-01 10:22:40 +01:00
Damien Le Thiec	01f142183e	Add and correct tests	2023-03-01 10:21:22 +01:00
Paul Chavard	d8ee4cb360	fix(test): dossiers_controller_spec	2023-02-28 17:28:17 +01:00
Paul Chavard	294a5135ce	feat(public/api): add dossier state api	2023-02-28 16:35:25 +01:00
Colin Darie	7e13d58db2	Merge pull request #8703 from govpf/feature/fix-dossier-controller-spec ... Fix dossier controller spec	2023-02-28 12:11:30 +00:00
krichtof	dee499d386	Merge pull request #8706 from demarches-simplifiees/all_demarches_even_without_zones ... liste toutes les démarches, même celles non associées à des zones	2023-02-28 10:58:07 +00:00
Paul Chavard	7076d6d99e	fix(turbo): rerender only top part of the header	2023-02-27 16:06:11 +01:00
sebastiencarceles	39545671f3	refacto: better error management	2023-02-27 14:35:11 +01:00
sebastiencarceles	33fa40eda2	don't clean the rna champ value ... Cleaning the value is useless, when fetching the association, as the value will be re-written by the dossier update, when the user fills in the dossier. Furthermore we need the value to persist when prefilling the champ.	2023-02-27 14:35:11 +01:00
Lisa Durand	636e6aa6cb	fix broken tabs with turbostream	2023-02-27 14:30:10 +01:00
sebastiencarceles	becf4da70a	fix raison social fetch	2023-02-27 13:54:35 +01:00
sebastiencarceles	30eef3e128	review: detailled error message	2023-02-27 13:45:16 +01:00
Sébastien Carceles	df2eaa9542	don't clean the siret champ value ... Cleaning the value is useless, when fetching the etablissement, as the value will be re-written by the dossier update, when the user fills in the dossier.	2023-02-27 13:45:16 +01:00
Damien Le Thiec	67bbacbb05	Merge pull request #8513 from demarches-simplifiees/feature/prefill_repetible ... Prefill repeatable	2023-02-27 09:58:53 +00:00
Christian Lautier	704dbf94db	Fix dossier controller spec	2023-02-25 08:32:21 -10:00
Lisa Durand	6487e2c27e	implement turbostream back for state change in dossier view	2023-02-24 17:54:53 +01:00
Christophe Robillard	1d6c2fd7eb	display procedures without zones	2023-02-24 17:27:28 +01:00
Eric Leroy-Terquem	4ea1d7d33b	feat(groupe instructeurs import): notify added instructeurs	2023-02-23 10:56:55 +01:00
Eric Leroy-Terquem	a6e01d98ea	feat(instructeurs import): notify added instructeurs	2023-02-23 10:56:55 +01:00
Damien Le Thiec	731cd56594	Merge branch 'main' into feature/prefill_repetible	2023-02-22 19:49:06 +01:00
Damien Le Thiec	fbe4fe251a	Fix format prefill repetition	2023-02-22 19:32:25 +01:00
Lisa Durand	fddcce8b7b	fix specs	2023-02-22 18:17:06 +01:00
Eric Leroy-Terquem	25df48f255	feat(groupe_instructeurs): import instructeurs in unrouted procedure with a proper CSV	2023-02-22 09:49:26 +01:00
Eric Leroy-Terquem	3aa7793ed3	fix(groupe_instructeurs): can parse a monocolumn csv file	2023-02-22 09:49:26 +01:00
Paul Chavard	e56d51e0f6	fix(graphql): fix demarcheUrl	2023-02-21 10:57:43 +01:00
Eric Leroy-Terquem	343cb5fce6	feat(groupe instructeur mailer): add emailing to added instructeurs	2023-02-20 15:41:19 +01:00
Damien Le Thiec	deb51e3880	Manage GET prefill by creating a dossier	2023-02-20 15:35:14 +01:00
Damien Le Thiec	dce4c84f9a	Merge branch 'main' into feature/prefill_repetible	2023-02-16 17:08:30 +01:00
Colin Darie	4f7839039d	refactor(password-complexity): as component for better form integration	2023-02-16 16:15:40 +01:00
sebastiencarceles	d5ffd61ab6	validate values inclusion	2023-02-16 10:49:15 +01:00
Eric Leroy-Terquem	a46faf8cdf	feat(groupe instructeur mailer): make two kind of notifications for removed instructeur	2023-02-16 10:37:04 +01:00
Eric Leroy-Terquem	5be58c8223	refactor(groupe instructeur mailer): rename mailer methods	2023-02-16 10:37:04 +01:00
Eric Leroy-Terquem	cbf072961c	feat(groupe instructeur mailer): add emailing to removed instructeurs	2023-02-16 10:37:04 +01:00
Damien Le Thiec	2533ca50d4	Merge branch 'main' into feature/prefill_repetible	2023-02-15 11:07:56 +01:00
sebastiencarceles	0159a10969	🐛 make possible_values_list method public	2023-02-14 11:41:35 +01:00
Sébastien Carceles	12abf9045b	add external_id and value validation	2023-02-14 09:23:11 +01:00
Damien Le Thiec	802a23057b	Microtest dossier prefill get without stored queries	2023-02-13 18:15:24 +01:00
Sébastien Carceles	1a72b80f8f	fix: "remove" a champ to prefill (#8612) ... * fix: "remove" a champ to prefill Removing a champ to prefill on /preremplir used to fail, because of a collusion (having the same form multiple times on un page looks like a bad idea, when it comes to multiple input fields). * fix specs	2023-02-13 08:17:22 +00:00
Damien Le Thiec	dbb92e7fd3	Merge branch 'main' into feature/prefill_repetible	2023-02-11 22:40:56 +01:00
Damien Le Thiec	4b0e6ea382	Convert datetime field to datetime_local (#8572) ... * Convert datetime field to datetime_local * Fix tests * Add value formatting view datetime component * Add helper datetime component value	2023-02-09 15:18:38 +01:00
sebastiencarceles	6c5b82ebbf	filter out locale from stored query params ... As 'locale' isn't a param we want to prefill a dossier, we ignore it and remove it from the stored query params.	2023-02-09 13:51:52 +01:00
sebastiencarceles	e212055ef8	tell when query params have been stored	2023-02-09 13:51:52 +01:00
Colin Darie	e626eb69ce	feat(admin): import groupe instructeurs csv when procedure is closed	2023-02-09 11:17:13 +01:00
Paul Chavard	f22cc8812b	secu(graphql): log full queries and variables	2023-02-08 15:10:27 +01:00
Eric Leroy-Terquem	6cbc514d56	feat(groupe instructeurs): remove mailing when add instructeurs	2023-02-08 10:36:42 +01:00
Damien Le Thiec	a51ed0094b	Fix tests	2023-02-07 00:28:21 +01:00
Paul Chavard	6924b8e46d	feat(dossier): optional repetition champ should not add first row	2023-02-06 11:53:32 +01:00
Eric Leroy-Terquem	ff5fecef25	fix(dossiers_transfers): can destroy dossiers_transfers	2023-02-03 13:48:39 +01:00
Eric Leroy-Terquem	b306dea5cf	refactor(avis): rename revive by remind	2023-02-01 09:55:46 +01:00
Eric Leroy-Terquem	004bf5be38	feat(avis): add remind_by! method	2023-02-01 09:55:46 +01:00
Damien Le Thiec	d7b01255fe	Merge branch 'main' into feature/prefill_repetible	2023-01-31 16:39:00 +01:00
Martin	88553eec9b	correctif(dossier_transfer): le transfer de dossier vers un email contenant des majuscule ne fonctionnait pas	2023-01-31 14:52:57 +01:00
Colin Darie	36d5569114	fix(instructeurs): pdf in exports include info administration	2023-01-30 18:38:54 +01:00
Paul Chavard	5b9e534b3f	chore(turbo): morph all the things	2023-01-25 13:45:26 +01:00
Sébastien Carceles	49ce255e29	feat(dossier): prefill region champ (#8442) ... * make regions champ prefillable * add possible and example value * add external_id and value validation	2023-01-24 11:25:17 +00:00
mfo	84a667b8bd	Merge pull request #8454 from tchak/feat-epci ... feat(types de champ): add EPCI champ	2023-01-23 16:56:18 +01:00
mfo	1926aa283d	Merge pull request #8425 from adullact/fix/procedure-custom-retention ... Fix du support d'une durée personnalisée de conservation des dossiers	2023-01-23 12:11:29 +01:00
Damien Le Thiec	962016e32e	Schema graph_ql (#8406) ... * First draft schema graph_ql * Add tests for json schema procedures	2023-01-23 11:31:06 +01:00
Sébastien Carceles	68ddae7382	feat(demarche): prefilling stats (#8436) ... * force json content type for POST / PATCH / PUT * add specs about stats dossiers funnel * new endpoint to render stats about a procedure	2023-01-20 13:28:02 +00:00
Paul Chavard	a4cbbe721e	feat(types de champ): add EPCI champ	2023-01-20 11:32:36 +01:00
Paul Chavard	8f1ae99413	fix(graphql): remove deprecated options from introspection query	2023-01-20 09:54:50 +01:00
Martin	52380d5249	fix(api): on fixe avec avec des tests le prob de token	2023-01-19 17:40:19 +01:00
Martin	7206f1b298	bug(api): token, not checked	2023-01-19 17:33:19 +01:00
simon lehericey	84d08d4d24	fix(expert_export): an expert export excludes annotation and avis	2023-01-19 12:09:16 +01:00
Martin	f59354f787	tech(champs/repetitions#remove): ajout d'un test pour s'assurer que l'action de suppression d'un bloc repetable fonctionne	2023-01-19 10:38:30 +01:00
Martin	3dc26efc61	infra(monitoring): ajoute le webhook pour les notifier des incidents cote sib	2023-01-19 09:50:25 +01:00
Kara Diaby	063059d6f0	tests	2023-01-18 18:46:42 +01:00
Paul Chavard	b5dc71e975	fix(graphql): demarche with pj should return schema	2023-01-18 18:06:10 +01:00
Paul Chavard	cdb3ce65cb	feat(graphql): expose more information on demarche descriptor	2023-01-18 13:46:40 +01:00
Sébastien Carceles	5c7b2ba1f3	feat(dossier): prefill drop down list champ (#8361) ... * feat(dossier): prefill drop down list champ * decorate the types de champ to avoid if / else In order to avoid doing if this a drop down ? / else at several places, we decorate the types de champ and let the decorator give the possible and example values. * show all possible values when there are too many * allow to prefill 'other' option * review: remove duplicate * review: refactor for readability * validate that value is in options * review: exclude disabled options	2023-01-18 09:47:22 +01:00
simon lehericey	8e75b6ff77	fix(send_dossier): avoid leaking instructeur emails	2023-01-17 16:57:56 +01:00
Damien Le Thiec	5e26acb0e1	Make date and datetime prefillable (#8304) ... * Make date and datetime prefillable * Format in ISO8601 format	2023-01-12 17:42:02 +01:00
François Vantomme	e794d4f77b	fix(procedure): deal nicely with custom NEW_MAX_DUREE_CONSERVATION	2023-01-12 14:37:54 +01:00
Paul Chavard	b663939674	feat(graphql): add demarcheCloner mutation	2023-01-11 23:38:12 +01:00
Paul Chavard	afc1f12028	feat(graphql): implement add/remove instructeurs via API	2023-01-10 20:33:35 +01:00
Sébastien Carceles	177dec2bdb	feat(dossier): add dossier id to prefill response (#8382)	2023-01-06 13:46:27 +00:00
Martin	3918757dc9	correctif(test): desormais l'association batch_operations.groupe_instructeurs passe par le dossier. Mise a jour des tests	2023-01-05 16:20:18 +01:00
Sébastien Carceles	1de969915a	rename file to match controller name (#8371)	2023-01-05 14:38:56 +01:00
Sébastien Carceles	456be420fa	feat(demarche): describe dossier prefilling with POST (#8298) ... * feat(demarche): describe dossier prefilling with POST * show response example	2023-01-04 07:31:31 +00:00
Martin	a4d6692bc6	accessibilite(pages-authentification): evolutions des pages de connexion/creation de compte pour respecter le DSFR et supporter une meilleure accessibilite ... Update app/components/dsfr/input_component/input_component.html.haml Co-authored-by: Colin Darie <colin@darie.eu>	2023-01-03 16:26:05 +01:00
Sébastien Carceles	20136b7ac8	feat(demarche): create and prefill a dossier with POST request (#8233) ... * add base controller for public api * add dossiers controller with basic checks * create the dossier * ensure content-type is json * prefill dossier with given values * mark a dossier as prefilled When a dossier is prefilled, it's allowed not to have a user. Plus, we add a secure token to the dossier, which we will need later to set a user after sign in / sign up. * set user as owner of an orphan prefilled dossier When a visitor comes from the dossier_url answered by the public api, the dossier is orphan: - when the user is already authenticated: they become the owner - when the user is not authenticated: they can sign in / sign up / france_connect and then they become the owner So here is the procedure: - allow to sign in / sign up / france connect when user is unauthenticated - set dossier ownership when the dossier is orphan - check dossier ownership when the dossier is not - redirect to brouillon path when user is signed in and owner * mark the dossier as prefilled when it's prefilled (even with a GET request, because it will be useful later on, for exmample in order to cleanup the unused prefilled dossiers) * system spec: prefilling dossier with post request	2023-01-03 14:46:10 +01:00
Martin	186d4e6539	correctif(ChampDepartement): gere les departement a 3 codes	2022-12-27 14:55:57 +01:00
Martin	48c80e9387	correctif(api/v1): ajoute la methode manquante for_api sur le type de champs departement	2022-12-27 11:45:43 +01:00
Paul Chavard	4a4ce67ef6	fix(dossier): explicitly send draft notification email	2022-12-26 22:02:33 +00:00
Paul Chavard	00218fded2	fix(dossier): update spec	2022-12-21 14:03:02 +01:00
Sébastien Carceles	dd0a05c1d8	feat(prefill): add possible values (#8299) ... * update layout in order to show possible values * filter out non fillable types de champ	2022-12-20 11:04:42 +01:00
Sébastien Carceles	0a10a08c21	feat(demarche): describe procedure prefilling (#8187) ... * feat(demarche): description Show the description of an opendata procedure (published or draft), with help about how to prefill a dossier for this procedure. Co-authored-by: Damien Le Thiec <damien.lethiec@gmail.com>	2022-12-19 11:32:09 +00:00
Martin	2be4441a70	amelioration(attestion.et.mail): deduplique les message d'erreur, améliore les messages d'erreur, gère la pluralisation des erreurs lorsque plusieurs tags sont concernés	2022-12-19 09:28:46 +01:00
Martin	dd74834689	amelioration(attestation.et.mail): desactive les tags sur les champs conditionnés et informe l'usager que ca arrivera	2022-12-19 09:28:46 +01:00
Martin	ef389eab41	amelioration(attestation.et.mail): repositionne les messages d'erreur lié à la substitution des balises a proximité du formulaire pour faciliter la comprehension. passage des champs au DSFR	2022-12-19 09:28:46 +01:00
Christophe Robillard	f1595d1f50	wrap resultset tuples in ProcedureDetail	2022-12-16 15:51:49 +01:00
Christophe Robillard	3a660349ad	export all demarches	2022-12-16 15:51:49 +01:00
Christophe Robillard	cea92c0488	perf: remove n+1 queries to count admin	2022-12-16 15:51:49 +01:00
Eric Leroy-Terquem	2645ac85f7	update wording and order in types de champ select	2022-12-16 09:30:36 +01:00
Paul Chavard	cb5b60ccda	Revert "Revert "Merge pull request #7907 from tchak/feat-cond-repetitions"" ... This reverts commit 0d10d36cb0. # Conflicts: # app/models/dossier.rb # app/models/dossier_preloader.rb	2022-12-15 19:09:25 +01:00
Sébastien Carceles	b8ff0ba4a2	feat(demarche): sign up when prefilling a dossier (#8247) ... * store prefill params in session Instead of using query params on /dossier/new, we assume the user comes from /commencer/:path, which is the new prefill link. There, we store the prefill params in session, and use them to prefill the dossier when creating it, in /dossiers/new. * spec: cover the case * review: serialize with json instead of yaml * review: rename method * review: store only query params * review: comment why we dont override already stored params	2022-12-15 10:58:17 +01:00
Lisa Durand	89730b485b	add bulk action feature for 'passer_en_instruction'	2022-12-15 10:04:25 +01:00
Colin Darie	3a9a71079a	Merge branch 'main' into pj-en-construction-replace	2022-12-14 16:59:48 +01:00
Paul Chavard	1b95809f14	refactor(dossier): flatten champ attributes	2022-12-14 13:03:06 +01:00
Paul Chavard	0d10d36cb0	Revert "Merge pull request #7907 from tchak/feat-cond-repetitions" ... This reverts commit 1900f8ff4c, reversing changes made to febffc2d64. # Conflicts: # app/models/dossier.rb	2022-12-14 11:25:45 +01:00
Colin Darie	4049240c2c	feat(piece_justificative): allow user to replace a PJ for dossier en_construction	2022-12-14 09:58:15 +01:00
sebastiencarceles	cdd790e3d3	review: document prefilling with json or array injection	2022-12-08 15:27:39 +01:00
sebastiencarceles	bf03e3b35a	review: prefix typed ids with 'champ_'	2022-12-08 15:27:39 +01:00
sebastiencarceles	1e21a3d3e1	review: query the db only once	2022-12-08 15:27:39 +01:00
sebastiencarceles	24802985a2	feat(dossier): prefill dossier from query params	2022-12-08 15:27:39 +01:00
Paul Chavard	16a48c02aa	feat(cond): add tests	2022-12-08 09:38:12 +01:00
Paul Chavard	52c8fc7e8d	feat(api_token): api v2 use new token	2022-12-07 18:19:37 +01:00
Paul Chavard	a47a056ee8	feat(api_token): api v1 use new token	2022-12-07 18:19:37 +01:00
Paul Chavard	3c21090a88	feat(api_token): add profile api token card	2022-12-07 18:19:37 +01:00
Paul Chavard	73ff739c52	refactor(graphql): extract stored queries spec in a separate file	2022-12-07 12:06:55 +01:00
Paul Chavard	b8a9b7223c	refactor(groupe_instructeur): improuve controller	2022-12-06 12:01:54 +01:00
Colin Darie	4ba76e6844	fix(api-v1): dossier -> avis -> piece_justificative_file_attachment relation name	2022-12-06 11:48:42 +01:00
Martin	6556fda218	clean(spec): rubocopify / fix specs	2022-12-06 11:28:48 +01:00
Martin	b0ae2e8a0f	clean(spec): rubocopify / fix specs	2022-12-06 11:28:48 +01:00
Lisa Durand	7b3cbcb8f6	display batch operation alerts	2022-12-06 11:28:48 +01:00
Lisa Durand	6859882a58	display batch operation alert to instructeur groups not only instructeur	2022-12-06 11:28:48 +01:00
Lisa Durand	c52443f221	change flash alert wording and display message in show if dossier is in batch	2022-12-06 11:28:48 +01:00
Lisa Durand	1beb219fdd	display batch operation alerts	2022-12-06 11:28:48 +01:00
Martin	e5944eed34	poc(batch_operation): habtm groupe instructeurs, permettra de visualiser plus facilement les batch en cours pour les instructeurs du meme groupe	2022-12-06 11:28:48 +01:00
Martin	eaf72162da	poc(batch_operation): some rewrite to avoid various conflict (when an instructeur try to create a job with an incompatible dossier regarding the current task). also soome cleanup to isole spec in least involved model	2022-12-06 11:28:48 +01:00
Martin	7a51ecec5d	poc(batch_operation): quand un dossier est dans un batch, impossible de faire les actions : archive, unarchive, follow, unfollow, passer_en_instruction, repasser_en_construction, repasser_en_instruction, terminer, restore, destroy, extend_conservation	2022-12-06 11:28:48 +01:00
Martin	beb39027d0	poc(batch_operation.ui): implement simple ui to trigger a batch of current page	2022-12-06 11:28:48 +01:00
Martin	7df86c50fb	poc(batch_operations_controller): implement simple [not yet with procedure_presentation] action to create a batch operation	2022-12-06 11:28:48 +01:00
simon lehericey	8771205679	clean(flipper): remove unused expert_not_allowed_to_invite	2022-12-05 12:22:29 +01:00
Colin Darie	b9d6397a9b	fix(pj_template): private proxy template url so their links are non expirable ... Closes #7920	2022-12-05 11:30:00 +01:00
Colin Darie	1138604748	feat(api): PieceJustificativeChamp: deprecate file in favor of files	2022-12-05 10:47:10 +01:00
Colin Darie	6a0379086d	chore(piece_justificative): continue attachments refactor	2022-12-05 10:47:10 +01:00
Paul Chavard	00556715d6	fix(typography): fix quotes	2022-12-01 17:59:11 +01:00
Paul Chavard	886a409abf	fix(dossier): fix links to empty pdf templates	2022-12-01 17:35:01 +01:00
Paul Chavard	c5901fbb95	clean(type_de_champ): remove magic factory	2022-12-01 16:36:59 +01:00
Paul Chavard	1fb051c3cc	refactor(attestation_template): remove unused code	2022-11-29 19:36:56 +01:00
simon lehericey	801d594efd	fix(avis_controller): revoked_acl on telecharger_pjs	2022-11-29 16:21:06 +01:00
simon lehericey	a84269e66e	fix(avis_controller): revoked acl on bilans_pdf	2022-11-29 16:21:06 +01:00
simon lehericey	d764959659	fix(avis_controller): revoked acl on create_commentaire	2022-11-29 16:21:06 +01:00
simon lehericey	20fcfdeb5e	clean(avis_controller_spec): procedure_id: procedure.id -> procedure_id:	2022-11-29 16:21:06 +01:00
simon lehericey	8929af2767	fix(avis_controller): revoked acl on messagerie	2022-11-29 16:21:06 +01:00
simon lehericey	71dd0b99ab	fix(avis_controller): revoked acl on update_expert	2022-11-29 16:21:06 +01:00
simon lehericey	531cbf2612	fix(avis_controller): revoked acl on update	2022-11-29 16:21:06 +01:00
simon lehericey	3be17da70e	fix(avis_controller): revoked acl on update	2022-11-29 16:21:06 +01:00
simon lehericey	cb2e1db52e	clean(avis_controller_spec): update	2022-11-29 16:21:06 +01:00
simon lehericey	6aa2ccacd4	fix(avis_controller): fix revoked acl on create_avis	2022-11-29 16:21:06 +01:00
simon lehericey	3c477691c3	clean(avis_controller_spec)	2022-11-29 16:21:06 +01:00
simon lehericey	c17bc50def	fix(avis_controller): acl on instruction	2022-11-29 16:21:06 +01:00
simon lehericey	f500cb8dc7	fix(avis_controller): procedure do not show revoked avis	2022-11-29 16:21:06 +01:00
simon lehericey	dcae06ae84	fix(avis_controller): index do not linked to revoked avis	2022-11-29 16:21:06 +01:00
simon lehericey	6ad048955b	clean(avis_controller_spec)	2022-11-29 16:21:06 +01:00
simon lehericey	644b88ea0e	clean(avis_controller_spec)	2022-11-29 16:21:06 +01:00
simon lehericey	d0c0d6c491	fix(spec): speed up *5	2022-11-29 16:21:06 +01:00
Paul Chavard	ee30a95847	fix(graphql): check if tokens are revoked	2022-11-25 16:27:11 +01:00
Paul Chavard	5a9ce7a331	feat(graphql): make demarche schema public	2022-11-24 18:21:33 +01:00
Christophe Robillard	3539b00652	search admins by email	2022-11-24 15:05:46 +01:00
Paul Chavard	234975b806	feat(graphql): expose groupe_instructeur state and update mutation	2022-11-24 14:33:29 +01:00
Martin	bb993d552e	amelioration(avis): sur une page listant les avis en attente sur une procedure, on remonte le dernier avis demandé en premier	2022-11-24 14:23:06 +01:00
Paul Chavard	e395ab5c87	fix(invite): do not render menu when invite not found	2022-11-24 09:43:19 +01:00
Paul Chavard	cafda4f6f0	refactor(attestation_template): move to procedure	2022-11-23 12:26:26 +01:00
Christophe Robillard	8e95c6a2ba	search procedures by libelle	2022-11-22 17:08:17 +01:00
simon lehericey	4babee2591	fix(admin): ignore active column ... the attribut should be retrieve from the user model as the administrateur is no more a devise model	2022-11-22 16:41:20 +01:00
simon lehericey	30b53ec927	feat(procedure_admins): allow self remove from procedure	2022-11-22 16:41:20 +01:00
Paul Chavard	29bdd82b59	refactor(procedure): types_de_champ -> active_revision.types_de_champ_public	2022-11-17 13:54:14 +01:00
Colin Darie	54699d35a8	test(manager): fix test after administrate upgrade	2022-11-15 17:28:04 +01:00
Colin Darie	7b9ff5ebe8	test(manager): add basic test on dossiers index & show	2022-11-15 16:30:18 +01:00
Lisa Durand	c2de73c09d	simplify and improve perf by making the feature works only for id search	2022-11-15 10:51:36 +01:00
Lisa Durand	d245e12559	remove render_views in spec and correct the way to retrieve dossiers	2022-11-15 10:51:36 +01:00
Lisa Durand	ba0799b684	it displays a message if instructor is looking for a dossier that is not in his instructor group	2022-11-15 10:51:36 +01:00
Martin	05dcf5e7cf	amelioration(usager.liste_des_dossier): ajout du bouton pour cloner un dossier	2022-11-14 09:13:54 +01:00
Paul Chavard	e6288c39f2	refactor(dossier): champs -> champs_public	2022-11-10 22:44:39 +00:00
Christophe Robillard	cc35788d26	extract computation to controller	2022-11-10 18:02:20 +01:00
Christophe Robillard	24e7de71e3	add procedures_filter specs	2022-11-10 18:02:20 +01:00
Paul Chavard	5e87539d6d	fix(groupe_instructeur): add explicit order to groupe_instructeurs	2022-11-09 10:56:40 +00:00
Christophe Robillard	a5fa21ca1b	add from_publication_date filter	2022-11-09 10:41:06 +01:00
Martin	a1dbc40f57	evolution(helpscout.webhooks): mise en place des rappel web afin de notifier l'equipe tech des bug identifies par le support ... Co-authored-by: Colin Darie <colin@darie.eu>	2022-11-08 17:00:03 +01:00
simon lehericey	db3ebfa6d2	feat(FranceConnect): list and allow to unlink FC identities	2022-11-08 16:17:06 +01:00
Christophe Robillard	c0231dffa2	extract ProceduresFilter class	2022-11-08 12:14:26 +01:00
Paul Chavard	3ced06d59b	feat(graphql): improuve groupe instructeur query	2022-11-04 11:27:58 +00:00
Eric Leroy-Terquem	aca2775874	remove routee? method	2022-11-04 12:03:44 +01:00
Eric Leroy-Terquem	b51770c151	toggle routing after groupe instructeur update	2022-11-04 12:03:44 +01:00
Eric Leroy-Terquem	110953e450	constraint logic to active groups	2022-11-04 12:03:43 +01:00
Eric Leroy-Terquem	b419c48262	toggle routing when adding or deleting groupe_instructeurs	2022-11-04 12:03:43 +01:00
Paul Chavard	33fc8a45ab	feat(emails): show email errors on procedure page	2022-11-04 09:08:41 +00:00
Paul Chavard	5487ce0458	feat(graphql): implement stored queries	2022-11-02 11:26:57 +01:00
Christophe Robillard	22fe357d75	list all demarches, filtered by status	2022-10-31 16:12:02 +01:00
Christophe Robillard	9abf1c4af3	list all demarches, filtered by zones	2022-10-31 16:12:02 +01:00
Paul Chavard	2ed26e8699	fix(graphql): properly handle variables json parse errors	2022-10-31 11:32:30 +01:00
Colin Darie	9f2fa5ee1c	fix(invitation): don't fail when dossier is hidden & user signed on another account ... Suite de 45994ff567 Cf https://sentry.io/organizations/demarches-simplifiees/issues/3422144920/events/e1c83ea74dbc410ea22aa17ef29fb329/?project=1429550	2022-10-28 08:56:03 +02:00
simon lehericey	d1a8731bfc	refactor(spec): faster service spec	2022-10-25 14:44:43 +02:00
simon lehericey	6af4fe624a	refactor(service): explicit call to service job to avoid test side effect	2022-10-25 14:44:43 +02:00
Kara Diaby	9529c6ba9c	tests	2022-10-21 19:13:12 +02:00
Paul Chavard	85581e72e9	refactor(turbo): simplify custom actions implementation now that turbo has support for it	2022-10-21 10:24:00 +02:00
Colin Darie	45994ff567	fix(invitation): when dossier is not visible anymore ... https://sentry.io/organizations/demarches-simplifiees/issues/3422144920/	2022-10-20 09:08:36 +02:00
simon lehericey	de875632e6	refactor(spec): use match_array	2022-10-14 09:45:58 +02:00
Paul Chavard	d409b6f4ef	feat(dossier): do not save dossier on submit	2022-10-13 14:44:46 +02:00
Damien Le Thiec	73f6063c87	Merge branch 'main' into feature/add_rna_type_de_champs	2022-10-11 15:36:46 +02:00
Martin	1f8bf201a2	feat(procedure_serializer): just add an empty string for direction	2022-10-07 18:39:17 +02:00
Martin	6752da40a9	test(procedure.direction): can we drop this column ?	2022-10-07 18:39:17 +02:00
krichtof	44018a86de	a procedure without zone is finally valid	2022-10-07 16:59:12 +02:00
Christophe Robillard	bdcb451d3c	procedure publiee must have one zone at least	2022-10-07 10:48:35 +02:00
Christophe Robillard	4d2c37ffdf	extract checkboxes zones to dedicated page	2022-10-07 10:48:35 +02:00
Damien Le Thiec	abbbef1461	Fix tests	2022-10-05 13:07:39 +02:00
Damien Le Thiec	0131a41266	Merge branch 'main' into feature/add_rna_type_de_champs	2022-10-05 12:38:24 +02:00
Damien Le Thiec	93e89c8968	Fix small bugs rna controller and add tests	2022-10-05 12:31:34 +02:00
Martin	54a47fadae	fix(sentry/3422144920): old email using TargetUserLink creates confusing errors	2022-10-04 11:41:32 +02:00
Paul Chavard	b0aa777315	refactor(ujs): france_connect controller to use turbo	2022-09-29 16:51:54 +02:00
Paul Chavard	df47f4a7ab	feat(graphql): new tokens should carry administrateur_id	2022-09-29 11:58:58 +02:00
simon lehericey	6b35155bd8	fix condition_controller_spec	2022-09-28 10:06:32 +02:00
Colin Darie	fe2b3ec936	feat(instructeurs/dossier): explicit error about impossible transition due to incomplete etablissement	2022-09-21 16:00:59 +02:00
simon lehericey	9d2d19800d	feat(champ siret): save etablissement in degraded mode if api down and allow submission	2022-09-19 12:12:05 +02:00
Colin Darie	95a4e8a907	feat(api_entreprise): create etablissement with fallback when API is down ... On créé l'établissement uniquement avec le SIRET, sans que ce soit bloquant pour compléter le dossier. On demande à l'utilisateur de vérifier lui-même la concordance du SIRET avec son entreprise. Cf #7766	2022-09-16 10:43:59 +02:00
Colin Darie	c4f6305b3a	fix(dossiers/api_down): specific error when API Entreprise is globally down.	2022-09-15 18:53:41 +02:00
sebastiencarceles	90d795d1e0	fix: remove instructeur when admin is removed	2022-09-13 09:44:49 +02:00
sebastiencarceles	9aaef79a3d	review: use salt to generate key	2022-09-13 07:47:30 +02:00
sebastiencarceles	f154bb56e6	confirm adding a new admin to a procedure ... For clarity and a better understanding, use a dedicated controller to allow the current admin to confirm adding an administrateur to a procedure.	2022-09-13 07:45:07 +02:00
sebastiencarceles	4123709e72	build and render secured URL to invite admin ... For clarity and a better understanding, use a dedicated controller to build and render the confirmation URL to share in order to add a new administrateur.	2022-09-13 07:45:07 +02:00
simon lehericey	c43bf2e5c9	fix(conditional): only parse user input as int if compared with a number	2022-09-09 11:28:32 +02:00
mfo	44f366d7f4	Merge branch 'main' into helpscout/1987597382	2022-09-08 12:03:01 +02:00
Paul Chavard	d6f5be622c	feat(dossier): autosave en construction	2022-09-08 11:26:29 +02:00
Martin	cbe77dd2f6	bug(instructeurs/dossiers#telecharger_pjs): zipline does not play well with not available active storage attachments	2022-09-08 11:05:24 +02:00
Colin Darie	3c9b41e233	fix(manager/services): d'ont search in etablissement_adresse (this is not a schema field)	2022-09-06 09:23:52 +02:00
Colin Darie	23fbc9210e	test(graphql): don't perform irrelevant & unmocked APIEntreprise::ServiceJob ... They would require heavy mocks otherwise	2022-09-06 09:23:52 +02:00
Colin Darie	64ce2719ed	feat(services): accept an optional SIRET ... Closes #7359	2022-09-06 09:23:52 +02:00
Colin Darie	54181bd920	refactor(spec/services): dynamic procedure reference instead of hardcoded id	2022-09-06 09:23:52 +02:00
Colin Darie	7f1764fa66	test(support): add contact-admin spec	2022-09-05 17:41:17 +02:00
simon lehericey	d612c39438	fix(admin procedure preview): redirect is procedure invalid	2022-09-05 10:18:33 +02:00
Kara Diaby	a52aeb6fdc	tests	2022-09-02 16:23:27 +02:00
Martin	51680b11c2	feat(Adminstrateur::Procedures#clone): redirect to home of procedure with special info regarding procedure presentation & service	2022-08-31 14:56:00 +02:00
Christophe Robillard	efbec80af8	update saml controller and views ... because of using another gem (saml_idp)	2022-08-23 15:05:20 +02:00
Martin	dc524cf615	fix(spec): broken spec due to TDD and refacto on former code	2022-08-23 13:28:10 +02:00
Martin	25c0e91d87	feat(Administrateurs::GroupeInstructeur): ensure admin from super admin can not add an instructeur	2022-08-23 13:28:10 +02:00
Martin	d1544bc4ae	feat(Administrateurs::ProcedureAdministrateurs): ensure admin from super admin can not add administrateur	2022-08-23 13:28:10 +02:00
Martin	d1297bc1f5	tech(rubocopify): ... just clean up ...	2022-08-23 13:28:10 +02:00
Martin	5e8210b8f8	feat(Administrateur::ExportsController#*): prevent SuperAdmin to ask/download export	2022-08-23 13:28:10 +02:00
Martin	bfd0f3379f	feat(Instructeur::ArchivesController#*): prevent SuperAdmin to index/download archives	2022-08-23 13:28:10 +02:00
Martin	c2e0994e11	feat(Administrateur::ArchivesController#*): prevent SuperAdmin to index/download archives	2022-08-23 13:28:10 +02:00
Kara Diaby	58f2f6bd9d	Manager : permet au super admin de se retirer d'une démarche	2022-08-11 10:58:58 +02:00
Christophe Robillard	e087582f57	Can get dossier vide if procedure is closed	2022-08-05 16:00:08 +02:00
Paul Chavard	2d7803cd48	refactor(spec): use new procedure.types_de_champ factory	2022-08-04 12:10:32 +02:00
Colin Darie	bc7cdb6b8e	fix(contact): translate captcha honeypot label	2022-08-03 11:57:26 +02:00
Colin Darie	d53aba4d24	fix(dossier_transfer): require a valid email ... Cf #7621	2022-08-03 11:44:54 +02:00
Colin Darie	a5d5f4307f	fix(dossier_transfer): avoid all transfers without valid email ... Cf #7621	2022-08-03 11:44:54 +02:00
Martin	7f1018c5b0	feat(Users::CommencerController#commencer): ensure to redirect to replaced_by_procedure when it exisits	2022-08-02 13:08:36 +02:00
Colin Darie	4284f14ad8	fix(services): can destroy with discarded procedures ... Closes #7626	2022-08-02 11:45:16 +02:00
Christophe Robillard	c8abe092c1	display alert message when no email is given for an invite ... no exception is raised anymore in this case	2022-07-27 15:05:00 +02:00
Paul Chavard	8cba80116e	fix(types_de_champ): fix exception on validation errors	2022-07-26 18:17:48 +02:00
simon lehericey	369141c7f7	Fix(procedure library): replace infinite list by a basic search	2022-07-26 12:38:05 +02:00
Paul Chavard	4276745338	fix(autosave): morph instead of replace to preserve controller instances	2022-07-26 11:15:10 +02:00
Martin	3e56fdd1d7	fix(export): when it takes more than 3 hours, exports are purge before being generated. make it possible to have an export that takes more than 3 hours and share this behaviour with kind of same class archive	2022-07-25 10:48:54 +02:00
Paul Chavard	430365768a	test(dossier.pdf): add a test case with piece_justificative inside repetition	2022-07-21 11:46:28 +02:00
Martin	87af7f3261	feat(exports): implement admin export	2022-07-20 14:08:33 +02:00
Colin Darie	d3232a28cd	chore(api_entreprise): intercept token expiration for a more contextual frontend message ... Auparavant le service échouait silencieusement et ne retournait rien, ce qui dans les implémentations du front aboutissait au message que l'établissement/l'entreprise n'a pas été trouvé. Un type d'erreur spécifique sur l'expiration du token permet d'afficher le message lié à un problème temporaire de récupération d'infos.	2022-07-18 09:57:19 +02:00
Colin Darie	8c08d0295b	Revert "feat(champ): customizable placeholders for text & textarea champs" ... This reverts commit 9e26ee932e. Finalement les champs génériques ne doivent pas avoir de placeholder personnalisable, ce sera uniquement via la description.	2022-07-12 11:37:58 +02:00
simon lehericey	0179a0a826	update conditions_controller	2022-07-12 10:44:40 +02:00
simon lehericey	2fee0ddfd4	feature: type_de_champ_controller	2022-07-12 10:44:40 +02:00
simon lehericey	3eadff9111	refactor spec	2022-07-12 10:44:40 +02:00
Colin Darie	9e26ee932e	feat(champ): customizable placeholders for text & textarea champs ... Closes #7429	2022-07-11 17:16:20 +02:00
mfo	30c02491eb	Update spec/controllers/targeted_user_links_controller_spec.rb ... Co-authored-by: LeSim <mail@simon.lehericey.net>	2022-07-11 14:37:01 +02:00
Martin	9f6a8cfe33	bug(targeted_user_link): from invite when user is not created, user check fails	2022-07-11 14:37:01 +02:00
simon lehericey	1751ddf713	add condition controller	2022-07-06 16:35:23 +02:00
Martin	7fb85c97cb	feat(Administrateur::ArchivesControllers): add archives #index and #create for admin	2022-07-04 14:18:46 +02:00
simon lehericey	73d5d5c919	fix spec by removing weird include	2022-07-02 16:42:32 +02:00
Martin	ab4d4c83a8	feat(GroupeInstructeurs.closed): add closed option to GroupeInstructeur in order to prevent usagers to submit dossier	2022-06-20 16:32:06 +02:00
Martin	274b5eab2e	feat(invite): wrap invitation with targeted_user_links	2022-06-17 16:44:37 +02:00
Paul Chavard	350ed3a11a	feat(graphql): expose revision on demarche descriptor type	2022-06-17 12:33:35 +02:00
Paul Chavard	1573d20ee9	types_de_champ controller to use turbo	2022-06-17 11:04:09 +02:00
Martin	8b487c847b	fix(instructeurs/avis#revive): ArgumentError on AvisMailer.avis_invitation	2022-06-14 08:41:09 +02:00
Kara Diaby	d58ecb3fcc	Lors de la restauration d'une démarche supprimée, met sur les dossiers liés hidden_by_administration_at à nil	2022-06-10 12:33:47 +02:00
Martin	cb890343ff	feat(targeted_user_link): add targeted user link to wrap expert invitation in order to avoid access issue when the expert is connected with another account ... feat(user.merge): ensure to merge user.targeted_user_link Update app/models/targeted_user_link.rb Co-authored-by: LeSim <mail@simon.lehericey.net> Update app/models/targeted_user_link.rb Co-authored-by: LeSim <mail@simon.lehericey.net> Update app/models/targeted_user_link.rb Co-authored-by: LeSim <mail@simon.lehericey.net> feat(db/create_targeted_user_links): ensure not null with fk	2022-05-31 14:50:31 +02:00
Paul Chavard	02675a104d	fix(revision): fix tests to use new revison system	2022-05-31 08:58:53 +02:00
Martin	91f1fa4ffb	bug(avis#instruction): fail when claimant had been destroyed during a merge	2022-05-30 15:42:36 +02:00
Kara Diaby	51b8d8f254	tests	2022-05-30 14:40:49 +02:00
Paul Chavard	8c6feb1e1f	feat(graphql): expose repasser_en_construction and repasser_en_instruction	2022-05-23 18:12:33 +02:00
Paul Chavard	99a8786dd5	fix(expert): expert should be allowed to delete messages	2022-05-20 15:47:48 +02:00
Paul Chavard	e33022ffc7	refactor(dossier): export to use turbo-poll	2022-05-17 16:08:47 +02:00
Paul Chavard	e9b02642c5	refactor(attachment): attachments controller to use turbo	2022-05-17 16:08:47 +02:00
Paul Chavard	95bd13872b	refactor(dossier): change state with turbo	2022-05-13 17:38:09 +02:00
Martin	da57a1dc9e	fix(commencer#commencer): broken due to missing interpolated variable in i18n	2022-05-13 13:15:31 +02:00
Martin	0826baeba3	bug(commencer#commencer): raise when procedure does not have a service ... fix(commencer#commencer): use alternate message when procedure does not have a service	2022-05-12 16:41:11 +02:00
Paul Chavard	c9b8d43acd	feat(autosave): use new autosave controller	2022-05-10 18:10:20 +02:00
Kara Diaby	7b73cb239a	tests	2022-05-10 17:13:08 +02:00
simon lehericey	0fc71afc29	spec: fix private type de champ repetition	2022-05-06 10:34:40 +02:00
Martin	3737311390	feat(procedure.procedure_expires_when_termine_enabled): enable by default, allow contributor to choose the default settings of this flag using an env var during migration. ie: DEFAULT_PROCEDURE_EXPIRES_WHEN_TERMINE_ENABLED=true|false ... feat(administrateurs/procedures#show): warning/alert when procedure_expires_when_termine_enabled is not true on current procedure feat(administrateur/procedure#update): after an update redirect to procedure show: suggested by: https://ux.stackexchange.com/questions/55291/after-updating-form-should-redirect-back-to-form-itself-or-to-the-show-page-or-b and confirmed by Olivier clean(Flipper.archive_zip_globale): no more in use, so remove all occurences Update app/views/administrateurs/procedures/_suggest_expires_when_termine.html.haml Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com> Update app/views/administrateurs/procedures/_suggest_expires_when_termine.html.haml Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com> Update app/views/administrateurs/procedures/_suggest_expires_when_termine.html.haml Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com> Update spec/views/administrateurs/procedures/show.html.haml_spec.rb Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com> fix(review): typo, why ena?, who knows fix(env.example.optional): add missing DEFAULT_PROCEDURE_EXPIRES_WHEN_TERMINE_ENABLED	2022-05-05 13:07:11 +02:00
Pierre de La Morinerie	9bc5364ca2	app: add controller and view to generate a deposit receipt	2022-05-04 16:09:52 +02:00
Paul Chavard	f8e3397f82	refactor(turbo): password complexity check use turbo	2022-05-04 14:11:43 +02:00
Paul Chavard	2db892d876	refactor(turbo): champ siret and dossier_link use turbo	2022-05-04 14:11:43 +02:00
Paul Chavard	1c2bd5543f	refactor(turbo): champ carte use turbo	2022-05-04 14:11:43 +02:00
Paul Chavard	39ecc669b1	refactor(champ): simplify dossier link champ	2022-05-03 16:14:54 +02:00
Paul Chavard	3384b535c5	refactor(champ): simplify siret champ	2022-05-03 16:14:54 +02:00
Martin	2529773515	bug(commencer/test): with procedure without service nor organisation, it crashes	2022-04-28 14:19:55 +02:00
Paul Chavard	68ca9efba0	feat(dossier): use persisted dossier for preview	2022-04-28 12:20:41 +02:00
Paul Chavard	91879b89ce	fix(commentaire): unified destroy commentaire	2022-04-26 14:54:58 +02:00
Martin	418d4ede17	test(commencer): test dossier_vide_pdf and dossier_vide_pdf_test	2022-04-25 15:00:48 +02:00
Paul Chavard	cad63391db	refactor(turbo): use turbo in procedure administrateurs controller	2022-04-21 19:41:27 +02:00
Paul Chavard	69d5713c19	fix(turbo): fix anonymous controller RSpec test ... https://github.com/hotwired/hotwire-rails/issues/42	2022-04-21 19:41:27 +02:00
simon lehericey	29dacb4686	remove env dependence in spec	2022-04-11 14:40:02 +02:00
simon lehericey	1dcfb2509f	check nonce	2022-04-11 14:40:02 +02:00
simon lehericey	9938586d96	check state	2022-04-11 13:56:27 +02:00
Martin	9bac5c65ba	feat(instructeurs/dossier#create_avis): only followed dossier receive notifications, so when an instructeur ask for an avis, he follows the dossier ... Update app/controllers/concerns/create_avis_concern.rb Co-authored-by: Paul Chavard <paul.chavard@beta.gouv.fr> Update spec/controllers/instructeurs/dossiers_controller_spec.rb Co-authored-by: Paul Chavard <paul.chavard@beta.gouv.fr>	2022-04-07 09:05:23 +02:00
Martin	a9769ae277	fix(instructeur/dossiers#create_avis): as an instructeur, when I ask an avis, i hope to be notified when the expert give his avis	2022-04-07 09:05:23 +02:00
Paul Chavard	ec3ed049ef	refactor(procedure_presentation): expose filtered_sorted_ids method	2022-04-05 15:50:53 +02:00
Paul Chavard	0daae815d8	refactor(dossier): use by_statut	2022-04-05 09:42:23 +02:00
Paul Chavard	f71c89aa91	refactor(procedure): cleanup tests	2022-04-05 09:42:23 +02:00
Martin	1d99e21a27	tech(bug): identify	2022-04-04 16:28:25 +02:00
simon lehericey	7ecf20ce75	harden email validation	2022-03-24 13:00:54 +01:00
Paul Chavard	7aacb7565c	fix(dossiers): mark as read dossier on update_annotations	2022-03-22 09:19:24 +01:00
Kara Diaby	4bfcf4f9d9	tests	2022-03-17 13:57:49 +01:00
simon lehericey	0a3eb4a909	reinforce preview testing	2022-03-15 11:15:28 +01:00
Paul Chavard	a50d07400e	refactor(instructeur): cleanup destroy / restore routes	2022-03-11 14:06:34 +01:00
Paul Chavard	78bf1147d0	refactor(instructeur): use better fallback location	2022-03-11 13:55:36 +01:00
Paul Chavard	51d7fd6190	test(dossier): update spec to use visible_by_administration	2022-03-10 14:29:40 +01:00
Paul Chavard	91caef0bfe	fix(dossier): ensure submitted dossiers always have groupe instructeur	2022-03-02 16:57:12 +00:00
mfo	4346775169	Merge branch 'main' into US/fix-avis	2022-02-28 15:08:25 +01:00
Martin	48612028f4	fix(avis_controller#*): missing ACL	2022-02-28 14:24:41 +01:00
Martin	85a588541b	feat(dossier_submitted_message): add a new system to customize the standby page (/merci) after an user created his folder. this is a basic feature that will come with more options asap ... wip(dossier_created_hook): add tile to administrateurs/procedure#show in order to crud dossier_created_hook refactor(css.utilities): remove merge helpers.scss within utils.scss (same purpose). use scss each for spacer modifiers refactor(dossiers/_merci.html): extract partial _merci so we can re-use it in preview of dossier_created_hook. feat(wip): current progress	2022-02-25 14:01:18 +01:00
Paul Chavard	08030bcdb7	fix(attestation_template): handle attestation changes on procedures without revisions	2022-02-11 11:12:10 +01:00
Kara Diaby	24ff41d2c0	tests	2022-02-09 14:43:36 +01:00
Paul Chavard	12151acb99	Revert "Revert "feat(attestation): revise attestations"" ... This reverts commit 4e7733e571.	2022-02-08 16:22:59 +01:00
Paul Chavard	dad17ec2f8	Merge pull request #6906 from adullact/fix/6864-franceconnect-application-name ... [FranceConnect] les tests échouent quand la variable d'env APPLICATION_NAME a une autre valeur que celle par défaut	2022-02-08 11:53:16 +01:00
François Vantomme	dacc1dca68	fix(groupe instructeur): avoid false-negative tests due to array ordering	2022-02-04 17:43:08 +01:00
François Vantomme	27ccf6bbdd	fix(france connect): stub application name in tests	2022-02-04 17:42:02 +01:00
Kara Diaby	842cc11689	tests	2022-01-31 10:03:44 +01:00
Paul Chavard	4e7733e571	Revert "feat(attestation): revise attestations" ... This reverts commit e413872530.	2022-01-25 18:26:34 +01:00
Kara Diaby	c9f402aa5b	tests	2022-01-25 11:46:05 +01:00
Kara Diaby	7a49985e2c	tests	2022-01-24 16:47:47 +01:00
Paul Chavard	e413872530	feat(attestation): revise attestations	2022-01-19 18:00:37 +01:00
Paul Chavard	403e71b41f	feat(procedure): only purge procedures without dossiers	2022-01-18 11:22:04 +01:00
Kara Diaby	bdcb0ca0e9	tests	2022-01-12 15:49:38 +01:00
Pierre de La Morinerie	062f52feb9	Fix ProcedureAdministrateursController#destroy ... - The "no remove oneself" rule wasn't actually enforced - `flash.error` is not a flash category	2022-01-07 15:39:58 +01:00
Pierre de La Morinerie	fb75a55b89	Add specs for Administrateurs::ProcedureAdministrateursController	2022-01-07 15:39:58 +01:00
Martin	f770ac4907	fix(users/champs/piece_justificative#update): ensure to bump dossier.last_champ_updated_at otherwise instructeurs are not notified when user update their piece_justificative	2022-01-06 13:09:57 +01:00
Paul Chavard	28c1763701	a11y(champs): generalize describedby and update to use new Combo props	2022-01-05 12:33:40 +01:00
simon lehericey	00871cfe13	Fix ping controller in dev ... For an unknown reason, ActiveRecord::Base.connected? does not work anymore in dev. It returns false negative. This simple workaround can timeout. The caller has to monitor the response time.	2022-01-05 11:44:32 +01:00
Martin	252eee272b	feat(support#create): block with invisible captcha [avoid painful captcha]	2022-01-04 14:49:00 +01:00
Kara Diaby	1ca553e088	rename hidden_by_instructeur by hidden_by_administration	2022-01-03 11:51:25 +01:00
Kara Diaby	598cb09c6d	tests	2021-12-29 17:37:58 +01:00
Martin	d0ab1711ff	fix(profil_controller#update_email): ensure we are not merging same account ... fix(profil_controller#update_email): changing email from current_user.email to current_user.email destroy current user. whoops ☠️' Update config/locales/en.yml Co-authored-by: Pierre de La Morinerie <pierre.de_la_morinerie@beta.gouv.fr> Update config/locales/fr.yml Co-authored-by: Pierre de La Morinerie <pierre.de_la_morinerie@beta.gouv.fr> Update spec/controllers/users/profil_controller_spec.rb Update config/locales/fr.yml Co-authored-by: Pierre de La Morinerie <pierre.de_la_morinerie@beta.gouv.fr> Update spec/controllers/users/profil_controller_spec.rb fix(spec): broken due to typo	2021-12-29 13:36:47 +01:00
François Vantomme	14e0c68266	feat(api particulier): add MESRI field	2021-12-16 16:45:18 +01:00
Martin	b9d13df483	fix(spec): avoid flacky test. 15.days ago is not always on the previous month. eg: this spec failed on 16 of december, stats is still in december	2021-12-16 15:02:17 +01:00
simon lehericey	c7f7855f14	avoid phishing	2021-12-15 13:51:49 +01:00
maatinito	0a31c8bc79	refactor date_trunc queries using groupdate gem	2021-12-14 08:50:11 +01:00
François Vantomme	6ab8ac0662	feat (api particulier): add Pole emploi field	2021-12-08 10:36:25 +01:00
François Vantomme	2110ef072c	feat(api particulier): add DGFiP field	2021-12-07 11:03:05 +01:00
Paul Chavard	2ba05bfb4f	fix(dossier): use depose_at instead of en_construction_at	2021-12-06 15:49:17 +01:00
Martin	081d5094a9	feat(instructeurs/procedure/dossiers#extend_conservation): add extends duree conservation in action button list, also rewire this action for user [extend by procedure.duree_conservation_dans_ds by default] but force 1.month for instructeur. add new icon for standby based on https://en.wikipedia.org/wiki/Power_symbol	2021-12-06 07:20:01 +01:00
Christophe Robillard	9341c787a1	administrateur can add zone to procedure	2021-12-02 19:24:26 +01:00
Pierre de La Morinerie	ac07f05771	app: use Instructeur.bypass_email_login_token	2021-12-02 08:51:52 +01:00
Paul Chavard	46e2e34b89	fix(stats): remove super admin stats	2021-12-01 18:10:05 +01:00
Pierre de La Morinerie	9db62178d2	views: display revision errors on the procedure dashboard	2021-11-30 13:34:41 +01:00
simon lehericey	5a0fb6237f	😭 AASM does not support keyword arguments ... https://github.com/aasm/aasm/issues/672	2021-11-30 09:42:45 +01:00
Pierre de La Morinerie	184a401182	app: rename new_administrateur to administrateurs	2021-11-30 08:49:38 +01:00
simon lehericey	a0c0520502	avoid redirection to a deleted user	2021-11-29 15:27:17 +01:00
Kara Diaby	c75a9b6271	tests	2021-11-29 14:30:17 +01:00
kara Diaby	06540c1b93	tests	2021-11-26 09:45:13 +01:00
Martin	fdf0f18fda	fix(i18n): wrap text under i18n.t ... i18n(france_connect/*): replace wording with i18n fix(lint): i18n key issue secu(views/france_connect/particulier/merge.html.haml): sanitize france_connect_email just in case fix(brakeman): sanitize FCI.email_france_connect when used with html_safe via an I18n.t, also add exception to brakeman	2021-11-25 17:34:37 +01:00
Martin	21894d0a0a	feat(france_connect/particulier#callback): in case the FC email exists as an DC account which is an instructor or and administrator, returns early to new_session_path so he can connect with this existing account	2021-11-25 17:34:36 +01:00
Martin	ff073f8884	Add confirmation by email when merging DC/FC accounts ... feat(fci.confirmation_code): add confirmation code to france_connect_informations feat(user_mailer.france_connect_confirmation_code): add confirmation by email mail method/preview/spec, pointing to merge_mail_with_existing_account (reuse existing method) feat(mail_merge): mail merge feat(merge.cannot_use_france_connect): same behaviour as callback clean(fci.confirmation_code): use same token for mail validation as merge feat(resend_france_connect/particulier/merge_confirmation): resend email with link. also enhance some trads, cleanup halfy finished refacto clean(tech): finalize story by plugging merge_with_new_account to email validation fix(deadspec): was removed fix(spec): broken after last refactoring lint(rubocop): space before parenthesis lint(haml-lint): yoohoooo space before = fix(lint): scss now :D Update app/assets/stylesheets/buttons.scss cleanup feat(france_connect): re-add confirm by email, with an option for confirmation by email instead of only confirmation by email fixup! Add confirmation by email when merging DC/FC accounts fix(lint): haml_spec failure	2021-11-25 17:34:34 +01:00
mfo	e7d9d047fe	Merge branch 'main' into 6649-etq-usager-instructeur-rendre-la-suppression-plus-visible	2021-11-24 14:07:32 +01:00
Paul Chavard	758e7d68e6	fix(graphql): fix and improuve query parsing for logs	2021-11-24 13:23:05 +03:00
simon lehericey	4efd15377c	spec	2021-11-23 14:17:59 +01:00
Pierre de La Morinerie	997c197980	specs: simplify the syntax of some factories	2021-11-23 08:07:07 +01:00
Pierre de La Morinerie	09ca70eef0	specs: improve search controller specs	2021-11-23 08:07:07 +01:00
Martin	3d1533dee9	feat(users/dossiers?statut=dossiers-expirant): add dossiers-expirant tab	2021-11-19 15:14:39 +01:00
mfo	82b23b92c0	Merge branch 'main' into 6624/etq-instructeur-je-souhaite-supprimer-des-messages-envoyes-par-erreur	2021-11-17 05:41:56 +01:00
Paul Chavard	e74d599042	feat(procedure): remove duree_conservation_dossiers_hors_ds	2021-11-16 19:55:56 +03:00
Martin	f0950b592b	clean(CommentaireService): extract soft delete within controller. returning an instance with an error[:base] is not persisted with validation : avoid poluting stuff	2021-11-16 16:13:11 +01:00
Martin	4042d51d1a	tech(lint): rubocopify	2021-11-15 14:17:57 +01:00
Martin	d4c74b5621	feat(rc.1): refine with better translations, better design	2021-11-15 14:15:05 +01:00
Martin	3b78a9d81a	feat(rc): first stable	2021-11-15 13:53:32 +01:00
Martin	8b931a57d4	feat(CommentairesController#destroy): implement destroy endpoint using CommentaireService	2021-11-15 13:18:10 +01:00
Martin	b03dc6ad5d	wip(dossiers/messages/_message): poc destroy button with expected ACL support	2021-11-15 11:30:41 +01:00
Paul Chavard	da47f491b3	fix(dossier): nullify close to expiration notice timestamps when changing state	2021-11-11 12:52:58 +01:00
simon lehericey	9041e201e8	one merge at a time	2021-11-04 16:10:09 +01:00
simon lehericey	b160086cc5	update update_email to allow merge	2021-11-04 16:10:09 +01:00
simon lehericey	652b8367be	accept or refuse merge	2021-11-04 16:10:09 +01:00
Pierre de La Morinerie	0a541d678d	graphql_controller_spec: create several dossiers only when required ... Creating dossiers is faster than creating a procedure, but still slow. We can create a single dossier in the default case, and only create several others when the example requires it. Speeds up this spec from 0m 57s to 0m 49s.	2021-11-03 19:38:01 +01:00
Pierre de La Morinerie	f0e045ad25	graphql_controller_spec: create all types de champs only when required ... Creating a procedure with all available types de champ is slow. We can create a simpler procedure in the default case, and only create all types de champs when the example requires it. Speeds up this spec from 1m 55s to 0m 57s.	2021-11-03 19:38:01 +01:00
Pierre de La Morinerie	e02251c0e5	graphql_controller_spec: populate all champs only when required ... Creating a dossier with available champs populated is slow. We can create simpler dossiers in the default case, and only populate all champs when the example requires it. Speeds up this spec from 2mn 20s to 1m 55s.	2021-11-03 19:38:01 +01:00
Pierre de La Morinerie	bb1bc9140d	graphql_controller_spec: remove unused line	2021-11-03 19:38:01 +01:00
Pierre de La Morinerie	04159056af	specs: clarify spec by replacing some context by describe	2021-11-03 19:38:01 +01:00
Pierre de La Morinerie	b06183d7bf	specs: rename Dossier's with_all_champs to with_populated_champs ... This better reflects what the trait is used for, and disambiguate it from the similarly named trait in the Procedure factory.	2021-11-03 19:38:01 +01:00
Paul Chavard	c4b93f8d4a	fix(groupe_instructeur): unfollow dossiers when removed from groupe instructeur	2021-10-28 14:45:52 +02:00