Commit graph

6648 commits

Author SHA1 Message Date
mfo
36247a4b6d
Merge pull request #10770 from demarches-simplifiees/US/fix-timeouting-task-fixing-champs-commune
ETQ operateur DS, je souhaite pouvoir corriger les champs de type commune ayant de la bad data
2024-09-17 07:17:47 +00:00
Paul Chavard
9924b2d640
Merge pull request #10804 from tchak/better_drop_down_other_option
Drop down other label set to 'Enter another option' instead of 'Other'
2024-09-16 15:12:14 +00:00
Paul Chavard
34a05d0bf0
Merge pull request #10462 from demarches-simplifiees/can-filter-from-repetition-content
ETQ instructeur je peux filtrer à partir du contenu d'un bloc répétable
2024-09-16 14:59:05 +00:00
Paul Chavard
e7bc7c4783
feat(procedure): can filter from repetion content 2024-09-16 16:46:49 +02:00
mfo
7bbf04b9b5
Merge pull request #10774 from mfo/US/fix-PG-NumericValueOutOfRange
correctif: ETQ instructeur, si j'ai essayé de filtrer mes dossiers par numéro et que j'ai saisi un numero superieur à 2147483647, ma page ne doit pas planter
2024-09-16 14:43:59 +00:00
Christian Lautier
17bbc474ff
Drop down other label set to 'Enter another option' instead of 'Other' 2024-09-16 16:41:46 +02:00
mfo
18137b176c
fix(fix_champs_commune_having_value_but_not_external_id_task): timeouting despite classic pattern to find all champs for a specific type. lighten request by selecting only :id and processing batches 2024-09-16 16:38:46 +02:00
mfo
6af07dd721
data(fix): backfill invalid procedure presentation filters having a value greater than pg max integer 2024-09-16 16:36:02 +02:00
mfo
4bd518f85e
Merge pull request #10802 from mfo/US/fix-rnf-with-removed-fondation
Correctif: ETQ usager/instructeur, je souhaite pouvoir visualiser les dossiers ayant un champ fondation dont celle ci a ete supprimé du registre
2024-09-16 13:48:05 +00:00
Paul Chavard
e9009025f6
Merge pull request #10736 from demarches-simplifiees/fix-notif-to-instructeurs-when-import
Correctif: lors de l‘import en masse d'instructeurs, les nouveaux instructeurs reçoivent un lien pour vérifier leur email
2024-09-16 13:31:33 +00:00
Lisa Durand
1a75e27097
change min_length password from 8 to 12 2024-09-16 15:28:14 +02:00
Lisa Durand
22e06bc5eb
change password complexity library and setup 2024-09-16 15:28:14 +02:00
Lisa Durand
0b0e47b7cd
change passwords in specs 2024-09-16 15:28:11 +02:00
Paul Chavard
dd199eb02d
Merge pull request #10791 from demarches-simplifiees/clean_virtual_column
Tech: suppression de l'attribut maintenant obsolète `virtual` des données des procédures présentations
2024-09-16 13:22:38 +00:00
mfo
e2ec5118f4
fix(champs.rnf): some foundations was removed from the registry. lucky us [or good archi ? :D], we kept api data 2024-09-16 14:24:40 +02:00
Paul Chavard
ae7971bdea
Merge pull request #10801 from tchak/api-entreprise-get-foreign-address
fix(api-entreprise): save libelle_commune_etranger and libelle_pays_etranger in db
2024-09-16 11:04:27 +00:00
Paul Chavard
f5fdef0600
fix(api-entreprise): save libelle_commune_etranger and libelle_pays_etranger in db 2024-09-16 12:55:59 +02:00
Paul Chavard
20af103bf5
run some tests in selenium 2024-09-16 12:31:10 +02:00
Paul Chavard
a57d8f2df8
fix failing spec 2024-09-16 12:31:10 +02:00
Paul Chavard
1577fdd6af
add playwright debug helper 2024-09-16 12:31:10 +02:00
Paul Chavard
6d752fa0d1
spec(js): run axe specs in chrome for now 2024-09-16 12:31:10 +02:00
Paul Chavard
142c789e76
use playwright driver 2024-09-16 12:31:10 +02:00
Paul Chavard
7b1c882498
spec(js): cleanup js tags 2024-09-16 12:31:10 +02:00
Colin Darie
58037f21cd
Merge pull request #10778 from colinux/sharerd-controller-nav-bar-profile
UX: améliore la détection du type de profile utilisé pour la nav bar
2024-09-16 08:01:03 +00:00
Paul Chavard
f00ba04fb9
graphql(playground): fix acl 2024-09-13 14:28:13 +02:00
mfo
52610010b7
Merge pull request #10794 from mfo/US/fix-normalized-international-adresse
correctif: ETQ usager une adresse internationnale ne fait pas planter la page
2024-09-13 12:13:11 +00:00
mfo
eb3d2cb20c
bug(normalized_address): should not raise an error for addresses without code postal 2024-09-13 11:17:16 +02:00
simon lehericey
bc7d91751d
Revert "fix: ignore virtual data in column initialization"
This reverts commit 4289aa2cf5.
2024-09-13 11:00:08 +02:00
simon lehericey
317c4344fc
clean: tdc.drop_down_options 2024-09-13 10:39:48 +02:00
simon lehericey
eddbe77c09
remove virtual column attribute from procedure_presentation data 2024-09-13 10:26:52 +02:00
Mathieu Magnin
d8a0adc6ed
Merge pull request #10772 from demarches-simplifiees/fix-10751
ETQ Instructeur, jamais connecté, je ne veux pas recevoir 10 mails si j'ai été ajouté à 10 groupes
2024-09-13 08:08:16 +00:00
Paul Chavard
7286fb9ef2
Merge pull request #10775 from tchak/improuve-chromedriver-config
spec(selenium): improve chromedriver config
2024-09-12 18:46:11 +00:00
Colin Darie
8dfddba433
Merge pull request #10584 from colinux/attestation-render-list
ETQ admin, améliore l'affichage de champ choix multiple et répétitions dans les attestations v2
2024-09-12 14:40:32 +00:00
Colin Darie
16e1daac9b
fix(recherche): respects nav bar profile context 2024-09-12 10:00:18 +02:00
Mathieu Magnin
dfbc132911
[#10753] fix test that fails on CI 2024-09-11 20:22:38 +02:00
Mathieu Magnin
a99fae168c
[#10751] Allow sending a new invitation if the user's previous one has expired 2024-09-11 18:45:15 +02:00
Mathieu Magnin
790177c758
[#10751] Only send the first invitation mail to the instructeur if email is not verified (from admin controller) 2024-09-11 18:45:15 +02:00
Mathieu Magnin
d7811fca40
[#10751] Only send the first invitation mail to the instructeur if email is not verified 2024-09-11 18:45:15 +02:00
Mathieu Magnin
678c9ea6bc
[#10753] Mark email as verified for users who signed in at least once in the last 5 months. 2024-09-11 18:43:33 +02:00
Colin Darie
b5c024cca5
Merge pull request #10768 from colinux/disable-admin-hide-instructeur-toggle
ETQ tech c'est finalement par le manager qui définit si le flag pour masquer l'email des instructeurs
2024-09-11 15:29:06 +00:00
Colin Darie
b987688d19
refactor: disable auto hide instructeurs toggle by admin 2024-09-11 17:20:57 +02:00
Colin Darie
09cafdb15f
Merge pull request #10745 from colinux/helpscout-delete-old-customers
ETQ opérateur, je supprime les contacts HS > 2 ans
2024-09-11 15:19:33 +00:00
Paul Chavard
701e71cbbf
spec(selenium): improve chromedriver config 2024-09-10 21:31:30 +02:00
mfo
02bbf26d3f
feat(ProcedurePresentation): validates that ProcedurePresentation.filters using a value casted as an integer [search by id] is not out of pg integer range 2024-09-10 17:47:50 +02:00
mfo
8ebb076a29
bug(ProcedurePresentation.filtered_ids): using numbers bigger than pg limit should not raise an error 2024-09-10 17:15:35 +02:00
simon lehericey
4289aa2cf5
fix: ignore virtual data in column initialization 2024-09-09 16:37:22 +02:00
Colin Darie
ab3139c2ed
Merge pull request #10680 from demarches-simplifiees/a11y-fix-demarche-header
Refonte du menu d'aide
2024-09-09 14:17:50 +00:00
mfo
5ab57a32ce
Merge pull request #10762 from mfo/US/export-when-tdc-change
Correctif, ETQ instructeur exportant mes dossiers, je souhaite retrouver la valeur saisie par les usagers quand les types de champ ont changés de type mais que les données restent compatible
2024-09-09 09:26:42 +00:00
mfo
7ec17ff7f5
fix(dossier.export): should not use default value when types_de_champ changed to a similar one 2024-09-09 11:00:01 +02:00
Colin Darie
7c30ab87bc
Merge pull request #10712 from colinux/rails-7-finalize-defaults
Rails 7.0 : finalise la migration des defaults
2024-09-09 08:08:27 +00:00
Colin Darie
977e47fa74
Merge pull request #10757 from mfo/US/fix-required-dossier-link-with-missing-dossier
correct: ETQ administrateur, je souhaite que les types de champ liens vers un dossier pointent vers un dossier valide si ils sont obligatoire
2024-09-09 07:28:48 +00:00
Colin Darie
5d4cafc18f
Merge pull request #10722 from colinux/migrates-otp-secrets
Tech: task pour copier les secrets OTP vers les encrypted attributes
2024-09-09 07:08:30 +00:00
Colin Darie
1515e67651
Merge pull request #10760 from demarches-simplifiees/fix_unverified_admin_email
ETQ Administrateur, je peux recevoir des mails lorsque je valide mon compte depuis le mail d'invitation
2024-09-09 07:07:26 +00:00
Mathieu Magnin
71d43078ee
Merge pull request #10743 from demarches-simplifiees/fix-10742
ETQ instructeur mon adresse email est automatiquement vérifiée quand je me connecte par AgentConnect
2024-09-06 14:26:54 +00:00
mfo
ad33934059
bug(dossier.export): lose value of champ when updating the type de champ from integer_number -> decimal_number 2024-09-06 16:25:56 +02:00
mfo
fcc2b10198
tech(state): define initial state reported by Patrick, cf: https://mattermost.incubateur.net/betagouv/pl/9epn7spg4tg3pbh8jgakafhnmh 2024-09-06 16:25:14 +02:00
Mathieu Magnin
22473adec7
[#10742] Set email as verified when instructeur signs in with Agent Connect 2024-09-06 16:18:11 +02:00
Mathieu Magnin
8d68bebaed
Merge pull request #10761 from demarches-simplifiees/fix-10754
ETQ Instructeur, si je n'ai pas vérifié mon email je dois quand même recevoir un email avec login token
2024-09-06 14:14:54 +00:00
LeSim
723ea310ba
Merge pull request #10758 from demarches-simplifiees/fix-10752
ETQ Instructeur je veux avoir mon email vérifié si je reset mon mdp
2024-09-06 13:36:29 +00:00
Mathieu Magnin
ced80bf23d
rewrite test with "expect to change" syntax
Co-authored-by: mfo <mfo@users.noreply.github.com>
2024-09-06 15:12:15 +02:00
Mathieu Magnin
d1749c2baf
[#10754] verify email when using login token 2024-09-06 14:56:44 +02:00
simon lehericey
277c1a17c6
set verified_email when admin set its password from email link 2024-09-06 14:51:48 +02:00
Mathieu Magnin
95eb9ef9d4
[#10754] bypass unverified mail protection for login token emails 2024-09-06 14:15:06 +02:00
mfo
915779c9b0
Merge pull request #10749 from mfo/US/commune-without-insee
correctif: ETQ administrateur/instructeur, je souhaite que les champs de type commune aient tjr un code insee afin de router de maniere fiable
2024-09-06 11:44:00 +00:00
Mathieu Magnin
9e843a3df4
[#10752] set email verified after password reset 2024-09-06 12:06:05 +02:00
mfo
eb8b9a13ca
fix(Champs::DossierLinkChamp): when required, should point to existing dossier 2024-09-06 11:23:12 +02:00
Eric Leroy-Terquem
d361ce2e38
fix(instructeurs import): send confirmation link if new instructeurs 2024-09-06 10:00:17 +02:00
mfo
657fb0ebf4
feat(Maintenance.communes): backfill missing external_id for communes champs in error 2024-09-06 09:29:28 +02:00
mfo
5abba5a166
feat(Champs::CommuneChamp): ensure presence of external_id since some of Champs::CommuneChamp.external_id are missing while .value is present 🔥 2024-09-06 08:37:08 +02:00
Colin Darie
328844dabf
feat(task): delete contacts without activity since 2 years 2024-09-05 10:50:42 +02:00
LeSim
9fd53b182a
Merge pull request #10570 from demarches-simplifiees/feat/10425
ETQ Usager se connectant par FC, je dois confirmer mon mail
2024-09-05 08:07:23 +00:00
Colin Darie
247bb6f8c6
refactor(attestation): hide libelle of empty repetitions 2024-09-04 17:42:04 +02:00
Kara Diaby
9cebac1d99
Supprime la vérification par feature flag et utilise la vérif par booléen au booléen 2024-09-04 15:00:03 +00:00
Kara Diaby
c86ad15b8c
Ajoute hide_instructeurs_identity sur Procedures et dans l'interface admin 2024-09-04 15:00:03 +00:00
Colin Darie
9f9720d65b
fix(attestation): delete empty paragraphs 2024-09-04 15:04:07 +02:00
Kara Diaby
0b4a9bb3bb
fixe les tests suite au changement de wording sur les layouts 2024-09-04 08:08:01 +00:00
simon lehericey
eaef5c7e39
readapt name and logic 2024-09-04 08:08:01 +00:00
mfo
c0970693f3
fix(associate_user.with_existing_one): does not leak existing email when trying to choose an alternative email with france connect 2024-09-04 08:05:54 +00:00
Kara Diaby
b6d0502f39
modifications après dernière review 2024-09-04 08:05:54 +00:00
mfo
88a4619dcb
feat(particulier#associate_user): catch email already taken and redirect to reset password 2024-09-04 08:05:53 +00:00
Kara Diaby
a4b8d816de
Tests 2024-09-04 08:05:53 +00:00
Colin Darie
1524f5ba16
feat(maintenance): add task to copy super admin OTP secrets to Rails 7 encrypted attributes 2024-09-03 19:25:32 +02:00
Lisa Durand
27c8abfb4b
Merge pull request #10734 from demarches-simplifiees/cannot-publish-with-test-service-ldu
ETQ Admin, je ne dois pas pouvoir publier une démarche avec les informations du service de test
2024-09-03 15:00:30 +00:00
Lisa Durand
0da8d9449d
use other siret for factory 2024-09-02 17:13:43 +02:00
simon lehericey
523e4fff41
spec: fix flaky 2024-09-02 16:52:25 +02:00
Colin Darie
4db4cf1513
fix(attestation): don't render block levels presentation elements into a p 2024-09-02 16:11:02 +02:00
Colin Darie
c9956c4881
feat(attestation): better presentation of repetition champs 2024-09-02 16:11:02 +02:00
Colin Darie
09581ad028
feat(attestation): render multiple drop down list as list 2024-09-02 15:23:11 +02:00
Colin Darie
cb902732be
Merge pull request #10710 from demarches-simplifiees/remove-unused-hidden-at-for-dossiers-ldu
[Tech] Retirer la colonne obsolète 'hidden_at' des dossiers (part 1)
2024-09-02 12:41:28 +00:00
mfo
f171727140
Merge pull request #10703 from mfo/US/dry-rna-rnf-siret-addresses-view
ETQ instructeur, je souhaite acceder aux information liées à l'adresses des champs RNA/RNF/SIRET
2024-09-02 12:25:54 +00:00
mfo
622b3d0ff2
Merge pull request #10732 from mfo/US/unflack_expert_spec
Tech : corrige un test qui bagotait (expert_spec:141)
2024-09-02 12:25:34 +00:00
mfo
810068e5a8
fix(spec): no more flackyness on ./spec/system/experts/expert_spec.rb:141 2024-09-02 11:14:32 +02:00
mfo
7c3dd84e9f
fix(spec): broken 2024-09-02 09:55:17 +02:00
Colin Darie
46547cb2cd
Merge pull request #10729 from mfo/US/fix-errored-data
ETQ usager, je souhaite que me dossier soit debloqué
2024-08-30 17:45:04 +02:00
mfo
3a33d8af45
fix(data): unlock broken dossier due to bad release 2024-08-30 17:37:05 +02:00
Colin Darie
e7443c2308
Revert "Champ related cleanups and refactoring" 2024-08-30 16:43:30 +02:00
Eric Leroy-Terquem
4d0961d3ec
chore: remove uninterlacing from web machines 2024-08-30 14:28:43 +02:00
Eric Leroy-Terquem
0511a84abf
chore: move uninterlace to image processor job 2024-08-30 14:28:43 +02:00
simon lehericey
6677f31652
use path_rewrite in commencer controller 2024-08-29 17:01:40 +02:00
Colin Darie
ca7100c7af
chore(encryption): task rotating api particulier token encrypted attributes 2024-08-28 13:58:59 +02:00
Colin Darie
3ac671576b
chore(encryption): rotate key with new default digest (SHA256) 2024-08-28 13:58:59 +02:00
mfo
bab8fc2d29
fix(delete_orphaned_champs): maintenance tasks with custom PG_STATEMENT_TIMEOUT is not a good fit. change implementation to after_party 2024-08-27 13:43:28 +02:00
mfo
0771d207f3
Merge pull request #10716 from mfo/US/fix-bad-data
ETQ instance DS, je souhaite que l'intégrité des données entre les champs et les dossiers soient garantie par une contrainte en base de donnée
2024-08-26 14:23:25 +00:00
mfo
1d84c0f55b
fix(champs.orphaned): add maintenance task to clean orphaned champs where dossier is missing 2024-08-26 16:00:59 +02:00
Paul Chavard
32bf3ec9db
cleanup in spec 2024-08-26 14:53:56 +02:00
Paul Chavard
1aee7ab1d2
refactor(champ): more concistent champ_for_update usage 2024-08-26 14:53:56 +02:00
Paul Chavard
f7cd7e615d
refactor(champs): validate only champs in current revision 2024-08-26 14:53:56 +02:00
Paul Chavard
bb2f590d18
refactor(repetition): use less champs and public_id methods 2024-08-26 14:53:56 +02:00
Eric Leroy-Terquem
fade633828
feat(routing): can create simple routing with address tdc 2024-08-26 11:16:47 +02:00
Eric Leroy-Terquem
8b4b4d7cb7
feat(conditional): can condition and route on address champ 2024-08-26 11:16:46 +02:00
Lisa Durand
8722a10d63
fix specs 2024-08-22 17:54:24 +02:00
Lisa Durand
b586f23009
remove hidden at column from dossiers 2024-08-22 17:36:41 +02:00
Lisa Durand
8e7e8d9624
Merge pull request #10705 from demarches-simplifiees/email-expert-need-confirmation-ldu
ETQ expert, je dois confirmer mon mail
2024-08-22 12:53:52 +00:00
Lisa Durand
fae81d0a58
fix test 2024-08-22 12:09:29 +02:00
mfo
70983c50f9
spec(normalized_address): add simple spec 2024-08-22 10:37:31 +02:00
mfo
8a42c6a7ad
Merge pull request #10708 from mfo/US/format-rna
ETQ tech je souhaite que les champs RNA ne puissent pas contenir d'espace sans quoi nos appels d'API remontent un URI::InvalidURIError
2024-08-22 08:36:38 +00:00
mfo
22e50d4c9e
fix(data): normalize invalid Champs::RNAChamp.values in db 2024-08-22 10:24:03 +02:00
Colin Darie
2b9fe12079
test(dolist): add some specs and remove unsupported email sent with attachments 2024-08-22 09:26:49 +02:00
Colin Darie
659d35e11f
test: fix for mutable string 2024-08-22 09:26:49 +02:00
Colin Darie
6d9a7648e2
fix(test): disable frozen string in siret concern because it's a literal string in spec 2024-08-22 09:26:49 +02:00
Colin Darie
77fb0553fc
chore: enable freeze string literals by comment 2024-08-22 09:26:48 +02:00
Colin Darie
eccfde848f
feat(admin): disable publish button when there are errors 2024-08-21 17:38:07 +02:00
Colin Darie
d0837c58f5
fix(admin): publish modifications button must be PUT 2024-08-21 17:38:07 +02:00
Kara Diaby
4a93579e71
Ajoute une sticky navbar si il y a une modification de démarche déjà publiée 2024-08-21 10:23:02 +00:00
mfo
ec9a03ac17
Merge pull request #10693 from mfo/US/filter-by-json-path-3
ETQ instructeur, je peux filtrer par les donnée de champs issues d'API, a commencer par RNA/RNF SIRET
2024-08-21 09:50:47 +00:00
mfo
42b9ac1737
spec(filter): with rna enum 2024-08-21 10:23:56 +02:00
mfo
575c4cbdff
clean(spec): procedure_filters_spec.rb, less tdc by default 2024-08-21 10:23:56 +02:00
mfo
750842f742
feat(Column::JSONPathColumn): allow search by json path column
Co-authored-by: LeSim <mail@simon.lehericey.net>
2024-08-21 10:23:39 +02:00
Paul Chavard
271602082b
refactor(columns): rename virtual to displayable 2024-08-20 18:46:19 +02:00
Colin Darie
8cdd7ef4df
Merge pull request #10699 from mfo/US/hotfix-pp
Correctif: rattrape les données inconsistantes pour la présentation des tableaux instructeurs qui se font detruire a la 1ere connection
2024-08-20 16:16:26 +00:00
mfo
3662e38366
hotfix(ProcedurePresentation): backfill invalid procedure presentation private tabel name for type de champs private 2024-08-20 17:58:55 +02:00
Lisa Durand
16864cc868
fix test 2024-08-20 15:47:09 +02:00
Paul Chavard
686000d6cb
fix spec 2024-08-20 15:26:15 +02:00
Lisa Durand
5281ab966a
add deleted dossiers in menu for instructeurs 2024-08-20 15:26:15 +02:00
Lisa Durand
95a8f1458b
fix specs 2024-08-20 15:26:14 +02:00
Lisa Durand
ab483a8959
simplifie tabs supprimes and reduce to one 2024-08-20 15:26:09 +02:00
Colin Darie
e4d460965f
Merge pull request #10690 from mfo/US/normalize-addresses-for-rnf-rna-siret
ETQ Tech, les adresses des champs siret / rna / rnf sont normalisées pour une recherche homogène via les filtres
2024-08-20 10:11:48 +00:00
Colin Darie
1e53e3bfef
Merge pull request #10661 from demarches-simplifiees/feat/10460
ETQ admin, je veux que l'email du déposant ne puisse pas être similaire à l'email du mandataire
2024-08-20 09:34:03 +00:00
LeSim
befe74b801
Merge pull request #9758 from demarches-simplifiees/purge_supprimer_dol
Tech: quand un dossier est définitivement supprimé, on ne garde que le log (DOL) concernant sa suppression
2024-08-20 09:26:33 +00:00
mfo
bc7264ee08
Merge pull request #10625 from demarches-simplifiees/US/cleanup-procedure-presentation
ETQ tech, je souhaite isoler le concept des colonnes extractable/cherchable/affichable d'une demarche
2024-08-20 09:04:23 +00:00
simon lehericey
28b338452a
feat(dossier_purge): when the dols are purged, only keep supprimer dol but destroy its data
Note, the only remaining data are dossier_id, automatic_operation, digest and bill_id, created_at
2024-08-20 10:55:32 +02:00
simon lehericey
92da869662
spec: Dossier.purge_discarded 2024-08-20 10:55:32 +02:00
mfo
a66bd46082
data(backfill): Champs::SiretChamp.value_json [±1.4M occurences] 2024-08-20 10:31:23 +02:00
mfo
917f25dcfd
data(backfill): Champs::RnaChamp.value_json [±7.5k occurences] 2024-08-20 10:31:23 +02:00
mfo
4bf5725d6d
data(backfill): Champs::RnfChamp.value_json [±400 occurences] 2024-08-20 10:31:23 +02:00
mfo
d866309d45
feat(rnf/rna/siret): normalize address in champs.value_json 2024-08-20 10:31:23 +02:00
Paul Chavard
ba92216504
Merge pull request #10614 from tchak/graphql-only-allow-saved-queries-without-token
secu(graphql): without a token, only saved queries are allowed
2024-08-20 08:11:48 +00:00
mfo
dba6f9b3aa
refactor(Facet): to column 🚀 2024-08-19 15:46:14 +02:00
mfo
2a0537134d
fix(spec): should have been updated with facet concern sig 2024-08-19 15:30:08 +02:00
mfo
b6464c1963
tech: use facet_id to sort fields 2024-08-19 15:30:08 +02:00
mfo
31255b69cc
move/rename faceting components within their instructeur ns 2024-08-19 15:30:08 +02:00
mfo
60c6c86d70
ProcedurePresentation.displayable_fields_for_select -> InstructeurFacetPickerComponent.displayable_fields_for_select 2024-08-19 15:29:59 +02:00
mfo
41ea39abb1
ProcedurePresentation.filterable_fields_options -> InstructeurFilterComponent.filterable_fields_options 2024-08-19 15:29:59 +02:00
simon lehericey
379c9fb812
procedure should provide its facets 2024-08-19 15:29:59 +02:00
simon lehericey
c5c2d5782d
lets keep it private 2024-08-19 15:29:59 +02:00
simon lehericey
772424ff5e
move field_enum to instructeur filter component 2024-08-19 15:28:36 +02:00
simon lehericey
305b8c13c7
! BREAKING : break previous filter by type_de_champ_private
simplify type_de_champ_private -> type_de_champ, fix spec, add facet_spec
2024-08-19 15:28:36 +02:00
mfo
b3cb3e974e
refactor(Facet): extract Facet from ProcedurePresentation
Co-Authored-By: LeSim <mail@simon.lehericey.net>

clean(code): no comment 🎶
2024-08-19 15:27:39 +02:00
Kara Diaby
61525b6c2b
test 2024-08-19 12:51:39 +00:00
Corinne Durrmeyer
e358f196e9
Change help__content to help-content to conform linting Regex 2024-08-14 09:56:52 +02:00
Corinne Durrmeyer
4e1332431b
Update sepc files 2024-08-14 09:56:52 +02:00
Paul Chavard
065000cae3
Merge pull request #10674 from colinux/really-fix-rnf
ETQ usager, permet de saisir un champ RNF en ignorant les espaces/tabulations
2024-08-01 18:09:21 +00:00
Colin Darie
c2159ca0bf
fix(contact): allow deletion of contact form of users having dossiers 2024-08-01 19:44:44 +02:00
Colin Darie
720a312b00
fix(rnf): really normalize spaces
Fix #10653
2024-08-01 18:54:50 +02:00
Paul Chavard
25d4e7dfee
fix(rnf): no crash on identifiers with spaces 2024-08-01 18:00:46 +02:00
Colin Darie
3469527637
fix(contact): use user email when no email was specified 2024-08-01 16:43:28 +02:00
Paul Chavard
807d43a9a7
feat(graphql): add desarchiver mutation 2024-08-01 09:50:01 +02:00
Colin Darie
4b6d3ee16d
refactor(contact): support => contact 2024-07-31 17:08:02 +02:00
Colin Darie
5af32b46f4
refactor(contact): form is persisted in db before pushed to HS 2024-07-31 17:08:01 +02:00
Colin Darie
4bc0a04106
chore(schema): add contact_forms 2024-07-31 17:08:01 +02:00
Colin Darie
ff62e99e7b
refactor(contact): suggest email correction, strict email validation, fix admin form 2024-07-31 11:23:17 +02:00
Colin Darie
90e6c8a6f6
Merge pull request #10603 from demarches-simplifiees/bug-input-pj-apres-suppression
ETQ Admin (bug), je veux pouvoir modifier des PJ sans recharger la page
2024-07-30 12:14:11 +00:00
Colin Darie
e467be1dbc
fix(dossier): can download an expired dossier 2024-07-30 14:06:43 +02:00
Paul Chavard
bced38eb78
Merge pull request #10665 from demarches-simplifiees/a11y-fix-suspect-email
Accessibilité : Assure la restitution par les TA du bloc de suggestion de l'adresse mail
2024-07-30 09:53:01 +00:00
Corinne Durrmeyer
edf9c8807f
Update spec file 2024-07-30 11:42:29 +02:00
Paul Chavard
9d7d7da85a
Merge pull request #10572 from demarches-simplifiees/add-pj-from-messagerie-to-gallery
ETQ instructeur je peux voir les pjs envoyées par la messagerie dans l‘onglet "pièces jointes"
2024-07-30 09:35:14 +00:00
Paul Chavard
337eaff3f0
Merge pull request #10602 from demarches-simplifiees/fix-routing-fields-list
Correctif : ouvre l‘assistant de routage à tous les types de champ conditionnables
2024-07-30 09:01:24 +00:00
Paul Chavard
4e180f8f05
Merge pull request #10642 from mfo/US/api.dossier_modifier_annotation_drop_down_list
Amélioration, ETQ consommateur de l'API graphql, je souhaite pouvoir modifier une annotation de type choix simple
2024-07-30 08:25:05 +00:00
Paul Chavard
9aa86031cc
Merge pull request #10660 from colinux/fix-attestation-draft
ETQ admin sur une démarche en brouillon, l'attestation v2 est créé en brouillon si on a déjà une v1 active
2024-07-30 08:12:55 +00:00
Paul Chavard
12c11c563f
Merge pull request #10656 from colinux/fix-when-removing-all-displayed-fields
ETQ instructeur, pas d'erreur quand on veut enlever la dernière colonne affichée dans le tableau
2024-07-30 08:11:02 +00:00
Paul Chavard
b81f69580b
fix(sva/svr): fix spec with arbitrary date 2024-07-30 09:35:15 +02:00
Colin Darie
2689bc6721
fix(attestation): build v2 draft on draft procedure when a v1 is published 2024-07-29 17:06:54 +02:00
Colin Darie
25014a71b8
Merge pull request #10659 from colinux/fix-devise-confirmation-leak
ETQ usager, redirige les utilisateurs déjà confirmés qui réutilisent le lien de confirmation
2024-07-29 12:15:21 +00:00
Colin Darie
a6554aa7bf
fix(users): don't expose email of accounts already confirmed 2024-07-29 12:07:02 +02:00
Paul Chavard
2fe40343a7
Merge pull request #10646 from colinux/faq-allow-custom-image-attributes
Accessibilité: permet au markdown FAQ d'intégrer n'importe quel attribut html dans les `<img>`
2024-07-29 08:27:04 +00:00
Colin Darie
6a6e643771
fix(instructeurs): don't fail when removing all displayed fields 2024-07-26 15:55:02 +02:00
simon lehericey
c4403bffeb
work on controller 2024-07-26 13:34:50 +02:00
simon lehericey
248da3a896
work on validator 2024-07-26 13:34:49 +02:00
simon lehericey
057868a48e
small work on tiptap 2024-07-26 13:34:49 +02:00
simon lehericey
f973c59c9a
stop exporting bills with export_template 2024-07-26 13:34:49 +02:00
simon lehericey
33244f6d70
adapt pieces_justificatives_service to new export_template.attachment_path 2024-07-26 13:34:49 +02:00
simon lehericey
8906a59635
simplify export_template model and spec 2024-07-26 13:34:49 +02:00
simon lehericey
977cfc87ce
Add export_item type 2024-07-26 13:31:06 +02:00
simon lehericey
24109a0128
add exportables_pieces_jointes_for_all_versions and outdated to pj_list_concern 2024-07-26 13:31:06 +02:00
simon lehericey
53a48f963d
tdc: add libelle_as_filename 2024-07-26 13:31:05 +02:00
Corinne Durrmeyer
190addd317
Merge pull request #10647 from demarches-simplifiees/a11y-authentification-page
Améliore l'accessibilité de la page d'authentification
2024-07-26 09:38:18 +00:00
Corinne Durrmeyer
a415775e17
Merge pull request #10632 from demarches-simplifiees/a11y-fix-faq-content
Améliore l'accessibilité des pages de contenu de la FAQ
2024-07-26 09:18:02 +00:00
Paul Chavard
223317fb5a
fix(rebase): avoid errors when adding pj champs to a new revision 2024-07-25 18:29:01 +02:00
Lisa Durand
e93ea356ab
Merge pull request #10488 from demarches-simplifiees/improve-mails-for-deleted-dossiers-ldu
[usager] Laisser un délai avant suppression des dossiers expirés
2024-07-25 15:14:30 +00:00
Lisa Durand
4f7b0c93d0
fix multiple errors from creation of dedicated method to restore and extend 2024-07-25 16:55:00 +02:00
Corinne Durrmeyer
c4afbfcbf1
Update spec files 2024-07-25 12:24:25 +02:00
Benoit Queyron
3493736133
Merge pull request #10624 from demarches-simplifiees/usager-remonter-bouton-nouveau-dossier
ETQ usager - je veux pouvoir accéder plus facilement au bouton "nouveau dossier"
2024-07-25 07:20:45 +00:00
Colin Darie
efa5122ce0
feat(a11y): allow trusted markdown (FAQ) to set any custom attributes in img 2024-07-24 19:13:08 +02:00
simon lehericey
746ff92118
Add PhishingAlert maintenance task and mailer 2024-07-24 18:10:57 +02:00
mfo
e63b777bd9
feat(api.dossier.modifier_annotation): stop validation only with graphql schema, also validate with our validations methods 2024-07-24 17:48:00 +02:00
Lisa Durand
b820577461
create a method to extend and restore 2024-07-24 17:07:48 +02:00
Lisa Durand
df13e53815
small refactos from Sim review 2024-07-24 17:07:47 +02:00
Lisa Durand
94e1f048ce
fix tabs count 2024-07-24 17:07:47 +02:00
Lisa Durand
eb3b928cf2
change scope to include new column for expiring dossiers 2024-07-24 17:07:47 +02:00
Lisa Durand
0dcdcb5643
add column hidden_by_expired_at 2024-07-24 17:07:41 +02:00
Lisa Durand
0bf1790682
change wording to clarify emails 2024-07-24 17:06:31 +02:00
Lisa Durand
9346020889
dont use depreciated column hidden_at 2024-07-24 17:06:30 +02:00
Lisa Durand
8b88fafc25
add correct action for instructeur 2024-07-24 17:06:30 +02:00
Lisa Durand
c2abceaa72
hide expired dossiers instead of delete them 2024-07-24 17:06:30 +02:00
mfo
8e6c5d1567
api(mutation.dossier_modifier_annotation_drop_down_list): add mutation to change drop_down_list annotations value 2024-07-24 15:02:24 +02:00
Benoit Queyron
aae87fce0a
ajustement test dossier_action 2024-07-24 14:54:27 +02:00
Eric Leroy-Terquem
d8d2094909
db(task): remove pj files for not visible champs 2024-07-24 09:21:12 +02:00
Corinne Durrmeyer
adba85755d
Update spec file 2024-07-23 12:20:54 +02:00
Eric Leroy-Terquem
a04749c3ef
fix a flaky test 2024-07-23 10:23:54 +02:00
Eric Leroy-Terquem
78d1572c8f
test(routing): test routing on autosave 2024-07-23 10:23:54 +02:00
Paul Chavard
229483d16c
refactor(champ): remove type_de_champ_id and champ factories 2024-07-22 13:53:45 +02:00
Paul Chavard
d6f9e57e77
secu(graphql): without a token, only persisted queries are allowed 2024-07-22 11:39:32 +02:00
Paul Chavard
406d05a47a
chore(spec): remove duplicated specs 2024-07-22 11:38:11 +02:00
simon lehericey
bb6c43cbb9
do not give bad advice 2024-07-22 11:15:27 +02:00
Eric Leroy-Terquem
5fbe2daca2
db(maintenance task): create representations for pjs sent by messagerie 2024-07-22 10:07:40 +02:00
Eric Leroy-Terquem
59ddaf5b0b
feat(gallery): add pjs from messagerie to gallery 2024-07-22 10:07:39 +02:00
Paul Chavard
888be8df89
feat(champs): use new combobox for champs selection multiple 2024-07-16 15:10:45 +02:00
Paul Chavard
d640ab8428
fix(combobox): dispatch change event on multiple combo changes 2024-07-16 15:10:45 +02:00
Benoit Queyron
ec24ce3dad
ajustement test PJ dossier en construction 2024-07-16 10:51:17 +02:00
Lisa Durand
7630cc39fa
Merge pull request #10595 from demarches-simplifiees/email-mandant-need-confirmation-ldu
ETQ Mandant, je dois confirmer mon mail avant de recevoir des notifs
2024-07-15 14:00:38 +00:00
Lisa Durand
e9f5389f83
resent email if link too old and better style email 2024-07-15 12:00:03 +02:00
Lisa Durand
3eabcb0736
add tests 2024-07-15 11:56:18 +02:00
mfo
b55ed262ed
Merge pull request #10607 from mfo/US/fix-invisible-pj
Amélioration: ETQ usager, je souhaite que les PJs d'un champ qui n'est plus visible ne soient pas soumise a l'administration
2024-07-15 09:36:01 +00:00
mfo
ad8a664fe4
Merge pull request #10608 from mfo/US/fix-regexp-error
Correctif: ETQ administrateur je souhaite qu'un type de champ expression régulière ne bloque pas l'edition de ma demarche
2024-07-15 09:34:16 +00:00
mfo
1cd539297f
feat(dossier.passer_en_construction!): clean up PJ for champs that are not visible [condition is false] 2024-07-15 11:28:59 +02:00
mfo
19268345db
fix(tdc.expression_reguliere): invalid regexp shows nice error message 2024-07-15 09:59:50 +02:00
mfo
29d36973ba
bug(tdc.expression_reguliere): invalid regexp should not raise error 2024-07-15 09:54:44 +02:00
Paul Chavard
f74e8d9c56
disable test untill we can figure out what to do 2024-07-12 17:32:34 +02:00
Benoit Queyron
2a955a0f8c
correction du test sur l'état de l'input 2024-07-12 11:36:43 +02:00
Benoit Queyron
88710969bb
correction du test sur la suppression de la PJ d'un dossier 2024-07-12 11:17:51 +02:00
Eric Leroy-Terquem
ea8112b8b3
fix(routing): open routing wizard to all conditionable types 2024-07-11 14:55:03 +02:00
Eric Leroy-Terquem
60ff785009
refactor(type de champ): rename routable_types in simple_routable_types 2024-07-11 12:17:46 +02:00
Eric Leroy-Terquem
30da11823b
db(task): create previews for pjs in one week 2024-07-10 17:38:05 +02:00
Eric Leroy-Terquem
c9d74c46d1
db(task): create variants for pjs in one week 2024-07-10 17:38:04 +02:00
Lisa Durand
7539d2ddea
fix specs 2024-07-10 16:11:38 +02:00
Lisa Durand
42633c0012
Merge branch 'main' of github.com:betagouv/demarches-simplifiees.fr into instructeur-invitation-include-typo-suggestion-ldu 2024-07-10 14:58:55 +02:00
Lisa Durand
3b138d5bb7
add confirmation for tiers email 2024-07-10 10:57:26 +02:00
mfo
f3690d8890
Merge pull request #10587 from tchak/refactor-no-validate-on-format
refactor(champ): remove call to validation from value formatting code
2024-07-09 14:31:10 +00:00
Benoit Queyron
fc385208db
update test 2024-07-08 16:09:25 +02:00
Paul Chavard
96e49d54cd
reafctor(logic): remove tests and accept unspecified behaviour 2024-07-08 15:44:30 +02:00
Colin Darie
ba6fdc4748
feat: /commencer alert about draft procedure 2024-07-08 11:32:37 +02:00
Colin Darie
28e8c786fa
chore: don't wrap "en test" tag/breadcrumb 2024-07-08 11:32:37 +02:00
mfo
75a6c8b4b6
Merge pull request #10555 from mfo/US/normalize-number-cahmp
tech: Normalisation des champs de type number/decimal pr enlever les espace blanc à la saisi
2024-07-08 07:31:29 +00:00
Paul Chavard
89fb0abe6e
fix(spec): fix system test 2024-07-05 09:36:33 +02:00
Paul Chavard
9f9243499c
refactor(combobox): fix specs 2024-07-05 09:36:33 +02:00
Paul Chavard
cb01f15570
refactor(champ): update champ commune 2024-07-05 09:36:33 +02:00
Paul Chavard
4e8b29b21c
refactor(js): remove old code 2024-07-05 09:36:33 +02:00
mfo
a8573febaa
clean(spec): remove since its now forced by a before_validation 2024-07-05 09:34:26 +02:00
Lisa Durand
8ff2bbbaab
fix specs 2024-07-04 14:41:37 +02:00
mfo
c50f949acd
feat(Champs::number*): normalize values by stripping spaces. 2024-07-04 09:56:23 +02:00
Colin Darie
68cf6b58a3
Merge pull request #10574 from colinux/fix-experts-invits
ETQ admin, fix l'invitation d'experts n'ayant pas de compte DS
2024-07-02 17:33:11 +02:00
Colin Darie
b3ccfc16c4
Merge pull request #10547 from colinux/mandatory-by-default
ETQ admin, un nouveau champ est obligatoire par défaut
2024-07-02 14:26:29 +00:00
Colin Darie
a53fc0fac9
fix(admin): invitation for experts not having an account 2024-07-02 16:15:24 +02:00
Colin Darie
b2514dd16c
Merge pull request #10567 from colinux/fix-hardcoded-name
Tech: corrige le nom de l'application hardcodé dans un email
2024-07-02 12:36:19 +00:00
Colin Darie
5e25547b7b
fix(attestation): don't delete v1 published when building a v2 2024-07-02 14:10:23 +02:00
Lisa Durand
337689333e
Merge pull request #10559 from demarches-simplifiees/change-button-print-to-download-for-user-ldu
ETQ usager, je veux pouvoir télécharger mon dossier sans avoir à passer par le bouton "imprimer"
2024-07-02 08:54:16 +00:00
Eric Leroy-Terquem
5397c84918
clean: remove failing maintenance tasks 2024-07-02 09:58:28 +02:00
Colin Darie
eee6e5e651
Merge pull request #10483 from colinux/fast-tests
Tech (tests): default administrateur fixtures
2024-07-01 21:35:11 +00:00
Colin Darie
2041623ded
test: merge similar examples 2024-07-01 22:36:31 +02:00
Colin Darie
9e80962ea5
test: default administrateur as fixtures 2024-07-01 22:36:31 +02:00
Lisa Durand
8b4e12a407
replace wording, use download instead of print 2024-07-01 17:20:55 +02:00
Colin Darie
f40b71f450
test(type_de_champ): mandatory by default, like schema 2024-07-01 17:00:49 +02:00
mfo
896ee76d74
Merge pull request #10524 from mfo/US/expert-invitation-by-admin
ETQ administrateur, lorsque je gère ma liste d'expert invités sur une démarche, je suis guidé pour eviter les typos
2024-07-01 09:59:15 +00:00
Colin Darie
327ebf106f
fix(mailer): hardcoded application name 2024-07-01 10:55:58 +02:00
mfo
e6a3f210d4
fix(experts_procedures#create): ensure to reload expert list after addition 2024-07-01 10:46:06 +02:00
Lisa Durand
159cc942f6
Merge pull request #10549 from demarches-simplifiees/new-instructeur-need-mail-confirmation-ldu
ETQ nouvel instructeur, je dois confirmer mon mail
2024-07-01 08:45:57 +00:00
mfo
ced634295e
clean(tech): EmailChecker, use class method, not instance 2024-07-01 10:40:55 +02:00
Lisa Durand
75403ba949
add specs 2024-06-26 10:57:40 +02:00
mfo
cfda807b66
fix(data): decimal number having spaces are no more exportable 2024-06-25 21:17:46 +02:00
mfo
476c7df160
bug(Champs::DecimalNumberChamp.for_export): should be able to cast a number wrapped with a string having leading/trailing spaces 2024-06-25 17:05:33 +02:00
Colin Darie
828c539469
Merge pull request #10546 from colinux/fix-flaky-brouillon
Tests: fix JS log events
2024-06-25 14:12:52 +00:00
Lisa Durand
d7893b9102
instructeur need to confirm mail after invitation 2024-06-25 15:14:26 +02:00
mfo
554141bb67
fix(spec): broken 2024-06-25 14:52:01 +02:00
mfo
2bb7584246
feat(administrateurs/experts_procedures#create): avoid typo on expert
list management
2024-06-25 14:04:01 +02:00
Colin Darie
e9920c76d5
feat(faq): can add dsfr alert from markdown 2024-06-24 16:28:35 +02:00
Colin Darie
55cc48b785
test: JS_LOG allows multiple events 2024-06-24 15:29:56 +02:00
Eric Leroy-Terquem
1ab77cede9
Merge pull request #10512 from demarches-simplifiees/safer-gallery
Technique : mise à jour de la galerie et transformation des images uniquement côté jobs
2024-06-24 10:16:57 +00:00
Eric Leroy-Terquem
c94c2f55c8
task(pj): create representations for latest pieces jointes 2024-06-24 11:13:37 +02:00
Eric Leroy-Terquem
0c95a098a5
feat(gallery): do not create representations in web machines 2024-06-24 11:13:36 +02:00
Colin Darie
ccf5b255ed
Merge pull request #10465 from colinux/attestations-v2-prod
ETQ admin je peux activer la délivrance des attestations v2 (sous feature flag)
2024-06-24 08:56:31 +00:00
Colin Darie
5ac2315b5a
Merge pull request #10535 from mfo/US/page-procedure-show
Améliroation, ETQ instructeur le nombre de dossier par page passe de 25 a 100
2024-06-24 08:14:56 +00:00
mfo
4e67255405
feat(instructeurs/procedure#show): increase dossier page size but keep request count same 2024-06-21 16:50:08 +02:00
mfo
2ee6f2350a
Merge pull request #10536 from mfo/US/summary-in-instructeur-demande
ETQ instructeur, je peux naviguer dans le formulaire de l'usager via un sommaire, idem pour les annotations privées.
2024-06-21 14:44:50 +00:00
mfo
4c5e0c245c
tech(spec): perf, instructeurs/procedures#show, start tracking request count on procedure show 2024-06-21 16:19:32 +02:00
mfo
4caeecadff
Merge pull request #10534 from mfo/US/fix-ineligibilite-rules-check-without-rules
Correctif: ETQ admin, je ne peux pas activer l'inéligibilité des dossiers sans règles d'inéligibilité
2024-06-21 09:47:43 +00:00
mfo
d46dc7055d
feat(instructeurs/dossiers): add summary to dossier.champs and dossier.champ_private views, also extract summary in
two component. one of type de champ editor. one for viewable champs
2024-06-21 11:06:45 +02:00
mfo
5a5ebfb235
Merge pull request #10531 from mfo/US/add-champ-summary-to-annotations
ETQ administrateur, je peux naviguer dans l'editeur des annotations en utilisant le sommaire façon editeur des champs du formulaire
2024-06-21 08:34:12 +00:00
mfo
6eaf870cbf
feat(administrateurs/procedure#annotations): add summary 2024-06-21 05:50:24 +02:00
mfo
43a7364229
Merge pull request #10522 from mfo/US/fix-submitted-dossier-error
Correctif: ETQ admin, j'aimerais pouvoir modifier le message de confirmation de dépôt de dossier
2024-06-21 03:22:48 +00:00
Colin Darie
372c732458
Merge pull request #10513 from colinux/helpscount-api
ETQ opérateur je peux supprimer les vieilles conversations helpscout
2024-06-20 19:57:46 +00:00