DGNum/demarches-normaliennes
14
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

fix(contact): use user email when no email was specified

Browse source
This commit is contained in:
Colin Darie 2024-08-01 16:38:39 +02:00
parent 45d5e79e55
commit 3469527637
No known key found for this signature in database
GPG key ID: 4FB865FDBCA4BCC4
2 changed files with 13 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/jobs/helpscout_create_conversation_job.rb
View file

@ -29,7 +29,7 @@ class HelpscoutCreateConversationJob < ApplicationJob
def create_conversation
response = api.create_conversation(
contact_form.email,
contact_form.email.presence || contact_form.user.email,
contact_form.subject,
contact_form.text,
safe_blob

13
spec/jobs/helpscout_create_conversation_job_spec.rb
View file

@ -8,7 +8,8 @@ RSpec.describe HelpscoutCreateConversationJob, type: :job do
let(:tags) { ["first tag"] }
let(:question_type) { "lost" }
let(:phone) { nil }
let(:contact_form) { create(:contact_form, email:, subject: subject_text, text:, tags:, phone:, question_type:) }
let(:user) { nil }
let(:contact_form) { create(:contact_form, email:, user:, subject: subject_text, text:, tags:, phone:, question_type:) }
describe '#perform' do
before do
@ -82,5 +83,15 @@ RSpec.describe HelpscoutCreateConversationJob, type: :job do
expect(api).to have_received(:add_phone_number).with(email, phone)
end
end
context 'attached to an user' do
let(:email) { nil }
let(:user) { users(:default_user) }
it 'associates the email from user' do
subject
expect(api).to have_received(:create_conversation).with(user.email, subject_text, text, nil)
end
end
end
end