DGNum/demarches-normaliennes
15
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

feat(instructeurs/procedure#show): increase dossier page size but keep request count same

Browse source
This commit is contained in:
mfo 2024-06-21 16:16:14 +02:00
parent 4c5e0c245c
commit 4e67255405
No known key found for this signature in database
GPG key ID: 7CE3E1F5B794A8EC
2 changed files with 20 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/controllers/instructeurs/procedures_controller.rb
View file

@ -3,7 +3,7 @@ module Instructeurs
before_action :ensure_ownership!, except: [:index]
before_action :ensure_not_super_admin!, only: [:download_export, :exports]
ITEMS_PER_PAGE = 25
ITEMS_PER_PAGE = 100
BATCH_SELECTION_LIMIT = 500
def index

26
spec/controllers/instructeurs/procedures_controller_spec.rb
View file

@ -331,16 +331,28 @@ describe Instructeurs::ProceduresController, type: :controller do
end
context 'with pagination' do
let(:dossiers) { 26.times.map { create(:dossier, :en_instruction, procedure: procedure) } }
before { dossiers }
let(:dossiers) { Array.new(26) { create(:dossier, :en_instruction, procedure: procedure) } }
before do # warmup cache
get :show, params: { procedure_id: procedure.id, statut: statut }
dossiers
end
it 'keeps request count stable' do
count = 0
callback = lambda { |*_args| count += 1 }
ActiveSupport::Notifications.subscribed(callback, "sql.active_record") do
subject
count_with_25, count_with_100 = 0, 0
stub_const('Instructeurs::ProceduresController::ITEMS_PER_PAGE', 25)
ActiveSupport::Notifications.subscribed(lambda { |*_args| count_with_25 += 1 }, "sql.active_record") do
get :show, params: { procedure_id: procedure.id, statut: statut }
expect(assigns(:projected_dossiers).size).to eq(25)
end
expect(count).to eq(43)
stub_const('Instructeurs::ProceduresController::ITEMS_PER_PAGE', 100)
ActiveSupport::Notifications.subscribed(lambda { |*_args| count_with_100 += 1 }, "sql.active_record") do
get :show, params: { procedure_id: procedure.id, statut: statut }
expect(assigns(:projected_dossiers).size).to eq(dossiers.size + 1) # +1 due to let!(:new_unfollow_dossier)
end
expect(count_with_100).to eq(count_with_25)
end
end