feat(champs): use new combobox for champs selection multiple

app/components/editable_champ/drop_down_list_component.rb

@@ -30,6 +30,8 @@ class EditableChamp::DropDownListComponent < EditableChamp::EditableChampBaseCom
       name: @form.field_name(:value),
       selected_key: @champ.selected,
       items: @champ.enabled_non_empty_options(other: true).map { _1.is_a?(Array) ? _1 : [_1, _1] },
-      empty_filter_key: @champ.drop_down_other? ? Champs::DropDownListChamp::OTHER : nil)
+      empty_filter_key: @champ.drop_down_other? ? Champs::DropDownListChamp::OTHER : nil,
+      'aria-describedby': @champ.describedby_id,
+      'aria-labelledby': @champ.labelledby_id)
   end
 end

app/components/editable_champ/multiple_drop_down_list_component.rb

@@ -9,7 +9,14 @@ class EditableChamp::MultipleDropDownListComponent < EditableChamp::EditableCham
     @champ.render_as_checkboxes? ? :fieldset : :div
   end
 
-  def update_path(option)
-    champs_options_path(@champ.dossier, @champ.stable_id, row_id: @champ.row_id, option:)
+  def react_props
+    react_input_opts(id: @champ.input_id,
+      class: 'fr-mt-1w',
+      name: @form.field_name(:value, multiple: true),
+      selected_keys: @champ.selected_options,
+      items: @champ.enabled_non_empty_options,
+      'aria-label': @champ.libelle,
+      'aria-describedby': @champ.describedby_id,
+      'aria-labelledby': @champ.labelledby_id)
   end
 end

app/components/editable_champ/multiple_drop_down_list_component/multiple_drop_down_list_component.html.haml

@@ -9,11 +9,5 @@
               = b.text
 
   - else
-    %div{ 'data-turbo-focus-group': true }
-      - if @champ.selected_options.present?
-        .fr-mb-2w.fr-mt-2w{ "data-turbo": "true" }
-          - @champ.selected_options.each do |option|
-            = render NestedForms::OwnedButtonComponent.new(formaction: update_path(option), http_method: :delete, opt: { aria: {pressed: true }, class: 'fr-tag fr-tag-bug fr-mb-1w fr-mr-1w', id: @champ.checkbox_id(option) }) do
-              = option
-      - if @champ.unselected_options.present?
-        = @form.select :value, @champ.unselected_options, { selected: '', include_blank: false, prompt: t('.prompt') }, id: @champ.input_id, aria: { describedby: @champ.describedby_id }, class: 'fr-select fr-mt-2v'
+    %react-fragment
+      = render ReactComponent.new "ComboBox/MultiComboBox", **react_props

app/controllers/champs/options_controller.rb

@@ -1,10 +0,0 @@
-class Champs::OptionsController < Champs::ChampController
-  include TurboChampsConcern
-
-  def remove
-    @champ.remove_option([params[:option]].compact, true)
-    @dossier = @champ.private? ? nil : @champ.dossier
-    champs_attributes = { @champ.public_id => {} }
-    @to_show, @to_hide, @to_update = champs_to_turbo_update(champs_attributes, @champ.dossier.champs)
-  end
-end

spec/controllers/champs/options_controller_spec.rb

@@ -1,22 +0,0 @@
-describe Champs::OptionsController, type: :controller do
-  let(:user) { create(:user) }
-  let(:procedure) { create(:procedure, types_de_champ_public: [{ type: :multiple_drop_down_list }]) }
-
-  describe '#remove' do
-    let(:dossier) { create(:dossier, user:, procedure:) }
-    let(:champ) { dossier.champs.first }
-
-    before {
-      sign_in user
-      champ.update(value: ['toto', 'tata'].to_json)
-    }
-
-    context 'with stable_id' do
-      subject { delete :remove, params: { dossier_id: dossier, stable_id: champ.stable_id, option: 'tata' }, format: :turbo_stream }
-
-      it 'remove option' do
-        expect { subject }.to change { champ.reload.selected_options.size }.from(2).to(1)
-      end
-    end
-  end
-end

spec/system/users/brouillon_spec.rb

@@ -34,8 +34,13 @@ describe 'The user' do
     find('.fr-checkbox-group label', text: 'val1').click
     find('.fr-checkbox-group label', text: 'val3').click
     select('bravo', from: form_id_for('simple_choice_drop_down_list_long'))
-    select('alpha', from: form_id_for('multiple_choice_drop_down_list_long'))
-    select('charly', from: form_id_for('multiple_choice_drop_down_list_long'))
+
+    scroll_to(find_field('multiple_choice_drop_down_list_long'), align: :center)
+    fill_in('multiple_choice_drop_down_list_long', with: 'alpha')
+    find('.fr-menu__item', text: 'alpha').click
+    fill_in('multiple_choice_drop_down_list_long', with: 'charly')
+    find('.fr-menu__item', text: 'charly').click
+    wait_until { champ_value_for('multiple_choice_drop_down_list_long') == ['alpha', 'charly'].to_json }
 
     select('Australie', from: form_id_for('pays'))
     select('Martinique', from: form_id_for('regions'))
@@ -109,8 +114,8 @@ describe 'The user' do
     expect(page).to have_selected_value('regions', selected: 'Martinique')
     expect(page).to have_selected_value('departements', selected: '02 – Aisne')
     within("##{champ_for('multiple_choice_drop_down_list_long').input_group_id}") do
-      expect(page).to have_button('alpha')
-      expect(page).to have_button('charly')
+      expect(page).to have_text('alpha')
+      expect(page).to have_text('charly')
     end
     expect(page).to have_field('communes', with: 'Brétigny (60400)')
     expect(page).to have_selected_value('pays', selected: 'Australie')

spec/views/shared/dossiers/_edit.html.haml_spec.rb

@@ -103,7 +103,7 @@ describe 'shared/dossiers/edit', type: :view do
       let(:options) { ['peach', 'banana', 'pear', 'apricot', 'apple', 'grapefruit'] }
 
       it 'renders the list as a multiple-selection dropdown' do
-        expect(subject).to have_selector('select')
+        expect(subject).to have_selector('react-fragment > react-component[name="ComboBox/MultiComboBox"]')
       end
     end
   end