mfo
0771d207f3
Merge pull request #10716 from mfo/US/fix-bad-data
...
ETQ instance DS, je souhaite que l'intégrité des données entre les champs et les dossiers soient garantie par une contrainte en base de donnée
2024-08-26 14:23:25 +00:00
mfo
1d84c0f55b
fix(champs.orphaned): add maintenance task to clean orphaned champs where dossier is missing
2024-08-26 16:00:59 +02:00
Paul Chavard
32bf3ec9db
cleanup in spec
2024-08-26 14:53:56 +02:00
Paul Chavard
1aee7ab1d2
refactor(champ): more concistent champ_for_update usage
2024-08-26 14:53:56 +02:00
Paul Chavard
f7cd7e615d
refactor(champs): validate only champs in current revision
2024-08-26 14:53:56 +02:00
Paul Chavard
bb2f590d18
refactor(repetition): use less champs and public_id methods
2024-08-26 14:53:56 +02:00
Eric Leroy-Terquem
fade633828
feat(routing): can create simple routing with address tdc
2024-08-26 11:16:47 +02:00
Eric Leroy-Terquem
8b4b4d7cb7
feat(conditional): can condition and route on address champ
2024-08-26 11:16:46 +02:00
Lisa Durand
8722a10d63
fix specs
2024-08-22 17:54:24 +02:00
Lisa Durand
b586f23009
remove hidden at column from dossiers
2024-08-22 17:36:41 +02:00
Lisa Durand
8e7e8d9624
Merge pull request #10705 from demarches-simplifiees/email-expert-need-confirmation-ldu
...
ETQ expert, je dois confirmer mon mail
2024-08-22 12:53:52 +00:00
Lisa Durand
fae81d0a58
fix test
2024-08-22 12:09:29 +02:00
mfo
70983c50f9
spec(normalized_address): add simple spec
2024-08-22 10:37:31 +02:00
mfo
8a42c6a7ad
Merge pull request #10708 from mfo/US/format-rna
...
ETQ tech je souhaite que les champs RNA ne puissent pas contenir d'espace sans quoi nos appels d'API remontent un URI::InvalidURIError
2024-08-22 08:36:38 +00:00
mfo
22e50d4c9e
fix(data): normalize invalid Champs::RNAChamp.values in db
2024-08-22 10:24:03 +02:00
Colin Darie
2b9fe12079
test(dolist): add some specs and remove unsupported email sent with attachments
2024-08-22 09:26:49 +02:00
Colin Darie
659d35e11f
test: fix for mutable string
2024-08-22 09:26:49 +02:00
Colin Darie
6d9a7648e2
fix(test): disable frozen string in siret concern because it's a literal string in spec
2024-08-22 09:26:49 +02:00
Colin Darie
77fb0553fc
chore: enable freeze string literals by comment
2024-08-22 09:26:48 +02:00
Colin Darie
eccfde848f
feat(admin): disable publish button when there are errors
2024-08-21 17:38:07 +02:00
Colin Darie
d0837c58f5
fix(admin): publish modifications button must be PUT
2024-08-21 17:38:07 +02:00
Kara Diaby
4a93579e71
Ajoute une sticky navbar si il y a une modification de démarche déjà publiée
2024-08-21 10:23:02 +00:00
mfo
ec9a03ac17
Merge pull request #10693 from mfo/US/filter-by-json-path-3
...
ETQ instructeur, je peux filtrer par les donnée de champs issues d'API, a commencer par RNA/RNF SIRET
2024-08-21 09:50:47 +00:00
mfo
42b9ac1737
spec(filter): with rna enum
2024-08-21 10:23:56 +02:00
mfo
575c4cbdff
clean(spec): procedure_filters_spec.rb, less tdc by default
2024-08-21 10:23:56 +02:00
mfo
750842f742
feat(Column::JSONPathColumn): allow search by json path column
...
Co-authored-by: LeSim <mail@simon.lehericey.net>
2024-08-21 10:23:39 +02:00
Paul Chavard
271602082b
refactor(columns): rename virtual to displayable
2024-08-20 18:46:19 +02:00
Colin Darie
8cdd7ef4df
Merge pull request #10699 from mfo/US/hotfix-pp
...
Correctif: rattrape les données inconsistantes pour la présentation des tableaux instructeurs qui se font detruire a la 1ere connection
2024-08-20 16:16:26 +00:00
mfo
3662e38366
hotfix(ProcedurePresentation): backfill invalid procedure presentation private tabel name for type de champs private
2024-08-20 17:58:55 +02:00
Lisa Durand
16864cc868
fix test
2024-08-20 15:47:09 +02:00
Paul Chavard
686000d6cb
fix spec
2024-08-20 15:26:15 +02:00
Lisa Durand
5281ab966a
add deleted dossiers in menu for instructeurs
2024-08-20 15:26:15 +02:00
Lisa Durand
95a8f1458b
fix specs
2024-08-20 15:26:14 +02:00
Lisa Durand
ab483a8959
simplifie tabs supprimes and reduce to one
2024-08-20 15:26:09 +02:00
Colin Darie
e4d460965f
Merge pull request #10690 from mfo/US/normalize-addresses-for-rnf-rna-siret
...
ETQ Tech, les adresses des champs siret / rna / rnf sont normalisées pour une recherche homogène via les filtres
2024-08-20 10:11:48 +00:00
Colin Darie
1e53e3bfef
Merge pull request #10661 from demarches-simplifiees/feat/10460
...
ETQ admin, je veux que l'email du déposant ne puisse pas être similaire à l'email du mandataire
2024-08-20 09:34:03 +00:00
LeSim
befe74b801
Merge pull request #9758 from demarches-simplifiees/purge_supprimer_dol
...
Tech: quand un dossier est définitivement supprimé, on ne garde que le log (DOL) concernant sa suppression
2024-08-20 09:26:33 +00:00
mfo
bc7264ee08
Merge pull request #10625 from demarches-simplifiees/US/cleanup-procedure-presentation
...
ETQ tech, je souhaite isoler le concept des colonnes extractable/cherchable/affichable d'une demarche
2024-08-20 09:04:23 +00:00
simon lehericey
28b338452a
feat(dossier_purge): when the dols are purged, only keep supprimer dol but destroy its data
...
Note, the only remaining data are dossier_id, automatic_operation, digest and bill_id, created_at
2024-08-20 10:55:32 +02:00
simon lehericey
92da869662
spec: Dossier.purge_discarded
2024-08-20 10:55:32 +02:00
mfo
a66bd46082
data(backfill): Champs::SiretChamp.value_json [±1.4M occurences]
2024-08-20 10:31:23 +02:00
mfo
917f25dcfd
data(backfill): Champs::RnaChamp.value_json [±7.5k occurences]
2024-08-20 10:31:23 +02:00
mfo
4bf5725d6d
data(backfill): Champs::RnfChamp.value_json [±400 occurences]
2024-08-20 10:31:23 +02:00
mfo
d866309d45
feat(rnf/rna/siret): normalize address in champs.value_json
2024-08-20 10:31:23 +02:00
Paul Chavard
ba92216504
Merge pull request #10614 from tchak/graphql-only-allow-saved-queries-without-token
...
secu(graphql): without a token, only saved queries are allowed
2024-08-20 08:11:48 +00:00
mfo
dba6f9b3aa
refactor(Facet): to column 🚀
2024-08-19 15:46:14 +02:00
mfo
2a0537134d
fix(spec): should have been updated with facet concern sig
2024-08-19 15:30:08 +02:00
mfo
b6464c1963
tech: use facet_id to sort fields
2024-08-19 15:30:08 +02:00
mfo
31255b69cc
move/rename faceting components within their instructeur ns
2024-08-19 15:30:08 +02:00
mfo
60c6c86d70
ProcedurePresentation.displayable_fields_for_select -> InstructeurFacetPickerComponent.displayable_fields_for_select
2024-08-19 15:29:59 +02:00
mfo
41ea39abb1
ProcedurePresentation.filterable_fields_options -> InstructeurFilterComponent.filterable_fields_options
2024-08-19 15:29:59 +02:00
simon lehericey
379c9fb812
procedure should provide its facets
2024-08-19 15:29:59 +02:00
simon lehericey
c5c2d5782d
lets keep it private
2024-08-19 15:29:59 +02:00
simon lehericey
772424ff5e
move field_enum to instructeur filter component
2024-08-19 15:28:36 +02:00
simon lehericey
305b8c13c7
! BREAKING : break previous filter by type_de_champ_private
...
simplify type_de_champ_private -> type_de_champ, fix spec, add facet_spec
2024-08-19 15:28:36 +02:00
mfo
b3cb3e974e
refactor(Facet): extract Facet from ProcedurePresentation
...
Co-Authored-By: LeSim <mail@simon.lehericey.net>
clean(code): no comment 🎶
2024-08-19 15:27:39 +02:00
Kara Diaby
61525b6c2b
test
2024-08-19 12:51:39 +00:00
Corinne Durrmeyer
e358f196e9
Change help__content to help-content to conform linting Regex
2024-08-14 09:56:52 +02:00
Corinne Durrmeyer
4e1332431b
Update sepc files
2024-08-14 09:56:52 +02:00
Paul Chavard
065000cae3
Merge pull request #10674 from colinux/really-fix-rnf
...
ETQ usager, permet de saisir un champ RNF en ignorant les espaces/tabulations
2024-08-01 18:09:21 +00:00
Colin Darie
c2159ca0bf
fix(contact): allow deletion of contact form of users having dossiers
2024-08-01 19:44:44 +02:00
Colin Darie
720a312b00
fix(rnf): really normalize spaces
...
Fix #10653
2024-08-01 18:54:50 +02:00
Paul Chavard
25d4e7dfee
fix(rnf): no crash on identifiers with spaces
2024-08-01 18:00:46 +02:00
Colin Darie
3469527637
fix(contact): use user email when no email was specified
2024-08-01 16:43:28 +02:00
Paul Chavard
807d43a9a7
feat(graphql): add desarchiver mutation
2024-08-01 09:50:01 +02:00
Colin Darie
4b6d3ee16d
refactor(contact): support => contact
2024-07-31 17:08:02 +02:00
Colin Darie
5af32b46f4
refactor(contact): form is persisted in db before pushed to HS
2024-07-31 17:08:01 +02:00
Colin Darie
4bc0a04106
chore(schema): add contact_forms
2024-07-31 17:08:01 +02:00
Colin Darie
ff62e99e7b
refactor(contact): suggest email correction, strict email validation, fix admin form
2024-07-31 11:23:17 +02:00
Colin Darie
90e6c8a6f6
Merge pull request #10603 from demarches-simplifiees/bug-input-pj-apres-suppression
...
ETQ Admin (bug), je veux pouvoir modifier des PJ sans recharger la page
2024-07-30 12:14:11 +00:00
Colin Darie
e467be1dbc
fix(dossier): can download an expired dossier
2024-07-30 14:06:43 +02:00
Paul Chavard
bced38eb78
Merge pull request #10665 from demarches-simplifiees/a11y-fix-suspect-email
...
Accessibilité : Assure la restitution par les TA du bloc de suggestion de l'adresse mail
2024-07-30 09:53:01 +00:00
Corinne Durrmeyer
edf9c8807f
Update spec file
2024-07-30 11:42:29 +02:00
Paul Chavard
9d7d7da85a
Merge pull request #10572 from demarches-simplifiees/add-pj-from-messagerie-to-gallery
...
ETQ instructeur je peux voir les pjs envoyées par la messagerie dans l‘onglet "pièces jointes"
2024-07-30 09:35:14 +00:00
Paul Chavard
337eaff3f0
Merge pull request #10602 from demarches-simplifiees/fix-routing-fields-list
...
Correctif : ouvre l‘assistant de routage à tous les types de champ conditionnables
2024-07-30 09:01:24 +00:00
Paul Chavard
4e180f8f05
Merge pull request #10642 from mfo/US/api.dossier_modifier_annotation_drop_down_list
...
Amélioration, ETQ consommateur de l'API graphql, je souhaite pouvoir modifier une annotation de type choix simple
2024-07-30 08:25:05 +00:00
Paul Chavard
9aa86031cc
Merge pull request #10660 from colinux/fix-attestation-draft
...
ETQ admin sur une démarche en brouillon, l'attestation v2 est créé en brouillon si on a déjà une v1 active
2024-07-30 08:12:55 +00:00
Paul Chavard
12c11c563f
Merge pull request #10656 from colinux/fix-when-removing-all-displayed-fields
...
ETQ instructeur, pas d'erreur quand on veut enlever la dernière colonne affichée dans le tableau
2024-07-30 08:11:02 +00:00
Paul Chavard
b81f69580b
fix(sva/svr): fix spec with arbitrary date
2024-07-30 09:35:15 +02:00
Colin Darie
2689bc6721
fix(attestation): build v2 draft on draft procedure when a v1 is published
2024-07-29 17:06:54 +02:00
Colin Darie
25014a71b8
Merge pull request #10659 from colinux/fix-devise-confirmation-leak
...
ETQ usager, redirige les utilisateurs déjà confirmés qui réutilisent le lien de confirmation
2024-07-29 12:15:21 +00:00
Colin Darie
a6554aa7bf
fix(users): don't expose email of accounts already confirmed
2024-07-29 12:07:02 +02:00
Paul Chavard
2fe40343a7
Merge pull request #10646 from colinux/faq-allow-custom-image-attributes
...
Accessibilité: permet au markdown FAQ d'intégrer n'importe quel attribut html dans les `<img>`
2024-07-29 08:27:04 +00:00
Colin Darie
6a6e643771
fix(instructeurs): don't fail when removing all displayed fields
2024-07-26 15:55:02 +02:00
simon lehericey
c4403bffeb
work on controller
2024-07-26 13:34:50 +02:00
simon lehericey
248da3a896
work on validator
2024-07-26 13:34:49 +02:00
simon lehericey
057868a48e
small work on tiptap
2024-07-26 13:34:49 +02:00
simon lehericey
f973c59c9a
stop exporting bills with export_template
2024-07-26 13:34:49 +02:00
simon lehericey
33244f6d70
adapt pieces_justificatives_service to new export_template.attachment_path
2024-07-26 13:34:49 +02:00
simon lehericey
8906a59635
simplify export_template model and spec
2024-07-26 13:34:49 +02:00
simon lehericey
977cfc87ce
Add export_item type
2024-07-26 13:31:06 +02:00
simon lehericey
24109a0128
add exportables_pieces_jointes_for_all_versions and outdated to pj_list_concern
2024-07-26 13:31:06 +02:00
simon lehericey
53a48f963d
tdc: add libelle_as_filename
2024-07-26 13:31:05 +02:00
Corinne Durrmeyer
190addd317
Merge pull request #10647 from demarches-simplifiees/a11y-authentification-page
...
Améliore l'accessibilité de la page d'authentification
2024-07-26 09:38:18 +00:00
Corinne Durrmeyer
a415775e17
Merge pull request #10632 from demarches-simplifiees/a11y-fix-faq-content
...
Améliore l'accessibilité des pages de contenu de la FAQ
2024-07-26 09:18:02 +00:00
Paul Chavard
223317fb5a
fix(rebase): avoid errors when adding pj champs to a new revision
2024-07-25 18:29:01 +02:00
Lisa Durand
e93ea356ab
Merge pull request #10488 from demarches-simplifiees/improve-mails-for-deleted-dossiers-ldu
...
[usager] Laisser un délai avant suppression des dossiers expirés
2024-07-25 15:14:30 +00:00
Lisa Durand
4f7b0c93d0
fix multiple errors from creation of dedicated method to restore and extend
2024-07-25 16:55:00 +02:00
Corinne Durrmeyer
c4afbfcbf1
Update spec files
2024-07-25 12:24:25 +02:00
Benoit Queyron
3493736133
Merge pull request #10624 from demarches-simplifiees/usager-remonter-bouton-nouveau-dossier
...
ETQ usager - je veux pouvoir accéder plus facilement au bouton "nouveau dossier"
2024-07-25 07:20:45 +00:00
Colin Darie
efa5122ce0
feat(a11y): allow trusted markdown (FAQ) to set any custom attributes in img
2024-07-24 19:13:08 +02:00
simon lehericey
746ff92118
Add PhishingAlert maintenance task and mailer
2024-07-24 18:10:57 +02:00
mfo
e63b777bd9
feat(api.dossier.modifier_annotation): stop validation only with graphql schema, also validate with our validations methods
2024-07-24 17:48:00 +02:00
Lisa Durand
b820577461
create a method to extend and restore
2024-07-24 17:07:48 +02:00
Lisa Durand
df13e53815
small refactos from Sim review
2024-07-24 17:07:47 +02:00
Lisa Durand
94e1f048ce
fix tabs count
2024-07-24 17:07:47 +02:00
Lisa Durand
eb3b928cf2
change scope to include new column for expiring dossiers
2024-07-24 17:07:47 +02:00
Lisa Durand
0dcdcb5643
add column hidden_by_expired_at
2024-07-24 17:07:41 +02:00
Lisa Durand
0bf1790682
change wording to clarify emails
2024-07-24 17:06:31 +02:00
Lisa Durand
9346020889
dont use depreciated column hidden_at
2024-07-24 17:06:30 +02:00
Lisa Durand
8b88fafc25
add correct action for instructeur
2024-07-24 17:06:30 +02:00
Lisa Durand
c2abceaa72
hide expired dossiers instead of delete them
2024-07-24 17:06:30 +02:00
mfo
8e6c5d1567
api(mutation.dossier_modifier_annotation_drop_down_list): add mutation to change drop_down_list annotations value
2024-07-24 15:02:24 +02:00
Benoit Queyron
aae87fce0a
ajustement test dossier_action
2024-07-24 14:54:27 +02:00
Eric Leroy-Terquem
d8d2094909
db(task): remove pj files for not visible champs
2024-07-24 09:21:12 +02:00
Corinne Durrmeyer
adba85755d
Update spec file
2024-07-23 12:20:54 +02:00
Eric Leroy-Terquem
a04749c3ef
fix a flaky test
2024-07-23 10:23:54 +02:00
Eric Leroy-Terquem
78d1572c8f
test(routing): test routing on autosave
2024-07-23 10:23:54 +02:00
Paul Chavard
229483d16c
refactor(champ): remove type_de_champ_id and champ factories
2024-07-22 13:53:45 +02:00
Paul Chavard
d6f9e57e77
secu(graphql): without a token, only persisted queries are allowed
2024-07-22 11:39:32 +02:00
Paul Chavard
406d05a47a
chore(spec): remove duplicated specs
2024-07-22 11:38:11 +02:00
simon lehericey
bb6c43cbb9
do not give bad advice
2024-07-22 11:15:27 +02:00
Eric Leroy-Terquem
5fbe2daca2
db(maintenance task): create representations for pjs sent by messagerie
2024-07-22 10:07:40 +02:00
Eric Leroy-Terquem
59ddaf5b0b
feat(gallery): add pjs from messagerie to gallery
2024-07-22 10:07:39 +02:00
Paul Chavard
888be8df89
feat(champs): use new combobox for champs selection multiple
2024-07-16 15:10:45 +02:00
Paul Chavard
d640ab8428
fix(combobox): dispatch change event on multiple combo changes
2024-07-16 15:10:45 +02:00
Benoit Queyron
ec24ce3dad
ajustement test PJ dossier en construction
2024-07-16 10:51:17 +02:00
Lisa Durand
7630cc39fa
Merge pull request #10595 from demarches-simplifiees/email-mandant-need-confirmation-ldu
...
ETQ Mandant, je dois confirmer mon mail avant de recevoir des notifs
2024-07-15 14:00:38 +00:00
Lisa Durand
e9f5389f83
resent email if link too old and better style email
2024-07-15 12:00:03 +02:00
Lisa Durand
3eabcb0736
add tests
2024-07-15 11:56:18 +02:00
mfo
b55ed262ed
Merge pull request #10607 from mfo/US/fix-invisible-pj
...
Amélioration: ETQ usager, je souhaite que les PJs d'un champ qui n'est plus visible ne soient pas soumise a l'administration
2024-07-15 09:36:01 +00:00
mfo
ad8a664fe4
Merge pull request #10608 from mfo/US/fix-regexp-error
...
Correctif: ETQ administrateur je souhaite qu'un type de champ expression régulière ne bloque pas l'edition de ma demarche
2024-07-15 09:34:16 +00:00
mfo
1cd539297f
feat(dossier.passer_en_construction!): clean up PJ for champs that are not visible [condition is false]
2024-07-15 11:28:59 +02:00
mfo
19268345db
fix(tdc.expression_reguliere): invalid regexp shows nice error message
2024-07-15 09:59:50 +02:00
mfo
29d36973ba
bug(tdc.expression_reguliere): invalid regexp should not raise error
2024-07-15 09:54:44 +02:00
Paul Chavard
f74e8d9c56
disable test untill we can figure out what to do
2024-07-12 17:32:34 +02:00
Benoit Queyron
2a955a0f8c
correction du test sur l'état de l'input
2024-07-12 11:36:43 +02:00
Benoit Queyron
88710969bb
correction du test sur la suppression de la PJ d'un dossier
2024-07-12 11:17:51 +02:00
Eric Leroy-Terquem
ea8112b8b3
fix(routing): open routing wizard to all conditionable types
2024-07-11 14:55:03 +02:00
Eric Leroy-Terquem
60ff785009
refactor(type de champ): rename routable_types in simple_routable_types
2024-07-11 12:17:46 +02:00
Eric Leroy-Terquem
30da11823b
db(task): create previews for pjs in one week
2024-07-10 17:38:05 +02:00
Eric Leroy-Terquem
c9d74c46d1
db(task): create variants for pjs in one week
2024-07-10 17:38:04 +02:00
Lisa Durand
7539d2ddea
fix specs
2024-07-10 16:11:38 +02:00
Lisa Durand
42633c0012
Merge branch 'main' of github.com:betagouv/demarches-simplifiees.fr into instructeur-invitation-include-typo-suggestion-ldu
2024-07-10 14:58:55 +02:00
Lisa Durand
3b138d5bb7
add confirmation for tiers email
2024-07-10 10:57:26 +02:00
mfo
f3690d8890
Merge pull request #10587 from tchak/refactor-no-validate-on-format
...
refactor(champ): remove call to validation from value formatting code
2024-07-09 14:31:10 +00:00
Benoit Queyron
fc385208db
update test
2024-07-08 16:09:25 +02:00
Paul Chavard
96e49d54cd
reafctor(logic): remove tests and accept unspecified behaviour
2024-07-08 15:44:30 +02:00
Colin Darie
ba6fdc4748
feat: /commencer alert about draft procedure
2024-07-08 11:32:37 +02:00
Colin Darie
28e8c786fa
chore: don't wrap "en test" tag/breadcrumb
2024-07-08 11:32:37 +02:00
mfo
75a6c8b4b6
Merge pull request #10555 from mfo/US/normalize-number-cahmp
...
tech: Normalisation des champs de type number/decimal pr enlever les espace blanc à la saisi
2024-07-08 07:31:29 +00:00
Paul Chavard
89fb0abe6e
fix(spec): fix system test
2024-07-05 09:36:33 +02:00
Paul Chavard
9f9243499c
refactor(combobox): fix specs
2024-07-05 09:36:33 +02:00
Paul Chavard
cb01f15570
refactor(champ): update champ commune
2024-07-05 09:36:33 +02:00
Paul Chavard
4e8b29b21c
refactor(js): remove old code
2024-07-05 09:36:33 +02:00
mfo
a8573febaa
clean(spec): remove since its now forced by a before_validation
2024-07-05 09:34:26 +02:00
Lisa Durand
8ff2bbbaab
fix specs
2024-07-04 14:41:37 +02:00
mfo
c50f949acd
feat(Champs::number*): normalize values by stripping spaces.
2024-07-04 09:56:23 +02:00
Colin Darie
68cf6b58a3
Merge pull request #10574 from colinux/fix-experts-invits
...
ETQ admin, fix l'invitation d'experts n'ayant pas de compte DS
2024-07-02 17:33:11 +02:00
Colin Darie
b3ccfc16c4
Merge pull request #10547 from colinux/mandatory-by-default
...
ETQ admin, un nouveau champ est obligatoire par défaut
2024-07-02 14:26:29 +00:00
Colin Darie
a53fc0fac9
fix(admin): invitation for experts not having an account
2024-07-02 16:15:24 +02:00
Colin Darie
b2514dd16c
Merge pull request #10567 from colinux/fix-hardcoded-name
...
Tech: corrige le nom de l'application hardcodé dans un email
2024-07-02 12:36:19 +00:00
Colin Darie
5e25547b7b
fix(attestation): don't delete v1 published when building a v2
2024-07-02 14:10:23 +02:00
Lisa Durand
337689333e
Merge pull request #10559 from demarches-simplifiees/change-button-print-to-download-for-user-ldu
...
ETQ usager, je veux pouvoir télécharger mon dossier sans avoir à passer par le bouton "imprimer"
2024-07-02 08:54:16 +00:00
Eric Leroy-Terquem
5397c84918
clean: remove failing maintenance tasks
2024-07-02 09:58:28 +02:00
Colin Darie
eee6e5e651
Merge pull request #10483 from colinux/fast-tests
...
Tech (tests): default administrateur fixtures
2024-07-01 21:35:11 +00:00
Colin Darie
2041623ded
test: merge similar examples
2024-07-01 22:36:31 +02:00
Colin Darie
9e80962ea5
test: default administrateur as fixtures
2024-07-01 22:36:31 +02:00
Lisa Durand
8b4e12a407
replace wording, use download instead of print
2024-07-01 17:20:55 +02:00
Colin Darie
f40b71f450
test(type_de_champ): mandatory by default, like schema
2024-07-01 17:00:49 +02:00
mfo
896ee76d74
Merge pull request #10524 from mfo/US/expert-invitation-by-admin
...
ETQ administrateur, lorsque je gère ma liste d'expert invités sur une démarche, je suis guidé pour eviter les typos
2024-07-01 09:59:15 +00:00
Colin Darie
327ebf106f
fix(mailer): hardcoded application name
2024-07-01 10:55:58 +02:00
mfo
e6a3f210d4
fix(experts_procedures#create): ensure to reload expert list after addition
2024-07-01 10:46:06 +02:00
Lisa Durand
159cc942f6
Merge pull request #10549 from demarches-simplifiees/new-instructeur-need-mail-confirmation-ldu
...
ETQ nouvel instructeur, je dois confirmer mon mail
2024-07-01 08:45:57 +00:00
mfo
ced634295e
clean(tech): EmailChecker, use class method, not instance
2024-07-01 10:40:55 +02:00
Lisa Durand
75403ba949
add specs
2024-06-26 10:57:40 +02:00
mfo
cfda807b66
fix(data): decimal number having spaces are no more exportable
2024-06-25 21:17:46 +02:00
mfo
476c7df160
bug(Champs::DecimalNumberChamp.for_export): should be able to cast a number wrapped with a string having leading/trailing spaces
2024-06-25 17:05:33 +02:00
Colin Darie
828c539469
Merge pull request #10546 from colinux/fix-flaky-brouillon
...
Tests: fix JS log events
2024-06-25 14:12:52 +00:00
Lisa Durand
d7893b9102
instructeur need to confirm mail after invitation
2024-06-25 15:14:26 +02:00
mfo
554141bb67
fix(spec): broken
2024-06-25 14:52:01 +02:00
mfo
2bb7584246
feat(administrateurs/experts_procedures#create): avoid typo on expert
...
list management
2024-06-25 14:04:01 +02:00
Colin Darie
e9920c76d5
feat(faq): can add dsfr alert from markdown
2024-06-24 16:28:35 +02:00
Colin Darie
55cc48b785
test: JS_LOG allows multiple events
2024-06-24 15:29:56 +02:00
Eric Leroy-Terquem
1ab77cede9
Merge pull request #10512 from demarches-simplifiees/safer-gallery
...
Technique : mise à jour de la galerie et transformation des images uniquement côté jobs
2024-06-24 10:16:57 +00:00
Eric Leroy-Terquem
c94c2f55c8
task(pj): create representations for latest pieces jointes
2024-06-24 11:13:37 +02:00
Eric Leroy-Terquem
0c95a098a5
feat(gallery): do not create representations in web machines
2024-06-24 11:13:36 +02:00
Colin Darie
ccf5b255ed
Merge pull request #10465 from colinux/attestations-v2-prod
...
ETQ admin je peux activer la délivrance des attestations v2 (sous feature flag)
2024-06-24 08:56:31 +00:00
Colin Darie
5ac2315b5a
Merge pull request #10535 from mfo/US/page-procedure-show
...
Améliroation, ETQ instructeur le nombre de dossier par page passe de 25 a 100
2024-06-24 08:14:56 +00:00
mfo
4e67255405
feat(instructeurs/procedure#show): increase dossier page size but keep request count same
2024-06-21 16:50:08 +02:00
mfo
2ee6f2350a
Merge pull request #10536 from mfo/US/summary-in-instructeur-demande
...
ETQ instructeur, je peux naviguer dans le formulaire de l'usager via un sommaire, idem pour les annotations privées.
2024-06-21 14:44:50 +00:00
mfo
4c5e0c245c
tech(spec): perf, instructeurs/procedures#show, start tracking request count on procedure show
2024-06-21 16:19:32 +02:00
mfo
4caeecadff
Merge pull request #10534 from mfo/US/fix-ineligibilite-rules-check-without-rules
...
Correctif: ETQ admin, je ne peux pas activer l'inéligibilité des dossiers sans règles d'inéligibilité
2024-06-21 09:47:43 +00:00
mfo
d46dc7055d
feat(instructeurs/dossiers): add summary to dossier.champs and dossier.champ_private views, also extract summary in
...
two component. one of type de champ editor. one for viewable champs
2024-06-21 11:06:45 +02:00
mfo
5a5ebfb235
Merge pull request #10531 from mfo/US/add-champ-summary-to-annotations
...
ETQ administrateur, je peux naviguer dans l'editeur des annotations en utilisant le sommaire façon editeur des champs du formulaire
2024-06-21 08:34:12 +00:00
mfo
6eaf870cbf
feat(administrateurs/procedure#annotations): add summary
2024-06-21 05:50:24 +02:00
mfo
43a7364229
Merge pull request #10522 from mfo/US/fix-submitted-dossier-error
...
Correctif: ETQ admin, j'aimerais pouvoir modifier le message de confirmation de dépôt de dossier
2024-06-21 03:22:48 +00:00
Colin Darie
372c732458
Merge pull request #10513 from colinux/helpscount-api
...
ETQ opérateur je peux supprimer les vieilles conversations helpscout
2024-06-20 19:57:46 +00:00
mfo
84cdeaa4cc
Merge pull request #10527 from mfo/US/fix-eligibilite-rules-caching-champs.visible
...
fix(eligibilite_rules): checking for eligibilites rules should not cache champs.visible
2024-06-20 14:11:11 +00:00
mfo
24d7b0b014
fix(ineligibilite_rules): prevent admin to enable ineligibilite rules without rules
2024-06-20 15:35:36 +02:00
mfo
cbe8d92f81
Merge pull request #10530 from demarches-simplifiees/a11y-fix-nav
...
Correction de la structure de navigation
2024-06-20 13:25:54 +00:00
Colin Darie
666b51fa9c
fix(textarea): merge data controllers from opts & autoresize
2024-06-20 14:31:05 +02:00
Colin Darie
f2669fbca8
fix(attestation): fix unspecified_attestation_champs for v2
2024-06-20 14:15:06 +02:00
Colin Darie
a2c0379127
test(attestation): preview pdf
2024-06-20 14:15:06 +02:00
Colin Darie
70aee9c9de
refactor(autosave): extract in component, better wording for attestation
2024-06-20 14:15:06 +02:00
Colin Darie
ce998f7864
feat(attestation): already published without publication when procedure is draft
2024-06-20 14:15:06 +02:00
Colin Darie
5bda9d0c63
test(attestation): fix wording after rebase
2024-06-20 14:15:05 +02:00
Colin Darie
cf58c48843
feat(attestation): can toggle activation
2024-06-20 14:15:05 +02:00
Colin Darie
cd07ee173f
feat(attestation): can reset draft attestation
2024-06-20 14:15:05 +02:00
Colin Darie
a540f8dccb
feat(attestation): can render & attach attestations v2
2024-06-20 14:15:05 +02:00
Colin Darie
ffd8c5617a
chore(attestation): card link to v2 if exist
2024-06-20 11:08:16 +02:00
Colin Darie
11d29f5574
chore(attestation): publish a v2 attestation
2024-06-20 11:08:15 +02:00
Colin Darie
4af6957237
fix(attestation): dup keep all attributes
2024-06-20 11:08:15 +02:00
Colin Darie
c5c24c01d8
chore(attestation): procedure#attestation_template always returns the published attestation
2024-06-20 11:08:15 +02:00
Corinne Durrmeyer
e5959b6081
Update test file
2024-06-18 15:13:54 +02:00
mfo
8cbf4753ff
bug(ineligibilite_rules): caching champs.visible without re-validation afterward means we can skip conditions
2024-06-17 16:40:31 +02:00
mfo
d1e983ed97
fix(EmailCheckerController): with partial email, should not raise error
2024-06-17 13:25:28 +02:00
Colin Darie
eaee4164a6
Merge pull request #10515 from colinux/contact-form-async
...
ETQ opérateur, le form de contact devient asynchrone et l'antivirus passe sur les PJ
2024-06-14 10:29:24 +00:00
Colin Darie
2dda5e44f9
chore(kredis): use default shared connection name, fixing dossier index debounce
2024-06-14 11:53:36 +02:00
mfo
2e1e1c060b
fix(dossier_submitted_message#edit): missing dossier for preview
2024-06-14 11:42:42 +02:00
Colin Darie
6fde2ede06
Merge pull request #10510 from colinux/tech-candies
...
Tech : 2 petites choses pratiques
2024-06-13 13:05:43 +00:00
Colin Darie
a1469b04fe
refactor(support): create HS conversation in async and run virus scanner on attachments
2024-06-13 13:27:51 +02:00
Colin Darie
939bc37eab
test(vcr): automatically redact bearer tokens
2024-06-13 11:16:53 +02:00
Colin Darie
9d4113befb
feat(helpscout): delete old conversations
2024-06-13 11:16:52 +02:00
mfo
8cb902821f
bug(draft_types_de_champ_private.condition): condition must be validated with upper_tdcs. considering that types_de_champ_private can have a condition using a types_de_champ_public, we have to include all types_de_champs_public plus only types_de_champs_private.upper_tdcs
2024-06-11 16:05:45 +02:00
Colin Darie
7553a5fc52
test: don't trace coverage by default in local machines
2024-06-11 14:46:23 +02:00
mfo
f6a5e932b8
Merge pull request #10292 from mfo/US/elligible-on-submit
...
ETQ administrateur, je peux ajouter des conditions d'eligibilité auxquelles les dossiers doivent correspondre sans quoi l'usager ne peut déposer son dossier
2024-06-11 09:46:25 +00:00
mfo
03381c05b3
Merge pull request #10499 from mfo/US/email-check-with-levenshtein
...
tech: ETQ usager je souhaite une verification de mes mails plus efficace
2024-06-11 08:55:28 +00:00
mfo
8e3d45b0b1
review(pr): some enhancement, tx @colinux
...
Co-Authored-By: Colin Darie <colin@darie.eu>
2024-06-11 10:48:10 +02:00
mfo
f819da8921
tech(clean): simplify implementation of eligibilite rules, code, enhance wording and test coverage
2024-06-11 09:57:36 +02:00
mfo
a011576757
feat(procedure_revision.validates): ineligibilite_rules
2024-06-11 09:39:21 +02:00
mfo
e3a24d53ea
tech(refactor): procedure::error_summary and dossier::ErrorsFullMessagesComponent use same behaviour to compact/expand errors
2024-06-11 09:39:20 +02:00
mfo
c480bc00c3
feat(Users/Dossiers#submit_brouillon_or_en_construction): prevent transition to en_construction if ineligibilite_rules matches. pop error nicely
2024-06-11 09:32:54 +02:00
mfo
178685b34b
feat(TypeDeChampEditor): prevent to destroy a type de champ used by inligibilite rules
2024-06-11 09:32:54 +02:00
mfo
be5f580237
feat(Users/Dossiers#update): track changes live and pop modal when ineligibilite_rules matches
2024-06-11 09:32:54 +02:00
mfo
2210db3b81
feat(Dossier::EditFooterComponent): disable submit button when inligibilite_rules matches
2024-06-11 09:32:54 +02:00
mfo
5644692448
feat(Logic.computable?): add computable? to know if a ineligibilite_rules set is computable
2024-06-11 09:32:53 +02:00
mfo
5de4ce889f
feat(ProcedureRevision.ineligibilites_rules): keep track of changes and show it to admin for republication
2024-06-11 09:32:53 +02:00
mfo
aca3e38859
feat(ProcedureRevision.ineligibilite_rules): add ineligibilite_rules management to procedure revision based on conditional logic
2024-06-11 09:32:53 +02:00
mfo
12d23f1498
feat(Procedure::Cards::IneligibleDossier): add an ineligibilite dossier card to procedure dashboard
2024-06-11 09:32:53 +02:00
mfo
ab522a3e40
Merge pull request #10503 from mfo/US/fix-condition-validator-on-private-champ-using-public-tdc
...
Correctif: ETQ admin, je souhaite pouvoir utiliser des champs public pour conditionner une annotation privée
2024-06-10 09:33:22 +00:00
mfo
27b86f9848
fix(TypesDeChamp::ConditionValidator): allow to use types_de_champ_public on condition for types_de_champ_private
2024-06-10 11:26:01 +02:00
mfo
d2ccea700b
bug(TypesDeChamp::ConditionValidator): should allow to use types_de_champ_public on condition for types_de_champ_private
2024-06-10 09:35:29 +02:00
mfo
66eb3dc821
feat(email_check): change strategy to check email, dropping email_buttler package and using a custom EmailChecker
2024-06-07 16:09:32 +02:00
mfo
c813c02975
feat(EmailChecker.check): add class to search for typo in email addresses
2024-06-07 15:13:50 +02:00
Eric Leroy-Terquem
48c092a74a
test(gallery): test gallery helper
2024-06-06 12:17:56 +02:00
Eric Leroy-Terquem
05ad5dcbd6
feat(gallery): display large variant for rare image types
2024-06-06 12:01:40 +02:00
Colin Darie
d9451aa64b
Merge pull request #10463 from demarches-simplifiees/reorganize-config-expert-ldu
...
[admin] améliorer configuration des experts invités
2024-06-06 07:16:49 +00:00
Kara Diaby
cb5ba455eb
Fixe bug sur toutes les démarches
2024-06-05 14:13:44 +00:00
mfo
5ef29a2f31
Merge pull request #10479 from mfo/us/enhance-procedure-validation
...
ETQ Admin, les erreurs liés aux formulaire usager et instructeurs sont plus consistantes
2024-06-05 05:14:45 +00:00
mfo
ef3ca9839b
feat(procedure.validation): extract validation context: types_de_champ_public_editor, types_de_champ_private_editor and publication [combining both contextes]. validate conditions, headers_sections, regexp on type_de_champ_private too. dry validation
2024-06-04 18:25:24 +02:00
Paul Chavard
9753a91db6
feat(graphql): messages can be discarded through api
2024-06-04 17:41:26 +02:00
mfo
f14c88a54a
clean(spec): speed, avoid using with_all_champs factory. takes too much time when not needed
2024-06-04 15:34:34 +02:00
mfo
f98517852f
feat(spec.procedure_administrateurs_spec): les navigation and cases
2024-06-04 15:34:34 +02:00
krichtof
45814fdbfb
Merge pull request #10454 from demarches-simplifiees/9827-add-specs
...
corrige quelques bugs de la feature export template (renommage dans le zip)
2024-06-04 13:18:12 +00:00
Colin Darie
ec269a568c
fix(mailer): fix delivery prevented with bcc
2024-06-04 14:27:04 +02:00
Christophe Robillard
ac23d5fb41
convert date with dash for export renaming
2024-06-04 10:32:14 +02:00
Paul Chavard
68c15ba99f
feat(champ): add updated_by column
2024-06-03 18:45:16 +02:00
Kara Diaby
8e093e88c2
Ajoute la méthode Acronomyze comme helper pour être utilisé sur la page toutes les démarches
2024-06-03 07:50:09 +00:00
Paul Chavard
27f15bbe07
Merge pull request #10070 from tchak/remove-vite-legacy
...
chore(js): remove vite legacy build
2024-05-31 19:56:17 +00:00
simon lehericey
819fa2cde2
feat(User): always allow reset_password_instructions
2024-05-31 14:53:50 +02:00
simon lehericey
7c514e3585
feat(user): always allow invitation mail
2024-05-31 14:53:50 +02:00
simon lehericey
8104157da6
feat(user): always allow devise mail
2024-05-31 14:53:49 +02:00
simon lehericey
607fbf5287
feat(user): block unverified_email from being sent
2024-05-31 14:53:49 +02:00
Paul Chavard
d44822cc1c
chore(js): remove vite legacy build
2024-05-31 14:17:59 +02:00
LeSim
abd2dae7a0
Merge pull request #10472 from demarches-simplifiees/block_dubious_email_adresse
...
Tech: block l'envoi de mails à des adresses douteuses
2024-05-31 08:32:43 +00:00
mfo
a278aac92f
fix(spec): maj broken spec on main
2024-05-31 08:24:55 +02:00
Lisa Durand
ee203d1afc
reorganize page config expert invites
2024-05-30 17:50:08 +02:00
Lisa Durand
291271f04b
fix linter and specs
2024-05-30 17:05:01 +02:00
simon lehericey
14294af5dc
tech: block dubious emails address
2024-05-30 12:35:04 +02:00
Christophe Robillard
acf6579aa4
add missing specs to export template
2024-05-29 14:38:05 +02:00
Kara Diaby
db0b32a99a
Test la méthode parsed_latest_zone_labels
2024-05-29 11:45:31 +00:00
Paul Chavard
de209954e1
Merge pull request #10466 from tchak/fix-supprimes_recemment-should-include-archived
...
fix(instructeur): supprimes_recemment should include archived dossiers
2024-05-29 11:09:41 +00:00
Paul Chavard
5154231ccf
fix(dossier): batch operations to termine dossier should send emails
2024-05-29 11:31:58 +02:00
Paul Chavard
b06934b8d3
fix(instructeur): supprimes_recemment should include archived dossiers
2024-05-29 11:03:46 +02:00
Christophe Robillard
c0a95ab525
add specs to pieces_justificatives_service
2024-05-28 18:25:48 +02:00
Christophe Robillard
bc4deb1fc2
add specs to export templates controller
2024-05-28 18:25:38 +02:00
Christophe Robillard
d9f7b6d1df
fix dossier directory for etablissement when export with export template
2024-05-28 18:25:38 +02:00
Christophe Robillard
2267ec98cf
fix dossier directory for attestation when export with export template
2024-05-28 18:25:37 +02:00
Christophe Robillard
4232cc98c7
fix dossier directory for motivation when export with export template
2024-05-28 18:25:37 +02:00
Christophe Robillard
08c079ca0b
fix dossier directory for avis when export with export template
2024-05-28 18:25:37 +02:00
Christophe Robillard
ce6ebf3589
fix dossier directory for commentaire when export with export template
2024-05-28 18:25:37 +02:00
Christophe Robillard
06cbb65d4e
spec: simplify export template factory
2024-05-28 18:25:37 +02:00
Christophe Robillard
5846fb4417
fix spec titles
2024-05-28 18:25:37 +02:00
simon lehericey
1cf9535bea
feat(User): verify mandat email during creation
2024-05-27 17:24:56 +02:00
simon lehericey
fa06d17169
Feat(user): set email_verified_at when setting confirmed_at
2024-05-27 17:24:56 +02:00
simon lehericey
841c1cc845
Feat(user): verify user email during devise confirmation
2024-05-27 17:24:55 +02:00
Paul Chavard
1bca3c123b
chore(dossier): remove legacy update attributes
2024-05-27 10:33:37 +02:00
Colin Darie
eaf9773e9e
chore(job): DossierIndexSearchTerms in low_priority queue
2024-05-27 09:55:24 +02:00
simon lehericey
0869168bd3
spec: test champs_id_row_index
2024-05-23 10:07:36 +02:00
simon lehericey
d3b700326d
spec: fix
2024-05-23 10:01:29 +02:00
simon lehericey
e38999efda
perf(pj service): compute row_id without extraneous requests
2024-05-23 10:01:29 +02:00
simon lehericey
8628ec1621
perf(spec): new record !
...
Co-authored-by: Christophe Robillard <christophe.robillard@beta.gouv.fr>
2024-05-23 10:01:29 +02:00
simon lehericey
a7e29c4ea6
perf(spec): new count !
2024-05-23 10:00:42 +02:00
simon lehericey
fa7d5cfa33
fix test
2024-05-23 10:00:41 +02:00
simon lehericey
d60e7906e0
refactor: memoize flat_tags
2024-05-23 10:00:41 +02:00
simon lehericey
fe5c655a52
spec(perf): count sql queries for 10 dossiers
2024-05-23 10:00:40 +02:00
simon lehericey
585810553f
refactor(suffix): be consistent with index suffix
2024-05-23 10:00:39 +02:00
simon lehericey
b656867836
refactor(pj_service): do not query for pj_index
2024-05-23 10:00:39 +02:00
simon lehericey
6d757db20b
fix: champ.row_index and test pjs_for_champs
2024-05-23 10:00:39 +02:00
