2881 commits

Author	SHA1	Message	Date
simon lehericey	04965ac35a	improve constant and empty to_s	2022-07-05 12:07:06 +02:00
simon lehericey	dda5bc35ed	extract champ value type	2022-07-05 12:07:06 +02:00
simon lehericey	809319f593	exposed champ value managed tdc	2022-07-05 12:07:06 +02:00
simon lehericey	5ebaf59fdb	parent_id -> parent_stable_id	2022-07-05 11:53:18 +02:00
simon lehericey	1342356651	after_id -> after_stable_id	2022-07-05 11:53:18 +02:00
Paul Chavard	9a6a8411d3	feat(export): add déparctement info to commune champ export	2022-07-04 16:30:16 +02:00
simon lehericey	f8c7003192	fix drop down other	2022-07-01 16:05:31 +02:00
Martin	54cc9de51e	feat(dubious): add RIB & IBAN and fix NRIPP istead of NIRPP	2022-06-29 17:07:00 +02:00
Martin	4ec61e58ac	feat(EditComponent): add max_file_size and content_types to upload buttons inspired by dsfr	2022-06-28 17:44:35 +02:00
Martin	ea71908850	fix(ChampEditor): add missing drop_down_other for type_de_champ.drop_down_list_with_other?	2022-06-27 17:19:10 +02:00
Christophe Robillard	6dd27ec7ed	reset opendata to true when procedure is cloned by another admin	2022-06-23 14:11:09 +02:00
Christophe Robillard	ea59f5f260	add opendata boolean attribute for procedure ... when opendata is set to true, it means that descriptive's procedure can be public when opendata is set to false, ti means that descriptive's can not be public, because the procedure is only available for public servants, not citizens.	2022-06-23 14:11:09 +02:00
Martin	ab4d4c83a8	feat(GroupeInstructeurs.closed): add closed option to GroupeInstructeur in order to prevent usagers to submit dossier	2022-06-20 16:32:06 +02:00
Martin	274b5eab2e	feat(invite): wrap invitation with targeted_user_links	2022-06-17 16:44:37 +02:00
simon lehericey	9596dac508	force resync types_de_champ and types_de_champ_public/private	2022-06-17 14:54:21 +02:00
simon lehericey	0db27b8718	validate conditions on revision	2022-06-17 14:54:21 +02:00
simon lehericey	758933f6f9	tdc can have condition	2022-06-17 14:53:28 +02:00
simon lehericey	9f49e8c2ea	add ensure_compatibility_from_left	2022-06-17 14:53:27 +02:00
simon lehericey	5ac3049033	add champ_value for dropdown	2022-06-17 14:53:27 +02:00
simon lehericey	809d991819	add champ_value	2022-06-17 14:53:27 +02:00
simon lehericey	daaa54b6f0	add n_ary operators	2022-06-17 14:53:27 +02:00
simon lehericey	698eff0a50	add equal operator	2022-06-17 14:53:27 +02:00
simon lehericey	ebe95b83fa	add compatibility checks	2022-06-17 14:53:27 +02:00
simon lehericey	a98a6d6d1e	add binary operators	2022-06-17 14:53:27 +02:00
simon lehericey	6ebfc505c4	add empty	2022-06-17 14:53:27 +02:00
simon lehericey	58da4805fa	add constant	2022-06-17 14:53:27 +02:00
Paul Chavard	350ed3a11a	feat(graphql): expose revision on demarche descriptor type	2022-06-17 12:33:35 +02:00
Paul Chavard	bbc44fe339	fix(export): no crash on empty repetitions	2022-06-17 11:33:48 +02:00
Paul Chavard	6801b04b7b	feat(type_de_champ): type_de_champ editor in stimulus/turbo	2022-06-17 11:04:09 +02:00
Paul Chavard	1573d20ee9	types_de_champ controller to use turbo	2022-06-17 11:04:09 +02:00
Paul Chavard	65bd996f2a	refactor(types_de_champ_editor): remove old react editor	2022-06-17 11:04:09 +02:00
Paul Chavard	564daeffe8	perf(dossier): improuve dossier preloading perf	2022-06-14 09:04:26 +01:00
Martin	56f7133799	fix(procedure_presentation): can not present a 'virtual field' like depose_since ... fix(data): add migration to remove fields depose_since from existing procedure presentation	2022-06-14 09:02:37 +02:00
Kara Diaby	d58ecb3fcc	Lors de la restauration d'une démarche supprimée, met sur les dossiers liés hidden_by_administration_at à nil	2022-06-10 12:33:47 +02:00
Paul Chavard	95a1ea1047	feat(procedure_presentation): add since date filters	2022-06-09 13:01:22 +01:00
Kara Diaby	d2bd2ffcbe	controller	2022-06-08 14:38:17 +02:00
Kara Diaby	60eed4ec01	model	2022-06-02 15:48:11 +02:00
Martin	d39b3b09ed	fix(webhook.perform): ensure to enqueue job with current state/updated_at for consistency reason	2022-06-01 15:54:55 +02:00
Paul Chavard	462b2618a4	feat(procedure): move new children to new parent in transaction	2022-06-01 09:33:39 +02:00
Martin	cb890343ff	feat(targeted_user_link): add targeted user link to wrap expert invitation in order to avoid access issue when the expert is connected with another account ... feat(user.merge): ensure to merge user.targeted_user_link Update app/models/targeted_user_link.rb Co-authored-by: LeSim <mail@simon.lehericey.net> Update app/models/targeted_user_link.rb Co-authored-by: LeSim <mail@simon.lehericey.net> Update app/models/targeted_user_link.rb Co-authored-by: LeSim <mail@simon.lehericey.net> feat(db/create_targeted_user_links): ensure not null with fk	2022-05-31 14:50:31 +02:00
Paul Chavard	c0a253078c	fix(revision): fix clone démarches with repetitions	2022-05-31 13:28:56 +02:00
Paul Chavard	a36672239d	refactor(revision): rename find_or_clone_type_de_champ	2022-05-31 08:58:53 +02:00
Paul Chavard	6f98def288	refactor(revision): remove old code	2022-05-31 08:58:53 +02:00
Kara Diaby	36aff57f24	model	2022-05-26 12:45:05 +02:00
Christophe Robillard	fd98247b48	[manager] add list of dubious procedures	2022-05-25 14:44:53 +02:00
Pierre de La Morinerie	8936461d5b	app: cache the duration estimate for published procedures	2022-05-25 10:39:18 +02:00
Pierre de La Morinerie	3e91a16895	app: display estimated fill duration on procedure description	2022-05-25 10:39:15 +02:00
Pierre de La Morinerie	3b57d98692	model: add estimated_fill_duration to type_de_champ	2022-05-25 10:37:59 +02:00
Pierre de La Morinerie	4fcb85fd65	app: remove procedure_dossier_papertrail feature flag ... The feature is now enabled for all procedures.	2022-05-24 17:32:11 +02:00
simon lehericey	8ce080bd3e	updated_at pb	2022-05-24 15:38:50 +02:00
simon lehericey	db5d291acd	complete spec and alternative implem	2022-05-24 15:38:50 +02:00
simon lehericey	abc3681053	delegate stable_id to tdc	2022-05-24 15:38:50 +02:00
simon lehericey	e7078279b8	rename published to target to be coherent	2022-05-24 15:38:50 +02:00
simon lehericey	75ec99e709	comments	2022-05-24 15:38:50 +02:00
Paul Chavard	0817731d6a	refactor(dossier): rebase to use new revisions	2022-05-24 15:38:50 +02:00
Martin	51f0be1034	clean(deadcode): remove dead methods	2022-05-24 14:23:40 +02:00
Martin	0eccb08f8b	fix(root): do not forget to move claimant_id when merging instructeur	2022-05-24 14:23:40 +02:00
Paul Chavard	b635952b2f	refactor(revision): types_de_champ for export	2022-05-23 18:36:18 +02:00
Paul Chavard	50aa50b047	refactor(type_de_champ): use children_of when serializing type_de_champ	2022-05-23 18:22:42 +02:00
Paul Chavard	ee50b8ad25	refactor(graphql): fix types_de_champ usage	2022-05-23 18:03:55 +02:00
Paul Chavard	a6cf311f56	Revert "if is not only in draft, its gonna be cloned anyway" ... This reverts commit 71e9240a7d.	2022-05-18 22:53:39 +02:00
simon lehericey	74653631c3	few comments	2022-05-18 22:23:31 +02:00
simon lehericey	71e9240a7d	if is not only in draft, its gonna be cloned anyway	2022-05-18 22:23:31 +02:00
simon lehericey	20288fbb7d	revise_type_de_champ -> replace_tdcs_and_children_by_clones	2022-05-18 22:15:22 +02:00
simon lehericey	e7524b3f0d	extract var	2022-05-18 21:59:31 +02:00
Paul Chavard	0e335f58ac	fix(revision): update children coordinate instead of duplicating	2022-05-18 19:39:20 +02:00
Pierre de La Morinerie	49410ff5f7	models: update database comments	2022-05-18 15:39:33 +02:00
simon lehericey	419d853d1d	add target_revision on rebase	2022-05-18 15:18:17 +02:00
simon lehericey	8bd3de2050	remove use of repetition.types_de_champ (except rebase)	2022-05-18 15:18:17 +02:00
simon lehericey	1921661fad	simplify children_of	2022-05-18 12:30:58 +02:00
simon lehericey	633f0d1ce5	remove_repetition	2022-05-18 12:12:25 +02:00
simon lehericey	4d97f6aa8c	types_de_champ_for_revision	2022-05-18 11:40:34 +02:00
Paul Chavard	6c2a3bafa4	refactor(dossier): champs order by coordinate	2022-05-18 11:20:50 +02:00
simon lehericey	be33c0ce7b	extract coordinate_and_tdc	2022-05-18 10:11:31 +02:00
simon lehericey	7f23449f24	remove set_position	2022-05-18 10:11:31 +02:00
Paul Chavard	0dfc015690	feat(dossiers): bring back export all dossiers	2022-05-17 18:34:00 +02:00
Paul Chavard	b6ea44f7e7	refactor(revision): remove type_de_champ#revision_id	2022-05-17 11:31:49 +02:00
Pierre de La Morinerie	0063b68689	mailers: add deposit receipt to initiated_mail ... See #6146	2022-05-17 10:25:13 +02:00
Paul Chavard	8d9929aa9f	fix(revision): (re)move child type de champ should clone parent for now	2022-05-13 17:17:24 +02:00
Paul Chavard	85c20784a2	refactor(revision): delete unused code	2022-05-13 17:17:23 +02:00
Paul Chavard	d7678c4389	Revert "Merge pull request #7295 from tchak/rollback-attempt" ... This reverts commit 24b37c230d, reversing changes made to 08b90b9173.	2022-05-13 17:17:23 +02:00
Kara Diaby	e99bd5f558	models	2022-05-13 10:31:51 +02:00
Paul Chavard	6adb3f7a3a	fix(revision): fix migrate_parent!	2022-05-12 10:40:41 +02:00
Paul Chavard	edf0cbf320	bring back find_type_de_champ_by_stable_id old implementation	2022-05-11 20:29:01 +02:00
Paul Chavard	4c26e34c79	Revert "Merge pull request #7270 from betagouv/remove_type_de_champ_v2" ... This reverts commit 41b6f8f51b, reversing changes made to 79d5946ab6.	2022-05-11 20:03:42 +02:00
Paul Chavard	08caa122dd	Revert "Merge pull request #7280 from betagouv/move_type_de_champ_v2" ... This reverts commit 08b90b9173, reversing changes made to bc9a90bd08.	2022-05-11 20:03:33 +02:00
simon lehericey	5d6dd853d4	refactor reorder: add order_place only in children	2022-05-11 16:54:26 +02:00
simon lehericey	df91fd1180	move_type_de_champ new style	2022-05-11 16:54:26 +02:00
simon lehericey	b6c2aa30f4	reorder the siblings after deletion	2022-05-11 15:59:17 +02:00
simon lehericey	5dd8bbe797	fix remove type de champ	2022-05-11 15:59:17 +02:00
Kara Diaby	d187b7e881	model	2022-05-10 16:16:16 +02:00
Martin	bf277d4802	bug(export): expect dossiers_for_export not to include dossiers brouillon ... fix(export.dossiers_for_export): add missing visible_by_administration	2022-05-10 16:09:12 +02:00
simon lehericey	d2509e7492	add procedure_revision children_of	2022-05-10 14:52:57 +02:00
Martin	75da4d8c8d	Revert "migration(fix.data): when a repetable revision_types_de_champ points to a non active revision type de champs, relink it to the actuel revision_type_de_champs pointing to the stable id of its parent.type_de_champ.stable_id" ... This reverts commit 19360e7aac.	2022-05-09 18:45:35 +02:00
Martin	19360e7aac	migration(fix.data): when a repetable revision_types_de_champ points to a non active revision type de champs, relink it to the actuel revision_type_de_champs pointing to the stable id of its parent.type_de_champ.stable_id	2022-05-09 18:01:02 +02:00
simon lehericey	4ec5b418cb	fix create_new_revision	2022-05-06 12:37:59 +02:00
Paul Chavard	842506f993	refactor(revision): rename revision methods params to reflect usage of stable_id	2022-05-06 11:08:58 +02:00
Paul Chavard	98814c3812	refactor(revision): test for type_de_champ having a unique revision	2022-05-06 11:08:51 +02:00
simon lehericey	ce0a592f3c	simplify find_type_de_champ_by_id	2022-05-06 10:34:40 +02:00
Martin	ba7a316f5e	fix(Dossier.for_export): instead of iterating champs to build an hash {stable_id: values} ; we iterate on the list of all type de champs, so when there is a type de champ with mutliple values for export, we build the column with the nil value	2022-05-06 09:38:45 +02:00
Martin	3737311390	feat(procedure.procedure_expires_when_termine_enabled): enable by default, allow contributor to choose the default settings of this flag using an env var during migration. ie: DEFAULT_PROCEDURE_EXPIRES_WHEN_TERMINE_ENABLED=true|false ... feat(administrateurs/procedures#show): warning/alert when procedure_expires_when_termine_enabled is not true on current procedure feat(administrateur/procedure#update): after an update redirect to procedure show: suggested by: https://ux.stackexchange.com/questions/55291/after-updating-form-should-redirect-back-to-form-itself-or-to-the-show-page-or-b and confirmed by Olivier clean(Flipper.archive_zip_globale): no more in use, so remove all occurences Update app/views/administrateurs/procedures/_suggest_expires_when_termine.html.haml Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com> Update app/views/administrateurs/procedures/_suggest_expires_when_termine.html.haml Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com> Update app/views/administrateurs/procedures/_suggest_expires_when_termine.html.haml Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com> Update spec/views/administrateurs/procedures/show.html.haml_spec.rb Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com> fix(review): typo, why ena?, who knows fix(env.example.optional): add missing DEFAULT_PROCEDURE_EXPIRES_WHEN_TERMINE_ENABLED	2022-05-05 13:07:11 +02:00
Paul Chavard	4523c0590c	fix(dossier): champs repetable in champs private	2022-05-04 15:57:25 +02:00
Martin	636f887698	fix(user.merge): when merging old_user having an instructeur with dossier_operation_logs containing the old_user.instructeur_id, should be able to merge to new instructeur ... feat(user.merge): when user have an instructeur having dossier_opertions_logs containing instructeur_id	2022-05-04 14:24:11 +02:00
simon lehericey	1ef8d99e6e	simplify a bit more	2022-05-04 13:16:12 +02:00
simon lehericey	37e01ea399	re introduce revision_types_de_champ	2022-05-04 13:16:12 +02:00
Paul Chavard	2d1370d123	refactor(champ): simplify repetition champ	2022-05-03 16:14:54 +02:00
Paul Chavard	b94bc8fd8a	refactor(dossier): use champ id as champ attributes key	2022-05-03 16:14:54 +02:00
simon lehericey	a2947751e2	add scope to query old admins	2022-05-03 12:14:02 +02:00
simon lehericey	ea361643be	types_de_champ -> types_de_champs_public	2022-05-03 11:05:24 +02:00
Paul Chavard	1e928a277d	chore(devise): drop unmaintained dependencie	2022-04-28 12:28:33 +02:00
Paul Chavard	68ca9efba0	feat(dossier): use persisted dossier for preview	2022-04-28 12:20:41 +02:00
Paul Chavard	27f9a820cc	feat(dossier): add preview flag	2022-04-28 11:52:38 +02:00
Martin	3c0e3f725d	feat(administrateur/procedures#publication): show dubious to administrateur ... Update app/views/administrateurs/procedures/publication.html.haml Co-authored-by: Paul Chavard <paul.chavard@beta.gouv.fr>	2022-04-27 15:13:22 +02:00
Martin	be090a1bec	feat(administrateur/procedure#create): allow admin to add a lien to the DPO, allow user to consult link to dpo. enhance spec on _procedure_footer.html ... Update spec/views/users/_procedure_footer.html.haml_spec.rb Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com>	2022-04-27 15:09:02 +02:00
Paul Chavard	91879b89ce	fix(commentaire): unified destroy commentaire	2022-04-26 14:54:58 +02:00
simon lehericey	fe6f211cc9	ignore instructeur_id in dol	2022-04-25 14:07:23 +02:00
Paul Chavard	23b60c87e9	fix(procedure): cloned procedure should not have auto_archive_on ... fix #7149	2022-04-22 10:48:31 +02:00
Paul Chavard	4624fa141f	fix(turbo): use a safer render method	2022-04-21 19:41:27 +02:00
simon lehericey	9fd5219751	fix sort in procedure presentation	2022-04-15 12:21:39 +02:00
Paul Chavard	22f23c58c7	fix(dossiers): fix columns order	2022-04-14 17:04:42 +02:00
simon lehericey	23707d6033	ignore file not found error when cloning procedure	2022-04-14 13:46:16 +02:00
Paul Chavard	c671f25d34	fix(dossier): do not show unwanted closed procedure banners	2022-04-14 12:22:37 +02:00
Paul Chavard	83a8d87e95	i18n(procedure_presentation): translate fields	2022-04-14 11:38:01 +02:00
Paul Chavard	433c01b1e6	Revert "Merge pull request #7137 from betagouv/faster_pdf" ... This reverts commit 9da44bd913, reversing changes made to ebac71796c.	2022-04-12 19:22:07 +02:00
Paul Chavard	caace89d98	refactor(export): use predefined helpers	2022-04-12 14:54:54 +02:00
Paul Chavard	d14e132305	feat(export): add zip format support	2022-04-12 14:54:54 +02:00
Paul Chavard	2832ea0286	refactor(export): return blob from to_* methods	2022-04-12 14:54:54 +02:00
Paul Chavard	a194616772	refactor(export): remove unnecessary to_sym	2022-04-12 14:54:54 +02:00
simon lehericey	53de567b59	revert fix(user.merge) : waiting for ignore column instructeur_id in ruby code	2022-04-12 14:02:20 +02:00
simon lehericey	ba688a477a	small refactor	2022-04-12 11:56:56 +02:00
Martin	e83f5fe475	fix(user.merge): when merging old_user having an instructeur with dossier_operation_logs containing the old_user.instructeur_id, should be able to merge to new instructeur ... feat(user.merge): when user have an instructeur having dossier_opertions_logs containing instructeur_id	2022-04-12 11:28:33 +02:00
Paul Chavard	90dd5bc9c5	fix(dossiers): dossier extend_conservation actually works	2022-04-08 13:40:28 +02:00
Paul Chavard	23e2429d0d	fix(export): make count argument optional	2022-04-06 17:08:38 +02:00
Paul Chavard	9904dabffe	feat(procedure_presentation): pass filters as serialized snapshot	2022-04-06 17:08:38 +02:00
Paul Chavard	e82dc9c8b5	feat(exports): add ability to create exports with filters	2022-04-06 17:08:38 +02:00
Paul Chavard	be1a2f916d	feat(exports): add statut and procedure_presentation to exports	2022-04-06 17:08:38 +02:00
Paul Chavard	ec3ed049ef	refactor(procedure_presentation): expose filtered_sorted_ids method	2022-04-05 15:50:53 +02:00
Martin	4890530428	fix(Dossier.processed_in_month): recast date to datetime in scope	2022-04-05 13:54:36 +02:00
Martin	9484c4cdf4	fix(Dossier.processed_in_month): using PG between operator with a date does not play nicely when it is compared to DateTime in postgres. meaning given a Date as 2022/03/31, when compared with a DateTime in postgres, the casting of 2022/03/31 to Datetime becomes 2022/03/31 00:00. So we skiped all dossiers from last date in month	2022-04-05 13:54:36 +02:00
Martin	c1884f231c	Revert "Merge pull request #7105 from betagouv/US/fix-dossier.processed_in_month" ... This reverts commit a0e144b9a7, reversing changes made to 49848bd150.	2022-04-05 13:39:37 +02:00
Martin	d6d9db9721	tech(Sorbet): prepare usage of sorbet to avoid defensive programming style [casting date to datetime]	2022-04-05 12:14:07 +02:00
Martin	ec78340c06	fix(Dossier.processed_in_month): recast date to datetime in scope	2022-04-05 12:14:07 +02:00
Martin	ab777a790c	fix(Dossier.processed_in_month): using PG between operator with a date does not play nicely when it is compared to DateTime in postgres. meaning given a Date as 2022/03/31, when compared with a DateTime in postgres, the casting of 2022/03/31 to Datetime becomes 2022/03/31 00:00. So we skiped all dossiers from last date in month	2022-04-05 12:14:07 +02:00
Paul Chavard	0daae815d8	refactor(dossier): use by_statut	2022-04-05 09:42:23 +02:00
Paul Chavard	6da54936b7	refactor(procedure_presentation): use internal reference to instructeur	2022-04-05 09:42:23 +02:00
Paul Chavard	706c648be8	refactor(procedure): remove unused code	2022-04-05 09:42:23 +02:00
simon lehericey	57f9e5bac3	always allow dossier pjs download (-9 queries)	2022-04-04 17:26:49 +02:00
Martin	ad4e5a8bc6	fix(instructeurs/procedures#index): counter not in sync	2022-04-04 16:28:25 +02:00
Kara Diaby	e06215281a	modify commentaire model	2022-03-31 15:48:17 +02:00
Martin	dbcf21a555	feat(archive): extract archive status management within job to simplify the main service as well as to isolate this part for a merge with exports csv/xslx [maybe?] ... Update app/dashboards/archive_dashboard.rb Co-authored-by: LeSim <mail@simon.lehericey.net>	2022-03-31 13:35:49 +02:00
Paul Chavard	6df18e1234	fix(dossier): only expire dossiers visible by user or administration	2022-03-31 12:17:24 +02:00
Paul Chavard	a171ebb772	fix(dossiers): exclude deleted dossiers from notifications	2022-03-31 12:17:24 +02:00
Martin	7ec1021e00	feat(Archive.prepare_broader_reach): activate by default the archive button in the export dropdown. add a call to action to contact our support to enable the feature. increase estimated file size limit up to 100.gigabytes	2022-03-30 16:21:07 +02:00
Pierre de La Morinerie	017625207e	db: add constraints to role tables	2022-03-29 14:52:38 +02:00
Kara Diaby	217793c5c8	modify model	2022-03-29 12:30:52 +02:00
Pierre de La Morinerie	9dcd92a678	db: add not-null constraints to AdministrateursInstructeur	2022-03-22 13:32:02 +01:00
Pierre de La Morinerie	fbe0410702	models: fix a typo in a ProcedurePresentation's comment	2022-03-22 07:58:44 +01:00
Pierre de La Morinerie	6849a73aec	models: ignore deprecated User columns	2022-03-22 07:58:44 +01:00
Pierre de La Morinerie	31bd05f835	models: inverse the direction of the User role associations	2022-03-22 07:58:44 +01:00
Pierre de La Morinerie	d4da6502ba	models: remove double-write callback on User	2022-03-22 07:58:44 +01:00
Kara Diaby	8bcdf59778	change commentaire model	2022-03-17 13:57:49 +01:00
Kara Diaby	eda5f75ec3	modify dossier model	2022-03-17 13:57:49 +01:00
Paul Chavard	c530399eac	feat(procedure): display revisions diffs	2022-03-17 10:26:38 +01:00
Martin	5739150f15	feat(service/archive_uploader): add an archive uploader class to upload files thru a custom script which handle file encryption of massive file (bigger than 4Go) ... Update doc/object-storange-and-data-encryption.md Co-authored-by: LeSim <mail@simon.lehericey.net> Update app/services/archive_uploader.rb Co-authored-by: LeSim <mail@simon.lehericey.net> Update doc/object-storange-and-data-encryption.md Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com> clean(doc): align document file name and document h1 clean(review): refactore based on various comments clean(review): refactore based on various comments	2022-03-16 14:56:21 +01:00
Pierre de La Morinerie	ae3e360139	models: double-write to the newly created foreign keys ... This code is only used to handle a live system creating new Administrateurs, Instructeurs or Experts before the migration to the new foreign keys.	2022-03-15 15:57:22 +01:00
Pierre de La Morinerie	48ea53b90d	db: add foreign keys to Administrateur, Instructeur and Expert	2022-03-15 15:15:51 +01:00
Pierre de La Morinerie	be834ba58d	models: reload old_user roles before destroying it ... Otherwise ActiveRecord believes that old_user still has roles (although they have been migrated to the new user), and attempts to delete them.	2022-03-15 15:13:45 +01:00
Pierre de La Morinerie	2cac7d96be	models: fix procedure_revision comments indentation	2022-03-15 15:13:45 +01:00
simon lehericey	44f2d93277	quick fix of sections in preview	2022-03-15 10:54:39 +01:00
Paul Chavard	77c2187747	fix(instructeur): avoid n+1 in instructeur_dossier#show and user_dossier#show	2022-03-15 09:57:54 +01:00
Paul Chavard	0695ea322a	refactor(instructeur): improuve dossiers list view	2022-03-11 14:06:34 +01:00
Paul Chavard	c60a8970f1	perf(dossier): memoize champ.sections on dossier	2022-03-11 00:15:53 +01:00
Paul Chavard	54b559364a	feat(dossier): replace discarded with visible_by_administration	2022-03-10 14:29:40 +01:00
Paul Chavard	59b0f3961d	refactor(dossier): improuve dossiers_count_summary	2022-03-10 14:29:40 +01:00
Pierre de La Morinerie	a645c5781d	models: delete AdministrateursProcedure when destroying Procedure	2022-03-08 09:20:34 +01:00
Pierre de La Morinerie	087e438eb6	models: delete AdministrateursInstructeur when destroying Instructeur ... By default, `has_and_belongs_to_many` properly deletes the record in the join table. However, as the association is declared manually with a `has_many / through`, it doesn't delete the joined record automatically. As we also lack a foreign-key contraint on the join table, that means a dangling record remains in the join table. To fix this, let's declare it a proper `has_and_belongs_to_many` association, which will let the join record be deleted automatically on destroy.	2022-03-02 11:26:53 +01:00
Pierre de La Morinerie	e32c9a9f94	models: don't attempt to format invalid phone numbers ... This is a defensive-programming measure, because formatting an invalid phone number may truncate some leading numbers.	2022-03-02 09:57:03 +00:00
Pierre de La Morinerie	f35d18cd5c	models: stop truncating DROM phone numbers ... Fix #6996	2022-03-02 09:57:03 +00:00
Pierre de La Morinerie	5150e33212	models: ensure DROM phone numbers are valid ... They were accepted before, because they were 'possible' – but now they are explicitely considered as valid.	2022-03-02 09:57:03 +00:00
Pierre de La Morinerie	71e1b6c973	models: delete AdministrateursProcedure when destroying Administrateur ... By default, `has_and_belongs_to_many` properly deletes the record in the join table. However, as the association is declared manually with a `has_many / through`, it doesn't delete the joined record automatically. As we also lack a foreign-key contraint on the join table, that means a dangling record remains in the join table. To fix this, let's declare it a proper `has_and_belongs_to_many` association, which will let the join record be deleted automatically on destroy.	2022-03-01 16:58:04 +01:00
Martin	b808b4db00	fix(relation): avoid double association between procedure/procedure_revision/dossier_submitted_message	2022-02-25 14:01:18 +01:00
Martin	85a588541b	feat(dossier_submitted_message): add a new system to customize the standby page (/merci) after an user created his folder. this is a basic feature that will come with more options asap ... wip(dossier_created_hook): add tile to administrateurs/procedure#show in order to crud dossier_created_hook refactor(css.utilities): remove merge helpers.scss within utils.scss (same purpose). use scss each for spacer modifiers refactor(dossiers/_merci.html): extract partial _merci so we can re-use it in preview of dossier_created_hook. feat(wip): current progress	2022-02-25 14:01:18 +01:00
Paul Chavard	2d396fcfb7	feat(dossier): rebase dossiers en construction and en instruction	2022-02-18 17:08:38 +01:00
Paul Chavard	08030bcdb7	fix(attestation_template): handle attestation changes on procedures without revisions	2022-02-11 11:12:10 +01:00
Paul Chavard	76b1b85fa7	fix(attestation_template): add revision diff support	2022-02-11 08:45:32 +01:00
Paul Chavard	e269077c40	refactor(attestation_template): cleanup relationships	2022-02-11 08:45:32 +01:00
Paul Chavard	88e80e9e32	Merge pull request #6901 from adullact/feature/6859-jwt-token-expiration ... [API Entreprise] Ajout du support des jetons JWT sans clé d'expiration	2022-02-10 11:48:39 +01:00
Kara Diaby	a6b2873bfc	modify instructeur model	2022-02-09 14:43:36 +01:00
Kara Diaby	0ce61f451e	modify dossier model	2022-02-09 14:43:36 +01:00
Paul Chavard	12151acb99	Revert "Revert "feat(attestation): revise attestations"" ... This reverts commit 4e7733e571.	2022-02-08 16:22:59 +01:00
François Vantomme	eba9a87123	refactor(API Entreprise): raise an error on blank token	2022-02-07 15:18:16 +01:00
Pierre de La Morinerie	e6cf07b810	stats: move date formatting out of the Stat model ... Before this commit, the monthly dossiers count was serialized into the Stat record using human-formatted dates, as: ```ruby s.dossiers_in_the_last_4_months = { "octobre 2021"=>409592, "novembre 2021"=>497823, "décembre 2021"=>38170, "janvier 2022"=>0 } ``` Turns out the ordering of keys in a serialized hash is not guaranteed. After a round-trip to the database, the keys will be wrongly sorted. Instead we want to save raw Date objects, which will preserve the ordering. The date formatting can be applied at display-time by the controller. Fix #6848	2022-02-02 14:13:53 +01:00
Pierre de La Morinerie	ca58e60dc0	validators: rename revisions namespace to types_de_champ	2022-02-01 12:37:16 +01:00
Pierre de La Morinerie	d680602c84	models: validate private types_de_champ	2022-02-01 12:37:16 +01:00
Pierre de La Morinerie	e8e37cce15	models: refactor the types_de_champ validators ... Context: we want to validate public and private types_de_champ separately. Before we validated the whole revision (and then validators themselves enumerated all champs, public and private). Now we validate the actual public types_de_champ, which will let us validate separately the private types_de_champ.	2022-02-01 12:37:16 +01:00
Kara Diaby	0f968f4c4e	modify models	2022-01-27 17:01:27 +01:00
Paul Chavard	4e7733e571	Revert "feat(attestation): revise attestations" ... This reverts commit e413872530.	2022-01-25 18:26:34 +01:00
Kara Diaby	2eb35065f8	fix dossier deletion mailers	2022-01-25 11:46:05 +01:00
Kara Diaby	0e3532a0b2	Fixe la liste 'tous' des dossiers instructeurs lorsqu'un dossier est en constructino et caché par l'usager	2022-01-24 16:47:47 +01:00
Paul Chavard	e413872530	feat(attestation): revise attestations	2022-01-19 18:00:37 +01:00
Paul Chavard	c1cb89bb44	fix(revision): changed? conflicts with rails method	2022-01-19 18:00:37 +01:00
Paul Chavard	403e71b41f	feat(procedure): only purge procedures without dossiers	2022-01-18 11:22:04 +01:00
Paul Chavard	7937e58caa	fix(archives): only export dossiers in archive groupe_instructeurs ... fix #6793	2022-01-18 11:16:20 +01:00
Paul Chavard	7e0d471a08	improuve discarded_expired scopes	2022-01-12 15:49:38 +01:00
Kara Diaby	e2caf5718f	modify instructeur model	2022-01-12 15:49:38 +01:00
Kara Diaby	894b065615	modify dossier model	2022-01-12 15:49:37 +01:00
Paul Chavard	fc058f721d	a11y(champs): expose ids for UI on champ	2022-01-05 12:33:40 +01:00
Kara Diaby	1ca553e088	rename hidden_by_instructeur by hidden_by_administration	2022-01-03 11:51:25 +01:00
Paul Chavard	ad4be3c482	refactor(dossier): handle discard by admin and super admin	2022-01-03 11:51:25 +01:00
Kara Diaby	b408811c5a	l'expert ne voit pas les dossiers supprimés par l'instructeur	2022-01-03 11:51:25 +01:00
Kara Diaby	051d7b2028	change dossier method	2021-12-29 17:37:58 +01:00
Kara Diaby	37e991ccb8	User : delete the folder if the instructeur has hide it	2021-12-29 17:37:58 +01:00
Kara Diaby	22ac853815	add hidden_by_instructeur scope	2021-12-29 17:37:58 +01:00
Kara Diaby	cd95b730e0	add hidden_by_instructeur_at on dossiers	2021-12-29 17:37:57 +01:00
Martin	d0ab1711ff	fix(profil_controller#update_email): ensure we are not merging same account ... fix(profil_controller#update_email): changing email from current_user.email to current_user.email destroy current user. whoops ☠️' Update config/locales/en.yml Co-authored-by: Pierre de La Morinerie <pierre.de_la_morinerie@beta.gouv.fr> Update config/locales/fr.yml Co-authored-by: Pierre de La Morinerie <pierre.de_la_morinerie@beta.gouv.fr> Update spec/controllers/users/profil_controller_spec.rb Update config/locales/fr.yml Co-authored-by: Pierre de La Morinerie <pierre.de_la_morinerie@beta.gouv.fr> Update spec/controllers/users/profil_controller_spec.rb fix(spec): broken due to typo	2021-12-29 13:36:47 +01:00
Christophe Robillard	6e36fee7b3	superadmin can display list of procedures without zone	2021-12-23 19:18:46 +01:00
Christophe Robillard	c7b5e57d2a	superadmin can get procedures from zone	2021-12-23 19:07:42 +01:00
Paul Chavard	4e779f445d	fix(instructeur): copy notifications settings from previous groupe instructeur ... fix #6763	2021-12-23 13:55:25 +01:00
François Vantomme	14e0c68266	feat(api particulier): add MESRI field	2021-12-16 16:45:18 +01:00
maatinito	0a31c8bc79	refactor date_trunc queries using groupdate gem	2021-12-14 08:50:11 +01:00
maatinito	573b3d39e2	Fix date_trunc sql queries for timezoned forks	2021-12-14 08:50:09 +01:00
Paul Chavard	c7b1dc7f87	fix(bulk_messages): destroy bulk messages with procedures	2021-12-09 16:16:40 +01:00
Paul Chavard	efd8ddb99e	fix(graphql): do not crash if attestation is nil	2021-12-08 13:12:42 +01:00
François Vantomme	6ab8ac0662	feat (api particulier): add Pole emploi field	2021-12-08 10:36:25 +01:00
Paul Chavard	5615baa985	Revert "Merge pull request #6724 from tchak/fix-approximative_expiration_date" ... This reverts commit c95a67d970, reversing changes made to 032989a400.	2021-12-07 13:32:39 +01:00
Paul Chavard	436569b08c	Revert "Merge pull request #6727 from tchak/fix-approximative_expiration_date-again" ... This reverts commit 951f974478, reversing changes made to c95a67d970.	2021-12-07 13:32:27 +01:00
Paul Chavard	48ee830586	fix(dossier): fix approximative_expiration_date again	2021-12-07 13:02:53 +01:00
Paul Chavard	60d4bcc4f7	fix(dossier): fix approximative_expiration_date	2021-12-07 12:47:27 +01:00
François Vantomme	2110ef072c	feat(api particulier): add DGFiP field	2021-12-07 11:03:05 +01:00
Paul Chavard	5e0f8a5816	task(type_de_champ): migrate type_de_champ parent_id	2021-12-06 21:45:54 +01:00
Paul Chavard	09c37435ad	feat(procedure_revision_types_de_champ): add parent_id	2021-12-06 21:45:54 +01:00
Paul Chavard	0036933425	feat(graphql): add commune and departement information to API	2021-12-06 21:01:28 +01:00
Paul Chavard	fcbe364ac8	feat(commune): display departement information on commune champ	2021-12-06 21:01:28 +01:00
Paul Chavard	2ba05bfb4f	fix(dossier): use depose_at instead of en_construction_at	2021-12-06 15:49:17 +01:00
Martin	081d5094a9	feat(instructeurs/procedure/dossiers#extend_conservation): add extends duree conservation in action button list, also rewire this action for user [extend by procedure.duree_conservation_dans_ds by default] but force 1.month for instructeur. add new icon for standby based on https://en.wikipedia.org/wiki/Power_symbol	2021-12-06 07:20:01 +01:00
Martin	d8a8d1fdab	feat(instructeur/dossier/header/_expiration_banner): split trads and add dedicated expiration banner for instructeur. also enhance wording to include duree conservation + extension_conservation ... feat(expiration_banner): enhance wording of expiration feat(dossiers/expiration_banner): enhance wording regarding expiration to include duree_conservation_dossiers_dans_ds + extension_conservation, also add spec on expiration_banner for instructeur	2021-12-06 07:05:17 +01:00
Martin	1bb868714c	fix(spec/lint/review): lint and fix spec of previous commits, also fix based on tchak feedback	2021-12-06 07:05:17 +01:00
Martin	d87f8b57cc	feat(instructeurs/procedures#show): add dossier experiant in procedure#show	2021-12-06 07:05:17 +01:00
Martin	2dfbc70d41	feat(instructeur#dossiers_count_summary): add counter for expirants. ignore brouillon	2021-12-06 07:05:17 +01:00
Martin	ce87878ff0	refactor(traitement.process_expired): move process expired to procedure	2021-12-03 16:32:36 +01:00
Christophe Robillard	561f6fb274	add belongs_to zone for procedure	2021-12-02 19:23:05 +01:00
Christophe Robillard	219eaf0d5e	add zone model	2021-12-02 19:16:11 +01:00
Pierre de La Morinerie	b7d17b0989	models: validate that no drop-downs are empty on publishing ... Disallow publishing a procedure containing drop-downs with no selectable values.	2021-12-02 09:00:37 +01:00
Pierre de La Morinerie	e219ec33d8	validators: rename no_empty_repetitions to no_empty_repetition	2021-12-02 09:00:37 +01:00
Martin	725521c3a1	fix(expiration_banner): only show expirations info when flip is enabled ... fix(lint): lint haml fix(spec): enable flipper and allow procedure to receive flipper check when checking banner presence fix(doc): add missing documentation on readme regarding system testing with a visual feedback fix(typo): add missing accent clean(PR): feedback from Tchak, better to wrap feature check for expirability by procedure within dossier.expirable? helper	2021-11-30 16:05:32 +01:00
Pierre de La Morinerie	52b0fbf9b7	models: validate repetitions on publishing	2021-11-30 13:34:41 +01:00
Pierre de La Morinerie	48133c2595	models: don't save the procedure before the state transition ... Otherwise a validation error occurs here instead of on save.	2021-11-30 13:34:41 +01:00
simon lehericey	5a0fb6237f	😭 AASM does not support keyword arguments ... https://github.com/aasm/aasm/issues/672	2021-11-30 09:42:45 +01:00
Pierre de La Morinerie	184a401182	app: rename new_administrateur to administrateurs	2021-11-30 08:49:38 +01:00
Martin	cf82c030e8	hotfix(scoping): try to avoid requesting archived: false when using termine scope, use state_termine instead	2021-11-26 15:09:53 +01:00
Martin	970e43efb8	feat(stats#index): update Stat model to also query DossierDeleted in stats computation ... tech(question): discard_and_keep_track! ; are we really keeping track with default_scope { kept } ? feat(stats): add DeletedDossier in Stat computations Revert "tech(question): discard_and_keep_track! ; are we really keeping track with default_scope { kept } ?" This reverts commit d1155b7eeaaf1a9f80189e59667e109541fcb089. feat(stats): support deleted_dossiers for last_four_months_hash and cumulative_hash. extract sanitize query & merge hashes in methdos clean(rubocop): lint with rubocop Update db/migrate/20211126080118_add_index_to_deleted_at_to_deleted_dossiers.rb Co-authored-by: LeSim <mail@simon.lehericey.net> fix(rubocop): avoid uneeded allocation fix(migration): add concurrent index with expected synthax fix(brakeman): add ignore message since group date_trunc evaluation is used by only ourself	2021-11-26 13:29:40 +01:00
kara Diaby	eaac293da3	add a new tab traités on user dossiers	2021-11-26 09:45:13 +01:00
Paul Chavard	d847775c68	feat(traitements): add depose_at to dossiers	2021-11-25 12:57:55 +03:00
Paul Chavard	1f1dd9fce5	fix(traitements): add missing traitements to dossiers when reverting a decision	2021-11-25 12:57:55 +03:00
Pierre de La Morinerie	e5f5440663	models: explicitely save procedure's new revision ... Deep-cloned objects have all their relationships stale. Thus, for a newly deep-cloned revision, `revision.types_de_champs` returns `[]`, even when it actually has associated types de champ. This causes consecutive champs creations and re-ordering to fail in subtle ways, like: ``` procedure.draft_revision.add_type_de_champ(…) procedure.publish_revision! procedure.draft_revision.add_type_de_champ(…) procedure.draft_revision.move_type_de_champ(…) # this will fail ``` As `publish_revision!` created a new stale revision, moving the type de champ fails because not all existing champs are found until the object is refreshed. We don't hit this path in production, because usually only a single operation is made in a request. To fix this, save the new revision before associating it as the draft procedure. (Another option would be to `reload` the revision after creation, but this seems better contained and matches the name of the method.)	2021-11-25 08:49:17 +01:00
mfo	e7d9d047fe	Merge branch 'main' into 6649-etq-usager-instructeur-rendre-la-suppression-plus-visible	2021-11-24 14:07:32 +01:00
Pierre de La Morinerie	60c2718f29	models: remove custom code for file size validation message ... With active_storage_validations 0.9.6, we can use the %{max_size} variable directly in the error message.	2021-11-24 10:06:45 +01:00
Pierre de La Morinerie	2227dcc1e7	app: remove leftovers of procedure path autocomplete ... We used to pre-validate the procedure, to display in advance if the path could be used. Now that the path autocomplete is long gone, we can remove this kludgy code.	2021-11-23 14:30:21 +01:00
simon lehericey	5234a1854c	manage AgentConnect callback	2021-11-23 14:17:59 +01:00
simon lehericey	1926a630f9	add agent_connect_id to instructeur	2021-11-23 14:17:59 +01:00
simon lehericey	898df449d4	redirect to AgentConnect	2021-11-23 14:17:59 +01:00
Martin	b6adf5fc72	feat(dossiers/show): enhance header with expirations message/banner. also ensure consistent design between dossier states ... fix(spec): broken due to last refactoring spec(dossier.extend_conservation): add system spec lint(ruby): still not yet ready for auto lint in IDE...	2021-11-23 05:50:25 +01:00
Martin	a9978fb70b	clean(code): move mfo comment to its rightful place	2021-11-19 14:34:20 +01:00
Martin	608a85148f	feat(Dossier.close_to_expiration): add method to find any kind of dossier close to expiration [reuse previous scopes], add missing spec to termine_close_to_expiration, complement spec for each kind of expiration scope with general close_to_expiration spec	2021-11-19 14:28:54 +01:00
Martin	d8257284ef	tech(refactor): extract states close to expiration within their scope.	2021-11-19 14:07:47 +01:00
Martin	1d721f14a0	fix(spec): get back to stable state	2021-11-19 12:36:03 +01:00
Martin	646459a1da	fix(spec): at least let us start from a green suite	2021-11-18 18:15:57 +01:00
Paul Chavard	df474b60cf	WIP	2021-11-18 18:58:17 +03:00
Paul Chavard	ae09b37e72	fix(champs): save departement info on champ commune	2021-11-17 14:52:47 +03:00
mfo	82b23b92c0	Merge branch 'main' into 6624/etq-instructeur-je-souhaite-supprimer-des-messages-envoyes-par-erreur	2021-11-17 05:41:56 +01:00
Paul Chavard	e74d599042	feat(procedure): remove duree_conservation_dossiers_hors_ds	2021-11-16 19:55:56 +03:00
Paul Chavard	04e67ea20a	fix(dossier): add instructeur email to traitements when available	2021-11-16 19:00:20 +03:00
mfo	1d174df2ec	Merge branch 'main' into 6624/etq-instructeur-je-souhaite-supprimer-des-messages-envoyes-par-erreur	2021-11-16 16:37:15 +01:00
Martin	f0950b592b	clean(CommentaireService): extract soft delete within controller. returning an instance with an error[:base] is not persisted with validation : avoid poluting stuff	2021-11-16 16:13:11 +01:00
Martin	8bbd77f89f	refactor(mail.delay): use simplier implementation using after_action to prevent email delivery with delay	2021-11-16 15:12:05 +01:00
Martin	0aecc301c9	refactor(Commentarie.soft_delete): use discard	2021-11-16 14:28:38 +01:00
simon lehericey	e3c1e19424	include hidden dossier in merge	2021-11-15 23:14:41 +01:00
Martin	ddabed0c7e	fix(refactor): continue to revert to past implementation. now use a job instead of calling deliver_later(wait: 5.minutes) [was not a satisfying implementation]	2021-11-15 15:45:48 +01:00
Martin	5534c3fbd6	fix(refactor): forgot to cleanup former implementation	2021-11-15 15:43:51 +01:00
Martin	5b6bb5171c	tech(lint): rubocopify	2021-11-15 15:42:20 +01:00
Martin	c68fa2d7f3	feat(Commentaire.notify_user): wait 5 minutes before sending email to user when instructor write a commentaire. leaving some space for instructor to destroy his message	2021-11-15 15:38:57 +01:00
Martin	46fc956de3	fix(refactor): forgot to pass var, classy	2021-11-15 15:01:56 +01:00
Martin	a74ca8ad39	fix(spec): scope out time as reference for time comparission, hope not a matter of precision	2021-11-15 14:55:35 +01:00
Martin	9a8ec1087c	feat(commentaire.soft_delete): wrap deletion behaviour in service	2021-11-15 12:43:53 +01:00
Martin	5b72bdec7e	fix(Commentaire.sent_by?): &.email compared to nil could sent by true when nil==nil, avoid this one	2021-11-15 12:01:56 +01:00
Martin	b03dc6ad5d	wip(dossiers/messages/_message): poc destroy button with expected ACL support	2021-11-15 11:30:41 +01:00
Paul Chavard	da47f491b3	fix(dossier): nullify close to expiration notice timestamps when changing state	2021-11-11 12:52:58 +01:00
Paul Chavard	faa235d205	fix(dossier): destroy operation logs when destroying an expired dossier	2021-11-11 09:37:09 +01:00
Paul Chavard	71939c650b	fix(export): remove wrong columns from repetition spreadsheets ... This fix prevent repetition children types de champ from being pulled from cloned procedures. stable_id is stable across revisions but also across cloned procedures.	2021-11-10 20:45:32 +01:00
simon lehericey	17d131b3cc	add has_may requested_merge_from	2021-11-04 16:10:09 +01:00
simon lehericey	b160086cc5	update update_email to allow merge	2021-11-04 16:10:09 +01:00
simon lehericey	6625c6bac3	add requested_merge_into column in user table	2021-11-04 16:10:09 +01:00
Paul Chavard	122cdacbc2	fix(avis): destroy avis for discarded en_construction dossiers	2021-11-04 10:12:44 +01:00
Paul Chavard	f6b8689a97	fix(revisions): fix repetitions export with revisions	2021-11-03 18:20:48 +01:00
Paul Chavard	0e2f09dd6f	fix(dossiers): wrap dossier discard in a transaction ... By doing this we ensure that deleted_dossier are not created when dossier is not discarded	2021-11-02 18:17:35 +01:00
Paul Chavard	da49a6447f	refactor(repetition): optimize and add a transaction around repetition add row	2021-10-28 14:54:33 +02:00
Paul Chavard	c4b93f8d4a	fix(groupe_instructeur): unfollow dossiers when removed from groupe instructeur	2021-10-28 14:45:52 +02:00
simon lehericey	8fe1e2bf71	wrap merge in transaction	2021-10-28 14:39:13 +02:00
simon lehericey	7935e42109	Add merge log	2021-10-28 14:39:13 +02:00
simon lehericey	3328c9a132	merge move invite as well	2021-10-28 14:39:13 +02:00
simon lehericey	f2ccb39912	merge destroys the old role and account	2021-10-28 14:39:13 +02:00
simon lehericey	1401d163ba	add dependent_destroy to user instructeur / admin / expert roles	2021-10-28 14:39:13 +02:00
simon lehericey	c725999582	move merge method to user	2021-10-28 14:39:13 +02:00
Paul Chavard	1393b7b07b	fix(rebase): fix repetition champ rebase	2021-10-28 13:27:53 +02:00
Paul Chavard	7ebc439630	refactor(drop_down_list_champ): other option	2021-10-27 12:01:15 +02:00
Paul Chavard	8154daf847	refactor(drop_down_list_champ): other option	2021-10-27 12:00:39 +02:00
kara Diaby	f1f2b76a3d	revisions	2021-10-27 12:00:39 +02:00
kara Diaby	dc35d9521f	add other option to liste deroulante champ	2021-10-26 16:11:15 +02:00
Paul Chavard	6e8e0c7b6b	feat(type_de_champ): reflect changes of secondary labels and descriptions	2021-10-26 12:18:01 +02:00
Paul Chavard	d308448f02	feat(type_de_champ): add secondary label and description do linked drop downs	2021-10-26 12:18:01 +02:00
Paul Chavard	579dce8eb6	refactor(user): wrap user destruction in a transaction	2021-10-26 11:16:29 +02:00
Paul Chavard	d5d3995dad	fix(dossier): fix dossier.avis cascade	2021-10-26 11:16:29 +02:00
Paul Chavard	4aa573a75d	fix(transfer): remove discarded dossiers from transfers	2021-10-26 10:41:01 +02:00
Paul Chavard	1561ea82f6	fix(transfer): manually nullify staled transfers references	2021-10-21 13:54:26 +02:00
Paul Chavard	2a3a9dd822	feat(revisions): rebase dossiers brouillons	2021-10-20 17:26:09 +02:00
Paul Chavard	09a09d3fcf	feat(revisions): add rebased_at to champs	2021-10-20 17:26:09 +02:00
Paul Chavard	67e98f79c9	feat(revisions): add stable_id to changes	2021-10-20 17:25:34 +02:00
Paul Chavard	1ca8192864	perf(export): load dossiers.champs in batches	2021-10-20 16:52:38 +02:00
simon lehericey	866df74706	merge admin	2021-10-19 16:12:42 +02:00
simon lehericey	19f81b594b	merge with an existing account by using the password	2021-10-14 14:47:50 +02:00
simon lehericey	f6879eba60	associate_user take a target email	2021-10-14 14:47:50 +02:00
simon lehericey	09f828a6a2	create_merge_token!	2021-10-14 14:47:50 +02:00
simon lehericey	34862f41e0	Add fci valid_for_merge	2021-10-14 14:47:50 +02:00
simon lehericey	2e118a8f5b	allow unattached fci	2021-10-14 14:47:50 +02:00
simon lehericey	6e6635560f	Add merge token to FCI	2021-10-14 14:47:50 +02:00
simon lehericey	6826bf03b0	Sign in with a user linked by france connect sub (openid) ... instead of looking linked user by email because : - follows FC recommendation to fetch ds account by openid - the email is not a valid key as many user can share the same FCI email. The following scenario is now working A user A (email: 1@mail.com) uses FC to connect to DS => It is connected as 1@mail.com Another user B (email: generic@mail.com) uses FC to connect => It is connected as generic@mail.com The first user A change its FC email to generic@mail.com and connect to DS => It is still connected as 1@mail.com	2021-10-14 14:47:50 +02:00
simon lehericey	87de9e38c6	allow draft to be saved with invalid cnaf champ	2021-10-12 14:27:20 +02:00
simon lehericey	7aee944daa	show cnaf tdc when procedure is compatible	2021-10-12 14:27:20 +02:00
simon lehericey	57a7f82a8f	add cnaf ui	2021-10-12 14:27:20 +02:00
simon lehericey	40d0cfcdc4	add champ validation	2021-10-12 14:27:20 +02:00
simon lehericey	c76d1043fa	add cnaf champ	2021-10-12 14:27:20 +02:00
simon lehericey	354735ace4	add champ value_json jsonb column	2021-10-12 14:27:20 +02:00
simon lehericey	d68129b34d	add cnaf type de champ	2021-10-12 14:26:40 +02:00
simon lehericey	7c65571fca	add case when the old_expert or old_instructeur is nil	2021-10-12 11:04:06 +02:00
simon lehericey	d7e621d167	beef up the merge methods	2021-10-07 15:51:31 +02:00
simon lehericey	a480b31eb5	merge expert	2021-10-07 15:51:31 +02:00
simon lehericey	136f29524e	merge instructeur	2021-10-07 15:51:31 +02:00
Paul Chavard	4a947f9135	feat(manager): add become administrateur button in manager (with 24h expiration)	2021-10-07 11:32:12 +02:00
Paul Chavard	9d5c5447c2	fix(dossier): do not attempt to destroy transfers when a dossier is destroyed ... we had a dependent option on both sides of a relationship which created race conditions	2021-10-06 17:51:09 +02:00
Paul Chavard	d3c1941fbe	fix(dossier): never write dossier log on dossiers brouillons	2021-10-05 17:56:51 +02:00
simon lehericey	1000417bc9	update notifications_for_dossier used in dossier show	2021-10-05 12:05:43 +02:00
simon lehericey	65911b7680	update with_notifications dossiers scope (used in procedure index and show)	2021-10-05 12:05:43 +02:00
simon lehericey	3a878dfc04	add identity_updated_at column to dossier	2021-10-05 12:05:43 +02:00
Pierre de La Morinerie	f01e4ed6ef	models: document upstream PR about file size validation	2021-09-30 15:45:30 +02:00
simon lehericey	6eb10ecde5	display tdc alphabetically 🎉	2021-09-27 15:45:37 +02:00
simon lehericey	f55db98e97	rework type de champ type	2021-09-27 15:45:37 +02:00
Paul Chavard	357c684688	feat(routage): self managing instructeurs	2021-09-27 15:06:17 +02:00
Paul Chavard	d4e8158887	feat(routing): add instructeurs_self_management_enabled to procedures	2021-09-27 15:06:17 +02:00
Ismael MOUSSA S	36dc9c2ca2	Add File Validation concern after refactoring	2021-09-21 12:11:20 -05:00
Ismael MOUSSA S	7c7c9c9ea4	Fix file size validation message	2021-09-21 12:11:20 -05:00
Ismael MOUSSA S	bdbb4deb87	ADD FILE_MAX_SIZE constant to set allow file size limit	2021-09-21 12:04:56 -05:00
Paul Chavard	0ff62c5a5e	feat(routage): add routing_enabled to procedures	2021-09-18 11:22:35 +02:00
Paul Chavard	8b4bef2816	refactor(routage): simplify goupe_instructeur assign code	2021-09-18 11:21:26 +02:00
simon lehericey	b000590d81	add api particulier sources to procedure	2021-09-17 13:50:23 +02:00
simon lehericey	6c6205e188	a cloned procedure to a different admin does not keep api_particulier token and scopes	2021-09-16 09:30:11 +02:00
simon lehericey	2d2ae3a878	add api particulier scopes to procedure	2021-09-16 09:30:11 +02:00
Pierre de La Morinerie	745e19bb8e	localize	2021-09-16 09:07:47 +02:00
Pierre de La Morinerie	e97b7164dd	models: extract password complexity to a concern	2021-09-09 09:40:39 -05:00
Paul Chavard	d6cbdf2a48	feat(dossier): add dossier transfer models	2021-09-08 14:39:46 +02:00
Paul Chavard	44eb0ada4f	fix(i18n): add Kosovo to countries list ... Kosovo is not part of ISO 3166 as of time of writing. https://en.wikipedia.org/wiki/ISO_3166-2:RS#cite_ref-1	2021-09-08 12:11:25 +02:00
Paul Chavard	a7ec43a21e	fix(i18n): fix email previews	2021-09-08 09:21:19 +02:00
Pierre de La Morinerie	905fca0bd3	models: ensure Champs::Pays#to_s is always a string ... Before this, the result of `Champs::Pays#to_s` could be `nil`, which would break various things (like the PDF rendering of these champs).	2021-09-07 10:47:18 -05:00
Paul Chavard	74e277d0a2	feat(graphql): add an option to dossier state change mutations to disable notifications	2021-09-07 14:21:48 +02:00
Paul Chavard	96cbbc0192	fix(virus scan): prevent virus scan on archives and signatures uploads	2021-09-07 14:21:48 +02:00
simon lehericey	367f508e2e	linked_drop_down_list: empty primary => empty secondary	2021-09-07 10:09:18 +02:00
Paul Chavard	ff7fa4d895	feat(i18n): expose locale on dossier and deleted_dossier	2021-09-07 09:51:23 +02:00
Paul Chavard	f1ff6da81b	feat(i18n): add locale to user	2021-09-07 09:47:01 +02:00
Paul Chavard	a3cc072bbd	feat(i18n): translate countries selector	2021-08-31 13:15:26 +02:00
Paul Chavard	8e1bfb469f	fix(dossier): send expiration notifications 2 weeks prior to supression instead of a month	2021-08-26 11:28:57 +02:00
Christophe Robillard	e06f11f33f	add code insee libelle for commune export	2021-08-19 08:04:47 +02:00
Christophe Robillard	4a6c22d6a6	export code insee for commune champ	2021-08-19 08:04:47 +02:00
Christophe Robillard	daa306859c	champ export can be an array of values	2021-08-19 08:04:47 +02:00
Paul Chavard	ffa8c0c80a	feat(dossiers): enable dossiers termine expiration behind feature flag ... feature flag "procedure_process_expired_dossiers_termine" controls if a procedure has expiration enabled on dossiers termine re #3796	2021-08-18 16:11:35 +01:00
Christophe Robillard	93ba0cc038	stats: rend plus explicite le graphe taux d'acceptation	2021-08-11 10:50:26 +02:00
Christophe Robillard	2ee505e9a9	stats: i18n pour legende repartition par semaine	2021-08-10 15:22:36 +02:00
kara Diaby	0300df9a35	add procedure to bulk messages	2021-08-04 11:35:06 +02:00
simon lehericey	b29bae4707	a procedure has an encrypted api_particulier_token ... Co-authored-by: François VANTOMME <akarzim@gmail.com>	2021-07-30 11:18:44 +02:00
simon lehericey	66c35fdffe	add encryptable_concern ... Co-authored-by: François VANTOMME <akarzim@gmail.com>	2021-07-30 11:18:44 +02:00
kara Diaby	ab0782530c	create Bulk Message model and migration	2021-07-27 19:38:22 +02:00
kara Diaby	c92b249340	fixup! modify models	2021-07-27 19:38:21 +02:00
Paul Chavard	64cfb4d64e	Fix sort with revisions	2021-07-23 10:57:04 +02:00
Pierre de La Morinerie	0fd23ebd43	db: fix schema.rb leftovers	2021-07-22 17:55:47 +02:00
Paul Chavard	388fb39eb5	Fix false positive blank champ warnings	2021-07-22 10:45:25 +02:00
Paul Chavard	ac0f50b488	Improuve champ blank check	2021-07-22 10:45:25 +02:00
Pierre de La Morinerie	32ab2f0a80	instructeur: limit the maximum size of a filter value ... This prevents the URL from exceeding the max size, and causing '414: Request-URI too large' errors.	2021-07-20 14:49:48 +02:00
Pierre de La Morinerie	40b3ea8ad6	Revert "Instructeurs : limitation de la valeur d'un filtre à 100 caractères"	2021-07-13 18:19:46 +02:00
Pierre de La Morinerie	3c8a88a660	instructeur: limit the maximum size of a filter value ... This prevents the URL from exceeding the max size, and causing '414: Request-URI too large' errors.	2021-07-08 16:17:22 +02:00
Christophe Robillard	bc07a875eb	integrate a mininum weight for the average dossier weight ... before this commit, the average dossier weight took account only pieces justificatives. With this commit, we add a minimum weight for other files included in an archive like pdf_export, log operations, attachments added to traitements. This minimum weight is set arbitrary, from the observation of some random procedures in production	2021-07-06 15:58:45 +02:00
Paul Chavard	ce27999bc3	Refactor clone_attachments	2021-07-01 16:21:46 +02:00
Paul Chavard	280e54b59d	Enable test revisions	2021-07-01 15:59:07 +02:00
Christophe Robillard	66cc0dd08d	Revert "Revert "Expose dossier PDF export as IO"" ... This reverts commit 362093eff0.	2021-06-24 21:01:59 +02:00
krichtof	362093eff0	Revert "Expose dossier PDF export as IO"	2021-06-24 19:21:37 +02:00
Paul Chavard	b73d504f8d	Expose dossier PDF export as IO ... Co-authored-by: Christophe Robillard <christophe.robillard@beta.gouv.fr>	2021-06-24 17:49:24 +02:00
Paul Chavard	a4482233b8	[GraphQL] expose deleted dossiers	2021-06-24 11:51:37 +02:00
Paul Chavard	15ff046428	Improuve revision changes messages	2021-06-24 11:39:49 +02:00
Paul Chavard	241eff76a3	Enable publish new revision only if some changes are found	2021-06-24 11:39:49 +02:00
Paul Chavard	0ca5e1abe2	Preview should reflect revision changes	2021-06-24 11:39:49 +02:00
Paul Chavard	8b2c2c6466	Handle carte layers changes	2021-06-24 11:39:49 +02:00
Paul Chavard	35eccb5630	Show separate blocks for types de champ and annotation changes	2021-06-23 09:40:07 +02:00
Paul Chavard	19195008e8	Expose removed types_de_champ in exports	2021-06-23 09:40:07 +02:00
simon lehericey	eadae7af6b	show all available tdc for procedure presentation	2021-06-23 09:40:07 +02:00
Paul Chavard	0d25f52309	Add changed? and compare on ProcedureRevision	2021-06-23 09:40:07 +02:00
Paul Chavard	15e9013264	Set published_at on revision when publishing a procedure	2021-06-23 09:40:07 +02:00
Paul Chavard	f238710044	Add last_month export	2021-06-23 09:23:10 +02:00
Christophe Robillard	7851d6b1cc	archives: count archived dossiers	2021-06-18 08:59:13 +02:00
krichtof	4bda6600b1	explain what percentile constant means ... Co-authored-by: Pierre de La Morinerie <pierre.de_la_morinerie@beta.gouv.fr>	2021-06-17 16:31:53 +02:00
Christophe Robillard	896190b91e	return nil when no traitement time	2021-06-17 16:31:53 +02:00
Christophe Robillard	887c5cb4a9	correct rubocop offenses	2021-06-17 16:31:53 +02:00
Christophe Robillard	a5ae5af56a	extract NB_DAYS_RECENT_DOSSIERS and PERCENTILE	2021-06-17 16:31:53 +02:00
Christophe Robillard	f2deba733d	use traitement_times to compute usual_traitement_time for recent ... dossiers	2021-06-17 16:31:53 +02:00
Christophe Robillard	21dd05cc56	less sql queries for usual_traitement_time_by_month	2021-06-17 16:31:53 +02:00
Christophe Robillard	a8840faadb	move stats methods to appropriate concern class	2021-06-17 16:31:53 +02:00
Christophe Robillard	45ffae9eb3	affiche evolution temps de traitement	2021-06-17 16:31:53 +02:00
Christophe Robillard	701b72494d	compute usual traitement time for specific month	2021-06-17 16:31:53 +02:00
Paul Chavard	a2c53ce7ea	format phone numbers	2021-06-15 09:14:55 +02:00
François Vantomme	c9b1095d1e	Refactor (Rubocop): replace map{ … }.compact by filter_map ... In Ruby 2.7, Enumerable#filter_map has been added. This cop identifies places where map { … }.compact can be replaced by filter_map. See: https://docs.rubocop.org/rubocop-performance/cops_performance.html#performancemapcompact	2021-06-11 15:38:09 +02:00
Christophe Robillard	169f254c79	infer champ type from class	2021-06-09 10:52:38 +02:00
Christophe Robillard	6f845508b4	order archive by desc month	2021-06-09 10:52:38 +02:00
Christophe Robillard	5e180268cd	remove one sql query	2021-06-09 10:52:38 +02:00
simon lehericey	f2ba83a704	cout_dossier_termines_by_month for groupe_instructeurs ... Co-authored-by: Christophe Robillard <christophe.robillard@beta.gouv.fr>	2021-06-09 10:52:38 +02:00
simon lehericey	9e43823f9a	add average_dossier_weight ... Co-authored-by: Christophe Robillard <christophe.robillard@beta.gouv.fr>	2021-06-09 10:52:38 +02:00
Christophe Robillard	7002811ba5	optim count nb_dossiers per month for archive ... `Traitement#count_dossiers_termines_by_month` removes n+1 queries Co-authored-by: LeSim <mail@simon.lehericey.net>	2021-06-09 10:52:38 +02:00
Christophe Robillard	9bb9462b3a	optimise les stats termines by week	2021-06-08 15:23:31 +02:00
Paul Chavard	1888f74b10	Prevent double processing of declarative dossiers	2021-06-04 17:55:40 +02:00
kara Diaby	3555c9696a	modify concern	2021-06-04 15:29:08 +02:00
Paul Chavard	f526e303e8	Apply suggestions from code review ... Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com>	2021-06-03 13:11:16 +02:00
Paul Chavard	3fb10fb4b8	Set published_at on revision when publishing a procedure	2021-06-03 13:11:16 +02:00
Paul Chavard	306e5d228d	Add published_at to procedure_revisions	2021-06-03 13:11:16 +02:00
Paul Chavard	05380b9520	Fix destoying discarded procedures	2021-05-27 18:48:56 +02:00
Paul Chavard	9b0dae4cc2	Fix apostrophes ‘ -> ’	2021-05-26 18:05:14 +02:00
Paul Chavard	4922bc88d6	Do not crash when properties is nil	2021-05-26 12:40:07 +02:00
Paul Chavard	dfc46a8736	Enable add descriptions to cadastres	2021-05-26 11:27:09 +02:00
Paul Chavard	179bb5a9fe	Apply suggestions from code review ... Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com>	2021-05-25 11:43:38 +02:00
Paul Chavard	acb277e650	Use stable_id when replacing tags	2021-05-25 11:43:38 +02:00
Paul Chavard	3b85ade440	Add compatibility cadsatre layer with old API GEO	2021-05-24 11:57:00 +02:00
Paul Chavard	e74dcb0056	Remove ign feature flag	2021-05-24 11:50:16 +02:00
simon lehericey	b620888597	show only dossier avis	2021-05-20 16:18:04 +02:00
kara Diaby	20933579b0	do not display confidential avis to other experts	2021-05-19 21:30:22 +02:00
Paul Chavard	5f419954b4	Fix dossier deleted user display	2021-05-13 10:43:55 +02:00
Paul Chavard	3f7a2bea9b	Dossier without user should be valid	2021-05-11 17:50:10 +02:00
Paul Chavard	8a74438dc1	Use conservation_extension instead of en_construction_conservation_extension	2021-05-11 17:33:53 +02:00
Paul Chavard	1e0d6ea28f	Rename en_construction_conservation_extension to conservation_extension	2021-05-11 14:08:51 +02:00
simon lehericey	c5f6c9ae1e	fix missing state translation	2021-05-10 11:17:34 +02:00
simon lehericey	8d0082419c	do not know how it worked before	2021-05-05 14:36:34 +02:00
simon lehericey	4dc314d24b	[fix #6084] add db constraints to france_connect_informations table	2021-05-05 14:28:20 +02:00
simon lehericey	50f679746f	do not extract twice the same dossier_id if the dossier is followed twice	2021-05-04 16:38:34 +02:00
Paul Chavard	bcbfcdc537	Revert "Merge pull request #6142 from tchak/enable_brouillon_extend_conservation" ... This reverts commit 48eb4d9778, reversing changes made to 5539d5cb8c. # Conflicts: # app/models/dossier.rb # db/schema.rb	2021-05-04 16:03:29 +02:00
Christophe Robillard	01f180022b	prend en compte uniquement les pj pour estimer la taille d'un dossier	2021-05-04 12:50:12 +02:00
Paul Chavard	f6508899de	Refactor NotificationMailer	2021-05-04 12:05:06 +02:00
Paul Chavard	a4fd629f4a	Enable user destruction	2021-05-04 12:05:06 +02:00
Paul Chavard	b2a867266a	Allow users to extend conservation on drafts	2021-04-29 19:50:30 +02:00
Christophe Robillard	f40d96fbd2	Revert "Revert "Export de tous les dossier d'une démarche"" ... This reverts commit d9a588b52e.	2021-04-29 17:29:47 +02:00
krichtof	d9a588b52e	Revert "Export de tous les dossier d'une démarche"	2021-04-29 16:07:18 +02:00
simon lehericey	db23a853a9	fetch all notification at once	2021-04-29 11:23:41 +02:00
simon lehericey	a4e813380a	one query for avis count	2021-04-29 11:23:41 +02:00
simon lehericey	8b73d8804c	fetch all exports at once by groupe_instructeurs_ids	2021-04-29 11:23:41 +02:00
Christophe Robillard	09870c918d	prevent race conditions when creating archives	2021-04-28 11:40:58 +02:00
Christophe Robillard	dfbe004122	rename content_type to time_span_type for archives	2021-04-28 11:40:58 +02:00
Christophe Robillard	8b2849408c	instructeurs can create and download archives	2021-04-28 11:40:58 +02:00
Christophe Robillard	07cc4fa97f	add service to create procedure archive	2021-04-28 11:40:58 +02:00
Christophe Robillard	c25f3c79d9	add archive model	2021-04-28 11:40:58 +02:00
Pierre de La Morinerie	0cb2162a65	db: fix out-to-date Procedure comments	2021-04-27 15:36:22 +02:00
Paul Chavard	2a068fb9b0	Remove user feedback buttons	2021-04-22 15:40:40 +01:00
Paul Chavard	c20ad5ca17	Remove the link between commentaire and user	2021-04-22 15:10:47 +01:00
simon lehericey	553e1d973c	remove old methods	2021-04-22 10:46:04 +02:00
kara Diaby	541a36abbf	Add boolean to procedures table	2021-04-19 10:23:45 +02:00
simon lehericey	e0959cda1e	constantize hot strings ... - 1131 objects over 4220 (-25%) created in app/	2021-04-16 13:13:22 +02:00
simon lehericey	47f13219ed	Avoid useless TypeDeChamp deserialization ... - 520 objects overs 4720 (10%) created in app/ (using ?pp=profile-memory&memory_profiler_allow_files=app/)	2021-04-16 13:13:22 +02:00
simon lehericey	e728a3fcb7	include type_de_champ ... Avoid n+1 when matching champ.stable_id in procedure.presentation.displayed_fields_values win 2s in the worst 3s scenario	2021-04-16 13:13:22 +02:00
Paul Chavard	ea484b879e	Prevent expert users to be deleted	2021-04-15 16:17:36 +01:00
kara Diaby	663fa50f02	notify expert when a decision is taken on a dossier	2021-04-15 11:29:55 +02:00
Paul Chavard	6d37e1d133	Fix discarded procedures destruction	2021-04-14 12:24:16 +01:00
Paul Chavard	5b56ec425b	Fix discarded dossiers destruction	2021-04-14 12:24:16 +01:00
Paul Chavard	f152c51d12	Remove ignored_columns	2021-04-13 17:00:07 +01:00
simon lehericey	76e261691a	add data column to france_connect_infromations	2021-04-13 09:59:28 +02:00
simon lehericey	cd6cb99c3c	add bypass_email_login_token to instructeur	2021-04-13 09:43:38 +02:00
simon lehericey	594cda3ee3	Remove previous attempt but steal its spec	2021-04-13 09:32:48 +02:00
simon lehericey	6055fd1b0b	remove for_procedure	2021-04-13 09:32:48 +02:00
simon lehericey	430acb1cb0	Fetch all count at once (- 400ms on pass culture)	2021-04-13 09:32:48 +02:00
simon lehericey	b24faae7e3	remove obsolete procedure_id column in assign_to table	2021-04-09 11:41:13 +02:00
Paul Chavard	5a7312f775	Ensure address to_s never returns nil	2021-04-08 16:43:45 +01:00
Paul Chavard	651a928b7c	Improuve export UI	2021-04-08 14:40:26 +01:00
Paul Chavard	371d612fdb	Remove unused columns	2021-04-08 12:43:29 +01:00
Paul Chavard	5e5122a436	Prevent crash in preview where there is no siblings	2021-04-06 18:15:29 +01:00
Paul Chavard	2702660d72	Update app/models/champs/header_section_champ.rb ... Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com>	2021-04-06 10:45:16 +01:00
Paul Chavard	4feda01b6f	Show section numbers only if none of sections start with numbers	2021-04-06 10:45:16 +01:00
kara Diaby	60c06b6d8c	add revoked at to experts_procedures	2021-04-06 10:39:22 +02:00
Pierre de La Morinerie	3499f5af9a	models: remove invalid Dossier ↔︎ Champ inverse relationship ... `Dossier.champs` is not really an inverse of `Champs.dossier`: when a Champ record is created, it should not always be added to dossier.champs (for instance if the champ is private). NB: this breaks the workaround we added in #3907 to fix the parent dossier not being touched in some cases (the workaround was to add an inverse relationship, but we now have to remove it). The new workaround is to watch for `changed_for_autosave?` on champs. Unlike `changed?`, `changed_for_autosave?` also detects changes to attachments. This allows us to touch both `last_champ_updated_at` and `updated_at` in a single pass.	2021-04-06 10:26:17 +02:00
Paul Chavard	7f3d4a26ad	Make exports#key not-null	2021-04-02 17:42:24 +01:00
Paul Chavard	fd48b86b7f	Simplify export unicity check and use create_or_find_by	2021-04-01 21:14:16 +01:00
Pierre de La Morinerie	798b4a65cc	models: fix db structure comment in etablissement.rb ... The column is not removed yet, but it is ignored.	2021-03-30 10:45:31 +02:00
Paul Chavard	23104f15a4	Fix export n+1 queries	2021-03-25 19:22:12 +01:00
Pierre de La Morinerie	3f3d6ae399	controllers: use template: rather than file: to render PDFs ... ActionView now throws an error if a relative path is used with `file:`.	2021-03-25 13:24:53 +01:00
kara Diaby	2930de1015	remove useless code in models	2021-03-24 17:47:24 +01:00
kara Diaby	71973de17c	remove useless columns from the db	2021-03-24 16:20:44 +01:00
Paul Chavard	0b22788d60	experts_procedure should not be optional	2021-03-23 13:46:33 +01:00
Paul Chavard	84214f4bd4	Do not export non exportable champs on draft procedures	2021-03-23 09:55:37 +01:00
Kara Diaby	38837443aa	Merge branch 'main' into fix-experts-lookup	2021-03-18 20:46:56 +01:00
Pierre de La Morinerie	239169e925	dossier: fix looking-up avis from Expert ... This line causes an error on Rails 6.1. And it isn't even necessary: this line is supposed to query avis where the expert advice has been requested – but this is handled by the `if expert.dossiers.include?(self)` condition just above.	2021-03-18 17:59:30 +01:00
Paul Chavard	1449fbbe67	Fix multiple_drop_down_list mandatory check	2021-03-18 15:22:28 +01:00
kara Diaby	5e88ecc24c	improve request to find an expert	2021-03-18 11:38:53 +01:00
kara Diaby	328c2a8e3c	change email to display for expert	2021-03-18 11:38:52 +01:00
kara Diaby	e7945594cf	eager_load for expert	2021-03-18 11:38:52 +01:00
kara Diaby	38740d1b5b	modify experts avis controllers, concern and serializer	2021-03-18 11:38:52 +01:00
kara Diaby	c55e4d0d98	remove unused instructeur logic	2021-03-18 11:38:52 +01:00
kara Diaby	54d414b3b7	add expert to export	2021-03-18 11:27:51 +01:00
kara Diaby	d47fde3fcb	add polymorphic relation to claimant on avis table	2021-03-18 11:27:51 +01:00
kara Diaby	d2ab2debb6	add expert logic	2021-03-18 11:27:51 +01:00
Christophe Robillard	60cc4d3697	add pdf to pjs export	2021-03-16 15:13:17 +01:00
Paul Chavard	76aa7bdfe3	Add default nil value for numero_tva_intracommunautaire	2021-03-16 12:57:10 +01:00
Pierre de La Morinerie	75a1046315	active_storage: refactor concerns ... Follow-up of #5953. Refactor the concerns with two goals: - Getting closer from the way ActiveStorage adds its own hooks. Usually ActiveStorage does this using an `Attachment#after_create` hook, which then delegates to the blob to enqueue the job. - Enqueuing each job only once. By hooking on `Attachment#after_create`, we guarantee each job will be added only once. We then let the jobs themselves check if they are relevant or not, and retry or discard themselves if necessary. We also need to update the tests a bit, because Rails' `perform_enqueued_jobs(&block)` test helper doesn't honor the `retry_on` clause of jobs. Instead it forwards the exception to the caller – which makes the test fail. Instead we use the inline version of `perform_enqueued_jobs()`, without a block, which properly ignores errors catched by retry_on.	2021-03-16 11:49:14 +01:00
Paul Chavard	a7fb7bf1ef	Add geo json validation	2021-03-11 15:51:09 +01:00
Paul Chavard	d24ee27cac	Try to reduce the number of external data fetches ... Only fetch external data if the external_id is the current one and data is not yet fetched	2021-03-11 14:56:37 +01:00
kara Diaby	6383e6b9e7	Revert "Revert "Claimant type to avis table"" ... This reverts commit f4fd220d43.	2021-03-10 08:48:55 +01:00
Paul Chavard	70500e3d56	Groupe instructeur selector default blank	2021-03-09 14:47:23 +01:00
Paul Chavard	9c3e72c84a	Use revision instead of groupe instructeur as dossier procedure link	2021-03-09 14:47:23 +01:00
Kara Diaby	f4fd220d43	Revert "Claimant type to avis table"	2021-03-09 13:40:10 +01:00
kara Diaby	af4a27f4e0	add claimant type on avis table	2021-03-07 22:47:24 +01:00
Christophe Robillard	6169399a6b	fix limit date for notice validation	2021-03-05 08:34:39 +01:00
Pierre de La Morinerie	b0735aafe0	config: fix DynamicSmtpSettingsInterceptor warning again ... This warning re-appeared when running mailer tests: ``` DISABLE_SPRING=1 bin/rspec spec/mailers/administration_mailer_spec.rb ``` It is now fixed properly, in a way recommanded by the documentation.	2021-03-04 22:52:19 +01:00
Christophe Robillard	7f496c43e5	no validation for old procedures	2021-03-04 16:13:19 +01:00
Pierre de La Morinerie	2f948f7e46	active_storage: fix blob update hooks ... For some reason on Rails 6.1 the `after_update_commit` hook is properly registered – but disappears from the record later, and in the end is never run. Fix it by using the general `after_commit` hook instead.	2021-03-04 14:30:38 +01:00
Paul Chavard	f31096b33e	When procedure is reset delete only draft revision dossiers	2021-03-04 13:10:58 +01:00
Paul Chavard	600f49a0ff	Hide groupe instructeur selector when routage is done via API	2021-03-04 11:06:04 +01:00
Paul Chavard	1c811083c0	Cleanup feature flags usage	2021-03-04 11:06:04 +01:00
Pierre de La Morinerie	9537342c06	procedure: fix query for finding champs without stable_id ... It would break on ActiveRecord 6.1.	2021-03-04 09:54:22 +00:00
Paul Chavard	5d4f025be0	Rename for consistency with defaut_groupe_instructeur	2021-03-04 10:45:02 +01:00
Paul Chavard	89ec3923f2	Defaut groupe instructeur ordered by label	2021-03-04 10:35:44 +01:00
Paul Chavard	96a832bc19	Add SerializerService	2021-03-02 12:42:22 +01:00
Paul Chavard	bb072ba9e9	Add id argument to most collections on dossier	2021-03-02 12:42:22 +01:00
Pierre de La Morinerie	9f676c76e1	config: fix zeitwerk warning about DynamicSmtpSettingsInterceptor ... Fix a warning when running tests: > DEPRECATION WARNING: Initialization autoloaded the constant DynamicSmtpSettingsInterceptor. > > Being able to do this is deprecated. Autoloading during initialization is going to be an error condition in future versions of Rails. > > Reloading does not reboot the application, and therefore code executed during > initialization does not run again. So, if you reload DynamicSmtpSettingsInterceptor, for example, > the expected changes won't be reflected in that stale Class object. > > This autoloaded constant has been unloaded. > > Please, check the "Autoloading and Reloading Constants" guide for solutions. However if we fix as recommanded, the interceptor will get added each time the classes are reloaded. And as the actual class instance changed after the reloading, they won't be de-duplicated – *and* there's no way to remove the old interceptor without having a reference to the (now-deleted) class. Instead we load the interceptor once, and add a message about the class not being auto-reloaded.	2021-02-24 19:00:29 +01:00
Paul Chavard	92158cecb6	fix constant	2021-02-19 11:29:08 +01:00
Paul Chavard	75392272fb	Add champ address model	2021-02-17 19:10:16 +01:00
Paul Chavard	7eee14feef	Add ChampFetchExternalDataJob	2021-02-17 19:10:16 +01:00
Christophe Robillard	d55f156aec	admin: durée de conservation des données hors ds n'est plus demandée ... La colonne est tout de même gardée en base	2021-02-17 16:41:57 +01:00
kara Diaby	7b4ec486ec	change active record request to get expert list	2021-02-16 09:46:18 +00:00
Paul Chavard	9ce07be1ee	[GraphQL] modifier annotation	2021-02-11 17:45:14 +01:00
Pierre de La Morinerie	819325c761	zeitwerk: move our Array extension to initializers/core_ext	2021-02-11 12:30:43 +01:00
Christophe Robillard	966ee33529	ignore when FranceConnect calls callback 2 times	2021-02-10 18:13:47 +01:00
Christophe Robillard	a288a13805	disable france connect authentication for admin and instructeurs	2021-02-10 18:13:47 +01:00
Pierre de La Morinerie	150ddab660	zeitwerk: Api -> API	2021-02-09 13:07:30 +01:00
Pierre de La Morinerie	4ad9adc510	models: fix Ruby 2.7 arguments passing ... Arguments to an ActiveRecord scope will always been passed as a Dictionnary. Thus `Dossier.with_notifiable_procedure(notify_on_closed: true)` will trigger a Ruby 2.7 warning: > /ruby/2.7.0/gems/activerecord-6.0.3.4/lib/active_record/relation.rb:412: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call Fix the issue by always expecting a Dictionary (rather than keyword arguments).	2021-02-09 09:20:46 +01:00
Paul Chavard	a591d5528e	Add job exception log methods to champ and dossier	2021-02-05 18:56:27 +01:00
Paul Chavard	78a07ef021	Add job exception logs to dossier and champ	2021-02-04 19:27:27 +01:00
Judith	6d89a83d14	unused locales clean-up	2021-02-04 12:15:13 +01:00
Paul Chavard	41c3a98d7d	Update Raven references to use Sentry	2021-01-28 19:46:36 +01:00
Paul Chavard	a26537c77d	Make some api entreprise fields optional	2021-01-27 11:53:00 +01:00
Paul Chavard	03ddd17884	Ignore entreprise_id on etablissements	2021-01-27 11:53:00 +01:00
kara Diaby	9b8d2f6fd3	instead of call Avis table, we now call Experts Procedure table to see the experts list	2021-01-26 13:59:10 +01:00
kara Diaby	85242e118b	add an email method to expert model	2021-01-26 13:59:09 +01:00
Paul Chavard	4452b2cf45	fix order of types de champ on procedure	2021-01-26 10:45:34 +01:00
kara Diaby	b683c2023b	add expert to avis table	2021-01-22 14:31:02 +01:00
kara Diaby	da067597ab	Add create expert method	2021-01-20 18:03:05 +01:00
simon lehericey	d409a9a6c5	Procedure and expert link	2021-01-20 18:03:05 +01:00
simon lehericey	29e9f2dd32	Ajout du model expert ... Co-authored-by: Kara Diaby <kdiaby.pro@gmail.com>	2021-01-20 18:03:05 +01:00
simon lehericey	685534e827	Add content validation for avis and messages	2021-01-18 17:23:08 +01:00
simon lehericey	d72f0c6dd2	Add authorized content type for pj	2021-01-18 17:23:08 +01:00
simon lehericey	da71031801	add skip_content_type_pj_validation attr to pj	2021-01-18 15:12:17 +01:00
Paul Chavard	97ce8f312b	Use external_id to fetch annuaire_education data	2021-01-15 11:50:02 +01:00
Paul Chavard	09a3cacd88	Add external_id to champs	2021-01-15 11:50:02 +01:00
Paul Chavard	54f2084aef	Add annuaire_education champ	2021-01-14 17:57:48 +01:00
Paul Chavard	a1643dad84	Add data column to champ	2021-01-14 17:31:37 +01:00
Paul Chavard	082b4830f3	Fix a crash when champ carte has no options	2021-01-12 14:47:20 +01:00
Paul Chavard	f33544f067	Fix type_de_champ repetition revision after clone ... fix #5769	2021-01-12 10:57:34 +01:00
simon lehericey	d43c7364fc	add image to notice and deliberation valid content type	2021-01-04 15:13:26 +01:00
kara Diaby	2b06ee95e1	Add a method to retrieve all invited experts for all procedure dossiers	2020-12-21 14:55:51 +01:00
Paul Chavard	09128cb85e	Add titre identite champ to GraphQL	2020-12-17 17:23:34 +01:00
Paul Chavard	a9a4f6e2a8	Add migration task to use stable_id in filters	2020-12-17 10:51:09 +01:00
simon lehericey	024cc70667	human_value use stable_id ?	2020-12-17 10:51:09 +01:00
simon lehericey	4960eda5cb	use stable id	2020-12-17 10:51:09 +01:00
simon lehericey	f07b395d95	sort : remove superfluous return	2020-12-17 10:51:08 +01:00
simon lehericey	f37c27a243	nicer find_field	2020-12-17 10:51:08 +01:00
simon lehericey	e5da1d7111	move remove_filter	2020-12-17 10:51:08 +01:00
simon lehericey	4241ea05f3	move add_filter	2020-12-17 10:51:08 +01:00
simon lehericey	e3ee756da4	move update_sort	2020-12-17 10:51:08 +01:00
simon lehericey	b7a43f3f44	move update_displayed_fields to procedure_presentation	2020-12-17 10:51:08 +01:00
simon lehericey	cbccdea8e0	move displayed_fields for select to procedure_controller	2020-12-17 10:51:08 +01:00
simon lehericey	55998b1284	remove unused dossier_field service	2020-12-17 10:51:08 +01:00
kara Diaby	c7643154d1	final optims after sim review	2020-12-16 15:00:26 +01:00
kara Diaby	f3c4040d2d	add grace period to deleted dossiers	2020-12-16 15:00:26 +01:00
kara Diaby	00b5ad7a10	EQT instructeur, je peux supprimer un dossier terminé	2020-12-16 15:00:26 +01:00
Christophe Robillard	3428c58b9e	extract password complexity validator ... for user and superadmin	2020-12-15 16:26:09 +01:00
Christophe Robillard	15a395fbc7	superadmin: check complexity password server side	2020-12-15 16:26:09 +01:00
simon lehericey	a941626d45	factorize read_attachment	2020-12-14 14:09:15 +01:00
simon lehericey	38a5847ca4	rewind io before reading to allow multiple read	2020-12-14 14:09:15 +01:00
Fabrice Gangler	064ea776c7	allow default logo of a procedure to be configured in .env file ... Refs: #5795	2020-12-14 13:41:10 +01:00
simon lehericey	5a9cd71783	fix bill signature	2020-12-11 15:49:05 +01:00
Paul Chavard	3c6e30a326	Show titre identite link only once watermark is added	2020-12-10 16:50:03 +01:00
Paul Chavard	48e7822e34	Remove titres identite after a dossier is processed	2020-12-10 15:21:25 +01:00
Paul Chavard	eaa9b1c071	Expose all optional layers in TypeDeChamp editor	2020-12-10 11:26:16 +01:00
Paul Chavard	cad8ee31d8	Remove legacy geo sources	2020-12-10 11:26:16 +01:00
Christophe Robillard	23ae528c6b	affiche Madame ou Monsieur ... mais continue à enregistrer en base Mme ou M.	2020-12-08 21:30:54 +01:00
Christophe Robillard	2066e3db87	rend plus compréhensible la civilité	2020-12-08 18:31:38 +01:00
Christophe Robillard	a8ed9ef172	remove dead code	2020-12-08 13:09:08 +00:00
Paul Chavard	b48e7813d2	Put watermark code behind a feature flag	2020-11-25 16:19:06 +01:00
Paul Chavard	371179dc5b	Watermark titres identite	2020-11-25 16:19:06 +01:00
kara Diaby	d9dea779ea	Remove foreign key dossier on dossier operations logs	2020-11-17 16:02:53 +01:00
kara Diaby	06f6cf7771	add new columns to deleted dossiers	2020-11-12 12:18:59 +01:00
kara Diaby	c033ef0910	Ajoute a l'information de connexion France Connect dans les informations du dossier ainsi que sur la demande usager	2020-11-05 19:30:13 +01:00
Christophe Robillard	5562e65bf3	refacto: rename administration to super_admin	2020-11-05 16:03:55 +01:00
Christophe Robillard	a88172eb01	configure otp_secret_key secret	2020-11-05 16:03:55 +01:00
Christophe Robillard	2a0ebd062a	enable 2FA for manager ... when trying to access manager, if superadmin did'nt enable otp, he/she is redirected to a page to enable 2FA. When superadmin is enabling 2FA, he has to to scan a qrcode with the 2FA application client. And afterwards, the superadmin has to log in with email, password and OTP code.	2020-11-05 16:03:55 +01:00
Christophe Robillard	305ccdc0cd	add recoverable and two_factor stragegy for administration	2020-11-05 16:03:55 +01:00
Christophe Robillard	6c2eb22960	remove github authentication for manager	2020-11-05 16:03:55 +01:00
clemkeirua	30dfe7fbd0	fix a_suivre	2020-11-04 11:07:53 +01:00
clemkeirua	89316c0689	fix counter for dossiers suivis/à suivre when unfollow	2020-10-28 13:51:35 +00:00
clemkeirua	b4910c557d	ajout de procedure.dossiers_count_for_instructeur	2020-10-28 13:51:35 +00:00
clemkeirua	47181ca80b	remove assert_matching_procedure	2020-10-28 13:51:35 +00:00
Paul Chavard	7c58f06c60	always validate geometries returned from api	2020-10-08 16:03:28 +02:00
Paul Chavard	0aa06d0197	[GraphQL] expose dossier pdf, geojson and attestation	2020-10-06 21:54:43 +02:00
simon lehericey	4af8bd47ac	cache landing data	2020-10-06 16:12:01 +02:00
simon lehericey	ad01d4dee5	really faster stats by precomputing some of them	2020-10-06 16:12:01 +02:00
kara Diaby	73399ae072	Fixe le nombre de caractères maximum dans l'url de la démarche (back end)	2020-10-06 14:26:14 +02:00
Paul Chavard	59086cc728	Fix geo length computations	2020-10-01 15:09:38 +02:00
Paul Chavard	4dfc1c719f	Fix geo areas computations	2020-10-01 15:09:38 +02:00
kara Diaby	57adb90c8f	add the possibility for administrator to refuse external review on a specific procedure	2020-10-01 10:55:19 +02:00
clemkeirua	9019a8b380	ensure a dossier_id is set if possible	2020-09-30 16:50:28 +02:00
Paul Chavard	1bd59c72e5	Include in exports types_de_champ from all revisions	2020-09-30 13:42:38 +02:00
clemkeirua	4fc038fe1b	use after_create instead of after_save	2020-09-29 18:15:38 +00:00
clemkeirua	d23b1136ad	send invite notifications using a hook	2020-09-29 18:15:38 +00:00
clemkeirua	dd7840cdc4	Notify new draft after dossier commit	2020-09-29 18:15:38 +00:00
simon lehericey	29ef5e6785	compute async only after create	2020-09-29 14:00:31 +02:00
simon lehericey	5ed491b958	export are kept for 1 hour	2020-09-29 13:59:57 +02:00
clemkeirua	9b324614b8	transform_values instead of map+to_h	2020-09-25 12:53:11 +00:00
clemkeirua	eb46cc6425	piecejusticative file validation focus on size	2020-09-25 09:35:16 +00:00
clemkeirua	c155de1d7e	ajout de la liste des extensions	2020-09-25 09:35:16 +00:00
clemkeirua	31d48c2879	validation is enableed only for 'new' procedures	2020-09-25 09:35:16 +00:00
clemkeirua	0d88674cea	better translations	2020-09-25 09:35:16 +00:00
clemkeirua	8711e8f911	reenable validator on piece_justificative	2020-09-25 09:35:16 +00:00
clemkeirua	d617a4b252	create export after commiting the export object	2020-09-24 18:56:22 +00:00
clemkeirua	c19b653581	higher level length sanitization for worksheet length	2020-09-24 14:59:46 +02:00
Paul Chavard	26a6e18cb9	Do not crash when rgeo can’t calculate polygon area ... example are “hourglass” shaped polygons	2020-09-23 16:52:08 +02:00
Paul Chavard	61c315b276	Fix geo area point coordinates display	2020-09-23 16:52:08 +02:00
kara Diaby	cb4e91c405	Add iban type de champ	2020-09-23 15:56:26 +02:00
Paul Chavard	973973ab6a	Do not enqueue web hooks for empty urls	2020-09-22 17:03:19 +02:00
Paul Chavard	c9f2224991	Remove ignored_columns from type_de_champ	2020-09-22 11:28:48 +02:00
Paul Chavard	3d3d0259a0	Remove TypeDeChamp.to_stable_id	2020-09-22 11:28:48 +02:00
Paul Chavard	a3f3b8a8e0	procedure.dossiers through revisions	2020-09-22 10:55:17 +02:00
Paul Chavard	a911a71db9	Log dossier archiver/desarchiver operations	2020-09-22 08:34:38 +00:00
Paul Chavard	50c0955465	Avoid an error if area can’t be computed	2020-09-22 09:12:55 +02:00
clemkeirua	f96377d878	refactor Dossier#with_notifications	2020-09-21 08:28:42 +00:00
clemkeirua	d01a53eb72	remove :cached_notifications gate	2020-09-21 08:28:42 +00:00
kara Diaby	5c68d75107	add titre_identite champ	2020-09-18 14:57:08 +02:00
clemkeirua	1e32a3c11f	add complexity check to admin account creation	2020-09-18 11:16:34 +02:00
clemkeirua	5a8fbde0e7	remove dead code in admin model	2020-09-18 11:16:34 +02:00
clemkeirua	de3118bc7b	force password reset on admin promotion or creation	2020-09-17 16:39:13 +02:00
clemkeirua	0307beecd6	Revert "Merge pull request #5576 from tchak/soft-delete-users" ... This reverts commit bf0d3914ce, reversing changes made to 503527459e.	2020-09-17 15:39:16 +02:00
Paul Chavard	a0dd3604a4	User discard_and_anonymize!	2020-09-17 11:16:56 +02:00
Paul Chavard	337b20661a	Add discared_at to users	2020-09-17 11:16:56 +02:00
clemkeirua	01ac4d7e19	remove operation_log_serialize_subject	2020-09-17 09:24:50 +02:00
Paul Chavard	bbcdff0ccf	Use IGN plan v2 and add MNHN data sources	2020-09-15 14:39:02 +02:00
simon lehericey	e4de522b48	only retrieve id of procedures with notifications	2020-09-11 09:43:04 +00:00
clemkeirua	3697c610b6	make polynesia mobile phone number valid	2020-09-09 09:00:07 +02:00
clemkeirua	c7b96d3d43	add feature-flip for instructeurs on cached notifications	2020-09-08 15:40:42 +00:00
clemkeirua	52ea5ef89a	make Dossier#with_notifications great again ... Co-authored-by: Christophe Robillard <christophe.robillard@beta.gouv.fr>	2020-09-08 15:40:42 +00:00
Paul Chavard	91bc2db594	Expose revisions on GraphQL API	2020-09-08 10:54:13 +02:00
clemkeirua	61cf33e3ca	remove duplicate private champ	2020-09-04 15:40:23 +02:00
Paul Chavard	6d4425885d	Fix champ order joins sql error	2020-09-03 18:32:43 +02:00
Paul Chavard	11a1e44fbe	Remove procedure_id from type_de_champ	2020-09-03 15:23:58 +02:00
Paul Chavard	d1de1587d3	Always serialize type_de_champ stable_id as id	2020-09-03 15:23:58 +02:00
kara Diaby	ae61c279af	migrate emails text editor to new interface	2020-09-03 14:42:22 +02:00
Paul Chavard	5ceae8235b	Ignore type_de_champ procedure_id	2020-09-02 11:26:26 +02:00
Paul Chavard	ec72fdd164	Remove migration service	2020-09-02 11:26:26 +02:00
Christophe Robillard	090a247ba9	validates phone champ server side	2020-08-20 15:33:03 +02:00
Christophe Robillard	f77cc06a91	prend en compte le nom de l'enseigne pour l'établissement	2020-08-20 14:23:02 +02:00
Pierre de La Morinerie	a7361fdbd3	models: require belong_to associations on mail templates	2020-08-18 15:57:37 +02:00
Pierre de La Morinerie	29e8c43e5e	models: require belong_to associations on groupe_instructeur	2020-08-18 15:57:37 +02:00
Pierre de La Morinerie	5a7bd24fba	models: require belong_to associations on type_de_champ ... - Make `type_de_champ.procedure` a requirement; - Move the procedure_id assignation to `before_validation` (otherwise the record is invalid, and never gets saved);	2020-08-18 15:57:37 +02:00
Pierre de La Morinerie	6328011f60	models: require belong_to associations on champ ... - Make `champ.dossier` a requirement; - Move the dossier_id assignation to `before_validation` (otherwise the record is invalid, and never gets saved); - Allow specs to only build the champ (instead of saving it to the database), which bypasses the requirement to have a dossier.	2020-08-18 15:57:37 +02:00
Pierre de La Morinerie	eb22dc9d8f	models: require belong_to associations on module_api_carto	2020-08-18 15:57:37 +02:00
Pierre de La Morinerie	71d9774d58	models: require belong_to associations on trusted_device_token	2020-08-18 15:57:37 +02:00
Pierre de La Morinerie	d807700c7b	models: require belong_to associations on traitement	2020-08-18 15:57:37 +02:00
Pierre de La Morinerie	059c147ffc	models: require belong_to associations on service	2020-08-18 15:57:37 +02:00
Pierre de La Morinerie	ce53e219e0	models: require belong_to associations on procedure_presentation ... Some tests are still failing	2020-08-18 15:57:37 +02:00
Pierre de La Morinerie	802d3804f5	models: require belong_to associations on invite	2020-08-18 15:57:37 +02:00
Pierre de La Morinerie	fe8804f208	models: require belong_to associations on individual	2020-08-18 15:57:37 +02:00
Pierre de La Morinerie	afb1c33154	models: require belong_to associations on geo_area	2020-08-18 15:57:37 +02:00
Pierre de La Morinerie	aff2713032	models: require belong_to associations on follow	2020-08-18 15:57:37 +02:00
Pierre de La Morinerie	91619b16e8	models: require belong_to associations on feedback	2020-08-18 15:57:36 +02:00
Pierre de La Morinerie	79fcf5e814	models: require belong_to associations on exercice	2020-08-18 15:57:36 +02:00
Pierre de La Morinerie	51d392a1dc	models: require belong_to associations on dossier	2020-08-18 15:57:36 +02:00
Pierre de La Morinerie	01248022bf	models: require belong_to associations on deleted_dossier	2020-08-18 15:57:36 +02:00
Pierre de La Morinerie	dd1bed9340	models: require belong_to associations on commentaire	2020-08-18 15:57:36 +02:00
Pierre de La Morinerie	32e55a6d37	models: require belong_to associations on avis	2020-08-18 15:57:36 +02:00
Pierre de La Morinerie	aefdd5d2a1	models: require belong_to associations on attestation_template	2020-08-18 15:57:36 +02:00
Pierre de La Morinerie	1ea4c2aa36	models: require belong_to associations on attestation	2020-08-18 15:57:36 +02:00
Pierre de La Morinerie	c1e2928ce7	models: require belong_to associations on assign_to	2020-08-18 15:57:36 +02:00
Pierre de La Morinerie	11456109c0	models: explicitly mark optional belongs_to relationship as so ... This prepares making the `belongs_to` relationship required by default.	2020-08-18 15:57:36 +02:00
Pierre de La Morinerie	c01d640997	models: return procedure revisions in deterministic order ... Fixes a randomly-failing spec in spec/models/procedure_revision_spec.rb.	2020-08-13 17:27:37 +02:00
Pierre de La Morinerie	2892fdbeef	models: remove columns that have been deleted from db schema ... These columns are gone, so we can't stop ignoring them.	2020-08-12 12:06:58 +02:00
Pierre de La Morinerie	6d28069539	models: generate annotations	2020-08-12 11:45:53 +02:00
Pierre de La Morinerie	8962db38cc	models: render attestations in a simpler way ... The older method of instanciating an entire new rendering stack can be made simpler using Rails >= 5.0 methods. See https://api.rubyonrails.org/classes/ActionController/Renderer.html#method-i-render	2020-08-04 16:53:46 +02:00
jpoulvel	bf94cc021b	Merge pull request #5424 from betagouv/new_design_edit_attestation ... New design page admin/attestation_templates/edit	2020-07-31 11:18:22 +02:00
Christophe Robillard	03e3e8fb1c	rename Dossier#modifier_annotations! ... give a more accurate name to the method Co-authored-by: clemkeirua <clement@keiruaprod.fr>	2020-07-30 10:18:44 +02:00
Judith	5df3838173	- tranferred controllers from admin to mew_administrateur ... - removed admin/attestation_templates views - changed routes accordingly	2020-07-29 12:26:27 +02:00
Paul Chavard	1fca481c6e	Cleanup after clone	2020-07-28 17:04:06 +02:00
clemkeirua	7e085c657d	specific deactivation of rubocop DS/ApplicationName rule	2020-07-23 16:20:16 +02:00
Paul Chavard	a08e318617	Add implicit_order_column on revisions	2020-07-22 12:25:06 +02:00
Paul Chavard	69ab2e44fb	Insert type_de_champ with correct initial position	2020-07-22 11:09:51 +02:00
Paul Chavard	3193784c24	Remove unused revision_id from payload	2020-07-22 11:09:06 +02:00