Lisa Durand
220b71bbf7
add classer_sans_suite and refuser to batch operation
2023-07-03 16:05:48 +02:00
Eric Leroy-Terquem
c82727120c
feat(DB): ignore migrated_champ_routage_columns
2023-07-03 14:58:45 +02:00
Eric Leroy-Terquem
7598b0a513
remove previous routing sytem code
2023-07-03 14:58:45 +02:00
Eric Leroy-Terquem
b94e8edb67
refactor(routing): move toggle_routing to procedure model
2023-07-03 14:47:56 +02:00
Eric Leroy-Terquem
3a667d39ba
refactor(routing): rollback Procedure#instructeurs_self_management?
2023-07-03 14:47:56 +02:00
Eric Leroy-Terquem
5416ec8226
refactor(routing): make toggle_routing public
2023-07-03 14:47:56 +02:00
Eric Leroy-Terquem
2a3ffdf3c6
refactor(routing): do not use toggle_routing as a callback anymore
2023-07-03 14:47:56 +02:00
Colin Darie
c95f4ab700
refactor(correction): preload corrections for exports
2023-07-03 09:53:24 +02:00
Martin
c52c0e4573
correctif(dossier.en_construction): ETQ usager, je souhaite pouvoir modifier un dossier ayant des repetition ayant des enfants
2023-06-30 12:09:54 +02:00
Christophe Robillard
faecefe405
merge admin api tokens
2023-06-28 13:37:33 +02:00
Paul Chavard
f3a5e0e6d7
Merge pull request #9219 from tchak/fix-departement-filters
...
ETQ Instructeur, je voudrais que les filtres fassent la différence entre les Bouches-du-Rhône et le Rhône
2023-06-28 09:42:50 +00:00
Colin Darie
10a37793be
Merge pull request #9252 from colinux/fix-demande-updated-at
...
ETQ usager/instructeur: fix date de modification du dossier
2023-06-28 08:46:39 +00:00
Paul Chavard
f7e81965b1
fix(instructeur): filter by departement or region should use code instead of name
2023-06-28 10:14:34 +02:00
Paul Chavard
02dcead04a
fix(commune): add fallbacks to commune name resolution
2023-06-28 09:44:21 +02:00
Colin Darie
1bdc6c02c6
style(demande): homogeneize "blank" champs and not attached files champs
2023-06-27 17:44:21 +02:00
Colin Darie
cf1285dd42
fix(rebase): ensure dossier.champs is up to date after creating a child
2023-06-23 01:01:39 +02:00
Colin Darie
8501fbadbb
fix(dossier): can merge fork after rebase adding a champ in repetition
2023-06-23 00:22:32 +02:00
Lisa Durand
9338a73362
add possibility to override generated pj list by admin
2023-06-22 09:50:38 +02:00
Paul Chavard
e509ff1717
fix(dossier): do not send notifcations to deleted users
2023-06-21 09:52:38 +01:00
mfo
ab1399da57
Merge pull request #9209 from mfo/US/intercept-email-delivering
...
amelioration(email_event): re-lever une erreur dans un rescue_from ne la fait pas remonter. change de stratégie pour savoir si oui ou non un mail a ete envoye avec success.
2023-06-20 14:55:49 +00:00
Martin
9b2d05b8a1
amelioration(email_event): re-lever une erreur dans un rescue_from ne la fait pas remonter. change de stratégie pour savoir si oui ou non un mail a ete envoye avec success.
2023-06-20 13:39:29 +02:00
Colin Darie
acc6456b08
Merge pull request #9201 from demarches-simplifiees/user-dashboard/add-filter-a-corriger
...
[refonte usager] Tableau de bord - remonter les dossiers à corriger
2023-06-19 19:21:32 +00:00
Lisa Durand
6a92249f0a
Merge pull request #9208 from demarches-simplifiees/remove-iban-from-suspicious-list
...
ETQ admin, je ne veux plus voir l'IBAN comme un champ "suspect"
2023-06-19 14:45:06 +00:00
Colin Darie
7023284726
Merge pull request #9195 from colinux/job-declarative-dossier-unit
...
Jobs: traite en isolation les dossiers bloqués de démarches déclaratives
2023-06-19 14:44:59 +00:00
Lisa Durand
52bbd47ebe
add constant for 'à_corriger'
2023-06-19 16:16:44 +02:00
Lisa Durand
87f11f06ad
remove IBAN from forbidden keywords list
2023-06-19 14:30:29 +02:00
Eric Leroy-Terquem
be4f8f57ab
Merge pull request #9093 from demarches-simplifiees/rerouter-un-dossier
...
ETQ instructeur je peux réaffecter un dossier à un autre groupe d'instructeurs
2023-06-16 12:01:10 +00:00
Lisa Durand
bcc37f4130
change states filter from checkbox to select and add 'a_corriger'
2023-06-15 18:17:36 +02:00
Lisa Durand
f4e33c068b
Merge pull request #9121 from demarches-simplifiees/add-detail-on-PJ-on-description-procedure-page
...
[Refonte page accueil demarche] Ajouter les infos concernant les PJ
2023-06-15 12:52:50 +00:00
Eric Leroy-Terquem
a9c6cc322a
feat(routing): do not run routing engine if dossier has been re routed
2023-06-15 14:34:02 +02:00
Eric Leroy-Terquem
ce1429b850
migration : add forced_group_instructeur_to_dossier
2023-06-15 14:14:47 +02:00
Eric Leroy-Terquem
e78c22f33c
refactor(groupe instructeur): extract method other_groupe_instructeurs
2023-06-15 14:14:47 +02:00
Paul Chavard
c1afc985e4
fix(prefill): allow private annotations prefill
2023-06-15 10:07:25 +01:00
Paul Chavard
01653440e7
Merge pull request #9198 from tchak/fix-groupe-instructeur-api-hack
...
fix(hack): fix and test hack for procedures using groupe instructeur api
2023-06-14 18:35:46 +00:00
Paul Chavard
10524643fb
fix(hack): fix and test hack for procedures using groupe instructeur api
2023-06-14 19:24:58 +01:00
Paul Chavard
a432323843
fix(dossier): only show optional text on public champs
2023-06-14 19:00:06 +01:00
Colin Darie
17f5fb4a51
refactor(declarative): process dossier in job isolation
2023-06-14 12:06:22 +02:00
Paul Chavard
b3aeb46c1b
fix(prefill): it should be possible to prefill a dossier on a test procedure
2023-06-14 09:14:12 +01:00
Lisa Durand
4b6d18608e
split pj in two lists regarding to conditionnal
2023-06-13 11:00:16 +02:00
Lisa Durand
d2f91a6405
add list of PJ in procedure description
2023-06-13 10:58:05 +02:00
Paul Chavard
6723bdcd9d
fix(carto): no crash on points with elevation
2023-06-12 14:56:52 +02:00
Colin Darie
75b2685230
fix(instructeurs): human format a filtered date
2023-06-08 19:01:23 +02:00
Paul Chavard
c4432b1b47
perf(carto): use json schema to validate geojson instead of rgeo
2023-06-06 15:43:56 +02:00
Colin Darie
66dc8f251f
Merge pull request #9128 from colinux/fix-procedure-presentation-show-avis
...
ETQ instructeur je veux pouvoir afficher sans erreur la colonne "avis"
2023-06-05 08:53:39 +00:00
Colin Darie
7e567d5080
fix(instructeurs): don't crash when displaying "avis" column
2023-06-02 17:07:02 +02:00
Colin Darie
b1bcc784bb
refactor(messagerie): preload commentaires with corrections & attachments blobs
2023-06-02 16:18:33 +02:00
Colin Darie
7f871728c7
refactor(message): badges à corriger/en attente/corrigé when related to a correction
2023-06-02 16:18:33 +02:00
Colin Darie
52c8553576
fix(dossier_correction): don't allow to save with a missing (invalid) commentaire
2023-06-02 16:18:33 +02:00
Colin Darie
b495e0aff0
feat(user): dossier résumé with commentaire about corrections
2023-06-02 16:18:32 +02:00
Colin Darie
62cc9d30d8
chore(correction): passing en_instruction resolve pending corrections
2023-06-02 16:16:14 +02:00
Colin Darie
5ab44fc7a9
chore: rename dossier_resolution => dossier_correction
2023-06-02 16:16:14 +02:00
Colin Darie
b14a70abf7
feat(instructeur): filter dossiers "en attente"
2023-06-02 16:16:14 +02:00
Colin Darie
9565267170
feat(dossier): notify user by email about pending corrections
2023-06-02 16:16:13 +02:00
Colin Darie
ca3b127942
feat(instructeur): can flag a dossier as "pending corrections"
2023-06-02 16:16:12 +02:00
Colin Darie
d73b96ea40
feat(dossier): pending resolution state
2023-06-02 16:13:16 +02:00
Colin Darie
2c79ca94f5
chore(schema): create dossier_corrections
2023-06-02 16:13:15 +02:00
Colin Darie
ec244f1a94
fix(procedure): auto_archive_on must be in future
2023-06-01 16:49:52 +02:00
Eric Leroy-Terquem
e8d687f5e7
fix(routing): routing engine works even with unconfigured groups
2023-05-31 11:38:16 +02:00
Eric Leroy-Terquem
54fe10ff76
add warning in revision change component if tdc options used for routing has been changed
2023-05-31 11:38:16 +02:00
Eric Leroy-Terquem
50abf496fd
add warning in gi pages in rule does not match tdc
2023-05-31 11:38:16 +02:00
simon lehericey
25ebfc4928
always set procedure.instructeurs_self_management_enabled to true when routing_enabled?
2023-05-31 11:38:16 +02:00
Eric Leroy-Terquem
692010fa32
destroy all groups but defaut
2023-05-31 11:38:16 +02:00
simon lehericey
f61498693a
use routable_type_de_champ
2023-05-31 11:38:16 +02:00
simon lehericey
5b0e0ced3c
add groupes_management_component
2023-05-31 11:38:16 +02:00
Lisa Durand
a20ec44841
Merge pull request #9074 from demarches-simplifiees/add-more-info-on-procedure-description
...
[Refonte page accueil demarche] Détailler la description pour plus de clarté pour l'usager
2023-05-30 09:45:32 +00:00
krichtof
0051face93
Merge pull request #9014 from demarches-simplifiees/8859-default_zones
...
Etq admin, lors de la création ou modification d'une démarche, des zones par défaut me sont suggérées
2023-05-26 17:25:21 +00:00
Christophe Robillard
1bda86be03
suggest default zones
2023-05-24 17:40:00 +02:00
Christophe Robillard
b13e77650e
update default zones after admin creation
2023-05-24 17:40:00 +02:00
Colin Darie
795e0ca471
fix(fork): can fork a dossier having invalid champs so it can be fixed in brouillon
2023-05-24 12:15:43 +02:00
Lisa Durand
7340206f81
rollback - add just one new field and use actual description field
2023-05-24 11:31:24 +02:00
Paul Chavard
cf13b942e7
Merge pull request #9076 from colinux/fix-instructeurs-filter-avis
...
ETQ instructeur je peux filtrer les dossiers par avis
2023-05-24 08:05:07 +00:00
Lisa Durand
b6cc35df68
fix specs
2023-05-23 10:34:03 +02:00
Colin Darie
ff8fba3725
fix(instructeur): can filter by avis answer
2023-05-23 09:40:21 +02:00
Lisa Durand
4a51a9a351
add two more fields for procedure description what et and for_who
2023-05-22 15:36:48 +02:00
Colin Darie
d16b81e09c
fix(rebase): don't fail on force rebased when procedure is still in draft
2023-05-22 13:50:58 +02:00
Paul Chavard
a2e98f9065
Merge pull request #9051 from demarches-simplifiees/fix-bug-procedure-clone-validations
...
[fix] Vider les champs invalides pour permettre de cloner une procedure
2023-05-17 07:44:39 +00:00
Lisa Durand
7e39e8113b
feedback PR Colin
2023-05-16 17:54:37 +02:00
Martin
f76e52cc97
tech(tache.recovery): ajoute une tache pour re-importer des dossiers venant d'un backup
...
Update app/lib/recovery/exporter.rb
Co-authored-by: Colin Darie <colin@darie.eu>
2023-05-16 14:49:36 +02:00
simon lehericey
06b6663662
import more stuff
2023-05-16 14:49:36 +02:00
Lisa Durand
f2cf3188d7
empty invalid fields to allow clone procedure
2023-05-16 10:59:17 +02:00
Christophe Robillard
34540d34e9
create default_zones_administrateurs
2023-05-16 09:40:53 +02:00
Christophe Robillard
3705dc2553
determine default zones according to tchap hs
2023-05-16 09:40:53 +02:00
Christophe Robillard
a191f66508
add tchap hs to zone
2023-05-16 09:40:53 +02:00
Colin Darie
8592571b50
Merge pull request #9034 from colinux/editor-typo
...
Admin: corrige une typo dans une option de nombre de caractères limite
2023-05-15 11:41:21 +00:00
Colin Darie
ec6d9f4e33
Merge pull request #9035 from colinux/fork-fix-champ-pj-updated-at
...
Correctif: ETQ usager le champ PJ d'un dossier en construction ne doit pas être marqué "à déposer" sans raison
2023-05-15 10:33:10 +00:00
Colin Darie
d3028f5570
Merge pull request #9037 from demarches-simplifiees/fix-bug-alert-batch-incrementation
...
[Fix] Actions multiples - Corriger le compteur dans les alertes + ajouter des infos sur le créateur du batch
2023-05-15 10:32:31 +00:00
Colin Darie
0d21450f8a
fix(fork): don't let active storage override our champ#updated_at after a transaction
2023-05-15 11:08:07 +02:00
Paul Chavard
f485f144fc
chore(procedure): log dossiers before reset
2023-05-15 10:21:54 +02:00
Paul Chavard
b4a299c326
fix(user): always rebase original dossier before merge
2023-05-12 20:42:02 +02:00
simon lehericey
26fa5de790
avoid reset
2023-05-12 11:31:34 +02:00
simon lehericey
6148f24387
Revert "Merge pull request #9002 from tchak/feat-procedure-clone-preview-published"
...
This reverts commit 7a6f46a8ad
, reversing
changes made to 4513c52213
.
2023-05-12 11:29:11 +02:00
simon lehericey
7b17bfe0a1
feat: add info for screen reader
2023-05-12 10:03:54 +02:00
Lisa Durand
1e7add3b6e
fix incrementation of success dossiers in batch alert
2023-05-11 15:42:23 +02:00
Colin Darie
79f450a422
Merge pull request #9021 from colinux/feat-en-construction-fork
...
ETQ usager, je modifie et soumets à nouveau mon dossier “en construction"
2023-05-10 19:46:40 +00:00
LeSim
4cde60ce2b
Merge pull request #9023 from mfo/US/clarify-counters
...
amelioration(instructeurs/procedure#show): ETQ instructeur, je souhaite avoir les mêmes compteurs entreles pages listant mes demarches et la page pour visualiser une démarches
2023-05-10 10:03:11 +00:00
Colin Darie
218c7d08c2
feat(fork): mark a fork as stale for future deletion, so it can't be reused
2023-05-09 18:49:53 +02:00
Colin Darie
c35176703f
feat(dossier): inform dossier en_construction having not submitted changes
2023-05-09 18:49:52 +02:00
Colin Darie
f6ebfe0e47
fix(dossier): sync search_terms after merge
...
Use a job instead of a lot of reloads
2023-05-09 18:49:52 +02:00
LeSim
d0bb759d3d
Merge pull request #8997 from demarches-simplifiees/add_defaut_procedure_for_new_admin
...
ETQ admin, je veux avoir une première démarche pré remplie lorsque j'arrive sur ds
2023-05-09 16:38:55 +00:00
Paul Chavard
71cfe094aa
fix(groupe_instructeur): always use assign_to_groupe_instructeur method
2023-05-09 17:23:23 +02:00
Paul Chavard
08a2a2c9aa
feat(dossier): fork dossier when editing en construction
2023-05-09 17:16:47 +02:00
Paul Chavard
025bd5beaf
feat(dossier): dossier can be forked for editing
2023-05-09 15:34:10 +02:00
Martin
386523019d
amelioration(instructeurs/procedure#show): ETQ instructeur, je souhaite avoir les mêmes compteurs entreles pages listant mes demarches et la page pour visualiser une démarches
2023-05-09 13:59:49 +02:00
Paul Chavard
b88d984828
fix(instructeur): exclude repetitions from filters/display
2023-05-09 11:38:06 +02:00
Lisa Durand
2b2d65de87
Merge pull request #8994 from demarches-simplifiees/add-simple-filter-for-usagers
...
[refonte usager] Tableau de bord - Ajouter bouton filtres simples
2023-05-09 08:06:15 +00:00
mfo
2374ced5d2
Merge pull request #8987 from mfo/US/link-to-errored-champs
...
amelioration(dossier#submit_brouillon): ETQ usager, je souhaite pouvoir acceder aux champs en erreur facilement
2023-05-09 07:06:36 +00:00
Paul Chavard
f563fb3269
Merge pull request #8990 from tchak/fix-limit-textarea-size
...
ETQ administrateur, je veux pouvoir limiter le nombre de caractères dans les champs "texte long"
2023-05-05 14:54:41 +00:00
Paul Chavard
fe041b4c6c
fix(textarea): fix character limit option
2023-05-05 16:36:51 +02:00
Paul Chavard
471da7eb61
Revert "Revert "Merge pull request #8844 from demarches-simplifiees/feat/7739""
...
This reverts commit 909d726429
.
2023-05-05 16:36:51 +02:00
Paul Chavard
7a6f46a8ad
Merge pull request #9002 from tchak/feat-procedure-clone-preview-published
...
ETQ Administrateur, je veux cloner la version publiée des démarches en production
2023-05-05 14:36:03 +00:00
Martin
2135985583
correctif(procedure.clone): ET admin, je souhaite pouvoir cloner une procedure ayant deux groupes d'instructeur ayant le dernier fermé
2023-05-05 11:09:06 +02:00
Paul Chavard
11065946ce
fix(instructeur): fix dossiers suivis filter (merge behavior change in rails 7)
2023-05-04 18:24:18 +02:00
Paul Chavard
616188bfe3
feat(administrateur): when clone or preview procedure should use published revision if not the owned
2023-05-04 16:15:55 +02:00
Lisa Durand
c039414872
feedback PR review
2023-05-04 12:39:06 +02:00
Lisa Durand
9fd9bdc7c0
add tag to display and remove active filters
2023-05-03 16:47:27 +02:00
simon lehericey
9c8020b05c
feat(admin): add initiation procedure for a new admin
2023-05-03 15:08:21 +02:00
Colin Darie
6616acb825
chore(super-admin): update devise-two-factor v5 with otp_secret encrypted attribute
2023-05-03 11:35:32 +02:00
Colin Darie
d31016973c
chore(schema): model annotations accordingly to schema
2023-05-03 11:35:31 +02:00
Nicolas Cavigneaux
3aa6a5e28e
fix: url helper method calls for files
2023-05-03 11:35:28 +02:00
Nicolas Cavigneaux
388ccca263
fix redefinition of signed_id
Rails method by supporting options as arg
2023-05-03 11:35:28 +02:00
Martin
c8ab1e8e03
amelioration(dossier#submit_brouillon): ETQ usager, je souhaite pouvoir acceder aux champs en erreur facilement
2023-05-03 07:36:42 +02:00
Lisa Durand
24eca40f66
add from_depose_at filter
2023-05-02 10:32:38 +02:00
Lisa Durand
21ed6abcad
add from_created_at filter
2023-05-02 09:37:03 +02:00
Paul Chavard
f2c1c071b4
Revert "Merge pull request #8899 from demarches-simplifiees/8738-validate-adresse-electronique"
...
This reverts commit d3eda28f35
, reversing
changes made to 6394996e7f
.
2023-04-28 16:10:20 +02:00
Paul Chavard
909d726429
Revert "Merge pull request #8844 from demarches-simplifiees/feat/7739"
...
This reverts commit 04fbfa15b7
, reversing
changes made to aac1cc7161
.
2023-04-28 16:08:24 +02:00
Lisa Durand
39f534b3d7
add states filter for usager
2023-04-28 15:28:04 +02:00
Kara Diaby
04fbfa15b7
Merge pull request #8844 from demarches-simplifiees/feat/7739
...
Ajoute un compteur sur les champ texte
2023-04-27 13:53:20 +00:00
Colin Darie
b0f4c578a6
Merge pull request #8978 from colinux/refactor-dolist-module
...
Tech: ne mélange pas class & module Dolist, supprime adapter SMTP
2023-04-27 09:52:42 +00:00
Kara Diaby
f3f49941b6
Ajoute un compteur sur les champ de type textarea sur l'interface usager
2023-04-27 10:28:43 +02:00
Colin Darie
5cc2712873
refactor(dolist): drop smtp deliver method
2023-04-27 10:09:29 +02:00
Paul Chavard
cb752d1857
fix(dossier): do not bypass depositaire check on modifier path
2023-04-27 09:52:10 +02:00
LeSim
4c5e903673
Merge pull request #8887 from demarches-simplifiees/8839-filter-by-siret
...
Filtrer les démarches par service
2023-04-26 19:44:08 +00:00
Paul Chavard
a41713c837
Merge pull request #8968 from demarches-simplifiees/fix_defaut_groupe_instructeur_again
...
Correctif: definit le groupe instructeur par defaut pour certaines procedure clonées
2023-04-26 17:59:13 +00:00
Paul Chavard
d3eda28f35
Merge pull request #8899 from demarches-simplifiees/8738-validate-adresse-electronique
...
ETQ usager, je veux que les champs de type adresse électronique soit validé
2023-04-26 16:52:02 +00:00
Lisa Durand
e393132fd8
Merge pull request #8936 from demarches-simplifiees/add-yes-no-column-for-instructeurs
...
[instructeur] ajout du nb de réponses oui/non aux avis dans le tableau d'une procedure
2023-04-26 09:05:58 +00:00
simon lehericey
0934a672fe
fix: defaut_groupe_instructeur for a cloned procedure from another admin without a group with default label
2023-04-26 10:52:31 +02:00
LeSim
1a704f0479
Merge pull request #8966 from mfo/US/fix-avis-remind-with-question
...
ETQ instructeur, je peux relancer une demande d'avis meme si celui ci contient une question
2023-04-26 08:09:41 +00:00
LeSim
c8ed0532ed
Merge pull request #8948 from colinux/fix-geoarea-geometry-blank
...
ETQ Usager, champ carte: ne permet pas d'enregistrer une geometry null pour ne pas casser les exports
2023-04-26 10:15:25 +02:00
Colin Darie
21a829ec1e
fix(conditionel): error when using operator eq/not_eq with a multi dropdown
2023-04-26 09:58:00 +02:00
Martin
1ae40f1a22
correctif(instructeurs/avis_controller#remind): ETQ instructeur, je peux relancer une demande d'avis meme si celui ci contient une question
2023-04-26 07:46:21 +02:00
mfo
fdb361c207
Merge pull request #8955 from tchak/fix-typo
...
ETQ instructeur, je veux pouvoir accéder à mes annotations privées
2023-04-25 12:47:49 +00:00
Lisa Durand
384b7f9fac
simplify humanized groupe instructeur filter
2023-04-25 14:15:40 +02:00
Lisa Durand
26ff82dbe4
Merge branch 'main' of github.com:betagouv/demarches-simplifiees.fr into user-dashboard/add-alert-WIP-last-dossier
2023-04-25 13:01:40 +02:00
Paul Chavard
08ed5e0d87
fix(type_de_champ): should use dossier revision instead of type_de_champ revision
2023-04-25 12:00:42 +02:00
Paul Chavard
eae58ae5b0
fix(type_de_champ): type_champs_private -> types_de_champ_private
2023-04-25 11:59:32 +02:00
Lisa Durand
3678015413
remove scope not_archived for brouillon
...
Co-authored-by: Paul Chavard <paul.chavard@beta.gouv.fr>
2023-04-25 10:56:59 +02:00
Colin Darie
f7880352f0
Merge pull request #8941 from mfo/US/fixed-dossier-stalled-auto-processing
...
correctif(procedure.declarative): ETQ administrateur d'une procedure declarative, certains de mes dossiers restent en construction [ex: l'object storage est down, le dossier reste bloqué]
2023-04-22 16:13:01 +00:00
Colin Darie
25956c5141
fix(geoarea): geometry must not be nil
2023-04-22 16:23:39 +02:00
Martin
9dec6f1611
correctif(procedure.declarative): ETQ administrateur d'une procedure declarative, certains de mes dossiers restent en construction [ex: l'object storage est down, le dossier reste bloqué]
2023-04-21 15:45:45 +02:00
Colin Darie
2775158052
Merge pull request #8943 from tchak/fix-dossier-can-create-new-dossiers
...
ETQ usager, je peux créer de nouveaux dossiers sur la démarche qui remplace la démarche fermée
2023-04-21 13:18:43 +00:00
simon lehericey
a202a57988
fix: defaut_groupe_instructeur_id for a cloned procedure
2023-04-21 12:20:50 +02:00
Paul Chavard
52d63a1b02
fix(dossier): user can create new dossiers when closed procedure is replaced
2023-04-21 11:18:27 +01:00
krichtof
c2461f230c
validate value for email champ
2023-04-20 18:27:02 +02:00
Lisa Durand
34697a3085
add missing translation for filter groupe instructeur
2023-04-20 17:32:36 +02:00
Lisa Durand
65730bcfcb
display avis_anwser yes/no in table
2023-04-20 15:55:31 +02:00
Paul Chavard
88f680a265
Merge pull request #8930 from tchak/fix-champ-commune-spaces
...
ETQ usager, je voudrai pouvoir remplir un code postal avec des espaces
2023-04-20 08:40:38 +00:00
Paul Chavard
586286cb08
Merge pull request #8916 from demarches-simplifiees/can-update-defaut-groupe-instructeur-2
...
feat(routage): permet de changer le groupe par défaut
2023-04-20 08:28:46 +00:00
Paul Chavard
4a2e499679
fix(commune): should accept postal codes with spaces
2023-04-20 10:16:48 +02:00
simon lehericey
e64ac79f05
tech(refactor): much nicer code, thx LeSim
...
root -> rooted_tree
depth_cach -> walk
smal refactor
comment
remove form for header_section
remove seen_at from header section
header_section: champ -> header_section
champ_subree: remove if not
remove root_depth use header_section_level_value instead
remove unused include
remove ChampTreeComponent
rename ChampsSubtreeComponent to SectionComponent
use TreeableConcern only in section component
remove fields_for_champ_component
champs -> tail
add split_section_champ helper
refactor(editable_champ::header_section): keep same interface everywhere
fix(repetition): add spec for SectionComponent on repetitions
2023-04-20 08:22:02 +02:00
Martin
88abefb370
tech(remaniement): isole la logique de rendu au champs_subtree_component
2023-04-20 08:22:02 +02:00
Martin
3b5d1bd55b
tech(remaniement): extraction du passage d'une liste de champs a un simili arbre
2023-04-20 08:22:02 +02:00
Martin
ad77b9321b
amelioration(formulaire-usager): groupes les champs suivant un titre de section dans une balise html de type <fieldset> de sorte a améliorer l'accessibilite de la plateforme
2023-04-20 08:22:02 +02:00
Martin
b9faa26560
amelioration(editeur-de-champs): permet de choisir un niveau de titre (de 1 à 3) pour les champs de type Champs::HeaderSectionChamp. Gère les erreurs dans le cas ou un administrateur supprimerait un HeaderSection qui casserait l'ordre des titre [ex: titre 1,2,3. et l'admin supprime le titre 1 et il reste que 2,3].
2023-04-20 08:22:02 +02:00
Paul Chavard
ce466d072a
feat(manager): display procedure state and unpublished date
2023-04-19 19:59:54 +02:00
Colin Darie
9728493bda
Merge pull request #8924 from colinux/rubocop-upgrades
...
Tech: update rubocop, active nouveaux cops Rails/*
2023-04-19 13:37:10 +00:00
simon lehericey
9c6af921e5
Use has_one defaut_procdre to avoid before destroy prepend
2023-04-19 13:52:42 +02:00
simon lehericey
95ab81fd1c
feat(routing): use procedure.defaut_groupe_instructeur_id to find defaut_groupe_instructeur
2023-04-19 13:52:41 +02:00
Paul Chavard
8904516b85
chore(procedure): remove duplicate code
2023-04-19 13:00:37 +02:00
Colin Darie
1af404c5e7
chore(rubocop): fix Rails/WhereMissing
2023-04-19 12:55:14 +02:00
Colin Darie
f4ad5289cd
chore(rubocop): fix Rails/RedundantPresenceValidationOnBelongsTo
2023-04-19 12:55:14 +02:00
Colin Darie
20f0b64736
chore(rubocop): fix Rails/WhereNotWithMultipleConditions
2023-04-19 12:55:14 +02:00
Colin Darie
e9649b667e
chore(rubocop): fix Rails/IgnoredColumnsAssignment
2023-04-19 12:55:14 +02:00
Colin Darie
8fa5e0dbb8
chore(rubocop): fix Rails/UnusedIgnoredColumns
2023-04-19 12:55:14 +02:00
Colin Darie
7aba5ccc3e
chore(rubocop): fix Rails/DurationArithmetic
2023-04-19 12:55:13 +02:00
Colin Darie
160178b8f8
chore(rubocop): fix Rails/ExpandedDateRange
2023-04-19 12:55:13 +02:00
Colin Darie
bd8e8633e7
chore(rubocop): fix Rails/CompactBlank
2023-04-19 12:55:13 +02:00
Colin Darie
ca11ec8380
chore(rubocop): fix Rails/OutputSafety
2023-04-19 12:55:12 +02:00
Paul Chavard
0912a30eb0
feat(dossier): use turbo on select with other
2023-04-18 15:24:23 +02:00
Paul Chavard
eb599394e0
feat(dossier): use turbo on linked lists
2023-04-18 15:24:23 +02:00
Lisa Durand
c565ed415b
change scope and alert location after UI modification
2023-04-18 12:03:10 +02:00
LeSim
c252748833
Merge pull request #8836 from demarches-simplifiees/improve-routing-rules-ux
...
feat(routing): nicer and safer ?
2023-04-17 08:23:15 +00:00
Paul Chavard
21b548d32b
fix(dossier): delete all champs starting with children
2023-04-13 11:08:10 +02:00
Paul Chavard
7054c2d9ef
fix(demarche): always reset outside of transactions
2023-04-13 11:05:38 +02:00
simon lehericey
f6948cfd5e
feat(routing): record first groupe as default_groupe_instructeur
2023-04-13 10:36:42 +02:00
Eric Leroy-Terquem
cade677355
feat(db): add defaut_groupe_instructeur_id column to procedures
2023-04-13 10:36:42 +02:00
simon lehericey
c1f67499aa
feat(routing): server side: prevent tdc deletion if used for routing
2023-04-13 10:28:52 +02:00
simon lehericey
3f55fddcef
feat(routing): ui side: prevent tdc deletion if used for routing
2023-04-13 10:28:52 +02:00
krichtof
78938b5a07
filter demarches by siret service
2023-04-12 18:53:57 +02:00
Lisa Durand
bc3e67ab94
add alert on user dashboard to edit last editable dossier
2023-04-11 15:50:17 +02:00
Paul Chavard
def32a3615
chore(dossier): remove fallback from commune champ
2023-04-11 10:49:01 +02:00
Colin Darie
a413d2fa9c
fix(admin): can delete an admin without published procedure
2023-04-07 16:10:10 +02:00
Paul Chavard
aaae3f461d
feat(graphql): expose commune and departement information on address
2023-04-07 12:13:41 +02:00
Paul Chavard
0b95a912c6
Merge pull request #8858 from tchak/feat-refactor-dossier-link-champ
...
feat(dossier): use turbo to select linked dossier
2023-04-07 08:49:11 +00:00
Paul Chavard
79fee39888
Merge pull request #8872 from tchak/fix-champ-multiselect
...
fix(dossier): selecting blank option should not empty selection
2023-04-06 14:32:35 +00:00
Paul Chavard
ffb332159f
fix(dossier): selecting blank option should not empty selection
2023-04-06 15:24:52 +02:00
Paul Chavard
a2f7d1df72
fix(graphql): pendingDeletedSince should not crash
2023-04-06 15:07:48 +02:00
Paul Chavard
7ea443f86a
Merge pull request #8860 from demarches-simplifiees/ay11-actions-multiples
...
[a11y] actions multiples
2023-04-05 16:41:06 +00:00
Paul Chavard
b8f639721e
Merge pull request #8864 from colinux/fix-date-not-parseable
...
fix(date): ne crash pas lorsqu'un champ date n'as pas une date standard
2023-04-05 11:48:48 +00:00
Colin Darie
5e62aa7d21
fix(date): don't crash when date value is not parseable
2023-04-05 12:42:28 +02:00
Paul Chavard
52c8b0b297
feat(dossier): use turbo to select linked dossier
2023-04-05 11:40:03 +02:00
Lisa Durand
9065e57e62
add aria-sort on sortable column
2023-04-05 10:05:51 +02:00
Martin
75657b5484
correctif(administrateur.merge): la fusion de compte entre admin devrait dissocie les services des procedures supprimées
2023-04-04 16:29:24 +02:00
Paul Chavard
2a48228552
fix(dossier): improuve commune champ rendering in pdf
2023-04-04 16:01:16 +02:00
Paul Chavard
ed33f1916a
fix(commune): to_s should always return a string
2023-04-04 15:32:03 +02:00
Paul Chavard
12f0c03bac
Merge pull request #8847 from tchak/feat-improuve-dossier-remove
...
fix(dossier): an invited user can remove (leave) a dossier
2023-04-04 13:10:18 +00:00
Paul Chavard
e2d5834dc2
Update app/models/user.rb
...
Co-authored-by: Colin Darie <colin@darie.eu>
2023-04-04 15:02:20 +02:00
mfo
2c32e38383
Merge pull request #8851 from demarches-simplifiees/fix_condtion_check_on_children
...
fix(condition_check_on_children): give proper upper tdc to child cond…
2023-04-04 08:48:02 +00:00
simon lehericey
fd927fd116
fix(condition_check_on_children): give proper upper tdc to child condition check
2023-04-04 10:24:11 +02:00
Lisa Durand
dde64415ae
Merge pull request #8845 from demarches-simplifiees/remove-dossiers-termines-from-avis-views
...
[bug] retirer les notifications + compteur des avis pour les dossiers terminés
2023-04-04 08:20:48 +00:00
Paul Chavard
0864666d0a
fix(dossier): an invited user can remove (leave) a dossier
2023-04-03 20:10:44 +02:00
Lisa Durand
2f012578eb
remove dossier termine from avis views
2023-04-03 18:20:17 +02:00
Paul Chavard
fce78bbf30
feat(dossier): multiselect without react
2023-04-03 16:54:50 +02:00
mfo
4336184fc8
Merge pull request #8833 from mfo/US/fix-valid-conditions-on-repetition
...
correctif(revision.validation-des-conditions): les conditions dans un bloc répétable ne remontenpt pas dans le composant ErrorsSummary
2023-03-31 15:03:12 +00:00
mfo
54d88e7dd0
Merge pull request #8699 from mfo/US/8661
...
a11y(bloc-repetable): amélioration des interactions avec les répétitions d'un bloc répétable
2023-03-31 14:39:23 +00:00
Martin
a53c32b41e
correctif(validation-des-conditions): les conditions dans un bloc repetable identifient les conditions invalident
...
Update app/models/procedure_revision.rb
Co-authored-by: LeSim <mail@simon.lehericey.net>
2023-03-31 16:38:27 +02:00
LeSim
b003fd8be8
Merge pull request #8774 from E-L-T/add-routing-to-groupe-instructeurs
...
Add routing rules to groupe instructeurs
2023-03-31 10:16:51 +00:00
Martin
21701a1e37
patch(demarche.lien_demarche): ignore cette colonne pr la supprimer plus tard
2023-03-31 09:57:27 +02:00
Martin
92d3f9c192
a11y(bloc-repetable.repetition): supprime une repetition via un bouton et non un lien
2023-03-31 08:51:39 +02:00
Martin
a3f1e1926a
a11y(bloc-repetable): ETQ usager qui navigue au clavier, lorsque j'ajoute un champs repetable, le focus vient sur le 1er champs du bloc repetable
2023-03-31 08:51:39 +02:00
Eric Leroy-Terquem
6f6bbd6ca1
feat(routing): put routing logic behind a feature flag
2023-03-30 10:52:53 +02:00
simon lehericey
3cede55d41
feat(routing): add routing engine
2023-03-30 10:51:20 +02:00
simon lehericey
bf737edec1
refactor: move serializer
2023-03-30 10:51:20 +02:00
simon lehericey
0ca7c805df
feat(routing): serialize routing condition
2023-03-30 10:51:20 +02:00
Eric Leroy-Terquem
3ef6adccd6
feat(db): add routing column to groupe_instructeurs
2023-03-30 10:51:20 +02:00
simon lehericey
1592006f63
feat(procedure): defaut_group_instructeur is the first created
2023-03-30 10:51:20 +02:00
Colin Darie
6ddbda34a2
fix(avis): don't list question_answer radios on empty question
2023-03-29 15:42:33 +02:00
Paul Chavard
76da68c3fb
feat(commune): prefill by postal code and insee
2023-03-28 16:34:19 +02:00
Paul Chavard
dc605015b3
feat(commune): chose commune by postal code
2023-03-28 16:34:19 +02:00
Paul Chavard
275150d727
feat(graphql): expose pendingDeletedDossiers
...
fix #8785
2023-03-22 19:40:43 +01:00
Paul Chavard
ee1df3f05f
fix(dossier): fix rebasing submitted dossiers private champs type changes
2023-03-22 11:43:08 +01:00
Lisa Durand
f27e362cae
fix validation of yes-no question in avis
2023-03-21 17:07:05 +01:00
Colin Darie
3a9b2d99e3
Merge pull request #8776 from colinux/fix-deadlocks
...
Fix: corrige peut-être des deadlocks postgresql sur le champ SIRET
2023-03-21 11:11:46 +00:00
Colin Darie
954652fcf5
fix(champ): may fix pg deadlocks: autosave already saves value at the same time
2023-03-20 14:32:14 +01:00
krichtof
da49497f0b
Merge pull request #8726 from demarches-simplifiees/disable-otp-4-super-admin
...
desactive le 2FA suivant la config
2023-03-20 10:34:27 +00:00
Lisa Durand
ee2f795dec
pr feedbacks - add validation for yes/no answer - improve locales use
2023-03-16 11:32:05 +01:00
Lisa Durand
3b3d5182bf
add new column to spreadsheets
2023-03-16 11:32:05 +01:00
Lisa Durand
a4a99a72ec
first step to add question in experts avis
2023-03-16 11:32:05 +01:00
simon lehericey
8b5d493f12
clean: log current_user in api v2, when not using token_v3
2023-03-16 10:06:23 +01:00
simon lehericey
c0ca9f156e
clean: remove unused Current.instructeur
2023-03-15 21:51:02 +01:00
simon lehericey
a984c21f64
clean: remove unused Current.administrateur
2023-03-15 21:51:02 +01:00
Paul Chavard
42e74dfc76
feat(api_token): enable fin graned access rights on tokens
2023-03-15 19:09:49 +01:00
Paul Chavard
8ee13f1719
feat(api_token): add allowed_procedure_ids and write_access
2023-03-15 19:09:49 +01:00
Paul Chavard
64f79bb6d8
feat(api_token): add allowed_procedure_ids to api tokens
2023-03-15 19:09:49 +01:00
Paul Chavard
cbaa77fca7
feat(annotations): activate autosave
2023-03-14 15:22:13 +01:00
Colin Darie
6a2a7fa2d0
Merge pull request #8753 from colinux/fix-auto-numering-in-repetition
...
Fix(dossier): ne numérote pas automatiquement les titres de section dans les répétitions
2023-03-09 15:41:57 +00:00
Colin Darie
6243e5fb92
Merge pull request #8748 from colinux/fix-clone-estimated-dossier
...
Administrateur: le clone d'une démarche ne copie pas le cache du nombre de dossiers
2023-03-09 15:25:08 +00:00
Colin Darie
f33d192142
fix(dossier): don't auto-number header sections in repetitions
2023-03-09 16:15:56 +01:00
Colin Darie
4288f28ac8
chore(job): same max_run_time between ArchiveCreationJob and ExportJob
2023-03-09 15:37:13 +01:00
Colin Darie
9e6d06fd9c
fix(job): attempt to fix a pg timeout int Cron::NotifyDraftNotSubmittedJob
2023-03-08 18:45:02 +01:00
Colin Darie
d6887f8aa4
fix(procedure): clone reset estimated_dossiers_count
2023-03-07 19:11:30 +01:00
Martin
2b99bbd836
correctif(cadastre): certaines parcelles cadastrales ne contiennent pas la surface. cf: cadastre : numero: 4120 commune: 73094 prefixe: 000 section: A à CREST VOLAND
2023-03-07 14:42:44 +01:00
Martin
5e24c0e19a
correctif(dossier.export.pdf): l'export au format pdf d'un dossier ayant un champ de type repetition contenant un titre est bien sous-sectionné
2023-03-07 07:00:28 +01:00
Colin Darie
35674838d1
Merge pull request #8720 from demarches-simplifiees/feat/8549
...
ETQ administrateur, je souhaite filtrer avec plusieurs tags
2023-03-06 10:19:22 +00:00
Colin Darie
8722ee028d
Merge pull request #8729 from colinux/fix-groupe-instructeur-wrongly-invalid
...
fix(groupe-instructeur): un groupe instructeur inactif est valide tant qu'il reste un groupe actif
2023-03-06 10:13:16 +00:00
Kara Diaby
cb0417aad4
Possibilité de selectionner plusieurs tags dans la page toutes les demarches
2023-03-03 11:50:47 +01:00
Colin Darie
20d4a8153d
fix(groupe-instructeur): a closed groupe with an active groupe is a valid record
2023-03-02 16:34:18 +01:00
Christophe Robillard
6af01077b6
disable 2FA according to config
...
2FA is disabled for superadmin unless `SUPER_ADMIN_OTP_ENABLED` is equal
to `enabled` (default value)
2023-03-02 13:47:48 +01:00
sebastiencarceles
00fa8dc895
transform value to also populate external id
2023-03-01 14:03:54 +01:00
sebastiencarceles
a7b21fcd7c
let address champ be prefillable
2023-03-01 14:03:54 +01:00
Paul Chavard
d3ef0fcf79
fix(datetime): improuve datetime field on old browsers
2023-03-01 12:30:25 +01:00
krichtof
5840c8c7f9
Merge pull request #8711 from demarches-simplifiees/8708-demarches-publiques
...
Ne pas publier le descriptif de toutes les procedures sur datagouv
2023-03-01 10:09:47 +00:00
Christophe Robillard
9ff88db48c
publish only some opendata procedures for datagouv
...
- only published or closed procedures
- only procedures with flag opendata
- only procedures with 4 or more dossiers
- only procedures without word "mail" in lien_site_web
- only procedures without word "intra" in lien_site_web
2023-02-28 17:02:08 +01:00
sebastiencarceles
f52554b5a3
review: update value with async fetch
...
1 - spec cover the job which fetches external data
2 - refactor the job with guard clauses
3 - delegate update operation to the champ itself
4 - annuaire education: override the update operation
to let the value be populated by the fetched data
5 - prefilling: don't fetch data synchronously
2023-02-28 14:53:08 +01:00
sebastiencarceles
d7bfb9dc18
enrich value from education api
2023-02-28 14:23:38 +01:00
sebastiencarceles
71f1e785ab
let annuaire education champ be prefillable
2023-02-28 13:26:35 +01:00
sebastiencarceles
a08bb1bddc
fix epci: all possible values
2023-02-28 08:37:52 +01:00
sebastiencarceles
2ae2d99e93
fix communes: all possible values
2023-02-28 08:36:43 +01:00
Colin Darie
ae93d3927e
refactor(dossier): extract sections logic in a concern
2023-02-27 17:29:22 +01:00
Colin Darie
1981bfc88e
feat(tdc): strip libelle so header section titles always start with something
2023-02-27 17:29:22 +01:00
Colin Darie
d7880f7e58
feat(dossier/pdf): header sections numbering
2023-02-27 17:29:22 +01:00
Colin Darie
3de089d6c7
fix(conditional): dynamic title counters using css
...
Closes #8086
2023-02-27 17:29:22 +01:00
sebastiencarceles
35f4874b69
allow integers only
2023-02-27 15:16:40 +01:00
sebastiencarceles
13229158bd
let dossier link champ be prefillable
2023-02-27 15:14:39 +01:00
sebastiencarceles
39545671f3
refacto: better error management
2023-02-27 14:35:11 +01:00
sebastiencarceles
33fa40eda2
don't clean the rna champ value
...
Cleaning the value is useless, when fetching the association,
as the value will be re-written by the dossier update, when the user
fills in the dossier.
Furthermore we need the value to persist when prefilling the champ.
2023-02-27 14:35:11 +01:00
Sébastien Carceles
7e55aca107
allow rna prefill
2023-02-27 14:35:11 +01:00
sebastiencarceles
7d65a34bc6
rna champ can fetch it's own association
2023-02-27 14:31:58 +01:00
Sébastien Carceles
e16f2bc39d
Merge branch 'main' into prefill/siret
2023-02-27 14:13:03 +01:00
Paul Chavard
2a6065ea31
Merge pull request #8694 from tchak/fix-filter-options
...
fix(filter): fix find type de champ by stable_id
2023-02-27 12:48:25 +00:00
sebastiencarceles
30eef3e128
review: detailled error message
2023-02-27 13:45:16 +01:00
Sébastien Carceles
2ad4e4c01f
refacto: better error management
2023-02-27 13:45:16 +01:00
Sébastien Carceles
df2eaa9542
don't clean the siret champ value
...
Cleaning the value is useless, when fetching the etablissement,
as the value will be re-written by the dossier update, when the user
fills in the dossier.
2023-02-27 13:45:16 +01:00
Sébastien Carceles
3eb76d8a43
allow siret prefilling
2023-02-27 13:45:16 +01:00
Sébastien Carceles
5876dab096
siret champ can fetch it's own etablissement
2023-02-27 13:39:31 +01:00
sebastiencarceles
da6ce0f528
add example
2023-02-27 12:20:11 +01:00
sebastiencarceles
76c9d1ada5
add possible values
2023-02-27 11:53:25 +01:00
sebastiencarceles
40b7ea3af2
transform the input value to assignable attributes
2023-02-27 11:51:24 +01:00
sebastiencarceles
46091cb6b4
let communes champ be prefillable
2023-02-27 11:50:25 +01:00
Damien Le Thiec
67bbacbb05
Merge pull request #8513 from demarches-simplifiees/feature/prefill_repetible
...
Prefill repeatable
2023-02-27 09:58:53 +00:00
Paul Chavard
531c5ec056
fix(filter): fix find type de champ by stable_id
2023-02-24 13:32:46 +01:00
Martin
fc1bb68a3a
correctif(filtres): les filtres par colonne se font par stable_id, non pas par id
2023-02-24 09:39:16 +01:00
Paul Chavard
21f47dcb01
feat(procedure): include deleted dossiers in stats
2023-02-23 17:14:25 +01:00
Paul Chavard
eb3039aeca
fix(demarche): exclude preview and deleted dossiers from stats
2023-02-23 16:38:40 +01:00
Damien Le Thiec
17f8475b07
Refacto comparaison typed id
2023-02-23 11:00:09 +01:00
Damien Le Thiec
61d2edc42e
Cache champ attributes
2023-02-22 20:05:36 +01:00
Damien Le Thiec
731cd56594
Merge branch 'main' into feature/prefill_repetible
2023-02-22 19:49:06 +01:00
Damien Le Thiec
ca29079c27
Fix rubocop
2023-02-22 19:40:52 +01:00
Damien Le Thiec
fbe4fe251a
Fix format prefill repetition
2023-02-22 19:32:25 +01:00
Paul Chavard
3c3629d151
refactor(instructeurs): add_instructeurs should add
2023-02-22 09:49:26 +01:00
Paul Chavard
fcd0f7c609
bring back find_or_create_instructeurs
2023-02-22 09:49:26 +01:00
Eric Leroy-Terquem
d0c432d939
refactor(groupe instructeur): move method to Instructeur model
2023-02-22 09:49:26 +01:00
Damien Le Thiec
2052bc7840
Remove dependency type_de_champ -> procedure
2023-02-21 16:00:58 +01:00
Christophe Robillard
c5acd82e6e
update dossiers count when passing to construction
2023-02-21 10:06:07 +01:00
Christophe Robillard
bd92291f8a
cache dossiers count
2023-02-21 10:06:07 +01:00
Martin
a89f5d373f
amelioration(procedures#filtres): filtre par regions avec un enum sur la collection des regions normalisés
2023-02-20 11:47:14 +01:00
Martin
68de0c6566
correctif(procedures#filtres): le filtre par departement ne fonctionnait plus. utilise un enum sur la collection des departements possible normalisés
2023-02-20 11:47:14 +01:00
Damien Le Thiec
d2452980fe
Fix merge conflict spec
2023-02-16 20:17:05 +01:00
Damien Le Thiec
dce4c84f9a
Merge branch 'main' into feature/prefill_repetible
2023-02-16 17:08:30 +01:00
Damien Le Thiec
6231c75e07
Fix tests conflicts
2023-02-16 16:58:55 +01:00
Paul Chavard
c0ad7853cb
fix(administrateur): procedure page n+1
2023-02-16 11:29:21 +01:00
Sébastien Carceles
8c67df7130
review: use selected options
...
Co-authored-by: Paul Chavard <paul.chavard@beta.gouv.fr>
2023-02-16 10:49:15 +01:00
sebastiencarceles
e344b97d51
review: readability
2023-02-16 10:49:15 +01:00
sebastiencarceles
d5ffd61ab6
validate values inclusion
2023-02-16 10:49:15 +01:00
sebastiencarceles
d648ac31c2
add prefill decorator for multiple drop down list
2023-02-16 10:49:15 +01:00
sebastiencarceles
cbe2dc9c2d
let the multiple drop down list be prefillable
2023-02-16 10:49:15 +01:00
Damien Le Thiec
96b9ec3f42
First fix tests
2023-02-15 18:13:16 +01:00
Damien Le Thiec
539b9e4f10
Merge branch 'main' into feature/prefill_repetible
2023-02-15 17:53:06 +01:00
Damien Le Thiec
4876d583b6
Merge branch 'main' into feature/prefill_repetible
2023-02-15 17:39:19 +01:00
Damien Le Thiec
5a89a2dbe4
Use Stable ID for repetitions prefill
2023-02-15 12:15:34 +01:00
sebastiencarceles
07b5a3b4b5
manage types de champ with multiple example values
2023-02-15 12:14:11 +01:00
sebastiencarceles
edf90a77f3
validate epci to reject incorrect prefill values
2023-02-15 12:14:11 +01:00
sebastiencarceles
5ac80f968a
add possible and example values
2023-02-15 12:14:11 +01:00
sebastiencarceles
f836f57e98
transform the input value to assignable attributes
...
Use the prefill decorator to transform the input value (for example
['01', '200042935']) into assignables attributes (for example
{ code_departement: '01', value: '200042935' }), in order to let the
champ be prefilled successfully.
2023-02-15 12:14:11 +01:00
sebastiencarceles
0f483668cf
let epci champ be prefillable
2023-02-15 12:14:11 +01:00
Paul Chavard
8b74a6f39b
fix(geometry): implement our own bbox to replace rgeo
2023-02-15 11:58:59 +01:00
Damien Le Thiec
2533ca50d4
Merge branch 'main' into feature/prefill_repetible
2023-02-15 11:07:56 +01:00
sebastiencarceles
6f65a4c2fe
🚨 line length
2023-02-14 13:49:41 +01:00
sebastiencarceles
681e1cf518
♻️ refactor possible_values impl for clarity
2023-02-14 13:45:30 +01:00
sebastiencarceles
a07446da6c
♻️ rename method for clarity
2023-02-14 11:45:39 +01:00
sebastiencarceles
0159a10969
🐛 make possible_values_list method public
2023-02-14 11:41:35 +01:00
sebastiencarceles
a77a0e2c7f
⚰️ dead code is dead
2023-02-14 11:35:35 +01:00
sebastiencarceles
67ef3a16fa
review: put example values in translation yamls
2023-02-14 09:23:52 +01:00
Sébastien Carceles
12abf9045b
add external_id and value validation
2023-02-14 09:23:11 +01:00
Sébastien Carceles
a235829ddd
add possible and example values
2023-02-14 09:19:55 +01:00
Sébastien Carceles
cd3a72ddce
make departements champ prefillable
2023-02-14 09:19:19 +01:00
mfo
76ef4ae96e
Merge pull request #8613 from colinux/email-template-subject-length
...
Email: limite le sujet généré à 100 caractères et utilise le sujet par défaut si le modèle est vide
2023-02-13 17:31:04 +01:00
Damien Le Thiec
899c8a6589
Add documentation json parse rescue repetition
2023-02-13 14:17:53 +01:00
Sébastien Carceles
1a72b80f8f
fix: "remove" a champ to prefill ( #8612 )
...
* fix: "remove" a champ to prefill
Removing a champ to prefill on /preremplir used to fail, because of a
collusion (having the same form multiple times on un page looks like a
bad idea, when it comes to multiple input fields).
* fix specs
2023-02-13 08:17:22 +00:00
Damien Le Thiec
ea126612a1
Refacto to_assignable_attributes for prefill_repetition
2023-02-12 13:02:30 +01:00
Damien Le Thiec
fc94aaaa21
Use "to_assignable_attributes"
2023-02-12 11:55:28 +01:00
Damien Le Thiec
4a6841c009
Fix linter
2023-02-11 22:51:37 +01:00
Damien Le Thiec
dbb92e7fd3
Merge branch 'main' into feature/prefill_repetible
2023-02-11 22:40:56 +01:00
Damien Le Thiec
2a3ba28343
Fix tests possible value prefill
2023-02-11 22:27:16 +01:00
Damien Le Thiec
a4d707f942
Improve format prefill possible_values (tests missing)
2023-02-09 18:08:51 +01:00
Colin Darie
aeb602a63d
fix(mail): default subject fallback when subject template is empty
...
Closes #8448
2023-02-09 17:49:43 +01:00
Damien Le Thiec
4b0e6ea382
Convert datetime field to datetime_local ( #8572 )
...
* Convert datetime field to datetime_local
* Fix tests
* Add value formatting view datetime component
* Add helper datetime component value
2023-02-09 15:18:38 +01:00
Colin Darie
e626eb69ce
feat(admin): import groupe instructeurs csv when procedure is closed
2023-02-09 11:17:13 +01:00
Colin Darie
a4329b6699
chore(export/job): set procedure_id for sentry
2023-02-09 11:06:54 +01:00
Damien Le Thiec
c5f1f80d25
Add prefill params tests repetition
2023-02-08 17:38:51 +01:00
Paul Chavard
1693e46acb
fix(dossier): prevent crash when updating champs in rebase
2023-02-08 14:56:26 +01:00
Colin Darie
0958053c72
chore(dossier): can destroy dossier having dossier_batch_operations
...
Ça peut arriver lors des démarches en test, avec des dossiers tests
en cours d'instruction.
2023-02-08 14:42:14 +01:00
Paul Chavard
dc9a455d22
fix(dossier): prevent crash in rebase
2023-02-08 11:11:14 +01:00
Kara Diaby
984ef67827
Prend en compte uniquement les procédures publiées dans les propositions de tags
2023-02-06 17:03:51 +01:00
Paul Chavard
6924b8e46d
feat(dossier): optional repetition champ should not add first row
2023-02-06 11:53:32 +01:00
Martin
f4cc8078b4
amelioration(EmailEvent): purge les email_events vieux de plus de un mois
...
Update app/models/email_event.rb
Co-authored-by: Colin Darie <colin@darie.eu>
Update app/jobs/cron/purge_old_email_event_job.rb
Co-authored-by: Colin Darie <colin@darie.eu>
2023-02-06 10:35:57 +01:00
Martin
6a25120f80
amelioration(dolist_api): echoue avec un fail pour remonter dans notre gestion des retry
2023-02-03 17:19:36 +01:00
Martin
2de9026c13
amelioration(dolist_api): forward le message_id afin de faciliter les investigations
2023-02-03 17:19:36 +01:00
Damien Le Thiec
63e7c17fda
First tests for prefill repetition
2023-02-03 12:14:18 +01:00
Paul Chavard
2971100081
fix(dossier): do not try to rebase if procedure is not published
2023-02-02 10:11:46 +01:00
Lisa Durand
3a82558c3f
use super instead of run_at
2023-02-01 17:06:04 +01:00
Lisa Durand
120fbb0ef7
Overload the finished_at
2023-02-01 17:06:04 +01:00
Lisa Durand
d0a131dc55
change the way we set the finished_at on batch operation job to fix alert display bug
2023-02-01 17:06:04 +01:00
Damien Le Thiec
e7c78321d9
Fix new failing tests
2023-02-01 13:35:32 +01:00
Colin Darie
eb9cd90ee8
chore(schema): +procedure#estimated_duration_visible
2023-02-01 11:02:55 +01:00
Paul Chavard
9c83939431
fix(dossier): fix adding repetition in a new revision
2023-02-01 10:36:46 +01:00
Eric Leroy-Terquem
b306dea5cf
refactor(avis): rename revive by remind
2023-02-01 09:55:46 +01:00
Eric Leroy-Terquem
004bf5be38
feat(avis): add remind_by! method
2023-02-01 09:55:46 +01:00
Damien Le Thiec
5a7b740f58
Clean rubocop alerts
2023-01-31 17:06:00 +01:00
Damien Le Thiec
4a07fd6223
Merge branch 'main' into feature/prefill_repetible
2023-01-31 16:49:40 +01:00
Damien Le Thiec
e1748a2666
Fix "see more" link for prefillable fields
2023-01-31 16:48:38 +01:00
Damien Le Thiec
d7b01255fe
Merge branch 'main' into feature/prefill_repetible
2023-01-31 16:39:00 +01:00
Martin
2edfcdd652
correctif(liens.invitations): utilise le mapping rails as: :target_model, sinon on requete uniquement par l'id du model, qui peut etre problématique en cas de relation polymorphiques avec des ensembles d'id se superposant
2023-01-31 16:33:31 +01:00
Damien Le Thiec
f91cc05d95
Small fix link to prefill type de champ
2023-01-31 16:24:32 +01:00
Damien Le Thiec
20ba96ba3c
POST working with prefill query example for repeating fields
2023-01-31 14:54:23 +01:00
Martin
88553eec9b
correctif(dossier_transfer): le transfer de dossier vers un email contenant des majuscule ne fonctionnait pas
2023-01-31 14:52:57 +01:00
Colin Darie
5cddb1c74e
fix(procedure_presentation): options groupe_instructeur for that procedure only
2023-01-31 13:55:06 +01:00
Paul Chavard
dcbe16603a
fix(dossier): fix parser with dashes
2023-01-31 10:40:48 +01:00
Paul Chavard
ca05fb753b
fix(only_present_on_draft?): broken when type_de_champ is removed from later revisions
2023-01-31 09:26:50 +01:00
Martin
dbe64cf0c8
correctif(date_champ): renforce la validation avec le parsing de la date plutot qu'une approche par regexp
2023-01-30 13:01:24 +01:00
Paul Chavard
6cacfbdf32
refactor(dossier): refactor rebase
2023-01-30 12:01:11 +01:00
Paul Chavard
2f4e85f163
fix(dossier): set rebased_at only on changed champs
2023-01-30 12:01:11 +01:00
Paul Chavard
626b28ca16
perf(tags parser): improuve parser perf
2023-01-30 11:52:35 +01:00
Eric Leroy-Terquem
1b67f93c66
feat(avis): add reminded_at field to avis
2023-01-30 11:13:23 +01:00
Paul Chavard
298721f90d
fix(dossier): fix clone with data
2023-01-30 10:58:26 +01:00
Damien Le Thiec
81df033282
First draft repeatable
2023-01-26 17:57:57 +01:00
Colin Darie
923ee59e92
refactor(instructeurs/perf): don't load anymore geo areas for each champ because of header
...
Economise 1 requête par champ sur chaque page instructeur d'un dossier
à cause du header juste pour savoir s'il faut afficher
le bouton d'export GeoJSON.
2023-01-26 14:57:45 +01:00
Paul Chavard
508cdec33f
fix(morph): ids should not start with numbers
2023-01-26 10:42:22 +01:00
Colin Darie
51c1736d00
refactor(conditional): extract in a ChampConditionalConcern with tests
2023-01-26 09:06:30 +01:00
Colin Darie
7c13449b4f
feat(conditional): show loader during autosave when other champs are dependent of it
2023-01-26 09:06:30 +01:00
Colin Darie
81f00774af
feat(logic): operators sources
2023-01-26 09:06:30 +01:00
Kara Diaby
b18d76dff6
Ne prend pas en compte les tags sur les démarches en brouillon
2023-01-24 14:53:27 +01:00
Sébastien Carceles
49ce255e29
feat(dossier): prefill region champ ( #8442 )
...
* make regions champ prefillable
* add possible and example value
* add external_id and value validation
2023-01-24 11:25:17 +00:00
mfo
84a667b8bd
Merge pull request #8454 from tchak/feat-epci
...
feat(types de champ): add EPCI champ
2023-01-23 16:56:18 +01:00
Sébastien Carceles
92c769de4f
fix(prefill): code pays display ( #8477 )
...
* show translated text AND possible values
* show less possible values
* show countries possible values
2023-01-23 14:08:20 +00:00
Paul Chavard
a4cbbe721e
feat(types de champ): add EPCI champ
2023-01-20 11:32:36 +01:00
Paul Chavard
f38ee8f03f
feat(dossier): implement refresh_after_update on champs
2023-01-20 11:05:25 +01:00
Sébastien Carceles
0046338e6a
fix(prefill): don't mark the dossier as prefilled when it's not ( #8464 )
...
A dossier should not be marked as prefilled when it's not, meaning
when no prefill params are given.
2023-01-19 10:51:56 +00:00
Colin Darie
428dd9bf1a
fix(dossier): we can't terminer any dossier having etablissements in degraded mode
...
Closes #8449
2023-01-18 19:23:25 +01:00
Kara Diaby
eac5a42a32
model
2023-01-18 18:46:42 +01:00
Damien Le Thiec
3a8a50a216
Allow prefill pays type de champs ( #8344 )
...
* Allow prefill pays type de champs
* Avoid conditional prefil params for pays champ
* Clean pays data with batch update
* Fix bug and add test batch update pays value
* Improve performance batch_update_pays
* Fix associated country code problem
* Fix after party task name
* Format country name if needed in batch update
2023-01-18 12:52:38 +01:00
Colin Darie
784b0458fe
feat(dolist): consolidate dispatched events with delivered emails
2023-01-18 09:56:40 +01:00
Sébastien Carceles
5c7b2ba1f3
feat(dossier): prefill drop down list champ ( #8361 )
...
* feat(dossier): prefill drop down list champ
* decorate the types de champ to avoid if / else
In order to avoid doing if this a drop down ? / else at several places,
we decorate the types de champ and let the decorator give the possible
and example values.
* show all possible values when there are too many
* allow to prefill 'other' option
* review: remove duplicate
* review: refactor for readability
* validate that value is in options
* review: exclude disabled options
2023-01-18 09:47:22 +01:00
Colin Darie
ef3546e9f1
fix(email-event): apparently mail subject could be null
2023-01-17 16:46:54 +01:00
Colin Darie
13479fc88e
fix(admin): display of procedure admins count
2023-01-17 16:02:08 +01:00
Paul Chavard
dad393355b
chore(db): remove unused columns
2023-01-17 12:49:22 +01:00
Paul Chavard
44488c7014
feat(dossier): use select in filters bygroupe instructeur
2023-01-16 14:00:08 +01:00
Lisa Durand
06c6a4ab0c
add action 'unfollow' to page 'suivis'
2023-01-16 11:14:29 +01:00
Lisa Durand
2f666b487e
add action 'repasser en construction' to page 'suivis'
2023-01-16 11:14:29 +01:00
Damien Le Thiec
5e26acb0e1
Make date and datetime prefillable ( #8304 )
...
* Make date and datetime prefillable
* Format in ISO8601 format
2023-01-12 17:42:02 +01:00
Paul Chavard
5641c2b078
fix(groupe_instructeur): only show to administrators the number of visible files
2023-01-11 21:49:08 +01:00
Martin
822eda7c42
correctif(safe_mailer): fix bug sur de la synthax
2023-01-11 20:29:51 +01:00
Martin
3e6b82ed9e
amelioration(safe_mailer): ajoute au manager la fonction pour configurer le routage des mails sur un fournisseur unique
...
Update app/mailers/devise_user_mailer.rb
Co-authored-by: LeSim <mail@simon.lehericey.net>
2023-01-11 17:32:24 +01:00
Martin
2f43ffc940
data(safe_mailer): ajout d'un object permetant d'orienter les mails vers un unique fournisseur au cas ou l'autre soit down
2023-01-11 17:13:05 +01:00
simon lehericey
528b2c2b88
fix(procedure): valid juridique on create and publication
2023-01-11 14:05:17 +01:00
simon lehericey
bd3fbbce49
add schema and annotation
2023-01-11 11:19:24 +01:00
Paul Chavard
afc1f12028
feat(graphql): implement add/remove instructeurs via API
2023-01-10 20:33:35 +01:00
Paul Chavard
af33d5d65c
refactor(repetition): use row_id instead of row
2023-01-10 19:31:41 +01:00
Colin Darie
d58e6a2f9c
refactor(email): remove pseudonymization, it will be done at dump-time
2023-01-10 16:07:35 +01:00
Colin Darie
5ae5de0d9c
refactor(email): log event when error occurs before recipients was set
2023-01-10 16:07:35 +01:00
Colin Darie
0a22c1d2f0
chore(email): log smtp errors
2023-01-10 16:07:35 +01:00
Colin Darie
6cb2389eef
chore(email): add an observer which log the emails dispatched
2023-01-10 16:07:35 +01:00
Colin Darie
07167cead9
chore(schema): create email_events
2023-01-10 16:07:35 +01:00
Colin Darie
0a890acc33
fix(conditional): huge perf improvement by caching champ visibility
...
Hyper nécessaire lorsqu'il y a des champs qui dépendent d'autres champs
en cascade.
Co-authored-by: simon lehericey <mail@simon.lehericey.net>
Co-authored-by: mfo <martin@sharypic.com>
2023-01-10 11:41:08 +01:00
Paul Chavard
5128b9a086
refactor(demarches): use turbo_stream template
2023-01-10 09:48:32 +01:00
Lisa Durand
67c104c8eb
affiner le scope
2023-01-09 11:58:51 +01:00
Lisa Durand
25a7fa5a34
add bulk action 'follow'
2023-01-09 11:58:51 +01:00
Paul Chavard
5a4cefc5c5
fix(dossier): fix rebase with drop down options
2023-01-06 14:15:46 +01:00
Sébastien Carceles
06b8a0f734
feat(dossier): prefill boolean champs ( #8381 )
2023-01-06 14:01:59 +01:00
Paul Chavard
dfe65136be
refactor(repetition): add row_id to champs
2023-01-05 18:04:54 +01:00
Paul Chavard
940f8c0474
fix(graphql): fix departements with alphanumeric codes
2023-01-05 17:33:03 +01:00
Lisa Durand
4afb873afc
feedbacks from Martin
2023-01-05 16:20:18 +01:00
Lisa Durand
59468fe351
add justificatif_motivation field to batch operation accepter
2023-01-05 16:20:18 +01:00
Lisa Durand
1bc0609543
add motivation field to batch operation accepter
2023-01-05 16:20:18 +01:00
Lisa Durand
d7ebb67889
implement first step - accepte without motivation and PJ
2023-01-05 16:20:18 +01:00
Paul Chavard
378f3c5fb0
use join table instead of arrays
2023-01-05 16:20:18 +01:00
Paul Chavard
26e02c7173
fix(template): trix will transform double spaces in
2023-01-05 13:23:24 +01:00
Sébastien Carceles
fa6fc077b4
normalize boolean values ( #8320 )
...
* extract parent for yes no and checkbox champs
* checkbox stores true / false instead of on / off
* normalize blank value to nil
* normalize invalid value to false
* after party task: normalize checkbox values
* after party task: normalize yes_no values
2023-01-05 11:18:27 +00:00
Paul Chavard
c4a30084fe
refactor(virus_scan): remove lock
2023-01-04 12:12:11 +01:00
Paul Chavard
6e18090fb3
refactor(virus_scan_result): use column instead of metadata on blob
2023-01-04 12:12:11 +01:00
Paul Chavard
d469bca0ae
refactor(watermark): use column instead of metadata on blob
2023-01-04 12:07:08 +01:00
Sébastien Carceles
456be420fa
feat(demarche): describe dossier prefilling with POST ( #8298 )
...
* feat(demarche): describe dossier prefilling with POST
* show response example
2023-01-04 07:31:31 +00:00
Martin
76301d4c32
correctif(api_entreprise_token): les nouveaux tokens stockent les roles dans sous la clé scopes et non plus roles
2023-01-03 15:32:50 +01:00
Sébastien Carceles
20136b7ac8
feat(demarche): create and prefill a dossier with POST request ( #8233 )
...
* add base controller for public api
* add dossiers controller with basic checks
* create the dossier
* ensure content-type is json
* prefill dossier with given values
* mark a dossier as prefilled
When a dossier is prefilled, it's allowed not to have a user.
Plus, we add a secure token to the dossier, which we will need later to set a
user after sign in / sign up.
* set user as owner of an orphan prefilled dossier
When a visitor comes from the dossier_url answered by the public api,
the dossier is orphan:
- when the user is already authenticated: they become the owner
- when the user is not authenticated: they can sign in / sign up / france_connect
and then they become the owner
So here is the procedure:
- allow to sign in / sign up / france connect when user is unauthenticated
- set dossier ownership when the dossier is orphan
- check dossier ownership when the dossier is not
- redirect to brouillon path when user is signed in and owner
* mark the dossier as prefilled when it's prefilled
(even with a GET request, because it will be useful later on, for
exmample in order to cleanup the unused prefilled dossiers)
* system spec: prefilling dossier with post request
2023-01-03 14:46:10 +01:00
mfo
1f5db1faf2
Merge pull request #8340 from mfo/US/fix-champs-pays
...
sentry(3830513995): champs pays peut avoir un external_id a '', test la presence d'external_id sinon on peut renvoyer du nil via Champs::PaysChamp.name
2022-12-28 09:51:18 +01:00
Martin
a2d3ec7a21
sentry(3830513995): champs pays peut avoir un external_id a '', test la presence d'external_id sinon on peut renvoyer du nil via Champs::PaysChamp.name
2022-12-27 16:28:34 +01:00
mfo
31735e16d8
Merge pull request #8339 from mfo/US/fix-departement-champs
...
Us/fix departement champs
2022-12-27 16:01:35 +01:00
Martin
186d4e6539
correctif(ChampDepartement): gere les departement a 3 codes
2022-12-27 14:55:57 +01:00
Paul Chavard
9b3fa4dd3c
refactor(revision): changes should be domain objects
2022-12-27 10:58:53 +00:00
Martin
48c80e9387
correctif(api/v1): ajoute la methode manquante for_api sur le type de champs departement
2022-12-27 11:45:43 +01:00
Martin
3732c079a7
correctif(champ.normalize): enleve les null chars uniquement si il y en a. sinon on rappel value=() avec nos champs surchargeant ce setter
2022-12-27 11:43:34 +01:00
Paul Chavard
0b10c73bcf
feat(prefill): allow to prefill private annotations
2022-12-26 22:14:17 +00:00
Paul Chavard
4a4ce67ef6
fix(dossier): explicitly send draft notification email
2022-12-26 22:02:33 +00:00
Damien Le Thiec
9e083ea3f7
Merge branch 'main' into feature/prefill_civility
2022-12-26 11:31:52 +01:00
mfo
62813f3d74
Merge pull request #8323 from tchak/fix-graphql-champs
...
feat(graphql): add pays champ to API
2022-12-22 13:51:02 +01:00
mfo
e3bf0d8fec
Merge pull request #8327 from tchak/feat-rebase-after-repasser-en-instruction
...
feat(dossier): rebase after repasser en instruction
2022-12-22 13:50:43 +01:00
Paul Chavard
f4f38982b4
feat(dossier): rebase after repasser en instruction
2022-12-22 13:44:03 +01:00
Paul Chavard
6363206c44
fix(dossier): when rebase creates a champ always push in to champs
2022-12-22 13:44:03 +01:00
Paul Chavard
4c516a6991
feat(dossier): allow to rebase champs with value made mandatory
2022-12-22 13:08:04 +01:00
Paul Chavard
072156d38e
feat(graphql): add pays champ to API
2022-12-22 11:56:45 +01:00
Paul Chavard
bd9fe7eb7c
feat(export): add pays, region and departement codes
2022-12-21 14:03:02 +01:00
Paul Chavard
3f0f5e381f
refactor(regions): champ regions to use simple select
2022-12-21 14:03:02 +01:00
Paul Chavard
e0b0a42bc3
refactor(departements): champ departements to use simple select
2022-12-21 14:03:02 +01:00
Paul Chavard
f7c1dff22a
refactor(pays): champ pays to use simple select
2022-12-21 14:03:02 +01:00
François Vantomme
993c1b8676
fix(batch operation): ensure to append bigint to SQL array
2022-12-21 11:59:55 +01:00
Christophe Robillard
11a18516b2
remove feature flag zonage
2022-12-21 09:02:16 +01:00
Paul Chavard
227296682b
fix(dossier): clone should include more attachments
2022-12-20 21:30:32 +01:00
Colin Darie
c673950e56
fix(instructeurs): behavior of sort by notifications checkbox (updated_at desc)
2022-12-20 15:51:47 +01:00
Damien Le Thiec
c4e427642f
Allow prefill civility
2022-12-20 14:38:05 +01:00
Sébastien Carceles
e4a7a4c391
hide values and examples for unprefillable champs ( #8309 )
...
* hide values and examples for unprefillable champs
* put prefillable champs first
2022-12-20 13:37:25 +00:00
Sébastien Carceles
dd0a05c1d8
feat(prefill): add possible values ( #8299 )
...
* update layout in order to show possible values
* filter out non fillable types de champ
2022-12-20 11:04:42 +01:00
Sébastien Carceles
0a10a08c21
feat(demarche): describe procedure prefilling ( #8187 )
...
* feat(demarche): description
Show the description of an opendata procedure (published or draft),
with help about how to prefill a dossier for this procedure.
Co-authored-by: Damien Le Thiec <damien.lethiec@gmail.com>
2022-12-19 11:32:09 +00:00
Martin
dd74834689
amelioration(attestation.et.mail): desactive les tags sur les champs conditionnés et informe l'usager que ca arrivera
2022-12-19 09:28:46 +01:00
Christophe Robillard
f1595d1f50
wrap resultset tuples in ProcedureDetail
2022-12-16 15:51:49 +01:00
Christophe Robillard
3a660349ad
export all demarches
2022-12-16 15:51:49 +01:00
Eric Leroy-Terquem
2645ac85f7
update wording and order in types de champ select
2022-12-16 09:30:36 +01:00
Paul Chavard
cb5b60ccda
Revert "Revert "Merge pull request #7907 from tchak/feat-cond-repetitions""
...
This reverts commit 0d10d36cb0
.
# Conflicts:
# app/models/dossier.rb
# app/models/dossier_preloader.rb
2022-12-15 19:09:25 +01:00
Sébastien Carceles
b8ff0ba4a2
feat(demarche): sign up when prefilling a dossier ( #8247 )
...
* store prefill params in session
Instead of using query params on /dossier/new, we assume the user comes
from /commencer/:path, which is the new prefill link.
There, we store the prefill params in session, and use them to prefill
the dossier when creating it, in /dossiers/new.
* spec: cover the case
* review: serialize with json instead of yaml
* review: rename method
* review: store only query params
* review: comment why we dont override already stored params
2022-12-15 10:58:17 +01:00
Lisa Durand
89730b485b
add bulk action feature for 'passer_en_instruction'
2022-12-15 10:04:25 +01:00
Colin Darie
7ff04c1a05
style(instructeurs): human/i18n value for state filter
2022-12-15 09:34:10 +01:00
mfo
74cd385b35
Merge pull request #8274 from tchak/fix-parent-dossiers
...
fix(dossier): parent_dossiers is really cloned_dossiers
2022-12-15 09:20:10 +01:00
Paul Chavard
243a8301bb
fix(dossier): authorize passage en instruction if auto archive is on and is in the past
2022-12-14 22:16:13 +01:00
Paul Chavard
59bdd4bd92
fix(tags): relax parser roules
2022-12-14 17:53:36 +01:00
Paul Chavard
9149e0fcd7
feat(revision): allow more dossiers to rebase
2022-12-14 17:42:27 +01:00
Paul Chavard
1b95809f14
refactor(dossier): flatten champ attributes
2022-12-14 13:03:06 +01:00
Paul Chavard
0d10d36cb0
Revert "Merge pull request #7907 from tchak/feat-cond-repetitions"
...
This reverts commit 1900f8ff4c
, reversing
changes made to febffc2d64
.
# Conflicts:
# app/models/dossier.rb
2022-12-14 11:25:45 +01:00
Paul Chavard
ece70efbea
refactor(dossier): improuve dossiers_safe_scope on batch operation
2022-12-14 09:45:53 +01:00
Paul Chavard
9510142cd8
fix(dossier): parent_dossiers is really cloned_dossiers
2022-12-14 09:44:19 +01:00
Paul Chavard
7929b7d0d7
clean(api_token): remove administrateur token support
2022-12-08 17:35:21 +01:00
sebastiencarceles
69d61913f5
review: unauthorize complex champs
2022-12-08 15:27:39 +01:00
sebastiencarceles
bf03e3b35a
review: prefix typed ids with 'champ_'
2022-12-08 15:27:39 +01:00
sebastiencarceles
11fed2c934
review: champs exist because stable ids exist
2022-12-08 15:27:39 +01:00
sebastiencarceles
a5c1c68a91
review: style
2022-12-08 15:27:39 +01:00
Sébastien Carceles
9dfb498806
review: prefer if to unless
...
Co-authored-by: LeSim <mail@simon.lehericey.net>
2022-12-08 15:27:39 +01:00
Damien Le Thiec
006a1257b5
Refacto prefill_params construction (remove merge)
2022-12-08 15:27:39 +01:00
sebastiencarceles
373e8aeadb
review: validate prefilled champs only
2022-12-08 15:27:39 +01:00
sebastiencarceles
1e21a3d3e1
review: query the db only once
2022-12-08 15:27:39 +01:00
sebastiencarceles
ab30af5fe5
review: move Prefillable to concern directory
2022-12-08 15:27:39 +01:00
sebastiencarceles
3939644030
validate prefilled champs when editing brouillon
2022-12-08 15:27:39 +01:00
sebastiencarceles
79ef48cafb
make the dossier prefillable
2022-12-08 15:27:39 +01:00
sebastiencarceles
f4e1a09e73
prepare prefilled values from ctrl params
2022-12-08 15:27:39 +01:00
sebastiencarceles
24802985a2
feat(dossier): prefill dossier from query params
2022-12-08 15:27:39 +01:00
Paul Chavard
52a32051c4
feat(dossier): add dossier.champs_public_all
2022-12-08 09:38:12 +01:00
Paul Chavard
6ce7064ffd
feat(dossier): add repetition champs to champs_for_condition
2022-12-08 09:38:12 +01:00
simon lehericey
86cda6a0b9
fix(timestamp spec): rewind io after before_save check
2022-12-07 19:28:01 +01:00
Paul Chavard
ebbada752f
feat(api_token): add APIToken model
2022-12-07 18:19:37 +01:00
Paul Chavard
4fe081e4be
fix(dossier): send notifications on declarative dossiers
2022-12-07 13:14:59 +01:00
Paul Chavard
bb47e8d2ab
fix(dossier): dossier.repasser_en_construction! should take disable_notification
2022-12-07 13:14:59 +01:00
Colin Darie
f4d403a81c
fix(apiv1): piece_justificative continue to returns a single attachment
2022-12-06 15:47:06 +01:00
Martin
2eaa06b22b
correctif(export.pjs): sur l'export, les champs de type piece justificative renvoyent un tableau de la meme dimension quelque soit le nombre de pj joint
2022-12-06 15:22:53 +01:00
Paul Chavard
b8a9b7223c
refactor(groupe_instructeur): improuve controller
2022-12-06 12:01:54 +01:00
Paul Chavard
9fe93ded7f
refactor(groupe_instructeur): add instructeur.find_or_invite
2022-12-06 12:01:54 +01:00
Colin Darie
4ba76e6844
fix(api-v1): dossier -> avis -> piece_justificative_file_attachment relation name
2022-12-06 11:48:42 +01:00
Paul Chavard
ed4d5cb36a
refactor(demarche): make declarative demarche processing syncroneous
2022-12-06 11:41:25 +01:00
Martin
91ef618a42
clean(code): stick to usage of present?/empty? instead of count zero etc
2022-12-06 11:28:48 +01:00
Martin
b5f69c8961
review(dossier.reload): evite de recharger le batch qui peut etre confusant
2022-12-06 11:28:48 +01:00
Martin
7c65af3be0
poc(batch_operation_alert): simplier wording
2022-12-06 11:28:48 +01:00
Martin
ea8bd13bcf
poc(batch_operation.purge): nettoie les batch terminé ou inutiles
2022-12-06 11:28:48 +01:00
Lisa Durand
1beb219fdd
display batch operation alerts
2022-12-06 11:28:48 +01:00
Martin
e5944eed34
poc(batch_operation): habtm groupe instructeurs, permettra de visualiser plus facilement les batch en cours pour les instructeurs du meme groupe
2022-12-06 11:28:48 +01:00
Martin
eaf72162da
poc(batch_operation): some rewrite to avoid various conflict (when an instructeur try to create a job with an incompatible dossier regarding the current task). also soome cleanup to isole spec in least involved model
2022-12-06 11:28:48 +01:00
Martin
4266ab93c5
poc(batch_operation): track dossier processed safely
2022-12-06 11:28:48 +01:00
Martin
beb39027d0
poc(batch_operation.ui): implement simple ui to trigger a batch of current page
2022-12-06 11:28:48 +01:00
Martin
7df86c50fb
poc(batch_operations_controller): implement simple [not yet with procedure_presentation] action to create a batch operation
2022-12-06 11:28:48 +01:00
Martin
b11dbafc59
poc(batch_operation_job): implement archive dossiers with async behaviour, lock, run_at, finished_at, failed_dossier_ids, success_dossier_ids
2022-12-06 11:28:48 +01:00
Martin
61f4cded75
poc(batch_operation): just the model and some specs and a poc for archive them without async
2022-12-06 11:28:48 +01:00
Colin Darie
b13c5e56f6
refactor(piece_justificative): UX follows mockups
2022-12-05 10:47:10 +01:00
Colin Darie
0014ce4b91
chore(schema): +procedures#piece_justificative_multiple
2022-12-05 10:47:10 +01:00
Colin Darie
b8296c6d4d
feat(piece_justificative): supports multiple files
...
Closes #7924
2022-12-05 10:47:10 +01:00
Colin Darie
91f4971df2
feat(champ): has_one_attached => has_many_attached piece_justificative_file
2022-12-05 10:47:10 +01:00
Paul Chavard
ece68076a7
feat(dossier): add some metadata to archive and remove operation log
2022-11-30 16:20:13 +01:00
Paul Chavard
a90dada104
fix(patron): dossier should have a procedure and champ should delegate to dossier
2022-11-30 10:54:03 +01:00
Paul Chavard
1fb051c3cc
refactor(attestation_template): remove unused code
2022-11-29 19:36:56 +01:00
Paul Chavard
06f43f99d0
fix(dossier): excluded deleted dossiers from demarche overview
2022-11-29 16:41:31 +01:00
simon lehericey
dcae06ae84
fix(avis_controller): index do not linked to revoked avis
2022-11-29 16:21:06 +01:00
simon lehericey
f96a7f432c
clean(dossier): useless method
2022-11-29 15:33:10 +01:00
Paul Chavard
53eb3e6ad0
chore(dossier): cleanup champs nested attributes
2022-11-29 11:10:59 +01:00
Paul Chavard
a760e0a698
feat(demarche): enable revisions for all
2022-11-24 17:35:33 +01:00
Paul Chavard
7a35a253a0
chore(dossier): cleanup clone champ
2022-11-24 16:25:27 +01:00
Christophe Robillard
1003a24711
remove useless spaces
2022-11-24 15:05:46 +01:00
Christophe Robillard
3539b00652
search admins by email
2022-11-24 15:05:46 +01:00
Paul Chavard
234975b806
feat(graphql): expose groupe_instructeur state and update mutation
2022-11-24 14:33:29 +01:00
Paul Chavard
405d2a695f
refactor(attestation_template): remove from revisions
2022-11-23 12:26:26 +01:00
Paul Chavard
c73b650f85
feat(attestation): validate attestation tags
2022-11-23 12:26:26 +01:00
Paul Chavard
cafda4f6f0
refactor(attestation_template): move to procedure
2022-11-23 12:26:26 +01:00
Paul Chavard
c0fd080d0e
refactor(operation_log): store data in jsonb instead of files
2022-11-22 18:06:05 +01:00
Paul Chavard
e4bf1bd2db
feat(dossier): add data to DossierOperationLog
2022-11-22 18:06:05 +01:00
Christophe Robillard
8e95c6a2ba
search procedures by libelle
2022-11-22 17:08:17 +01:00
simon lehericey
4babee2591
fix(admin): ignore active column
...
the attribut should be retrieve from the user model as the administrateur is no more a devise model
2022-11-22 16:41:20 +01:00
simon lehericey
fe35a8a6e7
fix(cni): only allow jpg and png because of buggy pdf watermarking
2022-11-21 17:53:29 +01:00
Lisa Durand
3953470c78
remove change on api V1 and update graphql for sensitive data
2022-11-18 11:15:16 +01:00
Lisa Durand
f34c890278
add a label for api and export for sensitive data as titre_identite_champ
2022-11-18 11:15:16 +01:00
Paul Chavard
0c0618aa79
feat(export): add GeoJSON export
2022-11-18 10:04:35 +01:00
simon lehericey
66e9b74121
feat(manager): select team_user base on attribute
2022-11-17 16:29:08 +01:00
Paul Chavard
29bdd82b59
refactor(procedure): types_de_champ -> active_revision.types_de_champ_public
2022-11-17 13:54:14 +01:00
simon lehericey
9ed42b316f
refactor(user): administration -> super_admin
...
delete_and_keep_track_dossier_also_delete_user is only called by super admin
2022-11-16 17:52:48 +01:00
simon lehericey
99871b6ba6
refactor(user): introduce method to only delete dossier
2022-11-16 17:52:47 +01:00
simon lehericey
fcfe09f05a
refactor(user): rename delete_and_keep_track_dossiers
2022-11-16 17:52:47 +01:00
Paul Chavard
6f6b3896de
refactor(export): reduce repetition in export code hopefully making it more readable
2022-11-16 08:49:37 +01:00
Paul Chavard
c1ae9d03be
feat(export): show refresh button sooner
2022-11-16 08:49:37 +01:00
Martin
18b7f4e4fa
remaniement(dossier.clone): simplifications, pas de callback/after, pas d'heritage, mm interface pour cloner les champs public/prive, clonage des PJs avec le nouveau service de clone, ajoute une cle etrangere sur la colonne parent_dossier_id
2022-11-14 09:53:19 +01:00
Martin
90f7d265c6
amelioration(clone.piece_justificative): gestion du clonage des piece justificative dans une tache asynchrone
2022-11-14 09:13:54 +01:00
Martin
844004818a
amelioration(dossier.clone): dossier.clone, permet de cloner un dossier
2022-11-14 09:13:52 +01:00
Paul Chavard
e6288c39f2
refactor(dossier): champs -> champs_public
2022-11-10 22:44:39 +00:00
Christophe Robillard
cc35788d26
extract computation to controller
2022-11-10 18:02:20 +01:00
Christophe Robillard
5f5b6bf7c7
use specific route for all admins
2022-11-10 18:02:20 +01:00
Christophe Robillard
c96781cfad
list all admins
2022-11-10 18:02:20 +01:00
Paul Chavard
95f65900d3
refactor(active_storage): no download on clone
2022-11-10 12:25:55 +00:00
Paul Chavard
5e87539d6d
fix(groupe_instructeur): add explicit order to groupe_instructeurs
2022-11-09 10:56:40 +00:00
Christophe Robillard
87832f6eb2
fix pagination bug
2022-11-09 10:41:06 +01:00
Christophe Robillard
a5fa21ca1b
add from_publication_date filter
2022-11-09 10:41:06 +01:00
Martin
b3f80dc5f9
amelioration(Procedure.revision_changes): ajout du support pour les texte complementaire affichable au clique des champs de type explication
...
Co-authored-by: Paul Chavard <github@paul.chavard.net>
2022-11-08 17:49:24 +01:00
Martin
df54dc04a4
amelioration(champ.explication): ajout du support pour avoir un menu depliant avec plus d'information sur un champs explication
...
amelioration(champ.explication): ajout du support pour avoir un menu depliant avec plus d'information sur un champs explication
2022-11-08 17:49:24 +01:00
Martin
fe0411203f
amelioration(types_de_champ/editor): en mode edition d'un champ de type explication, permet de choisir d'afficher ou pas cette explication derriere un collapse
2022-11-08 17:49:24 +01:00
Martin
0d675d4ee5
amelioration(Champ.titre-d-identite): ajout du support pour les .pdf
2022-11-08 16:27:06 +01:00
Christophe Robillard
c0231dffa2
extract ProceduresFilter class
2022-11-08 12:14:26 +01:00
Martin
bd28c29856
amelioration(manager): ajout de la visualisation des comptes marqués comme membre de l'equipe
2022-11-08 09:55:21 +01:00
Martin
c9292e7ba8
amelioration(bdd): mise en place d'un flag pour identifier les anciens comptes d'admin de DS
2022-11-08 09:55:21 +01:00
simon lehericey
1760ccbc01
fix(merge): transfers hidden procedures
2022-11-07 14:11:05 +01:00
Paul Chavard
1e8a440166
feat(graphql): expose deleted dossiers on groupe instructeur
2022-11-04 11:49:27 +00:00
Eric Leroy-Terquem
aca2775874
remove routee? method
2022-11-04 12:03:44 +01:00
Eric Leroy-Terquem
b51770c151
toggle routing after groupe instructeur update
2022-11-04 12:03:44 +01:00
Eric Leroy-Terquem
5578115acf
update routee? method
2022-11-04 12:03:43 +01:00
Eric Leroy-Terquem
110953e450
constraint logic to active groups
2022-11-04 12:03:43 +01:00
Eric Leroy-Terquem
63ae328bee
update wording and cards order
2022-11-04 12:03:43 +01:00
Eric Leroy-Terquem
b419c48262
toggle routing when adding or deleting groupe_instructeurs
2022-11-04 12:03:43 +01:00
Paul Chavard
33fc8a45ab
feat(emails): show email errors on procedure page
2022-11-04 09:08:41 +00:00
Paul Chavard
dd4c1f2fac
feat(emails): validate tags in notification emails
2022-11-04 09:08:41 +00:00
Paul Chavard
91a662fdb9
fix(graphql): make sure dossiers are always loaded with appropriate scope
2022-11-02 11:25:26 +01:00
Kara Diaby
661e5f78ac
model
2022-11-02 10:19:43 +01:00
Martin
ef2064a603
nettoyage(Traitement): supprime une methode morte
2022-11-01 12:43:49 +01:00
Martin
1b1568b2c2
remaniement(Administrateurs::ArchivesController): ne passe pas par la table des traitement pour compter le nombre de dossier traites par mois. Depuis que nous avons redescendu la colonne processed_at sur la table dossiers, ce n'\est plus necessaire et le code est compliqué a comprendre
2022-11-01 12:43:49 +01:00
Martin
cb1726366f
correctif(administrateur/procedure/archives#index): ne pas utiliser la table des traitement pour la comptabilisation du nombre de dossier dans une archive car si le dossier a ete accepte [mois n-1], repasse en instruction[mois-n1], accepte[mois-narchive], on se retrouve avec le dossier dans plusieurs archives et des compteurs confusant
2022-11-01 12:43:49 +01:00
simon lehericey
52b7886961
fix(clone): on procedure clone, discard integrity error
2022-11-01 10:17:24 +01:00
Paul Chavard
8cf9aec0f7
refactor(procedure): expose procedure tags on model
2022-10-31 19:50:25 +01:00
Christophe Robillard
9abf1c4af3
list all demarches, filtered by zones
2022-10-31 16:12:02 +01:00
Christophe Robillard
f9f31b721a
get zones of an admin
2022-10-31 16:12:02 +01:00
Martin
60dc6a3912
correctif(export.global): Export.find_for_groupe_instructeurs remonte les exports globaux même lorsqu'il y a une procedure presentation
2022-10-31 14:32:17 +01:00
Colin Darie
3a06e7e0b3
refactor(tdc): convert fill duration in Duration objects
2022-10-31 12:17:16 +01:00
Colin Darie
010c9a0dcb
feat(procedure): includes read duration of explication/non fillable champs
...
Long explications can significantly increase global fill duration,
so we can't ignore them.
Closes #7963
2022-10-31 12:17:16 +01:00
Colin Darie
7731c6ad64
feat(procedure): estimate fill duration takes account of libelle & description read time
...
Sometimes long description on types de champ
significantly increases global fill duration.
140 words per minute is a good estimate of attentive off-voice read time.
(This is independent of characters per word).
Closes #7963
2022-10-31 12:17:16 +01:00
Martin
5ced9fb431
chore(create_procedure_presentation): homogénéise l'interface sur les procédure présentation. pas d'objet 'build', sinon les export/filtres deviennent compliqués
2022-10-31 09:29:27 +01:00
Martin
50c43f4819
correct(export): la creation d'archive pour un groupe d'instructeur, avec des filtres differents et identique doit etre consistante
2022-10-31 09:29:27 +01:00
Colin Darie
9f2fa5ee1c
fix(invitation): don't fail when dossier is hidden & user signed on another account
...
Suite de 45994ff567
Cf https://sentry.io/organizations/demarches-simplifiees/issues/3422144920/events/e1c83ea74dbc410ea22aa17ef29fb329/?project=1429550
2022-10-28 08:56:03 +02:00
simon lehericey
4c98b8f01c
fix(merge): ensure service transfert always works
2022-10-27 12:44:02 +02:00
simon lehericey
44aff1a293
fix(silent_error_in_merge): raise if merge update fail
2022-10-26 23:27:53 +02:00
simon lehericey
6af4fe624a
refactor(service): explicit call to service job to avoid test side effect
2022-10-25 14:44:43 +02:00
Kara Diaby
492c7f377f
migration
2022-10-21 19:13:12 +02:00
Paul Chavard
f2e8dba8e4
fix(dossier): tag can contain non breaking space
2022-10-21 16:34:19 +02:00
Paul Chavard
d7c5dcf8bb
fix(dossier): a tag can be preceded by a -
2022-10-21 16:06:32 +02:00
Colin Darie
45994ff567
fix(invitation): when dossier is not visible anymore
...
https://sentry.io/organizations/demarches-simplifiees/issues/3422144920/
2022-10-20 09:08:36 +02:00
Martin
576aa2c1e0
amelioration(export): augment la duree de conservation des exports en cours de generation passant de 12 a 16h. augment la duree de conservation des exports generés passant de 16 à 32h
2022-10-20 06:32:41 +02:00
simon lehericey
5fa5d46d8c
fix(admin_merge): a case where 2 admins have the same service
2022-10-19 16:54:34 +02:00
Paul Chavard
5be8810da4
fix(dossier): nullify instructeur and expert id on messages when they are deleted
...
we keep email on the message so it will be used when instructeur or expert are not available
2022-10-19 11:53:10 +02:00
simon lehericey
c6e7db3622
fix(export): bug when combining revision and conditional
2022-10-18 11:53:13 +02:00
simon lehericey
fbf089d60e
refactor(dossier): rename check_mandatory_champs -> check_mandatory_and_visible_champs
2022-10-18 11:13:41 +02:00
simon lehericey
9bba2093be
refactor(champ): mandatory_blank_and_visible? -> mandatory_blank?
...
As the method does not check visibility
2022-10-18 11:13:41 +02:00
simon lehericey
7114623285
fix(champ): rewire champ.mandatory? to type_de_champ.mandatory?
...
it fixes behaviour in drop_down_list_component which add option if not mandatory (!= not required)
2022-10-18 11:13:41 +02:00
simon lehericey
528b7ec3f8
refactor(champ): add required?
...
used for the `required` html attribute. It check visibility to avoid hidden required input which prevent the form from being sent.
2022-10-18 11:13:41 +02:00
Paul Chavard
c075a4e415
fix(dossier): we should never detroy user’s dossiers in cascade
2022-10-14 14:14:51 +02:00
simon lehericey
d5d031e15d
fix(export): do not export invisible champ
2022-10-14 10:30:27 +02:00
simon lehericey
40a3fff593
perf(dossiers_controller): do not load pj template in update, -10ms
2022-10-13 22:36:56 +02:00
simon lehericey
f8ee6386b9
perf(champ): check condition.present? without json deserializationl, -6ms
2022-10-13 22:36:56 +02:00
simon lehericey
73b4ee64e6
perf(champ_value): use champ_type instead of tdc.type_champ, -22ms
2022-10-13 22:36:56 +02:00
Eric Leroy-Terquem
c6082ded09
no select for usager if only one groupe_instructeur
2022-10-13 19:49:32 +02:00
Martin
d09c47f5ce
correctif(usager.fusion): leve une erreur quand on essaie de fusionner un compte sur lui même
2022-10-13 17:00:20 +02:00
Paul Chavard
1fd1878370
feat(jobs): add request_id to jobs payload
2022-10-12 14:32:23 +02:00
Paul Chavard
7f1dd49bdc
chore(flipper): always use feature_enabled? helper
2022-10-12 14:14:30 +02:00
Damien Le Thiec
29a97fac43
Merge branch 'main' into feature/add_rna_type_de_champs
2022-10-11 18:59:45 +02:00
Damien Le Thiec
0e995c8bcc
Update app/models/champs/rna_champ.rb
...
Co-authored-by: Paul Chavard <paul.chavard@beta.gouv.fr>
2022-10-11 16:34:00 +02:00
simon lehericey
7672ad3fe9
fix(editor champ): do not raise on destroy replay
2022-10-11 16:27:49 +02:00
Damien Le Thiec
73f6063c87
Merge branch 'main' into feature/add_rna_type_de_champs
2022-10-11 15:36:46 +02:00
Damien Le Thiec
2e8c0512a5
Remove skip_cleanup option
2022-10-11 15:11:51 +02:00
Damien Le Thiec
bcdc9c18ae
Remove skip_fetch_data mechanism
2022-10-11 11:52:59 +02:00
Paul Chavard
a19bf050ef
fix(iban): format iban after validation
2022-10-11 10:43:32 +02:00
simon lehericey
157c3778df
refactor(dossier_preloader): add option to laod pj_template
2022-10-10 12:31:40 +02:00
simon lehericey
7e03f0c825
refactor(dossier_preloader): add load_one api
2022-10-10 12:31:40 +02:00
simon lehericey
5920168077
refactor(dossier_preloader): preload piece_justificative_template
2022-10-10 12:31:40 +02:00
simon lehericey
1f95f68fcc
refactor(dossier_preloader): assign champ.parent
2022-10-10 12:31:40 +02:00
simon lehericey
5df76d9fec
refactor(dossier_preloader): remove weird set_inverse_instance
2022-10-10 12:31:40 +02:00
Martin
c921e6e1ee
fix(ProcedureExportService): downloadable_sorted_batch is scoped by export, no need to re-filter them via downloadablable_sorted_batch otherwise export for supprimes_recemment does not includes dossier.supprimes_recemment
2022-10-10 11:11:21 +02:00
Eric Leroy-Terquem
1177d861f4
add validation on routing_criteria_name
2022-10-10 09:48:11 +02:00
Martin
6752da40a9
test(procedure.direction): can we drop this column ?
2022-10-07 18:39:17 +02:00
simon lehericey
ceaf8ebbe7
fix: orphan tdc due to reset_draft
2022-10-07 17:44:30 +02:00
krichtof
44018a86de
a procedure without zone is finally valid
2022-10-07 16:59:12 +02:00
Christophe Robillard
272c8cae09
cannot publish a procedure if no zones
2022-10-07 10:48:35 +02:00
Christophe Robillard
bdcb451d3c
procedure publiee must have one zone at least
2022-10-07 10:48:35 +02:00
Christophe Robillard
94ca93e130
can choose multiple zones
2022-10-07 10:48:35 +02:00
Christophe Robillard
bffd9d61a9
add habtm between procedures and zones
2022-10-07 10:48:34 +02:00
simon lehericey
0e75f9960b
fix: send_dossier_decision preview
2022-10-06 17:43:09 +02:00
Martin
a256dfbaa0
fix(spec): missed a failed spec previously. sorry
2022-10-06 15:34:29 +02:00
mfo
8a3550cda4
Merge pull request #7860 from mfo/US/procedure-duree-up-to-manager
...
feat(procedure.max_duree_conservation_dossiers_dans_ds): make it more flexible
2022-10-06 11:36:50 +02:00
mfo
e76b97fcb5
Merge pull request #7862 from mfo/US/cleanup-other-col
...
clean(procedure.columns): :durees_conservation_required, :cerfa_flag, :test_started_at
2022-10-06 11:36:00 +02:00
Martin
883ba8717f
clean(procedure.columns): :durees_conservation_required, :cerfa_flag, :test_started_at
2022-10-05 18:03:49 +02:00
Martin
405a885160
feat(procedure.max_duree_conservation_dossiers_dans_ds): make it more flexible
2022-10-05 17:27:09 +02:00
Damien Le Thiec
abbbef1461
Fix tests
2022-10-05 13:07:39 +02:00
Damien Le Thiec
0131a41266
Merge branch 'main' into feature/add_rna_type_de_champs
2022-10-05 12:38:24 +02:00
Paul Chavard
432c4690b5
feat(tags): replace regexp based parser with a parser combinator
2022-10-05 11:25:37 +02:00
Eric Leroy-Terquem
acd874ccdf
reorder inside categories
2022-10-05 09:21:08 +02:00
Eric Leroy-Terquem
6925ca66e6
add grouped options for select
2022-10-05 09:21:08 +02:00
Damien Le Thiec
0d9f02c88d
First draft autofetch data for RNA
2022-10-04 22:11:01 +02:00
Damien Le Thiec
e694ff1f60
Fix update external id after validation
2022-10-04 17:19:16 +02:00
Martin
7125e8538a
clean(engagement): remove last pieces of engagement champs
2022-10-04 07:17:47 +02:00
simon lehericey
6a5a82ce06
fix(instructeur dashboard): dossiers filtered on multiple states
2022-10-03 15:18:46 +02:00
Martin
aceb8996c1
feat(instructeur/procedure#show): enhance sort by notifications as planned by UX
...
Update app/javascript/controllers/checkbox_controller.ts
Co-authored-by: Paul Chavard <github@paul.chavard.net>
2022-09-30 10:29:51 +02:00
Paul Chavard
462cc41caa
refactor(block): use block? instead of repetition?
2022-09-29 17:49:14 +02:00
Paul Chavard
df47f4a7ab
feat(graphql): new tokens should carry administrateur_id
2022-09-29 11:58:58 +02:00
Martin
d7cce3c982
fix(instructeur/procedures#show): Procedure presentation filterable state field is in conflict with projected state field. quick fix, maybe will refactor both to align them
2022-09-28 15:28:51 +02:00
Kara Diaby
e1999d5729
fix checkbox mandatory champ
2022-09-28 10:53:24 +02:00
simon lehericey
8efd305256
add upper_tdcs to condition_form
2022-09-28 10:06:31 +02:00
simon lehericey
7e1963865e
compatibility from left
2022-09-28 10:06:31 +02:00
simon lehericey
43f926a1de
to_s
2022-09-28 10:06:31 +02:00
simon lehericey
f98d1463a6
compatible_type
2022-09-28 10:06:31 +02:00
simon lehericey
cd2b08e39b
options
2022-09-28 10:06:31 +02:00
simon lehericey
12b6a0d6d6
errors
2022-09-28 10:06:31 +02:00
simon lehericey
70022450cf
type
2022-09-28 10:06:31 +02:00
Martin
17ed80b18a
clean(Champs::Engagement): migrate to Champs::Checkbox, some for TypeDeChamp
2022-09-27 19:09:28 +02:00
Martin
ba6c5b4db7
feat(instructeur/procedure#index): enhance filter to support processed_at and state [plus en_instruction_at/since]
...
feat(filter): enable filter on dossiers.state, dossiers.processed_at(since), dossiers.en_instruction_at(since)
2022-09-27 17:19:54 +02:00
Colin Darie
e18dbb976f
fix(graphql/serializer): PersonneMorale#date_creation may be null
...
Ça fix le passage du dossier dans un dossier "terminé" pour un dossier
dont un champ avec SIRET correspond à un établissement sans date de creation
connue.
2022-09-26 18:05:04 +02:00
Christophe Robillard
ddd5f6ece2
make label method name more explict
2022-09-26 16:58:53 +02:00
Christophe Robillard
f452e1014a
make label_at more concise
2022-09-26 16:58:53 +02:00
Christophe Robillard
240f1b249f
makes the NA label for zone more explicit
2022-09-26 16:58:53 +02:00
Christophe Robillard
9a9330159c
choose zone options with correct label
...
label of the zone is the one available when the procedure has been published (or at the creation if the procedure has not been published)
2022-09-26 16:58:53 +02:00
Christophe Robillard
62f19aba8a
get all available zones at specific date
2022-09-26 16:58:53 +02:00
Christophe Robillard
9773977496
know if a zone exist at a specific date
2022-09-26 16:58:53 +02:00
Christophe Robillard
59cce4203a
get zone label at specific date
2022-09-26 16:58:53 +02:00
Christophe Robillard
a504e82021
add zone label
2022-09-26 16:58:53 +02:00
simon lehericey
f53e8608ae
refactor(conditional): error message system
2022-09-26 10:21:15 +02:00
simon lehericey
ab42b27176
refactor(logic): add comments
2022-09-26 10:21:15 +02:00
simon lehericey
fcb9b55bc4
feat(conditional): add include operator
2022-09-26 10:21:15 +02:00
Damien Le Thiec
542c5b518f
Improve and connect RNA Adapter
2022-09-22 17:13:53 +02:00
Colin Darie
6a4a9c8e03
fix(cron/procedure-declarative): don't auto accept a dossier still in degraded mode
2022-09-22 16:26:14 +02:00
Colin Darie
9b929c86ea
Merge pull request #7760 from betagouv/dsfr-dossier-top-form
...
DSFR: convert dossier top form elements
2022-09-21 16:44:51 +02:00
Colin Darie
e7de19b24d
fix(dossier): avoir final state if etablissement is still in degraded mode
...
Maintenant qu'on autorise un dossier pour entreprise a être créé en mode "dégradé",
(avec établissement incomplet suite à API Entreprise/INSEE down…),
on empêche de l'accepter/refuser/classer sans suite tant qu'on a pas
vérifié son SIRET.
Fix https://sentry.io/organizations/demarches-simplifiees/issues/2839832517/?project=1429550&query=is%3Aunresolved
2022-09-21 16:00:59 +02:00
Colin Darie
a5e1d8865b
style(france_connect_account): convert notice about FC user to DSFR
2022-09-21 15:47:35 +02:00
Paul Chavard
16bba911ba
Revert "Merge pull request #7637 from tchak/chore-add-missing-foreign-keys"
...
This reverts commit b21ee46dc2
, reversing
changes made to dd85b5c35c
.
2022-09-21 15:20:42 +02:00
Damien Le Thiec
d8afe81034
Setup RNA champ
2022-09-21 15:18:08 +02:00
Damien Le Thiec
606ac48964
Add new RNA Type de champ
2022-09-21 15:17:23 +02:00
Paul Chavard
84b9644bcd
fix(db): add missing foreign keys
2022-09-20 15:16:52 +02:00
Martin
eae05b0a6f
feat(export.xslx): add code commune to geo_area.label
2022-09-17 08:59:06 +02:00
Colin Darie
95a4e8a907
feat(api_entreprise): create etablissement with fallback when API is down
...
On créé l'établissement uniquement avec le SIRET, sans que ce soit bloquant
pour compléter le dossier. On demande à l'utilisateur de vérifier
lui-même la concordance du SIRET avec son entreprise.
Cf #7766
2022-09-16 10:43:59 +02:00
simon lehericey
c43bf2e5c9
fix(conditional): only parse user input as int if compared with a number
2022-09-09 11:28:32 +02:00
Paul Chavard
d35ceb7214
fix(champs): finish EditableChampComponent refactor
2022-09-08 11:26:29 +02:00
simon lehericey
ac0ac171ad
perf(dossier): remove unused row validation
...
Gain, one request per champ not child
2022-09-07 15:00:40 +02:00
Paul Chavard
c05bc61c99
fix(revisions): improuve changes information display
2022-09-07 13:52:44 +02:00
Colin Darie
91c735a219
chore(service): SIRET is required
2022-09-06 09:23:52 +02:00
Colin Darie
9d59a50cd4
chore(manager/services): show etablissement adresse & geopoint
2022-09-06 09:23:52 +02:00
Colin Darie
67cbc61e1e
chore(services): update etablissement adresse & geocode when siret changes
2022-09-06 09:23:52 +02:00
Colin Darie
7d39cc6b3e
chore(schema): +services#etablissement_{infos,geopoint}
...
- `etablissement_infos` est une représentation partielle en jsonb
de ce qui est renvoyé par l'API Entreprise.
(On ne conserve que l'adresse pour le moment, utilisée pour le geocodage)
- `etablissement_geopoint` est le point (x,y) issu du géocodage de
l'établissement
2022-09-06 09:23:52 +02:00
Colin Darie
64ce2719ed
feat(services): accept an optional SIRET
...
Closes #7359
2022-09-06 09:23:52 +02:00
Colin Darie
a4d9a45280
chore(schema): +services#siret
2022-09-06 09:23:52 +02:00
Colin Darie
4e3b063b87
feat(carte/export): list geo labels
2022-09-05 11:02:51 +02:00
simon lehericey
8c884b4869
fix(migration): fix avis email notification migration
2022-09-02 17:23:04 +02:00
Kara Diaby
f8d4644f73
models
2022-09-02 16:23:27 +02:00
Martin
5f2b290407
feat(Procedure.clone): reset subject.duree_conservation_dossiers_dans_ds when procedure.duree_conservation_etendue_par_ds was extended. only extends it on demand otherwise admin could clone old procedure with higher duree_conservation_dossiers_dans_ds
2022-08-31 14:56:00 +02:00
Martin
6e31decc2d
feat(Procedure.clone): stop cloning procedure service which is confusing for some administrateurs
2022-08-31 14:56:00 +02:00
Colin Darie
4ece7c2494
fix(champ): remove null byte before save
...
Les null bytes peuvent être injectés lors de c/c depuis certains documents,
et ne sont pas sauvegardables en base, rendant la sauvegarde d'un dossier impossible.
Closes #7656
https://sentry.io/organizations/demarches-simplifiees/issues/3194932607/activity/?project=1429550&query=is%3Aunresolved
2022-08-31 11:39:34 +02:00
Christian
63a4a13323
Graphql: Fix champs sort in repetition
2022-08-31 11:15:28 +02:00
Martin
2f5528398f
feat(manager#outdated_procedure): allow super admin to enable procedure_expires_when_termine_enabled for old procedure
...
revew(typo): various typo, tx christophe :-)
fix(spec): due to typo fixes
2022-08-24 13:10:48 +02:00
Martin
dc524cf615
fix(spec): broken spec due to TDD and refacto on former code
2022-08-23 13:28:10 +02:00
Martin
711b2ee2e4
feat(ExportComponent): only render it when connected instructeur/administrateur is not from manager
2022-08-23 13:28:10 +02:00
Martin
d1297bc1f5
tech(rubocopify): ... just clean up ...
2022-08-23 13:28:10 +02:00
Martin
c2e0994e11
feat(Administrateur::ArchivesController#*): prevent SuperAdmin to index/download archives
2022-08-23 13:28:10 +02:00
Martin
ef67958324
feat(manager): add #add_administrateur_with_confirmation and #confirm_add_administrateur so SuperAdmin requires another SuperAdmin approval to add an administrator to a procedure. Add #add_administrateur_and_instructeur for SuperAdmin willing to be administrateur/instructeur for 24
2022-08-23 13:28:10 +02:00
Martin
f0a4cbb61e
feat(assign_tos): add manager column to assign_tos table. Same idea as administrateur_procedures.manager which flag a link between procedure/administrateur coming from a SuperAdmin [target: able to avoid SuperAdmin sec issues]
2022-08-23 13:28:10 +02:00
simon lehericey
650c36e3e2
feat(conditional): add not eq operator
2022-08-10 11:59:09 +02:00
simon lehericey
898badb579
a champ is mandatory when visible with a mandatory tdc
2022-08-09 10:25:47 +02:00
Paul Chavard
a24885c2ee
feat(champ): can condition on other option
2022-08-04 15:28:54 +02:00
Paul Chavard
bbca7344e5
fix(conditional): mandatory champs inside hidden repetition should not be validated
2022-08-04 14:48:40 +02:00
Colin Darie
adced0f33a
fix(revision): fix stable siblings order when there are multiple identical position
...
Ça arrive parfois dans les tests, et potentiellement en prod :
après avoir créé un nouveau `revision_type_de_champ`,
on se retrouve très momentanément avec 2
RTDC ayant le même position en attendant le renumérotation peu près.
https://github.com/betagouv/demarches-simplifiees.fr/blob/main/app/models/procedure_revision.rb#L55
Ceci conduisait à une renumérotation erronnée quand la db renvoyait
le nouveau RTDC créé *avant* les précédents.
2022-08-03 18:29:48 +02:00
Colin Darie
8dc966feb4
fix(dossier_transfer): requires an actual email
...
Closes #7621
2022-08-03 11:44:54 +02:00
Paul Chavard
435a635b3d
fix(procedure_presentation): find last instance of type_de_champ through coordinates
2022-08-02 15:24:52 +02:00
Paul Chavard
48a4e8bec5
chore(db): remove already dropped ignored columns
2022-08-02 15:24:52 +02:00
Paul Chavard
782af3322a
fix(patron): when rendering “patron” champs should have dossier
2022-07-28 12:10:32 +02:00
Colin Darie
197fa54ea4
fix(archives): purge stuck pending archives
...
Cf 0cb096b3d6440a4da05ca2902ed6fa72a93e6579
2022-07-27 15:26:59 +02:00
Colin Darie
f1957e51f8
fix(exports): purge stuck (pending) exports, not generated or failed
...
Avec l'autre PR, ça reproduit le comportement d'avant, c'est à dire
que quoiqu'il arrive un export est purgé :
- soit 16h après sa génération (on a 16h pour le télécharger)
- soit 12h après sa création, et qu'il est bloqué
Auparavant, tous les exports étaient purgés au bout de 3h quelle que soit
le statut.
2022-07-27 15:26:59 +02:00
Colin Darie
67d2cb2061
chore(schema): add exports#job_status
...
Same behavior as Archive
On destroy tous les exports existants qui n'ont pas cette notion de status.
2022-07-26 17:53:24 +02:00
Colin Darie
6845b2ed08
fix(export): fix PurgeStaledExportsJob regression with stale
scope
...
cc #7547
2022-07-26 14:26:22 +02:00
Colin Darie
11cd73b4ac
feat(export/csv): list etablisement entreprise_etat_administratif
2022-07-25 10:58:02 +02:00
Colin Darie
f05e9331a7
chore(entreprises): save etat_administratif from API
2022-07-25 10:58:02 +02:00
Colin Darie
e1d3d1f844
chore(schema): add entreprise_etat_administratif to etablissements
2022-07-25 10:58:02 +02:00
Martin
3e56fdd1d7
fix(export): when it takes more than 3 hours, exports are purge before being generated. make it possible to have an export that takes more than 3 hours and share this behaviour with kind of same class archive
2022-07-25 10:48:54 +02:00
simon lehericey
0d3856e84a
fix(conditional): handle incorrect user input
2022-07-22 15:55:43 +02:00
Paul Chavard
d9eea35ae8
fix(dossier): decoralate dropdown behaviour from autosave
2022-07-21 18:40:16 +02:00
Paul Chavard
3e40b6d7bc
fix(graphql): handle annotations inside blocks
2022-07-21 14:54:14 +02:00
Paul Chavard
902dc678de
perf(graphql): improuve dossier loading
2022-07-21 12:29:08 +02:00
Paul Chavard
042703cead
refactor(dossier): extract dossier preloader
2022-07-21 12:29:08 +02:00
simon lehericey
821fd2394b
small refactor
2022-07-20 15:48:16 +02:00
simon lehericey
72583f846b
champ value return nil if champ is hidden
2022-07-20 11:23:57 +02:00
Paul Chavard
e85fe71887
fix(champ): allow to submit when secondary options are empty
2022-07-20 10:49:07 +02:00
simon lehericey
2d26ba3507
fix: binary operator computes false by default
2022-07-19 10:11:24 +02:00