Commit graph

12053 commits

Author SHA1 Message Date
simon lehericey
5cd780251b
refactor: mutualize email_expert logic 2024-04-16 17:58:29 +02:00
Colin Darie
7c6bcb268d
chore(admin): improve non declarative radio label 2024-04-16 17:55:17 +02:00
Colin Darie
2515f46fea
style(admin): minor spacing improvements in procedure form 2024-04-16 17:55:16 +02:00
Lisa Durand
ec26ebb807
use radio rich style for more readability 2024-04-16 17:55:15 +02:00
Lisa Durand
227d740a76
remove css change and add all fieldsets 2024-04-16 17:55:14 +02:00
Lisa Durand
1246ef02b6
remove interpolation in duree_conservation… field 2024-04-16 17:55:12 +02:00
Lisa Durand
5231ce71a3
follow-up : admin better procedure infos form 2024-04-16 17:55:11 +02:00
Colin Darie
b1570a40f9
wip: admin: better procedure infos form 2024-04-16 17:55:10 +02:00
Colin Darie
b336e1b606
chore(admin): fix hardcoded application names in translations 2024-04-16 17:55:09 +02:00
Colin Darie
94c176d791 style(notification): fix pastille position in dossiers list 2024-04-16 15:59:53 +02:00
Colin Darie
71b0592b0a
Merge pull request #10336 from colinux/fix-address-without-postcode
Usager: fix champ adresse dans un TOM sans code postal dans la BAN (ex. Nouvelle-Calédonie à Nouméa)
2024-04-16 13:45:04 +00:00
Colin Darie
db65c9178e
fix(address): BAN does not return postcode for some TOM like Nouvelle-Calédonie
But we have to fallback to an empty string because API graphql / serializer
expects a non-null attribute.
2024-04-16 15:37:56 +02:00
Paul Chavard
f95bd5d1f2
Merge pull request #10327 from tchak/remove-stable-id-delegate
refactor(champ): remove stable_id delegate to type_de_champ
2024-04-16 13:14:08 +00:00
simon lehericey
2f946c1592
refactor: put dol cold storage migration to its own queue 2024-04-16 13:48:12 +02:00
Paul Chavard
ee56a7da21 refactor(champ): remove stable_id delegate to type_de_champ 2024-04-16 12:10:07 +02:00
Lisa Durand
7a80574afc
Merge pull request #10190 from demarches-simplifiees/add-AR-feature-ldu
ETQ Admin je peux configurer une démarche avec accusé de lecture
2024-04-16 09:58:13 +00:00
Lisa Durand
49ed6d0b14 add demo video url on admin homepage 2024-04-16 10:34:28 +02:00
simon lehericey
6982b2d5e8
refactor: do not enqueue antivirus job for safe blob 2024-04-16 09:57:31 +02:00
Colin Darie
e3dbbf2009
Merge pull request #10235 from colinux/page-404
Pages d'erreur personnalisées / au dsfr
2024-04-15 21:12:04 +00:00
Paul Chavard
d857ad1d0a
Merge pull request #10323 from tchak/fix-commune-with-blank-codes
fix(commune): no crash on blank codes
2024-04-15 11:48:16 +00:00
Paul Chavard
7163571764
Merge pull request #10325 from colinux/fix-add-row-without-champ
Tech: pas d'erreur si un usager essaie d'ajouter une ligne d'un champ répétition sans enfant
2024-04-15 11:48:04 +00:00
Colin Darie
4da13f5dc2 fix(repetition): don't fail when trying to add a row of repetition without champ
Cf procedure#31063 which have stable_id#1078289 without children
2024-04-15 13:15:18 +02:00
Paul Chavard
f4f1d5bcd9 chore(task): backfill commune code from name task 2024-04-15 12:12:05 +02:00
Lisa Durand
c6e2e6445c add instructeur feedback on accuse de lecture agreement 2024-04-15 12:10:28 +02:00
Paul Chavard
bde496b739
Merge pull request #10322 from tchak/chore-backfill-stable-id-custom-limit
chore(task): backfill stable_id with custom limit
2024-04-15 09:28:21 +00:00
LeSim
716099e2d7
Merge pull request #10321 from demarches-simplifiees/add_maintenance_task_to_move_dol_to_cold_storage
Tech: ajoute une tache de maintenance pour rattraper les dossier operation log qui n'ont leur data sur le cold storage
2024-04-15 09:20:43 +00:00
Lisa Durand
a29719a15c small adjustments from PR feedbacks 2024-04-15 11:15:13 +02:00
Lisa Durand
13aeb4f4d9 Correction Sim PR - use dynamic application name
Co-authored-by: LeSim <mail@simon.lehericey.net>
2024-04-15 11:15:13 +02:00
Lisa Durand
71268c7f3b hide decision from email for tiers if procedure has accuse de lecture 2024-04-15 11:15:13 +02:00
Lisa Durand
1cf3db5899 hide dossier with accuse de lecture in user list when using state filter 2024-04-15 11:15:13 +02:00
Lisa Durand
5bbc4cab50 hide decision displayed in messagerie with auto commentaire 2024-04-15 11:15:13 +02:00
Lisa Durand
8fe9b174eb hide decision displayed in badge for user 2024-04-15 11:15:13 +02:00
Lisa Durand
e486f789f6 add AR in user view - hide decision on second dossier tab 2024-04-15 11:15:13 +02:00
Lisa Durand
8eda069bfc add AR in user view - hide decision on first dossier tab 2024-04-15 11:15:13 +02:00
Lisa Durand
ae08044ff2 create AR email and send it at the right time 2024-04-15 11:15:05 +02:00
Paul Chavard
ea47ba3747 fix(commune): no crash on blank codes 2024-04-15 11:01:15 +02:00
Lisa Durand
ee91f47c5a add AR component and page on admin view 2024-04-15 10:46:29 +02:00
Paul Chavard
ef2aa217ff chore(task): backfill stable_id with custom limit 2024-04-15 10:43:39 +02:00
simon lehericey
d419508b68
fix: reduce a join query size 2024-04-15 10:34:39 +02:00
simon lehericey
120eb4253c
data: add naive maintenance task to cold storage dol 2024-04-15 10:16:14 +02:00
mfo
cb2dd3dd3a
Merge pull request #10314 from mfo/US/enhance-a11y-on-carte-champs
ETQ Usager je souhaite que le champ carte soit plus accessible
2024-04-14 13:25:06 +00:00
mfo
d4e8227827
Merge pull request #10312 from mfo/US/ensure-dsfr-style-on-some-champs
ETQ usager, je veux que tous les champs aient un style DSFR
2024-04-12 13:41:16 +00:00
mfo
3e89921683
Merge pull request #10315 from mfo/US/drop-usage-of-invalid-aria
ETQ usager : pas d'`aria-invalid`
2024-04-12 11:55:58 +00:00
mfo
f1935eb7a0
Merge pull request #10318 from mfo/US/better-error-messages
ETQ Usager, je souhaite avoir des messages d'erreur homogènes et comprehensibles
2024-04-12 11:55:39 +00:00
mfo
b9907ac9ce
fix(Champ.rnf): add missing fr-input dsfr class name
Co-authored-by: Corinne Durrmeyer <corinne@inseo.fr>
2024-04-12 12:01:00 +02:00
mfo
1989c3e75b
fix(Champ.carte): add missing label to search input instead of placeholder
Co-authored-by: Corinne Durrmeyer <corinne@inseo.fr>
2024-04-12 11:56:34 +02:00
mfo
d7cacde727
feat(champ.aria): do not use aria-invalid from time to time [standardization]
Co-authored-by: Corinne Durrmeyer <corinne@inseo.fr>
2024-04-12 11:54:09 +02:00
mfo
35c92ee906
feat(champs.errors.format): better format for error below champs
Co-authored-by: Corinne Durrmeyer <corinne@inseo.fr>
2024-04-12 11:50:43 +02:00
mfo
938f5043a4
feat(champs.validation): standardize champ error messages 2024-04-12 11:39:43 +02:00
mfo
d8a8fb53ce
feat(Champ.carte): some error style on carte 2024-04-12 10:59:42 +02:00
mfo
a052341c93
fix(Champ.address): add missing fr-select dsfr class name 2024-04-12 10:45:37 +02:00
mfo
626f3780f6
fix(Champ.commune): add missing fr-select dsfr class name 2024-04-12 10:45:24 +02:00
mfo
c22438fb75
feat(Champ.annuaire_education): add missing fr-input class name 2024-04-12 10:45:12 +02:00
Eric Leroy-Terquem
84ab6d08b8
feat(routing): make assignment mode auto when all dossiers are reaffected to defaut groupe. so that all dossiers can be re routed 2024-04-12 10:27:21 +02:00
mfo
4773d9ebad
feat(Champ.repetition): hide destroy button of first repetition row when the repetition is mandatory 2024-04-12 09:29:00 +02:00
Colin Darie
a93a4cd5ce
chore: specific 422 error page 2024-04-11 18:19:32 +02:00
Colin Darie
5b98fd7c6d
chore: generic customized error page 2024-04-11 18:19:31 +02:00
Colin Darie
5d23b37f59
chore: custom dynamic & static 500 pages 2024-04-11 18:19:30 +02:00
Colin Darie
7dcd4ba538
feat: customized page 404 2024-04-11 18:19:29 +02:00
Paul Chavard
4d90b1f662
Merge pull request #10303 from colinux/update-admin-transfer-copy
ETQ admin: améliore le style de la page oubliée "Envoyer une copie de ma démarche"
2024-04-11 14:48:42 +00:00
Eric Leroy-Terquem
1e50223267
Merge pull request #10293 from demarches-simplifiees/re-router-tous-les-dossiers-d-une-demarche
ETQ tech je peux relancer le routage pour tous les dossiers en construction d'une démarche
2024-04-11 13:27:43 +00:00
simon lehericey
bda9c4b455
fix: drop unused column and fk procedure_revisions.attestation_template_id which block procedure.destroy 2024-04-11 13:38:38 +02:00
simon lehericey
ab4a6b1c7d
fix: rescue and sentry log procedure.purge_discarded to avoid blowing up the whole job 2024-04-11 13:22:37 +02:00
Colin Darie
efc1b2201a style(admin): Envoyer une copie form in dsfr 2024-04-11 12:52:03 +02:00
Paul Chavard
fe508c0a73
Merge pull request #10302 from tchak/ignore-attestation_template_id
chore(db): ignore attestation_template_id
2024-04-11 10:30:37 +00:00
Paul Chavard
2de2d8af45
Merge pull request #10301 from demarches-simplifiees/more_work_on_city_address
Tech: simplifie le code address dans les champs commune
2024-04-11 10:15:47 +00:00
Paul Chavard
d5b08d2ebb
Merge pull request #10298 from mfo/US/fix-move-after
ETQ Admin, quand je deplace les champs apres d'autre champ, ne pas griser le champs precedent
2024-04-11 10:07:35 +00:00
Paul Chavard
ceae749746 chore(db): ignore attestation_template_id 2024-04-11 12:03:06 +02:00
simon lehericey
124433b781
refactor: commune_champ 2024-04-11 11:57:18 +02:00
simon lehericey
c77b66feef
refactor: api_geo_services raises if wrong dep or city code 2024-04-11 11:56:53 +02:00
Paul Chavard
4cdaef3a08
Merge pull request #10300 from tchak/chore-stable_id-task
fix(stable_id): recursive job to fill stable_ids
2024-04-11 09:53:56 +00:00
LeSim
e7f31e4d49
Merge pull request #10297 from demarches-simplifiees/fix_dossier_operation_log_move_to_cold_storage
Tech: améliore la performance du job du stockage a froid des traces fonctionnelles
2024-04-11 09:47:37 +00:00
Paul Chavard
9bfc4119b1 fix(stable_id): recursive job to fill stable_ids 2024-04-11 11:45:03 +02:00
Lisa Durand
5b3277bb31
Merge pull request #10270 from demarches-simplifiees/ux-remove-icon-file-in-tableau-instructeur-ldu
ETQ instructeur, j'ai une colonne vide s'il n'y a pas les checkbox des actions multiples
2024-04-11 09:25:26 +00:00
mfo
45d45c0d05
feat(type_de_champ_editor): allow admin to move champ after previous champ. useless but better a11y 2024-04-11 11:00:08 +02:00
simon lehericey
34fae2831f
refactor: add dol_move_batch job which are enqueued by the cron 2024-04-11 10:58:34 +02:00
Colin Darie
dfbe53dcc5
fix(cron): really schedule jobs on sidekiq instead of running them 2024-04-10 18:03:47 +02:00
simon lehericey
344f0d2c80
fix: graphql new normalization 2024-04-10 10:57:37 +02:00
simon lehericey
5567570d74
more robust normalization 2024-04-10 10:57:37 +02:00
Lisa Durand
758673a355
Merge pull request #10280 from demarches-simplifiees/ux-improve-usager-filter-dropdown-ldu
[UX] Améliorer les filtres d'un dossier sur le tableau de bord d'un usager
2024-04-10 07:18:55 +00:00
Eric Leroy-Terquem
51312b178e
task(routing): reroute dossiers en construction 2024-04-09 17:17:49 +02:00
simon lehericey
23060da306
fix: do not url encode error message in sentry 2024-04-09 14:25:17 +02:00
simon lehericey
92ba1a12ce
chore: use space instead of tab 2024-04-09 14:25:17 +02:00
simon lehericey
f55328c15d
fix: maintenance task to backfill city_name 2024-04-09 11:44:11 +02:00
Colin Darie
4bbe136987
Merge pull request #10283 from demarches-simplifiees/fix-main-menu-a11y
Remplacement de l'attribut `aria-current="page"` par `aria-current="true"` lorsque le lien concerne un ensemble de pages
2024-04-09 08:57:09 +00:00
Colin Darie
c7d2caf1b7
Merge pull request #10266 from demarches-simplifiees/fix-a11y-contact-page
Amélioration de l'accessibilité de la page de contact.
2024-04-09 08:17:24 +00:00
Colin Darie
6e9bae4f0c
Merge pull request #10289 from colinux/fix-preferred-domain
Tech: n'assigne pas le domaine préféré à l'inscription/connexion si la feature n'est pas activée
2024-04-09 08:15:32 +00:00
Colin Darie
3c7018fd31 fix: don't set preferred domain on signup/signin unless feature is enabled 2024-04-09 10:04:18 +02:00
Colin Darie
25892f594c
fix(jobs): don't enqueue crons to default adapter anymore 2024-04-08 18:27:31 +02:00
Lisa Durand
09d4ed760f add missing views and change position for notif 2024-04-08 12:10:00 +02:00
Paul Chavard
df8ad3f709 fix(adresse): fallback to city name if commune not found 2024-04-08 11:49:37 +02:00
Paul Chavard
707d3980c0
Merge pull request #10171 from tchak/fix-perf-filters
perf(filter): we query by stable_id - no need to check type_de_champ private attribute
2024-04-08 09:24:54 +00:00
Corinne Durrmeyer
fd54c15144
feat(fix-aria-current-mainmenu) : Transform aria-current='page' into aria-current='true' when the current link targets several pages - fix #8559 #8135 2024-04-08 11:22:44 +02:00
Lisa Durand
e2d83d87d2 change wording in usager filter and target css to combobox component 2024-04-08 10:41:39 +02:00
LeSim
12406643d9
Merge pull request #10268 from demarches-simplifiees/sidekiq_cron
Tech: déplace les cron job sur sidekiq
2024-04-08 08:32:06 +00:00
LeSim
6855213435
Merge pull request #10273 from demarches-simplifiees/discard_champ_fetch_job_on_not_found
Tech:  supprime les fetch_external_data_job lorsque le champ correspond n'existe plus
2024-04-08 08:13:06 +00:00
LeSim
22830fd7f6
Merge pull request #10275 from demarches-simplifiees/fix_api_entreprise_status
Tech: corrige le mécanisme de surveillance des fournisseurs d entreprise.api.gouv.fr
2024-04-08 08:08:38 +00:00
Paul Chavard
c5c671f391
Merge pull request #10234 from tchak/type-de-champ-paths
feat(champ): add paths to type_de_champ
2024-04-08 08:07:30 +00:00
simon lehericey
e82a8787d5
dirty fix: avoid changing preferred domain 2024-04-05 15:26:12 +02:00
Paul Chavard
ce95fe1794
Merge pull request #10255 from demarches-simplifiees/fix-move-after-edit-list
ETQ Administrateur : Amélioration de l'accessibilité et de l'ergonomie de la liste d'édition du formulaire "déplacer après"
2024-04-05 11:39:55 +00:00
Paul Chavard
80b3f0c0b3 fix(champ): no validate on hidden champs 2024-04-05 13:24:57 +02:00
simon lehericey
2e2f4706c5
deduplicate and add error management 2024-04-05 12:30:43 +02:00
simon lehericey
42f0b87c39
remove api_up? 2024-04-05 12:27:54 +02:00
simon lehericey
7b33963a67
add and use api_djepva_up? 2024-04-05 12:27:26 +02:00
simon lehericey
e994738a2e
add and use api_insee_up? 2024-04-05 12:26:44 +02:00
simon lehericey
ac695a2151
fix: discard DeserializationError on fetch external data job 2024-04-05 10:42:44 +02:00
Corinne Durrmeyer
a46286f9df
feat(improve-contact-page-a11y) : Add missing h2 to footer 2024-04-05 09:35:28 +02:00
Corinne Durrmeyer
339dd7ef98
feat(improve-contact-page-a11y) : Add missing lang attributes - fix #6772 2024-04-05 09:35:22 +02:00
Paul Chavard
742e6f4a92 perf(filter): we query by stable_id - no need to check type_de_champ private attribute 2024-04-04 19:01:47 +02:00
Paul Chavard
282ce1322c fix(stats): more accurat stats about deleted dossiers 2024-04-04 19:00:48 +02:00
Paul Chavard
81c325f938 chore(task): another attempt to backfill stable_id 2024-04-04 17:55:38 +02:00
Lisa Durand
5155049873 remove column with checkbox if no batch actions 2024-04-04 17:17:03 +02:00
simon lehericey
42af5a9149
make cron_job work with both delayed_job and sidekiq 2024-04-04 16:38:38 +02:00
Paul Chavard
38a703034e feat(champ): expose paths 2024-04-04 16:13:23 +02:00
Corinne Durrmeyer
8039464541
feat(improve-contact-page-a11y) : Replace %span.mandatory * with AsteriskMandatoryComponent 2024-04-04 14:53:51 +02:00
Corinne Durrmeyer
9dab2afc11
feat(improve-contact-page-a11y) : Replace 'All fields are mandatory.' with 'Fields marked by an asterisk are mandatory' - fix #10264 2024-04-04 14:53:51 +02:00
Corinne Durrmeyer
5523dd4b35
feat(improve-contact-page-a11y) : Remove useless <h2> around paragraphs - fix #8212 #10264 2024-04-04 14:53:51 +02:00
Paul Chavard
9593e8825f chore(browser): be more agressive about browser deprecation 2024-04-04 13:53:41 +02:00
Colin Darie
c005991470
Merge pull request #10230 from demarches-simplifiees/fix-alert-for-closed-procedures-in-dossiers-list
Correctif : affiche correctement le lien vers la page de fermeture dans la liste des dossiers
2024-04-04 09:44:55 +00:00
Colin Darie
8af3f07181
Merge pull request #10231 from colinux/fix-gouv-fr-banner
Tech: petites corrections pour le .gouv
2024-04-04 09:02:03 +00:00
Eric Leroy-Terquem
8d7c078f92
fix(dossiers list): display link correctly 2024-04-04 09:44:37 +02:00
Corinne Durrmeyer
1cd552c79f
feat(move_after_edit_list) : Add new line at end of file to avoid lint error 2024-04-04 09:39:40 +02:00
Colin Darie
0c4a4c8764
Merge pull request #10232 from demarches-simplifiees/redirect-fermeture-to-commencer-if-procedure-not-closed
Correctif: redirige la page fermeture vers la page commencer si la démarche n'est pas fermée
2024-04-04 07:34:23 +00:00
Colin Darie
df59503ab7
Merge pull request #10224 from colinux/mail-host
Tech (mailers): `from`, liens et application en respectent le preferred domain du destinataire
2024-04-04 07:25:43 +00:00
LeSim
3f54d46f19
Merge pull request #10258 from demarches-simplifiees/fix_strange_locale
tech: verifie que la locale est disponible
2024-04-03 07:11:12 +00:00
simon lehericey
fc8d5adf2f
fix: avoid buggy locale from user 2024-04-02 21:53:56 +02:00
Colin Darie
8c0375fe6f
chore: easier to test .gouv / new host using APP_HOST 2024-04-02 19:36:39 +02:00
Colin Darie
033b2fa63d
chore(banner): easier with hardcoded .gouv.fr name 2024-04-02 19:36:37 +02:00
Colin Darie
d5515fca33
fix(banner): not closed form tag broke JS 2024-04-02 19:36:35 +02:00
Colin Darie
95e80d6ce3
fix(layout): header text alignemnt 2024-04-02 19:25:46 +02:00
Colin Darie
36fc535386
refactor(mailer): for devise mailer set locale in dedicated action 2024-04-02 19:25:44 +02:00
Colin Darie
172aeec3dc
chore(mail): replace textual logo with simple logo + application name as text 2024-04-02 18:47:53 +02:00
Colin Darie
df198a8946
style(mailer): big button in dsfr style 2024-04-02 18:47:51 +02:00
Colin Darie
68ee4a3404
feat(mail): use contextualized Current.application_name 2024-04-02 18:47:48 +02:00
Colin Darie
8b9d4c87f7
refactor(mailer): more thread safe defaults tweaks 2024-04-02 18:47:47 +02:00
Colin Darie
21991d7253
feat(mail): link with hosts for recipient for user mailer 2024-04-02 18:47:46 +02:00
Colin Darie
5bf580b6ac
feat(mail): link with hosts for recipient for notification mailer 2024-04-02 18:47:45 +02:00
Colin Darie
f8a9e72aa2
feat(mail): from and link with host for recipient in dossier_mailer 2024-04-02 18:47:44 +02:00
Colin Darie
3512e071d3
feat(mail): devise mailer respect user preferred host for any mail 2024-04-02 18:47:43 +02:00
Colin Darie
d14fe83261
feat(mail): devise confirmation instructions respect user preferred host 2024-04-02 18:47:41 +02:00
Paul Chavard
0006a12aea
Update app/models/dossier.rb
Co-authored-by: LeSim <mail@simon.lehericey.net>
2024-04-02 18:09:29 +02:00
Paul Chavard
7cf1cdb47b fix(champ): do not expose champs without row_id in repetitions 2024-04-02 17:51:57 +02:00
Corinne Durrmeyer
84f0165520
feat(move_after_edit_list) : Remove useless aria attribute - fix #10254 2024-04-02 17:23:25 +02:00
Corinne Durrmeyer
d54bac71bf
feat(move_after_edit_list) : Improve the "move after" edit list - fix #10206 2024-04-02 17:23:25 +02:00
Corinne Durrmeyer
a5a7e880eb
feat(move_after_edit_list) : Correct a typo - fix #10254 2024-04-02 17:23:25 +02:00
LeSim
2ea45d5dba
Merge pull request #10251 from colinux/exports-reduce-memory
Tech (exports): télécharge les PJ > 10mb en chunks pour ne pas les mettre en mémoire
2024-04-02 14:48:33 +00:00
Colin Darie
fe12df1892
Merge pull request #10252 from demarches-simplifiees/more_log_to_adresse_controller
Tech: ajoute des metadata pour débugger un pb sur l'adresse controller
2024-04-02 14:16:37 +00:00
Paul Chavard
94aef62e87
Merge pull request #10253 from tchak/chore-task-stable-id
chore(task): reduce batch size of fill stable id task
2024-04-02 14:10:22 +00:00
Paul Chavard
61a6f0b382
Merge pull request #10243 from demarches-simplifiees/small_job_fixes
Tech: petites corrections pour éviter les réessais inutile sur les jobs de mail et de rnf
2024-04-02 14:09:55 +00:00
Paul Chavard
792bf47658 chore(task): reduce batch size of fill stable id task 2024-04-02 15:55:44 +02:00
Colin Darie
e23e2d9c31
perf(export): download in chunks files >= 10 mb 2024-04-02 15:54:46 +02:00
simon lehericey
57927a3783
chore: more log to address controller errors 2024-04-02 15:47:11 +02:00
mfo
b245d9b063
Merge pull request #10220 from demarches-simplifiees/fix-drop-down-missing-hint
ETQ usager : Champ choix multiple, ajouter une aide a a la saisie
2024-04-02 09:28:34 +00:00
mfo
84f0891a8b
Merge pull request #10245 from demarches-simplifiees/US/fix-attestation-link
correctif(lien.attestation): ETQ expert, je souhaite avoir accès à l'attestation même si je ne suis pas instructeur
2024-04-02 08:14:37 +00:00
mfo
e40ef51f61
Merge pull request #10247 from colinux/fix-export-memory-leak
Tech: fix memory leak pendant le téléchargement des PJ des exports
2024-04-02 08:14:28 +00:00
mfo
3a895fbd4a
tech(review): add a guard clause to prevent missing pdf, enhance specs 2024-04-02 10:04:22 +02:00
simon lehericey
8405c83c12
fix: do not retry rnf bad request 2024-04-02 10:00:07 +02:00
simon lehericey
dd6c558541
fix: discard deserialization error as there are raised from AR not found 2024-04-02 10:00:06 +02:00
mfo
4da36531d4
Merge pull request #10242 from demarches-simplifiees/US/fix-decimal-number-validator
Correctif(annotations privées): ETQ instructeur, je ne pouvais modifier une annotation quand un usager avait saisi des valeur de champs incorrectes
2024-04-02 07:13:07 +00:00
Colin Darie
f9af570cab perf(export): fix memory leak after large files downloads 2024-04-01 20:03:35 +02:00
Paul Chavard
13005b0a4a fix(dossier): enqueue jobs after commit 2024-04-01 19:00:25 +02:00
Paul Chavard
5d302fb6ac refactor(dossier): extract aasm callbacks in to a concern 2024-04-01 18:55:08 +02:00
mfo
e08aa7d28b
wip(validates): prefill and validate_champ_value? on all other missing validation checks 2024-04-01 07:36:14 +02:00
mfo
284a10e235
fix(Champs::EngagementJuridiqueChamp): validates Champs::EngagementJuridiqueChamp respecting it's validation context. 2024-04-01 07:18:14 +02:00
mfo
ff527517c9
fix(Champs::CiviliteChamp): validates Champs::CiviliteChamp respecting it's validation context. 2024-04-01 07:18:14 +02:00
mfo
94ea16c894
fix(Champs::BooleanChamp): validates Champs::BooleanChamp respecting it's validation context. 2024-04-01 07:18:14 +02:00
mfo
d7f152f4af
fix(Champs::PhoneChamp): validates Champs::PhoneChamp respecting it's validation context. 2024-04-01 07:18:14 +02:00
mfo
374d763084
fix(Champs::IntegerNumberChamp): validates Champs::IntegerNumberChamp respecting it's validation context. 2024-04-01 07:18:13 +02:00
mfo
fd5faad31f
fix(Champs::PaysChamp): validates Champs::PaysChamp respecting it's validation context. Also do not save value when external_id/code can't be found by lookup 2024-04-01 07:18:13 +02:00
mfo
04f3b6a844
fix(Champs::DecimalNumberChamp): validates Champs::DecimalNumberChamp respecting it's validation context 2024-04-01 07:07:11 +02:00
Martin
2944a0c2c3
fix(expert.attestation.url): was pointing to attestation_instructeur_dossier_path, so did not worked when expert was not instructeur. use active_storage_link, secured enough because served to authenticated users as well as expiring link 2024-03-30 06:20:11 +01:00
Paul Chavard
46c5830306
Merge pull request #10238 from demarches-simplifiees/fix-mailbox-missing-link
ETQ usager : ajout d'un lien vers la messagerie dans les dossiers en attente de correction
2024-03-28 16:56:17 +00:00
Paul Chavard
3c336c437a chore(task): optimize maintenance task 2024-03-28 17:35:17 +01:00
Corinne Durrmeyer
d5af837872 feat(messagerie_missing_link): Add link to messaging system in the alert block - fix #10198 2024-03-28 11:55:09 +01:00
Eric Leroy-Terquem
78530f9823
fix(fermeture): redirect to commencer if procedure not closed 2024-03-27 12:16:04 +01:00
Lisa Durand
65b8f6881a
Merge pull request #10143 from demarches-simplifiees/float-too-many-decimal-ldu
ETQ admin, je veux que le champ nombre décimal ne prenne que 3 chiffres après la virgule
2024-03-27 10:05:35 +00:00
Lisa Durand
a3ab6dd257 add validation on decimal max 3 digits after coma 2024-03-27 10:55:10 +01:00
mfo
465de75e6b
Merge pull request #10215 from demarches-simplifiees/US/catch-oomed-jobs
tech(export_job): sometimes ExportJob are OOMed, in those cases jobs are stuck and never retried. release lock and increase attempts
2024-03-27 09:34:46 +00:00
Kara Diaby
bfc68f8377
Merge pull request #10216 from demarches-simplifiees/dark_mode_admin_mails
ETQ Admin, je souhaite voir l'éditeur de mail adapté au dark mode
2024-03-26 20:04:21 +00:00
Corinne Durrmeyer
ba290110e5 feat(multiple_drop_down_list): Replace blank option 2024-03-26 15:39:27 +01:00
Martin
be47152096 tech(export_job): sometimes ExportJob are OOMed, in those cases jobs are stuck and never retried. release lock and increase attemps 2024-03-26 15:29:04 +01:00
Corinne Durrmeyer
ab6a76ad46 feat(multiple_drop_down_list) : Add missing space - fix #10185 2024-03-26 15:27:59 +01:00
Colin Darie
d161589e2f fix(api-entreprise): Context is not defined in jobs 2024-03-26 12:45:28 +01:00
Paul Chavard
06d81dcfaf
Merge pull request #10169 from tchak/refactor-champ-public_id
fix(champ): use public_id in views
2024-03-26 10:31:13 +00:00
Paul Chavard
6ad0b901b6 fix(champ): use public_id in views 2024-03-26 11:23:23 +01:00
Kara Diaby
8da7ff7eaa editeur mail administrateur : adaptation pour le dark mode 2024-03-26 11:14:17 +01:00
Paul Chavard
b02ba1e909 feat(textarea): autoresize textareas 2024-03-25 19:53:29 +01:00
Colin Darie
b3d2ca1486
Merge pull request #10203 from colinux/dev-warn-visible
Tech: bannière indiquant staging / env de test plus visible
2024-03-25 17:31:03 +00:00
Colin Darie
6977d0e89f
style(dev): staging env more visible 2024-03-25 15:58:55 +01:00
Paul Chavard
f589129ef5 chore(attachment): remove unused replace code 2024-03-25 15:13:14 +01:00
Eric Leroy-Terquem
536a03bbb4
Merge pull request #10180 from demarches-simplifiees/update-bulk-messages-associations
Technique : Mise à jour de l'association bulk messages - procédures
2024-03-25 13:35:23 +00:00
Eric Leroy-Terquem
b1e8c2ab49
Merge pull request #10182 from demarches-simplifiees/remove-closing-attributes-from-cloned-procedures
Correctif : supprime les closing attributes lors du clonage d'une démarche
2024-03-25 13:23:27 +00:00
Eric Leroy-Terquem
7d28a2f38b
Merge pull request #10132 from demarches-simplifiees/add-alert-on-accepted-files-if-closed-procedure
ETQ usager je vois un message d'alerte dans la liste de mes dossiers sur mes dossiers terminés sur une démarche close
2024-03-25 10:24:34 +00:00
Eric Leroy-Terquem
d01cd3a310
refacto(dossier list): do not use html safe 2024-03-25 11:16:06 +01:00
Eric Leroy-Terquem
bfd4ae9d50
refacto(dossier list): use model method en_construction_ou_instruction? 2024-03-25 11:15:35 +01:00
Eric Leroy-Terquem
5754d01242
feat(dossier): add alert on dossiers list for dossiers termines on closed procedures 2024-03-25 11:15:34 +01:00
Colin Darie
e31cd40adc fix(banner): correct http/https protocol for dev/prod 2024-03-25 09:54:05 +01:00
Eric Leroy-Terquem
a726d34404 fix(cloned procedures): reset closing attributes 2024-03-22 17:07:22 +01:00
Eric Leroy-Terquem
e712cf5f23 task(procedure): fix open procedures with closing reason 2024-03-22 16:00:36 +01:00
Eric Leroy-Terquem
773de2dbf2 chore(groupe_instructeurs): do not reaffect bulk messages anymore 2024-03-22 14:56:54 +01:00
Eric Leroy-Terquem
30f96a79c2 chore(bulk messages): update associations 2024-03-22 14:52:34 +01:00
Martin
2281e3de4b fixup! feat(type_de_champ_editor): move champs after another champ. 2024-03-22 10:10:28 +01:00
Martin
8eb6e5d6bb feat(type_de_champ_editor): can't move champ after his previousSibling, nor after himself, noop 2024-03-22 10:10:28 +01:00
Martin
44cdb14fb9 feat(type_de_champ_editor): move champs after another champ. 2024-03-22 10:10:28 +01:00
Martin
b8a155a7ee feat(type_de_champ_editor): show tdc position indexed starting at 1 not 0 2024-03-22 10:10:28 +01:00
Martin
0cff8668fa fix(dossier.pdf): code path not tested reached a typo 2024-03-22 09:26:50 +01:00
Martin
862af8a9f6 fix(dosser#show.pdf): missing user indirection on fci 2024-03-22 08:45:19 +01:00
Martin
015e606f50 fix(dossier.has_many.france_connect_informations): wip 2024-03-22 07:47:02 +01:00
Colin Darie
b6526cfad9
Merge pull request #10172 from colinux/fix-banner-domain
Tech: fix pour la bannière du domaine
2024-03-21 21:04:30 +00:00
simon lehericey
46087e4577 raise Error if generation fail 2024-03-21 21:03:21 +01:00
simon lehericey
76f7222e7a add metadata to pdf 2024-03-21 21:03:21 +01:00
simon lehericey
77744f510e add upstream context to weasyprint html generation 2024-03-21 21:03:21 +01:00
LeSim
a8f2274939
Merge pull request #10174 from demarches-simplifiees/do_not_cache_application_name_on_landing
Tech: sort le nom de l'application du cache dans la page de landing
2024-03-21 18:08:52 +00:00
mfo
d00b146dc3
Merge pull request #10165 from mfo/US/add_champ_descriptor_id
feat(api): add champs.champDescriptorId so champRepetitions.rows[x] has a uniq id
2024-03-21 17:05:56 +00:00
simon lehericey
5c416105ee do not cache application name on landing 2024-03-21 17:38:00 +01:00
Colin Darie
d8b35e2e77 feat(banner-domain): hide error msg by default because while redirecting, we briefly see the banner 2024-03-21 17:20:03 +01:00
Colin Darie
dd0dba2959 fix(domain-banner): oops 2024-03-21 17:18:54 +01:00
Colin Darie
17f9992722
Merge pull request #10040 from colinux/cross-domain-component
Prépare la bannière informant du changement de nom de domaine, avec redirection automatique le cas échéant
2024-03-21 14:58:29 +00:00
Eric Leroy-Terquem
058350df53 fix(administrateur): can delete administrateur with a discarded procedure with no dossier 2024-03-21 14:27:53 +01:00
Eric Leroy-Terquem
9139bfbf48 clean(administrateur): remove dead code 2024-03-21 14:27:53 +01:00
Eric Leroy-Terquem
6a77bbb6c9 fix(administrateur): can be deleted only if other admin or dossiers on all procedures included with discarded 2024-03-21 14:27:52 +01:00
simon lehericey
fa47eea07e oups 2024-03-21 14:01:52 +01:00
Colin Darie
f768801b7d
feat(registration): set preferred host on signup/signin 2024-03-21 13:15:36 +01:00
Colin Darie
41a02d1ead
feat: notify sentry when connection test on new host fail 2024-03-21 13:15:35 +01:00
Colin Darie
2f4444bd5e
chore: mark preferred domain to new domain when closing notice 2024-03-21 13:15:34 +01:00
Colin Darie
a16f88f8af
chore(schema): add preferred_domain to users 2024-03-21 12:21:19 +01:00
Colin Darie
4dd24f0925
chore: cross domain banner between APP_HOST_LEGACY and APP_HOST 2024-03-21 12:21:16 +01:00
simon lehericey
2ea6a5d25c remove now useless biz_dev module 2024-03-21 11:54:03 +01:00
simon lehericey
a42f85ef05 remove useless administration_id in invite_admin and invite_administrateur! 2024-03-21 11:54:02 +01:00
Martin
22fa2e61b4 feat(api): add champs.champDescriptorId so champRepetitions.rows[x] has a uniq id 2024-03-21 10:29:33 +01:00
simon lehericey
44b113e433 fix brakeman 2024-03-21 10:06:09 +01:00
simon lehericey
1dfd3bf573 use Current.application_base_url in app 2024-03-21 10:06:09 +01:00
simon lehericey
4c3b0229eb set Current.application_base_url 2024-03-21 10:06:09 +01:00
simon lehericey
72a2b764dc add demarches.gouv.fr as sender of automatic emails 2024-03-21 10:06:09 +01:00
simon lehericey
edc4e60b81 use Current.contact_email in app 2024-03-21 10:06:09 +01:00
simon lehericey
d13910dac4 set Current.contact_email 2024-03-21 10:06:09 +01:00
simon lehericey
efa35e04a5 use Current.application_name in app excluding mail 2024-03-21 10:06:09 +01:00
simon lehericey
b9fcb25f1a set Current.application_name 2024-03-21 10:06:08 +01:00
Kara Diaby
6222a3b797
Merge pull request #10164 from demarches-simplifiees/feat/10151
ETQ instructeur, je souhaite voir la gestion des notifications instructeurs au DSFR
2024-03-21 08:51:07 +00:00
Eric Leroy-Terquem
a89b471b5c
Merge pull request #10163 from demarches-simplifiees/fix-bulk-message-maintenance-task
fix(maintenance task): fix query and add a test
2024-03-21 08:26:09 +00:00
Kara Diaby
84890f954b gestion des notifications instructeurs au DSFR 2024-03-21 04:02:53 +00:00
mfo
086cc1537b
Merge pull request #10068 from mfo/US/user-has-many-fcis
tech(User.FranceConnect): un usager peut avoir plusieurs profils FranceConnect, pas uniquement un
2024-03-20 16:30:39 +00:00
Eric Leroy-Terquem
dd7a407187 fix(maintenance task): fix query and add a test 2024-03-20 15:24:21 +01:00
Eric Leroy-Terquem
73d6609eb3
Merge pull request #10158 from demarches-simplifiees/fix-closing-reason-form
Correctif : ETQ admin je ne peux pas fermer une démarche en redirigeant sans choisir la nouvelle démarche
2024-03-20 13:28:40 +00:00
Lisa Durand
6c5c744411
Merge pull request #10119 from demarches-simplifiees/add-explanation-when-publish-with-same-url-ldu
ETQ admin j'ai un message d'explication si j'utilise une URL déja utilisée lors de la publication d'une démarche
2024-03-20 13:21:59 +00:00
Eric Leroy-Terquem
280f1ac3c7 refactor(procedure): add a prefix to closing_reason enum 2024-03-20 14:04:59 +01:00
Eric Leroy-Terquem
579fe2c933 chore(procedure): remove unnecessary safe operator 2024-03-20 14:04:59 +01:00
Eric Leroy-Terquem
234f0d7a75 fix(data): update closing_reason to other if no replaced_by_procedure_id 2024-03-20 14:04:59 +01:00
Eric Leroy-Terquem
e55531c6f4 fix(procedure): validates presence of replaced_by_id if procedure redirected 2024-03-20 14:04:59 +01:00
Lisa Durand
db244c821b remove ununcessary instance variable for current admin 2024-03-20 11:24:24 +01:00
Paul Chavard
eff03aaf23 refactor(dossier): label indexes based on type_de_champ not champ 2024-03-20 09:58:47 +01:00
Paul Chavard
33125c691e
Merge pull request #10145 from tchak/fix-clone-with-stable-id
fix(champ): fill stable_id and stream when cloning from old champs
2024-03-20 08:29:12 +00:00
simon lehericey
75db5ee320 replace AGENT_CONNECT_ENABLED and move AC conf to optionnal env 2024-03-19 21:17:45 +01:00
simon lehericey
df0298ac42 simply deal with multiple agent_connect_information by taking the last used 2024-03-19 21:17:45 +01:00
simon lehericey
ca17524559 Allow instructeur to have multiple agent_connect_information
AC will return two different sub depending of the domain demarches.gouv.fr or ds.
Both agent_connect_information are stored and the corresponding instructeur is found by its email.
We do not store anymore the agent_connect_id on the instructeur as the are many.
2024-03-19 21:17:45 +01:00
simon lehericey
2f6147308c use ac gouv conf when needed 2024-03-19 21:17:44 +01:00
simon lehericey
bdcc65ff4a fix: delete AgentConnect cookies instead of nullify 2024-03-19 21:17:44 +01:00
simon lehericey
759d729bf3 use AC autoconf discovery end_session_endpoint 2024-03-19 21:17:44 +01:00
simon lehericey
916407ec95 remove secret indirection and fetch AC conf once for all 2024-03-19 21:17:44 +01:00
simon lehericey
4997a81639 remove one indirection 2024-03-19 21:17:44 +01:00
Colin Darie
ee4af30725
Merge pull request #10153 from colinux/fix-closing-procedure-not-found
ETQ usager, pas d'erreur 500 lorsque j'accède à une démarche "fermée" qui n'existe pas
2024-03-19 15:31:46 +00:00
Colin Darie
0977bd39d9
Merge pull request #10155 from demarches-simplifiees/tchak-patch-1
task(champs): update champs for each dossier
2024-03-19 15:29:37 +00:00
Paul Chavard
40fb95978a
each -> find_each 2024-03-19 16:20:24 +01:00
Colin Darie
02cb64aa6e fix(combo-legacy): fieldset group has changed its id pattern 2024-03-19 16:16:45 +01:00
Paul Chavard
bda2d80dea
task(champs): update champs for each dossier 2024-03-19 16:08:56 +01:00
Colin Darie
b686e299a1
fix(procedure): format date with I18n helper 2024-03-19 14:46:02 +01:00
Colin Darie
370aa074d2
fix(procedure): don't crash when procedure does not exist on /fermerture path 2024-03-19 14:46:00 +01:00
Paul Chavard
8479300328 fix(champs): run mentainance task on all records 2024-03-19 14:25:36 +01:00
Paul Chavard
ebe762ee5d
Merge pull request #10146 from colinux/fix-champ-built-updated-at
Tech: pas de comparaison avec champ#updated_at lorsque le champ n'est pas persisté
2024-03-19 11:38:48 +00:00
Colin Darie
455086c1d7
fix(champs): don't fail on updated_at comparison when champ is not persisted 2024-03-19 11:46:08 +01:00
Paul Chavard
f2b3cbcf2e
Merge pull request #10147 from mfo/clean-fix-champ-missing
tech(clean): drop unusable maintenance task
2024-03-19 08:32:09 +00:00
Martin
291e6b0550 fix(fix_missing_champs_task): rake_puts present in spec, not in prod 2024-03-19 09:18:30 +01:00
Martin
9d94448763 tech(clean): drop unusable task (i'm not able to use my own csv_collection for task maintenance [that the expected format?, who knows]). now use https://github.com/demarches-simplifiees/demarches-simplifiees.fr/pull/10139, takes an array of procedure, find dossiers with missing champs, run the fixer. 2024-03-19 05:28:38 +01:00
Paul Chavard
a962e2d94e fix(champ): fill stable_id and stream when cloning from old champs 2024-03-18 20:04:53 +01:00
Paul Chavard
0f93ea2156 fix(dossier): select the right stable_id 2024-03-18 19:20:10 +01:00
mfo
aafe6a7bb6
Merge pull request #10139 from mfo/US/fix-missing-champs-task
fix(data): apply fix missing champ via task. FV dossiers are poping way too much at helpdesk
2024-03-18 17:26:45 +00:00
Paul Chavard
a9166c8d8e
Merge pull request #10140 from tchak/fix-count-in-mentenance-task
fix(champs): use approximate count in the task
2024-03-18 17:09:12 +00:00
Paul Chavard
c5892a1ca2
Merge pull request #10141 from tchak/fix-rows-order
fix(champs): fix rows order
2024-03-18 16:56:21 +00:00
Martin
2dac74916f fix(data): apply fix missing champ via task. FV dossiers are poping way too much at helpdesk
Co-authored-by: Colin Darie <colin@darie.eu>
2024-03-18 17:53:21 +01:00
Paul Chavard
f21192bb06
Merge pull request #10123 from tchak/fix-multiple-champ-copies-bug
fix(champ): fix multiple champ copies bug
2024-03-18 16:46:17 +00:00
Paul Chavard
818dcc32da fix(champs): fix rows order 2024-03-18 17:26:41 +01:00
Paul Chavard
750b38bbf4 fix(champs): use approximate count in the task 2024-03-18 17:06:24 +01:00
Lisa Durand
72c4b23821 add last_champ_updated_at in export 2024-03-18 16:10:26 +01:00
simon lehericey
dca3727253 proper agent connect logout mechanism 2024-03-18 14:02:53 +01:00
simon lehericey
597342fe9d small session refactor 2024-03-18 14:02:53 +01:00
simon lehericey
31b84fd770 store id_token 2024-03-18 14:02:53 +01:00
simon lehericey
063445b892 add logout route 2024-03-18 14:02:18 +01:00
Kara Diaby
e73318e3bb
Merge pull request #10127 from demarches-simplifiees/feat/10005
ETQ expert, je veux pouvoir gérer les notifications que je reçois depuis mon interface
2024-03-18 12:27:37 +00:00
Kara Diaby
09d479321b corrections après retours 2024-03-18 11:50:29 +00:00
Kara Diaby
f41dcc69d8 model 2024-03-18 11:50:29 +00:00
Kara Diaby
9424d020bc controller 2024-03-18 11:50:29 +00:00
Kara Diaby
24d67dc6f3 concern 2024-03-18 11:50:29 +00:00
Kara Diaby
e824118aea layout 2024-03-18 11:50:29 +00:00
Lisa Durand
b8cf19337f
Merge pull request #10131 from demarches-simplifiees/wording-page-stats-ldu
ETQ instructeur je souhaite mieux comprendre le graph "avancée des dossiers" en changeant le terme "démarrés"
2024-03-18 11:49:20 +00:00
Paul Chavard
1b2315cd45 fix(champ): fix multiple champ copies bug 2024-03-18 12:13:22 +01:00
Colin Darie
61c203e97e
Merge pull request #10122 from goulvench/patch-1
[Nitpick] Adjust vertical spacing in segmented-control-item
2024-03-18 11:12:35 +00:00
Paul Chavard
e8b2e77b65
Merge pull request #10133 from demarches-simplifiees/add-owner-on-dossier-list-when-many-invitations-ldu
ETQ invité, ajouter l'owner du dossier dans la liste des dossiers
2024-03-18 11:03:16 +00:00
Paul Chavard
8abe3fce79 add stable_id and stream 2024-03-18 11:34:55 +01:00
Lisa Durand
93c21d5639
use method to display email (PR review)
Co-authored-by: Paul Chavard <paul.chavard@beta.gouv.fr>
2024-03-18 11:27:50 +01:00
Lisa Durand
90331f6e52 add dossier owner on dossier list when there is invitation 2024-03-18 11:15:39 +01:00