sebastiencarceles
11fed2c934
review: champs exist because stable ids exist
2022-12-08 15:27:39 +01:00
sebastiencarceles
a5c1c68a91
review: style
2022-12-08 15:27:39 +01:00
Sébastien Carceles
9dfb498806
review: prefer if to unless
...
Co-authored-by: LeSim <mail@simon.lehericey.net>
2022-12-08 15:27:39 +01:00
Damien Le Thiec
006a1257b5
Refacto prefill_params construction (remove merge)
2022-12-08 15:27:39 +01:00
sebastiencarceles
373e8aeadb
review: validate prefilled champs only
2022-12-08 15:27:39 +01:00
sebastiencarceles
1e21a3d3e1
review: query the db only once
2022-12-08 15:27:39 +01:00
sebastiencarceles
ab30af5fe5
review: move Prefillable to concern directory
2022-12-08 15:27:39 +01:00
sebastiencarceles
3939644030
validate prefilled champs when editing brouillon
2022-12-08 15:27:39 +01:00
sebastiencarceles
79ef48cafb
make the dossier prefillable
2022-12-08 15:27:39 +01:00
sebastiencarceles
f4e1a09e73
prepare prefilled values from ctrl params
2022-12-08 15:27:39 +01:00
sebastiencarceles
24802985a2
feat(dossier): prefill dossier from query params
2022-12-08 15:27:39 +01:00
Paul Chavard
52a32051c4
feat(dossier): add dossier.champs_public_all
2022-12-08 09:38:12 +01:00
Paul Chavard
d513c364d8
feat(cond): enable conditional on champs in repetitions
2022-12-08 09:38:12 +01:00
Paul Chavard
6ce7064ffd
feat(dossier): add repetition champs to champs_for_condition
2022-12-08 09:38:12 +01:00
Colin Darie
40a1eaaaed
fix(annuaire-education): schema should not require adresse_1, type_contrat_prive attributes
...
https://sentry.io/organizations/demarches-simplifiees/issues/3328955794/events/147affe4b73b43a391c257b97d298bb9/?project=1429550
2022-12-07 22:23:34 +01:00
simon lehericey
fe8bd15939
feat(timestamp): ensure signature is openssl compatible
2022-12-07 19:28:01 +01:00
simon lehericey
86cda6a0b9
fix(timestamp spec): rewind io after before_save check
2022-12-07 19:28:01 +01:00
simon lehericey
de2c5c69be
feat(timestamp): use certigna to timestamp
2022-12-07 19:28:01 +01:00
simon lehericey
172a9d5599
feat(timestamp): add certigna
2022-12-07 19:28:01 +01:00
Paul Chavard
52c8fc7e8d
feat(api_token): api v2 use new token
2022-12-07 18:19:37 +01:00
Paul Chavard
a47a056ee8
feat(api_token): api v1 use new token
2022-12-07 18:19:37 +01:00
Paul Chavard
3c21090a88
feat(api_token): add profile api token card
2022-12-07 18:19:37 +01:00
Paul Chavard
3d1f57df83
feat(api_token): add api token controller
2022-12-07 18:19:37 +01:00
Paul Chavard
ebbada752f
feat(api_token): add APIToken model
2022-12-07 18:19:37 +01:00
Lisa Durand
64134d1b08
fix deleted notification in table after batch feature implementation
2022-12-07 16:21:15 +01:00
Paul Chavard
30a5c592e6
refactor(graphql): use shorthand syntax in mutations
2022-12-07 13:21:55 +01:00
Paul Chavard
4fe081e4be
fix(dossier): send notifications on declarative dossiers
2022-12-07 13:14:59 +01:00
Paul Chavard
bb47e8d2ab
fix(dossier): dossier.repasser_en_construction! should take disable_notification
2022-12-07 13:14:59 +01:00
Paul Chavard
e6fa7f0a9f
feat(graphql): update stored query to use files instead of file
2022-12-07 12:06:55 +01:00
Paul Chavard
c008cad1f9
feat(graphql): prepare avis and messages to handle multiple files
2022-12-07 12:06:55 +01:00
Colin Darie
f4eb32af29
fix(messagerie): attachment open in new tab
2022-12-06 16:44:24 +01:00
Colin Darie
182bfcd3e3
style(attachment): delete button replaces bullet when user can download + destroy
2022-12-06 16:37:10 +01:00
Colin Darie
5b20713893
style(attachment): fix antivirus badge when uploading as downloadable
2022-12-06 16:37:10 +01:00
Colin Darie
f4d403a81c
fix(apiv1): piece_justificative continue to returns a single attachment
2022-12-06 15:47:06 +01:00
Martin
2eaa06b22b
correctif(export.pjs): sur l'export, les champs de type piece justificative renvoyent un tableau de la meme dimension quelque soit le nombre de pj joint
2022-12-06 15:22:53 +01:00
Paul Chavard
b8a9b7223c
refactor(groupe_instructeur): improuve controller
2022-12-06 12:01:54 +01:00
Paul Chavard
f49a1baeec
refactor(groupe_instructeur): remove mailer should take a list of instructeurs
2022-12-06 12:01:54 +01:00
Paul Chavard
9fe93ded7f
refactor(groupe_instructeur): add instructeur.find_or_invite
2022-12-06 12:01:54 +01:00
Colin Darie
4ba76e6844
fix(api-v1): dossier -> avis -> piece_justificative_file_attachment relation name
2022-12-06 11:48:42 +01:00
Paul Chavard
ed4d5cb36a
refactor(demarche): make declarative demarche processing syncroneous
2022-12-06 11:41:25 +01:00
Martin
91ef618a42
clean(code): stick to usage of present?/empty? instead of count zero etc
2022-12-06 11:28:48 +01:00
Martin
8f1478b00f
clean(deadcode): remove deadcode
2022-12-06 11:28:48 +01:00
Martin
b5f69c8961
review(dossier.reload): evite de recharger le batch qui peut etre confusant
2022-12-06 11:28:48 +01:00
Martin
7c65af3be0
poc(batch_operation_alert): simplier wording
2022-12-06 11:28:48 +01:00
Lisa Durand
3d2f0ebb88
add icon on submit button and simplify i18n
2022-12-06 11:28:48 +01:00
Martin
ea8bd13bcf
poc(batch_operation.purge): nettoie les batch terminé ou inutiles
2022-12-06 11:28:48 +01:00
Martin
6556fda218
clean(spec): rubocopify / fix specs
2022-12-06 11:28:48 +01:00
Lisa Durand
0563ac391b
small css adjustements to improve table display
2022-12-06 11:28:48 +01:00
Martin
b0ae2e8a0f
clean(spec): rubocopify / fix specs
2022-12-06 11:28:48 +01:00
Martin
5875f9b572
spec(batch_operation): system spec batch operation poc
2022-12-06 11:28:48 +01:00
Lisa Durand
7b3cbcb8f6
display batch operation alerts
2022-12-06 11:28:48 +01:00
Lisa Durand
2615da1e28
setup seen_at to hide alert when batch is finished and alert has been seen
2022-12-06 11:28:48 +01:00
Lisa Durand
6859882a58
display batch operation alert to instructeur groups not only instructeur
2022-12-06 11:28:48 +01:00
Lisa Durand
c52443f221
change flash alert wording and display message in show if dossier is in batch
2022-12-06 11:28:48 +01:00
Lisa Durand
1beb219fdd
display batch operation alerts
2022-12-06 11:28:48 +01:00
Martin
e5944eed34
poc(batch_operation): habtm groupe instructeurs, permettra de visualiser plus facilement les batch en cours pour les instructeurs du meme groupe
2022-12-06 11:28:48 +01:00
Martin
eaf72162da
poc(batch_operation): some rewrite to avoid various conflict (when an instructeur try to create a job with an incompatible dossier regarding the current task). also soome cleanup to isole spec in least involved model
2022-12-06 11:28:48 +01:00
Martin
4266ab93c5
poc(batch_operation): track dossier processed safely
2022-12-06 11:28:48 +01:00
Martin
7a51ecec5d
poc(batch_operation): quand un dossier est dans un batch, impossible de faire les actions : archive, unarchive, follow, unfollow, passer_en_instruction, repasser_en_construction, repasser_en_instruction, terminer, restore, destroy, extend_conservation
2022-12-06 11:28:48 +01:00
Martin
35dbc4021e
poc(batch_operation): show locked files
2022-12-06 11:28:48 +01:00
Martin
beb39027d0
poc(batch_operation.ui): implement simple ui to trigger a batch of current page
2022-12-06 11:28:48 +01:00
Martin
7df86c50fb
poc(batch_operations_controller): implement simple [not yet with procedure_presentation] action to create a batch operation
2022-12-06 11:28:48 +01:00
Martin
b11dbafc59
poc(batch_operation_job): implement archive dossiers with async behaviour, lock, run_at, finished_at, failed_dossier_ids, success_dossier_ids
2022-12-06 11:28:48 +01:00
Martin
61f4cded75
poc(batch_operation): just the model and some specs and a poc for archive them without async
2022-12-06 11:28:48 +01:00
Martin
9193581ae2
correctif(admin/procedures/configuration): pour une procedure, la tuile instructeurs est considérée valide si le routage est activé ou si il y a des instructeurs declarés
...
Update app/components/procedure/card/instructeurs_component/instructeurs_component.html.haml
Co-authored-by: Paul Chavard <github@paul.chavard.net>
2022-12-06 10:20:17 +01:00
Colin Darie
a2e80cfcca
fix(clone-rescue): when record was invalid
2022-12-05 18:19:17 +01:00
Colin Darie
00e1e90cb6
fix: multipart upload on instructeurs import & acceptation avec PJ
...
Les options html dans un `form_tag` ne doivent pas être définies
sous la clé `html` mais directement à la "racine".
Fix régression introduite dans #7958
2022-12-05 17:28:12 +01:00
Martin
1cdfc9ded0
amelioration(liens-de-telechargement): permet de specifier si le lien de téléchargement se fait sur l'onglet actuel ou vers un nouvel onglet
2022-12-05 15:59:50 +01:00
simon lehericey
8771205679
clean(flipper): remove unused expert_not_allowed_to_invite
2022-12-05 12:22:29 +01:00
Colin Darie
f7d6350e05
fix(a11y/identite): indicates that all fields are required
...
Closes #8096
2022-12-05 11:37:36 +01:00
Colin Darie
b9d6397a9b
fix(pj_template): private proxy template url so their links are non expirable
...
Closes #7920
2022-12-05 11:30:00 +01:00
Colin Darie
c98021e58a
chore(attachment): input name attribute follows form object name for nested attributes
2022-12-05 10:47:10 +01:00
Colin Darie
6e8302101f
fix(attachments): cleanup useless kwarg
2022-12-05 10:47:10 +01:00
Colin Darie
cb2afc74b0
style(attachments): better UX when we can try to upload without network
2022-12-05 10:47:10 +01:00
Colin Darie
42b84384dd
fix(a11y/attachment): associate input to label, no empty id
2022-12-05 10:47:10 +01:00
Colin Darie
1db40de70e
style(attachments): improve when we can download our multiple attachments (dossier en_construction)
2022-12-05 10:47:10 +01:00
Colin Darie
920f90d2e3
chore(titre_identite): render template if exists
2022-12-05 10:47:10 +01:00
Colin Darie
3e617f34ec
chore(admin): can download an uploaded PJ template
2022-12-05 10:47:10 +01:00
Colin Darie
42363e0b0d
refactor(attachment): extract PendingPoll component
2022-12-05 10:47:10 +01:00
Colin Darie
b110e58f2f
refactor(attachment): extract i18n
2022-12-05 10:47:10 +01:00
Colin Darie
2f84346ba3
fix(dossier/sticky-footer): above dsfr buttons have a z-index = 1
2022-12-05 10:47:10 +01:00
Colin Darie
fe0312b1d7
style(procedure/form): fix bg on input file within non-dsfr forms
2022-12-05 10:47:10 +01:00
Colin Darie
e3ddb7779f
fix(form): multipart option must be set under "html" to ensure rendering as expected
2022-12-05 10:47:10 +01:00
Colin Darie
6ac0114992
test(attachments): more components tests & improvements
2022-12-05 10:47:10 +01:00
Colin Darie
fefc326e6b
refactor(attachment): extract shared Attachment::ProgressComponent
2022-12-05 10:47:10 +01:00
Colin Darie
7cbe6bbaa4
fix(attachment): clone piece justificatives with multiple attachments
2022-12-05 10:47:10 +01:00
Colin Darie
b609c3dae4
refactor(attachment): bring batch user_can_destroy, update tests
2022-12-05 10:47:10 +01:00
Colin Darie
df135b080b
refactor(attachment): remove useless id
arg
2022-12-05 10:47:10 +01:00
Colin Darie
0a114270af
refactor(attachment): update Attachment::EditComponent everywhere
2022-12-05 10:47:10 +01:00
Colin Darie
b13c5e56f6
refactor(piece_justificative): UX follows mockups
2022-12-05 10:47:10 +01:00
Colin Darie
84ca01bdf7
fix(piece_justicative): don't modify validator accepted formats in place
...
Previous implementation caused to add multiple times ".acidcsa".
2022-12-05 10:47:10 +01:00
Colin Darie
3e992589c5
style(piece_justificative): input ux & list accepted formats
2022-12-05 10:47:10 +01:00
Colin Darie
f66a0cf5a9
chore(piece_justificative): tells admins multiple files could be attached
2022-12-05 10:47:10 +01:00
Colin Darie
636645f686
refactor: minor piece_justificative_multiple? question mark use
2022-12-05 10:47:10 +01:00
Colin Darie
a726350f0d
feat(procedure): allow admin to enable multiple uploads for piece justificative on existing procedures
2022-12-05 10:47:10 +01:00
Colin Darie
3affd1660f
fix(api-v1): piece justificative serialization
2022-12-05 10:47:10 +01:00
Colin Darie
1f8d28c678
feat(piece_justificative): limit to 1 upload for existing procedures
2022-12-05 10:47:10 +01:00
Colin Darie
0014ce4b91
chore(schema): +procedures#piece_justificative_multiple
2022-12-05 10:47:10 +01:00
Colin Darie
ed1c6ec515
style(piece_justificative): use DSFR Téléchargement de fichiers for instructeurs & experts
2022-12-05 10:47:10 +01:00
Colin Darie
1138604748
feat(api): PieceJustificativeChamp: deprecate file
in favor of files
2022-12-05 10:47:10 +01:00
Colin Darie
6a0379086d
chore(piece_justificative): continue attachments refactor
2022-12-05 10:47:10 +01:00
Colin Darie
7ae6efe776
refactor(attachment): remove replace feature
2022-12-05 10:47:10 +01:00
Colin Darie
b8296c6d4d
feat(piece_justificative): supports multiple files
...
Closes #7924
2022-12-05 10:47:10 +01:00
Colin Darie
ab1928dc33
style(attachment): enable underlined link on refresh link
2022-12-05 10:47:10 +01:00
Colin Darie
91f4971df2
feat(champ): has_one_attached => has_many_attached piece_justificative_file
2022-12-05 10:47:10 +01:00
Colin Darie
ac234b7744
chore(footer): remove obsolete footer partial & i18n keys
2022-12-05 10:38:16 +01:00
Colin Darie
52b6502cbd
test(a11y): ensure we don't mix aria-label and title on main pages
...
Actuellement, on fait le choix de ne pas avoir d'éléments porteurs à la
fois d'aria-label et title.
Bien qu'en principe l'aria-label quand elle est gérée par un navigateur,
prenne précédence sur le title, en pratique un bug dans NVDA cumule les 2
et rend la navigation difficile.
On prend donc le parti (provisoire?) de n'avoir que l'un ou l'autre.
Nous gardons le title si l'info qu'il contient est également pertinente
pour les navigateurs graphiques qui l'affichent en guise de tooltip ;
autrement on bascule sur l'aria-label qui est plus largement supporté
par les navigateurs a11y.
2022-12-05 10:38:16 +01:00
Colin Darie
f653a25cc2
fix(i18n/a11y): translate "Edit file" button title
...
Closes #8136
2022-12-05 10:38:16 +01:00
Colin Darie
762942f468
chore(i18n): translate meta title for main user pages
2022-12-05 10:38:16 +01:00
Colin Darie
70d4d7848b
feat(i18n): more footer translations
2022-12-05 10:38:16 +01:00
Colin Darie
f15363e178
feat(i18n): basic home translation
2022-12-05 10:38:16 +01:00
Paul Chavard
36195acb29
feat(component): add CopyButtonComponent
2022-12-02 11:30:49 +01:00
Kara Diaby
1efcacd845
add copy button component
2022-12-02 11:30:49 +01:00
Kara Diaby
fe04244138
locales
2022-12-02 11:30:49 +01:00
Kara Diaby
d0ba0e2d63
layout
2022-12-02 11:30:48 +01:00
Kara Diaby
f5e4c28fc1
controller
2022-12-02 11:30:48 +01:00
Colin Darie
6803fbeddb
feat(instructeurs): list archiver email & date
2022-12-01 18:27:18 +01:00
Paul Chavard
00556715d6
fix(typography): fix quotes
2022-12-01 17:59:11 +01:00
Paul Chavard
886a409abf
fix(dossier): fix links to empty pdf templates
2022-12-01 17:35:01 +01:00
Paul Chavard
ece68076a7
feat(dossier): add some metadata to archive and remove operation log
2022-11-30 16:20:13 +01:00
Colin Darie
cd87390262
fix(a11y/dossiers): add a caption to dossiers table (critere 5.4)
...
Closes #8090
2022-11-30 13:41:13 +01:00
Colin Darie
80106bf4e6
fix(a11y/search): table th/td associations (critère 5.7)
...
Closes #8094
2022-11-30 13:41:13 +01:00
Colin Darie
3a2fae9cc2
fix(a11y): table having role=presentation (critere 5.3)
...
Closes #8154
2022-11-30 13:41:13 +01:00
Colin Darie
8baac2087e
style(mobile): fix burger menu alignment: we need a left icon (match UX)
2022-11-30 12:08:59 +01:00
Colin Darie
436c1951cc
fix(locale-switcher): attributes & wording issues
...
Cf #8059
2022-11-30 12:08:59 +01:00
Paul Chavard
a90dada104
fix(patron): dossier should have a procedure and champ should delegate to dossier
2022-11-30 10:54:03 +01:00
Colin Darie
8c16eb1543
fix(a11y): more external link having title saying it will open in new tab
2022-11-30 09:27:46 +01:00
Colin Darie
ff879eb0c2
fix(a11y/dossier): fix non explicit link (6.1)
...
Closes #8136
2022-11-30 09:27:46 +01:00
Colin Darie
edc2eaac30
fix(footer/home): add missing rel noopener/noreferer on external links
2022-11-30 09:27:46 +01:00
Colin Darie
4d00fcc2d9
fix(a11y/home): add missing title attributes
...
Cf #8050
2022-11-30 09:27:46 +01:00
Colin Darie
720995f48f
fix(a11y/footer): add "new tab" suffix on title links
...
Cf #8050
2022-11-30 09:27:46 +01:00
Colin Darie
e60fb1f0c1
fix(a11y/footer): img with alt for beta gouv logo
...
Cf #8050
2022-11-30 09:27:46 +01:00
Colin Darie
c55148f694
fix(a11y): root title link more explicit + i18n
...
Closes #8050
2022-11-30 09:27:46 +01:00
Paul Chavard
1fb051c3cc
refactor(attestation_template): remove unused code
2022-11-29 19:36:56 +01:00
Eric Leroy-Terquem
76605f2c0b
fix pagination
2022-11-29 17:46:30 +01:00
Paul Chavard
06f43f99d0
fix(dossier): excluded deleted dossiers from demarche overview
2022-11-29 16:41:31 +01:00
simon lehericey
bffd8015d8
fix(avis_controller): check revoked avis by default
2022-11-29 16:21:06 +01:00
simon lehericey
801d594efd
fix(avis_controller): revoked_acl on telecharger_pjs
2022-11-29 16:21:06 +01:00
simon lehericey
a84269e66e
fix(avis_controller): revoked acl on bilans_pdf
2022-11-29 16:21:06 +01:00
simon lehericey
d764959659
fix(avis_controller): revoked acl on create_commentaire
2022-11-29 16:21:06 +01:00
simon lehericey
8929af2767
fix(avis_controller): revoked acl on messagerie
2022-11-29 16:21:06 +01:00
simon lehericey
71dd0b99ab
fix(avis_controller): revoked acl on update_expert
2022-11-29 16:21:06 +01:00
simon lehericey
531cbf2612
fix(avis_controller): revoked acl on update
2022-11-29 16:21:06 +01:00
simon lehericey
3be17da70e
fix(avis_controller): revoked acl on update
2022-11-29 16:21:06 +01:00
simon lehericey
6aa2ccacd4
fix(avis_controller): fix revoked acl on create_avis
2022-11-29 16:21:06 +01:00
simon lehericey
c17bc50def
fix(avis_controller): acl on instruction
2022-11-29 16:21:06 +01:00
simon lehericey
f500cb8dc7
fix(avis_controller): procedure do not show revoked avis
2022-11-29 16:21:06 +01:00
simon lehericey
dcae06ae84
fix(avis_controller): index do not linked to revoked avis
2022-11-29 16:21:06 +01:00
simon lehericey
f96a7f432c
clean(dossier): useless method
2022-11-29 15:33:10 +01:00
Paul Chavard
53eb3e6ad0
chore(dossier): cleanup champs nested attributes
2022-11-29 11:10:59 +01:00