Commit graph

1369 commits

Author SHA1 Message Date
gregoirenovel
8cad7361cf An operator must be surrounded by single spaces 2017-04-19 17:05:57 +02:00
gregoirenovel
0789cfd311 Colons must be followed by a single space 2017-04-19 17:05:57 +02:00
gregoirenovel
8906801d6c Comment literals must be followed by a space 2017-04-19 17:05:57 +02:00
gregoirenovel
4b575bd386 Commas are followed by a space 2017-04-19 17:05:57 +02:00
gregoirenovel
4f0de677ab Begin pseudo elements with double colons 2017-04-19 17:05:57 +02:00
gregoirenovel
4b39e76c8a Use extend only with placeholders 2017-04-19 17:05:57 +02:00
gregoirenovel
f3ec7f1d42 Indent with two spaces 2017-04-19 17:05:57 +02:00
gregoirenovel
af7b611dd0 < 1 numbers must all have a leading zero 2017-04-19 17:05:57 +02:00
gregoirenovel
c9ff601b28 Hex colors must be written with uppercase letters 2017-04-19 17:05:57 +02:00
gregoirenovel
f519896e54 Hex colors must be 6 characters long 2017-04-19 17:05:57 +02:00
gregoirenovel
2cae8e751e Blocks must be separated by an empty line 2017-04-19 17:05:57 +02:00
gregoirenovel
0d5dd9d492 Remove empty rules 2017-04-19 17:05:57 +02:00
gregoirenovel
6a13e481fd Fix the declaration order 2017-04-19 17:05:57 +02:00
gregoirenovel
0ed13c9fe7 Remove duplicated properties 2017-04-19 17:05:56 +02:00
gregoirenovel
c5fc77b606 Change the comments style 2017-04-19 17:05:56 +02:00
gregoirenovel
bb02339183 Use border: none instead of border: 0 2017-04-19 17:05:56 +02:00
gregoirenovel
db331447e1 Use hex codes for colors 2017-04-19 17:05:55 +02:00
Simon Lehericey
ce4a23ec7f MandatoryAttachment: show * near mandatory attachment 2017-04-19 15:45:45 +02:00
Simon Lehericey
2b969ef575 MandatoryAttachment: group missing errors logic together
and show errors only if not draft
2017-04-19 15:45:45 +02:00
gregoirenovel
b00eb914da Use case statements instead of if statements where appropriated 2017-04-19 11:57:49 +02:00
gregoirenovel
9071656b55 Use #each instead of #map where appropriated 2017-04-19 11:57:49 +02:00
gregoirenovel
ddf02ccd6d Use a non-breaking space after the “numéro” contraction 2017-04-19 11:19:53 +02:00
gregoirenovel
aa41349f0c Lowercase the “n” of “numéro” contraction where needed 2017-04-19 11:19:53 +02:00
gregoirenovel
ba4ee68019 Use masculine ordinal indicator instead of the degree sign
It’s the right way to contract “numéro”

We should use the superscript lowercase o but
it’s hard to do in places where only raw text is
available
2017-04-19 11:19:53 +02:00
Simon Lehericey
4cd21580fb DescriptionController: move html_safe to the view
html_safe could not work upon redirection as stated here :
https://groups.google.com/forum/#!topic/rubyonrails-core/z52zgDgUmbs
2017-04-19 10:52:04 +02:00
Simon Lehericey
eb3bb63a8f DescriptionController: remove useless @champs 2017-04-19 10:52:04 +02:00
Simon Lehericey
866a54085c DescriptionController: cosmetic 2017-04-19 10:52:04 +02:00
Simon Lehericey
157d1818b2 DescriptionController: move instance var to local var 2017-04-19 10:52:04 +02:00
Simon Lehericey
71542f6a3a PiecesJustificativesService: more explicit selection of content 2017-04-19 10:24:08 +02:00
Simon Lehericey
21d7a96062 PiecesJustificativesService: less violent error message in case of virus 2017-04-19 10:22:30 +02:00
Simon Lehericey
395c9d5bb1 PiecesJustificativesService: improve error message when the file cannot be saved 2017-04-19 10:20:32 +02:00
Simon Lehericey
e0828dda13 PiecesJustificativesService: save_pj returns nil if no errors 2017-04-19 10:16:30 +02:00
Simon Lehericey
8e7e7a8ab4 Stats Index: remove useless locale 2017-04-19 10:06:22 +02:00
Simon Lehericey
4c74b04a91 Commentaire: use fr local to display date 2017-04-19 10:06:22 +02:00
Simon Lehericey
367b7c6ae1 DescriptionController: use common system to redirect with errors 2017-04-18 17:48:03 +02:00
Simon Lehericey
591ed2037e PiecesJustificativesServices: refactor upload_one! 2017-04-18 17:48:03 +02:00
Simon Lehericey
03e9cd523e PiecesJustificativesService: mandatory pj check and add test 2017-04-18 17:48:03 +02:00
Simon Lehericey
e49ea2d0e0 PiecesJustificative: add field to set it mandatory
small css to align the fields
2017-04-18 17:48:03 +02:00
gregoirenovel
3abbb0bdcd Use french formatting for numbers on the Stats page 2017-04-18 14:34:56 +02:00
gregoirenovel
21ff863dab [Fix #112] Add favicons 2017-04-17 19:32:26 +02:00
Mathieu Magnin
1612b60126 Remove useless code 2017-04-13 16:54:00 +02:00
Mathieu Magnin
320d5da40f Add individual infos to flat table export serializer 2017-04-13 16:54:00 +02:00
gregoirenovel
d531b02bc5 Order types_de_piece_justificative on Procedure
So that /spec/controllers/api/v1/
dossiers_controller_spec.rb#L163-L179 (on commit
8852431 for example) does not randomly fail due
to unordered types_de_piece_justificative
2017-04-13 14:48:18 +02:00
Mathieu Magnin
080c7c3d04 Fix csv export with no dossiers 2017-04-12 18:19:37 +02:00
gregoirenovel
f4ff778a5c Add a missing newline before the end of the controller
Same spacing rules at the top and at the bottom
of the file
2017-04-11 16:58:27 +02:00
gregoirenovel
913735554c Improve StatsController#thirty_days_flow and #clean_hash 2017-04-11 16:58:27 +02:00
gregoirenovel
11015787bf Add new total numbers to the Stats page 2017-04-11 16:51:38 +02:00
gregoirenovel
52ea4a1b8d Add new charts and a segmented control to the Stats page 2017-04-11 16:51:38 +02:00
gregoirenovel
9dc4901294 Change the template and style of the Stats page 2017-04-11 15:29:19 +02:00
gregoirenovel
e370c4e393 Exclude draft Dossiers and unpublished Procedures from Stats 2017-04-11 15:29:19 +02:00
gregoirenovel
2074ac93ba Add StatsController#thirty_days_flow_hash 2017-04-11 15:29:19 +02:00
gregoirenovel
e192038045 Rename the variables in StatsController#index 2017-04-11 15:29:19 +02:00
gregoirenovel
c4c6095abd Only show the last 30 days of data in Stats 2017-04-11 15:29:19 +02:00
gregoirenovel
de01914fa7 Fix the where clause in Stats
Now properly show the last 90 days of data instead
of strict quarters.

With the previous code, on the
1st of january, april, july and october, only one
day of data would be shown.
2017-04-11 15:29:18 +02:00
gregoirenovel
664d821dc0 Add a link to the Stats page in the footer 2017-04-11 15:29:18 +02:00
gregoirenovel
f84cd7f11b Make Stats a public page 2017-04-11 15:29:18 +02:00
Simon Lehericey
4a16fb2ce2 DescriptionController: refacto 2017-04-11 14:45:30 +02:00
gregoirenovel
dd1fd419c7 Require mandatory fields on the frontend side 2017-04-11 14:25:49 +02:00
Simon Lehericey
a324a22ba2 DossierLink: add show template 2017-04-11 13:54:33 +02:00
Simon Lehericey
3228737a87 DossierLink: add edition template 2017-04-11 13:54:33 +02:00
Simon Lehericey
785219c956 DossierLink: add type de champ 2017-04-11 13:54:33 +02:00
Simon Lehericey
ed36897337 DossiersController: add get procedure libelle 2017-04-11 13:54:33 +02:00
Simon Lehericey
ccf956ec01 DescriptionController: refactor redirection for draft 2017-04-11 12:11:10 +02:00
Simon Lehericey
d14a75c24a DescriptionController: refactor check_mandatory_fields 2017-04-11 12:11:10 +02:00
Simon Lehericey
191b29aff5 DescriptionController: simplify update logic 2017-04-11 12:11:10 +02:00
Simon Lehericey
3a9065e4c1 DescriptionController: remove useless code 2017-04-11 12:11:10 +02:00
Simon Lehericey
c4e128a506 DescriptionController: rename variable 2017-04-11 12:11:09 +02:00
Simon Lehericey
4df03fc28e ChampsService: add tests and refactor 2017-04-11 12:11:09 +02:00
gregoirenovel
1db37894c2 Factorize some code in Dossier#serialize_value_for_export 2017-04-11 11:43:42 +02:00
gregoirenovel
ae5b4f6249 Refactor Dossier#full_data_strings_array 2017-04-11 11:39:34 +02:00
gregoirenovel
df878b9ef4 Change Dossier#convert_specific_array_values_to_string’s signature and name
- It is always called with the data_with_champs
  argument

- Changing the signature requires a change of name
  in this case
2017-04-11 10:29:07 +02:00
gregoirenovel
57ee3c5b3f Separate ternary operators with spaces on both sides 2017-04-10 17:55:55 +02:00
gregoirenovel
9c04d3ff93 All CSS declarations must end with a semi-colon 2017-04-10 17:55:55 +02:00
gregoirenovel
3797015908 All colons must be followed by a single space 2017-04-10 17:55:55 +02:00
gregoirenovel
97df69bcd8 In HAML files, separate arguments by a comma and a single space 2017-04-10 17:55:55 +02:00
gregoirenovel
6db4a69cb2 Use spaces inside hashes 2017-04-10 17:55:54 +02:00
gregoirenovel
aaaed328fb Remove unnecessary string outputs 2017-04-10 17:55:54 +02:00
gregoirenovel
8d9cdf8e33 Remove a useless string in the gestionnaires list 2017-04-10 17:55:54 +02:00
gregoirenovel
6cb53b5545 Move a comment to avoid a haml-lint MultilineScript warning 2017-04-10 17:55:54 +02:00
gregoirenovel
7a941d3219 Remove a useless id in _list.html.haml 2017-04-10 17:55:54 +02:00
gregoirenovel
aa255e7e2d Use HAML comments in HAML files 2017-04-10 17:55:54 +02:00
gregoirenovel
69ba92009b Separate HAML comments from the leading # by a space 2017-04-10 17:55:54 +02:00
gregoirenovel
a8d2a003c1 Do not define static class names in the attributes hash 2017-04-10 17:55:53 +02:00
gregoirenovel
4788e280f5 Fix the indentation in the drop down list template 2017-04-10 17:55:53 +02:00
gregoirenovel
2d5df47c4e Use implicit div tags in HAML files 2017-04-10 17:55:53 +02:00
gregoirenovel
7e067c2624 Static classes attribute must use the inline tag syntax 2017-04-10 17:55:53 +02:00
gregoirenovel
a3d04fe7a9 Html Ruby evaluation tags must be followed by a single space 2017-04-10 17:55:53 +02:00
gregoirenovel
e7e4e41e12 Haml Ruby evaluation tags must be followed by a space 2017-04-10 17:55:53 +02:00
gregoirenovel
3ca914aba8 Delete some environment-based conditions
We should always try to be the closest to the
production environment
2017-04-10 16:17:33 +02:00
Mathieu Magnin
bf0d466f4b Move export_full_generation method from Dossier to Procedure 2017-04-05 12:26:38 +02:00
Mathieu Magnin
b18c09e9fd Download dossiers button exports all dossiers except draft 2017-04-05 11:04:53 +02:00
gregoirenovel
cb677dfb45 Indent using 2 spaces 2017-04-04 16:59:40 +02:00
gregoirenovel
d1e463b7ab Files should end with a single new line 2017-04-04 16:59:39 +02:00
gregoirenovel
d5e7bbd80d Files should end with a new line 2017-04-04 16:59:38 +02:00
gregoirenovel
15802b18ea Files should not start with a new line 2017-04-04 16:59:38 +02:00
gregoirenovel
87ab2ba9eb Remove trailing spaces 2017-04-04 16:59:37 +02:00
gregoirenovel
6cb78acd85 Make the birthday field a date field
And remove the date picker (you can now use the
native one)
2017-04-03 16:03:38 +02:00
gregoirenovel
8126549a0d Make the datepicker french for the auto archive field 2017-04-03 16:03:38 +02:00
Mathieu Magnin
d5e5a7997a Disable turbolinks cache to avoid weird behavior (ex: page change twice after single click) 2017-04-03 15:43:42 +02:00
Mathieu Magnin
08442e64a3 Update turbolinks 2017-04-03 15:43:41 +02:00
gregoirenovel
28747a951f Delete unused assets 2017-04-03 13:25:19 +02:00
Mathieu Magnin
95b83a57c1 Checkbox should be checked when value is 'on' 2017-04-03 10:50:15 +02:00
Mathieu Magnin
096f1e7198 Imageoptim on assets saved 400 ko 2017-03-30 15:51:39 +02:00
Mathieu Magnin
e4826b468a Fix departements / pays / regions drop down list 2017-03-29 14:22:23 +02:00
gregoirenovel
c6738bf223 Rename Mr in M. 2017-03-27 15:45:07 +02:00
Mathieu Magnin
6a8ca67a83 Merge branch 'develop' into auto_archive_on_date 2017-03-27 15:35:52 +02:00
gregoirenovel
458f557c93 Add a sort order to the demo procedures list 2017-03-22 17:52:56 +01:00
Mathieu Magnin
c2a27c6f6a Merge branch 'develop' into auto_archive_on_date 2017-03-22 11:32:56 +01:00
Mathieu Magnin
8e91d4ba97 Merge branch 'develop' into select_multiple 2017-03-20 12:30:42 +01:00
Mathieu Magnin
75007825f8 Update champ_decorator.rb 2017-03-20 12:14:16 +01:00
Simon Lehericey
a076dc2987 Wording 2017-03-20 12:03:27 +01:00
Simon Lehericey
ce343aac96 Select Multiple: text in placeholder and add separator 2017-03-20 11:36:06 +01:00
Simon Lehericey
ebd2051337 multiple_select: fix decorateur interference 2017-03-16 09:09:15 +01:00
Simon Lehericey
b3624256cd select_multiple: add decoration for view of multiple_select 2017-03-15 17:51:34 +01:00
Simon Lehericey
2f561a9cd0 select_multiple: clean user input 2017-03-15 17:51:34 +01:00
Simon Lehericey
1fa1e9e8e8 select_multiple: add select2 2017-03-15 17:51:34 +01:00
Simon Lehericey
3ed14bf1a4 Cleaning 2017-03-15 17:51:34 +01:00
Simon Lehericey
657ce53a60 select_multiple: add multiple_drop_down_list type 2017-03-15 17:51:34 +01:00
Mathieu Magnin
a87b54b168 Typo 2017-03-15 15:28:09 +01:00
Mathieu Magnin
237d4bdc28 Auto archive option is available even if procedure is published 2017-03-15 15:22:29 +01:00
Mathieu Magnin
4d323497e7 Remove puts 2017-03-15 15:16:00 +01:00
Mathieu Magnin
24d17dc0f3 Sidekiq worker to archive procedures automatically + tests 2017-03-15 12:40:59 +01:00
Simon Lehericey
7596c2424e Explication: do not show explication in _infos_dossier 2017-03-14 13:59:37 +01:00
Simon Lehericey
fb2aef1810 Explication: style in edit page 2017-03-14 13:58:59 +01:00
Simon Lehericey
d250cafccc Explication: add champ in edit formulaire 2017-03-14 13:58:21 +01:00
Simon Lehericey
fcca0bb247 Cleaning 2017-03-14 13:54:31 +01:00
Mathieu Magnin
359807b4f7 Procedure has an auto_archive date 2017-03-14 10:45:59 +01:00
Simon Lehericey
176092c256 Explication: add field and template 2017-03-13 15:02:05 +01:00
Simon Lehericey
ec0092fb3c Cleaning 2017-03-13 15:01:41 +01:00
LeSim
8f5f86b2f3 Merge pull request #40 from sgmap/destroy_emails_with_procedure
Destroy emails with procedure
2017-03-13 13:59:32 +01:00
Mathieu Magnin
fc9ef92c37 Destroy emails with procedure 2017-03-13 10:27:19 +01:00
Mathieu Magnin
ad1250af6f Add confirm popup on important actions 2017-03-09 16:55:47 +01:00
Mathieu Magnin
48d12cfa34 max width in Administration 2017-03-08 14:52:37 +01:00
Simon Lehericey
66cb0c09b1 Stats: wording 2017-03-08 14:26:45 +01:00
Mathieu Magnin
5d4e8622f6 Merge pull request #38 from sgmap/stats
Stats: add adminitrations stats view
2017-03-08 10:59:06 +01:00
Mathieu Magnin
342a6b239e Small css changes 2017-03-08 10:55:24 +01:00
LeSim
78325cc9f9 Merge pull request #34 from sgmap/customize_submission_mail
Customize submission mail
2017-03-07 18:32:55 +01:00
Mathieu Magnin
9cd506e265 Clone mail_templates with procedure 2017-03-07 18:19:48 +01:00
Simon Lehericey
6cb88a995f Stats: add adminitrations stats view 2017-03-07 18:09:09 +01:00
Mathieu Magnin
4ea7635dfc Fix after review 2017-03-07 16:23:44 +01:00
LeSim
2e19dd26b7 Merge pull request #36 from sgmap/remember_me
Add remember me on login
2017-03-07 14:15:37 +01:00
LeSim
9764604430 Merge branch 'develop' into customize_submission_mail 2017-03-07 11:05:04 +01:00
Mathieu Magnin
a88b150c3c Add remember me on login 2017-03-07 10:29:48 +01:00
Simon Lehericey
65e83dd6ec Mails: factorize default and change slug 2017-03-07 10:27:14 +01:00
Simon Lehericey
02bbf0543f Mails: move to their own namespace 2017-03-07 10:27:14 +01:00
Simon Lehericey
335caed65e Mail Template: Delete 2017-03-07 10:27:14 +01:00
Simon Lehericey
2536774519 DescriptionController: send initiatedMail notification 2017-03-07 10:27:14 +01:00
Simon Lehericey
3d7f04ad3d DossierController: send receivedMail when the mail is ... received 2017-03-07 10:27:14 +01:00
Simon Lehericey
9d710336b3 MailTemplate: allow edition of all the new mails 2017-03-07 10:27:13 +01:00
Simon Lehericey
c8f515832b MailTemplate: add email and nom_organisation tag 2017-03-07 10:27:13 +01:00