DGNum/demarches-normaliennes
13
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

PiecesJustificativesService: save_pj returns nil if no errors

Browse source
This commit is contained in:
Simon Lehericey 2017-04-19 10:16:30 +02:00
parent c103e55579
commit e0828dda13
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/services/pieces_justificatives_service.rb
View file

@ -12,7 +12,7 @@ class PiecesJustificativesService
errors += without_virus
.map { |tpj, content| save_pj(content, dossier, tpj, user) }
.reject(&:empty?)
.compact()
errors += missing_pj_error_messages(dossier)
end
@ -40,7 +40,7 @@ class PiecesJustificativesService
type_de_piece_justificative: tpj,
user: user)
pj.save ? '' : "le fichier #{pj.libelle} n'a pas pu être sauvegardé"
pj.save ? nil : "le fichier #{pj.libelle} n'a pas pu être sauvegardé"
end
def self.missing_pj_error_messages(dossier)

2
spec/services/pieces_justificatives_service_spec.rb
View file

@ -63,7 +63,7 @@ describe PiecesJustificativesService do
# we are messing around piece_justificative
# because directly doubling carrierwave params seems complicated
allow(PiecesJustificativesService).to receive(:save_pj).and_return('')
allow(PiecesJustificativesService).to receive(:save_pj).and_return(nil)
piece_justificative_double = double(type_de_piece_justificative: tpj_mandatory)
expect(dossier).to receive(:pieces_justificatives).and_return([piece_justificative_double])
end