DGNum/demarches-normaliennes
15
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

PiecesJustificativesService: improve error message when the file cannot be saved

Browse source
This commit is contained in:
Simon Lehericey 2017-04-19 10:20:32 +02:00
parent e0828dda13
commit 395c9d5bb1
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/services/pieces_justificatives_service.rb
View file

@ -40,7 +40,7 @@ class PiecesJustificativesService
type_de_piece_justificative: tpj,
user: user)
pj.save ? nil : "le fichier #{pj.libelle} n'a pas pu être sauvegardé"
pj.save ? nil : "le fichier #{content.original_filename} (#{pj.libelle}) n'a pas pu être sauvegardé"
end
def self.missing_pj_error_messages(dossier)

4
spec/services/pieces_justificatives_service_spec.rb
View file

@ -31,11 +31,11 @@ describe PiecesJustificativesService do
let(:hash) do
{
"piece_justificative_#{tpj_not_mandatory.id}" =>
double(path: '', original_filename: 'file')
double(path: '', original_filename: 'filename')
}
end
it { expect(errors).to match(["le fichier not mandatory n'a pas pu être sauvegardé"]) }
it { expect(errors).to match(["le fichier filename (not mandatory) n'a pas pu être sauvegardé"]) }
end
context 'when a virus is provided' do