Commit graph

6173 commits

Author SHA1 Message Date
Eric Leroy-Terquem
9139bfbf48 clean(administrateur): remove dead code 2024-03-21 14:27:53 +01:00
Colin Darie
f768801b7d
feat(registration): set preferred host on signup/signin 2024-03-21 13:15:36 +01:00
Colin Darie
4dd24f0925
chore: cross domain banner between APP_HOST_LEGACY and APP_HOST 2024-03-21 12:21:16 +01:00
simon lehericey
2ea6a5d25c remove now useless biz_dev module 2024-03-21 11:54:03 +01:00
simon lehericey
a42f85ef05 remove useless administration_id in invite_admin and invite_administrateur! 2024-03-21 11:54:02 +01:00
simon lehericey
5288ee4ab9 fix spec 2024-03-21 10:06:09 +01:00
Eric Leroy-Terquem
a89b471b5c
Merge pull request #10163 from demarches-simplifiees/fix-bulk-message-maintenance-task
fix(maintenance task): fix query and add a test
2024-03-21 08:26:09 +00:00
mfo
086cc1537b
Merge pull request #10068 from mfo/US/user-has-many-fcis
tech(User.FranceConnect): un usager peut avoir plusieurs profils FranceConnect, pas uniquement un
2024-03-20 16:30:39 +00:00
Eric Leroy-Terquem
dd7a407187 fix(maintenance task): fix query and add a test 2024-03-20 15:24:21 +01:00
Eric Leroy-Terquem
73d6609eb3
Merge pull request #10158 from demarches-simplifiees/fix-closing-reason-form
Correctif : ETQ admin je ne peux pas fermer une démarche en redirigeant sans choisir la nouvelle démarche
2024-03-20 13:28:40 +00:00
Lisa Durand
6c5c744411
Merge pull request #10119 from demarches-simplifiees/add-explanation-when-publish-with-same-url-ldu
ETQ admin j'ai un message d'explication si j'utilise une URL déja utilisée lors de la publication d'une démarche
2024-03-20 13:21:59 +00:00
Eric Leroy-Terquem
234f0d7a75 fix(data): update closing_reason to other if no replaced_by_procedure_id 2024-03-20 14:04:59 +01:00
Eric Leroy-Terquem
e55531c6f4 fix(procedure): validates presence of replaced_by_id if procedure redirected 2024-03-20 14:04:59 +01:00
Paul Chavard
eff03aaf23 refactor(dossier): label indexes based on type_de_champ not champ 2024-03-20 09:58:47 +01:00
simon lehericey
ca17524559 Allow instructeur to have multiple agent_connect_information
AC will return two different sub depending of the domain demarches.gouv.fr or ds.
Both agent_connect_information are stored and the corresponding instructeur is found by its email.
We do not store anymore the agent_connect_id on the instructeur as the are many.
2024-03-19 21:17:45 +01:00
simon lehericey
759d729bf3 use AC autoconf discovery end_session_endpoint 2024-03-19 21:17:44 +01:00
Colin Darie
455086c1d7
fix(champs): don't fail on updated_at comparison when champ is not persisted 2024-03-19 11:46:08 +01:00
mfo
aafe6a7bb6
Merge pull request #10139 from mfo/US/fix-missing-champs-task
fix(data): apply fix missing champ via task. FV dossiers are poping way too much at helpdesk
2024-03-18 17:26:45 +00:00
Martin
2dac74916f fix(data): apply fix missing champ via task. FV dossiers are poping way too much at helpdesk
Co-authored-by: Colin Darie <colin@darie.eu>
2024-03-18 17:53:21 +01:00
Paul Chavard
f21192bb06
Merge pull request #10123 from tchak/fix-multiple-champ-copies-bug
fix(champ): fix multiple champ copies bug
2024-03-18 16:46:17 +00:00
Lisa Durand
72c4b23821 add last_champ_updated_at in export 2024-03-18 16:10:26 +01:00
simon lehericey
dca3727253 proper agent connect logout mechanism 2024-03-18 14:02:53 +01:00
simon lehericey
31b84fd770 store id_token 2024-03-18 14:02:53 +01:00
Kara Diaby
e73318e3bb
Merge pull request #10127 from demarches-simplifiees/feat/10005
ETQ expert, je veux pouvoir gérer les notifications que je reçois depuis mon interface
2024-03-18 12:27:37 +00:00
Kara Diaby
30df608a99 tests 2024-03-18 11:50:29 +00:00
Lisa Durand
b8cf19337f
Merge pull request #10131 from demarches-simplifiees/wording-page-stats-ldu
ETQ instructeur je souhaite mieux comprendre le graph "avancée des dossiers" en changeant le terme "démarrés"
2024-03-18 11:49:20 +00:00
Paul Chavard
1b2315cd45 fix(champ): fix multiple champ copies bug 2024-03-18 12:13:22 +01:00
Paul Chavard
8abe3fce79 add stable_id and stream 2024-03-18 11:34:55 +01:00
Lisa Durand
6b916493cb change wording on page stats 2024-03-18 10:39:11 +01:00
Eric Leroy-Terquem
94f37b6708
Merge pull request #10125 from demarches-simplifiees/destroy-procedure-without-administrateur-and-without-dossier
Correctif : supprime les démarches sans administrateur ni dossier
2024-03-18 08:48:52 +00:00
Paul Chavard
900db5624f refactor(champs): if champ not found - build it 2024-03-17 23:51:45 +01:00
Paul Chavard
fd2e253ebc refactor(champs): use ViewableChamp::SectionComponent 2024-03-17 23:51:45 +01:00
Paul Chavard
378e15e083 fix(api_geo): include Paris, Lyon and Marseille code INSEE in local data 2024-03-15 22:33:26 +01:00
Eric Leroy-Terquem
6322532805 fix(data): destroy procedure if no administrateur and no dossier 2024-03-15 16:30:03 +01:00
simon lehericey
ce3a156a46 refactor(file retrieval): use ciphered query params instead of cookie to move email 2024-03-15 14:42:28 +01:00
simon lehericey
7e6792c616 feat(file retrieval): add dossier_transfer_log 2024-03-15 14:35:15 +01:00
simon lehericey
96a8e7888e feat(file retrieval): select procedure to recover 2024-03-15 14:35:14 +01:00
simon lehericey
e91eeadccb feat(file retrieval): add recovery_service 2024-03-15 14:35:14 +01:00
simon lehericey
cd7fd5832c feat(file retrieval): post targeted email 2024-03-15 14:35:14 +01:00
simon lehericey
d86bebdd03 feat(file retrieval): ensure collectivite territoriale 2024-03-15 14:35:14 +01:00
simon lehericey
fac365e01d feat(file retrieval): ensure agent connect is used 2024-03-15 14:35:14 +01:00
simon lehericey
d3955d48ee feat(file retrieval): contact support if not col ter 2024-03-15 14:35:14 +01:00
simon lehericey
a60a082ec5 feat(file retrieval): add api_recherche_entreprises_service 2024-03-15 14:35:14 +01:00
simon lehericey
277ac1259a feat(file retrieval): create agent connect information 2024-03-15 14:35:14 +01:00
Lisa Durand
e757eefd37 add message when path is already taken when publishing a procedure 2024-03-14 17:17:47 +01:00
Paul Chavard
4e023ebed0
Merge pull request #10106 from colinux/limit-service-geocoding-to-insee-code
Super-Admins: évite que le géocodage des services tombe sur une mauvaise commune
2024-03-14 16:16:03 +00:00
Colin Darie
8fa6e04c53
fix(export): turbo poll when creating an export 2024-03-14 14:04:25 +01:00
Eric Leroy-Terquem
237b21025a fix(data): update procedure with duree_conservation greater than max_duree 2024-03-13 11:09:36 +01:00
Colin Darie
578f19b000 chore(service): limit geocoding area to INSEE code commune 2024-03-13 10:40:39 +01:00
Lisa Durand
1ce4d17ad5
Merge pull request #9961 from demarches-simplifiees/amelioration-wording-co-construction-ldu
ETQ usager: Mentionne d'autres acteurs possibles dans la description de la co-construction
2024-03-12 16:55:21 +00:00
mfo
5dda05d710
Merge pull request #10100 from mfo/US/cleanup-champs-after-passer-en-construction
fix(email_validation): allow email with specific format
2024-03-12 17:09:39 +01:00
Colin Darie
fc1c6bb412
Merge pull request #10103 from tchak/dossier-vide-from-procedure
refactor(dossier_vide): use types_de_champ instead of empty dossier
2024-03-12 15:29:24 +00:00
Colin Darie
ee92668611
Merge pull request #9930 from demarches-simplifiees/add-external-link-to-procedure
ETQ admin lorsque je clos une démarche je peux alerter les usagers et je crée une page de fermeture si la démarche n'est pas redirigée dans DS
2024-03-12 15:03:30 +00:00
Colin Darie
0d2f5547e0
Merge pull request #10076 from mfo/US/fix-expert-dossier-export
correctif(Export.export): ETQ expert téléchargeant un dossier et toutes ses PJs, la messagerie n'est pas dans l'export quand la procedure ne l'autorise pas. L'export ne contient pas les annotations privées
2024-03-12 14:09:48 +00:00
Paul Chavard
aa0aea1543 refactor(dossier_vide): use types_de_champ instead of empty dossier 2024-03-12 14:23:07 +01:00
Colin Darie
5f826cfd88
Merge pull request #10095 from demarches-simplifiees/fix_multiple_error_message_on_regexp
Admin: corrige un bug ou un message d'erreur d expression regulière apparaissait plusieurs fois
2024-03-12 13:07:25 +00:00
Colin Darie
745d7d62b5
Merge pull request #10096 from colinux/fix-add-instructeur-without-valid-email
ETQ instructeur je ne dois pas pouvoir inviter un instructeur avec une adresse email invalide
2024-03-12 11:11:36 +00:00
Martin
2468d528fd fix(email_validation): use truemail regexp 2024-03-12 11:29:31 +01:00
Colin Darie
00d023184d
chore(sentry): don't report every InvalidAuthenticityToken 2024-03-11 17:06:38 +01:00
Eric Leroy-Terquem
5a098df525 test(procedure): add a system spec to test closing 2024-03-11 15:48:28 +01:00
Eric Leroy-Terquem
d800213920 feat(procedure): add closing details page 2024-03-11 15:48:28 +01:00
Eric Leroy-Terquem
facb38b539 db(procedure): add a maintenance task to backfill closed procedures with closing reason 2024-03-11 15:48:28 +01:00
Eric Leroy-Terquem
c95f0f1cad feat(procedure): send notifications after closing 2024-03-11 15:48:28 +01:00
Eric Leroy-Terquem
74903d79bf feat(procedure): update archiving to add closing reason and closing details 2024-03-11 15:48:28 +01:00
Colin Darie
bfba80a5ce fix(instructeur): don't try to create instructeur with an invalid email 2024-03-11 12:29:06 +01:00
simon lehericey
2bec15b78f fix multiple error message on regexp 2024-03-11 11:41:31 +01:00
Paul Chavard
9afe71529e fix(addresse): lookup for city, departement and region name in local db 2024-03-11 10:49:56 +01:00
mfo
14266232a4
Merge pull request #10084 from mfo/US/fix-rebase-when-repetition-was-removed
fix(rebase): rebase a dossier when its repetition had been removed on newer version of published_revision crashes
2024-03-08 16:15:00 +01:00
Martin
0e54ca314d bug(rebase): rebase a dossier when its repetition had been removed on newer version of published_revision crashes 2024-03-08 15:46:11 +01:00
Paul Chavard
6ec7a87bcb
Merge pull request #10080 from demarches-simplifiees/add-dependent-destroy-on-contact-information
Correctif : supprime l'information de contact à la suppression du groupe instructeur
2024-03-08 12:15:27 +00:00
mfo
0013528deb
Merge pull request #10065 from mfo/US/secu-email
fix(email.validation): some nasty tests
2024-03-08 09:05:03 +00:00
Martin
9425f2cc58 fix(user.france_connect_informations): has_many, not has_one 2024-03-08 09:44:21 +01:00
krichtof
1024557081
Merge pull request #10041 from demarches-simplifiees/10029-filter-kind-usager
ETQ admin, je peux filtrer toutes les démarches par type d'usager
2024-03-08 08:23:26 +00:00
Eric Leroy-Terquem
6651b36fe4 db(migration): add closing_reason and closing_details to procedure 2024-03-07 19:00:46 +01:00
Eric Leroy-Terquem
877e1f79cc fix(groupe instructeur): add a dependent destroy on contact information 2024-03-07 16:33:17 +01:00
Martin
f4d2f1ddf5 fix(export.pdf): expert should not have access to messagerie when it was disabled 2024-03-07 08:39:32 +01:00
Christophe Robillard
c01914bc24 update zones for new government 2024-03-06 21:18:09 +01:00
Christophe Robillard
05a7198442 remove useless spec 2024-03-06 21:18:09 +01:00
Paul Chavard
a9bf809ea3
Merge pull request #10069 from mfo/US/fix-spread-dossier-deletion-task
tech(spread_dossier_deletion_task): query on date time range not on date
2024-03-05 15:27:09 +00:00
Martin
0ea90e036e fix(email.validation): some nasty tests 2024-03-05 16:27:07 +01:00
Paul Chavard
1243cfefeb fix(entreprise): graphql effectif 2024-03-05 16:00:28 +01:00
Martin
4f85082034 fix(spread_dossier_deletion_task): query on date time range not on date 2024-03-05 14:25:16 +01:00
Martin
b468da9964 bug(user.fcis): users using more than one FranceConnect identity provider can not be destroyed 2024-03-05 14:03:02 +01:00
Paul Chavard
a247ec6c12
Merge pull request #9695 from tchak/use-types-de-champ-as-source-of-truth
refactor(dossier): use revision as source of truth to diplay champs
2024-03-04 15:03:02 +00:00
Paul Chavard
7a727e2bd2
Merge pull request #10051 from demarches-simplifiees/fix-france-connect-warning
Correction : etq usager je ne vois pas le bandeau indiquant que je suis connecté avec France Connect
2024-03-04 11:44:25 +00:00
Paul Chavard
124466a6a2
Merge pull request #10060 from tchak/fix-improuve-municipalities-handling-by-ban-api
fix(adress): show postal code on municipalities
2024-03-04 11:11:38 +00:00
Eric Leroy-Terquem
125724d416 feat(dossier): display france connect information notice only to instructeur 2024-03-04 11:30:19 +01:00
Paul Chavard
f3a97876bd fix(champ): champs are not ordered anymore 2024-03-04 10:59:11 +01:00
Paul Chavard
2eb1f54aa1 refactor(dossier_loader): ignore champs from old revisions 2024-03-04 10:59:11 +01:00
Paul Chavard
8687d73a73 refactor(dossier): clone only current revision champs 2024-03-04 10:59:11 +01:00
Paul Chavard
deb19177f7 refactor(test): update tests 2024-03-04 10:59:11 +01:00
Martin
eb6b23347b fix(data): avoid destroying 2M dossiers in one day due to error in Cron::ExpiredDossiersTermineDeletionJob 2024-03-04 10:52:49 +01:00
Paul Chavard
e6d15172a0 fix(spec): update vcr cassette 2024-03-04 10:42:19 +01:00
Colin Darie
f342bcb58b
test(flipper): instance reset is now out-of-box 2024-03-03 00:13:03 +01:00
Colin Darie
dbf04c63a4
fix(flipper): don't clone features globally enabled 2024-03-03 00:13:01 +01:00
Eric Leroy-Terquem
e94ae3498c
Merge pull request #10048 from demarches-simplifiees/etq-admin-je-vois-les-messages-envoyes-aux-brouillons
ETQ instructeur je vois les messages envoyés aux usagers avec un dossier en brouillon
2024-03-01 13:27:36 +00:00
Paul Chavard
178f1a0c26 fix(test): fail on last month day 2024-02-29 15:44:42 +01:00
Eric Leroy-Terquem
6be57d9ea4 fix(bulk messages): display previous bulk messages 2024-02-28 16:07:27 +01:00
Eric Leroy-Terquem
efa19926e4
Merge pull request #9966 from demarches-simplifiees/etq-admin-je-peux-coller-une-liste-d-emails-d-experts
ETQ admin ou instructeur je peux copier une liste d'emails pour inviter des experts
2024-02-28 14:49:04 +00:00
mfo
43a9ee0ca4
Merge pull request #10049 from colinux/fix-params-i18n-sanitization
Tech: chiffre le param email réaffiché dans la vue pour éviter de construire des pages de phishing
2024-02-28 14:17:47 +01:00
mfo
c0d120545e
Merge pull request #10042 from mfo/US/vers-demarches-gouv-et-lau-dela
tech(redirect): ETQ usager non connecté, je suis automatiquement redirigé de demarches-simplifiees vers le nouvel host
2024-02-28 10:30:42 +00:00
Martin
a13594792a feat(cross-domain-redirect): redirect to APP_HOST when user is on APP_HOST_LEGACY 2024-02-28 06:23:55 +01:00
Colin Darie
0a07c9cd72
fix: encode reset link email in param because it's rendered in view later 2024-02-27 18:59:52 +01:00
Colin Darie
9db7b5b864
fix: encode reset password email in param because it's rendered in view later 2024-02-27 18:53:07 +01:00
Christophe Robillard
26a86d8003 filter all demarches by kind usager 2024-02-23 16:04:27 +01:00
Martin
8ca853c79c feat(application_controller): add method to check if request is on app_host_legacy? 2024-02-23 10:42:23 +01:00
Colin Darie
3cf2e3ecde
Merge pull request #10031 from colinux/fix-typo-tiers
ETQ instructeur: corrige une typo tier => tiers dans les exports
2024-02-23 09:13:19 +00:00
Colin Darie
f04420812b
fix(export): typo tier => tiers 2024-02-22 15:58:29 +01:00
Colin Darie
a8166f43d6
Revert "test: fix graphql syntax error output since JSON parser is now yajl-ruby"
This reverts commit eb41f7e85e.
2024-02-22 15:18:35 +01:00
Colin Darie
7143c7e8e2
Merge pull request #9995 from colinux/attestation-v2-improvements
ETQ admin, quelques améliorations sur l'éditeur v2
2024-02-22 11:30:41 +00:00
Colin Darie
3c22f4ea48
fix(attestation): always return v1 template when exists, otherwise it's a v2 2024-02-22 12:19:07 +01:00
Colin Darie
8ba1c0e481
feat(attestation): can toggle optional champs tags visibility 2024-02-22 12:19:06 +01:00
Colin Darie
0f0c7d83f9
Merge pull request #9998 from colinux/bundle-update-phase-2
Tech: massive gem updates, phase 2
2024-02-22 10:33:37 +00:00
Colin Darie
bacfc0c5d1
Merge pull request #10015 from mfo/US/feat-export-include-mandataire
ETQ instructeur, ETQ API les exports contiennent plus de donnée (mandataire & info de france connection france connect)
2024-02-22 10:33:15 +00:00
Colin Darie
ff8c0e6c69
Merge pull request #10012 from colinux/doc-STRICT_EMAIL_VALIDATION_STARTS_ON
Tech: document STRICT_EMAIL_VALIDATION_STARTS_ON env var
2024-02-21 17:09:00 +00:00
mfo
8579736c03
Merge pull request #10025 from colinux/fix-filter-too-long-error
ETQ instructeur, message d'erreur plutôt que crash lorsqu'on ajoute un filtre trop long (plus de 100 caractères)
2024-02-21 14:51:26 +00:00
Martin
31168f9602 perf(spec): build not create some variables, & fix specs 2024-02-21 14:44:49 +01:00
Martin
c2675dfb4d feat(export.user): add when user passthru FranceConnect or not 2024-02-21 14:44:49 +01:00
Martin
c9235c8a3d feat(export.for_tier): add to export 2024-02-21 14:44:49 +01:00
Colin Darie
5f5756a034
Merge pull request #10017 from mfo/US/a11y-after-signup
ETQ usager utilisant un lecteur d'écran: la page de demande de confirmation de compte ne concentre pas le lecteur d'écran sur le champ pour renvoyer un mail de confirmation
2024-02-21 12:25:35 +00:00
Colin Darie
41a27fbad2
Merge pull request #10014 from mfo/US/better-expert-exports
ETQ expert: je retrouve mes avis confidentiel dans les exports. ETQ instructeur, je retrouve les fichiers joint a une demande d'avis expert
2024-02-21 11:25:58 +00:00
Colin Darie
5ab1d45b8a fix(instructeur): don't crash when adding a filter too long 2024-02-21 12:13:47 +01:00
Paul Chavard
5a8859cd28
Merge pull request #10018 from tchak/fix-address-champ
fix(champ): do not reset data on champs without fetch_external_data
2024-02-21 09:06:24 +00:00
Colin Darie
1671a783a2
Merge pull request #10021 from colinux/fix-email-subject-double-encode
ETQ usager je dois voir de vraies apostrophes à la place de `&#39;` dans les sujets d'email
2024-02-21 08:33:44 +00:00
Paul Chavard
702b9dd8b3 fix(champ): do not reset data on champs without fetch_external_data 2024-02-21 08:54:08 +01:00
Martin
48336f0ca4 a11y(users/confirmations#new): avoid autofocus on input to resend the mail, otherwise screen reader goes straight to the input 2024-02-21 07:56:00 +01:00
Colin Darie
c05aaa5f35 fix(email): dynamic subject should be escaped, cf RFC 2047 which have its own encoding 2024-02-20 18:29:41 +01:00
Colin Darie
560d50f52d fix(dropdown-multiple): a valid option starting by [ may not be a JSON value 2024-02-20 17:41:53 +01:00
Martin
ba3fda1928 bug(monavisvalidator): what any domain could be used ?! 2024-02-20 11:51:00 +01:00
mfo
de4369db29
Merge pull request #10010 from mfo/US/fix-expert-signup
amelioration(expert.signup): passe la page de creation de compte expert au dsfr
2024-02-19 16:43:31 +00:00
Martin
a151a304e2 feat(pj_service): add expert's avis (even when confidential) to exports asked by same expert 2024-02-19 16:22:08 +01:00
Martin
dd39ac313b feat(pj_service): add introduction_file to exports 2024-02-19 16:21:26 +01:00
Colin Darie
1626a71f93
test: fix invalid emails 2024-02-19 15:16:18 +01:00
Martin
8dc3103ac1 fix(champs.email): allow nil 2024-02-19 15:13:20 +01:00
Martin
e788846894 feat(expert.signup): dsfrize 2024-02-19 11:28:38 +01:00
Colin Darie
eb41f7e85e
test: fix graphql syntax error output since JSON parser is now yajl-ruby 2024-02-19 09:28:39 +01:00
Paul Chavard
46b12c0c3d
Merge pull request #9990 from tchak/refactor-adresse-champ
refactor(address): use directly BAN data
2024-02-16 16:42:17 +00:00
Martin
1a424beb6f fix(tags): libelle with double dash, becomes double underscore. no worries it was already broken 2024-02-16 14:00:18 +01:00
Martin
0fbbe4d97c bug(tags): libelle with double dash, double dash also known as tag delimiter 2024-02-16 14:00:18 +01:00
Paul Chavard
20307f1d21 refactor(address): use directly BAN data 2024-02-16 12:15:14 +01:00
Martin
32e8f34511 refactor(PiecesJustificativesService): stop passing flags, pass user_profile and manage ACL from the service itself 2024-02-16 11:23:39 +01:00
Martin
56ed901703 tech(clean): remove dead code 2024-02-16 11:23:39 +01:00
Martin
72a3f6e89c refactor(export/archives): holds user profile asking for the archive or export 2024-02-16 11:23:38 +01:00
mfo
4dfb3b86ef
Merge pull request #10000 from mfo/US/groupe-instructeur-manageable-for-routee-procedure
ETQ administrateur, je peux gerer la liste des instructeurs même si le routage est activé sur ma démarche
2024-02-16 09:26:06 +00:00
mfo
cc53946d22
Merge pull request #9978 from mfo/US/enforce-real-email-validation
feat(email): stricter validation
2024-02-16 09:25:58 +00:00
Colin Darie
fc482c1607
Merge pull request #10008 from colinux/fix-draft-procedure-description-cache
ETQ admin: correction du cache de la liste des PJ d'une démarche en brouillon
2024-02-16 07:22:22 +00:00
mfo
3e9abd73e4
Merge pull request #10004 from mfo/add_missing_acl_on_instructeurs_self_management_enabled
secu(instructeurs/groupes_instructeurs): s'assure que seul les instructeurs d'une demarche ayant la gestion activé puisse acceder aux ecrans
2024-02-16 06:37:45 +00:00
Colin Darie
a783c50026 fix(commencer): cache on description of draft procedure
Des changements dans le formulaire d'une démarche en brouillon
ne mettent pas à jour la cache_key de la procedure, donc au fait au plus
simple pour éviter un cache stale dans ces cas là.
2024-02-15 18:45:13 +01:00
Martin
a274629719 fix(instructeurs/groupes_instructeurs#*): add some ACL here 2024-02-15 17:11:25 +01:00
Martin
b6c2742cda bug(instructeurs/groupes_instructeurs#*): any ACL here ? 2024-02-15 17:11:25 +01:00
Martin
8488e74bbb review(suggestion): better code with reviews, normalize Champs::EmailChamp.value, simplier default strict validation activation
Co-authored-by: Colin Darie <colin@darie.eu>
2024-02-15 16:41:00 +01:00
Martin
5f77c0cd06 feat(email.validation): expand email validation to Avis, ContactInformation, Invite, DossierTransfert 2024-02-15 16:41:00 +01:00
Martin
05193e1d1e feat(User.validation): validates email when env var is present 2024-02-15 16:41:00 +01:00
Martin
25f92a7760 feat(email.validator): define a strict email validator, validates Champs::EmailChamp.value only on validation context
Co-authored-by: Paul Chavard <github@paul.chavard.net>
2024-02-15 16:41:00 +01:00
Martin
5407011668 feat(procedure.routing): allow admin to manage instructeur even when procedure has some routing 2024-02-15 13:40:48 +01:00
Colin Darie
a650114671
test: fix flaky match_array test 2024-02-15 11:00:53 +01:00
seb-by-ouidou
9ddd55d5cd feat: remove commentaire_component and replace it by message_component + replace commentaires/_form by messages/_form + few fixes 2024-02-15 07:50:20 +00:00
Colin Darie
bd3c2c070a
Merge pull request #9957 from demarches-simplifiees/finalize-rna-rnf-ldu
ETQ instructeur et consommateur API, la vue du champ RNA est harmonisée avec le champ RNF
2024-02-14 15:30:54 +00:00
Colin Darie
a9b24b897e
Merge pull request #9971 from demarches-simplifiees/harmonize-merci-message-from-admin-apercu-to-user-ldu
ETQ admin, je veux que le message de fin de dépot d'une démarche déclarative soit correct
2024-02-14 15:14:20 +00:00
Colin Darie
48644ae407
Merge pull request #9846 from adullact/feature-ouidou/admin_creation_delegation_gestionnaire_contact_parent_gestionnaires
Délégation de compte: ETQ gestionnaire je peux contacter les gestionnaires des groupes parents
2024-02-13 14:42:03 +00:00
Paul Chavard
7d9cb4d497
Merge pull request #9988 from tchak/refactor-logic-compute-sub-values
refactor(logic): compute sub champ values
2024-02-13 14:22:09 +00:00
Paul Chavard
ff95a812e2 fix(combobox): always sort on the client 2024-02-13 12:26:43 +01:00
Paul Chavard
93635b3516 refactor(logic): compute sub champ values 2024-02-13 11:57:31 +01:00
seb-by-ouidou
fba3cbe331 feat: as gestionnaire, contact gestionnaire of parent groupe 2024-02-13 11:19:52 +01:00
Paul Chavard
641a33e1e0
Merge pull request #9985 from tchak/fix-update-dossier-en-construction
ETQ Usager, je ne veux pas voir un message d'alerte indiquant que la démarche est close lorsque je modifie un dossier en construction
2024-02-13 09:38:08 +00:00
Colin Darie
c0f9b8c1cd test: fix flaky test due to passing time 2024-02-13 09:54:23 +01:00
Eric Leroy-Terquem
7b539c72b1
Merge pull request #9955 from demarches-simplifiees/fix-simple-routing
ETQ admin je peux faire un routage simple à partir d'un type de champ communes ou epci
2024-02-13 07:56:42 +00:00
Paul Chavard
034015384b fix(dossier): do not warn about closed demarche when updating a fork 2024-02-13 08:19:19 +01:00
Colin Darie
5e859bd41f
test(rna): add test against RNA type 2024-02-12 17:20:08 +01:00
Lisa Durand
f09ab62620
add rna type de champ to harmonize api with rnf 2024-02-12 17:20:07 +01:00
Colin Darie
7251a5ca01
Merge pull request #9983 from colinux/fix-address-champ
ETQ instructeur: fix génération d'attestation avec une balise "nom de la commune" depuis un champ adresse
2024-02-12 15:48:11 +00:00
Colin Darie
bfb98554ff
fix(active-storage): don't fail on analyzing a blob derivated by watermark
Quand l'analyse du job se produit après le watermark, elle doit comparer
le checksum avec celui du fichier filigrané.
2024-02-12 16:30:58 +01:00
Colin Darie
ea89c2e8dd
fix(attestation): tag commune_name from address 2024-02-12 15:08:05 +01:00
Colin Darie
c4110c35bf
fix(graphql): json error is not anymore prefixed by unknown line number 2024-02-12 09:33:28 +01:00
Colin Darie
18e5e13eba
test: fix devise-i18n change courriel => email 2024-02-12 09:33:27 +01:00
Colin Darie
e0d5dc84d5
fix(rubocop): Rails/TimeZone 2024-02-12 09:33:20 +01:00
Colin Darie
6ab3fa1cf4
fix(rubocop): Rails/RedundantActiveRecordAllMethod 2024-02-12 09:33:18 +01:00
Paul Chavard
23592087ae refactor(instructeur): use precomputed timestamps 2024-02-08 18:36:04 +01:00
Eric Leroy-Terquem
79ff2ba779 feat(combobox): can paste many terms separated by semicolons 2024-02-08 11:53:47 +01:00
Colin Darie
fb14afc530 fix(rna): real RNA identifier could contain at least 1 letter, despite of specs 2024-02-06 15:02:57 +01:00
Colin Darie
70e92f7c6b
Merge pull request #9903 from colinux/attestation-ux
ETQ admin, je peux tester l'attestation v2
2024-02-06 08:09:53 +00:00
Lisa Durand
0a8e8ebd05 change wording for co-constructing dossier 2024-02-05 12:08:10 +01:00
seb-by-ouidou
c2c54083e8
feat: display tree structure of a group 2024-02-05 09:30:24 +01:00
Colin Darie
eb55abebfc style(attestation): fix for headings style and spacing following charte 2024-02-02 13:49:22 +01:00
Colin Darie
f7484eb0e5
feat(attestation): list tags errors and substitute missing tag by libelle 2024-02-02 13:05:09 +01:00
seb-by-ouidou
46c19014f9 feat: notify administrateur and gestionnaire by email when new commentaire + for administrateur highlight card and commentaires if any unread 2024-02-02 12:52:36 +01:00
Colin Darie
6f49dd892d
fix(attestation): multiple tags improvements
- no menu when no matching tags
- insert a space after clicking a button
- allow no space before mention
2024-02-02 09:47:20 +01:00
Colin Darie
7e02342518
feat(attestation): tiptap default attestation 2024-02-01 18:55:58 +01:00
Colin Darie
475406f3f2
style(attestation): improve editor UI & style 2024-02-01 18:55:55 +01:00
Colin Darie
16478651a9
test(attestation): more tests for v2 2024-02-01 18:55:53 +01:00
Colin Darie
443e41a6ed
style(attestation): group tags by section 2024-02-01 18:55:52 +01:00
Colin Darie
40353fee04
feat(attestation): replace tags in preview for v2 2024-02-01 18:55:50 +01:00
Colin Darie
16cdff8425
feat(tiptap): detect first body paragraph for spacing, handle empty nodes 2024-01-31 17:03:47 +01:00
Colin Darie
45071b7bb6
fix(tiptap): don't fail on node without content 2024-01-31 17:03:40 +01:00
Eric Leroy-Terquem
b04f152733 fix(routing): can create simple routing with communes and epci tdc 2024-01-31 15:27:45 +01:00
Kara Diaby
17a471e880
Merge pull request #9939 from demarches-simplifiees/feat/9937
ETQ Super-Admin, je souhaite marquer une démarche comme modèle
2024-01-31 10:21:30 +00:00
Kara Diaby
46748091a6 Permet au Support de marquer une démarche comme modèle et de filtrer dans toutes les démarches 2024-01-31 09:30:14 +00:00
Colin Darie
88e62323b6
Merge pull request #9949 from mfo/US/fix-device-locale
correctif: ETQ usager naviguant sur le site en anglais, je m'attends a recevoir des messages d'erreur de connexion en anglais
2024-01-31 09:28:15 +00:00
Colin Darie
3ea718a3f5
Merge pull request #9664 from adullact/feature-ouidou/admin_creation_delegation_follow_commentaire
ETQ gestionnaire, j'ai un suivi des messages au sein de mes groupes
2024-01-31 08:56:29 +00:00
Martin
672b341279 bug(auth.error_message): should be i18n 2024-01-30 10:03:00 +01:00
Colin Darie
df1dd19eac
Merge pull request #9946 from colinux/fix-procedure-external-url
Tech: fix le job de vérification des liens externes des procédures lorsqu'un autre attribut est en erreur
2024-01-29 17:31:38 +00:00
seb-by-ouidou
f3cba9331d fix: improvement after review 2024-01-29 18:23:39 +01:00
seb-by-ouidou
6cd8b6d2df feat: for gestionnaire highlight card and commentaires if any unread 2024-01-29 18:23:39 +01:00
seb-by-ouidou
a5d95b2d9d fix: fix activate gestionnaire and activate administrateur 2024-01-29 18:23:39 +01:00
Colin Darie
533ce8d7ba fix(procedure-url-check): don't fail when other attribute have an error 2024-01-29 15:42:35 +01:00
Eric Leroy-Terquem
6203b1fd05
Merge pull request #9879 from demarches-simplifiees/cleaning-conditional-and-routing-code
Tech : nettoyage du code conditionnel et routage
2024-01-29 13:43:52 +00:00
mfo
77ca3dd28a
Merge pull request #9922 from mfo/US/nplus_one_in_summary
perf(TypeDeChampEditor): faster
2024-01-29 10:58:05 +00:00
Colin Darie
a582fef1e5
Merge pull request #9934 from colinux/fix-export-link-witout-file
ETQ instructeur, n'affiche pas encore de lien vers un export quand le fichier n'est pas encore disponible
2024-01-29 10:11:33 +00:00
LeSim
e12c663d21
Merge pull request #9940 from demarches-simplifiees/can_edit_again_a_token
Admin: je peux modifier le nom et les réseaux d'un jeton d'API
2024-01-29 09:21:21 +00:00
simon lehericey
5eaa957c31 can edit api_token to change networks and name 2024-01-29 10:09:55 +01:00
Colin Darie
c02171ede7
Merge pull request #9936 from colinux/badge-corrige
ETQ instructeur, je vois un badge Corrigé lorsque le dossier a été corrigé
2024-01-29 08:57:54 +00:00
Colin Darie
b64a32444c
Merge pull request #9935 from colinux/transfer-empty-no-fail
Tech: plus d'erreur lorsque l'email de transfert n'a plus de dossier associé
2024-01-29 08:43:50 +00:00
Martin
01752bc2e8 perf(ProcedureRevisionPreloader): preload revision quickly 2024-01-26 14:47:44 +01:00
Martin
ecc83edf4f wip 2024-01-26 13:43:10 +01:00
simon lehericey
97f335c36a add a cron job to send expiration notice 2024-01-26 10:18:16 +01:00
simon lehericey
6353c10955 add APIToken expiration mailer 2024-01-26 10:18:16 +01:00
simon lehericey
d909e2c8ea add various expiring scopes to APIToken 2024-01-26 10:15:37 +01:00
Martin
0e5768ec5b fixup! perf(editor): better perf to add, destroy, update, move up, move down and move with number 2024-01-26 09:45:59 +01:00
Colin Darie
50b9813b4d
Merge pull request #9932 from colinux/lock-submit-fork
Correctif: ETQ usager, je ne peux pas soumettre 2x mes modifications en parallèle
2024-01-25 11:37:56 +00:00
Colin Darie
4aa1306536
feat(transfer): make it silent in case dossier had been destroyed between queuing and processing
Co-authored-by: mfo <mfo@users.noreply.github.com>
2024-01-25 11:31:12 +01:00
simon lehericey
588e58195c move api_tokens to admin module 2024-01-25 11:27:15 +01:00
simon lehericey
49f0caba7e fix(spec): flaky test 2024-01-25 11:17:44 +01:00
simon lehericey
9a0dd45385 feat(api): add invalid ip addr error 2024-01-25 11:17:44 +01:00
simon lehericey
852eedbc50 refactor(api): create api_token with validity and network filtering 2024-01-25 11:17:44 +01:00
simon lehericey
7e8555923f feature(api): add ensure_token_is_not_expired to api_controller v1 and v2 2024-01-25 10:51:58 +01:00
simon lehericey
d8bc38bc69 feature(api): add ensure_authorized_network for api_controller v1 and v2 2024-01-25 10:51:58 +01:00
simon lehericey
6e5678d1c2 feature(api): add forbidden_network? to api_token 2024-01-25 10:51:58 +01:00
Colin Darie
8e6a1c58b2 feat(correction): badge Corrigé when a correction has been resolved
Closes #9928
2024-01-24 17:26:34 +01:00
Colin Darie
520a7c4402
fix(exports): don't try to link to an export when file is not yet attached 2024-01-24 13:36:25 +01:00
Kara Diaby
ac29cfbfdb Envoie un email à l'expert en cas de nouveau commentaire de l'usager dans la messagerie 2024-01-24 10:48:17 +00:00
Colin Darie
56f8b61866
feat(dossiers): lock submit en construction to avoid merge collisions with double submits 2024-01-24 10:58:40 +01:00
Martin
2952987ad8 refactor(spec): stop using procedure type de champs traits as :with_datetime, :with_xxx in favor of :types_de_champ_public which keeps position in check 2024-01-23 17:30:22 +01:00
mfo
15e0ed8480
Merge pull request #9927 from mfo/fix-flacky-type-de-champ-template
fix(spec.flacky): ./spec/system/administrateurs/types_de_champ_spec.rb:272 was flacky, try to fix it
2024-01-22 17:10:37 +00:00
Colin Darie
716e4bbe5d
Merge pull request #9645 from adullact/feature-ouidou/admin_creation_delegation_gestionnaire_answer_administrateur
Feature ouidou/admin creation delegation gestionnaire answer administrateur
2024-01-22 15:45:58 +00:00
Martin
2fa59076f9 fix(spec.flacky): ./spec/system/administrateurs/types_de_champ_spec.rb:272 was flacky, try to fix it 2024-01-22 15:50:38 +01:00
Martin
0f194a5e8e refactor(procedure_revision): without renumber, use types_de_champ_public factory for ordered champs 2024-01-22 14:57:04 +01:00
Martin
5c049a1c0f feat(update_draft_revision_type_de_champs_task): force to use real position otherwise have to process parent_coordinates... 2024-01-22 14:57:04 +01:00
Martin
434cd77030 poc(spec): renumber only at one point 2024-01-22 14:57:04 +01:00
Martin
a9c0d3e7e9 tech(clean): avoid useless indirection, cleanup some code complexity, rubocopify 2024-01-22 14:57:04 +01:00
Martin
4d97c5bc8a feat(move_type_de_champ): stop renumbering all procedure_revision_type_de_champ on move_type_de_champ 2024-01-22 14:57:04 +01:00
Martin
4b57ed871a feat(add_type_de_champ): stop renumbering all procedure_revision_type_de_champ 2024-01-22 14:57:04 +01:00
seb-by-ouidou
a6ca4b668e feat: answer message to administrateur as gestionnaire 2024-01-22 14:36:38 +01:00
seb-by-ouidou
8d8feedff0 fix: group "it" test 2024-01-22 14:36:38 +01:00
seb-by-ouidou
e6474f0d14 feat: US4.3.9 children management 2024-01-22 14:36:38 +01:00
seb-by-ouidou
96dd6bec52 feat: US4.3 update and delete groupe gestionnaire 2024-01-22 14:36:38 +01:00
Colin Darie
7892b54aa6 fix(discarded-dossiers): don't crash whole job when a single dossier causes an error 2024-01-17 13:15:42 +01:00
Colin Darie
1a8f839a7e
Merge pull request #9915 from colinux/fix-admin-memory-leak
Perf: remplace les `OpenStruct` par des objets plus performants
2024-01-17 08:59:01 +00:00
Colin Darie
a4db911585
perf(admin): remove 2 useless zones queries on each admin page due to navigation 2024-01-16 19:43:58 +01:00
Colin Darie
a0e64151d5
test: replace OpenStruct by model expected 2024-01-16 19:43:24 +01:00
Lisa Durand
d9b75ce0a2
Merge pull request #9882 from demarches-simplifiees/add-dossier-reference-in-transfer-email
Je veux que le numéro du dossier apparaisse dans l'email de demande de transfert
2024-01-15 15:39:09 +00:00
mfo
0328446bee
Merge pull request #9861 from demarches-simplifiees/US/move-type-de-champ-with-select
ETQ administrateur, je peux deplacer un champ via un select
2024-01-15 13:09:56 +00:00
Martin
69346ad41f tech(review): implement some pair review suggestions 2024-01-12 11:00:29 +01:00
Colin Darie
8a83fd2ce0
fix(recherche): show notification indicator for instructeurs 2024-01-12 10:09:34 +01:00
Martin
e7eee7ba72 spec(move_and_morph): add some spec and lint with rubocop/haml/eslint 2024-01-11 16:12:09 +01:00
Martin
857a1fc496 fix(select_champ_position): rewire for more robust and easier implementation which work with repetition avoiding double submit 2024-01-11 16:01:24 +01:00
Martin
11de4bdfb6 feat(types_de_champ_editor.ts): wires move_and_morph with type de champs editor [for now, the select is empty and will be synced] 2024-01-11 16:01:24 +01:00
simon lehericey
e12dbe7aad use email_merge_token in email merge 2024-01-11 11:33:38 +01:00
simon lehericey
ca08b80c3e use email_merge_token in mailer 2024-01-11 11:33:38 +01:00
simon lehericey
fca28a3ebd use email_merge_token in mail_merge_with_existing_account route 2024-01-11 11:33:38 +01:00
simon lehericey
65aa07ecbe the merge_token issued for password check can be reused for the confirmation by email route
Thus by passing the password check or the email possession check
2024-01-11 11:33:38 +01:00
seb-by-ouidou
210df8a418 feat: review test after view component upgrade 2024-01-09 13:25:04 +01:00
seb-by-ouidou
c45e2eaccc feat: write message to gestionnaires as administrateur 2024-01-09 13:25:04 +01:00
simon lehericey
f96347caad fix(spec): another way to mock current_user 2024-01-08 14:30:19 +01:00
mfo
a0248bf08b
Merge pull request #9888 from mfo/US/validate-epci-by-code
Correctif: Le noms des EPCIs changent, ce qui bloque la validation et ou demande a resaisir le champs
2024-01-08 09:56:09 +00:00
Martin
fa07c21ec3 fix(champs.epci): epci names change over time. remap when it occurs 2024-01-04 07:17:15 +01:00
mfo
9df978f6fa
Merge pull request #9887 from mfo/US/fix-fci-missing-device-callback
Correctif: ETQ usager invité, lorsque je crée mon compte via FC, je ne retrouve pas mes invitations
2024-01-04 06:15:14 +00:00
Martin
4073804b00 feat(administrateurs/types_de_champ_controller#move_and_morph): add action to move and morph fields between two coordinates 2024-01-03 11:08:53 +01:00
Martin
92730e266b fix(FranceConnect): missing after_confirmation callback, leading to invalites invitations when user france connect 2023-12-26 15:00:15 +01:00
Eric Leroy-Terquem
24563a3c18 fix(personnes impliquees): display reaffectations block only if procedure is routed 2023-12-22 10:57:53 +01:00
Eric Leroy-Terquem
547a4d95b7 chore(logic): commune and epci champs are always compute with compute_value_json 2023-12-22 10:57:53 +01:00
Colin Darie
deab400057
Merge pull request #9578 from adullact/feature-ouidou/admin_creation_delegation_administrateur_pages
Feature ouidou/admin creation delegation administrateur pages
2023-12-22 09:06:58 +00:00
mfo
c4adee6278
Merge pull request #9878 from mfo/US/fix-not-type-ej-in-api
API: cast le type de champ EJ
2023-12-22 07:20:13 +00:00
seb-by-ouidou
c253e7dd65 feat: US5.1 US5.2 administrateur in admin 2023-12-21 18:40:36 +01:00
Colin Darie
6f7d786783
Merge pull request #9880 from demarches-simplifiees/api_token_store_last_used_ips
API: stocke les ips utilisées pour accéder à l'API
2023-12-21 16:18:00 +00:00
Lisa Durand
ff284a1c96 add more info in notify transfer email 2023-12-21 16:58:33 +01:00
Martin
989a7ba787 feat(API): cast type de champ EJ in a dedicated graphql type 2023-12-21 16:21:31 +01:00
Eric Leroy-Terquem
4c82f2c9d7 fix(champ value): fix compute_value_json on departement champ 2023-12-21 16:21:08 +01:00
simon lehericey
afb6eacf57 feature(api): store any ip used 2023-12-21 16:02:11 +01:00
Colin Darie
9bdf525ff1
Merge pull request #9863 from colinux/fix-message-html-injection
Tech: échappe les tags de données utilisateur dans les modèles pour email
2023-12-21 08:50:21 +00:00
Colin Darie
29df9ad09d
Merge pull request #9751 from tchak/departement-tags
feat(champs): expose more tags and api fields on rnf, address and commune
2023-12-21 08:45:01 +00:00
Colin Darie
e17c3bd046
Merge pull request #9839 from mfo/US/fix-filter-focus-out-with-not-selected-filter
correctif : ETQ instructeurs, lorsque je sors du composant de filtrage sans choisir une option, le site renvoie une erreur
2023-12-21 08:42:12 +00:00
Colin Darie
535a54ce97
Merge pull request #9874 from demarches-simplifiees/add-email-for-tiers-when-repasser-en-instruction-ldu
[Co-construction] Envoyer un mail au bénéficiaire si le dossier repasse en instruction
2023-12-21 08:32:10 +00:00
Lisa Durand
3e872c5246 add email for tiers when repasser en instruction 2023-12-20 11:51:02 +01:00
Lisa Durand
e52bd9d6bf
Merge pull request #9855 from demarches-simplifiees/display-last-export-in-same-page-ldu
ETQ instructeur, j'ai besoin d'un accès très facile à mondernier export
2023-12-20 10:02:08 +00:00
Eric Leroy-Terquem
882d72d139 data(conditional): add a maintenance task to update conditions based on commune or epci champ 2023-12-19 17:39:40 +01:00
Eric Leroy-Terquem
e4632214fb data(conditional): add a maintenance task to update routing rules based on commune or epci champ 2023-12-19 17:39:39 +01:00
Eric Leroy-Terquem
954facdaff
Merge pull request #9798 from demarches-simplifiees/add-new-operators-to-conditional
Etq admin je peux conditionner/router avec les opérateurs "est dans mon département",  "n'est pas dans mon département",  "est dans ma région" et   "n'est pas dans ma région".
2023-12-19 16:10:59 +00:00
Lisa Durand
e6a4459633 refacto 2023-12-19 16:54:23 +01:00
Lisa Durand
f553f3c408
Merge pull request #9872 from demarches-simplifiees/add-badge-for-role-ldu
ETQ utilisateur avec plusieurs rôles, je m'y retrouve plus facilement
2023-12-19 11:01:28 +00:00
mfo
e75c4456e8
Merge pull request #9871 from mfo/US/add-pj-to-explication
ETQ administrateur, je peux ajouter une notice explicative a un champs explication
2023-12-19 10:44:03 +00:00
Lisa Durand
c767164e28 add expert in current_account and mode badge to the right 2023-12-19 11:33:48 +01:00
Lisa Durand
0286d2b6fb add profiles in flash after sign-in if multiple profile 2023-12-19 10:33:26 +01:00
Martin
37e8772eab feat(type_de_champ_editor.explication): add a Attached::One to TypeDeChamp.explication, named notice_explicative [cf, cerfa wording] 2023-12-19 09:52:27 +01:00
Colin Darie
e9ee405954
Merge pull request #9868 from colinux/blocking-pending-correction-ff
ETQ instructeur je peux de nouveau passer en correction un dossier avec corrections en attente
2023-12-18 13:29:39 +00:00
Colin Darie
1a56fe620e feat(correction): make pending corrections blocking by feature flag only 2023-12-18 14:12:45 +01:00
Lisa Durand
53f9f3cbdb add trad if export failed 2023-12-18 14:09:47 +01:00
Lisa Durand
a9ab1daf3a display alert only for instructeur who generated the export and if recent 2023-12-18 11:25:52 +01:00
simon lehericey
9bb89f7e3e fix(print): missing dossier var 2023-12-18 09:51:41 +01:00
Colin Darie
fa37c6c62b
fix(tags): escape user data tags for emails 2023-12-15 14:05:11 +01:00
Colin Darie
c0b444d747
Merge pull request #9847 from colinux/fix-style
Style: plusieurs améliorations mineures / thème sombre
2023-12-15 12:00:53 +00:00
Martin
d27e4fc693 amelioration(combobox): permet de passer des options au input[type=hidden], utilise cette option pour autosubmit uniquement un input [dans notre cas, ne soumet pas a l'input du combobox, mais a l'input hidden une fois le combobox selectionné] 2023-12-15 11:23:25 +01:00
Colin Darie
7ba13507ff
Merge pull request #9808 from colinux/remove-usager-antivirus
ETQ usager, je ne vois plus le statut "antivirus en cours" lorsque j'envoie un PJ
2023-12-14 19:53:34 +00:00
Colin Darie
9a5d908851
Merge pull request #9853 from mfo/US/fix-expert-link-to-dossiers
ETQ expert: lorsque je me connecte, je suis redirigé vers la page des avis, non pas vers la page de mes dossiers
2023-12-14 19:52:32 +00:00
Colin Darie
3b0e4e59d5
Merge pull request #9858 from colinux/fix-invite-html-injection
Tech: sanitize les messages utilisateurs dans les emails
2023-12-14 17:27:28 +00:00
Lisa Durand
569d4af6f7
Merge pull request #9706 from demarches-simplifiees/feat/9678
ETQ usager passant par un mandataire, je suis notifié des changements d'état de mon dossier par email
2023-12-14 16:57:07 +00:00
Eric Leroy-Terquem
2e547cd46f chore(routing): cannot create simple_routing with champs communes or epcis 2023-12-14 17:48:14 +01:00
Eric Leroy-Terquem
e40d1107ac chore(conditional): add not_in_departement and not_in_region operators 2023-12-14 17:48:14 +01:00
Eric Leroy-Terquem
c9676020b4 chore(conditional): add in_departement and in_region operators 2023-12-14 17:48:13 +01:00
Martin
1307e7262f amelioration(application_controller.roles): intègre aussi le role d'expert aux logs 2023-12-14 14:52:50 +01:00
Colin Darie
fd7839773b fix(email): sanitize user message 2023-12-14 12:51:56 +01:00
Martin
6def2609f1 amelioration(liens-suivis): persiste la page a laquelle il doit etre redirigé apres une connexion 2023-12-14 10:47:04 +01:00
Martin
4380fecd73 amelioration(expert.sign-in): ETQ expert, je suis redirigé vers la page listant les avis a donner ap connexion 2023-12-14 10:47:04 +01:00
Lisa Durand
2f1259709a fix email content 2023-12-14 10:01:13 +01:00
Eric Leroy-Terquem
57b6522536 data(geo): update api_geo_data take task to store region_code in departements and communes json 2023-12-14 09:36:50 +01:00
Colin Darie
c76213cb87
fix(users): don't show procedures filter when there are not enough procedures 2023-12-13 18:03:22 +01:00
Colin Darie
01d12c9bb4
Merge pull request #9840 from colinux/maintenance-task-update-tdc
ETQ superadmin je peux mettre à jour le brouillon d'une révision à partir d'un CSV
2023-12-13 10:15:41 +00:00
Colin Darie
715c800788
Merge pull request #9821 from colinux/en-attente-block-instruction
ETQ instructeur je ne peux pas passer en instruction un dossier en attente de correction
2023-12-13 10:02:32 +00:00
Kara Diaby
57dfe2b0f6 Améliorations après retours PR 2023-12-13 09:21:09 +00:00
Lisa Durand
878f58e00c add mailer test 2023-12-12 22:35:11 +00:00
Lisa Durand
43f5f4e030 fix test 2023-12-12 22:35:11 +00:00
Kara Diaby
303230dd1d Add new testss 2023-12-12 22:35:11 +00:00
Lisa Durand
d0e2f281cc fix tests 2023-12-12 22:35:11 +00:00
Lisa Durand
f6f18e9c86 send email to tiers if notification by email is set 2023-12-12 22:35:11 +00:00
krichtof
246d53fa99
Merge pull request #9754 from demarches-simplifiees/9435-transfer-dossier
En tant que superadmin, je peux transférer un dossier d'un utilistateur à un autre
2023-12-12 14:44:39 +00:00
Christophe Robillard
122a6b6f5b revoke superadmin dossier transfer 2023-12-12 15:25:39 +01:00
Colin Darie
7c38cbcab3
test: fix random failing test 2023-12-12 15:05:48 +01:00
Colin Darie
c0771ad903
fix(dossier): passe en instruction with auto-archive even with pending correction 2023-12-12 15:05:46 +01:00
Colin Darie
3d21262e89
test(declarative): clarify intention with pending correction & declarative procedure 2023-12-12 15:05:45 +01:00
Colin Darie
c26b59722d
feat(instructeur): pending correction blocks passer en instruction
Closes #9731
2023-12-12 15:05:44 +01:00
Colin Darie
f9c4846fde
Merge pull request #9571 from adullact/feature-ouidou/admin_creation_delegation_gestionnaire_page_group_administrateur_management
Feature ouidou/admin creation delegation gestionnaire page group administrateur management
2023-12-12 10:41:28 +00:00
Colin Darie
6a2e68b697 feat(admin): task removing type de champ from draft revision from a csv 2023-12-11 19:04:49 +01:00
Colin Darie
7618b8c549 feat(admin): task updating libelles, description, mandatory and positions on draft revision
Co-Authored-By: mfo <mfo@users.noreply.github.com>
2023-12-11 18:41:20 +01:00
Colin Darie
968b2cfb0a
Merge pull request #9818 from colinux/correction-remove-from-message
ETQ instructeur, ma demande de correction est supprimée (résolue) lorsque je supprime son message associé
2023-12-11 13:07:43 +00:00
mfo
b56d5199e2
Merge pull request #9820 from mfo/US/filter-dossier-with-combobox
ETQ instructeur, lorsque je veux filtrer les dossiers d'une démarche, je peux utiliser un autocomplete
2023-12-11 09:48:58 +01:00
seb-by-ouidou
8c1bc9e62f feat: batch action for repousser_expiration depuis expirant 2023-12-09 06:27:00 +01:00
seb-by-ouidou
5c80f6c3f0 feat: batch action for desarchiver 2023-12-09 06:27:00 +01:00
seb-by-ouidou
c0c2e35881 feat: batch action for restaurer 2023-12-09 06:27:00 +01:00
seb-by-ouidou
5ec95d781c feat: batch action for supprimer 2023-12-09 06:27:00 +01:00
mfo
28bbfc7b3a
Merge pull request #9800 from colinux/fix-publication-revision-errors
ETQ admin je suis prévenu si des erreurs sur la démarche empêchent la publication de révision
2023-12-08 17:14:14 +00:00
Martin
1f13000537 amelioraiton(instructeur.filtres): utilise un combobox pour rechercher le type de champs 2023-12-08 16:10:18 +01:00
Martin
a66fd42450 amelioration(estimation_delay): evite des estimations de date similaire 2023-12-07 16:47:16 +01:00
Colin Darie
accd7864ff feat(correction): deleting a comment resolves the related correction
Cf #9731
2023-12-07 15:41:50 +01:00
Colin Darie
0f1980b1c3 refactor(pj): don't poll on antivirus when submitting a pj
Closes #9733
2023-12-07 14:29:09 +01:00
Martin
f26a4bc041 amelioration(delai.traitement): revoie l'affichage du delais d'instruction
Co-authored-by: Colin Darie <colin@darie.eu>
2023-12-07 09:19:52 +01:00
Martin
474fde3380 amelioration(procedure.usual_traitement_time_for_recent_dossiers): divise en 3 groupe l'estimation de la duree de traitement 2023-12-07 09:19:52 +01:00
seb-by-ouidou
e34307b50c fix: fixes after review 2023-12-06 14:47:39 +01:00
seb-by-ouidou
564c3c04fa feat: US4.3.8 administrateur management 2023-12-06 14:47:39 +01:00
Colin Darie
eb42ea9a2d
refactor(admin): improve links & message of PublicationWarningComponent 2023-12-05 18:51:12 +01:00
Christophe Robillard
961c7c5be4 fix format for motivation in notification mail 2023-12-05 18:50:50 +01:00
Colin Darie
60abc6ea6e fix(admin): warn when errors block revision publication 2023-12-05 18:31:20 +01:00
mfo
d90c55c29e
Merge pull request #9762 from tchak/fix-email-template
fix(email_template): less magic - less bugs !
2023-12-05 09:56:53 +00:00
Colin Darie
6674884c25
Merge pull request #9774 from colinux/perf-user-dossiers
ETQ usager l'affichage de la liste de mes dossiers va beaucoup plus vite
2023-12-05 08:59:45 +00:00
Colin Darie
437fb0e39f
test: fix context warning 2023-12-04 15:31:48 +01:00
Colin Darie
75c22bc7d4
perf(usager): cache tabs with a simple and fast cache_key
Plutôt que d'include dans la cache_key tous les scopes utilisés par l'onglet,
(ce qui provquerait une requête par scope),
on le base simplement sur les dossiers & invitations.
Les deleted dossiers sont inclus indirectement car ça correspond à la
suppression (N-1) d'un dossier.
2023-12-04 15:31:47 +01:00
Colin Darie
d70b03c969
style: replace refuse legacy icon 2023-12-04 14:07:25 +01:00
Colin Darie
adfeac02e7
style: replace new-folder icon with remix/dsfr icon 2023-12-04 14:07:17 +01:00
mfo
dbfbaf4cea
Merge pull request #9757 from mfo/US/fix-extends-duree-conservation-dossier
correctif(expiration): etends la durée de conservation des dossiers quand la duree de conservation d'une procedure change
2023-12-04 09:18:45 +00:00
Colin Darie
42ea9ed2f3 perf(preloader): fix N+1 on non mandatory repetition blocks
We have to tell repetition.champs association has been loaded
even when it's empty.
2023-11-30 14:10:33 +01:00
Paul Chavard
3de0367ed9 fix(email_template): less magic - less bugs ! 2023-11-29 20:36:44 +00:00
Paul Chavard
216e2f9198 feat(tiptap): add zones to tiptap service 2023-11-29 12:07:42 +00:00
Martin
57d7b385ec correctif(expiration): etends la durée de conservation des dossiers quand la duree de conservation d'une procedure change 2023-11-28 16:59:41 +01:00
Christophe Robillard
332570bfba superadmin can transfer dossier from a user to another user 2023-11-28 15:48:39 +01:00
Colin Darie
64400b512c
Merge pull request #9677 from govpf/feature-ouidou/clone_procedure_with_feature_flags
ETQ admin, les procédures clonées conservent les features flags
2023-11-28 08:21:02 +00:00
Paul Chavard
bfc809f96f feat(champs): expose more tags and api fields on rnf, address and commune 2023-11-27 15:33:05 +00:00
Colin Darie
15ff65429b
Merge pull request #9738 from colinux/validate-pending-correction
ETQ usager modifiant un dossier en construction je n'ai plus besoin de cocher la case de correction effectuée
2023-11-27 13:52:06 +00:00
Colin Darie
3869dd3a92
Merge pull request #9748 from colinux/fix-etablissement-non-diffusable
ETQ usager on ne m'affiche plus la raison sociale d'un établissement non diffusible
2023-11-27 13:51:54 +00:00
seb-by-ouidou
c4ca381bed feat: enable features on cloned procedure 2023-11-27 12:00:27 +01:00
Colin Darie
3b9285a00b
perf(procedure): description view caching 2023-11-27 11:29:20 +01:00
Colin Darie
5d747ba0c2
fix(procedure): list piece justificative in repetitions 2023-11-27 11:08:39 +01:00
krichtof
fce2d8efa9
Merge pull request #9710 from demarches-simplifiees/9615-form-autosave
ETQ admin, je peux savoir quand mon formulaire a été sauvegardé pour la dernière fois
2023-11-23 23:17:14 +00:00
Christophe Robillard
9c641ccee1 remove flash success messages 2023-11-23 17:10:29 +01:00
Colin Darie
aa84a4c335 fix(entreprise): don't leak identity of non diffusable etablissement 2023-11-23 17:07:05 +01:00
Christophe Robillard
2c6a9e7bf2 add autosave feedback when admin updates form 2023-11-23 13:35:53 +01:00
mfo
78f9a2aa1e
Merge pull request #9737 from demarches-simplifiees/9670-export-rnf
En tant qu'instructeur, je peux exporter les données RNF des dossiers
2023-11-23 08:19:00 +00:00
Eric Leroy-Terquem
d92155a96a
Merge pull request #9714 from demarches-simplifiees/add-not-include-operator
ETQ admin je peux conditionner / router à partir d'un champ de type choix multiple avec l'opérateur "Ne contient pas"
2023-11-22 16:29:24 +00:00
Eric Leroy-Terquem
a54d55486c chore(routing): update routing_rule validation 2023-11-22 13:01:44 +01:00
Colin Darie
ba076357c5
feat(dossier): submit en construction resolve automatically correction except for sva 2023-11-22 12:35:42 +01:00
Christophe Robillard
daa4c28af7 add data from rnf field to export 2023-11-22 12:20:05 +01:00
mfo
0203867460
Merge pull request #9729 from mfo/US/fix-cron-job-that-expires-users
correctif(users.expires): typos et perf
2023-11-21 14:46:14 +00:00
Paul Chavard
4842fc4d94 feat(tags): all tags should have ids 2023-11-21 13:55:25 +01:00
Martin
fd81936baf correctif(users.expires): maj l'appel a process_expired car le service est instanciable maintenant 2023-11-21 10:18:58 +01:00
Colin Darie
99fe4694af fix(announces): link rendering not catched by turbo and fix a11y attributes 2023-11-20 15:07:21 +01:00
Colin Darie
49cd10458c feat(announces): show Nouveautés link in main navigation 2023-11-20 15:07:20 +01:00
Colin Darie
a41c8f73ad refactor(nav): organize main navigation logic across profiles 2023-11-20 15:06:43 +01:00
Colin Darie
f972d36f2f test: fix when using timestamps not yet limited by postgresql precision
Sur des colonnes dont le schema ne connait pas le niveau de précision
(créées avant rails 7), rails créé un timestamp avec la précision système
(par exemple 9 décimales sur linux) alors que pg va l'arrondir
a posteriori à 6.

Ce n'est généralement pas un problème en production,
mais se révèle dans les tests typiquement avec des objets crées
par des factories: si un test dépend de ces timestamps,
il faut récupérer la valeur limitée par pg (d'où le reload),
plutôt que celle directement issue de Time.now à la création de l'objet.

Une alternative aurait été de créer une migration pour ces colonnes pour
forcer la précision à 6 et que le schema en aurait pris connaissance:
rails limiterait la précision de lui même dès la création de l'objet.
2023-11-20 11:22:28 +01:00
Martin
14b2fc30b2 tech(user.expiration): ne perds pas de vue qu'il faut mettre a jour le users.last_sign_in_at 2023-11-17 11:33:14 +01:00
Martin
520863d814 amelioration(user.expiration): ajoute une raison specifique a la suppression d'un dossier : user_expired 2023-11-17 11:33:14 +01:00
Martin
bfe27b5eb7 amelioration(UsersDeletionService.expired_users_with_dossiers): ignore les usagers ayant un dossier en instruction, meme si il a des dossiers en brouillon ou autre 2023-11-17 11:33:14 +01:00
Martin
3a9b520a93 tech(review): quelques améliorations de style 2023-11-17 11:33:14 +01:00
Martin
81826e2509 amelioration(Cron::ExpiredUsersDeletionJob): ne retente jamais ce job si il crash [pour eviter de se lancer ds une boucle infinie de suppression] 2023-11-17 11:33:14 +01:00
Martin
5f452a731e amelioration(UserDeletionService): les usagers ont uniquement identifié comme inactif si ils ne se sont pas connecté depuis 2ans [et on ignore les admin, expert, instructeur, usager avec un dossier en instruction ou usager sans dossier dutout] 2023-11-17 11:33:14 +01:00
Martin
66cf41b6d2 amelioration(procedure.duree_conservation_dossiers_dans_ds_changes): reset les flag d'expirations lorsqu'on change la date de conservation des dosseirs d'une procedure 2023-11-17 11:33:14 +01:00
Martin
1716a931c5 amelioration(Procedure.procedure_expires_when_termine_enabled): active l'expiration des dossiers terminés sur les procedure ne l'ayant pas activé jusqu'à présent. La cible est de faire ça sur 20 Procedure quotidiennement 2023-11-17 11:33:14 +01:00
Martin
3186b0aa68 tech(refactor): centralise/documente les constantes de duree de retentions dans le ns dedié à l'expiration 2023-11-17 11:33:14 +01:00
Martin
c9d470d9ec tech(refactor): mutualise la duree de rentention apres notification entre dossier/user 2023-11-17 11:33:14 +01:00
Martin
aecc41490b tech(refactor): deplace le mail rate limiter dans le module dédié à l'expiration 2023-11-17 11:33:14 +01:00
Martin
fb238ff7ac tech(refactor): deplace l'echelonnement des taches cron liés a l'expiration dans un module dédié 2023-11-17 11:33:14 +01:00
Martin
99529c611d tech(refactor): deplace les service d'expiration usager/dossier dans un namespace dedié 2023-11-17 11:33:14 +01:00
Martin
fb51710309 amelioration(ExpiredUsersDeletionService): ne touche pas aux dossiers en instruction 2023-11-17 11:33:14 +01:00
Martin
054b3be02a tech(clean): cleanup spec and code 2023-11-17 11:33:14 +01:00