DGNum/demarches-normaliennes
15
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

perf(spec): build not create some variables, & fix specs

Browse source
This commit is contained in:
Martin 2024-02-19 16:59:29 +01:00 committed by mfo
parent c2675dfb4d
commit 31168f9602
2 changed files with 10 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
spec/models/dossier_spec.rb
View file

@ -2146,13 +2146,13 @@ describe Dossier, type: :model do
it { expect(dossier.spreadsheet_columns(types_de_champ: [])).to include(["État du dossier", "Brouillon"]) }
context 'procedure sva' do
let(:dossier) { create(:dossier, :en_instruction, procedure: create(:procedure, :sva)) }
let(:dossier) { build(:dossier, :en_instruction, procedure: create(:procedure, :sva)) }
it { expect(dossier.spreadsheet_columns(types_de_champ: [])).to include(["Date décision SVA", :sva_svr_decision_on]) }
end
context 'procedure svr' do
let(:dossier) { create(:dossier, :en_instruction, procedure: create(:procedure, :svr)) }
let(:dossier) { build(:dossier, :en_instruction, procedure: create(:procedure, :svr)) }
it { expect(dossier.spreadsheet_columns(types_de_champ: [])).to include(["Date décision SVR", :sva_svr_decision_on]) }
end

10
spec/services/procedure_export_service_spec.rb
View file

@ -39,9 +39,13 @@ describe ProcedureExportService do
[
"ID",
"Email",
"FranceConnect ?",
"Civilité",
"Nom",
"Prénom",
"Dépot pour un tier",
"Nom du mandataire",
"Prénom du mandataire",
"Archivé",
"État du dossier",
"Dernière mise à jour le",
@ -111,8 +115,8 @@ describe ProcedureExportService do
# SimpleXlsxReader is transforming datetimes in utc... It is only used in test so we just hack around.
offset = dossier.depose_at.utc_offset
depose_at = Time.zone.at(dossiers_sheet.data[0][8] - offset.seconds)
en_instruction_at = Time.zone.at(dossiers_sheet.data[0][9] - offset.seconds)
depose_at = Time.zone.at(dossiers_sheet.data[0][12] - offset.seconds)
en_instruction_at = Time.zone.at(dossiers_sheet.data[0][13] - offset.seconds)
expect(dossiers_sheet.data.first.size).to eq(nominal_headers.size)
expect(depose_at).to eq(dossier.depose_at.round)
expect(en_instruction_at).to eq(dossier.en_instruction_at.round)
@ -174,6 +178,7 @@ describe ProcedureExportService do
[
"ID",
"Email",
"FranceConnect ?",
"Entreprise raison sociale",
"Archivé",
"État du dossier",
@ -245,6 +250,7 @@ describe ProcedureExportService do
[
"ID",
"Email",
"FranceConnect ?",
"Établissement SIRET",
"Établissement siège social",
"Établissement NAF",