3366 commits

Author	SHA1	Message	Date
Paul Chavard	0b10c73bcf	feat(prefill): allow to prefill private annotations	2022-12-26 22:14:17 +00:00
Paul Chavard	4a4ce67ef6	fix(dossier): explicitly send draft notification email	2022-12-26 22:02:33 +00:00
Damien Le Thiec	9e083ea3f7	Merge branch 'main' into feature/prefill_civility	2022-12-26 11:31:52 +01:00
mfo	62813f3d74	Merge pull request #8323 from tchak/fix-graphql-champs ... feat(graphql): add pays champ to API	2022-12-22 13:51:02 +01:00
mfo	e3bf0d8fec	Merge pull request #8327 from tchak/feat-rebase-after-repasser-en-instruction ... feat(dossier): rebase after repasser en instruction	2022-12-22 13:50:43 +01:00
Paul Chavard	f4f38982b4	feat(dossier): rebase after repasser en instruction	2022-12-22 13:44:03 +01:00
Paul Chavard	6363206c44	fix(dossier): when rebase creates a champ always push in to champs	2022-12-22 13:44:03 +01:00
Paul Chavard	4c516a6991	feat(dossier): allow to rebase champs with value made mandatory	2022-12-22 13:08:04 +01:00
Paul Chavard	072156d38e	feat(graphql): add pays champ to API	2022-12-22 11:56:45 +01:00
Paul Chavard	bd9fe7eb7c	feat(export): add pays, region and departement codes	2022-12-21 14:03:02 +01:00
Paul Chavard	3f0f5e381f	refactor(regions): champ regions to use simple select	2022-12-21 14:03:02 +01:00
Paul Chavard	e0b0a42bc3	refactor(departements): champ departements to use simple select	2022-12-21 14:03:02 +01:00
Paul Chavard	f7c1dff22a	refactor(pays): champ pays to use simple select	2022-12-21 14:03:02 +01:00
François Vantomme	993c1b8676	fix(batch operation): ensure to append bigint to SQL array	2022-12-21 11:59:55 +01:00
Christophe Robillard	11a18516b2	remove feature flag zonage	2022-12-21 09:02:16 +01:00
Paul Chavard	227296682b	fix(dossier): clone should include more attachments	2022-12-20 21:30:32 +01:00
Colin Darie	c673950e56	fix(instructeurs): behavior of sort by notifications checkbox (updated_at desc)	2022-12-20 15:51:47 +01:00
Damien Le Thiec	c4e427642f	Allow prefill civility	2022-12-20 14:38:05 +01:00
Sébastien Carceles	e4a7a4c391	hide values and examples for unprefillable champs (#8309) ... * hide values and examples for unprefillable champs * put prefillable champs first	2022-12-20 13:37:25 +00:00
Sébastien Carceles	dd0a05c1d8	feat(prefill): add possible values (#8299) ... * update layout in order to show possible values * filter out non fillable types de champ	2022-12-20 11:04:42 +01:00
Sébastien Carceles	0a10a08c21	feat(demarche): describe procedure prefilling (#8187) ... * feat(demarche): description Show the description of an opendata procedure (published or draft), with help about how to prefill a dossier for this procedure. Co-authored-by: Damien Le Thiec <damien.lethiec@gmail.com>	2022-12-19 11:32:09 +00:00
Martin	dd74834689	amelioration(attestation.et.mail): desactive les tags sur les champs conditionnés et informe l'usager que ca arrivera	2022-12-19 09:28:46 +01:00
Christophe Robillard	f1595d1f50	wrap resultset tuples in ProcedureDetail	2022-12-16 15:51:49 +01:00
Christophe Robillard	3a660349ad	export all demarches	2022-12-16 15:51:49 +01:00
Eric Leroy-Terquem	2645ac85f7	update wording and order in types de champ select	2022-12-16 09:30:36 +01:00
Paul Chavard	cb5b60ccda	Revert "Revert "Merge pull request #7907 from tchak/feat-cond-repetitions"" ... This reverts commit 0d10d36cb0. # Conflicts: # app/models/dossier.rb # app/models/dossier_preloader.rb	2022-12-15 19:09:25 +01:00
Sébastien Carceles	b8ff0ba4a2	feat(demarche): sign up when prefilling a dossier (#8247) ... * store prefill params in session Instead of using query params on /dossier/new, we assume the user comes from /commencer/:path, which is the new prefill link. There, we store the prefill params in session, and use them to prefill the dossier when creating it, in /dossiers/new. * spec: cover the case * review: serialize with json instead of yaml * review: rename method * review: store only query params * review: comment why we dont override already stored params	2022-12-15 10:58:17 +01:00
Lisa Durand	89730b485b	add bulk action feature for 'passer_en_instruction'	2022-12-15 10:04:25 +01:00
Colin Darie	7ff04c1a05	style(instructeurs): human/i18n value for state filter	2022-12-15 09:34:10 +01:00
mfo	74cd385b35	Merge pull request #8274 from tchak/fix-parent-dossiers ... fix(dossier): parent_dossiers is really cloned_dossiers	2022-12-15 09:20:10 +01:00
Paul Chavard	243a8301bb	fix(dossier): authorize passage en instruction if auto archive is on and is in the past	2022-12-14 22:16:13 +01:00
Paul Chavard	59bdd4bd92	fix(tags): relax parser roules	2022-12-14 17:53:36 +01:00
Paul Chavard	9149e0fcd7	feat(revision): allow more dossiers to rebase	2022-12-14 17:42:27 +01:00
Paul Chavard	1b95809f14	refactor(dossier): flatten champ attributes	2022-12-14 13:03:06 +01:00
Paul Chavard	0d10d36cb0	Revert "Merge pull request #7907 from tchak/feat-cond-repetitions" ... This reverts commit 1900f8ff4c, reversing changes made to febffc2d64. # Conflicts: # app/models/dossier.rb	2022-12-14 11:25:45 +01:00
Paul Chavard	ece70efbea	refactor(dossier): improuve dossiers_safe_scope on batch operation	2022-12-14 09:45:53 +01:00
Paul Chavard	9510142cd8	fix(dossier): parent_dossiers is really cloned_dossiers	2022-12-14 09:44:19 +01:00
Paul Chavard	7929b7d0d7	clean(api_token): remove administrateur token support	2022-12-08 17:35:21 +01:00
sebastiencarceles	69d61913f5	review: unauthorize complex champs	2022-12-08 15:27:39 +01:00
sebastiencarceles	bf03e3b35a	review: prefix typed ids with 'champ_'	2022-12-08 15:27:39 +01:00
sebastiencarceles	11fed2c934	review: champs exist because stable ids exist	2022-12-08 15:27:39 +01:00
sebastiencarceles	a5c1c68a91	review: style	2022-12-08 15:27:39 +01:00
Sébastien Carceles	9dfb498806	review: prefer if to unless ... Co-authored-by: LeSim <mail@simon.lehericey.net>	2022-12-08 15:27:39 +01:00
Damien Le Thiec	006a1257b5	Refacto prefill_params construction (remove merge)	2022-12-08 15:27:39 +01:00
sebastiencarceles	373e8aeadb	review: validate prefilled champs only	2022-12-08 15:27:39 +01:00
sebastiencarceles	1e21a3d3e1	review: query the db only once	2022-12-08 15:27:39 +01:00
sebastiencarceles	ab30af5fe5	review: move Prefillable to concern directory	2022-12-08 15:27:39 +01:00
sebastiencarceles	3939644030	validate prefilled champs when editing brouillon	2022-12-08 15:27:39 +01:00
sebastiencarceles	79ef48cafb	make the dossier prefillable	2022-12-08 15:27:39 +01:00
sebastiencarceles	f4e1a09e73	prepare prefilled values from ctrl params	2022-12-08 15:27:39 +01:00
sebastiencarceles	24802985a2	feat(dossier): prefill dossier from query params	2022-12-08 15:27:39 +01:00
Paul Chavard	52a32051c4	feat(dossier): add dossier.champs_public_all	2022-12-08 09:38:12 +01:00
Paul Chavard	6ce7064ffd	feat(dossier): add repetition champs to champs_for_condition	2022-12-08 09:38:12 +01:00
simon lehericey	86cda6a0b9	fix(timestamp spec): rewind io after before_save check	2022-12-07 19:28:01 +01:00
Paul Chavard	ebbada752f	feat(api_token): add APIToken model	2022-12-07 18:19:37 +01:00
Paul Chavard	4fe081e4be	fix(dossier): send notifications on declarative dossiers	2022-12-07 13:14:59 +01:00
Paul Chavard	bb47e8d2ab	fix(dossier): dossier.repasser_en_construction! should take disable_notification	2022-12-07 13:14:59 +01:00
Colin Darie	f4d403a81c	fix(apiv1): piece_justificative continue to returns a single attachment	2022-12-06 15:47:06 +01:00
Martin	2eaa06b22b	correctif(export.pjs): sur l'export, les champs de type piece justificative renvoyent un tableau de la meme dimension quelque soit le nombre de pj joint	2022-12-06 15:22:53 +01:00
Paul Chavard	b8a9b7223c	refactor(groupe_instructeur): improuve controller	2022-12-06 12:01:54 +01:00
Paul Chavard	9fe93ded7f	refactor(groupe_instructeur): add instructeur.find_or_invite	2022-12-06 12:01:54 +01:00
Colin Darie	4ba76e6844	fix(api-v1): dossier -> avis -> piece_justificative_file_attachment relation name	2022-12-06 11:48:42 +01:00
Paul Chavard	ed4d5cb36a	refactor(demarche): make declarative demarche processing syncroneous	2022-12-06 11:41:25 +01:00
Martin	91ef618a42	clean(code): stick to usage of present?/empty? instead of count zero etc	2022-12-06 11:28:48 +01:00
Martin	b5f69c8961	review(dossier.reload): evite de recharger le batch qui peut etre confusant	2022-12-06 11:28:48 +01:00
Martin	7c65af3be0	poc(batch_operation_alert): simplier wording	2022-12-06 11:28:48 +01:00
Martin	ea8bd13bcf	poc(batch_operation.purge): nettoie les batch terminé ou inutiles	2022-12-06 11:28:48 +01:00
Lisa Durand	1beb219fdd	display batch operation alerts	2022-12-06 11:28:48 +01:00
Martin	e5944eed34	poc(batch_operation): habtm groupe instructeurs, permettra de visualiser plus facilement les batch en cours pour les instructeurs du meme groupe	2022-12-06 11:28:48 +01:00
Martin	eaf72162da	poc(batch_operation): some rewrite to avoid various conflict (when an instructeur try to create a job with an incompatible dossier regarding the current task). also soome cleanup to isole spec in least involved model	2022-12-06 11:28:48 +01:00
Martin	4266ab93c5	poc(batch_operation): track dossier processed safely	2022-12-06 11:28:48 +01:00
Martin	beb39027d0	poc(batch_operation.ui): implement simple ui to trigger a batch of current page	2022-12-06 11:28:48 +01:00
Martin	7df86c50fb	poc(batch_operations_controller): implement simple [not yet with procedure_presentation] action to create a batch operation	2022-12-06 11:28:48 +01:00
Martin	b11dbafc59	poc(batch_operation_job): implement archive dossiers with async behaviour, lock, run_at, finished_at, failed_dossier_ids, success_dossier_ids	2022-12-06 11:28:48 +01:00
Martin	61f4cded75	poc(batch_operation): just the model and some specs and a poc for archive them without async	2022-12-06 11:28:48 +01:00
Colin Darie	b13c5e56f6	refactor(piece_justificative): UX follows mockups	2022-12-05 10:47:10 +01:00
Colin Darie	0014ce4b91	chore(schema): +procedures#piece_justificative_multiple	2022-12-05 10:47:10 +01:00
Colin Darie	b8296c6d4d	feat(piece_justificative): supports multiple files ... Closes #7924	2022-12-05 10:47:10 +01:00
Colin Darie	91f4971df2	feat(champ): has_one_attached => has_many_attached piece_justificative_file	2022-12-05 10:47:10 +01:00
Paul Chavard	ece68076a7	feat(dossier): add some metadata to archive and remove operation log	2022-11-30 16:20:13 +01:00
Paul Chavard	a90dada104	fix(patron): dossier should have a procedure and champ should delegate to dossier	2022-11-30 10:54:03 +01:00
Paul Chavard	1fb051c3cc	refactor(attestation_template): remove unused code	2022-11-29 19:36:56 +01:00
Paul Chavard	06f43f99d0	fix(dossier): excluded deleted dossiers from demarche overview	2022-11-29 16:41:31 +01:00
simon lehericey	dcae06ae84	fix(avis_controller): index do not linked to revoked avis	2022-11-29 16:21:06 +01:00
simon lehericey	f96a7f432c	clean(dossier): useless method	2022-11-29 15:33:10 +01:00
Paul Chavard	53eb3e6ad0	chore(dossier): cleanup champs nested attributes	2022-11-29 11:10:59 +01:00
Paul Chavard	a760e0a698	feat(demarche): enable revisions for all	2022-11-24 17:35:33 +01:00
Paul Chavard	7a35a253a0	chore(dossier): cleanup clone champ	2022-11-24 16:25:27 +01:00
Christophe Robillard	1003a24711	remove useless spaces	2022-11-24 15:05:46 +01:00
Christophe Robillard	3539b00652	search admins by email	2022-11-24 15:05:46 +01:00
Paul Chavard	234975b806	feat(graphql): expose groupe_instructeur state and update mutation	2022-11-24 14:33:29 +01:00
Paul Chavard	405d2a695f	refactor(attestation_template): remove from revisions	2022-11-23 12:26:26 +01:00
Paul Chavard	c73b650f85	feat(attestation): validate attestation tags	2022-11-23 12:26:26 +01:00
Paul Chavard	cafda4f6f0	refactor(attestation_template): move to procedure	2022-11-23 12:26:26 +01:00
Paul Chavard	c0fd080d0e	refactor(operation_log): store data in jsonb instead of files	2022-11-22 18:06:05 +01:00
Paul Chavard	e4bf1bd2db	feat(dossier): add data to DossierOperationLog	2022-11-22 18:06:05 +01:00
Christophe Robillard	8e95c6a2ba	search procedures by libelle	2022-11-22 17:08:17 +01:00
simon lehericey	4babee2591	fix(admin): ignore active column ... the attribut should be retrieve from the user model as the administrateur is no more a devise model	2022-11-22 16:41:20 +01:00
simon lehericey	fe35a8a6e7	fix(cni): only allow jpg and png because of buggy pdf watermarking	2022-11-21 17:53:29 +01:00
Lisa Durand	3953470c78	remove change on api V1 and update graphql for sensitive data	2022-11-18 11:15:16 +01:00
Lisa Durand	f34c890278	add a label for api and export for sensitive data as titre_identite_champ	2022-11-18 11:15:16 +01:00
Paul Chavard	0c0618aa79	feat(export): add GeoJSON export	2022-11-18 10:04:35 +01:00
simon lehericey	66e9b74121	feat(manager): select team_user base on attribute	2022-11-17 16:29:08 +01:00
Paul Chavard	29bdd82b59	refactor(procedure): types_de_champ -> active_revision.types_de_champ_public	2022-11-17 13:54:14 +01:00
simon lehericey	9ed42b316f	refactor(user): administration -> super_admin ... delete_and_keep_track_dossier_also_delete_user is only called by super admin	2022-11-16 17:52:48 +01:00
simon lehericey	99871b6ba6	refactor(user): introduce method to only delete dossier	2022-11-16 17:52:47 +01:00
simon lehericey	fcfe09f05a	refactor(user): rename delete_and_keep_track_dossiers	2022-11-16 17:52:47 +01:00
Paul Chavard	6f6b3896de	refactor(export): reduce repetition in export code hopefully making it more readable	2022-11-16 08:49:37 +01:00
Paul Chavard	c1ae9d03be	feat(export): show refresh button sooner	2022-11-16 08:49:37 +01:00
Martin	18b7f4e4fa	remaniement(dossier.clone): simplifications, pas de callback/after, pas d'heritage, mm interface pour cloner les champs public/prive, clonage des PJs avec le nouveau service de clone, ajoute une cle etrangere sur la colonne parent_dossier_id	2022-11-14 09:53:19 +01:00
Martin	90f7d265c6	amelioration(clone.piece_justificative): gestion du clonage des piece justificative dans une tache asynchrone	2022-11-14 09:13:54 +01:00
Martin	844004818a	amelioration(dossier.clone): dossier.clone, permet de cloner un dossier	2022-11-14 09:13:52 +01:00
Paul Chavard	e6288c39f2	refactor(dossier): champs -> champs_public	2022-11-10 22:44:39 +00:00
Christophe Robillard	cc35788d26	extract computation to controller	2022-11-10 18:02:20 +01:00
Christophe Robillard	5f5b6bf7c7	use specific route for all admins	2022-11-10 18:02:20 +01:00
Christophe Robillard	c96781cfad	list all admins	2022-11-10 18:02:20 +01:00
Paul Chavard	95f65900d3	refactor(active_storage): no download on clone	2022-11-10 12:25:55 +00:00
Paul Chavard	5e87539d6d	fix(groupe_instructeur): add explicit order to groupe_instructeurs	2022-11-09 10:56:40 +00:00
Christophe Robillard	87832f6eb2	fix pagination bug	2022-11-09 10:41:06 +01:00
Christophe Robillard	a5fa21ca1b	add from_publication_date filter	2022-11-09 10:41:06 +01:00
Martin	b3f80dc5f9	amelioration(Procedure.revision_changes): ajout du support pour les texte complementaire affichable au clique des champs de type explication ... Co-authored-by: Paul Chavard <github@paul.chavard.net>	2022-11-08 17:49:24 +01:00
Martin	df54dc04a4	amelioration(champ.explication): ajout du support pour avoir un menu depliant avec plus d'information sur un champs explication ... amelioration(champ.explication): ajout du support pour avoir un menu depliant avec plus d'information sur un champs explication	2022-11-08 17:49:24 +01:00
Martin	fe0411203f	amelioration(types_de_champ/editor): en mode edition d'un champ de type explication, permet de choisir d'afficher ou pas cette explication derriere un collapse	2022-11-08 17:49:24 +01:00
Martin	0d675d4ee5	amelioration(Champ.titre-d-identite): ajout du support pour les .pdf	2022-11-08 16:27:06 +01:00
Christophe Robillard	c0231dffa2	extract ProceduresFilter class	2022-11-08 12:14:26 +01:00
Martin	bd28c29856	amelioration(manager): ajout de la visualisation des comptes marqués comme membre de l'equipe	2022-11-08 09:55:21 +01:00
Martin	c9292e7ba8	amelioration(bdd): mise en place d'un flag pour identifier les anciens comptes d'admin de DS	2022-11-08 09:55:21 +01:00
simon lehericey	1760ccbc01	fix(merge): transfers hidden procedures	2022-11-07 14:11:05 +01:00
Paul Chavard	1e8a440166	feat(graphql): expose deleted dossiers on groupe instructeur	2022-11-04 11:49:27 +00:00
Eric Leroy-Terquem	aca2775874	remove routee? method	2022-11-04 12:03:44 +01:00
Eric Leroy-Terquem	b51770c151	toggle routing after groupe instructeur update	2022-11-04 12:03:44 +01:00
Eric Leroy-Terquem	5578115acf	update routee? method	2022-11-04 12:03:43 +01:00
Eric Leroy-Terquem	110953e450	constraint logic to active groups	2022-11-04 12:03:43 +01:00
Eric Leroy-Terquem	63ae328bee	update wording and cards order	2022-11-04 12:03:43 +01:00
Eric Leroy-Terquem	b419c48262	toggle routing when adding or deleting groupe_instructeurs	2022-11-04 12:03:43 +01:00
Paul Chavard	33fc8a45ab	feat(emails): show email errors on procedure page	2022-11-04 09:08:41 +00:00
Paul Chavard	dd4c1f2fac	feat(emails): validate tags in notification emails	2022-11-04 09:08:41 +00:00
Paul Chavard	91a662fdb9	fix(graphql): make sure dossiers are always loaded with appropriate scope	2022-11-02 11:25:26 +01:00
Kara Diaby	661e5f78ac	model	2022-11-02 10:19:43 +01:00
Martin	ef2064a603	nettoyage(Traitement): supprime une methode morte	2022-11-01 12:43:49 +01:00
Martin	1b1568b2c2	remaniement(Administrateurs::ArchivesController): ne passe pas par la table des traitement pour compter le nombre de dossier traites par mois. Depuis que nous avons redescendu la colonne processed_at sur la table dossiers, ce n'\est plus necessaire et le code est compliqué a comprendre	2022-11-01 12:43:49 +01:00
Martin	cb1726366f	correctif(administrateur/procedure/archives#index): ne pas utiliser la table des traitement pour la comptabilisation du nombre de dossier dans une archive car si le dossier a ete accepte [mois n-1], repasse en instruction[mois-n1], accepte[mois-narchive], on se retrouve avec le dossier dans plusieurs archives et des compteurs confusant	2022-11-01 12:43:49 +01:00
simon lehericey	52b7886961	fix(clone): on procedure clone, discard integrity error	2022-11-01 10:17:24 +01:00
Paul Chavard	8cf9aec0f7	refactor(procedure): expose procedure tags on model	2022-10-31 19:50:25 +01:00
Christophe Robillard	9abf1c4af3	list all demarches, filtered by zones	2022-10-31 16:12:02 +01:00
Christophe Robillard	f9f31b721a	get zones of an admin	2022-10-31 16:12:02 +01:00
Martin	60dc6a3912	correctif(export.global): Export.find_for_groupe_instructeurs remonte les exports globaux même lorsqu'il y a une procedure presentation	2022-10-31 14:32:17 +01:00
Colin Darie	3a06e7e0b3	refactor(tdc): convert fill duration in Duration objects	2022-10-31 12:17:16 +01:00
Colin Darie	010c9a0dcb	feat(procedure): includes read duration of explication/non fillable champs ... Long explications can significantly increase global fill duration, so we can't ignore them. Closes #7963	2022-10-31 12:17:16 +01:00
Colin Darie	7731c6ad64	feat(procedure): estimate fill duration takes account of libelle & description read time ... Sometimes long description on types de champ significantly increases global fill duration. 140 words per minute is a good estimate of attentive off-voice read time. (This is independent of characters per word). Closes #7963	2022-10-31 12:17:16 +01:00
Martin	5ced9fb431	chore(create_procedure_presentation): homogénéise l'interface sur les procédure présentation. pas d'objet 'build', sinon les export/filtres deviennent compliqués	2022-10-31 09:29:27 +01:00
Martin	50c43f4819	correct(export): la creation d'archive pour un groupe d'instructeur, avec des filtres differents et identique doit etre consistante	2022-10-31 09:29:27 +01:00
Colin Darie	9f2fa5ee1c	fix(invitation): don't fail when dossier is hidden & user signed on another account ... Suite de 45994ff567 Cf https://sentry.io/organizations/demarches-simplifiees/issues/3422144920/events/e1c83ea74dbc410ea22aa17ef29fb329/?project=1429550	2022-10-28 08:56:03 +02:00
simon lehericey	4c98b8f01c	fix(merge): ensure service transfert always works	2022-10-27 12:44:02 +02:00
simon lehericey	44aff1a293	fix(silent_error_in_merge): raise if merge update fail	2022-10-26 23:27:53 +02:00
simon lehericey	6af4fe624a	refactor(service): explicit call to service job to avoid test side effect	2022-10-25 14:44:43 +02:00
Kara Diaby	492c7f377f	migration	2022-10-21 19:13:12 +02:00
Paul Chavard	f2e8dba8e4	fix(dossier): tag can contain non breaking space	2022-10-21 16:34:19 +02:00
Paul Chavard	d7c5dcf8bb	fix(dossier): a tag can be preceded by a -	2022-10-21 16:06:32 +02:00
Colin Darie	45994ff567	fix(invitation): when dossier is not visible anymore ... https://sentry.io/organizations/demarches-simplifiees/issues/3422144920/	2022-10-20 09:08:36 +02:00
Martin	576aa2c1e0	amelioration(export): augment la duree de conservation des exports en cours de generation passant de 12 a 16h. augment la duree de conservation des exports generés passant de 16 à 32h	2022-10-20 06:32:41 +02:00
simon lehericey	5fa5d46d8c	fix(admin_merge): a case where 2 admins have the same service	2022-10-19 16:54:34 +02:00
Paul Chavard	5be8810da4	fix(dossier): nullify instructeur and expert id on messages when they are deleted ... we keep email on the message so it will be used when instructeur or expert are not available	2022-10-19 11:53:10 +02:00
simon lehericey	c6e7db3622	fix(export): bug when combining revision and conditional	2022-10-18 11:53:13 +02:00
simon lehericey	fbf089d60e	refactor(dossier): rename check_mandatory_champs -> check_mandatory_and_visible_champs	2022-10-18 11:13:41 +02:00
simon lehericey	9bba2093be	refactor(champ): mandatory_blank_and_visible? -> mandatory_blank? ... As the method does not check visibility	2022-10-18 11:13:41 +02:00
simon lehericey	7114623285	fix(champ): rewire champ.mandatory? to type_de_champ.mandatory? ... it fixes behaviour in drop_down_list_component which add option if not mandatory (!= not required)	2022-10-18 11:13:41 +02:00
simon lehericey	528b7ec3f8	refactor(champ): add required? ... used for the `required` html attribute. It check visibility to avoid hidden required input which prevent the form from being sent.	2022-10-18 11:13:41 +02:00
Paul Chavard	c075a4e415	fix(dossier): we should never detroy user’s dossiers in cascade	2022-10-14 14:14:51 +02:00
simon lehericey	d5d031e15d	fix(export): do not export invisible champ	2022-10-14 10:30:27 +02:00
simon lehericey	40a3fff593	perf(dossiers_controller): do not load pj template in update, -10ms	2022-10-13 22:36:56 +02:00
simon lehericey	f8ee6386b9	perf(champ): check condition.present? without json deserializationl, -6ms	2022-10-13 22:36:56 +02:00
simon lehericey	73b4ee64e6	perf(champ_value): use champ_type instead of tdc.type_champ, -22ms	2022-10-13 22:36:56 +02:00
Eric Leroy-Terquem	c6082ded09	no select for usager if only one groupe_instructeur	2022-10-13 19:49:32 +02:00
Martin	d09c47f5ce	correctif(usager.fusion): leve une erreur quand on essaie de fusionner un compte sur lui même	2022-10-13 17:00:20 +02:00
Paul Chavard	1fd1878370	feat(jobs): add request_id to jobs payload	2022-10-12 14:32:23 +02:00
Paul Chavard	7f1dd49bdc	chore(flipper): always use feature_enabled? helper	2022-10-12 14:14:30 +02:00
Damien Le Thiec	29a97fac43	Merge branch 'main' into feature/add_rna_type_de_champs	2022-10-11 18:59:45 +02:00
Damien Le Thiec	0e995c8bcc	Update app/models/champs/rna_champ.rb ... Co-authored-by: Paul Chavard <paul.chavard@beta.gouv.fr>	2022-10-11 16:34:00 +02:00
simon lehericey	7672ad3fe9	fix(editor champ): do not raise on destroy replay	2022-10-11 16:27:49 +02:00
Damien Le Thiec	73f6063c87	Merge branch 'main' into feature/add_rna_type_de_champs	2022-10-11 15:36:46 +02:00
Damien Le Thiec	2e8c0512a5	Remove skip_cleanup option	2022-10-11 15:11:51 +02:00
Damien Le Thiec	bcdc9c18ae	Remove skip_fetch_data mechanism	2022-10-11 11:52:59 +02:00
Paul Chavard	a19bf050ef	fix(iban): format iban after validation	2022-10-11 10:43:32 +02:00
simon lehericey	157c3778df	refactor(dossier_preloader): add option to laod pj_template	2022-10-10 12:31:40 +02:00
simon lehericey	7e03f0c825	refactor(dossier_preloader): add load_one api	2022-10-10 12:31:40 +02:00
simon lehericey	5920168077	refactor(dossier_preloader): preload piece_justificative_template	2022-10-10 12:31:40 +02:00
simon lehericey	1f95f68fcc	refactor(dossier_preloader): assign champ.parent	2022-10-10 12:31:40 +02:00
simon lehericey	5df76d9fec	refactor(dossier_preloader): remove weird set_inverse_instance	2022-10-10 12:31:40 +02:00
Martin	c921e6e1ee	fix(ProcedureExportService): downloadable_sorted_batch is scoped by export, no need to re-filter them via downloadablable_sorted_batch otherwise export for supprimes_recemment does not includes dossier.supprimes_recemment	2022-10-10 11:11:21 +02:00
Eric Leroy-Terquem	1177d861f4	add validation on routing_criteria_name	2022-10-10 09:48:11 +02:00
Martin	6752da40a9	test(procedure.direction): can we drop this column ?	2022-10-07 18:39:17 +02:00
simon lehericey	ceaf8ebbe7	fix: orphan tdc due to reset_draft	2022-10-07 17:44:30 +02:00
krichtof	44018a86de	a procedure without zone is finally valid	2022-10-07 16:59:12 +02:00
Christophe Robillard	272c8cae09	cannot publish a procedure if no zones	2022-10-07 10:48:35 +02:00
Christophe Robillard	bdcb451d3c	procedure publiee must have one zone at least	2022-10-07 10:48:35 +02:00
Christophe Robillard	94ca93e130	can choose multiple zones	2022-10-07 10:48:35 +02:00
Christophe Robillard	bffd9d61a9	add habtm between procedures and zones	2022-10-07 10:48:34 +02:00
simon lehericey	0e75f9960b	fix: send_dossier_decision preview	2022-10-06 17:43:09 +02:00
Martin	a256dfbaa0	fix(spec): missed a failed spec previously. sorry	2022-10-06 15:34:29 +02:00
mfo	8a3550cda4	Merge pull request #7860 from mfo/US/procedure-duree-up-to-manager ... feat(procedure.max_duree_conservation_dossiers_dans_ds): make it more flexible	2022-10-06 11:36:50 +02:00
mfo	e76b97fcb5	Merge pull request #7862 from mfo/US/cleanup-other-col ... clean(procedure.columns): :durees_conservation_required, :cerfa_flag, :test_started_at	2022-10-06 11:36:00 +02:00
Martin	883ba8717f	clean(procedure.columns): :durees_conservation_required, :cerfa_flag, :test_started_at	2022-10-05 18:03:49 +02:00
Martin	405a885160	feat(procedure.max_duree_conservation_dossiers_dans_ds): make it more flexible	2022-10-05 17:27:09 +02:00
Damien Le Thiec	abbbef1461	Fix tests	2022-10-05 13:07:39 +02:00
Damien Le Thiec	0131a41266	Merge branch 'main' into feature/add_rna_type_de_champs	2022-10-05 12:38:24 +02:00
Paul Chavard	432c4690b5	feat(tags): replace regexp based parser with a parser combinator	2022-10-05 11:25:37 +02:00
Eric Leroy-Terquem	acd874ccdf	reorder inside categories	2022-10-05 09:21:08 +02:00
Eric Leroy-Terquem	6925ca66e6	add grouped options for select	2022-10-05 09:21:08 +02:00
Damien Le Thiec	0d9f02c88d	First draft autofetch data for RNA	2022-10-04 22:11:01 +02:00
Damien Le Thiec	e694ff1f60	Fix update external id after validation	2022-10-04 17:19:16 +02:00
Martin	7125e8538a	clean(engagement): remove last pieces of engagement champs	2022-10-04 07:17:47 +02:00
simon lehericey	6a5a82ce06	fix(instructeur dashboard): dossiers filtered on multiple states	2022-10-03 15:18:46 +02:00
Martin	aceb8996c1	feat(instructeur/procedure#show): enhance sort by notifications as planned by UX ... Update app/javascript/controllers/checkbox_controller.ts Co-authored-by: Paul Chavard <github@paul.chavard.net>	2022-09-30 10:29:51 +02:00
Paul Chavard	462cc41caa	refactor(block): use block? instead of repetition?	2022-09-29 17:49:14 +02:00
Paul Chavard	df47f4a7ab	feat(graphql): new tokens should carry administrateur_id	2022-09-29 11:58:58 +02:00
Martin	d7cce3c982	fix(instructeur/procedures#show): Procedure presentation filterable state field is in conflict with projected state field. quick fix, maybe will refactor both to align them	2022-09-28 15:28:51 +02:00
Kara Diaby	e1999d5729	fix checkbox mandatory champ	2022-09-28 10:53:24 +02:00
simon lehericey	8efd305256	add upper_tdcs to condition_form	2022-09-28 10:06:31 +02:00
simon lehericey	7e1963865e	compatibility from left	2022-09-28 10:06:31 +02:00
simon lehericey	43f926a1de	to_s	2022-09-28 10:06:31 +02:00
simon lehericey	f98d1463a6	compatible_type	2022-09-28 10:06:31 +02:00
simon lehericey	cd2b08e39b	options	2022-09-28 10:06:31 +02:00
simon lehericey	12b6a0d6d6	errors	2022-09-28 10:06:31 +02:00
simon lehericey	70022450cf	type	2022-09-28 10:06:31 +02:00
Martin	17ed80b18a	clean(Champs::Engagement): migrate to Champs::Checkbox, some for TypeDeChamp	2022-09-27 19:09:28 +02:00
Martin	ba6c5b4db7	feat(instructeur/procedure#index): enhance filter to support processed_at and state [plus en_instruction_at/since] ... feat(filter): enable filter on dossiers.state, dossiers.processed_at(since), dossiers.en_instruction_at(since)	2022-09-27 17:19:54 +02:00
Colin Darie	e18dbb976f	fix(graphql/serializer): PersonneMorale#date_creation may be null ... Ça fix le passage du dossier dans un dossier "terminé" pour un dossier dont un champ avec SIRET correspond à un établissement sans date de creation connue.	2022-09-26 18:05:04 +02:00
Christophe Robillard	ddd5f6ece2	make label method name more explict	2022-09-26 16:58:53 +02:00
Christophe Robillard	f452e1014a	make label_at more concise	2022-09-26 16:58:53 +02:00
Christophe Robillard	240f1b249f	makes the NA label for zone more explicit	2022-09-26 16:58:53 +02:00
Christophe Robillard	9a9330159c	choose zone options with correct label ... label of the zone is the one available when the procedure has been published (or at the creation if the procedure has not been published)	2022-09-26 16:58:53 +02:00
Christophe Robillard	62f19aba8a	get all available zones at specific date	2022-09-26 16:58:53 +02:00
Christophe Robillard	9773977496	know if a zone exist at a specific date	2022-09-26 16:58:53 +02:00
Christophe Robillard	59cce4203a	get zone label at specific date	2022-09-26 16:58:53 +02:00
Christophe Robillard	a504e82021	add zone label	2022-09-26 16:58:53 +02:00
simon lehericey	f53e8608ae	refactor(conditional): error message system	2022-09-26 10:21:15 +02:00
simon lehericey	ab42b27176	refactor(logic): add comments	2022-09-26 10:21:15 +02:00
simon lehericey	fcb9b55bc4	feat(conditional): add include operator	2022-09-26 10:21:15 +02:00
Damien Le Thiec	542c5b518f	Improve and connect RNA Adapter	2022-09-22 17:13:53 +02:00
Colin Darie	6a4a9c8e03	fix(cron/procedure-declarative): don't auto accept a dossier still in degraded mode	2022-09-22 16:26:14 +02:00
Colin Darie	9b929c86ea	Merge pull request #7760 from betagouv/dsfr-dossier-top-form ... DSFR: convert dossier top form elements	2022-09-21 16:44:51 +02:00
Colin Darie	e7de19b24d	fix(dossier): avoir final state if etablissement is still in degraded mode ... Maintenant qu'on autorise un dossier pour entreprise a être créé en mode "dégradé", (avec établissement incomplet suite à API Entreprise/INSEE down…), on empêche de l'accepter/refuser/classer sans suite tant qu'on a pas vérifié son SIRET. Fix https://sentry.io/organizations/demarches-simplifiees/issues/2839832517/?project=1429550&query=is%3Aunresolved	2022-09-21 16:00:59 +02:00
Colin Darie	a5e1d8865b	style(france_connect_account): convert notice about FC user to DSFR	2022-09-21 15:47:35 +02:00
Paul Chavard	16bba911ba	Revert "Merge pull request #7637 from tchak/chore-add-missing-foreign-keys" ... This reverts commit b21ee46dc2, reversing changes made to dd85b5c35c.	2022-09-21 15:20:42 +02:00
Damien Le Thiec	d8afe81034	Setup RNA champ	2022-09-21 15:18:08 +02:00
Damien Le Thiec	606ac48964	Add new RNA Type de champ	2022-09-21 15:17:23 +02:00
Paul Chavard	84b9644bcd	fix(db): add missing foreign keys	2022-09-20 15:16:52 +02:00
Martin	eae05b0a6f	feat(export.xslx): add code commune to geo_area.label	2022-09-17 08:59:06 +02:00
Colin Darie	95a4e8a907	feat(api_entreprise): create etablissement with fallback when API is down ... On créé l'établissement uniquement avec le SIRET, sans que ce soit bloquant pour compléter le dossier. On demande à l'utilisateur de vérifier lui-même la concordance du SIRET avec son entreprise. Cf #7766	2022-09-16 10:43:59 +02:00
simon lehericey	c43bf2e5c9	fix(conditional): only parse user input as int if compared with a number	2022-09-09 11:28:32 +02:00
Paul Chavard	d35ceb7214	fix(champs): finish EditableChampComponent refactor	2022-09-08 11:26:29 +02:00
simon lehericey	ac0ac171ad	perf(dossier): remove unused row validation ... Gain, one request per champ not child	2022-09-07 15:00:40 +02:00
Paul Chavard	c05bc61c99	fix(revisions): improuve changes information display	2022-09-07 13:52:44 +02:00
Colin Darie	91c735a219	chore(service): SIRET is required	2022-09-06 09:23:52 +02:00
Colin Darie	9d59a50cd4	chore(manager/services): show etablissement adresse & geopoint	2022-09-06 09:23:52 +02:00
Colin Darie	67cbc61e1e	chore(services): update etablissement adresse & geocode when siret changes	2022-09-06 09:23:52 +02:00
Colin Darie	7d39cc6b3e	chore(schema): +services#etablissement_{infos,geopoint} ... - `etablissement_infos` est une représentation partielle en jsonb de ce qui est renvoyé par l'API Entreprise. (On ne conserve que l'adresse pour le moment, utilisée pour le geocodage) - `etablissement_geopoint` est le point (x,y) issu du géocodage de l'établissement	2022-09-06 09:23:52 +02:00
Colin Darie	64ce2719ed	feat(services): accept an optional SIRET ... Closes #7359	2022-09-06 09:23:52 +02:00
Colin Darie	a4d9a45280	chore(schema): +services#siret	2022-09-06 09:23:52 +02:00
Colin Darie	4e3b063b87	feat(carte/export): list geo labels	2022-09-05 11:02:51 +02:00
simon lehericey	8c884b4869	fix(migration): fix avis email notification migration	2022-09-02 17:23:04 +02:00
Kara Diaby	f8d4644f73	models	2022-09-02 16:23:27 +02:00
Martin	5f2b290407	feat(Procedure.clone): reset subject.duree_conservation_dossiers_dans_ds when procedure.duree_conservation_etendue_par_ds was extended. only extends it on demand otherwise admin could clone old procedure with higher duree_conservation_dossiers_dans_ds	2022-08-31 14:56:00 +02:00
Martin	6e31decc2d	feat(Procedure.clone): stop cloning procedure service which is confusing for some administrateurs	2022-08-31 14:56:00 +02:00
Colin Darie	4ece7c2494	fix(champ): remove null byte before save ... Les null bytes peuvent être injectés lors de c/c depuis certains documents, et ne sont pas sauvegardables en base, rendant la sauvegarde d'un dossier impossible. Closes #7656 https://sentry.io/organizations/demarches-simplifiees/issues/3194932607/activity/?project=1429550&query=is%3Aunresolved	2022-08-31 11:39:34 +02:00
Christian	63a4a13323	Graphql: Fix champs sort in repetition	2022-08-31 11:15:28 +02:00
Martin	2f5528398f	feat(manager#outdated_procedure): allow super admin to enable procedure_expires_when_termine_enabled for old procedure ... revew(typo): various typo, tx christophe :-) fix(spec): due to typo fixes	2022-08-24 13:10:48 +02:00
Martin	dc524cf615	fix(spec): broken spec due to TDD and refacto on former code	2022-08-23 13:28:10 +02:00
Martin	711b2ee2e4	feat(ExportComponent): only render it when connected instructeur/administrateur is not from manager	2022-08-23 13:28:10 +02:00
Martin	d1297bc1f5	tech(rubocopify): ... just clean up ...	2022-08-23 13:28:10 +02:00
Martin	c2e0994e11	feat(Administrateur::ArchivesController#*): prevent SuperAdmin to index/download archives	2022-08-23 13:28:10 +02:00
Martin	ef67958324	feat(manager): add #add_administrateur_with_confirmation and #confirm_add_administrateur so SuperAdmin requires another SuperAdmin approval to add an administrator to a procedure. Add #add_administrateur_and_instructeur for SuperAdmin willing to be administrateur/instructeur for 24	2022-08-23 13:28:10 +02:00
Martin	f0a4cbb61e	feat(assign_tos): add manager column to assign_tos table. Same idea as administrateur_procedures.manager which flag a link between procedure/administrateur coming from a SuperAdmin [target: able to avoid SuperAdmin sec issues]	2022-08-23 13:28:10 +02:00
simon lehericey	650c36e3e2	feat(conditional): add not eq operator	2022-08-10 11:59:09 +02:00
simon lehericey	898badb579	a champ is mandatory when visible with a mandatory tdc	2022-08-09 10:25:47 +02:00
Paul Chavard	a24885c2ee	feat(champ): can condition on other option	2022-08-04 15:28:54 +02:00
Paul Chavard	bbca7344e5	fix(conditional): mandatory champs inside hidden repetition should not be validated	2022-08-04 14:48:40 +02:00
Colin Darie	adced0f33a	fix(revision): fix stable siblings order when there are multiple identical position ... Ça arrive parfois dans les tests, et potentiellement en prod : après avoir créé un nouveau `revision_type_de_champ`, on se retrouve très momentanément avec 2 RTDC ayant le même position en attendant le renumérotation peu près. https://github.com/betagouv/demarches-simplifiees.fr/blob/main/app/models/procedure_revision.rb#L55 Ceci conduisait à une renumérotation erronnée quand la db renvoyait le nouveau RTDC créé *avant* les précédents.	2022-08-03 18:29:48 +02:00
Colin Darie	8dc966feb4	fix(dossier_transfer): requires an actual email ... Closes #7621	2022-08-03 11:44:54 +02:00
Paul Chavard	435a635b3d	fix(procedure_presentation): find last instance of type_de_champ through coordinates	2022-08-02 15:24:52 +02:00
Paul Chavard	48a4e8bec5	chore(db): remove already dropped ignored columns	2022-08-02 15:24:52 +02:00
Paul Chavard	782af3322a	fix(patron): when rendering “patron” champs should have dossier	2022-07-28 12:10:32 +02:00
Colin Darie	197fa54ea4	fix(archives): purge stuck pending archives ... Cf 0cb096b3d6440a4da05ca2902ed6fa72a93e6579	2022-07-27 15:26:59 +02:00
Colin Darie	f1957e51f8	fix(exports): purge stuck (pending) exports, not generated or failed ... Avec l'autre PR, ça reproduit le comportement d'avant, c'est à dire que quoiqu'il arrive un export est purgé : - soit 16h après sa génération (on a 16h pour le télécharger) - soit 12h après sa création, et qu'il est bloqué Auparavant, tous les exports étaient purgés au bout de 3h quelle que soit le statut.	2022-07-27 15:26:59 +02:00
Colin Darie	67d2cb2061	chore(schema): add exports#job_status ... Same behavior as Archive On destroy tous les exports existants qui n'ont pas cette notion de status.	2022-07-26 17:53:24 +02:00
Colin Darie	6845b2ed08	fix(export): fix PurgeStaledExportsJob regression with stale scope ... cc #7547	2022-07-26 14:26:22 +02:00
Colin Darie	11cd73b4ac	feat(export/csv): list etablisement entreprise_etat_administratif	2022-07-25 10:58:02 +02:00
Colin Darie	f05e9331a7	chore(entreprises): save etat_administratif from API	2022-07-25 10:58:02 +02:00
Colin Darie	e1d3d1f844	chore(schema): add entreprise_etat_administratif to etablissements	2022-07-25 10:58:02 +02:00
Martin	3e56fdd1d7	fix(export): when it takes more than 3 hours, exports are purge before being generated. make it possible to have an export that takes more than 3 hours and share this behaviour with kind of same class archive	2022-07-25 10:48:54 +02:00
simon lehericey	0d3856e84a	fix(conditional): handle incorrect user input	2022-07-22 15:55:43 +02:00
Paul Chavard	d9eea35ae8	fix(dossier): decoralate dropdown behaviour from autosave	2022-07-21 18:40:16 +02:00
Paul Chavard	3e40b6d7bc	fix(graphql): handle annotations inside blocks	2022-07-21 14:54:14 +02:00
Paul Chavard	902dc678de	perf(graphql): improuve dossier loading	2022-07-21 12:29:08 +02:00
Paul Chavard	042703cead	refactor(dossier): extract dossier preloader	2022-07-21 12:29:08 +02:00
simon lehericey	821fd2394b	small refactor	2022-07-20 15:48:16 +02:00
simon lehericey	72583f846b	champ value return nil if champ is hidden	2022-07-20 11:23:57 +02:00
Paul Chavard	e85fe71887	fix(champ): allow to submit when secondary options are empty	2022-07-20 10:49:07 +02:00
simon lehericey	2d26ba3507	fix: binary operator computes false by default	2022-07-19 10:11:24 +02:00
Martin	05b6b462b6	feat(new_max_duree_conservation): make it configurable for other instances	2022-07-18 14:08:53 +02:00
Martin	24c8dc5829	feat(procedure.duree_conservation_dossiers_dans_ds): decrease max duree_conservation_dossiers_dans_ds from 36 to 12	2022-07-18 14:08:53 +02:00
Paul Chavard	98a0bc8c71	refactor(condition): use dom_id with stable_id	2022-07-13 15:38:43 +02:00
Paul Chavard	0adfd92213	refactor(condition): use standard revision change ops	2022-07-13 15:32:25 +02:00
simon lehericey	2cad0e11d3	display condition change between version	2022-07-13 15:10:23 +02:00
Paul Chavard	0f9d8b6a39	feat(dossier): exclude conditionally invisible fields from mandatory check	2022-07-12 17:33:42 +02:00
Paul Chavard	120b593015	feat(dossier): toggle conditional champs visibility	2022-07-12 17:33:42 +02:00
simon lehericey	6f7fb9841c	fix: make edition annotation work again	2022-07-12 14:17:05 +02:00
Colin Darie	d805114a72	Revert "feat(revision): list updated placeholder option for generic type de champ" ... This reverts commit fe0282e904. Continue 2bd33ada45b036f73f3fc78150621092e0667693	2022-07-12 11:37:58 +02:00
Colin Darie	8c08d0295b	Revert "feat(champ): customizable placeholders for text & textarea champs" ... This reverts commit 9e26ee932e. Finalement les champs génériques ne doivent pas avoir de placeholder personnalisable, ce sera uniquement via la description.	2022-07-12 11:37:58 +02:00
simon lehericey	c4c0c275e1	fix: coordinate_and_tdc return nil if not found	2022-07-12 10:44:40 +02:00
simon lehericey	faa2797d80	fix: champ_value for tdc destroyed	2022-07-12 10:44:40 +02:00
simon lehericey	2fee0ddfd4	feature: type_de_champ_controller	2022-07-12 10:44:40 +02:00
simon lehericey	256d4e4fda	refactor: reorder -> renumber	2022-07-12 10:44:40 +02:00
simon lehericey	64d82798a6	fix create_tdc after_stable_id	2022-07-12 10:16:22 +02:00
Colin Darie	fe0282e904	feat(revision): list updated placeholder option for generic type de champ	2022-07-11 17:16:20 +02:00
Colin Darie	9e26ee932e	feat(champ): customizable placeholders for text & textarea champs ... Closes #7429	2022-07-11 17:16:20 +02:00
Martin	4c0aac8e0c	fix(linked_dropdown/dropdown): for dropdown_list, drop blank option because rails add it when the field is required. kind of same behaviour for linked_dropdown_list [but requires to manage it on the front too]	2022-07-11 14:47:26 +02:00
Martin	8eceee54ff	fix(targeted_user_link): on invitation user are not always already created	2022-07-11 14:37:01 +02:00
Paul Chavard	4d48055158	feat(tags): expose used_type_de_champ_tags	2022-07-07 23:23:17 +02:00
simon lehericey	61839ef1ac	add logic condition_split	2022-07-06 20:27:14 +02:00
Christophe Robillard	e2348aa8f1	rename publiques scope to opendata	2022-07-06 17:59:03 +02:00
Christophe Robillard	b56706b6b8	add scope publiques for procedures	2022-07-06 17:59:03 +02:00
Paul Chavard	fb37f8c5a8	fix(dossier): fix some reset draft changes edge cases	2022-07-06 16:52:12 +02:00
simon lehericey	42488419b5	add condition form model	2022-07-06 16:35:23 +02:00
Paul Chavard	9b45dcea3f	feat(demarche): add possibility to reset draft revision	2022-07-06 14:18:01 +02:00
simon lehericey	b715d1f495	Revert "Add id to term" ... This reverts commit 87385d03fd.	2022-07-06 09:44:54 +02:00
simon lehericey	350d32c369	in serialization rename op to term	2022-07-05 14:47:49 +02:00
simon lehericey	87385d03fd	Add id to term	2022-07-05 14:47:49 +02:00
simon lehericey	d8454d9d47	remove text from managed_type_de_champ	2022-07-05 12:07:06 +02:00
simon lehericey	c631c5cd82	Logic add_empty_condition_to	2022-07-05 12:07:06 +02:00
simon lehericey	df7acf70c8	and empty_operator compute always true	2022-07-05 12:07:06 +02:00
simon lehericey	6e8206b8b4	add unmanaged champ value type	2022-07-05 12:07:06 +02:00
simon lehericey	144b522773	empty operator is no longer an error	2022-07-05 12:07:06 +02:00
simon lehericey	976e760045	empty has nil value	2022-07-05 12:07:06 +02:00
simon lehericey	04965ac35a	improve constant and empty to_s	2022-07-05 12:07:06 +02:00
simon lehericey	dda5bc35ed	extract champ value type	2022-07-05 12:07:06 +02:00
simon lehericey	809319f593	exposed champ value managed tdc	2022-07-05 12:07:06 +02:00
simon lehericey	5ebaf59fdb	parent_id -> parent_stable_id	2022-07-05 11:53:18 +02:00
simon lehericey	1342356651	after_id -> after_stable_id	2022-07-05 11:53:18 +02:00
Paul Chavard	9a6a8411d3	feat(export): add déparctement info to commune champ export	2022-07-04 16:30:16 +02:00
simon lehericey	f8c7003192	fix drop down other	2022-07-01 16:05:31 +02:00
Martin	54cc9de51e	feat(dubious): add RIB & IBAN and fix NRIPP istead of NIRPP	2022-06-29 17:07:00 +02:00
Martin	4ec61e58ac	feat(EditComponent): add max_file_size and content_types to upload buttons inspired by dsfr	2022-06-28 17:44:35 +02:00
Martin	ea71908850	fix(ChampEditor): add missing drop_down_other for type_de_champ.drop_down_list_with_other?	2022-06-27 17:19:10 +02:00
Christophe Robillard	6dd27ec7ed	reset opendata to true when procedure is cloned by another admin	2022-06-23 14:11:09 +02:00
Christophe Robillard	ea59f5f260	add opendata boolean attribute for procedure ... when opendata is set to true, it means that descriptive's procedure can be public when opendata is set to false, ti means that descriptive's can not be public, because the procedure is only available for public servants, not citizens.	2022-06-23 14:11:09 +02:00
Martin	ab4d4c83a8	feat(GroupeInstructeurs.closed): add closed option to GroupeInstructeur in order to prevent usagers to submit dossier	2022-06-20 16:32:06 +02:00
Martin	274b5eab2e	feat(invite): wrap invitation with targeted_user_links	2022-06-17 16:44:37 +02:00
simon lehericey	9596dac508	force resync types_de_champ and types_de_champ_public/private	2022-06-17 14:54:21 +02:00
simon lehericey	0db27b8718	validate conditions on revision	2022-06-17 14:54:21 +02:00
simon lehericey	758933f6f9	tdc can have condition	2022-06-17 14:53:28 +02:00
simon lehericey	9f49e8c2ea	add ensure_compatibility_from_left	2022-06-17 14:53:27 +02:00
simon lehericey	5ac3049033	add champ_value for dropdown	2022-06-17 14:53:27 +02:00
simon lehericey	809d991819	add champ_value	2022-06-17 14:53:27 +02:00
simon lehericey	daaa54b6f0	add n_ary operators	2022-06-17 14:53:27 +02:00
simon lehericey	698eff0a50	add equal operator	2022-06-17 14:53:27 +02:00
simon lehericey	ebe95b83fa	add compatibility checks	2022-06-17 14:53:27 +02:00
simon lehericey	a98a6d6d1e	add binary operators	2022-06-17 14:53:27 +02:00
simon lehericey	6ebfc505c4	add empty	2022-06-17 14:53:27 +02:00
simon lehericey	58da4805fa	add constant	2022-06-17 14:53:27 +02:00
Paul Chavard	350ed3a11a	feat(graphql): expose revision on demarche descriptor type	2022-06-17 12:33:35 +02:00
Paul Chavard	bbc44fe339	fix(export): no crash on empty repetitions	2022-06-17 11:33:48 +02:00
Paul Chavard	6801b04b7b	feat(type_de_champ): type_de_champ editor in stimulus/turbo	2022-06-17 11:04:09 +02:00
Paul Chavard	1573d20ee9	types_de_champ controller to use turbo	2022-06-17 11:04:09 +02:00
Paul Chavard	65bd996f2a	refactor(types_de_champ_editor): remove old react editor	2022-06-17 11:04:09 +02:00
Paul Chavard	564daeffe8	perf(dossier): improuve dossier preloading perf	2022-06-14 09:04:26 +01:00
Martin	56f7133799	fix(procedure_presentation): can not present a 'virtual field' like depose_since ... fix(data): add migration to remove fields depose_since from existing procedure presentation	2022-06-14 09:02:37 +02:00
Kara Diaby	d58ecb3fcc	Lors de la restauration d'une démarche supprimée, met sur les dossiers liés hidden_by_administration_at à nil	2022-06-10 12:33:47 +02:00
Paul Chavard	95a1ea1047	feat(procedure_presentation): add since date filters	2022-06-09 13:01:22 +01:00
Kara Diaby	d2bd2ffcbe	controller	2022-06-08 14:38:17 +02:00
Kara Diaby	60eed4ec01	model	2022-06-02 15:48:11 +02:00
Martin	d39b3b09ed	fix(webhook.perform): ensure to enqueue job with current state/updated_at for consistency reason	2022-06-01 15:54:55 +02:00
Paul Chavard	462b2618a4	feat(procedure): move new children to new parent in transaction	2022-06-01 09:33:39 +02:00
Martin	cb890343ff	feat(targeted_user_link): add targeted user link to wrap expert invitation in order to avoid access issue when the expert is connected with another account ... feat(user.merge): ensure to merge user.targeted_user_link Update app/models/targeted_user_link.rb Co-authored-by: LeSim <mail@simon.lehericey.net> Update app/models/targeted_user_link.rb Co-authored-by: LeSim <mail@simon.lehericey.net> Update app/models/targeted_user_link.rb Co-authored-by: LeSim <mail@simon.lehericey.net> feat(db/create_targeted_user_links): ensure not null with fk	2022-05-31 14:50:31 +02:00
Paul Chavard	c0a253078c	fix(revision): fix clone démarches with repetitions	2022-05-31 13:28:56 +02:00
Paul Chavard	a36672239d	refactor(revision): rename find_or_clone_type_de_champ	2022-05-31 08:58:53 +02:00
Paul Chavard	6f98def288	refactor(revision): remove old code	2022-05-31 08:58:53 +02:00
Kara Diaby	36aff57f24	model	2022-05-26 12:45:05 +02:00
Christophe Robillard	fd98247b48	[manager] add list of dubious procedures	2022-05-25 14:44:53 +02:00
Pierre de La Morinerie	8936461d5b	app: cache the duration estimate for published procedures	2022-05-25 10:39:18 +02:00
Pierre de La Morinerie	3e91a16895	app: display estimated fill duration on procedure description	2022-05-25 10:39:15 +02:00
Pierre de La Morinerie	3b57d98692	model: add estimated_fill_duration to type_de_champ	2022-05-25 10:37:59 +02:00
Pierre de La Morinerie	4fcb85fd65	app: remove procedure_dossier_papertrail feature flag ... The feature is now enabled for all procedures.	2022-05-24 17:32:11 +02:00
simon lehericey	8ce080bd3e	updated_at pb	2022-05-24 15:38:50 +02:00
simon lehericey	db5d291acd	complete spec and alternative implem	2022-05-24 15:38:50 +02:00
simon lehericey	abc3681053	delegate stable_id to tdc	2022-05-24 15:38:50 +02:00
simon lehericey	e7078279b8	rename published to target to be coherent	2022-05-24 15:38:50 +02:00
simon lehericey	75ec99e709	comments	2022-05-24 15:38:50 +02:00
Paul Chavard	0817731d6a	refactor(dossier): rebase to use new revisions	2022-05-24 15:38:50 +02:00
Martin	51f0be1034	clean(deadcode): remove dead methods	2022-05-24 14:23:40 +02:00
Martin	0eccb08f8b	fix(root): do not forget to move claimant_id when merging instructeur	2022-05-24 14:23:40 +02:00
Paul Chavard	b635952b2f	refactor(revision): types_de_champ for export	2022-05-23 18:36:18 +02:00
Paul Chavard	50aa50b047	refactor(type_de_champ): use children_of when serializing type_de_champ	2022-05-23 18:22:42 +02:00
Paul Chavard	ee50b8ad25	refactor(graphql): fix types_de_champ usage	2022-05-23 18:03:55 +02:00
Paul Chavard	a6cf311f56	Revert "if is not only in draft, its gonna be cloned anyway" ... This reverts commit 71e9240a7d.	2022-05-18 22:53:39 +02:00
simon lehericey	74653631c3	few comments	2022-05-18 22:23:31 +02:00
simon lehericey	71e9240a7d	if is not only in draft, its gonna be cloned anyway	2022-05-18 22:23:31 +02:00
simon lehericey	20288fbb7d	revise_type_de_champ -> replace_tdcs_and_children_by_clones	2022-05-18 22:15:22 +02:00
simon lehericey	e7524b3f0d	extract var	2022-05-18 21:59:31 +02:00
Paul Chavard	0e335f58ac	fix(revision): update children coordinate instead of duplicating	2022-05-18 19:39:20 +02:00
Pierre de La Morinerie	49410ff5f7	models: update database comments	2022-05-18 15:39:33 +02:00
simon lehericey	419d853d1d	add target_revision on rebase	2022-05-18 15:18:17 +02:00
simon lehericey	8bd3de2050	remove use of repetition.types_de_champ (except rebase)	2022-05-18 15:18:17 +02:00
simon lehericey	1921661fad	simplify children_of	2022-05-18 12:30:58 +02:00
simon lehericey	633f0d1ce5	remove_repetition	2022-05-18 12:12:25 +02:00
simon lehericey	4d97f6aa8c	types_de_champ_for_revision	2022-05-18 11:40:34 +02:00
Paul Chavard	6c2a3bafa4	refactor(dossier): champs order by coordinate	2022-05-18 11:20:50 +02:00
simon lehericey	be33c0ce7b	extract coordinate_and_tdc	2022-05-18 10:11:31 +02:00
simon lehericey	7f23449f24	remove set_position	2022-05-18 10:11:31 +02:00
Paul Chavard	0dfc015690	feat(dossiers): bring back export all dossiers	2022-05-17 18:34:00 +02:00
Paul Chavard	b6ea44f7e7	refactor(revision): remove type_de_champ#revision_id	2022-05-17 11:31:49 +02:00
Pierre de La Morinerie	0063b68689	mailers: add deposit receipt to initiated_mail ... See #6146	2022-05-17 10:25:13 +02:00
Paul Chavard	8d9929aa9f	fix(revision): (re)move child type de champ should clone parent for now	2022-05-13 17:17:24 +02:00
Paul Chavard	85c20784a2	refactor(revision): delete unused code	2022-05-13 17:17:23 +02:00
Paul Chavard	d7678c4389	Revert "Merge pull request #7295 from tchak/rollback-attempt" ... This reverts commit 24b37c230d, reversing changes made to 08b90b9173.	2022-05-13 17:17:23 +02:00
Kara Diaby	e99bd5f558	models	2022-05-13 10:31:51 +02:00
Paul Chavard	6adb3f7a3a	fix(revision): fix migrate_parent!	2022-05-12 10:40:41 +02:00
Paul Chavard	edf0cbf320	bring back find_type_de_champ_by_stable_id old implementation	2022-05-11 20:29:01 +02:00
Paul Chavard	4c26e34c79	Revert "Merge pull request #7270 from betagouv/remove_type_de_champ_v2" ... This reverts commit 41b6f8f51b, reversing changes made to 79d5946ab6.	2022-05-11 20:03:42 +02:00
Paul Chavard	08caa122dd	Revert "Merge pull request #7280 from betagouv/move_type_de_champ_v2" ... This reverts commit 08b90b9173, reversing changes made to bc9a90bd08.	2022-05-11 20:03:33 +02:00
simon lehericey	5d6dd853d4	refactor reorder: add order_place only in children	2022-05-11 16:54:26 +02:00
simon lehericey	df91fd1180	move_type_de_champ new style	2022-05-11 16:54:26 +02:00
simon lehericey	b6c2aa30f4	reorder the siblings after deletion	2022-05-11 15:59:17 +02:00
simon lehericey	5dd8bbe797	fix remove type de champ	2022-05-11 15:59:17 +02:00
Kara Diaby	d187b7e881	model	2022-05-10 16:16:16 +02:00
Martin	bf277d4802	bug(export): expect dossiers_for_export not to include dossiers brouillon ... fix(export.dossiers_for_export): add missing visible_by_administration	2022-05-10 16:09:12 +02:00
simon lehericey	d2509e7492	add procedure_revision children_of	2022-05-10 14:52:57 +02:00
Martin	75da4d8c8d	Revert "migration(fix.data): when a repetable revision_types_de_champ points to a non active revision type de champs, relink it to the actuel revision_type_de_champs pointing to the stable id of its parent.type_de_champ.stable_id" ... This reverts commit 19360e7aac.	2022-05-09 18:45:35 +02:00
Martin	19360e7aac	migration(fix.data): when a repetable revision_types_de_champ points to a non active revision type de champs, relink it to the actuel revision_type_de_champs pointing to the stable id of its parent.type_de_champ.stable_id	2022-05-09 18:01:02 +02:00
simon lehericey	4ec5b418cb	fix create_new_revision	2022-05-06 12:37:59 +02:00
Paul Chavard	842506f993	refactor(revision): rename revision methods params to reflect usage of stable_id	2022-05-06 11:08:58 +02:00
Paul Chavard	98814c3812	refactor(revision): test for type_de_champ having a unique revision	2022-05-06 11:08:51 +02:00
simon lehericey	ce0a592f3c	simplify find_type_de_champ_by_id	2022-05-06 10:34:40 +02:00
Martin	ba7a316f5e	fix(Dossier.for_export): instead of iterating champs to build an hash {stable_id: values} ; we iterate on the list of all type de champs, so when there is a type de champ with mutliple values for export, we build the column with the nil value	2022-05-06 09:38:45 +02:00
Martin	3737311390	feat(procedure.procedure_expires_when_termine_enabled): enable by default, allow contributor to choose the default settings of this flag using an env var during migration. ie: DEFAULT_PROCEDURE_EXPIRES_WHEN_TERMINE_ENABLED=true|false ... feat(administrateurs/procedures#show): warning/alert when procedure_expires_when_termine_enabled is not true on current procedure feat(administrateur/procedure#update): after an update redirect to procedure show: suggested by: https://ux.stackexchange.com/questions/55291/after-updating-form-should-redirect-back-to-form-itself-or-to-the-show-page-or-b and confirmed by Olivier clean(Flipper.archive_zip_globale): no more in use, so remove all occurences Update app/views/administrateurs/procedures/_suggest_expires_when_termine.html.haml Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com> Update app/views/administrateurs/procedures/_suggest_expires_when_termine.html.haml Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com> Update app/views/administrateurs/procedures/_suggest_expires_when_termine.html.haml Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com> Update spec/views/administrateurs/procedures/show.html.haml_spec.rb Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com> fix(review): typo, why ena?, who knows fix(env.example.optional): add missing DEFAULT_PROCEDURE_EXPIRES_WHEN_TERMINE_ENABLED	2022-05-05 13:07:11 +02:00
Paul Chavard	4523c0590c	fix(dossier): champs repetable in champs private	2022-05-04 15:57:25 +02:00
Martin	636f887698	fix(user.merge): when merging old_user having an instructeur with dossier_operation_logs containing the old_user.instructeur_id, should be able to merge to new instructeur ... feat(user.merge): when user have an instructeur having dossier_opertions_logs containing instructeur_id	2022-05-04 14:24:11 +02:00
simon lehericey	1ef8d99e6e	simplify a bit more	2022-05-04 13:16:12 +02:00
simon lehericey	37e01ea399	re introduce revision_types_de_champ	2022-05-04 13:16:12 +02:00
Paul Chavard	2d1370d123	refactor(champ): simplify repetition champ	2022-05-03 16:14:54 +02:00
Paul Chavard	b94bc8fd8a	refactor(dossier): use champ id as champ attributes key	2022-05-03 16:14:54 +02:00
simon lehericey	a2947751e2	add scope to query old admins	2022-05-03 12:14:02 +02:00
simon lehericey	ea361643be	types_de_champ -> types_de_champs_public	2022-05-03 11:05:24 +02:00
Paul Chavard	1e928a277d	chore(devise): drop unmaintained dependencie	2022-04-28 12:28:33 +02:00
Paul Chavard	68ca9efba0	feat(dossier): use persisted dossier for preview	2022-04-28 12:20:41 +02:00
Paul Chavard	27f9a820cc	feat(dossier): add preview flag	2022-04-28 11:52:38 +02:00
Martin	3c0e3f725d	feat(administrateur/procedures#publication): show dubious to administrateur ... Update app/views/administrateurs/procedures/publication.html.haml Co-authored-by: Paul Chavard <paul.chavard@beta.gouv.fr>	2022-04-27 15:13:22 +02:00
Martin	be090a1bec	feat(administrateur/procedure#create): allow admin to add a lien to the DPO, allow user to consult link to dpo. enhance spec on _procedure_footer.html ... Update spec/views/users/_procedure_footer.html.haml_spec.rb Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com>	2022-04-27 15:09:02 +02:00
Paul Chavard	91879b89ce	fix(commentaire): unified destroy commentaire	2022-04-26 14:54:58 +02:00
simon lehericey	fe6f211cc9	ignore instructeur_id in dol	2022-04-25 14:07:23 +02:00
Paul Chavard	23b60c87e9	fix(procedure): cloned procedure should not have auto_archive_on ... fix #7149	2022-04-22 10:48:31 +02:00
Paul Chavard	4624fa141f	fix(turbo): use a safer render method	2022-04-21 19:41:27 +02:00
simon lehericey	9fd5219751	fix sort in procedure presentation	2022-04-15 12:21:39 +02:00
Paul Chavard	22f23c58c7	fix(dossiers): fix columns order	2022-04-14 17:04:42 +02:00
simon lehericey	23707d6033	ignore file not found error when cloning procedure	2022-04-14 13:46:16 +02:00
Paul Chavard	c671f25d34	fix(dossier): do not show unwanted closed procedure banners	2022-04-14 12:22:37 +02:00
Paul Chavard	83a8d87e95	i18n(procedure_presentation): translate fields	2022-04-14 11:38:01 +02:00
Paul Chavard	433c01b1e6	Revert "Merge pull request #7137 from betagouv/faster_pdf" ... This reverts commit 9da44bd913, reversing changes made to ebac71796c.	2022-04-12 19:22:07 +02:00
Paul Chavard	caace89d98	refactor(export): use predefined helpers	2022-04-12 14:54:54 +02:00
Paul Chavard	d14e132305	feat(export): add zip format support	2022-04-12 14:54:54 +02:00
Paul Chavard	2832ea0286	refactor(export): return blob from to_* methods	2022-04-12 14:54:54 +02:00
Paul Chavard	a194616772	refactor(export): remove unnecessary to_sym	2022-04-12 14:54:54 +02:00
simon lehericey	53de567b59	revert fix(user.merge) : waiting for ignore column instructeur_id in ruby code	2022-04-12 14:02:20 +02:00
simon lehericey	ba688a477a	small refactor	2022-04-12 11:56:56 +02:00
Martin	e83f5fe475	fix(user.merge): when merging old_user having an instructeur with dossier_operation_logs containing the old_user.instructeur_id, should be able to merge to new instructeur ... feat(user.merge): when user have an instructeur having dossier_opertions_logs containing instructeur_id	2022-04-12 11:28:33 +02:00
Paul Chavard	90dd5bc9c5	fix(dossiers): dossier extend_conservation actually works	2022-04-08 13:40:28 +02:00
Paul Chavard	23e2429d0d	fix(export): make count argument optional	2022-04-06 17:08:38 +02:00
Paul Chavard	9904dabffe	feat(procedure_presentation): pass filters as serialized snapshot	2022-04-06 17:08:38 +02:00
Paul Chavard	e82dc9c8b5	feat(exports): add ability to create exports with filters	2022-04-06 17:08:38 +02:00
Paul Chavard	be1a2f916d	feat(exports): add statut and procedure_presentation to exports	2022-04-06 17:08:38 +02:00
Paul Chavard	ec3ed049ef	refactor(procedure_presentation): expose filtered_sorted_ids method	2022-04-05 15:50:53 +02:00
Martin	4890530428	fix(Dossier.processed_in_month): recast date to datetime in scope	2022-04-05 13:54:36 +02:00
Martin	9484c4cdf4	fix(Dossier.processed_in_month): using PG between operator with a date does not play nicely when it is compared to DateTime in postgres. meaning given a Date as 2022/03/31, when compared with a DateTime in postgres, the casting of 2022/03/31 to Datetime becomes 2022/03/31 00:00. So we skiped all dossiers from last date in month	2022-04-05 13:54:36 +02:00
Martin	c1884f231c	Revert "Merge pull request #7105 from betagouv/US/fix-dossier.processed_in_month" ... This reverts commit a0e144b9a7, reversing changes made to 49848bd150.	2022-04-05 13:39:37 +02:00
Martin	d6d9db9721	tech(Sorbet): prepare usage of sorbet to avoid defensive programming style [casting date to datetime]	2022-04-05 12:14:07 +02:00
Martin	ec78340c06	fix(Dossier.processed_in_month): recast date to datetime in scope	2022-04-05 12:14:07 +02:00
Martin	ab777a790c	fix(Dossier.processed_in_month): using PG between operator with a date does not play nicely when it is compared to DateTime in postgres. meaning given a Date as 2022/03/31, when compared with a DateTime in postgres, the casting of 2022/03/31 to Datetime becomes 2022/03/31 00:00. So we skiped all dossiers from last date in month	2022-04-05 12:14:07 +02:00
Paul Chavard	0daae815d8	refactor(dossier): use by_statut	2022-04-05 09:42:23 +02:00
Paul Chavard	6da54936b7	refactor(procedure_presentation): use internal reference to instructeur	2022-04-05 09:42:23 +02:00
Paul Chavard	706c648be8	refactor(procedure): remove unused code	2022-04-05 09:42:23 +02:00
simon lehericey	57f9e5bac3	always allow dossier pjs download (-9 queries)	2022-04-04 17:26:49 +02:00
Martin	ad4e5a8bc6	fix(instructeurs/procedures#index): counter not in sync	2022-04-04 16:28:25 +02:00
Kara Diaby	e06215281a	modify commentaire model	2022-03-31 15:48:17 +02:00
Martin	dbcf21a555	feat(archive): extract archive status management within job to simplify the main service as well as to isolate this part for a merge with exports csv/xslx [maybe?] ... Update app/dashboards/archive_dashboard.rb Co-authored-by: LeSim <mail@simon.lehericey.net>	2022-03-31 13:35:49 +02:00
Paul Chavard	6df18e1234	fix(dossier): only expire dossiers visible by user or administration	2022-03-31 12:17:24 +02:00
Paul Chavard	a171ebb772	fix(dossiers): exclude deleted dossiers from notifications	2022-03-31 12:17:24 +02:00
Martin	7ec1021e00	feat(Archive.prepare_broader_reach): activate by default the archive button in the export dropdown. add a call to action to contact our support to enable the feature. increase estimated file size limit up to 100.gigabytes	2022-03-30 16:21:07 +02:00
Pierre de La Morinerie	017625207e	db: add constraints to role tables	2022-03-29 14:52:38 +02:00
Kara Diaby	217793c5c8	modify model	2022-03-29 12:30:52 +02:00
Pierre de La Morinerie	9dcd92a678	db: add not-null constraints to AdministrateursInstructeur	2022-03-22 13:32:02 +01:00
Pierre de La Morinerie	fbe0410702	models: fix a typo in a ProcedurePresentation's comment	2022-03-22 07:58:44 +01:00
Pierre de La Morinerie	6849a73aec	models: ignore deprecated User columns	2022-03-22 07:58:44 +01:00
Pierre de La Morinerie	31bd05f835	models: inverse the direction of the User role associations	2022-03-22 07:58:44 +01:00
Pierre de La Morinerie	d4da6502ba	models: remove double-write callback on User	2022-03-22 07:58:44 +01:00
Kara Diaby	8bcdf59778	change commentaire model	2022-03-17 13:57:49 +01:00
Kara Diaby	eda5f75ec3	modify dossier model	2022-03-17 13:57:49 +01:00
Paul Chavard	c530399eac	feat(procedure): display revisions diffs	2022-03-17 10:26:38 +01:00
Martin	5739150f15	feat(service/archive_uploader): add an archive uploader class to upload files thru a custom script which handle file encryption of massive file (bigger than 4Go) ... Update doc/object-storange-and-data-encryption.md Co-authored-by: LeSim <mail@simon.lehericey.net> Update app/services/archive_uploader.rb Co-authored-by: LeSim <mail@simon.lehericey.net> Update doc/object-storange-and-data-encryption.md Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com> clean(doc): align document file name and document h1 clean(review): refactore based on various comments clean(review): refactore based on various comments	2022-03-16 14:56:21 +01:00
Pierre de La Morinerie	ae3e360139	models: double-write to the newly created foreign keys ... This code is only used to handle a live system creating new Administrateurs, Instructeurs or Experts before the migration to the new foreign keys.	2022-03-15 15:57:22 +01:00
Pierre de La Morinerie	48ea53b90d	db: add foreign keys to Administrateur, Instructeur and Expert	2022-03-15 15:15:51 +01:00
Pierre de La Morinerie	be834ba58d	models: reload old_user roles before destroying it ... Otherwise ActiveRecord believes that old_user still has roles (although they have been migrated to the new user), and attempts to delete them.	2022-03-15 15:13:45 +01:00
Pierre de La Morinerie	2cac7d96be	models: fix procedure_revision comments indentation	2022-03-15 15:13:45 +01:00
simon lehericey	44f2d93277	quick fix of sections in preview	2022-03-15 10:54:39 +01:00
Paul Chavard	77c2187747	fix(instructeur): avoid n+1 in instructeur_dossier#show and user_dossier#show	2022-03-15 09:57:54 +01:00
Paul Chavard	0695ea322a	refactor(instructeur): improuve dossiers list view	2022-03-11 14:06:34 +01:00
Paul Chavard	c60a8970f1	perf(dossier): memoize champ.sections on dossier	2022-03-11 00:15:53 +01:00
Paul Chavard	54b559364a	feat(dossier): replace discarded with visible_by_administration	2022-03-10 14:29:40 +01:00
Paul Chavard	59b0f3961d	refactor(dossier): improuve dossiers_count_summary	2022-03-10 14:29:40 +01:00
Pierre de La Morinerie	a645c5781d	models: delete AdministrateursProcedure when destroying Procedure	2022-03-08 09:20:34 +01:00
Pierre de La Morinerie	087e438eb6	models: delete AdministrateursInstructeur when destroying Instructeur ... By default, `has_and_belongs_to_many` properly deletes the record in the join table. However, as the association is declared manually with a `has_many / through`, it doesn't delete the joined record automatically. As we also lack a foreign-key contraint on the join table, that means a dangling record remains in the join table. To fix this, let's declare it a proper `has_and_belongs_to_many` association, which will let the join record be deleted automatically on destroy.	2022-03-02 11:26:53 +01:00
Pierre de La Morinerie	e32c9a9f94	models: don't attempt to format invalid phone numbers ... This is a defensive-programming measure, because formatting an invalid phone number may truncate some leading numbers.	2022-03-02 09:57:03 +00:00
Pierre de La Morinerie	f35d18cd5c	models: stop truncating DROM phone numbers ... Fix #6996	2022-03-02 09:57:03 +00:00
Pierre de La Morinerie	5150e33212	models: ensure DROM phone numbers are valid ... They were accepted before, because they were 'possible' – but now they are explicitely considered as valid.	2022-03-02 09:57:03 +00:00
Pierre de La Morinerie	71e1b6c973	models: delete AdministrateursProcedure when destroying Administrateur ... By default, `has_and_belongs_to_many` properly deletes the record in the join table. However, as the association is declared manually with a `has_many / through`, it doesn't delete the joined record automatically. As we also lack a foreign-key contraint on the join table, that means a dangling record remains in the join table. To fix this, let's declare it a proper `has_and_belongs_to_many` association, which will let the join record be deleted automatically on destroy.	2022-03-01 16:58:04 +01:00
Martin	b808b4db00	fix(relation): avoid double association between procedure/procedure_revision/dossier_submitted_message	2022-02-25 14:01:18 +01:00
Martin	85a588541b	feat(dossier_submitted_message): add a new system to customize the standby page (/merci) after an user created his folder. this is a basic feature that will come with more options asap ... wip(dossier_created_hook): add tile to administrateurs/procedure#show in order to crud dossier_created_hook refactor(css.utilities): remove merge helpers.scss within utils.scss (same purpose). use scss each for spacer modifiers refactor(dossiers/_merci.html): extract partial _merci so we can re-use it in preview of dossier_created_hook. feat(wip): current progress	2022-02-25 14:01:18 +01:00
Paul Chavard	2d396fcfb7	feat(dossier): rebase dossiers en construction and en instruction	2022-02-18 17:08:38 +01:00
Paul Chavard	08030bcdb7	fix(attestation_template): handle attestation changes on procedures without revisions	2022-02-11 11:12:10 +01:00
Paul Chavard	76b1b85fa7	fix(attestation_template): add revision diff support	2022-02-11 08:45:32 +01:00
Paul Chavard	e269077c40	refactor(attestation_template): cleanup relationships	2022-02-11 08:45:32 +01:00
Paul Chavard	88e80e9e32	Merge pull request #6901 from adullact/feature/6859-jwt-token-expiration ... [API Entreprise] Ajout du support des jetons JWT sans clé d'expiration	2022-02-10 11:48:39 +01:00
Kara Diaby	a6b2873bfc	modify instructeur model	2022-02-09 14:43:36 +01:00
Kara Diaby	0ce61f451e	modify dossier model	2022-02-09 14:43:36 +01:00
Paul Chavard	12151acb99	Revert "Revert "feat(attestation): revise attestations"" ... This reverts commit 4e7733e571.	2022-02-08 16:22:59 +01:00
François Vantomme	eba9a87123	refactor(API Entreprise): raise an error on blank token	2022-02-07 15:18:16 +01:00
Pierre de La Morinerie	e6cf07b810	stats: move date formatting out of the Stat model ... Before this commit, the monthly dossiers count was serialized into the Stat record using human-formatted dates, as: ```ruby s.dossiers_in_the_last_4_months = { "octobre 2021"=>409592, "novembre 2021"=>497823, "décembre 2021"=>38170, "janvier 2022"=>0 } ``` Turns out the ordering of keys in a serialized hash is not guaranteed. After a round-trip to the database, the keys will be wrongly sorted. Instead we want to save raw Date objects, which will preserve the ordering. The date formatting can be applied at display-time by the controller. Fix #6848	2022-02-02 14:13:53 +01:00
Pierre de La Morinerie	ca58e60dc0	validators: rename revisions namespace to types_de_champ	2022-02-01 12:37:16 +01:00
Pierre de La Morinerie	d680602c84	models: validate private types_de_champ	2022-02-01 12:37:16 +01:00
Pierre de La Morinerie	e8e37cce15	models: refactor the types_de_champ validators ... Context: we want to validate public and private types_de_champ separately. Before we validated the whole revision (and then validators themselves enumerated all champs, public and private). Now we validate the actual public types_de_champ, which will let us validate separately the private types_de_champ.	2022-02-01 12:37:16 +01:00
Kara Diaby	0f968f4c4e	modify models	2022-01-27 17:01:27 +01:00
Paul Chavard	4e7733e571	Revert "feat(attestation): revise attestations" ... This reverts commit e413872530.	2022-01-25 18:26:34 +01:00
Kara Diaby	2eb35065f8	fix dossier deletion mailers	2022-01-25 11:46:05 +01:00
Kara Diaby	0e3532a0b2	Fixe la liste 'tous' des dossiers instructeurs lorsqu'un dossier est en constructino et caché par l'usager	2022-01-24 16:47:47 +01:00
Paul Chavard	e413872530	feat(attestation): revise attestations	2022-01-19 18:00:37 +01:00
Paul Chavard	c1cb89bb44	fix(revision): changed? conflicts with rails method	2022-01-19 18:00:37 +01:00
Paul Chavard	403e71b41f	feat(procedure): only purge procedures without dossiers	2022-01-18 11:22:04 +01:00
Paul Chavard	7937e58caa	fix(archives): only export dossiers in archive groupe_instructeurs ... fix #6793	2022-01-18 11:16:20 +01:00
Paul Chavard	7e0d471a08	improuve discarded_expired scopes	2022-01-12 15:49:38 +01:00
Kara Diaby	e2caf5718f	modify instructeur model	2022-01-12 15:49:38 +01:00
Kara Diaby	894b065615	modify dossier model	2022-01-12 15:49:37 +01:00
Paul Chavard	fc058f721d	a11y(champs): expose ids for UI on champ	2022-01-05 12:33:40 +01:00
Kara Diaby	1ca553e088	rename hidden_by_instructeur by hidden_by_administration	2022-01-03 11:51:25 +01:00
Paul Chavard	ad4be3c482	refactor(dossier): handle discard by admin and super admin	2022-01-03 11:51:25 +01:00
Kara Diaby	b408811c5a	l'expert ne voit pas les dossiers supprimés par l'instructeur	2022-01-03 11:51:25 +01:00
Kara Diaby	051d7b2028	change dossier method	2021-12-29 17:37:58 +01:00
Kara Diaby	37e991ccb8	User : delete the folder if the instructeur has hide it	2021-12-29 17:37:58 +01:00
Kara Diaby	22ac853815	add hidden_by_instructeur scope	2021-12-29 17:37:58 +01:00
Kara Diaby	cd95b730e0	add hidden_by_instructeur_at on dossiers	2021-12-29 17:37:57 +01:00
Martin	d0ab1711ff	fix(profil_controller#update_email): ensure we are not merging same account ... fix(profil_controller#update_email): changing email from current_user.email to current_user.email destroy current user. whoops ☠️' Update config/locales/en.yml Co-authored-by: Pierre de La Morinerie <pierre.de_la_morinerie@beta.gouv.fr> Update config/locales/fr.yml Co-authored-by: Pierre de La Morinerie <pierre.de_la_morinerie@beta.gouv.fr> Update spec/controllers/users/profil_controller_spec.rb Update config/locales/fr.yml Co-authored-by: Pierre de La Morinerie <pierre.de_la_morinerie@beta.gouv.fr> Update spec/controllers/users/profil_controller_spec.rb fix(spec): broken due to typo	2021-12-29 13:36:47 +01:00
Christophe Robillard	6e36fee7b3	superadmin can display list of procedures without zone	2021-12-23 19:18:46 +01:00
Christophe Robillard	c7b5e57d2a	superadmin can get procedures from zone	2021-12-23 19:07:42 +01:00
Paul Chavard	4e779f445d	fix(instructeur): copy notifications settings from previous groupe instructeur ... fix #6763	2021-12-23 13:55:25 +01:00
François Vantomme	14e0c68266	feat(api particulier): add MESRI field	2021-12-16 16:45:18 +01:00
maatinito	0a31c8bc79	refactor date_trunc queries using groupdate gem	2021-12-14 08:50:11 +01:00
maatinito	573b3d39e2	Fix date_trunc sql queries for timezoned forks	2021-12-14 08:50:09 +01:00
Paul Chavard	c7b1dc7f87	fix(bulk_messages): destroy bulk messages with procedures	2021-12-09 16:16:40 +01:00
Paul Chavard	efd8ddb99e	fix(graphql): do not crash if attestation is nil	2021-12-08 13:12:42 +01:00
François Vantomme	6ab8ac0662	feat (api particulier): add Pole emploi field	2021-12-08 10:36:25 +01:00
Paul Chavard	5615baa985	Revert "Merge pull request #6724 from tchak/fix-approximative_expiration_date" ... This reverts commit c95a67d970, reversing changes made to 032989a400.	2021-12-07 13:32:39 +01:00
Paul Chavard	436569b08c	Revert "Merge pull request #6727 from tchak/fix-approximative_expiration_date-again" ... This reverts commit 951f974478, reversing changes made to c95a67d970.	2021-12-07 13:32:27 +01:00
Paul Chavard	48ee830586	fix(dossier): fix approximative_expiration_date again	2021-12-07 13:02:53 +01:00
Paul Chavard	60d4bcc4f7	fix(dossier): fix approximative_expiration_date	2021-12-07 12:47:27 +01:00
François Vantomme	2110ef072c	feat(api particulier): add DGFiP field	2021-12-07 11:03:05 +01:00
Paul Chavard	5e0f8a5816	task(type_de_champ): migrate type_de_champ parent_id	2021-12-06 21:45:54 +01:00
Paul Chavard	09c37435ad	feat(procedure_revision_types_de_champ): add parent_id	2021-12-06 21:45:54 +01:00
Paul Chavard	0036933425	feat(graphql): add commune and departement information to API	2021-12-06 21:01:28 +01:00
Paul Chavard	fcbe364ac8	feat(commune): display departement information on commune champ	2021-12-06 21:01:28 +01:00
Paul Chavard	2ba05bfb4f	fix(dossier): use depose_at instead of en_construction_at	2021-12-06 15:49:17 +01:00
Martin	081d5094a9	feat(instructeurs/procedure/dossiers#extend_conservation): add extends duree conservation in action button list, also rewire this action for user [extend by procedure.duree_conservation_dans_ds by default] but force 1.month for instructeur. add new icon for standby based on https://en.wikipedia.org/wiki/Power_symbol	2021-12-06 07:20:01 +01:00
Martin	d8a8d1fdab	feat(instructeur/dossier/header/_expiration_banner): split trads and add dedicated expiration banner for instructeur. also enhance wording to include duree conservation + extension_conservation ... feat(expiration_banner): enhance wording of expiration feat(dossiers/expiration_banner): enhance wording regarding expiration to include duree_conservation_dossiers_dans_ds + extension_conservation, also add spec on expiration_banner for instructeur	2021-12-06 07:05:17 +01:00
Martin	1bb868714c	fix(spec/lint/review): lint and fix spec of previous commits, also fix based on tchak feedback	2021-12-06 07:05:17 +01:00
Martin	d87f8b57cc	feat(instructeurs/procedures#show): add dossier experiant in procedure#show	2021-12-06 07:05:17 +01:00
Martin	2dfbc70d41	feat(instructeur#dossiers_count_summary): add counter for expirants. ignore brouillon	2021-12-06 07:05:17 +01:00
Martin	ce87878ff0	refactor(traitement.process_expired): move process expired to procedure	2021-12-03 16:32:36 +01:00
Christophe Robillard	561f6fb274	add belongs_to zone for procedure	2021-12-02 19:23:05 +01:00
Christophe Robillard	219eaf0d5e	add zone model	2021-12-02 19:16:11 +01:00
Pierre de La Morinerie	b7d17b0989	models: validate that no drop-downs are empty on publishing ... Disallow publishing a procedure containing drop-downs with no selectable values.	2021-12-02 09:00:37 +01:00
Pierre de La Morinerie	e219ec33d8	validators: rename no_empty_repetitions to no_empty_repetition	2021-12-02 09:00:37 +01:00
Martin	725521c3a1	fix(expiration_banner): only show expirations info when flip is enabled ... fix(lint): lint haml fix(spec): enable flipper and allow procedure to receive flipper check when checking banner presence fix(doc): add missing documentation on readme regarding system testing with a visual feedback fix(typo): add missing accent clean(PR): feedback from Tchak, better to wrap feature check for expirability by procedure within dossier.expirable? helper	2021-11-30 16:05:32 +01:00
Pierre de La Morinerie	52b0fbf9b7	models: validate repetitions on publishing	2021-11-30 13:34:41 +01:00
Pierre de La Morinerie	48133c2595	models: don't save the procedure before the state transition ... Otherwise a validation error occurs here instead of on save.	2021-11-30 13:34:41 +01:00
simon lehericey	5a0fb6237f	😭 AASM does not support keyword arguments ... https://github.com/aasm/aasm/issues/672	2021-11-30 09:42:45 +01:00
Pierre de La Morinerie	184a401182	app: rename new_administrateur to administrateurs	2021-11-30 08:49:38 +01:00
Martin	cf82c030e8	hotfix(scoping): try to avoid requesting archived: false when using termine scope, use state_termine instead	2021-11-26 15:09:53 +01:00
Martin	970e43efb8	feat(stats#index): update Stat model to also query DossierDeleted in stats computation ... tech(question): discard_and_keep_track! ; are we really keeping track with default_scope { kept } ? feat(stats): add DeletedDossier in Stat computations Revert "tech(question): discard_and_keep_track! ; are we really keeping track with default_scope { kept } ?" This reverts commit d1155b7eeaaf1a9f80189e59667e109541fcb089. feat(stats): support deleted_dossiers for last_four_months_hash and cumulative_hash. extract sanitize query & merge hashes in methdos clean(rubocop): lint with rubocop Update db/migrate/20211126080118_add_index_to_deleted_at_to_deleted_dossiers.rb Co-authored-by: LeSim <mail@simon.lehericey.net> fix(rubocop): avoid uneeded allocation fix(migration): add concurrent index with expected synthax fix(brakeman): add ignore message since group date_trunc evaluation is used by only ourself	2021-11-26 13:29:40 +01:00
kara Diaby	eaac293da3	add a new tab traités on user dossiers	2021-11-26 09:45:13 +01:00
Paul Chavard	d847775c68	feat(traitements): add depose_at to dossiers	2021-11-25 12:57:55 +03:00
Paul Chavard	1f1dd9fce5	fix(traitements): add missing traitements to dossiers when reverting a decision	2021-11-25 12:57:55 +03:00
Pierre de La Morinerie	e5f5440663	models: explicitely save procedure's new revision ... Deep-cloned objects have all their relationships stale. Thus, for a newly deep-cloned revision, `revision.types_de_champs` returns `[]`, even when it actually has associated types de champ. This causes consecutive champs creations and re-ordering to fail in subtle ways, like: ``` procedure.draft_revision.add_type_de_champ(…) procedure.publish_revision! procedure.draft_revision.add_type_de_champ(…) procedure.draft_revision.move_type_de_champ(…) # this will fail ``` As `publish_revision!` created a new stale revision, moving the type de champ fails because not all existing champs are found until the object is refreshed. We don't hit this path in production, because usually only a single operation is made in a request. To fix this, save the new revision before associating it as the draft procedure. (Another option would be to `reload` the revision after creation, but this seems better contained and matches the name of the method.)	2021-11-25 08:49:17 +01:00
mfo	e7d9d047fe	Merge branch 'main' into 6649-etq-usager-instructeur-rendre-la-suppression-plus-visible	2021-11-24 14:07:32 +01:00
Pierre de La Morinerie	60c2718f29	models: remove custom code for file size validation message ... With active_storage_validations 0.9.6, we can use the %{max_size} variable directly in the error message.	2021-11-24 10:06:45 +01:00
Pierre de La Morinerie	2227dcc1e7	app: remove leftovers of procedure path autocomplete ... We used to pre-validate the procedure, to display in advance if the path could be used. Now that the path autocomplete is long gone, we can remove this kludgy code.	2021-11-23 14:30:21 +01:00
simon lehericey	5234a1854c	manage AgentConnect callback	2021-11-23 14:17:59 +01:00
simon lehericey	1926a630f9	add agent_connect_id to instructeur	2021-11-23 14:17:59 +01:00
simon lehericey	898df449d4	redirect to AgentConnect	2021-11-23 14:17:59 +01:00
Martin	b6adf5fc72	feat(dossiers/show): enhance header with expirations message/banner. also ensure consistent design between dossier states ... fix(spec): broken due to last refactoring spec(dossier.extend_conservation): add system spec lint(ruby): still not yet ready for auto lint in IDE...	2021-11-23 05:50:25 +01:00
Martin	a9978fb70b	clean(code): move mfo comment to its rightful place	2021-11-19 14:34:20 +01:00
Martin	608a85148f	feat(Dossier.close_to_expiration): add method to find any kind of dossier close to expiration [reuse previous scopes], add missing spec to termine_close_to_expiration, complement spec for each kind of expiration scope with general close_to_expiration spec	2021-11-19 14:28:54 +01:00
Martin	d8257284ef	tech(refactor): extract states close to expiration within their scope.	2021-11-19 14:07:47 +01:00
Martin	1d721f14a0	fix(spec): get back to stable state	2021-11-19 12:36:03 +01:00
Martin	646459a1da	fix(spec): at least let us start from a green suite	2021-11-18 18:15:57 +01:00
Paul Chavard	df474b60cf	WIP	2021-11-18 18:58:17 +03:00
Paul Chavard	ae09b37e72	fix(champs): save departement info on champ commune	2021-11-17 14:52:47 +03:00
mfo	82b23b92c0	Merge branch 'main' into 6624/etq-instructeur-je-souhaite-supprimer-des-messages-envoyes-par-erreur	2021-11-17 05:41:56 +01:00
Paul Chavard	e74d599042	feat(procedure): remove duree_conservation_dossiers_hors_ds	2021-11-16 19:55:56 +03:00
Paul Chavard	04e67ea20a	fix(dossier): add instructeur email to traitements when available	2021-11-16 19:00:20 +03:00
mfo	1d174df2ec	Merge branch 'main' into 6624/etq-instructeur-je-souhaite-supprimer-des-messages-envoyes-par-erreur	2021-11-16 16:37:15 +01:00
Martin	f0950b592b	clean(CommentaireService): extract soft delete within controller. returning an instance with an error[:base] is not persisted with validation : avoid poluting stuff	2021-11-16 16:13:11 +01:00
Martin	8bbd77f89f	refactor(mail.delay): use simplier implementation using after_action to prevent email delivery with delay	2021-11-16 15:12:05 +01:00
Martin	0aecc301c9	refactor(Commentarie.soft_delete): use discard	2021-11-16 14:28:38 +01:00
simon lehericey	e3c1e19424	include hidden dossier in merge	2021-11-15 23:14:41 +01:00
Martin	ddabed0c7e	fix(refactor): continue to revert to past implementation. now use a job instead of calling deliver_later(wait: 5.minutes) [was not a satisfying implementation]	2021-11-15 15:45:48 +01:00
Martin	5534c3fbd6	fix(refactor): forgot to cleanup former implementation	2021-11-15 15:43:51 +01:00
Martin	5b6bb5171c	tech(lint): rubocopify	2021-11-15 15:42:20 +01:00
Martin	c68fa2d7f3	feat(Commentaire.notify_user): wait 5 minutes before sending email to user when instructor write a commentaire. leaving some space for instructor to destroy his message	2021-11-15 15:38:57 +01:00
Martin	46fc956de3	fix(refactor): forgot to pass var, classy	2021-11-15 15:01:56 +01:00
Martin	a74ca8ad39	fix(spec): scope out time as reference for time comparission, hope not a matter of precision	2021-11-15 14:55:35 +01:00
Martin	9a8ec1087c	feat(commentaire.soft_delete): wrap deletion behaviour in service	2021-11-15 12:43:53 +01:00
Martin	5b72bdec7e	fix(Commentaire.sent_by?): &.email compared to nil could sent by true when nil==nil, avoid this one	2021-11-15 12:01:56 +01:00
Martin	b03dc6ad5d	wip(dossiers/messages/_message): poc destroy button with expected ACL support	2021-11-15 11:30:41 +01:00
Paul Chavard	da47f491b3	fix(dossier): nullify close to expiration notice timestamps when changing state	2021-11-11 12:52:58 +01:00
Paul Chavard	faa235d205	fix(dossier): destroy operation logs when destroying an expired dossier	2021-11-11 09:37:09 +01:00
Paul Chavard	71939c650b	fix(export): remove wrong columns from repetition spreadsheets ... This fix prevent repetition children types de champ from being pulled from cloned procedures. stable_id is stable across revisions but also across cloned procedures.	2021-11-10 20:45:32 +01:00
simon lehericey	17d131b3cc	add has_may requested_merge_from	2021-11-04 16:10:09 +01:00
simon lehericey	b160086cc5	update update_email to allow merge	2021-11-04 16:10:09 +01:00
simon lehericey	6625c6bac3	add requested_merge_into column in user table	2021-11-04 16:10:09 +01:00
Paul Chavard	122cdacbc2	fix(avis): destroy avis for discarded en_construction dossiers	2021-11-04 10:12:44 +01:00
Paul Chavard	f6b8689a97	fix(revisions): fix repetitions export with revisions	2021-11-03 18:20:48 +01:00
Paul Chavard	0e2f09dd6f	fix(dossiers): wrap dossier discard in a transaction ... By doing this we ensure that deleted_dossier are not created when dossier is not discarded	2021-11-02 18:17:35 +01:00
Paul Chavard	da49a6447f	refactor(repetition): optimize and add a transaction around repetition add row	2021-10-28 14:54:33 +02:00
Paul Chavard	c4b93f8d4a	fix(groupe_instructeur): unfollow dossiers when removed from groupe instructeur	2021-10-28 14:45:52 +02:00
simon lehericey	8fe1e2bf71	wrap merge in transaction	2021-10-28 14:39:13 +02:00
simon lehericey	7935e42109	Add merge log	2021-10-28 14:39:13 +02:00
simon lehericey	3328c9a132	merge move invite as well	2021-10-28 14:39:13 +02:00
simon lehericey	f2ccb39912	merge destroys the old role and account	2021-10-28 14:39:13 +02:00
simon lehericey	1401d163ba	add dependent_destroy to user instructeur / admin / expert roles	2021-10-28 14:39:13 +02:00
simon lehericey	c725999582	move merge method to user	2021-10-28 14:39:13 +02:00
Paul Chavard	1393b7b07b	fix(rebase): fix repetition champ rebase	2021-10-28 13:27:53 +02:00
Paul Chavard	7ebc439630	refactor(drop_down_list_champ): other option	2021-10-27 12:01:15 +02:00
Paul Chavard	8154daf847	refactor(drop_down_list_champ): other option	2021-10-27 12:00:39 +02:00
kara Diaby	f1f2b76a3d	revisions	2021-10-27 12:00:39 +02:00
kara Diaby	dc35d9521f	add other option to liste deroulante champ	2021-10-26 16:11:15 +02:00
Paul Chavard	6e8e0c7b6b	feat(type_de_champ): reflect changes of secondary labels and descriptions	2021-10-26 12:18:01 +02:00
Paul Chavard	d308448f02	feat(type_de_champ): add secondary label and description do linked drop downs	2021-10-26 12:18:01 +02:00
Paul Chavard	579dce8eb6	refactor(user): wrap user destruction in a transaction	2021-10-26 11:16:29 +02:00
Paul Chavard	d5d3995dad	fix(dossier): fix dossier.avis cascade	2021-10-26 11:16:29 +02:00
Paul Chavard	4aa573a75d	fix(transfer): remove discarded dossiers from transfers	2021-10-26 10:41:01 +02:00
Paul Chavard	1561ea82f6	fix(transfer): manually nullify staled transfers references	2021-10-21 13:54:26 +02:00
Paul Chavard	2a3a9dd822	feat(revisions): rebase dossiers brouillons	2021-10-20 17:26:09 +02:00
Paul Chavard	09a09d3fcf	feat(revisions): add rebased_at to champs	2021-10-20 17:26:09 +02:00
Paul Chavard	67e98f79c9	feat(revisions): add stable_id to changes	2021-10-20 17:25:34 +02:00
Paul Chavard	1ca8192864	perf(export): load dossiers.champs in batches	2021-10-20 16:52:38 +02:00
simon lehericey	866df74706	merge admin	2021-10-19 16:12:42 +02:00
simon lehericey	19f81b594b	merge with an existing account by using the password	2021-10-14 14:47:50 +02:00
simon lehericey	f6879eba60	associate_user take a target email	2021-10-14 14:47:50 +02:00
simon lehericey	09f828a6a2	create_merge_token!	2021-10-14 14:47:50 +02:00
simon lehericey	34862f41e0	Add fci valid_for_merge	2021-10-14 14:47:50 +02:00
simon lehericey	2e118a8f5b	allow unattached fci	2021-10-14 14:47:50 +02:00
simon lehericey	6e6635560f	Add merge token to FCI	2021-10-14 14:47:50 +02:00
simon lehericey	6826bf03b0	Sign in with a user linked by france connect sub (openid) ... instead of looking linked user by email because : - follows FC recommendation to fetch ds account by openid - the email is not a valid key as many user can share the same FCI email. The following scenario is now working A user A (email: 1@mail.com) uses FC to connect to DS => It is connected as 1@mail.com Another user B (email: generic@mail.com) uses FC to connect => It is connected as generic@mail.com The first user A change its FC email to generic@mail.com and connect to DS => It is still connected as 1@mail.com	2021-10-14 14:47:50 +02:00
simon lehericey	87de9e38c6	allow draft to be saved with invalid cnaf champ	2021-10-12 14:27:20 +02:00
simon lehericey	7aee944daa	show cnaf tdc when procedure is compatible	2021-10-12 14:27:20 +02:00
simon lehericey	57a7f82a8f	add cnaf ui	2021-10-12 14:27:20 +02:00
simon lehericey	40d0cfcdc4	add champ validation	2021-10-12 14:27:20 +02:00
simon lehericey	c76d1043fa	add cnaf champ	2021-10-12 14:27:20 +02:00
simon lehericey	354735ace4	add champ value_json jsonb column	2021-10-12 14:27:20 +02:00
simon lehericey	d68129b34d	add cnaf type de champ	2021-10-12 14:26:40 +02:00
simon lehericey	7c65571fca	add case when the old_expert or old_instructeur is nil	2021-10-12 11:04:06 +02:00
simon lehericey	d7e621d167	beef up the merge methods	2021-10-07 15:51:31 +02:00
simon lehericey	a480b31eb5	merge expert	2021-10-07 15:51:31 +02:00
simon lehericey	136f29524e	merge instructeur	2021-10-07 15:51:31 +02:00
Paul Chavard	4a947f9135	feat(manager): add become administrateur button in manager (with 24h expiration)	2021-10-07 11:32:12 +02:00
Paul Chavard	9d5c5447c2	fix(dossier): do not attempt to destroy transfers when a dossier is destroyed ... we had a dependent option on both sides of a relationship which created race conditions	2021-10-06 17:51:09 +02:00
Paul Chavard	d3c1941fbe	fix(dossier): never write dossier log on dossiers brouillons	2021-10-05 17:56:51 +02:00
simon lehericey	1000417bc9	update notifications_for_dossier used in dossier show	2021-10-05 12:05:43 +02:00
simon lehericey	65911b7680	update with_notifications dossiers scope (used in procedure index and show)	2021-10-05 12:05:43 +02:00
simon lehericey	3a878dfc04	add identity_updated_at column to dossier	2021-10-05 12:05:43 +02:00
Pierre de La Morinerie	f01e4ed6ef	models: document upstream PR about file size validation	2021-09-30 15:45:30 +02:00
simon lehericey	6eb10ecde5	display tdc alphabetically 🎉	2021-09-27 15:45:37 +02:00
simon lehericey	f55db98e97	rework type de champ type	2021-09-27 15:45:37 +02:00
Paul Chavard	357c684688	feat(routage): self managing instructeurs	2021-09-27 15:06:17 +02:00
Paul Chavard	d4e8158887	feat(routing): add instructeurs_self_management_enabled to procedures	2021-09-27 15:06:17 +02:00
Ismael MOUSSA S	36dc9c2ca2	Add File Validation concern after refactoring	2021-09-21 12:11:20 -05:00
Ismael MOUSSA S	7c7c9c9ea4	Fix file size validation message	2021-09-21 12:11:20 -05:00
Ismael MOUSSA S	bdbb4deb87	ADD FILE_MAX_SIZE constant to set allow file size limit	2021-09-21 12:04:56 -05:00
Paul Chavard	0ff62c5a5e	feat(routage): add routing_enabled to procedures	2021-09-18 11:22:35 +02:00
Paul Chavard	8b4bef2816	refactor(routage): simplify goupe_instructeur assign code	2021-09-18 11:21:26 +02:00
simon lehericey	b000590d81	add api particulier sources to procedure	2021-09-17 13:50:23 +02:00
simon lehericey	6c6205e188	a cloned procedure to a different admin does not keep api_particulier token and scopes	2021-09-16 09:30:11 +02:00
simon lehericey	2d2ae3a878	add api particulier scopes to procedure	2021-09-16 09:30:11 +02:00
Pierre de La Morinerie	745e19bb8e	localize	2021-09-16 09:07:47 +02:00
Pierre de La Morinerie	e97b7164dd	models: extract password complexity to a concern	2021-09-09 09:40:39 -05:00
Paul Chavard	d6cbdf2a48	feat(dossier): add dossier transfer models	2021-09-08 14:39:46 +02:00
Paul Chavard	44eb0ada4f	fix(i18n): add Kosovo to countries list ... Kosovo is not part of ISO 3166 as of time of writing. https://en.wikipedia.org/wiki/ISO_3166-2:RS#cite_ref-1	2021-09-08 12:11:25 +02:00
Paul Chavard	a7ec43a21e	fix(i18n): fix email previews	2021-09-08 09:21:19 +02:00
Pierre de La Morinerie	905fca0bd3	models: ensure Champs::Pays#to_s is always a string ... Before this, the result of `Champs::Pays#to_s` could be `nil`, which would break various things (like the PDF rendering of these champs).	2021-09-07 10:47:18 -05:00
Paul Chavard	74e277d0a2	feat(graphql): add an option to dossier state change mutations to disable notifications	2021-09-07 14:21:48 +02:00
Paul Chavard	96cbbc0192	fix(virus scan): prevent virus scan on archives and signatures uploads	2021-09-07 14:21:48 +02:00
simon lehericey	367f508e2e	linked_drop_down_list: empty primary => empty secondary	2021-09-07 10:09:18 +02:00
Paul Chavard	ff7fa4d895	feat(i18n): expose locale on dossier and deleted_dossier	2021-09-07 09:51:23 +02:00
Paul Chavard	f1ff6da81b	feat(i18n): add locale to user	2021-09-07 09:47:01 +02:00
Paul Chavard	a3cc072bbd	feat(i18n): translate countries selector	2021-08-31 13:15:26 +02:00
Paul Chavard	8e1bfb469f	fix(dossier): send expiration notifications 2 weeks prior to supression instead of a month	2021-08-26 11:28:57 +02:00
Christophe Robillard	e06f11f33f	add code insee libelle for commune export	2021-08-19 08:04:47 +02:00
Christophe Robillard	4a6c22d6a6	export code insee for commune champ	2021-08-19 08:04:47 +02:00
Christophe Robillard	daa306859c	champ export can be an array of values	2021-08-19 08:04:47 +02:00
Paul Chavard	ffa8c0c80a	feat(dossiers): enable dossiers termine expiration behind feature flag ... feature flag "procedure_process_expired_dossiers_termine" controls if a procedure has expiration enabled on dossiers termine re #3796	2021-08-18 16:11:35 +01:00
Christophe Robillard	93ba0cc038	stats: rend plus explicite le graphe taux d'acceptation	2021-08-11 10:50:26 +02:00
Christophe Robillard	2ee505e9a9	stats: i18n pour legende repartition par semaine	2021-08-10 15:22:36 +02:00
kara Diaby	0300df9a35	add procedure to bulk messages	2021-08-04 11:35:06 +02:00
simon lehericey	b29bae4707	a procedure has an encrypted api_particulier_token ... Co-authored-by: François VANTOMME <akarzim@gmail.com>	2021-07-30 11:18:44 +02:00
simon lehericey	66c35fdffe	add encryptable_concern ... Co-authored-by: François VANTOMME <akarzim@gmail.com>	2021-07-30 11:18:44 +02:00
kara Diaby	ab0782530c	create Bulk Message model and migration	2021-07-27 19:38:22 +02:00
kara Diaby	c92b249340	fixup! modify models	2021-07-27 19:38:21 +02:00
Paul Chavard	64cfb4d64e	Fix sort with revisions	2021-07-23 10:57:04 +02:00
Pierre de La Morinerie	0fd23ebd43	db: fix schema.rb leftovers	2021-07-22 17:55:47 +02:00
Paul Chavard	388fb39eb5	Fix false positive blank champ warnings	2021-07-22 10:45:25 +02:00
Paul Chavard	ac0f50b488	Improuve champ blank check	2021-07-22 10:45:25 +02:00
Pierre de La Morinerie	32ab2f0a80	instructeur: limit the maximum size of a filter value ... This prevents the URL from exceeding the max size, and causing '414: Request-URI too large' errors.	2021-07-20 14:49:48 +02:00
Pierre de La Morinerie	40b3ea8ad6	Revert "Instructeurs : limitation de la valeur d'un filtre à 100 caractères"	2021-07-13 18:19:46 +02:00
Pierre de La Morinerie	3c8a88a660	instructeur: limit the maximum size of a filter value ... This prevents the URL from exceeding the max size, and causing '414: Request-URI too large' errors.	2021-07-08 16:17:22 +02:00
Christophe Robillard	bc07a875eb	integrate a mininum weight for the average dossier weight ... before this commit, the average dossier weight took account only pieces justificatives. With this commit, we add a minimum weight for other files included in an archive like pdf_export, log operations, attachments added to traitements. This minimum weight is set arbitrary, from the observation of some random procedures in production	2021-07-06 15:58:45 +02:00
Paul Chavard	ce27999bc3	Refactor clone_attachments	2021-07-01 16:21:46 +02:00
Paul Chavard	280e54b59d	Enable test revisions	2021-07-01 15:59:07 +02:00
Christophe Robillard	66cc0dd08d	Revert "Revert "Expose dossier PDF export as IO"" ... This reverts commit 362093eff0.	2021-06-24 21:01:59 +02:00
krichtof	362093eff0	Revert "Expose dossier PDF export as IO"	2021-06-24 19:21:37 +02:00
Paul Chavard	b73d504f8d	Expose dossier PDF export as IO ... Co-authored-by: Christophe Robillard <christophe.robillard@beta.gouv.fr>	2021-06-24 17:49:24 +02:00
Paul Chavard	a4482233b8	[GraphQL] expose deleted dossiers	2021-06-24 11:51:37 +02:00
Paul Chavard	15ff046428	Improuve revision changes messages	2021-06-24 11:39:49 +02:00
Paul Chavard	241eff76a3	Enable publish new revision only if some changes are found	2021-06-24 11:39:49 +02:00
Paul Chavard	0ca5e1abe2	Preview should reflect revision changes	2021-06-24 11:39:49 +02:00
Paul Chavard	8b2c2c6466	Handle carte layers changes	2021-06-24 11:39:49 +02:00
Paul Chavard	35eccb5630	Show separate blocks for types de champ and annotation changes	2021-06-23 09:40:07 +02:00
Paul Chavard	19195008e8	Expose removed types_de_champ in exports	2021-06-23 09:40:07 +02:00
simon lehericey	eadae7af6b	show all available tdc for procedure presentation	2021-06-23 09:40:07 +02:00
Paul Chavard	0d25f52309	Add changed? and compare on ProcedureRevision	2021-06-23 09:40:07 +02:00
Paul Chavard	15e9013264	Set published_at on revision when publishing a procedure	2021-06-23 09:40:07 +02:00
Paul Chavard	f238710044	Add last_month export	2021-06-23 09:23:10 +02:00
Christophe Robillard	7851d6b1cc	archives: count archived dossiers	2021-06-18 08:59:13 +02:00
krichtof	4bda6600b1	explain what percentile constant means ... Co-authored-by: Pierre de La Morinerie <pierre.de_la_morinerie@beta.gouv.fr>	2021-06-17 16:31:53 +02:00
Christophe Robillard	896190b91e	return nil when no traitement time	2021-06-17 16:31:53 +02:00
Christophe Robillard	887c5cb4a9	correct rubocop offenses	2021-06-17 16:31:53 +02:00
Christophe Robillard	a5ae5af56a	extract NB_DAYS_RECENT_DOSSIERS and PERCENTILE	2021-06-17 16:31:53 +02:00
Christophe Robillard	f2deba733d	use traitement_times to compute usual_traitement_time for recent ... dossiers	2021-06-17 16:31:53 +02:00
Christophe Robillard	21dd05cc56	less sql queries for usual_traitement_time_by_month	2021-06-17 16:31:53 +02:00
Christophe Robillard	a8840faadb	move stats methods to appropriate concern class	2021-06-17 16:31:53 +02:00
Christophe Robillard	45ffae9eb3	affiche evolution temps de traitement	2021-06-17 16:31:53 +02:00
Christophe Robillard	701b72494d	compute usual traitement time for specific month	2021-06-17 16:31:53 +02:00
Paul Chavard	a2c53ce7ea	format phone numbers	2021-06-15 09:14:55 +02:00
François Vantomme	c9b1095d1e	Refactor (Rubocop): replace map{ … }.compact by filter_map ... In Ruby 2.7, Enumerable#filter_map has been added. This cop identifies places where map { … }.compact can be replaced by filter_map. See: https://docs.rubocop.org/rubocop-performance/cops_performance.html#performancemapcompact	2021-06-11 15:38:09 +02:00
Christophe Robillard	169f254c79	infer champ type from class	2021-06-09 10:52:38 +02:00
Christophe Robillard	6f845508b4	order archive by desc month	2021-06-09 10:52:38 +02:00
Christophe Robillard	5e180268cd	remove one sql query	2021-06-09 10:52:38 +02:00
simon lehericey	f2ba83a704	cout_dossier_termines_by_month for groupe_instructeurs ... Co-authored-by: Christophe Robillard <christophe.robillard@beta.gouv.fr>	2021-06-09 10:52:38 +02:00
simon lehericey	9e43823f9a	add average_dossier_weight ... Co-authored-by: Christophe Robillard <christophe.robillard@beta.gouv.fr>	2021-06-09 10:52:38 +02:00
Christophe Robillard	7002811ba5	optim count nb_dossiers per month for archive ... `Traitement#count_dossiers_termines_by_month` removes n+1 queries Co-authored-by: LeSim <mail@simon.lehericey.net>	2021-06-09 10:52:38 +02:00
Christophe Robillard	9bb9462b3a	optimise les stats termines by week	2021-06-08 15:23:31 +02:00
Paul Chavard	1888f74b10	Prevent double processing of declarative dossiers	2021-06-04 17:55:40 +02:00
kara Diaby	3555c9696a	modify concern	2021-06-04 15:29:08 +02:00
Paul Chavard	f526e303e8	Apply suggestions from code review ... Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com>	2021-06-03 13:11:16 +02:00
Paul Chavard	3fb10fb4b8	Set published_at on revision when publishing a procedure	2021-06-03 13:11:16 +02:00
Paul Chavard	306e5d228d	Add published_at to procedure_revisions	2021-06-03 13:11:16 +02:00
Paul Chavard	05380b9520	Fix destoying discarded procedures	2021-05-27 18:48:56 +02:00
Paul Chavard	9b0dae4cc2	Fix apostrophes ‘ -> ’	2021-05-26 18:05:14 +02:00
Paul Chavard	4922bc88d6	Do not crash when properties is nil	2021-05-26 12:40:07 +02:00
Paul Chavard	dfc46a8736	Enable add descriptions to cadastres	2021-05-26 11:27:09 +02:00
Paul Chavard	179bb5a9fe	Apply suggestions from code review ... Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com>	2021-05-25 11:43:38 +02:00
Paul Chavard	acb277e650	Use stable_id when replacing tags	2021-05-25 11:43:38 +02:00
Paul Chavard	3b85ade440	Add compatibility cadsatre layer with old API GEO	2021-05-24 11:57:00 +02:00
Paul Chavard	e74dcb0056	Remove ign feature flag	2021-05-24 11:50:16 +02:00
simon lehericey	b620888597	show only dossier avis	2021-05-20 16:18:04 +02:00
kara Diaby	20933579b0	do not display confidential avis to other experts	2021-05-19 21:30:22 +02:00
Paul Chavard	5f419954b4	Fix dossier deleted user display	2021-05-13 10:43:55 +02:00
Paul Chavard	3f7a2bea9b	Dossier without user should be valid	2021-05-11 17:50:10 +02:00
Paul Chavard	8a74438dc1	Use conservation_extension instead of en_construction_conservation_extension	2021-05-11 17:33:53 +02:00
Paul Chavard	1e0d6ea28f	Rename en_construction_conservation_extension to conservation_extension	2021-05-11 14:08:51 +02:00
simon lehericey	c5f6c9ae1e	fix missing state translation	2021-05-10 11:17:34 +02:00
simon lehericey	8d0082419c	do not know how it worked before	2021-05-05 14:36:34 +02:00
simon lehericey	4dc314d24b	[fix #6084] add db constraints to france_connect_informations table	2021-05-05 14:28:20 +02:00
simon lehericey	50f679746f	do not extract twice the same dossier_id if the dossier is followed twice	2021-05-04 16:38:34 +02:00
Paul Chavard	bcbfcdc537	Revert "Merge pull request #6142 from tchak/enable_brouillon_extend_conservation" ... This reverts commit 48eb4d9778, reversing changes made to 5539d5cb8c. # Conflicts: # app/models/dossier.rb # db/schema.rb	2021-05-04 16:03:29 +02:00
Christophe Robillard	01f180022b	prend en compte uniquement les pj pour estimer la taille d'un dossier	2021-05-04 12:50:12 +02:00
Paul Chavard	f6508899de	Refactor NotificationMailer	2021-05-04 12:05:06 +02:00
Paul Chavard	a4fd629f4a	Enable user destruction	2021-05-04 12:05:06 +02:00
Paul Chavard	b2a867266a	Allow users to extend conservation on drafts	2021-04-29 19:50:30 +02:00
Christophe Robillard	f40d96fbd2	Revert "Revert "Export de tous les dossier d'une démarche"" ... This reverts commit d9a588b52e.	2021-04-29 17:29:47 +02:00
krichtof	d9a588b52e	Revert "Export de tous les dossier d'une démarche"	2021-04-29 16:07:18 +02:00
simon lehericey	db23a853a9	fetch all notification at once	2021-04-29 11:23:41 +02:00
simon lehericey	a4e813380a	one query for avis count	2021-04-29 11:23:41 +02:00
simon lehericey	8b73d8804c	fetch all exports at once by groupe_instructeurs_ids	2021-04-29 11:23:41 +02:00
Christophe Robillard	09870c918d	prevent race conditions when creating archives	2021-04-28 11:40:58 +02:00
Christophe Robillard	dfbe004122	rename content_type to time_span_type for archives	2021-04-28 11:40:58 +02:00
Christophe Robillard	8b2849408c	instructeurs can create and download archives	2021-04-28 11:40:58 +02:00
Christophe Robillard	07cc4fa97f	add service to create procedure archive	2021-04-28 11:40:58 +02:00
Christophe Robillard	c25f3c79d9	add archive model	2021-04-28 11:40:58 +02:00
Pierre de La Morinerie	0cb2162a65	db: fix out-to-date Procedure comments	2021-04-27 15:36:22 +02:00
Paul Chavard	2a068fb9b0	Remove user feedback buttons	2021-04-22 15:40:40 +01:00
Paul Chavard	c20ad5ca17	Remove the link between commentaire and user	2021-04-22 15:10:47 +01:00
simon lehericey	553e1d973c	remove old methods	2021-04-22 10:46:04 +02:00
kara Diaby	541a36abbf	Add boolean to procedures table	2021-04-19 10:23:45 +02:00
simon lehericey	e0959cda1e	constantize hot strings ... - 1131 objects over 4220 (-25%) created in app/	2021-04-16 13:13:22 +02:00
simon lehericey	47f13219ed	Avoid useless TypeDeChamp deserialization ... - 520 objects overs 4720 (10%) created in app/ (using ?pp=profile-memory&memory_profiler_allow_files=app/)	2021-04-16 13:13:22 +02:00
simon lehericey	e728a3fcb7	include type_de_champ ... Avoid n+1 when matching champ.stable_id in procedure.presentation.displayed_fields_values win 2s in the worst 3s scenario	2021-04-16 13:13:22 +02:00
Paul Chavard	ea484b879e	Prevent expert users to be deleted	2021-04-15 16:17:36 +01:00
kara Diaby	663fa50f02	notify expert when a decision is taken on a dossier	2021-04-15 11:29:55 +02:00
Paul Chavard	6d37e1d133	Fix discarded procedures destruction	2021-04-14 12:24:16 +01:00
Paul Chavard	5b56ec425b	Fix discarded dossiers destruction	2021-04-14 12:24:16 +01:00
Paul Chavard	f152c51d12	Remove ignored_columns	2021-04-13 17:00:07 +01:00
simon lehericey	76e261691a	add data column to france_connect_infromations	2021-04-13 09:59:28 +02:00
simon lehericey	cd6cb99c3c	add bypass_email_login_token to instructeur	2021-04-13 09:43:38 +02:00
simon lehericey	594cda3ee3	Remove previous attempt but steal its spec	2021-04-13 09:32:48 +02:00
simon lehericey	6055fd1b0b	remove for_procedure	2021-04-13 09:32:48 +02:00
simon lehericey	430acb1cb0	Fetch all count at once (- 400ms on pass culture)	2021-04-13 09:32:48 +02:00
simon lehericey	b24faae7e3	remove obsolete procedure_id column in assign_to table	2021-04-09 11:41:13 +02:00
Paul Chavard	5a7312f775	Ensure address to_s never returns nil	2021-04-08 16:43:45 +01:00
Paul Chavard	651a928b7c	Improuve export UI	2021-04-08 14:40:26 +01:00
Paul Chavard	371d612fdb	Remove unused columns	2021-04-08 12:43:29 +01:00
Paul Chavard	5e5122a436	Prevent crash in preview where there is no siblings	2021-04-06 18:15:29 +01:00
Paul Chavard	2702660d72	Update app/models/champs/header_section_champ.rb ... Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com>	2021-04-06 10:45:16 +01:00
Paul Chavard	4feda01b6f	Show section numbers only if none of sections start with numbers	2021-04-06 10:45:16 +01:00
kara Diaby	60c06b6d8c	add revoked at to experts_procedures	2021-04-06 10:39:22 +02:00
Pierre de La Morinerie	3499f5af9a	models: remove invalid Dossier ↔︎ Champ inverse relationship ... `Dossier.champs` is not really an inverse of `Champs.dossier`: when a Champ record is created, it should not always be added to dossier.champs (for instance if the champ is private). NB: this breaks the workaround we added in #3907 to fix the parent dossier not being touched in some cases (the workaround was to add an inverse relationship, but we now have to remove it). The new workaround is to watch for `changed_for_autosave?` on champs. Unlike `changed?`, `changed_for_autosave?` also detects changes to attachments. This allows us to touch both `last_champ_updated_at` and `updated_at` in a single pass.	2021-04-06 10:26:17 +02:00
Paul Chavard	7f3d4a26ad	Make exports#key not-null	2021-04-02 17:42:24 +01:00
Paul Chavard	fd48b86b7f	Simplify export unicity check and use create_or_find_by	2021-04-01 21:14:16 +01:00
Pierre de La Morinerie	798b4a65cc	models: fix db structure comment in etablissement.rb ... The column is not removed yet, but it is ignored.	2021-03-30 10:45:31 +02:00
Paul Chavard	23104f15a4	Fix export n+1 queries	2021-03-25 19:22:12 +01:00
Pierre de La Morinerie	3f3d6ae399	controllers: use template: rather than file: to render PDFs ... ActionView now throws an error if a relative path is used with `file:`.	2021-03-25 13:24:53 +01:00
kara Diaby	2930de1015	remove useless code in models	2021-03-24 17:47:24 +01:00
kara Diaby	71973de17c	remove useless columns from the db	2021-03-24 16:20:44 +01:00
Paul Chavard	0b22788d60	experts_procedure should not be optional	2021-03-23 13:46:33 +01:00
Paul Chavard	84214f4bd4	Do not export non exportable champs on draft procedures	2021-03-23 09:55:37 +01:00
Kara Diaby	38837443aa	Merge branch 'main' into fix-experts-lookup	2021-03-18 20:46:56 +01:00
Pierre de La Morinerie	239169e925	dossier: fix looking-up avis from Expert ... This line causes an error on Rails 6.1. And it isn't even necessary: this line is supposed to query avis where the expert advice has been requested – but this is handled by the `if expert.dossiers.include?(self)` condition just above.	2021-03-18 17:59:30 +01:00
Paul Chavard	1449fbbe67	Fix multiple_drop_down_list mandatory check	2021-03-18 15:22:28 +01:00
kara Diaby	5e88ecc24c	improve request to find an expert	2021-03-18 11:38:53 +01:00
kara Diaby	328c2a8e3c	change email to display for expert	2021-03-18 11:38:52 +01:00
kara Diaby	e7945594cf	eager_load for expert	2021-03-18 11:38:52 +01:00
kara Diaby	38740d1b5b	modify experts avis controllers, concern and serializer	2021-03-18 11:38:52 +01:00
kara Diaby	c55e4d0d98	remove unused instructeur logic	2021-03-18 11:38:52 +01:00
kara Diaby	54d414b3b7	add expert to export	2021-03-18 11:27:51 +01:00
kara Diaby	d47fde3fcb	add polymorphic relation to claimant on avis table	2021-03-18 11:27:51 +01:00
kara Diaby	d2ab2debb6	add expert logic	2021-03-18 11:27:51 +01:00
Christophe Robillard	60cc4d3697	add pdf to pjs export	2021-03-16 15:13:17 +01:00
Paul Chavard	76aa7bdfe3	Add default nil value for numero_tva_intracommunautaire	2021-03-16 12:57:10 +01:00
Pierre de La Morinerie	75a1046315	active_storage: refactor concerns ... Follow-up of #5953. Refactor the concerns with two goals: - Getting closer from the way ActiveStorage adds its own hooks. Usually ActiveStorage does this using an `Attachment#after_create` hook, which then delegates to the blob to enqueue the job. - Enqueuing each job only once. By hooking on `Attachment#after_create`, we guarantee each job will be added only once. We then let the jobs themselves check if they are relevant or not, and retry or discard themselves if necessary. We also need to update the tests a bit, because Rails' `perform_enqueued_jobs(&block)` test helper doesn't honor the `retry_on` clause of jobs. Instead it forwards the exception to the caller – which makes the test fail. Instead we use the inline version of `perform_enqueued_jobs()`, without a block, which properly ignores errors catched by retry_on.	2021-03-16 11:49:14 +01:00
Paul Chavard	a7fb7bf1ef	Add geo json validation	2021-03-11 15:51:09 +01:00
Paul Chavard	d24ee27cac	Try to reduce the number of external data fetches ... Only fetch external data if the external_id is the current one and data is not yet fetched	2021-03-11 14:56:37 +01:00
kara Diaby	6383e6b9e7	Revert "Revert "Claimant type to avis table"" ... This reverts commit f4fd220d43.	2021-03-10 08:48:55 +01:00
Paul Chavard	70500e3d56	Groupe instructeur selector default blank	2021-03-09 14:47:23 +01:00