simon lehericey
ee296f2b44
Use default format for date and datetime champ
2019-06-12 17:48:12 +02:00
pedong
abcd58c35d
[ fix #3710 ] date with letter
...
Co-Authored-By: simon lehericey <mail@simon.lehericey.net>
2019-06-12 17:48:12 +02:00
Nicolas Bouilleaud
6b90bc1ea1
Add “previously followed” dossiers and gestionnaires
...
Using an “inactive” Follow scope, similar to the “active” scope.
(I was tempted to use a default_scope, but this breaks when trying to `unscope` it in associations.)
2019-06-12 17:33:53 +02:00
Pierre de La Morinerie
55c9dfc001
api_entreprise: display better error message when SIRET is private
...
Previously we blamed the network.
Now we say that the entreprise infos cannot be retrieved. Which is not
ideal, but better.
2019-06-12 11:58:04 +02:00
Pierre de La Morinerie
0b49e61ec0
tasks: repair updated_at of dossiers wrongly touched by PJ migration
...
When running the PJ migration task, migrated dossiers have their
updated_at attribute modified.
This means a yellow notification badge pops up on the Instructeurs
pages.
This PR repairs the affected dossiers, by restoring an approximative
updated_at from the latest workflow value (or the timestamp of the
migrated champ).
2019-06-06 11:11:29 +02:00
Paul Chavard
6d312e1716
spec: refactor wait_for_ajax
to work with out new ajax utils
...
`wait_for_ajax` is not used anymore, but it may be in the future.
2019-06-04 16:30:36 +02:00
Paul Chavard
f621bd63e5
spec: fix flaky test by using new wait_until
helper
...
Fix #3911
2019-06-04 16:30:36 +02:00
Paul Chavard
cc80939a42
spec: remove tests for old pj (probably) dead code
2019-06-04 16:30:36 +02:00
Pierre de La Morinerie
c2fcc6057e
spec: add a wait_until
helper
2019-06-04 16:30:36 +02:00
Paul Chavard
e870ba186f
spec: add a pause
helper
2019-06-04 16:16:53 +02:00
Pierre de La Morinerie
b829d105d9
brouillon_spec: fix the slow use of have_select(locator, selected: …)
...
Capybara's `have_select` can be very slow for elemtns with many options
(see https://github.com/teamcapybara/capybara/issues/1527 )
This is because Capybara asserts that no other elements than the
required ones are selected.
This faster version is not as complete, but helps when checking the
countries list or the years in a date picker.
2019-06-04 11:03:09 +02:00
Pierre de La Morinerie
5419c130f4
brouillon_spec: make the login sequence faster
...
Log the user with `login_as` (rather than the browser).
2019-06-04 11:03:09 +02:00
Pierre de La Morinerie
2bd749a325
specs: clear the React champ before adding a new value
...
This prevents the value from being
`Nouveau champ TexteLibellé de champ carte`.
2019-06-03 12:47:03 +02:00
Pierre de La Morinerie
c05dc38b95
specs: remove 'disable-gpu' from chromedriver options
...
This option as only ever needed on Windows [1] (which we don't use),
and it shouldn't be required anymore, as the underlying bug has been
fixed [2].
- [1] https://developers.google.com/web/updates/2017/04/headless-chrome
- [2] https://bugs.chromium.org/p/chromium/issues/detail?id=737678
2019-06-03 12:46:12 +02:00
Paul Chavard
ff44b7a600
Refactor purge pj to be more generic
2019-05-29 15:54:51 +02:00
Pierre de La Morinerie
6cb02f2927
pj migration: handle signal interrupts
2019-05-29 14:46:49 +02:00
Pierre de La Morinerie
60121a1be6
task_helper: ensure that incrementing above 100% doesn’t raise an error
2019-05-29 12:06:32 +02:00
Pierre de La Morinerie
10df7b70ee
carrierwave: when migrating, create an empty blob if file is missing
2019-05-28 18:19:33 +02:00
Pierre de La Morinerie
44c410d40d
piece_justificative_service: fix for missing order_place
...
In production some pieces justificatives don't have an order place.
In this case, insert the champs after the ones that have an order place.
2019-05-28 17:20:07 +02:00
Pierre de La Morinerie
52b7a82932
services: mark attachments migrated from CarrierWave as safe
...
This avoids to enqueue thousands of scans when migrating the PJs of
a whole procedure.
2019-05-28 11:39:22 +02:00
Pierre de La Morinerie
4cf54e0d28
tasks: add progress report to the pjs migration task
...
Progress is indicated per migrated champ.
2019-05-28 10:42:18 +02:00
Pierre de La Morinerie
21ac60ad04
tasks: add a task to migrate pjs of procedures in batches
2019-05-28 10:42:18 +02:00
clemkeirua
f06ae1631f
no crash when q is missing on RechercheController::index
2019-05-22 15:02:57 +02:00
Paul Chavard
cc4eba2b36
Less mokey patching
2019-05-21 14:21:42 +02:00
Paul Chavard
f6421e081a
Refactor attachment view
2019-05-21 14:21:13 +02:00
Paul Chavard
42235e81b1
Use active storage load hook to extend blob
2019-05-16 20:43:01 +02:00
Paul Chavard
9725f2a418
Enable new champs editor for all
2019-05-14 16:18:29 +02:00
Paul Chavard
3446782cd0
Remove deprecated editor
2019-05-14 16:18:29 +02:00
Paul Chavard
dba8d65137
Track dossier operations with author and subject
2019-05-14 14:31:03 +02:00
Pierre de La Morinerie
f5f7dfba40
france_connect: fix for params entirely missing from the callback
...
Fix a Sentry exception encountered in production.
2019-05-13 15:45:12 +02:00
pedong
b1f11c0b0a
add explanation to spec login
2019-05-13 15:28:25 +02:00
pedong
a226999382
redirect to same path after use signup
2019-05-13 15:28:25 +02:00
Pierre de La Morinerie
e66e78b4db
helpscout: remove integration of custom fields
...
Our new HelpScout plan doesn't allow custom fields
anymore.
2019-05-13 12:33:29 +02:00
clemkeirua
d0794f42d1
fix tag_substitution_concern links for lien attestation
2019-05-07 08:54:29 +02:00
clemkeirua
c98655be52
ellipsis on file input overflow
2019-05-07 08:54:29 +02:00
clemkeirua
0e26bda186
cleanup the tag substitution concern & uniformization
2019-05-07 08:54:29 +02:00
clemkeirua
e4259466b4
nettoyage du tag_substitution_concern
2019-05-07 08:54:29 +02:00
clemkeirua
f8a2598647
ajout du lien vers le justificatif dans la balise --lien attestation--
2019-05-07 08:54:29 +02:00
clemkeirua
747dc505cc
ajout d'un test
2019-05-07 08:54:29 +02:00
clemkeirua
4aab72be68
implementation du systeme de PJ de motivation
2019-05-07 08:54:29 +02:00
Nicolas Bouilleaud
df865e71dc
Make sure that there always is at least one administrator per Procedure
2019-05-06 16:19:08 +02:00
Paul Chavard
96b3547788
Exercices and RNA information are optional and should not block the request
2019-05-03 18:23:21 +02:00
Paul Chavard
91f2d7d706
Remove deprecated virus_scan model
2019-05-03 11:07:19 +02:00
Paul Chavard
6e8b9cf668
Refactor piece_jointe template to avoid repetition
2019-05-02 15:58:09 +02:00
Paul Chavard
f113d108c9
Save virus scan status to blob metadata
2019-05-02 15:58:09 +02:00
Paul Chavard
2f633b5d23
Load leaflet from a separate chunk
2019-05-02 14:10:48 +02:00
Pierre de La Morinerie
e06e32238c
api_entreprise: display a specific error message on network errors
2019-05-02 11:24:38 +02:00
Pierre de La Morinerie
ad4a89f0f6
api_entreprise: raise on network error
2019-05-02 11:24:22 +02:00
Pierre de La Morinerie
7c1c61248e
spec: cleanup siret_controller_spec.rb
2019-05-02 11:24:22 +02:00
Pierre de La Morinerie
fd95ea2871
spec: cleanup exercices_adapter_spec
2019-05-02 11:24:22 +02:00
Pierre de La Morinerie
d855468cb6
dossiers: display the estimate of the entire processing time
...
Displaying separate estimations for en_construction and en_instruction
doesn't really make sense for the users: they want to know how
long it is going to take overall, not the petty details of our workflow.
2019-04-30 15:56:27 +02:00
Nicolas Bouilleaud
1c2e93ed41
Fix “nearing_end_of_retention” test
...
The `nearing_end_of_retention` test creates a `just_expired_dossier` “six months ago”, which is 29 Oct 2018. The autumn DST change was on October 28; this is the first time this test runs under these conditions. We workaround the time offset by creating the dossier one hour earlier.
This is technically a workaround, not a fix: the date arithmetics in `nearing_end_of_retention` are probably wrong. It looks like it’s comparing intervals, which seems error-prone, while it should be comparing dates. For now, I’m just making the tests pass.
2019-04-29 15:41:52 +02:00
Paul Chavard
8d093bd9ba
Fix missing dossier_id on champs inside repetition
2019-04-18 16:55:35 +02:00
simon lehericey
e65e21a72f
Email notification: use the right method for procedures
2019-04-18 15:07:01 +02:00
Paul Chavard
9beff5ee9a
Always create menu deroulant champs with a value
2019-04-11 14:38:21 +02:00
Mathieu Magnin
1a97cd42de
Fix missing helper in notification mailer
2019-04-11 12:25:55 +02:00
Mathieu Magnin
22034730b0
Fix factory to avoid crash because of procedure is nil
2019-04-11 12:25:55 +02:00
Mathieu Magnin
c550d40e3a
[ Fix #3064 ] Add preview test
2019-04-11 11:03:13 +02:00
Mathieu Magnin
28f9208ce8
When mail template is updated, stay on edit page to easily preview it
2019-04-11 11:03:13 +02:00
Mathieu Magnin
14c3fb7224
[ Fix #3064 ] Add a preview button for state notifications emails
2019-04-11 11:03:13 +02:00
Mathieu Magnin
e91b412254
[ Fix #3064 ] Use a different layout for state notifications emails
2019-04-11 11:03:12 +02:00
Nicolas Bouilleaud
c5122ee7f5
Allow filtering ProcedurePresentation by followers_gestionnaires
...
fixes #3464
2019-04-10 14:32:51 +02:00
Pierre de La Morinerie
e34c556f29
procedure: fix specs
...
When the time computations are done accross a Daylight Saving Time
change, they may be off by one hour.
It doesn't matter, as the estimated delay is counted in days, not
hours.
2019-04-08 15:24:44 +02:00
Pierre de La Morinerie
8ca683c515
mailers: fix last_week_overview crash when the overview is missing
...
This is because procedures may be unpublished between the time where
the job is enqueued and the time the mailer is run
Fix #3745
2019-04-04 17:32:12 +02:00
Paul Chavard
4fb889f10a
Send browser support information and format user id
2019-04-04 14:21:32 +02:00
Pierre de La Morinerie
41ad89d8ac
commencer: fix redirection with invalid path
2019-04-04 14:03:40 +02:00
Pierre de La Morinerie
158d6e1ae6
avis: format newlines in avis
...
Fix #3738
2019-04-04 10:20:57 +02:00
Paul Chavard
8157fd0127
Fix type de champ menu déroulant
2019-04-03 21:53:57 +02:00
Paul Chavard
b9be186d2c
Sentry should send environment information
2019-04-03 18:19:16 +02:00
Pierre de La Morinerie
22f2ca105e
commencer: display a FranceConnect button
...
Fix #3640
2019-04-03 16:08:09 +02:00
Pierre de La Morinerie
28dcbcb85b
auth: move the FranceConnect button to a partial
2019-04-03 16:08:09 +02:00
simon lehericey
65370b20a9
Use IPService to remove secure connexion from trusted networks
2019-04-03 15:21:19 +02:00
simon lehericey
52e6632175
Add IPService
2019-04-03 15:21:19 +02:00
Paul Chavard
e2fc9e10b0
Update tests for new editor
2019-04-03 14:38:57 +02:00
Paul Chavard
639facaf2a
Add new types_de_champ#move api
2019-04-03 14:38:07 +02:00
Pierre de La Morinerie
031c40aa55
stats: display 12 weeks of feedbacks
2019-04-02 17:22:38 +02:00
Mathieu Magnin
8525761332
Revert english dates
2019-04-02 14:38:47 +02:00
simon lehericey
f945b9ec63
Champ Siret: Fix siret-champ save
...
When a user enter a siret, it calls siret_controller in ajax. The champ value is stil nil, so champ.present? is false because champ.blank is redefined to focus on value. Thus the champ is not updated.
2019-04-02 14:17:21 +02:00
Mathieu Magnin
71e0969bc0
[ Fix #3692 ] Ensure SIRET is correct on server
2019-03-28 18:03:53 +01:00
Mathieu Magnin
27c8e9dcb8
Use the same clone_attachment method for all attributes on procedure.clone
2019-03-28 17:17:29 +01:00
clemkeirua
0d71120f98
[ fix #306 ] Possibilité de joindre un document à un avis
2019-03-28 15:45:14 +01:00
Pierre de La Morinerie
abeb58caa5
dossiers: displays an "Start an other dossier" item in action dropdown
2019-03-28 15:26:15 +01:00
Pierre de La Morinerie
d03e340345
dossiers: add an actions menu
2019-03-28 15:26:15 +01:00
Pierre de La Morinerie
06e7355d5b
commencer: fix invalid URL on test procedures
...
Fix #3693
2019-03-28 14:15:46 +01:00
Pierre de La Morinerie
d267d782b8
help: add administration contact on /commencer pages
2019-03-28 11:36:24 +01:00
Frederic Merizen
9aebb76e77
[ #2180 ] Avoid sending spurious notifications to instructeurs
2019-03-27 17:36:13 +01:00
Frederic Merizen
7d316b8369
[ #2180 ] High-level PJ to champ PJ migration service
2019-03-27 17:36:13 +01:00
Frederic Merizen
e24242e4b2
[ #2180 ] Low-level Carrierwave to ActiveStorage migration
2019-03-27 17:36:13 +01:00
Frederic Merizen
21dbe44e07
[ #2180 ] Fix ordering of piece jointe champs
2019-03-27 17:36:13 +01:00
pedong
fb29d30826
[ fix #3342 ] show date with format letter
2019-03-27 15:27:20 +01:00
Mathieu Magnin
4e27872a25
[ Fix #3650 ] when cloning a procedure, do not forget pj_templates
2019-03-26 15:31:09 +01:00
Pierre de La Morinerie
30d11e0dac
app: rename new_gestionnaire
to gestionnaires
2019-03-26 10:48:59 +01:00
pedong
0d7c30c9dd
[ fix #3476 ] add notify email for the dossier change state to instruction
2019-03-25 16:04:33 +01:00
simon lehericey
39b710fdde
Annotation: can use repetable
2019-03-25 11:08:53 +01:00
Pierre de La Morinerie
ded5b70444
app: rename new_user
to users
2019-03-25 10:56:39 +01:00
Pierre de La Morinerie
b1a7018d30
procedure: ignore bad data when computing usual_instruction_time
...
Fix #3655
2019-03-20 17:48:54 +01:00
Mathieu Magnin
6570bed09c
[ Fix #3641 ] Do not change PJ value in API if PJ is safe
2019-03-20 11:37:31 +01:00
Pierre de La Morinerie
69580288a4
help: add a custom help dropdown in gestionnaire context
2019-03-20 11:06:54 +01:00
Pierre de La Morinerie
549b17f75e
help: add a custom help dropdown in dossier context
2019-03-20 11:06:54 +01:00
Paul Chavard
69a51e3296
Save SIRET data on search
2019-03-19 16:22:42 +01:00
Pierre de La Morinerie
ed1f6ec38d
procedure: fix verification delay
...
The verification delay was ignoring all dossiers not closed yet.
2019-03-19 15:51:51 +01:00
Mathieu Magnin
2c1e1db37d
[ Fix #3617 ] 404 when filter[value] contains a "."
2019-03-19 14:25:57 +01:00
simon lehericey
6607de4827
Notification: add service to send notifications
2019-03-18 16:37:51 +01:00
simon lehericey
ed6828c66c
Notification: UI
2019-03-18 16:37:51 +01:00
Mathieu Magnin
6b9dbb22af
Remove unused stats
2019-03-13 11:00:14 +01:00
Mathieu Magnin
ff0356e698
Fix Sentry 165 : api crash when siret is unknown
2019-03-12 17:53:11 +01:00
Paul Chavard
549eca44cb
Enable flipflop on api requests
2019-03-12 14:02:55 +01:00
Paul Chavard
48701e80bd
Enable flipflop for instructeurs
2019-03-12 12:14:34 +01:00
Paul Chavard
bb8ba75d22
Explicitly pass current_administrateur on publish
2019-03-12 11:59:01 +01:00
Paul Chavard
0e4b6e1ba2
Remove “Nombre d'administrations ayant dématérialisé N démarches” graph
2019-03-12 11:59:01 +01:00
Paul Chavard
c37f649453
Update specs to use multiple administrateurs
2019-03-12 11:59:01 +01:00
Paul Chavard
23d8f0d803
Remove old tasks depending on single administrateur
2019-03-12 11:57:51 +01:00
Mathieu Magnin
b690b89b34
Clean old support task
2019-03-12 11:26:07 +01:00
Mathieu Magnin
f96d1b1823
Create default path for brouillons procedures
2019-03-12 11:26:07 +01:00
Mathieu Magnin
44f28ec565
Remove feature flag for publish draft
2019-03-12 11:26:07 +01:00
Frederic Merizen
af37005b33
Fix test intermittent introduit par #3479
2019-03-11 20:27:24 +01:00
Frederic Merizen
8d8376947d
[ Fix #3477 ] Individually remove values from multi-value filter
2019-03-11 17:14:17 +01:00
Frederic Merizen
efa71284fc
[ #3477 ] Test eager_load_displayed_fields
2019-03-11 17:14:17 +01:00
Frederic Merizen
70bf6aecf6
[ #3477 ] Filter by mutliple values
2019-03-11 17:14:17 +01:00
Frederic Merizen
5d01e37d70
[ #3477 ] Make filters stand out a little more in spec
2019-03-11 17:14:17 +01:00
Frederic Merizen
b428406fc7
[ Fix #3578 ] No tags for champs that cannot have user input anyway
2019-03-11 10:26:27 +01:00
Frederic Merizen
1d0156f9c6
[ #3572 ] Add tests
2019-03-08 18:32:35 +01:00
Frederic Merizen
6b0832047b
Service that computes administrator statistics and sends them to SendinBlue
2019-03-08 16:33:28 +01:00
Frederic Merizen
a8ce11a4d2
Add rel=noopener to links with target=_blank
...
http://support.detectify.com/customer/portal/articles/2792257-external-links-using-target-_blank-
2019-03-05 18:25:26 +01:00
Frederic Merizen
d053a9bb8d
Fix test for the 2 months following February
...
The problem was caused by the variable lenght of 2.months.ago, used
in the test.
During the period from March 1st to April 29th, because February
is so short, the message would change from 'delai de 2 mois'
to 'delai de environ 2 mois', causing the test to fail.
2019-03-01 18:25:15 +01:00
Paul Chavard
f7af01e0dc
Create new procedures with administrateurs
2019-02-26 16:38:58 +01:00
Pierre de La Morinerie
066672803b
pj_link: fix an exception when the scan is not associated yet
2019-02-21 16:00:33 +01:00
clemkeirua
71bff0812c
ajout d'un test pour caractériser le cas service = null
2019-02-21 12:34:53 +01:00
clemkeirua
236f73f838
ajout d'une balise pour le nom du service
2019-02-21 12:18:44 +01:00
Paul Chavard
84383fc3c1
Assigne admins to procedure.administrateurs
2019-02-20 17:10:57 +01:00
Paul Chavard
a7ba01a02a
Fix champ spec
...
fix #3257
2019-02-20 16:26:12 +01:00
Mathieu Magnin
f7650135f4
[ Fix #3375 ] on the API display safe files only
2019-02-19 18:10:35 +01:00
Pierre de La Morinerie
ffda67c1d8
spec: add specs for attachments
2019-02-19 18:02:27 +01:00
Pierre de La Morinerie
a3c0f3ccd6
spec: wait for the page to be rendered before checking values
2019-02-19 18:02:27 +01:00
Pierre de La Morinerie
d51cc8bfa2
spec: fix ActiveRecord queue not being set
2019-02-19 18:02:27 +01:00
Mathieu Magnin
11078b7f71
Add rake task to activate publish draft
2019-02-19 17:50:11 +01:00
Paul Chavard
aad685bb79
Show preview with correct type de champ options
...
fix #3439
2019-02-19 16:37:42 +01:00
clemkeirua
4ff9adde27
ajout d'un test auto pour l'affichage de la date de dépot coté instructeur
2019-02-19 12:00:36 +01:00
Mathieu Magnin
cf610bbd91
Merge branch 'dev' into enforce-rubocop-timezone
2019-02-18 17:41:41 +01:00
simon lehericey
0b8619be77
Gestionnaire: login_token! -> create_trusted_device_token
2019-02-18 17:21:46 +01:00
simon lehericey
c16e30442a
save path before redirect to link_sent_path
2019-02-18 17:20:49 +01:00
simon lehericey
7de3a18fd1
valid period depend on trusted_device_token.created_at
2019-02-18 17:20:49 +01:00
simon lehericey
d664f130fd
trustedDeviceToken: move token youth
2019-02-18 17:20:49 +01:00
simon lehericey
23db8a160c
move token validity to trusted_device_token
2019-02-18 17:20:49 +01:00
simon lehericey
bee9a108c5
split login and trusted_device logic
2019-02-18 17:20:00 +01:00
simon lehericey
9d92e43d8d
[ fix #3315 ] Migrate service organisme
2019-02-18 16:50:44 +01:00
Mathieu Magnin
dd27167c5d
Enforce Timezone rule in Rubocop
2019-02-18 16:19:42 +01:00
simon lehericey
a7e068003a
[ fix #3427 ] Administration can soft delete a dossier
2019-02-14 18:09:08 +01:00
Pierre de La Morinerie
7413df81e0
Revert "file upload: proxy direct upload through the APP_HOST"
...
This reverts commit 2365efbdaa
.
2019-02-14 16:23:11 +01:00
Mathieu Magnin
2365efbdaa
file upload: proxy direct upload through the APP_HOST
...
Ref #3409
2019-02-14 14:28:03 +01:00
Frederic Merizen
eb7cd28504
Fix undefined method for nil:NilClass
2019-02-13 19:22:38 +01:00
Frederic Merizen
41ab7246cf
[ #3424 ] Improve formatting of addresses with missing components
2019-02-13 09:57:33 +01:00
Paul Chavard
b7058947e1
Fix buttons on screen bottom
2019-02-12 16:22:12 +01:00
Paul Chavard
5da5f75c5f
[Types de Champ Editeur] Save on change and only edited model
2019-02-07 17:05:55 +01:00
Pierre de La Morinerie
4bfc258cbd
dossiers: refactor dossiers specs
...
- Use login_as instead of signing up in the browser
- Better name factory objects
- Group specs by use-case
2019-02-07 11:08:02 +01:00
Pierre de La Morinerie
a6704c4cd6
dossiers: allow users to delete "en construction" dossiers
2019-02-07 11:07:07 +01:00
Paul Chavard
6b39128be3
Clone nested types_de_champ
2019-02-06 10:05:27 +01:00
Mathieu Magnin
f6714cd9a3
If ClamavService fails then raise an error
2019-02-05 17:58:41 +01:00
simon lehericey
5715cdaa4c
[ fix #3363 ] use organisation_name in dossier summary
2019-02-05 17:41:51 +01:00
Frederic Merizen
a255e61556
[ #3356 ] Improve formatting for menus that only have a primary value
2019-02-05 17:35:30 +01:00
Frederic Merizen
a3d7c8de55
[ Fix #3356 ] Add tags for primary menu only / secondary menu only
2019-02-05 17:35:30 +01:00
Paul Chavard
a9a853b669
Fix and simplify linked-drop-down-list js
2019-02-05 16:48:26 +01:00
Paul Chavard
1d75a32cac
Add a default text type de champ to editor
2019-02-05 16:48:26 +01:00
Paul Chavard
071448e1d9
Champ Repetition dossier editor
2019-02-04 16:19:07 +01:00
Paul Chavard
a4a421a91a
Champ Repetition dossier display
2019-02-04 15:46:39 +01:00
Paul Chavard
9b7b59f67e
Champs editor should handle repetition type
2019-02-04 11:58:26 +01:00
Paul Chavard
7678d8eb0b
Revert for_api value on yes_no champs
2019-01-29 15:23:09 +01:00
Pierre de La Morinerie
803364490d
carto: present API InternalServerError to the user, instead of failing
2019-01-28 18:22:55 +01:00
Pierre de La Morinerie
f1f7f0ef9f
specs: cleanup "Delete draft from dossiers list" spec
2019-01-28 18:17:38 +01:00
Pierre de La Morinerie
934368616c
form: remove the "Delete draft" button
...
Draft can now be deleted from the dossiers list. This is the best place
to delete it (as it allow to clean the list) – and it is better than
asking the user if they want to delete a draft *precisely while they
are filling the form*.
2019-01-28 18:17:38 +01:00
Pierre de La Morinerie
bb1cc1eef8
tasks: delete dossiers without procedures
...
Fix #3279
2019-01-23 17:19:36 +01:00
Pierre de La Morinerie
fb75461c78
procedure: delete dossiers on destroy
2019-01-23 17:19:36 +01:00
Pierre de La Morinerie
3f0f22d849
procedure: clarify controller spec
2019-01-23 17:14:14 +01:00
Pierre de La Morinerie
23276cb9f9
commencer: add temporal context about the dossier
...
Ref #2225
2019-01-23 16:14:25 +01:00
Pierre de La Morinerie
437f73b4ce
search: exclude more special characters
2019-01-22 17:16:49 +01:00
Pierre de La Morinerie
151e5744e6
contact: rewrite specs to use finer-grained mocks
...
Before the specs mocked entire controller methods–which caused them
not to be tested.
Now we use finer mocks (or no mocks at all), to actually run more code.
2019-01-22 16:12:13 +01:00
pedong
6103176a78
[ fix #1238 ] add previsualization attestation for gestionnaire
2019-01-22 14:54:24 +01:00
Pierre de La Morinerie
bb753ce23e
commencer: redirect to the procedure page after sign-in and sign-up
2019-01-21 14:45:38 +01:00
Pierre de La Morinerie
016e5f2e6f
commencer: add an independant page
2019-01-21 14:45:38 +01:00
simon lehericey
45db2d8e5a
[ #3268 ] Rake task to correct bad follows and logs
2019-01-21 14:17:17 +01:00
Frederic Merizen
d01270eff2
[ #2180 ] Do not double-expose migrated type PJ as type champ PJ
2019-01-17 17:47:08 +01:00
Frederic Merizen
63519f04c8
[ #2180 ] Expose migrated types PJ as legacy type PJ in dossier API
2019-01-17 17:47:08 +01:00
Frederic Merizen
bf23abdfe3
[ #2180 ] Expose migrated PJs as legacy PJs in dossier API
2019-01-17 17:47:08 +01:00
Frederic Merizen
5f74ae1545
[ #2180 ] Do not double-expose migrated type PJs as champs in procedure API
2019-01-17 17:47:08 +01:00
Frederic Merizen
082255b489
[ #2180 ] Expose migrated types PJ as legacy types PJ in procedure API
2019-01-17 17:46:56 +01:00
Frederic Merizen
5e37400834
[ #2180 ] Only retain old PJ API when cloning for same admin
2019-01-17 17:40:40 +01:00
Frederic Merizen
530079e464
[ #2180 ] Make sure that old_pj is kept through successive clones
2019-01-17 17:40:40 +01:00
Frederic Merizen
8cb509d192
[ #2180 ] Keep information that this type de champ was cloned from a PJ
2019-01-17 17:40:40 +01:00
Frederic Merizen
651fd6149b
[ #2180 ] When cloning a procedure, convert types de PJ to types de champ PJ
2019-01-17 17:40:40 +01:00
Mathieu Magnin
b1efe57403
[ Fix #2423 ] Allow Usager to delete brouillon from dossiers#index
2019-01-17 17:30:37 +01:00
Paul Chavard
9136c9dfa0
Enable support_form for all
2019-01-17 15:17:48 +01:00
Mathieu Magnin
0e6b5678ad
Fix tests
2019-01-17 14:04:59 +01:00
Paul Chavard
f0cda2ca13
Test new champs editor
2019-01-17 11:20:31 +01:00
Paul Chavard
41c9b21509
Use new editor
2019-01-17 11:20:31 +01:00
Pierre de La Morinerie
ae763d93f3
sign_up: display procedure context if available
2019-01-17 11:07:09 +01:00
Pierre de La Morinerie
4fd9fa6610
sign_in: extract the procedure context to a ProcedureContextConcern
2019-01-17 11:07:09 +01:00
Pierre de La Morinerie
e580d336e4
sessions: add a helper to clear the stored return path
2019-01-17 10:48:54 +01:00
simon lehericey
99bfd19b41
[ fix #3268 ] Jobs: use automatic_operation
2019-01-16 17:20:12 +01:00
simon lehericey
6ab2d124f9
Dossier: #accepter_automatiquement!
2019-01-16 17:20:12 +01:00
simon lehericey
0f3dedb0b6
Dossier: #passer_automatiquement_en_instruction!
2019-01-16 17:12:32 +01:00
Pierre de La Morinerie
c944135c74
specs: move sign_up specs from common tests to new_user
...
Because sign_up is specific to each type of user
2019-01-16 14:25:12 +01:00
Pierre de La Morinerie
62ee710382
sign_in: remove hack for displaying the procedure context
...
Before there was no way to display the informations about a procedure
without having a dossier. Thus an empty dossier was created.
Now we can display the informations of a procedure using a @procedure
instance variable, so we can move this hack away.
2019-01-16 14:25:12 +01:00
Pierre de La Morinerie
5d6005dbe9
views: make dossier optional on procedure_footer
...
This allow displaying the procedure footer even when
there is no dossier yet
2019-01-16 14:25:12 +01:00
Pierre de La Morinerie
d36696442b
layouts: migrate sign_in to the shared layout
2019-01-16 14:25:12 +01:00
Pierre de La Morinerie
13f1d4c7d9
views: rename dossier_footer to procedure_footer
2019-01-16 14:25:12 +01:00
Frederic Merizen
0846860748
Proxy for active storage service provider
2019-01-16 11:34:57 +01:00
Pierre de La Morinerie
908771e172
stats: use group_by_week to compute the week range
...
Fix #3242
2019-01-10 16:17:00 +01:00
simon lehericey
29fff9ee68
[ fix #3269 ] bufferize login token email
2019-01-10 12:06:35 +01:00
Pierre de La Morinerie
6a0996c5f3
specs: refactor a view spec to be clearer and faster
2019-01-10 11:26:43 +01:00
Pierre de La Morinerie
5719107cbc
views: fix misnamed textarea template
2019-01-10 11:26:43 +01:00
simon lehericey
e7d5f30192
Admin: small reword in admin procedure ui
2019-01-09 16:25:00 +01:00
simon lehericey
a197285742
[ fix #2612 ] Admin: add missing steps to admin UI
2019-01-09 16:25:00 +01:00
simon lehericey
8ca7eb1c54
Procedure: cloning set the current admin gestionnaire of the procedure
2019-01-09 16:25:00 +01:00
simon lehericey
ac43038566
SessionControllerSpec: refactor #create tests
2019-01-09 13:49:47 +01:00
simon lehericey
b38fbc78ef
SessionControllerSpec: remove specific attribut test
...
change user.update(log_in_with_france_connect: nil) as log_in_france_connect is an enum
2019-01-09 13:49:47 +01:00
simon lehericey
9e26b5f4d8
SessionControllerSpec: small cleaning
2019-01-09 13:49:47 +01:00
simon lehericey
f5fa0499ca
SessionControllerSpec: remove duplicated tests
2019-01-09 13:49:47 +01:00
simon lehericey
9c335698f1
SessionControllerSpec: remove password syncing relating test
2019-01-09 13:49:47 +01:00
simon lehericey
f0139c5962
Spec Factory: an administrateur always has a gestionnaire
2019-01-09 13:49:47 +01:00
Paul Chavard
1beefe4469
Fix champ repetition belongs_to associations
2019-01-08 11:56:33 +00:00
gregoirenovel
b4781f7440
Make dossier link clickable for users in the Demande tab
2019-01-08 12:32:27 +01:00
gregoirenovel
f5a31be36a
Remove the now useless #formatted_value method
2019-01-08 12:32:26 +01:00
gregoirenovel
c00aac2f80
We can now replace processing in #formatted_value by #to_s calls
2019-01-08 12:32:26 +01:00
gregoirenovel
9e42190148
Remove the proxy value_for_export method
...
Overload for_export instead
2019-01-08 12:32:26 +01:00
gregoirenovel
9a2341c56c
Remove the useless #for_display proxy method
2019-01-08 12:32:26 +01:00
Pierre de La Morinerie
be1567ecbd
messages: improve wording of the "Send" button
2019-01-07 16:20:23 +01:00
Pierre de La Morinerie
e25bd7139f
layouts: use a common procedure_context
layout for the demarche overview
2019-01-07 15:39:58 +01:00
simon lehericey
7b935a6486
login_token: lets constantize
2019-01-07 08:18:29 +01:00
simon lehericey
5daa565a80
login_token: add missing tests
2019-01-07 08:18:29 +01:00
gregoirenovel
5fa5f2aa37
Bump development gems
...
- rubocop (0.61.1 → 0.62.0)
2019-01-05 11:47:55 +01:00
Pierre de La Morinerie
98127b6778
signature: refactor specs
2019-01-03 17:48:53 +01:00
Pierre de La Morinerie
2c0108190c
spec: fix specs failing randomly
...
This is because creating a procedure attempts to create an admin from
scratch, and fails to do so.
Broken by 802f2086d6
2019-01-03 17:42:43 +01:00
Pierre de La Morinerie
86b9e2d092
stats: fix exception when HelpScout env vars are missing
...
This fixes the stats page, which used to raise an exception when
HelpScout env vars are not present.
2019-01-03 17:27:56 +01:00
Pierre de La Morinerie
d77530c461
Make Procedure state consistent after switching types de champ order
...
Fixes an issue where, after clicking the "move champ up" button,
the new form is rendered with an incoherent order.
2019-01-03 15:13:14 +01:00
gregoirenovel
9466442aff
Remove the TypeDeChamp decorators
2019-01-03 12:08:25 +01:00
gregoirenovel
9c130c41da
Remove ProcedureDecorator
2019-01-03 12:08:25 +01:00
gregoirenovel
b41764ec03
Remove ChampDecorator
2019-01-03 12:08:25 +01:00
gregoirenovel
b8f57415cd
Remove the unused decorator DossierDecorator
2019-01-03 12:08:25 +01:00
gregoirenovel
559df6b82a
Remove the unused decorator ProceduresDecorator
2019-01-03 12:08:24 +01:00
gregoirenovel
4f30e30a08
Remove the unused decorator FranceConnectInformationDecorator
2019-01-03 12:08:24 +01:00
gregoirenovel
0336ecf639
Remove useless arguments from some methods
2019-01-03 10:53:50 +01:00
gregoirenovel
0596d53ac2
Enable the Lint/UnusedBlockArgument cop
2019-01-03 10:53:50 +01:00
gregoirenovel
ddc71cbacf
Enable the Lint/UnderscorePrefixedVariableName cop
2019-01-03 10:53:50 +01:00
gregoirenovel
baf7977786
Enable the Lint/StringConversionInInterpolation cop
2019-01-03 10:53:50 +01:00
gregoirenovel
186e362701
Enable the Layout/SpaceInsideArrayLiteralBrackets
2019-01-03 10:53:50 +01:00
gregoirenovel
386fbce776
Enable the Layout/SpaceBeforeBlockBraces cop
2019-01-03 10:53:50 +01:00
gregoirenovel
8b0b8162f0
Enable the Layout/SpaceAfterComma cop
2019-01-03 10:53:50 +01:00
Chaïb Martinez
802f2086d6
Redirect admins with no démarches to the new demarche page
2018-12-28 18:57:51 +01:00
maatinito
4ad3a60e25
[ Fix #2575 ] Créer automatiquement un compte instructeur aux administrateurs
2018-12-26 09:44:20 -10:00
gregoirenovel
03eb47016c
Fix a gestionnaire sign in bug
2018-12-26 18:14:04 +01:00
maatinito
8304ce12e1
Make some email previews database-independent
2018-12-20 17:07:03 +01:00
maatinito
e1b97b3303
Make more emails previewable
2018-12-20 17:06:57 +01:00
maatinito
e37372d261
Fix a typo
2018-12-20 16:21:27 +01:00
maatinito
9842142a9a
Add InviteMailerPreview
2018-12-20 16:21:27 +01:00
maatinito
a1a11adb83
[ #325 ] Make the notification layout inherit from the general layout
2018-12-20 16:21:27 +01:00
Mathieu Magnin
904d8d208b
[ Fix #3192 ] Fix data
2018-12-20 15:45:48 +01:00
Mathieu Magnin
b40c706d98
[ Fix #3192 ] Clone service if procedure is transferred
2018-12-20 15:45:48 +01:00
Paul Chavard
eb9edc1cee
Order types de champ in scope
2018-12-20 14:14:15 +01:00
Paul Chavard
5d1c24f3d8
Add type de champ repetition models (with row)
2018-12-19 15:31:11 +01:00
gregoirenovel
df7e0a9881
Remove dead code
2018-12-19 14:59:15 +01:00
Frederic Merizen
d1cfe4468d
Encourager la création de champs PJ plutôt que de vieilles PJS
2018-12-19 11:57:23 +01:00
Frederic Merizen
832b4a61bc
Drop CleverCloud Service for ActiveStorage
2018-12-19 10:36:02 +01:00
Frederic Merizen
57a136c861
Make champ PJ generally available
2018-12-18 11:11:23 +01:00
Pierre de La Morinerie
d614ea6bd5
stats: display contact rate
2018-12-18 10:38:59 +01:00
maatinito
af8eee25ad
[ Fix #249 ] added test for too short passwords
2018-12-17 11:14:35 -10:00
Mathieu Magnin
edf3eefa87
Fix Sentry 114, Instructeur can delete pj in private champs
2018-12-13 17:27:05 +01:00
simon lehericey
5a87fad02e
[ fix #3154 ] order export
2018-12-10 16:41:37 +01:00
Pierre de La Morinerie
a0ae1afb45
typhoeus: add a cache store for successful requests
2018-12-10 11:41:07 +01:00
Frederic Merizen
270c7568fa
[ #2180 ] Avoid fetching old PJ modification times separately
...
Speeds up transfer
2018-12-08 15:55:40 +01:00
Frederic Merizen
907e87809b
[ #2180 ] Iterate over storage keys rather than blobs
...
To create less confusion on dev
2018-12-07 15:30:10 +01:00
pedong
f70f276ae9
[ fix #2813 ] set lien_notice nil when clone a procedure
2018-12-06 21:28:08 +01:00
simon lehericey
db6c86b242
DossierController: user can destroy pjs
2018-12-06 10:45:10 +01:00
Frederic Merizen
4699e515ed
[ Fix #2999 ] Send gestionnaire back to what they were doing after email verification
2018-12-06 10:03:21 +01:00
Paul Chavard
ee93b4e33d
Revert legacy carte API to parsed json
2018-12-05 18:19:15 +01:00
Paul Chavard
35494df78e
Procedure export dossiers with champs siret
2018-12-05 17:09:39 +01:00
Pierre de La Morinerie
e206f3d4d4
gestionnaire: display draft procedures in the list
...
Fix #3088
2018-12-05 15:38:20 +01:00
Pierre de La Morinerie
421f125c45
gestionnaire_spec: factorize a assign helper
2018-12-05 15:38:20 +01:00
Paul Chavard
a08f170dbd
Assign users and gestionnaires to commentaires
...
fix #2052
2018-12-05 13:40:57 +01:00
gregoirenovel
121086eedd
Bump rails
2018-12-04 11:16:42 +01:00
gregoirenovel
873bf2fc0f
Tell puma to STFU
2018-12-04 10:35:13 +01:00
gregoirenovel
478fb88618
Bump capybara (2.18.0 → 3.11.0)
2018-12-04 10:35:13 +01:00
gregoirenovel
94b6783a65
Slightly change some tests to comply with puma
2018-12-03 16:28:18 +01:00
gregoirenovel
b3d0a113eb
Use non-breaking spaces in tests
2018-12-03 16:28:18 +01:00
Paul Chavard
e873b6a9c4
Expose selection utilisateur size on champ carte
2018-12-03 12:49:03 +01:00
Paul Chavard
d77a5c9f15
More tests and fixes on carte champ
2018-11-30 13:28:30 +01:00
Paul Chavard
097a15d624
Test and fix all possible cases of champ carte serialization
2018-11-30 12:02:27 +01:00
Paul Chavard
35d2bc36fc
cleanup selection_utilisateur geo_json
2018-11-29 17:10:14 +01:00
Paul Chavard
ca147969ab
Fix number champs validation
2018-11-29 15:12:31 +01:00
Paul Chavard
1883c57c87
Add stable ids to types_de_champ after every update
2018-11-29 11:41:13 +01:00
Paul Chavard
b9af07b845
Add admin support contact form
2018-11-28 16:50:37 +01:00
Paul Chavard
575a437f97
Remove carto from admin/procedure controller
2018-11-27 16:11:25 +01:00
Paul Chavard
1897b2775c
Remove old migration task
2018-11-27 16:11:25 +01:00
Paul Chavard
c6ef30f3e1
Remove unused carto from instructeur interface
2018-11-27 16:11:25 +01:00
Paul Chavard
9ff65efea8
Remove deprecated carto from dossiers controller
2018-11-27 16:11:25 +01:00
Paul Chavard
d988638c58
Simplify API carte serializer
2018-11-27 16:11:25 +01:00
Paul Chavard
36f6f54337
Remove unused carto models
2018-11-27 16:11:25 +01:00
Paul Chavard
5632929d3d
Remove old caro editor
2018-11-27 16:11:25 +01:00
Paul Chavard
37a7e26fc3
Remove unused users/carte_controller
2018-11-27 16:11:25 +01:00
Pierre de La Morinerie
ea8bc0c961
mailers: improve notification layout
2018-11-27 15:51:26 +01:00
Pierre de La Morinerie
4e801b188c
tasks: remove outdated footers in mail templates
...
Fix #1863
2018-11-27 15:32:02 +01:00