[#2180] Do not double-expose migrated type PJs as champs in procedure API

app/serializers/procedure_serializer.rb

@@ -44,6 +44,10 @@ class ProcedureSerializer < ActiveModel::Serializer
     end
   end
 
+  def types_de_champ
+    object.types_de_champ.reject { |c| c.old_pj.present? }
+  end
+
   def types_de_piece_justificative
     ActiveModelSerializers::SerializableResource.new(object.types_de_piece_justificative).serializable_hash +
       PiecesJustificativesService.serialize_types_de_champ_as_type_pj(object)

spec/serializers/procedure_serializer_spec.rb

@@ -41,5 +41,9 @@ describe ProcedureSerializer do
         ]
       )
     end
+
+    it "is not exposed as a type de champ" do
+      expect(subject[:types_de_champ]).not_to include(a_hash_including(libelle: type_pj.libelle))
+    end
   end
 end