[#2180] Do not double-expose migrated type PJ as type champ PJ

app/serializers/dossier_serializer.rb

@@ -26,7 +26,7 @@ class DossierSerializer < ActiveModel::Serializer
   has_many :champs, serializer: ChampSerializer
 
   def champs
-    champs = object.champs.to_a
+    champs = object.champs.reject { |c| c.type_de_champ.old_pj.present? }
 
     if object.expose_legacy_carto_api?
       champ_carte = champs.find do |champ|

spec/serializers/dossier_serializer_spec.rb

@@ -96,5 +96,9 @@ describe DossierSerializer do
         ]
       )
     end
+
+    it "does not expose the PJ as a champ" do
+      expect(subject[:champs]).not_to include(a_hash_including(type_de_champ: a_hash_including(id: migrated_type_champ.id)))
+    end
   end
 end