539 commits

Author	SHA1	Message	Date
simon lehericey	97aac5d588	update tests for rules based routing	2023-05-31 11:38:16 +02:00
Christophe Robillard	ef82149a3b	amelioration(api-entreprise.rna): passe a la v3 pour le endpoint RNA_RESOURCE_NAME	2023-05-31 09:59:44 +02:00
Lisa Durand	a20ec44841	Merge pull request #9074 from demarches-simplifiees/add-more-info-on-procedure-description ... [Refonte page accueil demarche] Détailler la description pour plus de clarté pour l'usager	2023-05-30 09:45:32 +00:00
krichtof	0051face93	Merge pull request #9014 from demarches-simplifiees/8859-default_zones ... Etq admin, lors de la création ou modification d'une démarche, des zones par défaut me sont suggérées	2023-05-26 17:25:21 +00:00
Christophe Robillard	ba281d53cf	migrate entreprise adapter to v3	2023-05-26 13:37:20 +02:00
Lisa Durand	7f53120815	fix specs - forget to remove description in siret context	2023-05-25 16:49:07 +02:00
Lisa Durand	31969b290b	create a new layout without procedure for login and use same layout full_screen without description for identite step	2023-05-25 16:15:31 +02:00
Christophe Robillard	b13e77650e	update default zones after admin creation	2023-05-24 17:40:00 +02:00
Lisa Durand	7340206f81	rollback - add just one new field and use actual description field	2023-05-24 11:31:24 +02:00
Paul Chavard	47f1e27f85	Merge pull request #9032 from colinux/password-email-wording ... Usager: plus de détails sur les raisons qui expliquent pourquoi je ne reçois pas l'email "mot de passe perdu"	2023-05-24 08:30:03 +00:00
Lisa Durand	6274594c70	add new layout to handle new full screen design	2023-05-23 16:49:37 +02:00
Lisa Durand	b6cc35df68	fix specs	2023-05-23 10:34:03 +02:00
Martin	af19bbe8f5	correctif(users/dossiers/brouillon#submit): ETQ usager, je souhaite que chaque lien pointant vers une erreur de champ m'oriente sur le champ	2023-05-20 08:27:55 +02:00
Paul Chavard	d448806ddb	fix(spec): specify vcr cassette for the whole scenario	2023-05-16 17:55:44 +02:00
simon lehericey	0457251cb0	try something different	2023-05-11 16:56:56 +02:00
simon lehericey	4aee0e056d	try to fix autosave spec	2023-05-11 11:52:30 +02:00
Colin Darie	f33fb0a076	refactor(password-reset): improve message not received wording	2023-05-11 09:10:20 +02:00
Colin Darie	79f450a422	Merge pull request #9021 from colinux/feat-en-construction-fork ... ETQ usager, je modifie et soumets à nouveau mon dossier “en construction"	2023-05-10 19:46:40 +00:00
simon lehericey	6d73faf90b	try fix api particulier spec	2023-05-10 10:41:35 +02:00
simon lehericey	3a1614f96d	try fix upload pj spec	2023-05-10 10:41:35 +02:00
Colin Darie	11dd1b7d76	style(autosave): retry button as dsfr	2023-05-09 18:49:52 +02:00
Paul Chavard	08a2a2c9aa	feat(dossier): fork dossier when editing en construction	2023-05-09 17:16:47 +02:00
Lisa Durand	9fd9bdc7c0	add tag to display and remove active filters	2023-05-03 16:47:27 +02:00
Lisa Durand	1ab3dbb864	fix spec adding click on dropdown	2023-05-03 11:04:15 +02:00
Lisa Durand	6113c0b75e	improve/add translations	2023-05-02 15:10:36 +02:00
Lisa Durand	24eca40f66	add from_depose_at filter	2023-05-02 10:32:38 +02:00
Lisa Durand	21ed6abcad	add from_created_at filter	2023-05-02 09:37:03 +02:00
Lisa Durand	39f534b3d7	add states filter for usager	2023-04-28 15:28:04 +02:00
Lisa Durand	aac1cc7161	Merge pull request #8971 from demarches-simplifiees/add-filter-for-usagers ... [fix] Pagination interface usager - onglets disparaissent si pas sur la page 1	2023-04-27 13:46:15 +00:00
Lisa Durand	b76c0a36e8	fix specs	2023-04-27 15:26:10 +02:00
simon lehericey	fcb11e49e1	spec: fix flaky test	2023-04-26 16:51:10 +02:00
simon lehericey	ae1fd3f30b	linter	2023-04-24 10:59:42 +02:00
Martin	8c78008b4d	correctif(usager.depot-dossier): ETQ usager, les titres de section conditionnés etait visible meme si la condition n'etait pas remplie	2023-04-24 10:47:20 +02:00
Martin	ad77b9321b	amelioration(formulaire-usager): groupes les champs suivant un titre de section dans une balise html de type <fieldset> de sorte a améliorer l'accessibilite de la plateforme	2023-04-20 08:22:02 +02:00
Martin	b9faa26560	amelioration(editeur-de-champs): permet de choisir un niveau de titre (de 1 à 3) pour les champs de type Champs::HeaderSectionChamp. Gère les erreurs dans le cas ou un administrateur supprimerait un HeaderSection qui casserait l'ordre des titre [ex: titre 1,2,3. et l'admin supprime le titre 1 et il reste que 2,3].	2023-04-20 08:22:02 +02:00
Paul Chavard	0912a30eb0	feat(dossier): use turbo on select with other	2023-04-18 15:24:23 +02:00
LeSim	c252748833	Merge pull request #8836 from demarches-simplifiees/improve-routing-rules-ux ... feat(routing): nicer and safer ?	2023-04-17 08:23:15 +00:00
Paul Chavard	5abb6a8f12	chore(spec): remove memory store cache from tests	2023-04-13 13:10:23 +02:00
simon lehericey	213d463ff4	feat(routing): small UI polish	2023-04-13 10:28:52 +02:00
Paul Chavard	207ce21327	fix(dossier): instructeur actions should be buttons and not links	2023-04-07 12:12:15 +02:00
Paul Chavard	12f0c03bac	Merge pull request #8847 from tchak/feat-improuve-dossier-remove ... fix(dossier): an invited user can remove (leave) a dossier	2023-04-04 13:10:18 +00:00
Lisa Durand	dde64415ae	Merge pull request #8845 from demarches-simplifiees/remove-dossiers-termines-from-avis-views ... [bug] retirer les notifications + compteur des avis pour les dossiers terminés	2023-04-04 08:20:48 +00:00
Paul Chavard	0864666d0a	fix(dossier): an invited user can remove (leave) a dossier	2023-04-03 20:10:44 +02:00
Lisa Durand	2f012578eb	remove dossier termine from avis views	2023-04-03 18:20:17 +02:00
Paul Chavard	fce78bbf30	feat(dossier): multiselect without react	2023-04-03 16:54:50 +02:00
Paul Chavard	ed62d171ce	fix(commune): improuve label and error message	2023-04-03 11:24:32 +02:00
LeSim	b003fd8be8	Merge pull request #8774 from E-L-T/add-routing-to-groupe-instructeurs ... Add routing rules to groupe instructeurs	2023-03-31 10:16:51 +00:00
Lisa Durand	630742ee94	fix test	2023-03-30 17:54:14 +02:00
simon lehericey	41cb62b5c7	add full system spec	2023-03-30 12:31:48 +02:00
Eric Leroy-Terquem	6f6bbd6ca1	feat(routing): put routing logic behind a feature flag	2023-03-30 10:52:53 +02:00
Eric Leroy-Terquem	6dfe54479d	test(routing): can route from a dropdown list	2023-03-30 10:51:48 +02:00
Paul Chavard	01602101f1	spec(commune): improuve spec	2023-03-29 15:42:33 +02:00
Paul Chavard	00fc2f519f	chore(spec): fix commune spec	2023-03-29 15:42:33 +02:00
Paul Chavard	76da68c3fb	feat(commune): prefill by postal code and insee	2023-03-28 16:34:19 +02:00
Lisa Durand	0424f9dff8	merge avis_list view expert and instructeur	2023-03-27 14:59:49 +02:00
Lisa Durand	aa9c94a20e	fix display in view and export if answer is 'no'	2023-03-22 11:56:52 +01:00
Lisa Durand	4a2982dc37	fix tests and linter	2023-03-22 09:30:26 +01:00
Lisa Durand	f27e362cae	fix validation of yes-no question in avis	2023-03-21 17:07:05 +01:00
Lisa Durand	ee2f795dec	pr feedbacks - add validation for yes/no answer - improve locales use	2023-03-16 11:32:05 +01:00
Lisa Durand	01afa998b6	add specs	2023-03-16 11:32:05 +01:00
mfo	df05c4fbc5	Merge pull request #8754 from mfo/US/fix-duree-conservation-dans-ds ... correctif(procedure.maj): quand la duree conservation dans ds est supérieur a 12, on ne pouvait plus mettre a jour la procedure	2023-03-10 09:28:31 +00:00
Lisa Durand	1f03130d52	Merge pull request #8728 from demarches-simplifiees/revoke-usager-transfert-demande ... [usager] peut révoquer une demande de transfert	2023-03-10 09:21:59 +00:00
Martin	4ac498392c	bug(procedure.maj): impossible de mettre a jour une procedure avec une duree de conservation supérieur a 12 mois	2023-03-10 10:16:36 +01:00
Lisa Durand	efcb783c8c	fix system spec with trad	2023-03-09 14:58:47 +01:00
Colin Darie	c112018ec3	fix(administrateur): tags persistence when non interacting with tags combobox	2023-03-08 11:27:31 +01:00
Lisa Durand	72667cb49a	fix tests	2023-03-02 16:37:05 +01:00
Damien Le Thiec	687c05e6d1	Merge pull request #8622 from demarches-simplifiees/fix/stored_query_issue ... Dossier prefill get without stored queries	2023-03-02 14:01:04 +00:00
Lisa Durand	54f17ad3c7	Merge pull request #8630 from demarches-simplifiees/harmonize-actions-for-instructeurs ... [instructeurs] Uniformiser les actions pour les instructeurs sur la page tableau et dossier	2023-03-02 13:28:23 +00:00
sebastiencarceles	157a2d8cae	feature spec cover	2023-03-01 14:05:18 +01:00
Damien Le Thiec	8a7cb3f1fe	Merge branch 'main' into fix/stored_query_issue	2023-03-01 10:22:40 +01:00
Damien Le Thiec	01f142183e	Add and correct tests	2023-03-01 10:21:22 +01:00
sebastiencarceles	f52554b5a3	review: update value with async fetch ... 1 - spec cover the job which fetches external data 2 - refactor the job with guard clauses 3 - delegate update operation to the champ itself 4 - annuaire education: override the update operation to let the value be populated by the fetched data 5 - prefilling: don't fetch data synchronously	2023-02-28 14:53:08 +01:00
sebastiencarceles	8b25503f7e	feature spec cover	2023-02-28 14:23:38 +01:00
sebastiencarceles	8f12467168	feature spec cover	2023-02-27 15:18:37 +01:00
sebastiencarceles	1caf56d943	fix lint	2023-02-27 14:48:46 +01:00
sebastiencarceles	efd5464bd5	cover use case with feature spec	2023-02-27 14:43:48 +01:00
sebastiencarceles	becf4da70a	fix raison social fetch	2023-02-27 13:54:35 +01:00
sebastiencarceles	498e5d7487	cover use case with a feature spec	2023-02-27 13:53:18 +01:00
sebastiencarceles	bd1bed940c	feature spec cover	2023-02-27 12:20:11 +01:00
Damien Le Thiec	67bbacbb05	Merge pull request #8513 from demarches-simplifiees/feature/prefill_repetible ... Prefill repeatable	2023-02-27 09:58:53 +00:00
Lisa Durand	6487e2c27e	implement turbostream back for state change in dossier view	2023-02-24 17:54:53 +01:00
Lisa Durand	90a7ecef52	rename state button to instruction button	2023-02-23 16:05:38 +01:00
Martin	c00c4936b2	correctif(a11y): traite aussi les avis d'expert avec la nouvelle methode de rendu des textes saisis par des admin/instructeur/expert	2023-02-23 15:23:20 +01:00
Damien Le Thiec	731cd56594	Merge branch 'main' into feature/prefill_repetible	2023-02-22 19:49:06 +01:00
Damien Le Thiec	fbe4fe251a	Fix format prefill repetition	2023-02-22 19:32:25 +01:00
Lisa Durand	fddcce8b7b	fix specs	2023-02-22 18:17:06 +01:00
Damien Le Thiec	2052bc7840	Remove dependency type_de_champ -> procedure	2023-02-21 16:00:58 +01:00
Eric Leroy-Terquem	343cb5fce6	feat(groupe instructeur mailer): add emailing to added instructeurs	2023-02-20 15:41:19 +01:00
Martin	5e10e680dc	chore(spec): corrige les spec cassées et remanie un peu des specs ecrites	2023-02-20 11:47:14 +01:00
Martin	a89f5d373f	amelioration(procedures#filtres): filtre par regions avec un enum sur la collection des regions normalisés	2023-02-20 11:47:14 +01:00
Martin	68de0c6566	correctif(procedures#filtres): le filtre par departement ne fonctionnait plus. utilise un enum sur la collection des departements possible normalisés	2023-02-20 11:47:14 +01:00
Damien Le Thiec	dce4c84f9a	Merge branch 'main' into feature/prefill_repetible	2023-02-16 17:08:30 +01:00
sebastiencarceles	a3ca79076e	cover the use case with feature specs	2023-02-16 10:49:15 +01:00
Damien Le Thiec	539b9e4f10	Merge branch 'main' into feature/prefill_repetible	2023-02-15 17:53:06 +01:00
Damien Le Thiec	4876d583b6	Merge branch 'main' into feature/prefill_repetible	2023-02-15 17:39:19 +01:00
Damien Le Thiec	4b3d403d7e	fix spec	2023-02-15 17:14:29 +01:00
sebastiencarceles	8aa31522b6	cover feature with specs	2023-02-15 12:14:11 +01:00
Martin	c45f15ff61	correctif(procedure/all.xsls): deconnecte le lien de telechargement de toutes les demarche de turbo	2023-02-15 11:26:21 +01:00
Damien Le Thiec	dbb92e7fd3	Merge branch 'main' into feature/prefill_repetible	2023-02-11 22:40:56 +01:00
Damien Le Thiec	4b0e6ea382	Convert datetime field to datetime_local (#8572) ... * Convert datetime field to datetime_local * Fix tests * Add value formatting view datetime component * Add helper datetime component value	2023-02-09 15:18:38 +01:00
sebastiencarceles	7a254d124f	feature spec cover	2023-02-09 13:51:52 +01:00
Kara Diaby	f212fa1008	Permet de cloner une démarche depuis la page toutes les démarches	2023-02-09 08:28:30 +00:00
Paul Chavard	6924b8e46d	feat(dossier): optional repetition champ should not add first row	2023-02-06 11:53:32 +01:00
Lisa Durand	f80fe9680f	corrections from Sim review	2023-02-03 15:13:06 +01:00
Lisa Durand	fcd5b38a28	fix spec broken because new line in html table	2023-02-03 15:13:06 +01:00
Lisa Durand	f1a378bf03	dont'use DSFR component - add a line inside the table instead	2023-02-03 15:13:06 +01:00
Lisa Durand	9aa6c55d1f	replace partial by component	2023-02-03 15:13:06 +01:00
Lisa Durand	1a79eb9717	change checkbox tag to hidden field	2023-02-03 15:13:06 +01:00
Lisa Durand	93a85ca4b0	add limit of 500 dossiers	2023-02-03 15:13:06 +01:00
Damien Le Thiec	63e7c17fda	First tests for prefill repetition	2023-02-03 12:14:18 +01:00
Colin Darie	fa0f72aaba	feat(procedure): hide estimated fill duration when super admin disabled it ... Closes #8466	2023-02-01 11:02:55 +01:00
Martin	4f4791a864	bug(liens-invitation): ne devrait pas pointer sur l'avis ayant le même id que l'invitation	2023-01-31 16:33:31 +01:00
Colin Darie	3265fff30e	fix(dropdown): wait "other" input to be disabled before autosave ... Fix le workflow suivant pour un champ drop down avec option "autre" : - on choisit la valeur "autre" avec une valeur => ça autosave la bonne valeur - on choisit finalement une autre valeur proposée => l'autosave envoyait la nouvelle valeur, et toujours la valeur "other" car l'input n'était pas encore `disabled`. Par conséquent la valeur other overridait la valeur choisie et ça provoquait des erreurs en cascade, notamment dans le conditionnel.	2023-01-30 12:16:25 +01:00
Martin	9a12b97424	amelioration(expert/avis/header): passe d'un dropdown avec un element pour telecharger le dossier au composant dsfr de telechargement de fichier	2023-01-26 11:13:23 +01:00
Martin	2be0f5aa99	amelioration(menu): extraction des menu dans un composant ruby pour ne pas dupliquer les changements aria partout ds la codebase	2023-01-26 11:13:23 +01:00
Martin	8528939b75	correctif(champs/repetitions#remove): les row id etant des ulid commence par un int. utiliser l'ulid comme selecteur css n'est pas valide. il faut donc avoir un selecteur CSS 'safe', et envoyer le row_id	2023-01-19 10:48:01 +01:00
Paul Chavard	44488c7014	feat(dossier): use select in filters bygroupe instructeur	2023-01-16 14:00:08 +01:00
Damien Le Thiec	5e26acb0e1	Make date and datetime prefillable (#8304) ... * Make date and datetime prefillable * Format in ISO8601 format	2023-01-12 17:42:02 +01:00
Paul Chavard	289d48f697	refactor(js): use autosubmit controller in filter_component	2023-01-12 11:58:46 +01:00
simon lehericey	9043bed3a0	refactor(procedure_presentation): add required tags	2023-01-11 14:05:17 +01:00
François Vantomme	fe518fed8c	refactor(links): move FAQ from footer to common scope	2023-01-11 11:28:03 +01:00
François Vantomme	faa5dda761	refactor(links): use FAQ URL locale everywhere	2023-01-11 11:28:03 +01:00
Lisa Durand	7abf51ca81	split filter in 2 partials too display filters tags on its own div to have more spaces	2023-01-10 18:05:23 +01:00
François Vantomme	0e3fe055e4	fix(archive): typo on flash notice	2023-01-10 17:23:48 +01:00
Lisa Durand	080747f60b	reorganise multiple buttons on top of table from instructeur procedure view	2023-01-05 17:22:53 +01:00
Sébastien Carceles	fa6fc077b4	normalize boolean values (#8320) ... * extract parent for yes no and checkbox champs * checkbox stores true / false instead of on / off * normalize blank value to nil * normalize invalid value to false * after party task: normalize checkbox values * after party task: normalize yes_no values	2023-01-05 11:18:27 +00:00
Colin Darie	b89fc16999	style(instructeurs/expiration): convert banner to DSFR	2023-01-04 13:15:10 +01:00
Paul Chavard	6e18090fb3	refactor(virus_scan_result): use column instead of metadata on blob	2023-01-04 12:12:11 +01:00
Sébastien Carceles	456be420fa	feat(demarche): describe dossier prefilling with POST (#8298) ... * feat(demarche): describe dossier prefilling with POST * show response example	2023-01-04 07:31:31 +00:00
Martin	a4d6692bc6	accessibilite(pages-authentification): evolutions des pages de connexion/creation de compte pour respecter le DSFR et supporter une meilleure accessibilite ... Update app/components/dsfr/input_component/input_component.html.haml Co-authored-by: Colin Darie <colin@darie.eu>	2023-01-03 16:26:05 +01:00
Sébastien Carceles	20136b7ac8	feat(demarche): create and prefill a dossier with POST request (#8233) ... * add base controller for public api * add dossiers controller with basic checks * create the dossier * ensure content-type is json * prefill dossier with given values * mark a dossier as prefilled When a dossier is prefilled, it's allowed not to have a user. Plus, we add a secure token to the dossier, which we will need later to set a user after sign in / sign up. * set user as owner of an orphan prefilled dossier When a visitor comes from the dossier_url answered by the public api, the dossier is orphan: - when the user is already authenticated: they become the owner - when the user is not authenticated: they can sign in / sign up / france_connect and then they become the owner So here is the procedure: - allow to sign in / sign up / france connect when user is unauthenticated - set dossier ownership when the dossier is orphan - check dossier ownership when the dossier is not - redirect to brouillon path when user is signed in and owner * mark the dossier as prefilled when it's prefilled (even with a GET request, because it will be useful later on, for exmample in order to cleanup the unused prefilled dossiers) * system spec: prefilling dossier with post request	2023-01-03 14:46:10 +01:00
Martin	69aed18b46	correctif(instructeurs/dossier#telecharger_pjs): ne pas inclure les bills et horodatage quand on telecharge un dossier unitairement	2022-12-26 17:11:10 +01:00
Paul Chavard	00218fded2	fix(dossier): update spec	2022-12-21 14:03:02 +01:00
Christophe Robillard	00536b949a	fix system specs by adding zone for new procedure	2022-12-21 09:02:16 +01:00
Christophe Robillard	f4977f358b	fix spec procedure_cloning ... add zone to new procedure	2022-12-21 09:02:16 +01:00
Colin Darie	c673950e56	fix(instructeurs): behavior of sort by notifications checkbox (updated_at desc)	2022-12-20 15:51:47 +01:00
Sébastien Carceles	0a10a08c21	feat(demarche): describe procedure prefilling (#8187) ... * feat(demarche): description Show the description of an opendata procedure (published or draft), with help about how to prefill a dossier for this procedure. Co-authored-by: Damien Le Thiec <damien.lethiec@gmail.com>	2022-12-19 11:32:09 +00:00
Martin	2be4441a70	amelioration(attestion.et.mail): deduplique les message d'erreur, améliore les messages d'erreur, gère la pluralisation des erreurs lorsque plusieurs tags sont concernés	2022-12-19 09:28:46 +01:00
Martin	ef389eab41	amelioration(attestation.et.mail): repositionne les messages d'erreur lié à la substitution des balises a proximité du formulaire pour faciliter la comprehension. passage des champs au DSFR	2022-12-19 09:28:46 +01:00
Eric Leroy-Terquem	2645ac85f7	update wording and order in types de champ select	2022-12-16 09:30:36 +01:00
Paul Chavard	cb5b60ccda	Revert "Revert "Merge pull request #7907 from tchak/feat-cond-repetitions"" ... This reverts commit 0d10d36cb0. # Conflicts: # app/models/dossier.rb # app/models/dossier_preloader.rb	2022-12-15 19:09:25 +01:00
Lisa Durand	2fff6faed6	fix checkbox rendering in all pages	2022-12-15 14:46:05 +01:00
Sébastien Carceles	b8ff0ba4a2	feat(demarche): sign up when prefilling a dossier (#8247) ... * store prefill params in session Instead of using query params on /dossier/new, we assume the user comes from /commencer/:path, which is the new prefill link. There, we store the prefill params in session, and use them to prefill the dossier when creating it, in /dossiers/new. * spec: cover the case * review: serialize with json instead of yaml * review: rename method * review: store only query params * review: comment why we dont override already stored params	2022-12-15 10:58:17 +01:00
Colin Darie	7ff6455440	style(instructeurs): convert filters to DSFR tags	2022-12-15 09:34:10 +01:00
Colin Darie	3a9a71079a	Merge branch 'main' into pj-en-construction-replace	2022-12-14 16:59:48 +01:00
Paul Chavard	0d10d36cb0	Revert "Merge pull request #7907 from tchak/feat-cond-repetitions" ... This reverts commit 1900f8ff4c, reversing changes made to febffc2d64. # Conflicts: # app/models/dossier.rb	2022-12-14 11:25:45 +01:00
Colin Darie	013a05f24a	feat(piece_justificative): replace with multiple attachments for dossier en_construction	2022-12-14 09:58:15 +01:00
sebastiencarceles	bfdba0c513	review: system spec	2022-12-08 15:27:39 +01:00
Paul Chavard	16a48c02aa	feat(cond): add tests	2022-12-08 09:38:12 +01:00
Colin Darie	8cf8c2c88a	test(attachment): maybe fix flaky test	2022-12-06 16:37:11 +01:00
Martin	7c65af3be0	poc(batch_operation_alert): simplier wording	2022-12-06 11:28:48 +01:00
Lisa Durand	3d2f0ebb88	add icon on submit button and simplify i18n	2022-12-06 11:28:48 +01:00
Martin	6556fda218	clean(spec): rubocopify / fix specs	2022-12-06 11:28:48 +01:00
Martin	5875f9b572	spec(batch_operation): system spec batch operation poc	2022-12-06 11:28:48 +01:00
Colin Darie	53d4395cbd	test(attachments): system test for multiple attachments upload	2022-12-05 10:47:10 +01:00
Colin Darie	cb2afc74b0	style(attachments): better UX when we can try to upload without network	2022-12-05 10:47:10 +01:00
Colin Darie	b13c5e56f6	refactor(piece_justificative): UX follows mockups	2022-12-05 10:47:10 +01:00
Colin Darie	52b6502cbd	test(a11y): ensure we don't mix aria-label and title on main pages ... Actuellement, on fait le choix de ne pas avoir d'éléments porteurs à la fois d'aria-label et title. Bien qu'en principe l'aria-label quand elle est gérée par un navigateur, prenne précédence sur le title, en pratique un bug dans NVDA cumule les 2 et rend la navigation difficile. On prend donc le parti (provisoire?) de n'avoir que l'un ou l'autre. Nous gardons le title si l'info qu'il contient est également pertinente pour les navigateurs graphiques qui l'affichent en guise de tooltip ; autrement on bascule sur l'aria-label qui est plus largement supporté par les navigateurs a11y.	2022-12-05 10:38:16 +01:00
Paul Chavard	00556715d6	fix(typography): fix quotes	2022-12-01 17:59:11 +01:00
Colin Darie	acdd0b2350	test(a11y): verify on basic pages external link say it will open a new tab	2022-11-30 09:27:46 +01:00
Colin Darie	f625d99934	chore(dossier_transfer): extract i18n	2022-11-25 13:34:12 +01:00
sebastiencarceles	c294ce70ca	fix: escape characters when showing page title	2022-11-25 09:30:20 +01:00
Paul Chavard	cafda4f6f0	refactor(attestation_template): move to procedure	2022-11-23 12:26:26 +01:00
Paul Chavard	ff470ada48	fix(dossier): fix dossier brouillon spec	2022-11-23 11:56:35 +01:00
simon lehericey	f532eee9f6	fix(spec): remove strange click	2022-11-22 16:41:20 +01:00
Paul Chavard	29bdd82b59	refactor(procedure): types_de_champ -> active_revision.types_de_champ_public	2022-11-17 13:54:14 +01:00
Martin	05dcf5e7cf	amelioration(usager.liste_des_dossier): ajout du bouton pour cloner un dossier	2022-11-14 09:13:54 +01:00
Paul Chavard	e6288c39f2	refactor(dossier): champs -> champs_public	2022-11-10 22:44:39 +00:00
Martin	571452c530	bug(a11y.dropdown): la dropdown d'aide usager sur une procedure n'est pas a11y compatible	2022-11-08 16:40:17 +01:00
Martin	48b12d03f6	spec(wcag_usager_spec): add test on dropdown. broken 🤭	2022-11-08 16:40:17 +01:00
Martin	3f37102f97	spec(wcag_usager_spec): add test to dossiers_path with at least one dossier	2022-11-08 16:40:17 +01:00
Martin	0a4f17d245	chore(wcag_usager_spec): remove skips	2022-11-08 16:40:17 +01:00
Paul Chavard	f47b39f389	fix spec	2022-11-07 13:34:58 +00:00
Paul Chavard	7de52d582a	feat(conditional): remove conditional feature flag	2022-11-04 13:37:37 +00:00
Eric Leroy-Terquem	63ae328bee	update wording and cards order	2022-11-04 12:03:43 +01:00
Eric Leroy-Terquem	b419c48262	toggle routing when adding or deleting groupe_instructeurs	2022-11-04 12:03:43 +01:00
Eric Leroy-Terquem	09c5b9dc99	remove categories_type_de_champ feature flag	2022-11-03 14:28:27 +01:00
simon lehericey	e7666e274f	fix(spec/system): wait for merci page	2022-10-28 14:51:41 +02:00
simon lehericey	d859f1ed0a	fix(spec/system): add delay when dealing with pj	2022-10-28 14:51:41 +02:00
Martin	c7c46c9dff	design(page de configuration de procedure): passage de la grille au DSFR	2022-10-27 14:00:44 +02:00
simon lehericey	0a1ab733b6	refactor(spec): stabilize api_particulier_spec	2022-10-25 14:44:43 +02:00
simon lehericey	00d1552060	clean(spec): remove useless autosave	2022-10-25 14:44:43 +02:00
Eric Leroy-Terquem	2147a1865c	add test	2022-10-13 19:49:32 +02:00
Paul Chavard	dd38fa4458	refactor(spec): add wait_for_autosave helper	2022-10-13 14:44:46 +02:00
Paul Chavard	03c714e86d	test(flipper): cleanup flipper calls in tests	2022-10-12 14:14:30 +02:00
Colin Darie	10917af523	style: signin button styled accordingly to UX	2022-10-11 09:50:21 +02:00
Eric Leroy-Terquem	ff2e9f0816	add feature flag	2022-10-05 09:21:08 +02:00
Martin	aceb8996c1	feat(instructeur/procedure#show): enhance sort by notifications as planned by UX ... Update app/javascript/controllers/checkbox_controller.ts Co-authored-by: Paul Chavard <github@paul.chavard.net>	2022-09-30 10:29:51 +02:00
simon lehericey	7a9c5e8d19	refactor(ujs): turbo use an id for turbo_stream.update id not a class	2022-09-29 17:04:15 +02:00
Martin	17ed80b18a	clean(Champs::Engagement): migrate to Champs::Checkbox, some for TypeDeChamp	2022-09-27 19:09:28 +02:00
Martin	ba6c5b4db7	feat(instructeur/procedure#index): enhance filter to support processed_at and state [plus en_instruction_at/since] ... feat(filter): enable filter on dossiers.state, dossiers.processed_at(since), dossiers.en_instruction_at(since)	2022-09-27 17:19:54 +02:00
Colin Darie	7e1c542807	fix: FranceConnect button was not visible anymore, convert to DSFR	2022-09-21 09:28:54 +02:00
Paul Chavard	d6f5be622c	feat(dossier): autosave en construction	2022-09-08 11:26:29 +02:00
sebastiencarceles	b643660017	'Choix parmi une liste' becomes 'Choix unique' ... closes #7374	2022-09-06 11:26:30 +02:00
Martin	df3ef23f7e	fix(spec): 1. visit new_user_session_path instead of navigating to it. 2. change way to submit search according to dsfr html. 3. avoid nav without aria label. 4. various lint fixes	2022-09-06 10:09:12 +02:00
Martin	73f94b9635	feat(header): switch to DSFR translate component and dropdown component	2022-09-06 10:09:12 +02:00
Martin	96cdae0dd5	feat(DSFR.header): switch to DSFR header	2022-09-06 10:09:12 +02:00
Martin	549eda6fe3	feat(DSFR.breadcrumb): switch to DSFR breadcrumb style since it is part of new service UI	2022-09-06 10:09:12 +02:00
Martin	289b8f78b8	feat(Administrateur::Services#index): rework list of services	2022-08-31 14:56:00 +02:00
Martin	51680b11c2	feat(Adminstrateur::Procedures#clone): redirect to home of procedure with special info regarding procedure presentation & service	2022-08-31 14:56:00 +02:00
Martin	c230db1ec4	bug(brouillon.edit.form): when their is a type de champs repetition having a child being mandatory. if the condition is not met, should be able to submit form	2022-08-24 15:18:05 +02:00
Martin	e35da17ce8	bug(instructeurs/archives#create): month should not be nil	2022-08-23 15:31:17 +02:00
Martin	dc524cf615	fix(spec): broken spec due to TDD and refacto on former code	2022-08-23 13:28:10 +02:00
Martin	711b2ee2e4	feat(ExportComponent): only render it when connected instructeur/administrateur is not from manager	2022-08-23 13:28:10 +02:00
Martin	25c0e91d87	feat(Administrateurs::GroupeInstructeur): ensure admin from super admin can not add an instructeur	2022-08-23 13:28:10 +02:00
Martin	d1544bc4ae	feat(Administrateurs::ProcedureAdministrateurs): ensure admin from super admin can not add administrateur	2022-08-23 13:28:10 +02:00
simon lehericey	6b5f38ce74	spec	2022-08-11 14:03:04 +02:00
simon lehericey	00d0813292	ensure the mandatory star hint is always displayed	2022-08-09 10:29:41 +02:00
simon lehericey	898badb579	a champ is mandatory when visible with a mandatory tdc	2022-08-09 10:25:47 +02:00
simon lehericey	ec40836589	spec	2022-08-08 18:02:28 +02:00
simon lehericey	0b90c81c3a	wrap existing spec in specific context	2022-08-08 18:02:28 +02:00
Paul Chavard	2d7803cd48	refactor(spec): use new procedure.types_de_champ factory	2022-08-04 12:10:32 +02:00
Colin Darie	9ebcbbbd67	test(brouillon_spec): fix random errors due to db champs not yet updated	2022-08-03 16:15:40 +02:00
Colin Darie	e8b088c2c5	test(brouillon_spec): remove unecessary manual sleep, improve "brouillon" feedback testing	2022-08-03 16:15:39 +02:00
Colin Darie	81a9258c8a	test(brouillon_spec): use capybara wait matchers	2022-08-03 16:15:39 +02:00
Colin Darie	983815bfe8	test(brouillon_spec): fix frequent dossier_link error by using an existing dossier	2022-08-03 16:15:39 +02:00
Paul Chavard	f48048179c	fix(conditional): enable conditional per procedure	2022-08-03 09:16:10 +02:00
simon lehericey	0d3856e84a	fix(conditional): handle incorrect user input	2022-07-22 15:55:43 +02:00
Martin	87af7f3261	feat(exports): implement admin export	2022-07-20 14:08:33 +02:00
simon lehericey	d1e3a0d29f	spec	2022-07-20 11:23:57 +02:00
Paul Chavard	982e604b07	feat(dossier): test check conditions on en construction dossier	2022-07-12 18:32:03 +02:00
Paul Chavard	120b593015	feat(dossier): toggle conditional champs visibility	2022-07-12 17:33:42 +02:00
simon lehericey	28a18e3912	spec: prove annotation is broken	2022-07-12 14:17:05 +02:00
Paul Chavard	a4681d8832	refactor(autosave): improuve events handling	2022-07-12 11:47:33 +02:00
Colin Darie	8c08d0295b	Revert "feat(champ): customizable placeholders for text & textarea champs" ... This reverts commit 9e26ee932e. Finalement les champs génériques ne doivent pas avoir de placeholder personnalisable, ce sera uniquement via la description.	2022-07-12 11:37:58 +02:00
simon lehericey	9bd1d97ed7	add feature flag	2022-07-12 10:44:40 +02:00
simon lehericey	e9cf41a00d	add system spec	2022-07-12 10:44:40 +02:00
Paul Chavard	b8db929e62	fix(a11y): add id to drop_down_other	2022-07-12 08:43:17 +02:00
Colin Darie	9e26ee932e	feat(champ): customizable placeholders for text & textarea champs ... Closes #7429	2022-07-11 17:16:20 +02:00
Colin Darie	9768f4e1c9	style(champ): add placeholders for email, iban, phone, siret champs ... Closes #7428	2022-07-11 17:16:19 +02:00
Martin	4c0aac8e0c	fix(linked_dropdown/dropdown): for dropdown_list, drop blank option because rails add it when the field is required. kind of same behaviour for linked_dropdown_list [but requires to manage it on the front too]	2022-07-11 14:47:26 +02:00
Martin	7ad47f3eae	bug(linked_dropdown/dropdown): dropdown_list : when mandatory, add an extra blank option. linked_dropdown_list : when mandatory and not filled, add an extra blank option to first list, then when select an element from the first list, another extra blank.	2022-07-11 14:47:26 +02:00
Martin	7fb85c97cb	feat(Administrateur::ArchivesControllers): add archives #index and #create for admin	2022-07-04 14:18:46 +02:00
Martin	ea71908850	fix(ChampEditor): add missing drop_down_other for type_de_champ.drop_down_list_with_other?	2022-06-27 17:19:10 +02:00
Martin	ab4d4c83a8	feat(GroupeInstructeurs.closed): add closed option to GroupeInstructeur in order to prevent usagers to submit dossier	2022-06-20 16:32:06 +02:00
Martin	274b5eab2e	feat(invite): wrap invitation with targeted_user_links	2022-06-17 16:44:37 +02:00
Paul Chavard	6801b04b7b	feat(type_de_champ): type_de_champ editor in stimulus/turbo	2022-06-17 11:04:09 +02:00
Paul Chavard	564daeffe8	perf(dossier): improuve dossier preloading perf	2022-06-14 09:04:26 +01:00
Kara Diaby	1f2f148464	tests	2022-06-08 14:38:17 +02:00
Martin	7ed9d586cf	fix(drop_down_list): ensure to skip disabled input when sending data via autosave	2022-06-02 09:06:37 +02:00
Pierre de La Morinerie	c1616adf8c	app: remove procedure-estimated-fill-time feature-flag ... The feature is now enabled for every procedure. Ref #7338	2022-06-01 11:11:55 +02:00
Pierre de La Morinerie	2b90d7cc01	helpers: allow champ without persisted dossier ... This fixes the /patron page. I also added an end-to-end test to avoid breaking this page in the future.	2022-05-31 15:12:29 +02:00
Martin	cb890343ff	feat(targeted_user_link): add targeted user link to wrap expert invitation in order to avoid access issue when the expert is connected with another account ... feat(user.merge): ensure to merge user.targeted_user_link Update app/models/targeted_user_link.rb Co-authored-by: LeSim <mail@simon.lehericey.net> Update app/models/targeted_user_link.rb Co-authored-by: LeSim <mail@simon.lehericey.net> Update app/models/targeted_user_link.rb Co-authored-by: LeSim <mail@simon.lehericey.net> feat(db/create_targeted_user_links): ensure not null with fk	2022-05-31 14:50:31 +02:00
Paul Chavard	02675a104d	fix(revision): fix tests to use new revison system	2022-05-31 08:58:53 +02:00
Pierre de La Morinerie	c738d7d07f	js: display estimated duration in champ editor	2022-05-25 21:50:49 +02:00
Pierre de La Morinerie	736ef10bb3	spec: cleanup system/types_de_champ_spec.rb	2022-05-25 21:50:49 +02:00
Pierre de La Morinerie	4fcb85fd65	app: remove procedure_dossier_papertrail feature flag ... The feature is now enabled for all procedures.	2022-05-24 17:32:11 +02:00
simon lehericey	5767c9b97e	fix test	2022-05-18 10:11:31 +02:00
Martin	ad5c659f88	bug(instructeurs/dossiers#destroy): redirect on destroyed dossier -> NotFound	2022-05-17 11:42:10 +02:00
Paul Chavard	142e6c032c	cleanup(dossier): remove legacy menu	2022-05-11 11:01:25 +02:00
Paul Chavard	c9b8d43acd	feat(autosave): use new autosave controller	2022-05-10 18:10:20 +02:00
Martin	3737311390	feat(procedure.procedure_expires_when_termine_enabled): enable by default, allow contributor to choose the default settings of this flag using an env var during migration. ie: DEFAULT_PROCEDURE_EXPIRES_WHEN_TERMINE_ENABLED=true|false ... feat(administrateurs/procedures#show): warning/alert when procedure_expires_when_termine_enabled is not true on current procedure feat(administrateur/procedure#update): after an update redirect to procedure show: suggested by: https://ux.stackexchange.com/questions/55291/after-updating-form-should-redirect-back-to-form-itself-or-to-the-show-page-or-b and confirmed by Olivier clean(Flipper.archive_zip_globale): no more in use, so remove all occurences Update app/views/administrateurs/procedures/_suggest_expires_when_termine.html.haml Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com> Update app/views/administrateurs/procedures/_suggest_expires_when_termine.html.haml Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com> Update app/views/administrateurs/procedures/_suggest_expires_when_termine.html.haml Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com> Update spec/views/administrateurs/procedures/show.html.haml_spec.rb Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com> fix(review): typo, why ena?, who knows fix(env.example.optional): add missing DEFAULT_PROCEDURE_EXPIRES_WHEN_TERMINE_ENABLED	2022-05-05 13:07:11 +02:00
Pierre de La Morinerie	7109e2d4e6	views: add a link to the deposit receipt	2022-05-04 16:09:52 +02:00
Paul Chavard	2d1370d123	refactor(champ): simplify repetition champ	2022-05-03 16:14:54 +02:00
Martin	3c0e3f725d	feat(administrateur/procedures#publication): show dubious to administrateur ... Update app/views/administrateurs/procedures/publication.html.haml Co-authored-by: Paul Chavard <paul.chavard@beta.gouv.fr>	2022-04-27 15:13:22 +02:00
simon lehericey	579578cf0c	fix system spec	2022-04-12 12:05:08 +02:00
Paul Chavard	e82dc9c8b5	feat(exports): add ability to create exports with filters	2022-04-06 17:08:38 +02:00
Paul Chavard	a50d07400e	refactor(instructeur): cleanup destroy / restore routes	2022-03-11 14:06:34 +01:00
Pierre de La Morinerie	8786b60285	specs: fix flaky "dossier brouillon" spec ... When filling all the champs of a dossier, we skip the "Address" champ (because it would attempt to request a blocked URL). But that means the "Yes/No" radio buttons may be under the sticky bottom bar, and thus not register the click – which makes the test fail. Fix the issue by manually scrolling to the radio buttons.	2022-02-15 15:04:49 +01:00
François Vantomme	9ff7fa73e4	Fix (Expert): clear emails before feature tests ... Failures: 1) Inviting an expert: as an Instructeur I can invite an expert Failure/Error: invitation_email = open_email(expert.email.to_s) Diff: -/procedures/2/avis/2/sign_up/email/expert1@expert.com +/procedures/1/avis/1/sign_up/email/expert1@expert.com	2022-02-04 17:40:03 +01:00
Pierre de La Morinerie	d680602c84	models: validate private types_de_champ	2022-02-01 12:37:16 +01:00
Pierre de La Morinerie	e8e37cce15	models: refactor the types_de_champ validators ... Context: we want to validate public and private types_de_champ separately. Before we validated the whole revision (and then validators themselves enumerated all champs, public and private). Now we validate the actual public types_de_champ, which will let us validate separately the private types_de_champ.	2022-02-01 12:37:16 +01:00
Paul Chavard	7e81b257b1	test(system): simplify select menu selector	2022-01-13 17:49:16 +01:00
Martin	a9ffaf942e	feat(attestation): can enable/disable attestation no matter the state of the procedure	2022-01-05 18:20:11 +01:00
Paul Chavard	cb66348916	a11y(select): cleanup select helpers in specs	2022-01-05 12:33:40 +01:00
Kara Diaby	598cb09c6d	tests	2021-12-29 17:37:58 +01:00
François Vantomme	14e0c68266	feat(api particulier): add MESRI field	2021-12-16 16:45:18 +01:00
simon lehericey	3bdf6b63d9	small wording fixes	2021-12-08 11:19:30 +01:00
François Vantomme	6ab8ac0662	feat (api particulier): add Pole emploi field	2021-12-08 10:36:25 +01:00
François Vantomme	2110ef072c	feat(api particulier): add DGFiP field	2021-12-07 11:03:05 +01:00
Paul Chavard	2ba05bfb4f	fix(dossier): use depose_at instead of en_construction_at	2021-12-06 15:49:17 +01:00
Martin	081d5094a9	feat(instructeurs/procedure/dossiers#extend_conservation): add extends duree conservation in action button list, also rewire this action for user [extend by procedure.duree_conservation_dans_ds by default] but force 1.month for instructeur. add new icon for standby based on https://en.wikipedia.org/wiki/Power_symbol	2021-12-06 07:20:01 +01:00
Martin	725521c3a1	fix(expiration_banner): only show expirations info when flip is enabled ... fix(lint): lint haml fix(spec): enable flipper and allow procedure to receive flipper check when checking banner presence fix(doc): add missing documentation on readme regarding system testing with a visual feedback fix(typo): add missing accent clean(PR): feedback from Tchak, better to wrap feature check for expirability by procedure within dossier.expirable? helper	2021-11-30 16:05:32 +01:00
Pierre de La Morinerie	b86dec8251	views: prevent procedure publication on validation error	2021-11-30 13:34:41 +01:00
Pierre de La Morinerie	9db62178d2	views: display revision errors on the procedure dashboard	2021-11-30 13:34:41 +01:00
Pierre de La Morinerie	93124195fc	specs: refactor procedure_creation_spec.rb ... - Improve wording of specs description - Remove publication test (duplicate of procedure_publish_spec.rb)	2021-11-30 13:34:41 +01:00
Pierre de La Morinerie	8e69a9883b	specs: avoid using french in procedure_publish_spec.rb	2021-11-30 13:34:41 +01:00
simon lehericey	5a0fb6237f	😭 AASM does not support keyword arguments ... https://github.com/aasm/aasm/issues/672	2021-11-30 09:42:45 +01:00
Pierre de La Morinerie	184a401182	app: rename new_administrateur to administrateurs	2021-11-30 08:49:38 +01:00
mfo	e7d9d047fe	Merge branch 'main' into 6649-etq-usager-instructeur-rendre-la-suppression-plus-visible	2021-11-24 14:07:32 +01:00
Pierre de La Morinerie	970c3e4b2b	specs: avoid executing business logic in Procedure factory ... Calling business logic in a factory is a code-smell, because it usually requires the object to be saved into database, and may have unintended consequences when the business logic is changed. Also, this allows to just build a published procedure, without saving it to the database.	2021-11-23 08:07:07 +01:00
Martin	b6adf5fc72	feat(dossiers/show): enhance header with expirations message/banner. also ensure consistent design between dossier states ... fix(spec): broken due to last refactoring spec(dossier.extend_conservation): add system spec lint(ruby): still not yet ready for auto lint in IDE...	2021-11-23 05:50:25 +01:00
Pierre de La Morinerie	9dd7806ae5	specs: add two missing fields to the brouillon spec	2021-11-09 15:22:20 +01:00
Pierre de La Morinerie	5dbb9f9e3c	specs: fix flaky "dossier brouillon" spec ... The previous fix (scrolling to the viewport) didn't actually worked, because the code tried to scroll the checkbox itself.	2021-11-09 15:21:59 +01:00
simon lehericey	d1162d7493	add e2e spec	2021-11-04 16:10:09 +01:00
Paul Chavard	ba0211ba52	feat(champ): ask for departement before asking for commune	2021-11-04 11:55:25 +01:00
Pierre de La Morinerie	b06183d7bf	specs: rename Dossier's with_all_champs to with_populated_champs ... This better reflects what the trait is used for, and disambiguate it from the similarly named trait in the Procedure factory.	2021-11-03 19:38:01 +01:00
kara Diaby	71aa13f468	tests	2021-10-27 12:00:39 +02:00
Pierre de La Morinerie	9fd38cae5e	specs: migrate from features to system specs ... System specs have been available since Rails 5.1, and are better integrated with the Rails framework. - Rename `spec/features` to `spec/system` - Rename `feature do` to `describe do` - Configure Capybara for system specs Steps mostly taken from https://medium.com/table-xi/a-quick-guide-to-rails-system-tests-in-rspec-b6e9e8a8b5f6	2021-10-26 12:24:46 +02:00