DGNum/demarches-normaliennes
14
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity
11208 commits 4 branches 1166 tags 85 MiB
Commit graph

5808 commits

Author SHA1 Message Date
Paul Chavard
3193784c24 Remove unused revision_id from payload 2020-07-22 11:09:06 +02:00
Paul Chavard
ad4dff819e fix type_de_champ controller move param 2020-07-22 11:08:06 +02:00
Christophe Robillard
5950f6c93c fix demarches active link when action of procedures_controller 2020-07-22 10:04:32 +02:00
Paul Chavard
0338080430 Remove unused procedure move type_de_champ code 2020-07-21 19:35:30 +02:00
Paul Chavard
d18a9c8162 Migrate procedures “on demand” 2020-07-21 19:35:30 +02:00
Paul Chavard
0a0912503b Add type_de_champ mutation methods to revision 2020-07-21 19:35:30 +02:00
Paul Chavard
bc09b61684 Add migration service and task 2020-07-21 19:35:30 +02:00
Paul Chavard
9de917592b Add revisions models and relationships 2020-07-21 19:35:30 +02:00
Pierre de La Morinerie
213e325a8a
Merge pull request #5401 from betagouv/fix/5287-champs 
Administrateur : indique plus clairement si des champs de formulaire ont été ajouté à la démarche
 2020-07-21 18:23:41 +02:00
Keirua
f583b16f92
Merge pull request #5400 from betagouv/add-test-for-zip-download 
Ajout d'un test pour le telechargement de zips de dossier
 2020-07-21 17:39:39 +02:00
Keirua
b2aa90b729
Merge pull request #5392 from betagouv/fix-CI-accessibility-errors 
Fix CI accessibility errors
 2020-07-21 17:15:45 +02:00
kara Diaby
3ed7d6605d add counter to admin new interface for procedure detail, on the champ card 2020-07-21 17:01:03 +02:00
clemkeirua
d31b4b6848 ajout d'un test sur le telechargement de zips 2020-07-21 15:45:57 +02:00
krichtof
8c5308b9dc
Merge pull request #5396 from betagouv/5395-relancer-expert 
5395 instructeur : relance un expert pour une demande d'avis
 2020-07-21 15:02:53 +02:00
Christophe Robillard
7f90bdeec4 only instructeurs of the avis dossier or claimant can revive expert 2020-07-21 13:14:07 +02:00
Christophe Robillard
689a51588f translations for avis list view 2020-07-21 10:46:55 +02:00
Paul Chavard
86f562e7ea Expose repetitions and options on champ_descriptors 2020-07-21 10:37:33 +02:00
Christophe Robillard
d9cb5c067f relance un expert 2020-07-20 16:26:16 +02:00
Christophe Robillard
bde8fe2c5d update wording for revoke 2020-07-20 16:08:35 +02:00
kara Diaby
06b90077d3 some fixes to new admin interface 2020-07-20 15:45:18 +02:00
Keirua
fd8507b531
Merge pull request #5393 from betagouv/zip-with-identical-files 
Zip with identical files
 2020-07-20 15:35:35 +02:00
clemkeirua
48b96046f1 pad file name with creation date 
During zip creation, when 2 files have an identical name it creates a corrupted zip file
Duplicate files can now be downloaded with all the versions, the file names contain a timestamp
 2020-07-20 15:33:22 +02:00
clemkeirua
c0cf8b1341 fix display of labels for datetime on screenreaders 2020-07-20 11:37:01 +02:00
clemkeirua
bc34905742 fix heading order by removing useless h4 2020-07-20 11:36:55 +02:00
Christophe Robillard
4476f00be2 fix active link menu for demarches 2020-07-20 11:26:19 +02:00
clemkeirua
def81f9de8 fix zip download for everybody 2020-07-20 11:14:34 +02:00
krichtof
0c95e41c6f
Merge pull request #5386 from betagouv/5138-revoque-avis-expert 
[Revoque une demande d'avis à un expert](https://github.com/betagouv/demarches-simplifiees.fr/pull/5386)
 2020-07-17 20:42:13 +02:00
Paul Chavard
6dbe2fe165 fix patron drop down list 2020-07-17 12:11:46 +02:00
kara Diaby
5e43559329 fix new admin interface regarding test links and previsualisation 2020-07-17 11:10:54 +02:00
Christophe Robillard
52e8f32e19 expert can only revoke avis claimed by him/her 2020-07-16 21:07:20 +02:00
Christophe Robillard
3ea34834a7 revoke expert avis 2020-07-16 21:05:11 +02:00
clemkeirua
889cdd6874 ajout des annotations privées 2020-07-16 18:13:51 +02:00
Paul Chavard
b628169053 Remove unsused drop_down_list model 2020-07-16 15:29:01 +02:00
kara Diaby
b69bc11ae4 new design for procedure detail (admin) 2020-07-16 10:40:58 +02:00
kara Diaby
9dc542af09 Revert "Revert "Feat/5287 - New design for admin procedure detail"" 
This reverts commit cf5eb3f251.
 2020-07-15 17:00:03 +02:00
krichtof
0c924be222
Merge pull request #5374 from betagouv/3451-revoquer-invite 
usager: revoque un invité sur un dossier
 2020-07-15 15:46:16 +02:00
clemkeirua
7b9a954473 include procedure in usual_traitement_time 2020-07-15 09:27:23 +00:00
clemkeirua
96e82c75d6 use more idiomatic update 2020-07-15 09:00:12 +00:00
clemkeirua
299c86141c added before_save to PieceJustificativeChamp in order to set skip_pj_validation 2020-07-15 09:00:12 +00:00
clemkeirua
bdbe57debd add skip_pj_validation accessor to TypeDeChamp 2020-07-15 09:00:12 +00:00
Christophe Robillard
8111babdd6 user: revoque un invité sur un dossier 2020-07-14 18:25:31 +02:00
Pierre de La Morinerie
e34f82a6fb mailers: ignore more SMTP errors 
Although we already ignore "invalid recipient" errors, a new type
of error recently popped: the mail service responds with
> Net::SMTPServerBusy '400 unexpected recipients: want atleast 1, got 0'

We want to also ignore this kind of errors.
 2020-07-13 16:17:55 +02:00
Pierre de La Morinerie
7a67f1a802 jobs: ignore missing blob during virus scan 
We currently have many failed VirusScannerJob enqueued, because the
underlying blob is missing.

This PR fixes the issue by discarding the job in those cases (because if
the blob is gone, the job is never going to succeed).

The implementation is based on a similar issue encoutered by the
ActiveStorage::AnalyzeJob. See 06f8baf73c
 2020-07-13 14:35:41 +02:00
Kara Diaby
cf5eb3f251
Revert "Feat/5287 - New design for admin procedure detail" 2020-07-13 11:36:42 +02:00
Paul Chavard
cc7e6853e7 Disable usual_traitement_time 2020-07-12 12:32:28 +02:00
kara Diaby
7f3b38cfee Merge admin dashboard to new design for procedure details 2020-07-09 12:18:22 +02:00
Paul Chavard
ef259c361d Fix exception when purge_later is called before save 2020-07-08 19:25:05 +02:00
Paul Chavard
a74e52c828 Call remove_drop_down_list on before_save 2020-07-08 19:25:05 +02:00
Paul Chavard
3c9cc6c070 Remove repetition types_de_champ on type_champ change 2020-07-08 19:25:05 +02:00
Christophe Robillard
2c56511204 validate api_entreprise_token 2020-07-08 18:59:22 +02:00
Christophe Robillard
f38e16e371 avoid n+1 queries 2020-07-08 18:15:15 +02:00
Christophe Robillard
dfc97d8d87 allège l'affichage des décisions rendues 2020-07-08 18:15:15 +02:00
Christophe Robillard
f0e0554da9 display instructeur_email who took decision only if email is present 2020-07-08 18:15:15 +02:00
Christophe Robillard
1253bb5994 store instructeur_email in traitement 2020-07-08 18:15:15 +02:00
Christophe Robillard
9b6c5fd7fd update termine_close_to_expiration with traitement 2020-07-08 18:15:15 +02:00
Christophe Robillard
8f9d6d2871 show which instructeur took decision and when 
and also replace "sans suite" by "classé sans suite"
 2020-07-08 18:15:15 +02:00
Christophe Robillard
cea170e4a6 update stats with traitement model 2020-07-08 18:15:15 +02:00
Christophe Robillard
0be4b50ade update usual_traitement_time with traitement model 2020-07-08 18:15:15 +02:00
Christophe Robillard
a072d35211 use traitement model 
when a dossier is terminated (accepte, refuse or classe_sans_suite),
we store now `processed_at` and `motivation` in a traitement instance
 2020-07-08 18:15:15 +02:00
Christophe Robillard
f631acd118 update state date in aasm after callbacks 
call aasm event methods, not state methods directly
 2020-07-08 18:15:15 +02:00
Christophe Robillard
d20d91bc07 no sentry reporting for api-entreprise 2020-07-08 17:58:33 +02:00
clemkeirua
b440f41cd8 change link from to contact to FAQ on home 2020-07-08 16:22:55 +02:00
Pierre de La Morinerie
cd65dc14dd models: fix ProcedurePresentation#sorted_ids 
The `Dossier#with_notifications` scope needs to be composed with an
`instructeurs` scope. But it seems Rails 6 will only generate proper
SQL if the `instructeurs` scope is merged before filtering on
`with_notifications`.
 2020-07-07 18:03:56 +02:00
Pierre de La Morinerie
4aeb8c392f bill_signature: fix reading unsaved attachments 
Since Rails 6, an unsaved attachment_changes can contain either
a Tempfile, or an hash with an :io key.

squash! bill_signature: fix reading unsaved attachments
 2020-07-07 18:03:56 +02:00
Pierre de La Morinerie
a4ed845e43 models: fix attestation template rendering on Rails 6 2020-07-07 18:03:56 +02:00
Pierre de La Morinerie
b8706757e3 controllers: disable explicit purge of invalid file 2020-07-07 18:03:56 +02:00
Pierre de La Morinerie
35240e2219 lint: fix Rubocop warnings 
The Rails/UniqueValidationWithoutIndex rule is disabled for now, but
we'll need to re-enable it (and fix the underlying issues) after the
migration to Rails 6.
 2020-07-07 18:03:56 +02:00
Paul Chavard
04feada77e Use respond_to 2020-07-07 18:03:56 +02:00
Paul Chavard
c9ab80c880 WIP 2020-07-07 18:03:56 +02:00
Paul Chavard
6a24c3f812 Rails app:update 2020-07-07 18:03:56 +02:00
Judith
927a3b3efd fix all instructeur procedure_path into instructeur_procedure_path 2020-07-07 17:11:46 +02:00
Judith
060022df78 fix instructeur_mail_notifications 2020-07-07 17:11:46 +02:00
Judith
2adb854bf8 new_from_existing : added new route for 'Consulter' 2020-07-07 14:51:08 +00:00
Judith
9793128f61 'Services' routes moved under 'new_administrateur' scope and '/admn' added in their url 2020-07-07 14:08:01 +00:00
Judith
782706537d Changed the routes to pass all new design admin pages under 
'new_administrateur' scope, except 'services'.
As a result, the url of these pages will all include '/admin'.
 2020-07-07 14:08:01 +00:00
Pierre de La Morinerie
f5f7a47de3 stylesheet: make the selected tab more visible 
Tabs are notoriously hard to notice. Make them stand out more.
 2020-07-07 11:02:15 +02:00
Pierre de La Morinerie
c3b648f975 stylesheets: hide summary details marker on procedure summary 
Chrome needs a specific syntax, but other browsers use the standard way.

See developer.mozilla.org/fr/docs/Web/HTML/Element/details#Personnaliser_le_marqueur_de_r%C3%A9v%C3%A9lation
 2020-07-07 10:20:01 +02:00
Pierre de La Morinerie
b6fbf9bd4b gems: update scss_lint 
Fix false-positive on pseudo-elements.
 2020-07-07 10:20:01 +02:00
clemkeirua
90efbe66a9 define SHOW_PAGE_ATTRIBUTES for bill dashboard 2020-07-07 08:06:37 +00:00
clemkeirua
d5c955080b fix demandes adapter when no demandes 2020-07-07 09:24:23 +02:00
Pierre de La Morinerie
5f1d38a555 stylesheets: improve procedure synthese badges 
- Align with baseline
- More padding
- More margin
- Use constants for colors and margins
 2020-07-06 15:11:45 +02:00
Pierre de La Morinerie
975d1648d5 dossier: fix PDF rendering of effectif_mensuel 
The effectif_mensuel was a number, it needs to be converted explicitely
into a string.

As a bonus, `nil.to_s` is `""`, so we can remove the special case for
nil.
 2020-07-06 11:41:25 +02:00
Pierre de La Morinerie
a810daeb0c stylesheets: fix with of large select elements 
Select elements with very long options would overflow the form
width, and create a disgraceful scroller bar on the bottom of the
screen.
 2020-07-06 10:55:34 +02:00
clemkeirua
ca74ae5a5e ajout d'une bannière de dépréciation pour IE11 2020-07-06 10:01:02 +02:00
maatinito
1c29e903da pdf dossier: better layout for etablissement fields 2020-07-02 13:53:36 +02:00
Myriam
0f542527fb Instructeur : add overview table with counts for files 
- changement du design
- tableau visible seulement si plus d'une procédure
 2020-07-02 09:02:49 +00:00
Myriam
a486fe9a2e Instructeur : add overview table with counts for files 
nombre total de dossier :
- 'à suivre'
- 'suivi'
- 'traité'
- 'dossier'
- 'archivé'
 2020-07-02 09:02:49 +00:00
Pierre de La Morinerie
b8f6545963
Revert "pdf dossier: better layout for etablissement fields" 2020-07-01 15:59:05 +02:00
bors[bot]
b135b5cfb0
Merge #5316 
5316: fix missing aria-labels in footer r=Keirua a=Keirua

début du cleanup des exclusions d'accessibilité
(et bon candidat pour tester si bors fonctionne comme prévu)

Co-authored-by: clemkeirua <clement@keiruaprod.fr>
 2020-07-01 09:28:02 +00:00
bors[bot]
dbba5644e3
Merge #5319 
5319: pdf dossier: better layout for etablissement fields r=Keirua a=maatinito

Dans l'export du dossier PDF, comme je le mettais au couleurs de Polynésie, je me suis rendu compte que c'était moche, principalement parce que la fonction format_in_2_column ne savait pas calculer la hauteur qu'elle prend. 
Donc voilà une petite PR pour améliorer l'affichage de la personne morale, qui s'adapte en fonction de la longueur des textes à afficher, à tester sur une démarche 'Personne Morale'. 
J'aurais bien voulu vous montrer une image du résultat pour accélérer la revue mais je n'ai pas accès à l'API entreprise pour faire une démo sur la branche dev. 

Co-authored-by: maatinito <15379878+maatinito@users.noreply.github.com>
 2020-07-01 08:48:44 +00:00
Christophe Robillard
cce1435faf remove precision for currency 2020-07-01 09:28:18 +02:00
maatinito
bc8d88af73 pdf dossier: better layout for etablissement fields 2020-06-30 15:09:38 -10:00
Christophe Robillard
1d86f863d3 rename avis#all to avis#index 2020-06-30 09:17:27 +02:00
Christophe Robillard
bbec76d33b rename avis#index to avis#procedure 2020-06-30 09:17:27 +02:00
Christophe Robillard
8f2b09ae06 fix active_links in header 2020-06-30 09:17:27 +02:00
Christophe Robillard
63dd71aed4 display all avis for an expert 2020-06-30 09:17:27 +02:00
Christophe Robillard
29e2d3d7eb display all avis for a procedure for an expert 2020-06-30 09:17:27 +02:00
Christophe Robillard
c565c9c87b refactor sign_up_instructeur_avis_url 2020-06-30 09:17:27 +02:00
Christophe Robillard
4839506374 refactor instructeur_avis_url 2020-06-30 09:17:27 +02:00
Christophe Robillard
b0cfb2c02a refactor messagerie_instructeur_avis_url 2020-06-30 09:17:27 +02:00
Christophe Robillard
83fba55b29 refactor instruction_instructeur_avis_url 2020-06-30 09:17:27 +02:00
Christophe Robillard
72d27ffdb2 replace instructeur_avis_index url by instructeur_all_avis url 2020-06-30 09:17:27 +02:00
clemkeirua
1072bacb12 fix missing aria-labels in footer 2020-06-29 15:31:14 +02:00
kara Diaby
6b07cc0659 Move admin/assigns to the new UI like groupe_instructeurs 2020-06-29 14:44:28 +02:00
Pierre de La Morinerie
d25e173f11 attachment: disable Delete button during request 
Prevent users from clicking the Delete button more than once.
 2020-06-29 12:28:53 +00:00
Judith
bbcd432eaa class 'sr-only' transfered to accessibilite.scss 2020-06-29 11:57:48 +00:00
Judith
73ee4d69ca usager/dossiers: the link to the dossier is present: 
- in the 'N° de dossier' column for mouse users and screen reader users.
- in the 'Démarche' column for mouse users, screen reader users and keyboard users.
Also added a sr-only class for text which should be read by screen-readers but not visible or accessible to other users
 2020-06-29 11:57:48 +00:00
clemkeirua
3a9204af56 rename 'Menu déroulant' in graphql 2020-06-29 08:59:12 +00:00
Pierre de La Morinerie
5949266e89 javascript: silence Crisp warning in Javascript console 2020-06-26 15:57:14 +02:00
Paul Chavard
210389d0f8 Remove admin creation notification email 2020-06-25 16:29:06 +02:00
Paul Chavard
97f91513c8 Store drop_down_list values as jsonb 2020-06-25 13:14:17 +02:00
Pierre de La Morinerie
acc1cb1abd dossier: export PJs from private champs 
Fix #5297
 2020-06-24 15:42:30 +02:00
Pierre de La Morinerie
6f14e7783f dossier: refactor piece_justificative service 2020-06-24 15:42:30 +02:00
Pierre de La Morinerie
84149218db dossier: refactor piece_justificative export helpers 2020-06-24 15:42:30 +02:00
Pierre de La Morinerie
df13bce0e0 policies: clarify the role of ChampPolicy 2020-06-24 15:42:30 +02:00
Pierre de La Morinerie
812aef978d controllers: rename pundit_user to current_account 
It makes epxlicity what is the name of the structure returned by
`pundit_user`: not an actual User, but an `account` structure.
 2020-06-24 15:42:30 +02:00
Judith
235a406295 Spectral removed and replaced by Marianne-thin 2020-06-24 13:11:04 +00:00
Judith
b7fe9418fd adapting font size to fit previous size with LiberationSerif 2020-06-24 13:11:04 +00:00
Judith
c3a6f671c8 replaced LiberationSerif regular and bold by Marianne, italic by Spectral-Italic 2020-06-24 13:11:04 +00:00
clemkeirua
6b3631dbfe extract rendering condition 2020-06-24 14:11:58 +02:00
clemkeirua
5c39f22417 seuil d'affichages des checbox/radio à 5 elements 2020-06-24 12:18:56 +02:00
clemkeirua
342129c893 display small multiple selects as checkboxes 2020-06-24 12:18:56 +02:00
clemkeirua
22fc4c4195 display small selects as radio buttons 2020-06-24 12:18:56 +02:00
Christophe Robillard
954d41ce4e fetch effectifs mensuels for may month 2020-06-24 10:23:00 +02:00
clemkeirua
53ecd48be2 set email autocomplete during registration 
username is an invalid autocomplete attribute for input type=email, but email is not
 2020-06-23 14:58:56 +00:00
clemkeirua
cca84a62ca meilleurs descriptions aria au signup 2020-06-23 14:58:56 +00:00
clemkeirua
58b110b88a invalid image width '-_- 2020-06-23 14:58:56 +00:00
Paul Chavard
34df07bc96 Fix oui/non filter on type_de_champ_private 2020-06-23 11:33:46 +02:00
Pierre de La Morinerie
af5b36ea6a helpers: prevent some texts to be incorrectly detected as links 
Users were having issues with texts like:

> Pour info: penser à faire cette action.

where `info:` was detected as being an URI.
 2020-06-22 14:42:41 +02:00
simon lehericey
fecad19b91 add maintenance mode 2020-06-22 11:17:22 +02:00
jpoulvel
841758fdcf
Merge branch 'dev' into 5162-fix-help-button 2020-06-18 17:12:58 +02:00
kara Diaby
3dacff19d5 [CARTO] fix the GPX and KML imports in order to manage multiples draw types in the same file 2020-06-18 16:28:46 +02:00
Judith
af60b1dddc help_dropdown_procedure contains now a <button> and not a <div>, which makes it accessible for keyboard navigation 2020-06-18 11:17:39 +02:00
Judith
65d6f12958 added new green for higher contrasts. Previous green remains accessible as old-green 2020-06-16 14:58:28 +00:00
Judith
75b1642c0d changed grey by dark-grey for texts 2020-06-16 14:58:28 +00:00
Judith
76160b48bd _colors.scss: added dark-grey for more contrasted texts 2020-06-16 14:58:28 +00:00
Judith
19e54a73b0 replacing ' with ’ in text 2020-06-16 14:39:27 +00:00
Judith
1b7a4574e8 headers : aria-label in print button 2020-06-16 14:39:27 +00:00
Judith
b02f1e4c34 fixed empty links in contact footer 2020-06-16 14:39:27 +00:00
Judith
ef242649c6 homogenization of the mandatory-explanation 2020-06-16 14:39:27 +00:00
Judith
b88dc6ec72 mandatory_explanation added in the description and changed PJ label_tag to :piece_jointe 2020-06-16 14:39:27 +00:00
Paul Chavard
e89f0846bb Fix job max attempts 2020-06-16 15:57:18 +02:00
jpoulvel
adaf0753b0
Merge branch 'dev' into instruct-filter-yes-no 2020-06-16 14:53:22 +02:00
Christophe Robillard
f8b170836c report to sentry for BadFormatRequest and ResourceNotFound exceptions 2020-06-11 23:09:50 +02:00
Christophe Robillard
b90513f456 no sentry report when error 400 for exercices 2020-06-11 18:16:19 +02:00
Christophe Robillard
f9b1b8217a more verbose exception when RequestFailed for apientreprise occurs 2020-06-11 17:24:45 +02:00
Paul Chavard
c4896b45ad Prepare to remove dossier procedure_id 2020-06-11 16:13:44 +02:00
Christophe Robillard
8b802ae2c8 add destroy dependent option for exports 2020-06-11 12:33:29 +02:00
Christophe Robillard
56ed8dd36a remove useless dependent option 2020-06-11 10:24:04 +02:00
Christophe Robillard
8df9ae3a8d ask only effectifs for april 2020-06-10 17:41:13 +02:00