Commit graph

119 commits

Author SHA1 Message Date
Tom Hughes
1234561a78 The ActiveRecord exists? method may not return an explicit true/false
https://github.com/rails/rails/issues/10062
2013-07-09 18:26:54 +01:00
Tom Hughes
28faa17526 Fix bogus test class names 2013-06-30 21:44:41 +01:00
Tom Hughes
b3e540a6b6 Improve tests for trace RSS feeds 2013-05-10 22:48:26 +01:00
Tom Hughes
461e39f4a5 Fix bogus test 2012-11-12 19:27:09 +00:00
Tom Hughes
e4be816ca0 Don't allow hash signs in usernames 2012-07-23 12:59:50 +01:00
Tom Hughes
91a9738ee8 Don't try and look for variables in non-existent values 2012-06-01 15:48:23 +01:00
Tom Hughes
9813d9f1e4 Get all the tests passing under ruby 1.9 2012-05-27 13:51:25 +01:00
Matt Amos
8bfb5cae8a Added relation redaction logic, same as node and way logic, plus tests 2012-04-05 13:49:46 +01:00
Kai Krueger
72e59b49fa Copy the redaction code from nodes to ways 2012-04-05 13:49:39 +01:00
Matt Amos
67dd9e4c9d Adding first cut of Redactions support
Redactions support hiding historical versions of elements and
collecting meta-data about that action together.
2012-04-05 13:46:36 +01:00
Tom Hughes
eaad3611b8 Add functional tests for messages
Also fixes various issues in the code discovered while writing
the tests, and adds some named routes for messages.
2012-03-22 23:14:29 +00:00
Tom Hughes
38a610fd31 Add functional tests for the user_roles controller 2012-03-20 17:21:13 +00:00
Tom Hughes
e1d873cde9 Add functional tests for user blocks
Also fixes various issues in the code discovered while writing
the tests, and adds some named routes for user blocks.
2012-03-19 11:26:02 +00:00
Tom Hughes
02542c96f2 Add some tests for the RichText module 2012-03-17 16:37:21 +00:00
Tom Hughes
b1cb7bb819 Drop the contents of <script> and <style> tags when we strip them 2012-03-17 16:37:01 +00:00
Tom Hughes
7be823bb11 Treat messages received by email as plain text
Move creation of a message from an email into the message model and
adjust the logic to treat messages received by email as plain text.
2012-03-17 16:37:00 +00:00
Tom Hughes
222cd46a57 Add some more unit tests for traces 2012-03-07 21:12:02 +00:00
Tom Hughes
e3152ea1c7 Add some more unit tests for users 2012-03-07 16:44:58 +00:00
Tom Hughes
2a62ebec53 Add some extra unit tests for diary entries 2012-03-07 15:59:07 +00:00
Tom Hughes
1340fca8f1 Turn on mass assignment protection
Require any attribute that is going to be mass assigned to be
whitelisted, and whitelist those attributes which need it
2012-03-06 08:54:45 +00:00
Tom Hughes
8f7ecf169a Add a test to check the validity of the translations 2012-03-04 14:24:21 +00:00
Matt Amos
64030a40ac Replace @ with ~ in the shortlink
This should help Twitter's horribly broken URL detection algorithm
not screw up shortlinks from OSM.
2011-11-24 22:27:16 +00:00
Tom Hughes
7b89dc6349 Make OAuth work again 2011-11-16 21:13:25 +00:00
Peter Gray
95d899786a Refactor bounding box code
Moved duplicated code into the BoundingBox class, and pass around
BoundingBox objects instead of lists of bounds.
2011-11-14 09:42:57 +00:00
Tom Hughes
44a9a65aa7 Create new diary entry records instead of cloning the fixture
Cloning fixtures doesn't seem to do a deep copy in rails 3.1 so the
attribute changes persist into other future cloned copies of the same
fixture. The fix is to create completely new records for each test.
2011-11-14 09:42:52 +00:00
Tom Hughes
fc25c3d412 Rename all ID columns that aren't unique
Having a table with a column called ID that is only part of the
primary key really doesn't work as rails likes to treat ID as a
special name so it becomes impossible to assign to it or read it.
2011-11-14 09:42:52 +00:00
Tom Hughes
feef62b1cc Do validation in the :save context when testing email address validations 2011-11-14 09:42:46 +00:00
Tom Hughes
a92223a506 Duplicate records raise RecordNotUnique now, not StatementInvalid 2011-11-14 09:42:45 +00:00
Tom Hughes
3d55db46ed Avoid use of deprecated methods on error objects 2011-11-14 09:42:45 +00:00
Matt Amos
cd66a5db99 Initial work on support for multiple editors 2010-11-29 12:20:21 +00:00
Tom Hughes
7b3e8871d5 There are five trace fixtures now 2010-10-11 23:35:44 +01:00
Tom Hughes
f07819d81a Rework application configuration
Use a preinitializer to load the settings from application.yml so
that they are available as early as possible. All settings can also
be overridden using environment variables.

The ad-hoc settins in environment.rb are then moved to this new
system so we have one consistent location for settings.
2010-08-04 22:06:05 +01:00
Tom Hughes
406b46e49b Revert "Switch to using oauth-plugin as a gem"
This reverts commit 41a123334b.
2010-06-07 16:01:04 +01:00
Tom Hughes
41a123334b Switch to using oauth-plugin as a gem
Use the oauth-plugin as a gem instead of carrying a local copy.

This also required that commit eff06faf46 be
reverted as it changed the plugin. I don't think the cosmetic improvement
from that patch is worth the hassle of carrying local changes to the plugin.
2010-05-24 12:58:27 +01:00
Tom Hughes
20cc601f85 Fix tests for changes to user model 2010-05-06 22:11:55 +01:00
Tom Hughes
0ec5e8f858 Move bogus addresses from the good set to the bad set - unicode email
addresses are not currently allowed by the email standards.
2010-02-25 21:22:42 +00:00
Shaun McDonald
094855be22 Actually the changeset doesn't need an id attribute in the xml. It is simply fetched as a parameter in the url. Thanks for pointing it out Frederik. We really need more tests so that things like this are thought about more before committing potentially significant changes. 2009-12-15 23:53:19 +00:00
Shaun McDonald
43a28065b1 Change the way that the changeset parsing is done, so that it is in line with the nodes/ways/relations and gives much nicer error messages. Adding some tests too to back up those changes. 2009-12-06 02:13:30 +00:00
Thomas Wood
76b6d7d876 Tests for [17838]
Why is our testing fixtures such a mess? It took me half an hour to find a useable node. And I'm still not sure if it's ok, since I want to get to bed. kthxbye
2009-09-29 03:58:33 +00:00
Štefan Baebler
93c592bbe4 tests for diary rss feeds 2009-08-19 05:07:26 +00:00
Tom Hughes
908a6ef409 Merge 16891:17044 from trunk. 2009-08-13 17:18:08 +00:00
Tom Hughes
565171486f Add extra visibility options for GPS traces, and enhance the API call
that returns trace data to return more information if the owner of the
trace has allowed it. Based on a patch from Matt Amos.
2009-08-13 17:06:11 +00:00
Matt Amos
eff06faf46 Moved find_token method into the token class, since that seems a more appropriate place for it. 2009-08-03 14:00:29 +00:00
Tom Hughes
64fb530581 Merge 16110:16487 from trunk. 2009-07-14 08:03:24 +00:00
Matt Amos
1d8e66016c Adding 'shortlink' functions which will allow URLs like http://osm.org/go/XXXX suitable for use in twitter, etc... 2009-06-25 23:31:53 +00:00
Tom Hughes
f4571eeb7c Revert r16046.
DO NOT COMMIT MAJOR ENHANCEMENTS TO TRUNK WITHOUT TALKING TO ME FIRST.
2009-06-23 02:48:38 +00:00
Matt Amos
b8f6dbd403 Adding initial version of the OAuth token authentication method. This adds basic OAuth support for registering apps, getting and revoking keys, etc... The tokens come with 6 separate permissions bits; read/write user preferences, write diaries, write API and read/write GPS traces. Needs more tests. 2009-06-22 16:54:37 +00:00
Shaun McDonald
65eb6af303 Give a nice error message when parsing the nwr tags and they are missing the k and/or v. Also includes tests. 2009-06-11 11:08:37 +00:00
Shaun McDonald
17a1e22df9 Adding a couple of extra unit tests for the parsing of keys 2009-06-10 17:42:29 +00:00
Shaun McDonald
37df03a043 Cleanup the Relation.from_xml to come in line with the Way and Node versions. Includes tests. Bug fix for the previous tests. 2009-06-10 17:17:03 +00:00