Moved find_token method into the token class, since that seems a more appropriate place for it.

This commit is contained in:
Matt Amos 2009-08-03 14:00:29 +00:00
parent 45a3acb4e2
commit eff06faf46
5 changed files with 23 additions and 29 deletions

View file

@ -6,16 +6,6 @@ class ClientApplication < ActiveRecord::Base
validates_uniqueness_of :key
before_validation_on_create :generate_keys
def self.find_token(token_key)
token = OauthToken.find_by_token(token_key, :include => :client_application)
if token && token.authorized?
logger.info "Loaded #{token.token} which was authorized by (user_id=#{token.user_id}) on the #{token.authorized_at}"
token
else
nil
end
end
def self.verify_request(request, options = {}, &block)
begin
signature = OAuth::Signature.build(request, options, &block)

View file

@ -5,6 +5,16 @@ class OauthToken < ActiveRecord::Base
validates_presence_of :client_application, :token, :secret
before_validation_on_create :generate_keys
def self.find_token(token_key)
token = OauthToken.find_by_token(token_key, :include => :client_application)
if token && token.authorized?
logger.info "Loaded #{token.token} which was authorized by (user_id=#{token.user_id}) on the #{token.authorized_at}"
token
else
nil
end
end
def invalidated?
invalidated_at != nil
end

View file

@ -1,17 +0,0 @@
require File.dirname(__FILE__) + '/../test_helper'
class ClientApplicationTest < ActiveSupport::TestCase
api_fixtures
##
# test that tokens can't be found unless they're authorised
def test_find_token
tok = client_applications(:oauth_web_app).create_request_token
assert_equal false, tok.authorized?, "Token should be created unauthorised."
assert_equal nil, ClientApplication.find_token(tok.token), "Shouldn't be able to find unauthorised token"
tok.authorize!(users(:public_user))
assert_equal true, tok.authorized?, "Token should now be authorised."
assert_not_equal nil, ClientApplication.find_token(tok.token), "Should be able to find authorised token"
end
end

View file

@ -23,4 +23,15 @@ class OauthTokenTest < ActiveSupport::TestCase
assert_equal false, tok.authorized?, "Token should now be invalid."
end
##
# test that tokens can't be found unless they're authorised
def test_find_token
tok = client_applications(:oauth_web_app).create_request_token
assert_equal false, tok.authorized?, "Token should be created unauthorised."
assert_equal nil, OauthToken.find_token(tok.token), "Shouldn't be able to find unauthorised token"
tok.authorize!(users(:public_user))
assert_equal true, tok.authorized?, "Token should now be authorised."
assert_not_equal nil, OauthToken.find_token(tok.token), "Should be able to find authorised token"
end
end

View file

@ -96,7 +96,7 @@ module OAuth
def verify_oauth_signature
begin
valid = ClientApplication.verify_request(request) do |request|
self.current_token = ClientApplication.find_token(request.token)
self.current_token = OauthToken.find_token(request.token)
logger.info "self=#{self.class.to_s}"
logger.info "token=#{self.current_token}"
# return the token secret and the consumer secret
@ -111,4 +111,4 @@ module OAuth
end
end
end
end
end