Commit graph

11570 commits

Author SHA1 Message Date
Andy Allan
675f72fe35 Use flex grid to position changeset discussion subscribe button
This avoids needing any floats. Also remove buttons class from two
locations, since there is a min-width on that class and it affects
the button styling negatively for standalone buttons
2021-11-24 12:24:16 +00:00
Andy Allan
8249b41a83 Remove some unused thumbnail rules
These are all done with flex grids now, so no need to float the image anywhere
2021-11-24 12:24:16 +00:00
Andy Allan
cb68450ac7 Simplify margins when showing diary entries 2021-11-24 12:24:16 +00:00
Andy Allan
514ec41c58 Remove unused browse-field style rules 2021-11-24 12:24:16 +00:00
Andy Allan
3bc20b6f21 Pass classes to override the default thumbnail_tiny style, rather than having another selector overriding 2021-11-24 12:24:16 +00:00
Andy Allan
52cd62bf13 Replace CSS-driven borders with bootstrap borders
This makes future refactoring easier, since the elements will
retain their borders even if the hierarchy changes.

Also round some maps and the legale section since I think those now
look nicer.
2021-11-24 12:24:16 +00:00
Andy Allan
f433fb3d4e Remove border-radius parameter
This overrides the same variable from bootstrap. Since bootstrap
also comes with -sm and -lg variants defined by rem, our px-based
override doesn't sit nicely with those.
2021-11-24 12:24:08 +00:00
Andy Allan
300cd884ec Use flex grid instead of floating to position changeset element paging nav
This works much better when either the heading or the paging is long.

The heading was moved into the partial to avoid repetitive grid definitions
2021-11-24 12:07:49 +00:00
Andy Allan
846bacd665 Remove the custom flash styling for sidebar flashes
The flash partial is now based on flexbox, so these positioning classes
are no longer required
2021-11-24 12:07:31 +00:00
Andy Allan
b43aaa1d58 Remove the floating from the sidebar close buttons
These are mostly positioned with flexbox, and those that aren't
are covered by the similar close-wrap selector elsewhere in this file
2021-11-24 12:07:07 +00:00
Andy Allan
18c70fa2de Add a user link to the heading of the diary comments page
Fixes #3369

This makes the heading match the layout of the user's Notes page,
which also has a short heading and a subheading with a link.

Additionally, add a page title, again for consistency
2021-11-24 10:55:09 +00:00
dependabot[bot]
88e24d7ff3
Bump actions/cache from 2.1.6 to 2.1.7
Bumps [actions/cache](https://github.com/actions/cache) from 2.1.6 to 2.1.7.
- [Release notes](https://github.com/actions/cache/releases)
- [Commits](https://github.com/actions/cache/compare/v2.1.6...v2.1.7)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-11-23 23:05:29 +00:00
Tom Hughes
abbd5a30d4 Validate any origin passed the auth failure callback
Fixes #3375
2021-11-23 17:33:19 +00:00
Tom Hughes
407b61857e Improve fallback behaviour for unsafe referer redirects 2021-11-23 17:18:41 +00:00
Tom Hughes
31e638474a Handle authentication failure callbacks with no message 2021-11-23 17:01:06 +00:00
Tom Hughes
64457dbbd0 Handle exceptions rendering flash messages 2021-11-23 16:55:06 +00:00
Tom Hughes
d951621c44 Make safe_referer handle invalid URIs 2021-11-23 11:27:02 +00:00
Tom Hughes
88f156a41a Merge remote-tracking branch 'upstream/pull/3373' 2021-11-23 00:09:19 +00:00
dependabot[bot]
f3867752b8
Bump eslint from 8.2.0 to 8.3.0
Bumps [eslint](https://github.com/eslint/eslint) from 8.2.0 to 8.3.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](https://github.com/eslint/eslint/compare/v8.2.0...v8.3.0)

---
updated-dependencies:
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-11-22 23:00:38 +00:00
Tom Hughes
b5711b4e2c Disable oxipng in image_optim config 2021-11-22 21:36:17 +00:00
Tom Hughes
cd1dcad31a Update bundle 2021-11-22 20:52:35 +00:00
translatewiki.net
ca896970d2 Localisation updates from https://translatewiki.net. 2021-11-22 13:36:51 +01:00
Tom Hughes
bb5954e489 Drop unused browser feature predicates 2021-11-19 18:10:50 +00:00
Tom Hughes
87bf5648c8 Drop es5 polyfill 2021-11-19 18:09:49 +00:00
Tom Hughes
d8da12f587 Drop use of html5shiv
Fixes #3367
2021-11-18 17:20:07 +00:00
translatewiki.net
aefa58156d Localisation updates from https://translatewiki.net. 2021-11-18 13:14:19 +01:00
Tom Hughes
ad0cfee788 Fix boot warnings for autoloaded constants in initializers 2021-11-16 19:08:26 +00:00
Tom Hughes
02fb858956 Send plain errors for non HTML resources
Without this we throw a second error when we can't find a view
of the correct format and issue a 500 response.
2021-11-16 12:44:52 +00:00
Tom Hughes
e3966479a6 Fix new rubocop warnings 2021-11-16 08:48:35 +00:00
Tom Hughes
7b1e78e247 Update bundle 2021-11-16 08:48:35 +00:00
Tom Hughes
e342314d8b Merge remote-tracking branch 'upstream/pull/3353' 2021-11-16 08:21:17 +00:00
translatewiki.net
0c306b5524 Localisation updates from https://translatewiki.net. 2021-11-15 13:11:44 +01:00
Tom Hughes
e21b9b2bf1 Merge remote-tracking branch 'upstream/pull/3365' 2021-11-11 15:33:08 +00:00
Tom Hughes
33f38fa372 Merge remote-tracking branch 'upstream/pull/3364' 2021-11-11 15:30:37 +00:00
Andy Allan
75749cc540 Convert remaining heading titles to use h1
This makes them consistent with all the other pages that use h1
in the `content_for :heading` sections
2021-11-11 15:12:23 +00:00
Andy Allan
3719e8defb Remove the userinformation ids from headings
The style rule was removed in 3f8cf32272
and they were otherwise only used in the tests.
2021-11-11 14:53:36 +00:00
translatewiki.net
c615bebc29 Localisation updates from https://translatewiki.net. 2021-11-11 13:10:14 +01:00
Tom Hughes
425818913b Merge remote-tracking branch 'upstream/pull/3363' 2021-11-10 18:26:34 +00:00
Tom Hughes
8da015ac88 Merge remote-tracking branch 'upstream/pull/3362' 2021-11-10 18:21:01 +00:00
Tom Hughes
71f01eab43 Merge remote-tracking branch 'upstream/pull/3361' 2021-11-10 18:15:59 +00:00
Andy Allan
9c9bf153cd Simplify user_image and user_thumbnail css
Now that all uses of the images and thumbnails have been migrated
to flex grids, we can remove the margin and padding from the original
css classes and revert to using them.
2021-11-10 15:30:42 +00:00
Andy Allan
a9ca2fe7e7 fixup popup 2021-11-10 15:29:28 +00:00
Andy Allan
dc67e54958 Use grid for dashboard map popups 2021-11-10 15:19:31 +00:00
Andy Allan
aa77ff5aec Use flex grid for issue reports and comments 2021-11-10 15:06:54 +00:00
Andy Allan
2c9d2486ec Use flex grid for diary index headings 2021-11-10 14:54:54 +00:00
Andy Allan
afce5886f4 Rework diary entries to use grid when a heading thumbnail is shown
This happens on the index page, but not individual show pages. I've
reversed the if condition to avoid having an else on a negative
condition.
2021-11-10 14:46:52 +00:00
Andy Allan
ee9c8ff7c8 Use grid for diary entry heading layout
This brings it into line with the user profile, which has a similar heading
2021-11-10 14:41:27 +00:00
Andy Allan
6283d0a47a Rework diary comments to use flex grid rather than floats and margins 2021-11-10 14:32:13 +00:00
Andy Allan
6181919b61 Fix erblint errors from the Rails/ContentTag cop 2021-11-10 12:23:48 +00:00
Tom Hughes
ceebd74bd7 Drop rubocop-rails version lock 2021-11-09 18:31:46 +00:00