Tom Hughes
8773ec6e57
Switch to using selenium for system tests
2020-04-22 13:51:37 +01:00
Tom Hughes
c51786d10b
Merge remote-tracking branch 'upstream/pull/2596'
2020-04-22 13:44:17 +01:00
Tom Hughes
359d76c8f0
Redirect to the error page for non-existent issues
2020-04-22 12:37:56 +01:00
Andy Allan
1aa5a54419
Refactor site controller tests to inherit from ActionDispatch::IntegrationTest
...
This is the modern way of writing controller tests, since it uses the
rails middleware (among other things) and leads to more realistic tests.
Refs #2563
2020-04-22 11:09:13 +02:00
Tom Hughes
ef147d479e
Fix new rubocop warnings
2020-04-19 19:06:07 +01:00
Tom Hughes
7a1615bc55
Fix rubocop-minitest warnings
2020-04-15 19:07:13 +01:00
Andy Allan
a219df24ca
Ensure that urls are only valid if the entire string is a url
...
This replaces our homegrown regexps (that didn't quite work) with
ruby built-in regexps, and uses the termination anchor to ensure
that the entire string, not just the first part, is validated.
2020-04-01 17:53:37 +02:00
Tom Hughes
e47c11c644
Merge remote-tracking branch 'upstream/pull/2577'
2020-04-01 11:56:27 +01:00
Andy Allan
055a976051
Remove custom table styling
...
This removes the custom table styling code, and move to using bootstrap table styling for almost all remaining tables.
2020-04-01 12:29:01 +02:00
Tom Hughes
0e902b5424
Set QT_QPA_PLATFORM=offscreen for Ubuntu etc
...
Fixes #2569
2020-03-25 17:04:44 +00:00
Tom Hughes
e693063fa5
Make linkify return an HTML safe result for unsafe inputs
...
Fixes #2567
2020-03-22 12:59:39 +00:00
Andy Allan
1cb0767e3d
Copy trace fixture files, rather than symlinking
...
Since we are using tmpdirs in order to enable parallel testing, we
can go the full hog and drop the fakefs too and just copy all the
files directly into the tmpdir. If a test makes changes (e.g.
changing the icon file during an import) the copy in the tmpdir is
thrown away at the end of the test anyway.
2020-03-18 15:35:55 +01:00
Andy Allan
0e612ea99a
Remove unused directories
2020-03-18 15:04:18 +01:00
Andy Allan
6bd6cbd203
Enable parallel tests
2020-03-18 15:04:18 +01:00
Andy Allan
979a474c68
Use unique test directories for each trace test
...
This allows tests to be run in parallel, since it avoids deleting
some of the symlinks that other tests expect to be there.
2020-03-18 15:04:18 +01:00
Andy Allan
8407c0dd98
Use the settings for the destination of the gpx fixture symlinks
...
This lets us change the settings values and have the fixtures appear
in the right place.
2020-03-18 14:58:48 +01:00
Andy Allan
5fdada204c
Use bootstrap table striping to replace hand-cycled table stripes
...
This cuts down on the complexity of having to use the `cycle` function
and makes the templates easier to read. CSS-based striping has been
around for many years.
The CSS is in order to keep our custom colour for striped tables.
2020-03-18 12:14:24 +01:00
Tom Hughes
06122fc090
Enforce restrictions on issue visibility properly
2020-03-01 19:20:18 +00:00
Andy Allan
93da959699
Merge pull request #2542 from boubascript/master
...
Show mailto: links for email values in browse
2020-02-26 17:09:27 +01:00
Andy Allan
73c95847a6
Merge pull request #2485 from mmd-osm/patch/json2
...
JSON output nodes, ways, relations, map
2020-02-26 15:55:48 +01:00
Boubacar
5d7b09e3bd
change validation to accept only single email values
2020-02-19 23:44:40 -05:00
Boubacar
c42722d57d
Add email link helper to create mailto: links for email values in objects
2020-02-16 21:46:48 -05:00
Andreas Geyer-Schulz
f6f23ed0ee
Fix typo: change 'noreferer' to 'noreferrer'
...
as the correct rel attribute in external links.
2020-01-25 20:10:23 +01:00
mmd-osm
3159c3c3f7
JSON: return HTTP 406 for unsupported formats
2020-01-22 22:33:30 +01:00
mmd-osm
b556b054d1
JSON: added clarification for non-supported Accept header formats
2020-01-22 17:38:28 +01:00
Andy Allan
a3795cddbb
Move the search results to use list-group-flush
2020-01-16 12:39:13 +01:00
Andy Allan
f885cfe0f5
Rename form-row to standard-form-row to avoid clashing with a bootstrap class
2020-01-15 17:16:11 +01:00
Tom Hughes
e72acaca9b
Merge remote-tracking branch 'upstream/pull/2495'
2020-01-15 10:11:30 +00:00
mmd-osm
03ca0b2c69
Added Accept header unit tests
2020-01-12 17:46:11 +01:00
mmd-osm
91b31f03de
Added unit tests
2020-01-08 19:57:21 +01:00
Andy Allan
9643e3393d
Update tests to ensure referer is working
...
This reinstates the form tests in the controller test, but uses
the system tests to actually click the button and make sure that
it works
2020-01-08 18:26:57 +01:00
Andy Allan
8a774e7519
Use a post link to logout
...
This avoids needing to access the session id, which is currently
only working with the memcache store.
The fallback page is preserved for anyone who wants to logout without
using javascript.
Refs #2488
2020-01-08 14:03:05 +01:00
Tom Hughes
473da378b7
Remove fallback to hostip.info
...
We haven't used hostip.info in production for years, except
for when we did so by accident, leading to a two hour partial
outage when it went down.
2020-01-06 19:14:12 +00:00
mmd-osm
b54333fa6d
Unify lat/lon formatting for json output
2020-01-02 14:52:53 +01:00
Tom Hughes
2f1705db7c
Test language specific versions of about and copyright pages
2019-12-30 22:52:31 +00:00
Tom Hughes
bb2c5677df
Add some missing route tests for the site controller
2019-12-30 22:37:24 +00:00
mmd-osm
75a49786f8
API JSON output
2019-12-30 16:37:52 +01:00
Andy Allan
c4c1f8ded3
Reformat params hashes to avoid super-long lines
2019-12-18 15:58:37 +01:00
Tom Hughes
6f8966e7c1
Note events use "opened" not "open" as the status
2019-12-16 22:26:33 +00:00
Tom Hughes
4ee60c0f8f
Make all translation lookup errors throw exceptions in test mode
2019-12-16 21:54:11 +00:00
Tom Hughes
ac6a872a48
Avoid errors when /edit is called on an invalid object
2019-12-16 21:23:09 +00:00
Tom Hughes
9153fd3559
Fix link in error page when a user has public edits disabled
2019-12-12 18:50:30 +00:00
Andy Allan
7595e5a4dd
Use squiggly heredocs instead of rails strip_heredoc
...
Squiggly heredocs were introduced in ruby 2.3 and I prefer the ability
to indent the closing heredoc marker.
2019-12-11 10:54:19 +01:00
Tom Hughes
57f5b7840e
Fix rubocop warnings
2019-12-04 19:31:53 +00:00
Andy Allan
f1c6a87aa1
Merge pull request #2427 from mmd-osm/patch/remove_expand_bbox
...
Remove expand_bbox endpoint
2019-12-04 12:48:34 +01:00
Andy Allan
44c6fdc273
Use the conventional 'destroy' method name for destroying traces
2019-12-04 11:59:18 +01:00
Tom Hughes
dba3940571
Replace content_tag_for with a simple tr element
2019-12-03 22:54:55 +00:00
Tom Hughes
c468af5fbd
Errors have text/plain as the content type
2019-11-24 11:05:02 +00:00
Tom Hughes
1f4d48eaf3
Fix some deprecation warnings
2019-11-24 11:05:02 +00:00
Tom Hughes
22cd2314e5
Update to rails 6.0.1
2019-11-24 11:05:02 +00:00
