Andy Allan
bb2afc3e8b
Prevent addition of style attributes to all elements
2021-03-24 20:55:30 +00:00
Andy Allan
d7eac9b5a8
Strip away class attributes from sanitized outputs
...
There's a lot of shenanigans that are possible when you can apply
arbitrary classes to the rendered output.
2021-03-24 19:15:21 +00:00
Andy Allan
5d39bf8491
Add tests for richtext table classes
2021-03-24 17:55:15 +00:00
Andy Allan
9fd96cfb87
Move sessions-related tests out of UsersControllerTest
2021-03-24 11:40:17 +00:00
Andy Allan
f18baae22e
Refactor login/logout into sessions controller
...
Certain controller methods are shared with oauth-based logins, and these have been
moved to a concern.
2021-03-24 11:32:46 +00:00
Tom Hughes
3512d6303c
Fix new rubocop warnings
2021-03-23 19:48:13 +00:00
Andy Allan
a08fe1c291
Use list-inline to achieve spacing between elements on a line
...
This is a better solution than spans and margins. Additionally, rework
to use mb-* instead of my-* (bootstrap advises against using margin-top)
and get rid of <br>s by using paragraphs instead.
2021-03-17 18:57:36 +00:00
Andy Allan
4dc584421a
Refactor traces list display
...
Ideas taken from #3036
2021-03-17 18:04:00 +00:00
Tom Hughes
01b84a8107
Merge remote-tracking branch 'upstream/pull/3125'
2021-03-10 14:55:58 +00:00
Andy Allan
38ad8fbc36
Use login_path instead of explicit controller and actions
...
This makes future refactoring easier.
2021-03-10 14:31:55 +00:00
Andy Allan
952cf0fdb4
Remove the old richtext_area helper
...
This has been superseded by the `f.richtext_field` custom form builder.
2021-03-03 15:34:16 +00:00
Tom Hughes
1f136a84a6
Prevent CSRF bypass with login form
2021-02-10 20:39:23 +00:00
Tom Hughes
51af102c00
Prevent CSRF bypass with password reset form
2021-02-09 23:00:21 +00:00
mmd-osm
c49e400aa3
Prevent CSRF bypass unblocking users
2021-02-09 20:39:04 +00:00
Tom Hughes
7810734ac4
Prevent CSRF bypass updating account details
...
Fixes #3089
2021-02-08 12:24:43 +00:00
Tom Hughes
e430bc0f7f
Fix URL generation for atom feed on history page
...
Fixes #3085
2021-02-07 16:24:14 +00:00
Tom Hughes
66b5e85845
Merge remote-tracking branch 'upstream/pull/3078'
2021-02-03 14:48:24 +00:00
mmd-osm
4e6d729529
Remove /api/0.6/changes endpoint
...
Also removes sql functions which are only used by this endpoint
2021-02-03 14:06:34 +00:00
Tom Hughes
5912a8011b
Update to Omniauth 2.x
...
This requires converting all use of the /auth endpoints
to use the POST method as GET is no longer supported.
2021-02-02 19:49:03 +00:00
Andy Allan
a7d959e588
Refactor account form to use bootstrap
...
There's further refactoring that could be done, but this is sufficient for now.
2021-01-27 17:59:58 +00:00
Andy Allan
cc8bb7c6a5
Refactor user registration form to use bootstrap
2021-01-20 15:38:10 +00:00
Frederik Ramm
d14083129c
Fix a small typo and tests that depend on it.
2021-01-19 20:56:43 +01:00
Tom Hughes
812f5b44e8
Redirect after saving settings in case the username has changed
...
Fixes #3059
2021-01-19 18:57:34 +00:00
Tom Hughes
0654be27f9
Fix new rubocop warnings
2021-01-11 19:17:31 +00:00
Tom Hughes
0ff89c31e4
Remove both Potlatch versions
...
Fixes #2622
2021-01-05 21:18:45 +00:00
Tom Hughes
786b8cce65
Verify that public and trackable traces don't return identity details
2020-12-30 17:58:04 +00:00
Andy Allan
2519841efe
Return the centre of the image if the bbox has no extent
...
Fixes #3007 . If all the provided points in the gpx file have the same
lat/lon, then an image where they are all at the centre seems plausible.
2020-12-23 15:01:01 +00:00
Tom Hughes
c9a4c78146
Make coverage testing work with parallel tests
...
https://github.com/simplecov-ruby/simplecov/issues/718#issuecomment-538201587
2020-12-18 22:39:23 +00:00
Andy Allan
bd1420a7c5
Merge pull request #3009 from gravitystorm/svg_icons
...
Add updated authentication icons
2020-12-17 11:44:22 +00:00
Andy Allan
c192bd0d40
Use bootstrap utility class instead of custom css
2020-12-16 17:34:12 +00:00
Tom Hughes
4a9f8a5e69
Move coveralls submission to actions workflow
2020-12-10 00:11:50 +00:00
Tom Hughes
88ba316abe
Merge remote-tracking branch 'upstream/pull/2999'
2020-12-09 14:51:04 +00:00
Andy Allan
dd8e5f04e3
Add a test for i18n interpolation into plain and html parts
...
I spent some time working on an alternative translation strategy, without realising some of the plain text implications.
2020-12-02 13:02:25 +00:00
Andy Allan
b83c0acbd1
Fix trace tag interpolation, and add a test
2020-11-25 11:34:35 +00:00
mxdanger
aad1c1b933
Add updated authentication logos
2020-11-13 20:02:00 -08:00
Tom Hughes
99e537859a
Fix HTML escaping issues with user role icons
2020-11-13 15:13:37 +00:00
Tom Hughes
bfffe7ed96
Prefer string interpolation to concatenation
2020-11-13 11:32:28 +00:00
Tom Hughes
582402ba8f
Prefer keyword arguments when method has optional boolean arguments
2020-11-13 10:22:55 +00:00
Andy Allan
1f242978af
Prefer keyword arguments when method has optional boolean arguments
2020-11-12 11:24:44 +00:00
Andy Allan
a65cb84288
Remove unused code
2020-11-11 16:43:58 +00:00
Andy Allan
01b72f7adf
Fix missing html layout for user_mailer emails
...
This was caused by renaming the mailer without renaming the layout. Added a test to cover this in future.
Fixes #2903
2020-11-11 11:19:20 +00:00
Tom Hughes
93e49daee2
Merge remote-tracking branch 'upstream/pull/2918' into master
2020-10-28 11:29:57 +00:00
Andy Allan
da2277505f
Ensure that test utility methods are marked as private
...
This allows us to enable the check for test method names.
2020-10-28 11:49:01 +01:00
Andy Allan
86a5e198f7
Refactor test to use general basic_authorization_header method
...
There's no need for this test to have its own version of the method.
2020-10-28 11:33:51 +01:00
Andy Allan
c04d05686f
Resolve some extra-long lines
2020-10-28 11:07:34 +01:00
Tom Hughes
e72092161b
Update test results for presence of zh-HK translations
2020-10-19 19:26:17 +01:00
Tom Hughes
2dc50b4431
Fix new rubocop warnings
2020-10-09 08:26:38 +01:00
Tom Hughes
ddac660f3b
Merge remote-tracking branch 'upstream/pull/2839'
2020-09-30 11:54:30 +01:00
mmd-osm
37a7996d94
API User details: format tweaks
...
- _show_ to return single user only
- remove nesting for languages
2020-09-18 21:50:38 +02:00
mmd-osm
dff8effc13
Json user details: unit tests
2020-09-16 22:13:19 +02:00