Ensure that urls are only valid if the entire string is a url
This replaces our homegrown regexps (that didn't quite work) with ruby built-in regexps, and uses the termination anchor to ensure that the entire string, not just the first part, is validated.
This commit is contained in:
parent
e47c11c644
commit
a219df24ca
2 changed files with 6 additions and 6 deletions
|
@ -3,7 +3,7 @@ require "test_helper"
|
|||
class ClientApplicationTest < ActiveSupport::TestCase
|
||||
def test_url_valid
|
||||
ok = ["http://example.com/test", "https://example.com/test"]
|
||||
bad = ["", "ftp://example.com/test", "myapp://somewhere"]
|
||||
bad = ["", "ftp://example.com/test", "myapp://somewhere", "http://example.com\nhttp://example.net"]
|
||||
|
||||
ok.each do |url|
|
||||
app = build(:client_application)
|
||||
|
@ -20,7 +20,7 @@ class ClientApplicationTest < ActiveSupport::TestCase
|
|||
|
||||
def test_support_url_valid
|
||||
ok = ["", "http://example.com/test", "https://example.com/test"]
|
||||
bad = ["ftp://example.com/test", "myapp://somewhere", "gibberish"]
|
||||
bad = ["ftp://example.com/test", "myapp://somewhere", "gibberish", "http://example.com\nhttp://example.net"]
|
||||
|
||||
ok.each do |url|
|
||||
app = build(:client_application)
|
||||
|
@ -37,7 +37,7 @@ class ClientApplicationTest < ActiveSupport::TestCase
|
|||
|
||||
def test_callback_url_valid
|
||||
ok = ["", "http://example.com/test", "https://example.com/test", "ftp://example.com/test", "myapp://somewhere"]
|
||||
bad = ["gibberish"]
|
||||
bad = ["gibberish", "http://example.com\nhttp://example.net"]
|
||||
|
||||
ok.each do |url|
|
||||
app = build(:client_application)
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue