Gracefully handle neighbor-less LLDP devices #309

Open

ribetm wants to merge 1 commit from ribetm/lldp_loneliness into main

ribetm commented

2024-10-17 16:48:38 +02:00

(Migrated from github.com)

lldpd may be successful but empty

`lldpd` may be successful but empty

c0ff3e commented

2024-10-18 08:50:07 +02:00

(Migrated from github.com)

vill not #292 do the same ?

ribetm commented

2024-10-18 10:44:23 +02:00

(Migrated from github.com)

vill not #292 do the same ?

You could say both have similar intents, but #292 is about lshw while mine is about lldpd.

Also, one notable difference is that #292 uses placeholders while mine simply does nothing if there are no visible neighbors

It's actually closer to this eb0a3a596f (from #279) but I prefer my solution since it allows us to support LLDP-compatible virtual switchs like OVS

> vill not #292 do the same ? You could say both have similar intents, but #292 is about `lshw` while mine is about `lldpd`. Also, one notable difference is that #292 uses placeholders while mine simply does nothing if there are no visible neighbors It's actually closer to this https://github.com/Solvik/netbox-agent/pull/279/commits/eb0a3a596fb6fc2ab13dc1dea1854189ed64f849 (from #279) but I prefer my solution since it allows us to support LLDP-compatible virtual switchs like OVS

👍 1

c0ff3e commented

2024-10-18 16:02:42 +02:00

(Migrated from github.com)

Sorry mixed it up, problem with working with 5 things simultaneously.

This pull request has changes conflicting with the target branch.

netbox_agent/lldp.py

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin ribetm/lldp_loneliness:ribetm/lldp_loneliness

git checkout ribetm/lldp_loneliness

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git checkout main

git merge --no-ff ribetm/lldp_loneliness

git checkout ribetm/lldp_loneliness

git rebase main

git checkout main

git merge --ff-only ribetm/lldp_loneliness

git checkout ribetm/lldp_loneliness

git rebase main

git checkout main

git merge --no-ff ribetm/lldp_loneliness

git checkout main

git merge --squash ribetm/lldp_loneliness