Virtualmachine corrections #279

Merged

obeone merged 3 commits from obeone/virtualmachine_corrections into master

2024-10-21 12:32:31 +02:00

obeone commented

2023-08-21 20:46:11 +02:00

(Migrated from github.com)

I add missing debug print (--debug was failing on a VM).

And if lldp is enabled and we are on a VM, multiple errors occurred. I add some checks.

And last thing, maybe it has to be in a separate PR (but for one line...), main now return 0 if everything was ok, as it's what a shell except

I add missing debug print (--debug was failing on a VM). And if lldp is enabled and we are on a VM, multiple errors occurred. I add some checks. And last thing, maybe it has to be in a separate PR (but for one line...), main now return 0 if everything was ok, as it's what a shell except

Solvik commented

2023-08-28 19:04:00 +02:00

(Migrated from github.com)

Hi @obeone

Thanks for this second PR
Could you remove the update to requirements.txt as it's already handled by your other PR ?

Thanks

Hi @obeone Thanks for this second PR Could you remove the update to requirements.txt as it's already handled by your other PR ? Thanks

obeone commented

2023-08-30 17:22:43 +02:00

(Migrated from github.com)

Yes !
Sorry, I realized after that this branch embedded the other PR, and I was hoping you'll accept the other one 😄

I do that soon !