Commit graph

4091 commits

Author SHA1 Message Date
mfo
b6464c1963
tech: use facet_id to sort fields 2024-08-19 15:30:08 +02:00
mfo
743ff8c8a9
extract Instructeurs::FacetTableHeaderComponent wrapping sort logic 2024-08-19 15:30:08 +02:00
simon lehericey
61051771a7
stay the old way for the moment ? 2024-08-19 15:30:07 +02:00
simon lehericey
ef63579e2e
clean facets_concern 2024-08-19 15:30:07 +02:00
mfo
60c6c86d70
ProcedurePresentation.displayable_fields_for_select -> InstructeurFacetPickerComponent.displayable_fields_for_select 2024-08-19 15:29:59 +02:00
mfo
41ea39abb1
ProcedurePresentation.filterable_fields_options -> InstructeurFilterComponent.filterable_fields_options 2024-08-19 15:29:59 +02:00
simon lehericey
379c9fb812
procedure should provide its facets 2024-08-19 15:29:59 +02:00
simon lehericey
e19f1bd8c2
sortable? -> sorted_by 2024-08-19 15:29:59 +02:00
simon lehericey
c5c2d5782d
lets keep it private 2024-08-19 15:29:59 +02:00
simon lehericey
7a1c25271d
small refactors 2024-08-19 15:29:56 +02:00
simon lehericey
772424ff5e
move field_enum to instructeur filter component 2024-08-19 15:28:36 +02:00
simon lehericey
73293b0d06
give facet object instead of field_id to instructeur_filter_component 2024-08-19 15:28:36 +02:00
simon lehericey
437e632f6a
move facet_find to Facet.find 2024-08-19 15:28:36 +02:00
simon lehericey
969282e453
remove last field_hash 2024-08-19 15:28:36 +02:00
simon lehericey
305b8c13c7
! BREAKING : break previous filter by type_de_champ_private
simplify type_de_champ_private -> type_de_champ, fix spec, add facet_spec
2024-08-19 15:28:36 +02:00
simon lehericey
2239172fac
move facets list to facets 2024-08-19 15:28:36 +02:00
simon lehericey
49eaf10bce
fields -> facets 2024-08-19 15:28:36 +02:00
simon lehericey
5c09581228
move id to facet and search_by facet_id 2024-08-19 15:28:34 +02:00
mfo
b3cb3e974e
refactor(Facet): extract Facet from ProcedurePresentation
Co-Authored-By: LeSim <mail@simon.lehericey.net>

clean(code): no comment 🎶
2024-08-19 15:27:39 +02:00
Kara Diaby
88cd4a94dd
Ajoute la validation sur le modèle Individual 2024-08-19 12:51:39 +00:00
Paul Chavard
065000cae3
Merge pull request #10674 from colinux/really-fix-rnf
ETQ usager, permet de saisir un champ RNF en ignorant les espaces/tabulations
2024-08-01 18:09:21 +00:00
Colin Darie
c2159ca0bf
fix(contact): allow deletion of contact form of users having dossiers 2024-08-01 19:44:44 +02:00
Colin Darie
720a312b00
fix(rnf): really normalize spaces
Fix #10653
2024-08-01 18:54:50 +02:00
Paul Chavard
25d4e7dfee
fix(rnf): no crash on identifiers with spaces 2024-08-01 18:00:46 +02:00
Colin Darie
4b6d3ee16d
refactor(contact): support => contact 2024-07-31 17:08:02 +02:00
Colin Darie
5af32b46f4
refactor(contact): form is persisted in db before pushed to HS 2024-07-31 17:08:01 +02:00
Colin Darie
4bc0a04106
chore(schema): add contact_forms 2024-07-31 17:08:01 +02:00
Paul Chavard
9d7d7da85a
Merge pull request #10572 from demarches-simplifiees/add-pj-from-messagerie-to-gallery
ETQ instructeur je peux voir les pjs envoyées par la messagerie dans l‘onglet "pièces jointes"
2024-07-30 09:35:14 +00:00
Paul Chavard
337eaff3f0
Merge pull request #10602 from demarches-simplifiees/fix-routing-fields-list
Correctif : ouvre l‘assistant de routage à tous les types de champ conditionnables
2024-07-30 09:01:24 +00:00
simon lehericey
057868a48e
small work on tiptap 2024-07-26 13:34:49 +02:00
simon lehericey
8906a59635
simplify export_template model and spec 2024-07-26 13:34:49 +02:00
simon lehericey
977cfc87ce
Add export_item type 2024-07-26 13:31:06 +02:00
simon lehericey
24109a0128
add exportables_pieces_jointes_for_all_versions and outdated to pj_list_concern 2024-07-26 13:31:06 +02:00
simon lehericey
53a48f963d
tdc: add libelle_as_filename 2024-07-26 13:31:05 +02:00
Paul Chavard
223317fb5a
fix(rebase): avoid errors when adding pj champs to a new revision 2024-07-25 18:29:01 +02:00
Lisa Durand
4f7b0c93d0
fix multiple errors from creation of dedicated method to restore and extend 2024-07-25 16:55:00 +02:00
Lisa Durand
7da3e05752
small refacto to simplify scope 2024-07-24 17:07:48 +02:00
Lisa Durand
b820577461
create a method to extend and restore 2024-07-24 17:07:48 +02:00
Lisa Durand
ae1a6e1b3d
improve hidden_by_expired scope 2024-07-24 17:07:47 +02:00
Lisa Durand
5c26073af7
small refacto with hidden_by_expired? method 2024-07-24 17:07:47 +02:00
Lisa Durand
df13e53815
small refactos from Sim review 2024-07-24 17:07:47 +02:00
Lisa Durand
94e1f048ce
fix tabs count 2024-07-24 17:07:47 +02:00
Lisa Durand
eb3b928cf2
change scope to include new column for expiring dossiers 2024-07-24 17:07:47 +02:00
Lisa Durand
0dcdcb5643
add column hidden_by_expired_at 2024-07-24 17:07:41 +02:00
Lisa Durand
1441855fe8
fix query for instructeur tabs count 2024-07-24 17:06:31 +02:00
Lisa Durand
2d66a67564
use automatic flag for dossier operation log 2024-07-24 17:06:31 +02:00
Lisa Durand
9346020889
dont use depreciated column hidden_at 2024-07-24 17:06:30 +02:00
Lisa Durand
8b88fafc25
add correct action for instructeur 2024-07-24 17:06:30 +02:00
Lisa Durand
c2abceaa72
hide expired dossiers instead of delete them 2024-07-24 17:06:30 +02:00
Paul Chavard
229483d16c
refactor(champ): remove type_de_champ_id and champ factories 2024-07-22 13:53:45 +02:00
Eric Leroy-Terquem
3bbcda9c04
refactor(dossier): refactor pieces jointes 2024-07-22 10:07:39 +02:00
Eric Leroy-Terquem
3516bae008
feat(gallery): create representations for pjs sent by messagerie 2024-07-22 10:07:39 +02:00
Paul Chavard
be83f2c7d1
Merge pull request #10609 from tchak/champs-selection-multiple-combobox
Utiliser les nouvelles combobox pour les champs de sélection multiple
2024-07-16 13:17:41 +00:00
Paul Chavard
d640ab8428
fix(combobox): dispatch change event on multiple combo changes 2024-07-16 15:10:45 +02:00
Paul Chavard
42ed6d7c87
refactor(dossier): use each instead of filter with side effects 2024-07-16 09:03:56 +02:00
Lisa Durand
7630cc39fa
Merge pull request #10595 from demarches-simplifiees/email-mandant-need-confirmation-ldu
ETQ Mandant, je dois confirmer mon mail avant de recevoir des notifs
2024-07-15 14:00:38 +00:00
Lisa Durand
e9f5389f83
resent email if link too old and better style email 2024-07-15 12:00:03 +02:00
Lisa Durand
3eabcb0736
add tests 2024-07-15 11:56:18 +02:00
mfo
b55ed262ed
Merge pull request #10607 from mfo/US/fix-invisible-pj
Amélioration: ETQ usager, je souhaite que les PJs d'un champ qui n'est plus visible ne soient pas soumise a l'administration
2024-07-15 09:36:01 +00:00
mfo
1cd539297f
feat(dossier.passer_en_construction!): clean up PJ for champs that are not visible [condition is false] 2024-07-15 11:28:59 +02:00
mfo
d5c8b7464c
fix(users.update_email): optimistic 2024-07-12 15:42:50 +02:00
Eric Leroy-Terquem
ea8112b8b3
fix(routing): open routing wizard to all conditionable types 2024-07-11 14:55:03 +02:00
Eric Leroy-Terquem
60ff785009
refactor(type de champ): rename routable_types in simple_routable_types 2024-07-11 12:17:46 +02:00
Lisa Durand
7539d2ddea
fix specs 2024-07-10 16:11:38 +02:00
Lisa Durand
42633c0012
Merge branch 'main' of github.com:betagouv/demarches-simplifiees.fr into instructeur-invitation-include-typo-suggestion-ldu 2024-07-10 14:58:55 +02:00
Lisa Durand
3b138d5bb7
add confirmation for tiers email 2024-07-10 10:57:26 +02:00
mfo
f3690d8890
Merge pull request #10587 from tchak/refactor-no-validate-on-format
refactor(champ): remove call to validation from value formatting code
2024-07-09 14:31:10 +00:00
Colin Darie
142ed6f762
fix(cojo): fetch external data when "-01" suffix is typed, even if its deleted later by .to_i 2024-07-09 12:49:22 +02:00
Paul Chavard
133689b4d3
refactor(champ): remove call to validation from value formatting code 2024-07-08 15:39:28 +02:00
Colin Darie
3e9cb6f388
Merge pull request #10576 from colinux/secure-cookies
Tech: cookies avec flag `secure` et `httponly`
2024-07-08 09:33:30 +00:00
mfo
75a6c8b4b6
Merge pull request #10555 from mfo/US/normalize-number-cahmp
tech: Normalisation des champs de type number/decimal pr enlever les espace blanc à la saisi
2024-07-08 07:31:29 +00:00
Paul Chavard
f0f88ef3f0
refactor(champ): update champ drop_down_list 2024-07-05 09:36:33 +02:00
Paul Chavard
cb01f15570
refactor(champ): update champ commune 2024-07-05 09:36:33 +02:00
Paul Chavard
f1f1af4e61
refactor(champ): update champ annuaire education 2024-07-05 09:36:33 +02:00
Paul Chavard
79a65a4847
refactor(champ): update champ address 2024-07-05 09:36:33 +02:00
mfo
c50f949acd
feat(Champs::number*): normalize values by stripping spaces. 2024-07-04 09:56:23 +02:00
Lisa Durand
c8906d20b8
add reusable code in concern for typo detection email 2024-07-03 16:09:34 +02:00
Colin Darie
1eb0bdb4ae
chore: cookies with "secure" flag (only transmitted through https) 2024-07-03 11:18:16 +02:00
Colin Darie
b3ccfc16c4
Merge pull request #10547 from colinux/mandatory-by-default
ETQ admin, un nouveau champ est obligatoire par défaut
2024-07-02 14:26:29 +00:00
Eric Leroy-Terquem
2b0c53cd82
Merge pull request #10565 from demarches-simplifiees/add-demarches-publiees-page-in-manager
ETQ superadmin, je peux accéder aux informations essentielles des dernières démarches publiées
2024-07-02 07:46:30 +00:00
Eric Leroy-Terquem
0a70c6b90f
manager: add a page for demarches publiees 2024-06-28 18:20:05 +02:00
Colin Darie
48e5a237e3
chore(schema): change default types_de_champ#mandatory from false to true 2024-06-25 17:17:21 +02:00
Lisa Durand
d7893b9102
instructeur need to confirm mail after invitation 2024-06-25 15:14:26 +02:00
Colin Darie
ccf5b255ed
Merge pull request #10465 from colinux/attestations-v2-prod
ETQ admin je peux activer la délivrance des attestations v2 (sous feature flag)
2024-06-24 08:56:31 +00:00
mfo
2ee6f2350a
Merge pull request #10536 from mfo/US/summary-in-instructeur-demande
ETQ instructeur, je peux naviguer dans le formulaire de l'usager via un sommaire, idem pour les annotations privées.
2024-06-21 14:44:50 +00:00
mfo
4caeecadff
Merge pull request #10534 from mfo/US/fix-ineligibilite-rules-check-without-rules
Correctif: ETQ admin, je ne peux pas activer l'inéligibilité des dossiers sans règles d'inéligibilité
2024-06-21 09:47:43 +00:00
mfo
d46dc7055d
feat(instructeurs/dossiers): add summary to dossier.champs and dossier.champ_private views, also extract summary in
two component. one of type de champ editor. one for viewable champs
2024-06-21 11:06:45 +02:00
mfo
5a5ebfb235
Merge pull request #10531 from mfo/US/add-champ-summary-to-annotations
ETQ administrateur, je peux naviguer dans l'editeur des annotations en utilisant le sommaire façon editeur des champs du formulaire
2024-06-21 08:34:12 +00:00
mfo
6eaf870cbf
feat(administrateurs/procedure#annotations): add summary 2024-06-21 05:50:24 +02:00
mfo
24d7b0b014
fix(ineligibilite_rules): prevent admin to enable ineligibilite rules without rules 2024-06-20 15:35:36 +02:00
mfo
9adb1bcf49
fix(ineligibilite_rules): cache bust champs.visible after checking for ineligibilite rules
Update app/models/dossier.rb

Co-authored-by: Paul Chavard <github@paul.chavard.net>
2024-06-20 15:20:32 +02:00
Colin Darie
f2669fbca8
fix(attestation): fix unspecified_attestation_champs for v2 2024-06-20 14:15:06 +02:00
Colin Darie
a540f8dccb
feat(attestation): can render & attach attestations v2 2024-06-20 14:15:05 +02:00
Colin Darie
11d29f5574
chore(attestation): publish a v2 attestation 2024-06-20 11:08:15 +02:00
Colin Darie
4af6957237
fix(attestation): dup keep all attributes 2024-06-20 11:08:15 +02:00
Colin Darie
c5c24c01d8
chore(attestation): procedure#attestation_template always returns the published attestation 2024-06-20 11:08:15 +02:00
Colin Darie
ad3c5a7493
chore(schema): add attestation_templates#state 2024-06-20 11:08:15 +02:00
Benoit Queyron
97ef01b075
Merge branch 'main' into etq-usager-bouton-jdma 2024-06-11 18:09:01 +02:00
mfo
f6a5e932b8
Merge pull request #10292 from mfo/US/elligible-on-submit
ETQ administrateur, je peux ajouter des conditions d'eligibilité auxquelles les dossiers doivent correspondre sans quoi l'usager ne peut déposer son dossier
2024-06-11 09:46:25 +00:00
mfo
f819da8921
tech(clean): simplify implementation of eligibilite rules, code, enhance wording and test coverage 2024-06-11 09:57:36 +02:00
mfo
a011576757
feat(procedure_revision.validates): ineligibilite_rules 2024-06-11 09:39:21 +02:00
mfo
c480bc00c3
feat(Users/Dossiers#submit_brouillon_or_en_construction): prevent transition to en_construction if ineligibilite_rules matches. pop error nicely 2024-06-11 09:32:54 +02:00
mfo
178685b34b
feat(TypeDeChampEditor): prevent to destroy a type de champ used by inligibilite rules 2024-06-11 09:32:54 +02:00
mfo
2210db3b81
feat(Dossier::EditFooterComponent): disable submit button when inligibilite_rules matches 2024-06-11 09:32:54 +02:00
mfo
5644692448
feat(Logic.computable?): add computable? to know if a ineligibilite_rules set is computable 2024-06-11 09:32:53 +02:00
mfo
5de4ce889f
feat(ProcedureRevision.ineligibilites_rules): keep track of changes and show it to admin for republication 2024-06-11 09:32:53 +02:00
mfo
aca3e38859
feat(ProcedureRevision.ineligibilite_rules): add ineligibilite_rules management to procedure revision based on conditional logic 2024-06-11 09:32:53 +02:00
mfo
12d23f1498
feat(Procedure::Cards::IneligibleDossier): add an ineligibilite dossier card to procedure dashboard 2024-06-11 09:32:53 +02:00
Benoit Queyron
a8e382d0d0 fix(clone): le lien monavis est reinitialise lors du clonage 2024-06-10 14:55:51 +02:00
Benoit Queyron
0983f35dfd ajout d'un helper pour la source 2024-06-10 11:09:55 +02:00
mfo
73fe247c3d feat(avis): ensure consistent ordering, use ASC ordering to give back most recent avis first 2024-06-05 17:50:32 +02:00
Kara Diaby
cb5ba455eb Fixe bug sur toutes les démarches 2024-06-05 14:13:44 +00:00
mfo
5ef29a2f31
Merge pull request #10479 from mfo/us/enhance-procedure-validation
ETQ Admin, les erreurs liés aux formulaire usager et instructeurs sont plus consistantes
2024-06-05 05:14:45 +00:00
mfo
ef3ca9839b feat(procedure.validation): extract validation context: types_de_champ_public_editor, types_de_champ_private_editor and publication [combining both contextes]. validate conditions, headers_sections, regexp on type_de_champ_private too. dry validation 2024-06-04 18:25:24 +02:00
Paul Chavard
9753a91db6
feat(graphql): messages can be discarded through api 2024-06-04 17:41:26 +02:00
mfo
f14c88a54a clean(spec): speed, avoid using with_all_champs factory. takes too much time when not needed 2024-06-04 15:34:34 +02:00
krichtof
45814fdbfb
Merge pull request #10454 from demarches-simplifiees/9827-add-specs
corrige quelques bugs de la feature export template (renommage dans le zip)
2024-06-04 13:18:12 +00:00
Christophe Robillard
ac23d5fb41 convert date with dash for export renaming 2024-06-04 10:32:14 +02:00
Paul Chavard
68c15ba99f
feat(champ): add updated_by column 2024-06-03 18:45:16 +02:00
simon lehericey
5d259ec47b
refactor(user): rename invite! -> invite_instructeur! 2024-05-31 14:53:49 +02:00
simon lehericey
607fbf5287
feat(user): block unverified_email from being sent 2024-05-31 14:53:49 +02:00
Kara Diaby
2371705efc
Merge pull request #10437 from demarches-simplifiees/feat/10332
Amélioration de la page toutes les démarches :  Quick Wins
2024-05-29 13:50:04 +00:00
Paul Chavard
ed2f615f2b
Merge pull request #10468 from tchak/fix-handle-missing-siret-information
fix(dossier): handle missing siret information when dossier passe en instruction
2024-05-29 12:19:30 +00:00
Kara Diaby
7281f3ec1a SQL pour renvoyer les zones dans ProcedureDetail 2024-05-29 11:45:31 +00:00
Paul Chavard
de209954e1
Merge pull request #10466 from tchak/fix-supprimes_recemment-should-include-archived
fix(instructeur): supprimes_recemment should include archived dossiers
2024-05-29 11:09:41 +00:00
Paul Chavard
eb9aad27c3
fix(dossier): handle missing siret information when dossier passe en instruction 2024-05-29 13:09:04 +02:00
Paul Chavard
5154231ccf
fix(dossier): batch operations to termine dossier should send emails 2024-05-29 11:31:58 +02:00
Paul Chavard
b06934b8d3
fix(instructeur): supprimes_recemment should include archived dossiers 2024-05-29 11:03:46 +02:00
Christophe Robillard
d61203e57c remove dead code 2024-05-28 19:14:57 +02:00
Christophe Robillard
d9f7b6d1df fix dossier directory for etablissement when export with export template 2024-05-28 18:25:38 +02:00
Christophe Robillard
2267ec98cf fix dossier directory for attestation when export with export template 2024-05-28 18:25:37 +02:00
Christophe Robillard
ce6ebf3589 fix dossier directory for commentaire when export with export template 2024-05-28 18:25:37 +02:00
simon lehericey
fa06d17169
Feat(user): set email_verified_at when setting confirmed_at 2024-05-27 17:24:56 +02:00
simon lehericey
841c1cc845
Feat(user): verify user email during devise confirmation 2024-05-27 17:24:55 +02:00
Paul Chavard
1bca3c123b
chore(dossier): remove legacy update attributes 2024-05-27 10:33:37 +02:00
Colin Darie
3617368a35
fix(search): increase debounce delay because of too frequent brouillon updates 2024-05-27 09:57:05 +02:00
simon lehericey
e38999efda
perf(pj service): compute row_id without extraneous requests 2024-05-23 10:01:29 +02:00
simon lehericey
6184b33a18
perf(preloader): preloader use batch for batches 2024-05-23 10:01:29 +02:00
simon lehericey
ca12a56e6a
perf(zip): give champ to avoid seeking stable_id 2024-05-23 10:00:42 +02:00
simon lehericey
080bcd8628
refactor: DossierPreloader rename includes_for_dossier -> includes_for_champ 2024-05-23 10:00:41 +02:00
simon lehericey
e8a175d310
refactor: be explicite with memoization 2024-05-23 10:00:41 +02:00
simon lehericey
420520489d
refactor(tags_substitution): simplify 2024-05-23 10:00:41 +02:00
simon lehericey
d60e7906e0
refactor: memoize flat_tags 2024-05-23 10:00:41 +02:00
simon lehericey
e0c867f222
refactor: rename 2024-05-23 10:00:40 +02:00
simon lehericey
3af1cee240
refactor: simplify 2024-05-23 10:00:40 +02:00
simon lehericey
1c0bd3e0e5
refactor: remove unused data 2024-05-23 10:00:40 +02:00
simon lehericey
43fb1ddeb5
refactor: remove target in tags 2024-05-23 10:00:40 +02:00
simon lehericey
585810553f
refactor(suffix): be consistent with index suffix 2024-05-23 10:00:39 +02:00
simon lehericey
6d757db20b
fix: champ.row_index and test pjs_for_champs 2024-05-23 10:00:39 +02:00
simon lehericey
c8b3b4b45a
refactor: renaming 2024-05-23 10:00:38 +02:00
simon lehericey
6445337be7
refactor(pj_list): extract pj list in a concern and simplify 2024-05-23 10:00:38 +02:00
Christophe Robillard
565f6f44e5
make private some methods 2024-05-23 10:00:37 +02:00
Christophe Robillard
aeb4bd2ff1
add original-filename tag 2024-05-23 10:00:36 +02:00
Christophe Robillard
43c862ed4d
list export templates for groupes instructeur of current instructeur 2024-05-23 10:00:36 +02:00
Christophe Robillard
2c28d97f3f
destroy export_template 2024-05-23 10:00:35 +02:00
Christophe Robillard
357c07456c
generate export with export_template 2024-05-23 10:00:34 +02:00
Christophe Robillard
7661b8b1b2
add export_template to exports 2024-05-23 10:00:34 +02:00
Christophe Robillard
f5813b4e55
create and update export templates 2024-05-23 10:00:33 +02:00
Christophe Robillard
95c308dc51
add specific tags 2024-05-23 10:00:33 +02:00
Christophe Robillard
a248eba641
export template: set default values 2024-05-23 10:00:33 +02:00
Christophe Robillard
dbf46b1f02
extract DOSSIER_ID_TAG 2024-05-23 10:00:32 +02:00
Christophe Robillard
bbb6309b4f
procedure: add pieces_jointes_exportables_list 2024-05-23 10:00:32 +02:00
Christophe Robillard
25ab2420fe
validate export template 2024-05-23 10:00:32 +02:00
Christophe Robillard
24922605cd
add pj for export template 2024-05-23 10:00:32 +02:00
Christophe Robillard
d1c3b84ea2
add export template model 2024-05-23 10:00:32 +02:00
mfo
29ef5b313c
fix(data): clean Champs::PieceJustificativeChamp for annotations that had been cloned 2024-05-21 14:35:51 +02:00
mfo
4ea601de79
fix(champs.pj.clone): stop cloning private piece_justificative_file when user clone his dossier 2024-05-21 09:50:27 +02:00
Colin Darie
c2b1d7aaaf
Merge pull request #10261 from colinux/ignore-search-terms-2
Tech (perf): ignore les `search_terms` colonnes pour ne plus les select à chaque query et debounce l'indexation
2024-05-21 07:07:10 +00:00
Lisa Durand
7cfd9becc8
avoid performing job if attachment is created on existed blob 2024-05-17 11:03:40 +02:00
Lisa Durand
affb1820d8
add PDF preview in view for gallery 2024-05-17 11:03:39 +02:00
Lisa Durand
93c3761107
add specs 2024-05-17 11:03:39 +02:00
Lisa Durand
b4a7b4bfbd
create a job for all image treatments 2024-05-17 11:03:38 +02:00
Lisa Durand
96238da249
add service to rotate jpg attachment automatically 2024-05-17 11:03:37 +02:00
Colin Darie
55ee9cd6bf
Merge pull request #10422 from colinux/better-sanitize-stats-year
Tech (carte): ignore silencieusement les params invalides
2024-05-16 17:53:17 +00:00
Colin Darie
3d52601155
fix(carte): gracefully ignore invalid year and kind params
Empêche d'envoyer une date invalide à PG et polluer les logs.
2024-05-16 16:58:42 +02:00
Paul Chavard
b12627f074 fix(dossier): fix n+1 on header sections 2024-05-15 17:57:44 +02:00
Paul Chavard
bcd3f3b471 refactor(champs): change views to use new urls with stable_id and row_id 2024-05-15 16:51:26 +02:00
Paul Chavard
a1db089681 fix(champ): champ value formatters should check champ type 2024-05-13 17:00:46 +02:00
Paul Chavard
f766a6fb5e fix(dossier): fix projected value on linked_drop_down_list 2024-05-13 15:32:04 +02:00
Colin Darie
ea821e1eac fix: departement_type_de_champ#champ_value_for_tag bad signature 2024-05-13 13:29:30 +02:00
Colin Darie
e01f5b7993
refactor(search): index search terms only when necessary 2024-05-08 10:35:04 +02:00
Kara Diaby
b048a2b042 BUGFIX : La démarche modèle clonée n'est plus modèle 2024-05-07 09:49:29 +00:00
mfo
9518982166
Merge pull request #10346 from mfo/US/permit-to-disable-tiers-bloc
ETQ administrateur, je souhaite pouvoir conditionner l'affichage du bloc " Pour un bénéficiaire : membre de la famille, proche, mandant, professionnel en charge du suivi du dossier…"
2024-05-07 09:23:07 +00:00
Colin Darie
6733b2884f
feat(search): index mandataire name 2024-05-06 18:58:52 +02:00
Colin Darie
39b0327237
refactor(search): rename update search terms => index search terms 2024-05-06 18:57:39 +02:00
Colin Darie
797bd6b94b
fix(search): preload before updating search terms because we access all champs 2024-05-06 18:57:04 +02:00
Colin Darie
4408824882
fix(dossier): update search terms when etablissement or individual changed 2024-05-06 18:57:03 +02:00
Colin Darie
ee465b38ff
feat(search): debounce update search terms 2024-05-06 18:57:00 +02:00
Colin Darie
2e763d5e92
perf(search): ignore search_terms columns, use raw sql instead 2024-05-06 17:16:34 +02:00
mfo
b40cc2a54e feat(individual.validation): add missing strict_email validation 2024-05-06 15:56:22 +02:00
Eric Leroy-Terquem
3d5e0043a6
refacto: remove unused small variant 2024-05-06 15:52:06 +02:00
Colin Darie
0dd4bafdfd refactor(pj): more readable as_multiple logic 2024-05-06 09:49:02 +00:00
Kara Diaby
bec9af90e8 models 2024-05-06 09:49:02 +00:00
Eric Leroy-Terquem
4b53808b5c
fix(gallery): add variants on thumbnails 2024-04-29 21:35:20 +02:00
Paul Chavard
244dcfcc23 refactor(export): improuve specs 2024-04-24 13:27:20 +02:00
Paul Chavard
39364961ab refactor(export): expose new interface on type de champ and use it in champs 2024-04-24 13:27:20 +02:00
Paul Chavard
371b8b0b46 refactor(export): remove old formatting code from champs 2024-04-24 13:27:20 +02:00
Paul Chavard
99834e0cf5 refactor(export): move formatting logic to type de champ 2024-04-24 13:27:20 +02:00
Paul Chavard
95bb09a1f8 refactor(champs): do not depend on attributes hash key in old code 2024-04-22 18:38:59 +02:00
Paul Chavard
741712141a refactor(champs): add new champs controllers urls with stable_id and row_id 2024-04-22 13:55:02 +02:00
Paul Chavard
1021a31f7b refactor(dossier): use update_champs_private and update_champs_public methods 2024-04-22 13:55:02 +02:00
Paul Chavard
25e009df78 refactor(prefill): use champ_for_update method 2024-04-22 13:55:01 +02:00
Paul Chavard
0c7bc6b555 feat(dossier): add methods to upsert champ values 2024-04-22 13:55:01 +02:00
Paul Chavard
c479d46b47 refactor(champs): extract dossier champ related methods in to a concern 2024-04-22 13:55:01 +02:00
Paul Chavard
5788997519
Merge pull request #10347 from tchak/cleanup-dossier-user
fix(dossier): always use user_email_for instead of user.email
2024-04-22 08:22:51 +00:00
simon lehericey
9e33b1ee6d
fix: allow unsigned expert when restricted list 2024-04-19 13:03:09 +02:00
mfo
4041bfa160
Merge pull request #10317 from mfo/US/aria-labelled-by-error-message
ETQ Usager, je souhaite que mon screen reader verbalise les erreurs sur les champs unique contenu dans un `fieldset`
2024-04-18 08:53:12 +00:00
Paul Chavard
6644f8157f fix(dossier): always use user_email_for instead of user.email 2024-04-18 10:21:32 +02:00
mfo
8453e121d7
feat(champ.errors): add aria-labelledby error on champs wrapped within a fieldset, make error messages always present and aria-live: assertive on validation error
Co-authored-by: Corinne Durrmeyer <corinne@inseo.fr>
Co-authored-by: Colin Darie <colin@darie.eu>
2024-04-18 10:00:27 +02:00
Paul Chavard
2c9f809a46
Merge pull request #10250 from mfo/US/add-missing-validators
tech(champs.validators): dry and standardize champs.validations
2024-04-17 15:06:47 +00:00
simon lehericey
ca4ab4cfe1
fix: multi FC do not change const 2024-04-17 15:33:37 +02:00
LeSim
6165df277b
Merge pull request #10342 from demarches-simplifiees/dirty_fix_to_make_fc_work_again
hack: always use default redirect_uri
2024-04-17 09:45:21 +00:00
simon lehericey
2424885adf
hack: always use default redirect_uri 2024-04-17 11:36:35 +02:00
mfo
aca67a2274
tech(refactor.champs.validation): all champs validation use :validate_champ_value_or_prefill? 2024-04-17 06:27:26 +02:00
mfo
c6e21fb7bd
feat(champs.contextual_validation): extract contextual methods validation in module 2024-04-17 06:27:25 +02:00
simon lehericey
981003975c
refactor: use last_sign_in_at as confirmed_at is not reliable 2024-04-16 17:58:30 +02:00
simon lehericey
d95ce505a8
feat: suggest recently added user even if its not confirmed 2024-04-16 17:58:30 +02:00
simon lehericey
8d95df2250
feat: do not suggest unconfirmed experts 2024-04-16 17:58:30 +02:00
simon lehericey
1502635327
refactor: experts emails pluck 2024-04-16 17:58:30 +02:00
simon lehericey
5cd780251b
refactor: mutualize email_expert logic 2024-04-16 17:58:29 +02:00
Colin Darie
71b0592b0a
Merge pull request #10336 from colinux/fix-address-without-postcode
Usager: fix champ adresse dans un TOM sans code postal dans la BAN (ex. Nouvelle-Calédonie à Nouméa)
2024-04-16 13:45:04 +00:00
Colin Darie
db65c9178e
fix(address): BAN does not return postcode for some TOM like Nouvelle-Calédonie
But we have to fallback to an empty string because API graphql / serializer
expects a non-null attribute.
2024-04-16 15:37:56 +02:00
Paul Chavard
ee56a7da21 refactor(champ): remove stable_id delegate to type_de_champ 2024-04-16 12:10:07 +02:00
Lisa Durand
7a80574afc
Merge pull request #10190 from demarches-simplifiees/add-AR-feature-ldu
ETQ Admin je peux configurer une démarche avec accusé de lecture
2024-04-16 09:58:13 +00:00
simon lehericey
6982b2d5e8
refactor: do not enqueue antivirus job for safe blob 2024-04-16 09:57:31 +02:00
Lisa Durand
c6e2e6445c add instructeur feedback on accuse de lecture agreement 2024-04-15 12:10:28 +02:00
Lisa Durand
71268c7f3b hide decision from email for tiers if procedure has accuse de lecture 2024-04-15 11:15:13 +02:00
Lisa Durand
1cf3db5899 hide dossier with accuse de lecture in user list when using state filter 2024-04-15 11:15:13 +02:00
Lisa Durand
e486f789f6 add AR in user view - hide decision on second dossier tab 2024-04-15 11:15:13 +02:00
Lisa Durand
ae08044ff2 create AR email and send it at the right time 2024-04-15 11:15:05 +02:00
mfo
cb2dd3dd3a
Merge pull request #10314 from mfo/US/enhance-a11y-on-carte-champs
ETQ Usager je souhaite que le champ carte soit plus accessible
2024-04-14 13:25:06 +00:00
mfo
938f5043a4
feat(champs.validation): standardize champ error messages 2024-04-12 11:39:43 +02:00
mfo
d8a8fb53ce
feat(Champ.carte): some error style on carte 2024-04-12 10:59:42 +02:00
Eric Leroy-Terquem
1e50223267
Merge pull request #10293 from demarches-simplifiees/re-router-tous-les-dossiers-d-une-demarche
ETQ tech je peux relancer le routage pour tous les dossiers en construction d'une démarche
2024-04-11 13:27:43 +00:00
simon lehericey
bda9c4b455
fix: drop unused column and fk procedure_revisions.attestation_template_id which block procedure.destroy 2024-04-11 13:38:38 +02:00
simon lehericey
ab4a6b1c7d
fix: rescue and sentry log procedure.purge_discarded to avoid blowing up the whole job 2024-04-11 13:22:37 +02:00
Paul Chavard
fe508c0a73
Merge pull request #10302 from tchak/ignore-attestation_template_id
chore(db): ignore attestation_template_id
2024-04-11 10:30:37 +00:00
Paul Chavard
ceae749746 chore(db): ignore attestation_template_id 2024-04-11 12:03:06 +02:00
simon lehericey
124433b781
refactor: commune_champ 2024-04-11 11:57:18 +02:00
Eric Leroy-Terquem
51312b178e
task(routing): reroute dossiers en construction 2024-04-09 17:17:49 +02:00
Colin Darie
3c7018fd31 fix: don't set preferred domain on signup/signin unless feature is enabled 2024-04-09 10:04:18 +02:00
Paul Chavard
707d3980c0
Merge pull request #10171 from tchak/fix-perf-filters
perf(filter): we query by stable_id - no need to check type_de_champ private attribute
2024-04-08 09:24:54 +00:00
LeSim
22830fd7f6
Merge pull request #10275 from demarches-simplifiees/fix_api_entreprise_status
Tech: corrige le mécanisme de surveillance des fournisseurs d entreprise.api.gouv.fr
2024-04-08 08:08:38 +00:00
Paul Chavard
c5c671f391
Merge pull request #10234 from tchak/type-de-champ-paths
feat(champ): add paths to type_de_champ
2024-04-08 08:07:30 +00:00
simon lehericey
e82a8787d5
dirty fix: avoid changing preferred domain 2024-04-05 15:26:12 +02:00
Paul Chavard
80b3f0c0b3 fix(champ): no validate on hidden champs 2024-04-05 13:24:57 +02:00
simon lehericey
7b33963a67
add and use api_djepva_up? 2024-04-05 12:27:26 +02:00
simon lehericey
e994738a2e
add and use api_insee_up? 2024-04-05 12:26:44 +02:00
Paul Chavard
742e6f4a92 perf(filter): we query by stable_id - no need to check type_de_champ private attribute 2024-04-04 19:01:47 +02:00
Paul Chavard
282ce1322c fix(stats): more accurat stats about deleted dossiers 2024-04-04 19:00:48 +02:00
Paul Chavard
38a703034e feat(champ): expose paths 2024-04-04 16:13:23 +02:00
Colin Darie
df59503ab7
Merge pull request #10224 from colinux/mail-host
Tech (mailers): `from`, liens et application en respectent le preferred domain du destinataire
2024-04-04 07:25:43 +00:00
Colin Darie
d14fe83261
feat(mail): devise confirmation instructions respect user preferred host 2024-04-02 18:47:41 +02:00
Paul Chavard
0006a12aea
Update app/models/dossier.rb
Co-authored-by: LeSim <mail@simon.lehericey.net>
2024-04-02 18:09:29 +02:00
Paul Chavard
7cf1cdb47b fix(champ): do not expose champs without row_id in repetitions 2024-04-02 17:51:57 +02:00
mfo
4da36531d4
Merge pull request #10242 from demarches-simplifiees/US/fix-decimal-number-validator
Correctif(annotations privées): ETQ instructeur, je ne pouvais modifier une annotation quand un usager avait saisi des valeur de champs incorrectes
2024-04-02 07:13:07 +00:00
Paul Chavard
13005b0a4a fix(dossier): enqueue jobs after commit 2024-04-01 19:00:25 +02:00
Paul Chavard
5d302fb6ac refactor(dossier): extract aasm callbacks in to a concern 2024-04-01 18:55:08 +02:00
mfo
e08aa7d28b
wip(validates): prefill and validate_champ_value? on all other missing validation checks 2024-04-01 07:36:14 +02:00
mfo
284a10e235
fix(Champs::EngagementJuridiqueChamp): validates Champs::EngagementJuridiqueChamp respecting it's validation context. 2024-04-01 07:18:14 +02:00
mfo
ff527517c9
fix(Champs::CiviliteChamp): validates Champs::CiviliteChamp respecting it's validation context. 2024-04-01 07:18:14 +02:00
mfo
94ea16c894
fix(Champs::BooleanChamp): validates Champs::BooleanChamp respecting it's validation context. 2024-04-01 07:18:14 +02:00
mfo
d7f152f4af
fix(Champs::PhoneChamp): validates Champs::PhoneChamp respecting it's validation context. 2024-04-01 07:18:14 +02:00
mfo
374d763084
fix(Champs::IntegerNumberChamp): validates Champs::IntegerNumberChamp respecting it's validation context. 2024-04-01 07:18:13 +02:00
mfo
fd5faad31f
fix(Champs::PaysChamp): validates Champs::PaysChamp respecting it's validation context. Also do not save value when external_id/code can't be found by lookup 2024-04-01 07:18:13 +02:00
mfo
04f3b6a844
fix(Champs::DecimalNumberChamp): validates Champs::DecimalNumberChamp respecting it's validation context 2024-04-01 07:07:11 +02:00
Lisa Durand
65b8f6881a
Merge pull request #10143 from demarches-simplifiees/float-too-many-decimal-ldu
ETQ admin, je veux que le champ nombre décimal ne prenne que 3 chiffres après la virgule
2024-03-27 10:05:35 +00:00
Lisa Durand
a3ab6dd257 add validation on decimal max 3 digits after coma 2024-03-27 10:55:10 +01:00
Paul Chavard
6ad0b901b6 fix(champ): use public_id in views 2024-03-26 11:23:23 +01:00
Eric Leroy-Terquem
536a03bbb4
Merge pull request #10180 from demarches-simplifiees/update-bulk-messages-associations
Technique : Mise à jour de l'association bulk messages - procédures
2024-03-25 13:35:23 +00:00
Eric Leroy-Terquem
a726d34404 fix(cloned procedures): reset closing attributes 2024-03-22 17:07:22 +01:00
Eric Leroy-Terquem
30f96a79c2 chore(bulk messages): update associations 2024-03-22 14:52:34 +01:00
Martin
44cdb14fb9 feat(type_de_champ_editor): move champs after another champ. 2024-03-22 10:10:28 +01:00
Martin
015e606f50 fix(dossier.has_many.france_connect_informations): wip 2024-03-22 07:47:02 +01:00
mfo
d00b146dc3
Merge pull request #10165 from mfo/US/add_champ_descriptor_id
feat(api): add champs.champDescriptorId so champRepetitions.rows[x] has a uniq id
2024-03-21 17:05:56 +00:00
Colin Darie
17f9992722
Merge pull request #10040 from colinux/cross-domain-component
Prépare la bannière informant du changement de nom de domaine, avec redirection automatique le cas échéant
2024-03-21 14:58:29 +00:00
Eric Leroy-Terquem
9139bfbf48 clean(administrateur): remove dead code 2024-03-21 14:27:53 +01:00
Eric Leroy-Terquem
6a77bbb6c9 fix(administrateur): can be deleted only if other admin or dossiers on all procedures included with discarded 2024-03-21 14:27:52 +01:00
Colin Darie
2f4444bd5e
chore: mark preferred domain to new domain when closing notice 2024-03-21 13:15:34 +01:00
Colin Darie
a16f88f8af
chore(schema): add preferred_domain to users 2024-03-21 12:21:19 +01:00
simon lehericey
a42f85ef05 remove useless administration_id in invite_admin and invite_administrateur! 2024-03-21 11:54:02 +01:00
Martin
22fa2e61b4 feat(api): add champs.champDescriptorId so champRepetitions.rows[x] has a uniq id 2024-03-21 10:29:33 +01:00
simon lehericey
4c3b0229eb set Current.application_base_url 2024-03-21 10:06:09 +01:00
simon lehericey
72a2b764dc add demarches.gouv.fr as sender of automatic emails 2024-03-21 10:06:09 +01:00
simon lehericey
d13910dac4 set Current.contact_email 2024-03-21 10:06:09 +01:00
simon lehericey
efa35e04a5 use Current.application_name in app excluding mail 2024-03-21 10:06:09 +01:00
simon lehericey
b9fcb25f1a set Current.application_name 2024-03-21 10:06:08 +01:00
mfo
086cc1537b
Merge pull request #10068 from mfo/US/user-has-many-fcis
tech(User.FranceConnect): un usager peut avoir plusieurs profils FranceConnect, pas uniquement un
2024-03-20 16:30:39 +00:00
Eric Leroy-Terquem
73d6609eb3
Merge pull request #10158 from demarches-simplifiees/fix-closing-reason-form
Correctif : ETQ admin je ne peux pas fermer une démarche en redirigeant sans choisir la nouvelle démarche
2024-03-20 13:28:40 +00:00
Lisa Durand
6c5c744411
Merge pull request #10119 from demarches-simplifiees/add-explanation-when-publish-with-same-url-ldu
ETQ admin j'ai un message d'explication si j'utilise une URL déja utilisée lors de la publication d'une démarche
2024-03-20 13:21:59 +00:00
Eric Leroy-Terquem
280f1ac3c7 refactor(procedure): add a prefix to closing_reason enum 2024-03-20 14:04:59 +01:00
Eric Leroy-Terquem
e55531c6f4 fix(procedure): validates presence of replaced_by_id if procedure redirected 2024-03-20 14:04:59 +01:00
Paul Chavard
eff03aaf23 refactor(dossier): label indexes based on type_de_champ not champ 2024-03-20 09:58:47 +01:00
Paul Chavard
33125c691e
Merge pull request #10145 from tchak/fix-clone-with-stable-id
fix(champ): fill stable_id and stream when cloning from old champs
2024-03-20 08:29:12 +00:00
simon lehericey
df0298ac42 simply deal with multiple agent_connect_information by taking the last used 2024-03-19 21:17:45 +01:00
simon lehericey
ca17524559 Allow instructeur to have multiple agent_connect_information
AC will return two different sub depending of the domain demarches.gouv.fr or ds.
Both agent_connect_information are stored and the corresponding instructeur is found by its email.
We do not store anymore the agent_connect_id on the instructeur as the are many.
2024-03-19 21:17:45 +01:00
simon lehericey
4997a81639 remove one indirection 2024-03-19 21:17:44 +01:00
Paul Chavard
a962e2d94e fix(champ): fill stable_id and stream when cloning from old champs 2024-03-18 20:04:53 +01:00
Paul Chavard
c5892a1ca2
Merge pull request #10141 from tchak/fix-rows-order
fix(champs): fix rows order
2024-03-18 16:56:21 +00:00
Paul Chavard
f21192bb06
Merge pull request #10123 from tchak/fix-multiple-champ-copies-bug
fix(champ): fix multiple champ copies bug
2024-03-18 16:46:17 +00:00