simon lehericey
4d7715fbb6
extract filter and sort function to a filter_service
2024-10-15 16:09:08 +02:00
simon lehericey
16e93a217b
reset procedure_presentation if a pb occurs with a column deserialization
2024-10-15 16:09:07 +02:00
simon lehericey
3677f3b2d3
tech(clean): remove Column classname: attribute
...
Co-authored-by: mfo <mfo@users.noreply.github.com>
2024-10-15 16:09:07 +02:00
simon lehericey
b2754cd26c
move validations concern to filtered_column
...
Co-authored-by: mfo <mfo@users.noreply.github.com>
2024-10-15 16:09:06 +02:00
simon lehericey
14fe11b612
use displayed_columns !
2024-10-15 16:09:06 +02:00
simon lehericey
7e4ca07df2
use filtered_column to filter !
...
Co-authored-by: mfo <mfo@users.noreply.github.com>
2024-10-15 16:09:05 +02:00
simon lehericey
4c5d7e2950
remove now useless add_filters and remove_filters
2024-10-15 16:09:05 +02:00
simon lehericey
72c389161a
remove filter using generic add_filter methods
2024-10-15 16:09:05 +02:00
simon lehericey
175f303399
display filter tags
2024-10-15 16:09:05 +02:00
simon lehericey
e9c11a95f1
directly write in new filter columns
2024-10-15 16:09:05 +02:00
simon lehericey
d54ab64e40
add filtered_column type
2024-10-15 16:09:05 +02:00
Mathieu Magnin
4b5235e42f
[ #10919 ] Fix tests
2024-10-15 15:32:46 +02:00
Mathieu Magnin
097074fdc7
Merge pull request #10865 from demarches-simplifiees/fix-10799
...
ETQ Admin / Instructeur je veux être savoir si le jeton api entreprise d'une démarche a expiré ou va expirer prochainement
2024-10-15 13:25:20 +00:00
Benoit Queyron
c8f69283cc
Merge pull request #10713 from demarches-simplifiees/etq-admin-bug-message-info-character-limit
...
Tech : amélioration de la gestion des types_de_champ.options
2024-10-15 13:02:33 +00:00
Mathieu Magnin
dfa3276cb6
[ #10799 ] Missing test
2024-10-15 14:40:50 +02:00
Mathieu Magnin
4266a76db6
[ #10799 ] Move test in right file
2024-10-15 14:40:50 +02:00
Mathieu Magnin
c897893e8a
[ #10799 ] Remove dead code
2024-10-15 14:40:50 +02:00
Mathieu Magnin
f26ff30538
[ #10799 ] Add maintenance task to fill api_entreprise_token_expires_at for previous data
2024-10-15 14:40:50 +02:00
Mathieu Magnin
6b326b634e
[ #10799 ] Modifications after Marlene's comments
2024-10-15 14:40:50 +02:00
Mathieu Magnin
687617cb08
[ #10799 ] Add test
2024-10-15 14:40:50 +02:00
Mathieu Magnin
ec2c913ab4
[ #10799 ] Display token error on related card
2024-10-15 14:40:49 +02:00
Mathieu Magnin
703a722c54
[ #10799 ] Handle the case when api_entreprise_token is not nil then set to nil
2024-10-15 14:40:49 +02:00
Mathieu Magnin
7009eed9d7
[ #10799 ] Move api entreprise token logic in a concern
2024-10-15 14:40:49 +02:00
Mathieu Magnin
39fdb8ddbb
[ #10799 ] Display a warning about token expiration on token form page
2024-10-15 14:40:49 +02:00
Mathieu Magnin
2d9854dc01
[ #10799 ] Declare api_entreprise_token_expires_at attribute and feed it on save
2024-10-15 14:40:49 +02:00
benoitqueyron
e88d84cf57
ajout d'un nettoyage des options des types_de_champ lors de la publication d'une procedure ou d'une nouvelle revision
2024-10-15 14:40:33 +02:00
benoitqueyron
4f62590b7a
ProcedureRevision#compare_type_de_champ: fix bug comparaison character_limit chaine vide vs nil
2024-10-15 14:40:33 +02:00
simon lehericey
b588b77571
TypeDeChamp: amélioration de la gestion des drop_down_options
2024-10-15 14:40:15 +02:00
Mathieu Magnin
49c9f274e4
[ #10919 ] When data in geo_area is invalid do not crash when .label is called
2024-10-15 14:37:32 +02:00
Corinne Durrmeyer
89d31ddf11
Improve rendering of “n°” by assistive technologies
2024-10-15 12:18:23 +02:00
Paul Chavard
bd32f5693d
refactor(repetition): remove parent_id
2024-10-15 11:42:36 +02:00
mfo
e7080c1ad1
Merge pull request #10927 from mfo/US/renormalize_department_code_and_name
...
amelioration ETQ tech, je souhaite que les composants d'adresses soient normalisés en anglais
2024-10-15 07:49:16 +00:00
mfo
366c02dbb7
fix(typo): use english for normalized addresses component
2024-10-15 09:13:05 +02:00
Colin Darie
ed6a254135
Merge pull request #10930 from colinux/fix-dropdown-list-filter-length
...
ETQ instructeur je peux filtrer un champ "choix simple" avec un long libellé d'option
2024-10-14 19:18:35 +00:00
Colin Darie
1c32a30b80
fix(filters): drop down list filters can have much longer values.
...
Notre infra supporte des urls d'au moins 8000 caractères, probablement
plus encore, donc on est large.
2024-10-14 16:01:48 +02:00
Eric Leroy-Terquem
60be8d68fc
test(instructeurs management): update tests
2024-10-14 15:14:06 +02:00
Eric Leroy-Terquem
59fe8b64c4
wording(instructeurs management): update translations
2024-10-14 15:13:35 +02:00
Colin Darie
9e27295a36
fix(admin): all procedures really filtered by tags
2024-10-14 10:26:47 +02:00
Kara Diaby
2c85757289
Créé la liste de nouveaux tags en base et les associe aux démarches
2024-10-14 10:26:47 +02:00
Kara Diaby
953ccbcfb6
Mise à jour des tests
2024-10-14 10:26:47 +02:00
Paul Chavard
32d8cbfe48
Merge pull request #10923 from tchak/graphql-siret-address-optimize
...
fix(graphql): parse_etablissement_address is slow (up to 300ms) – bypasse it when possible
2024-10-14 08:14:51 +00:00
Paul Chavard
960385831e
Merge pull request #10904 from tchak/remove-some-complex-champs-from-prefill
...
chore(prefill): remove unused prefill support on complex champs
2024-10-14 08:11:30 +00:00
Paul Chavard
b027839721
fix(graphql): parse_etablissement_address is slow (300ms) – bypasse it when possible
2024-10-14 09:23:35 +02:00
Mathieu Magnin
2222b6ff2d
[ #10921 ] Extend error handling to cover new error codes
2024-10-11 16:16:17 +02:00
Eric Leroy-Terquem
3397beb71d
refactor(gallery test): use freeze_time instead of Timecop
2024-10-11 13:14:19 +02:00
Eric Leroy-Terquem
72ae654ce7
style(pieces jointes): update UI
2024-10-11 11:20:47 +02:00
Eric Leroy-Terquem
3bc232e81e
feat(gallery): update gallery item badge class after seen
2024-10-11 11:20:46 +02:00
Eric Leroy-Terquem
d9f604e8ce
feat(gallery): notify instructeur if pieces jointes updates
2024-10-11 11:20:46 +02:00
Eric Leroy-Terquem
bc237152e7
feat(gallery): add origin tag to gallery item
2024-10-11 10:41:05 +02:00
Eric Leroy-Terquem
df08617387
feat(gallery): add badge for date of created_at or updated_at
2024-10-11 10:41:04 +02:00
Eric Leroy-Terquem
3560d73b58
refactor(gallery): use gallery component in gallery demande
2024-10-11 10:41:04 +02:00
Eric Leroy-Terquem
2882af43aa
refactor(gallery): extract representation_url_for method
2024-10-11 10:41:04 +02:00
Eric Leroy-Terquem
bae752f1aa
refactor(gallery): add attachment_gallery_item component
2024-10-11 10:41:03 +02:00
Colin Darie
7f18db6c91
fix(job): non crirtical mail must be sent into < 15min, not hours
2024-10-10 17:14:28 +02:00
mfo
fc37bbaa4a
Merge pull request #10906 from mfo/US/reword-queueing
...
amelioration : ETQ operateur j'aimerais simplifier/optimiser la gestion des tâches asynchrones
2024-10-10 07:47:59 +00:00
mfo
b8b727f06b
feat(default.queues): mailers that are not critical are low, otherwise critical. analysis is default, purge is low
2024-10-10 09:31:20 +02:00
Colin Darie
9ef445a4a1
Merge pull request #10905 from tchak/fix-api-entreprise-sentry-error
...
ETQ Usager, je veux pouvoir déposer mon dossier même si le service des SIRET n'est pas disponible
2024-10-09 14:13:47 +00:00
LeSim
163fa42007
Merge pull request #10869 from demarches-simplifiees/add_id_to_column_second_part
...
Tech: utilise les objets `SortedColumn`
2024-10-09 13:05:50 +00:00
Colin Darie
cae5d8afed
feat(task): task enqueueing a maintenance task runnable on deploy
2024-10-09 13:44:17 +02:00
Colin Darie
d0f77d0aab
feat(task): with_statement_timeout helper for long running collection or process query
2024-10-09 13:44:17 +02:00
Paul Chavard
668aba8986
fix(api-entreprise): do not raise an error when the service is unavailable
2024-10-09 12:47:26 +02:00
Paul Chavard
e56bc9d35b
chore(prefill): remove unused prefill support on complex champs
2024-10-09 12:11:42 +02:00
simon lehericey
34b0379203
procedure.find_column raise NotFound to fit AR interface
2024-10-09 09:23:06 +02:00
simon lehericey
4f0cac251d
use sorted_column to sort dossier
2024-10-08 22:51:26 +02:00
simon lehericey
ba91f2f66e
remove now useless validation
2024-10-08 22:51:25 +02:00
simon lehericey
da98aa556b
use update(sorted_column:) and remove obsolete update_sort(column_id:, order:)
2024-10-08 22:51:25 +02:00
simon lehericey
21533f91e3
add storted_column_type
2024-10-08 22:47:37 +02:00
simon lehericey
305b31e53b
add sorted_column
2024-10-08 22:47:37 +02:00
simon lehericey
693629afc8
add column type
2024-10-08 22:47:36 +02:00
simon lehericey
a418cf6632
remove_filter double_write
2024-10-07 22:09:21 +02:00
simon lehericey
870d67e844
add_filter double write
2024-10-07 22:09:21 +02:00
simon lehericey
5f6d8e93ca
update_display double write
2024-10-07 22:09:20 +02:00
simon lehericey
98c2b7e954
update_sort double write
2024-10-07 22:09:20 +02:00
simon lehericey
a7ebe23504
migrate procedure_presentation to column
2024-10-07 22:09:20 +02:00
simon lehericey
a8b41e90cc
remove make_id
2024-10-07 21:47:03 +02:00
simon lehericey
3740a79219
add procedure_id to column.id
2024-10-07 21:46:59 +02:00
Paul Chavard
274e43c5e6
fix(dossier): projected champs should have updated_at
2024-10-05 22:22:04 +02:00
Paul Chavard
5cbdfd8677
Merge pull request #10882 from tchak/playwright-bun
...
chore(playwright): run playwright using bunx instead of default npx
2024-10-05 08:58:19 +00:00
Paul Chavard
70699a681d
Merge pull request #10889 from tchak/fix-dossier-follow-should-bump-updated-at
...
ETQ intégrateur d’API, je veux que le dossier soit remonté comme modifié quand ses instructeurs changent
2024-10-05 08:58:05 +00:00
Paul Chavard
7a39267473
refactor(spec): champs_* -> project_champs_*
2024-10-04 12:29:50 +02:00
Paul Chavard
8fdf5cbe80
refactor(dossier): explicitly build default values - less callbacks, less magic
2024-10-04 12:05:54 +02:00
Paul Chavard
25977fd97d
ETQ intégrateur d’API, je veux que le dossier soit remonté comme modifié quand ses instructeurs changent
2024-10-03 18:10:04 +02:00
mfo
5879d54145
Merge pull request #10866 from mfo/US/fix-filter-ilike
...
amelioration : ETQ instructeur, je souhaite pouvoir filtrer les dossiers sur mon tableau de bord fonction des choix simple/multiple/etc.. sans conflit parmis les autres valeurs de ces même choix simple/multiple/etc...
2024-10-03 13:08:49 +00:00
Colin Darie
3923e316e1
Merge pull request #10883 from colinux/helpscout-instructeur-notif
...
ETQ support je vois dans HS lorsqu'un instructeur a désactivé ses notifications
2024-10-03 09:12:15 +00:00
Colin Darie
a933e45e7b
feat(helpscout): warn when instructeur disabled notifs
2024-10-03 10:03:34 +02:00
Corinne Durrmeyer
480c8f493e
Remove nav when empty
2024-10-01 10:16:03 +02:00
Paul Chavard
9aee925ab1
chore(playwright): run playwright using bunx instead of default npx
...
without this change, specs fail on systems without node installed
2024-09-30 21:13:32 +02:00
simon lehericey
c638ac0261
rename drop_down_list_value -> drop_down_option_from_text
2024-09-30 15:37:02 +02:00
simon lehericey
532f0f48fa
replace drop_down_list_enabled_non_empty_options by drop_down_options when possible
2024-09-30 15:37:02 +02:00
simon lehericey
8b5f689a67
use drop_down_options when possible
2024-09-30 15:37:01 +02:00
simon lehericey
5a19cc1a09
remove drop_down_list_value reader
2024-09-30 15:37:01 +02:00
Paul Chavard
084a68a121
refactor(repetition): consolidate repetition manipulation methods
2024-09-27 11:34:06 +02:00
Mathieu Magnin
5e0ebb69f8
Merge pull request #10779 from demarches-simplifiees/fix-10753
...
ETQ Mainteneur je veux marqué les emails des instructeurs qui se sont connectés il y a < 5 mois comme vérifiés
2024-09-26 13:07:04 +00:00
mfo
1339e10280
bug(filter): filtering types_de_champs.value with ilike is trickier than expected. indead, some enum might overlap on word ex: Favorable, Defavorable. Searching with ilike Favorable finds Defavorable
2024-09-24 20:48:10 +02:00
mfo
0cbb296e7d
Merge pull request #10864 from mfo/US/fix-export-template-with-lots-of-types-de-champs
...
correctif: ETQ instructeur, j'aimerais pouvoir modifier mes modèles d'export, meme sur des démarches avec beaucoup de champs
2024-09-24 16:37:37 +00:00
mfo
b117bc9774
fix(export_template#preview): avoid 414 responses, using get method is not a good option for procedure with a lot of types_de_champ, otherwise we reach http get size limit
2024-09-24 18:07:18 +02:00
Lisa Durand
e1d9ea2a66
Merge pull request #10859 from demarches-simplifiees/improve-dossier-transfer-ldu
...
Améliorer le mail si un usager sans compte DS reçoit un transfert de dossier
2024-09-24 13:49:45 +00:00
Colin Darie
f700024df0
Merge pull request #10862 from colinux/fix-sva-with-complex-pending-corrections
...
ETQ usager: corrige la date prévisionnelle SVA lorsqu'il y a un mélange de demandes de corrections résolues et en attente
2024-09-24 12:35:26 +00:00
Colin Darie
99534ef834
Merge pull request #10812 from colinux/date-last-updated-at-tag
...
ETQ admin, créé les balises "date de mise à jour" du dossier et "date prévisionnelle SVA/SVR"
2024-09-24 12:21:07 +00:00
Colin Darie
b50d42fbb4
fix(sva): when there were resolved corrections and a pending correction
2024-09-24 12:48:09 +02:00
Lisa Durand
463e3e1538
improve email wording for transfert with DS account
2024-09-24 11:31:00 +02:00
Colin Darie
2b07826202
fix(sva): add sva/svr decision date tag for relevant template emails
...
Closes #10033
2024-09-24 11:28:18 +02:00
Colin Darie
861f7359b1
feat(attestation): support last champ updated at as tag
...
closes #9825
2024-09-24 11:28:17 +02:00
Colin Darie
655e4be0e7
Merge pull request #10858 from colinux/attestation-v2-better-v1-ording
...
ETQ admin, explique mieux que l'attestation v1 reste fonctionnelle alors que j'ai accès à la v2
2024-09-24 08:35:09 +00:00
Mathieu Magnin
af0692163b
Merge pull request #10839 from demarches-simplifiees/fix-10837
...
ETQ Administrateur, si j'oublie de renseigner le SIRET de mon service, je souhaite recevoir un message d'erreur explicite pour m'alerter.
2024-09-24 08:31:47 +00:00
Colin Darie
e7f5217211
chore(attestation): improve wording about v1/v2 switch
2024-09-24 10:18:00 +02:00
Eric Leroy-Terquem
7625ec5c8f
fix(manager): can add to super admin both roles of administrator and instructor if he is already one of them
2024-09-24 09:05:38 +02:00
Eric Leroy-Terquem
f16addd080
test(manager): nominal case of #add_administrateur_and_instructor
2024-09-24 09:05:37 +02:00
Paul Chavard
fb07a0ca54
fix(combobox): can copy past multiple values in restricted multi select combobox
2024-09-23 21:49:24 +02:00
Paul Chavard
b5eb87de6a
fix(champ): improve row_id validation and remove it during export
2024-09-23 17:06:33 +02:00
mfo
7adbdaa4de
tech(clean): unused index and column
2024-09-23 14:53:37 +02:00
Paul Chavard
b1c0b4de20
Merge pull request #10840 from tchak/fix-pagination-links
...
fix some playwright specs
2024-09-23 12:27:54 +00:00
Paul Chavard
4ab9ef1f3f
Merge pull request #10842 from tchak/revert-du-revert-de-refactoring-champs
...
Revert "Revert "Merge pull request #10771 ""
2024-09-23 12:27:04 +00:00
mfo
d16a40b6aa
Merge pull request #10836 from mfo/US/fix-mistake-changing-dossier-repasser-en-construciton
...
ETQ administrateur, je ne souhaite pas voir des dossiers en instruction repasser en construction pour une donnée qui ne m'est pas necessaire
2024-09-23 11:54:56 +00:00
Colin Darie
6800205ffe
Merge pull request #10682 from demarches-simplifiees/a11y-fix-process-screen-1
...
Corrige les défaut d'accessibilité de la page d'accueil d'une démarche
2024-09-23 11:21:11 +00:00
Paul Chavard
3429a72f53
fix(dossier): do not show repetitions in header sections summary
2024-09-23 10:51:38 +02:00
Paul Chavard
6254b50de9
Revert "Revert "Merge pull request #10771 from tchak/refactor-champs-revert""
...
This reverts commit 10a1ae5534
2024-09-23 10:21:07 +02:00
Mathieu Magnin
e9b5c4a615
[ #10837 ] Add an explicit message when SIRET is not valid on service
2024-09-20 15:44:46 +02:00
Paul Chavard
356dae446c
fix(spec): make pagination links clickable
2024-09-20 15:24:41 +02:00
Paul Chavard
0aba2456cd
fix(spec): scroll to combobox before filling
2024-09-20 15:24:13 +02:00
mfo
3b3c845b2e
fix(fix_champs_commune_having_value_but_not_external_id): only asks for update for dossier en construction
2024-09-20 14:30:42 +02:00
mfo
ada5ceeeec
fix(data): revert pending_correction for champs commune not having external_id, was a mistake. mine
2024-09-20 11:54:11 +02:00
mfo
cd8c55b161
Merge pull request #10814 from demarches-simplifiees/fix-10813
...
[bug] Ne pas afficher de 500 quand value_json d'un champ SIRET est nil
2024-09-19 15:22:45 +00:00
Corinne Durrmeyer
6cd91015cf
Update spec file
2024-09-19 14:15:51 +02:00
simon lehericey
10a1ae5534
Revert "Merge pull request #10771 from tchak/refactor-champs-revert"
...
This reverts commit c902061ebfb4ed11c788
2024-09-19 11:09:01 +02:00
Lisa Durand
5b31aca888
improve transfer mail for user without account
2024-09-18 17:19:26 +02:00
LeSim
6b322d61ca
Merge pull request #10776 from demarches-simplifiees/ac_2fa
...
ETQ Instructeur, je dois utiliser le 2fa pour le fournisseur d'identité Agent Connect / Mon Compte Pro
2024-09-18 12:48:39 +00:00
LeSim
d32124d732
Merge pull request #10807 from demarches-simplifiees/slow_drop_down_cleaning
...
Tech: simplification de la logique des champs listes
2024-09-18 12:46:15 +00:00
Lisa Durand
3d50f9363f
Merge pull request #10741 from demarches-simplifiees/secu-improve-complexity-password-ldu
...
[sécu] Améliorer la complexité des mots de passe pour tous les users
2024-09-18 12:40:17 +00:00
simon lehericey
05238912cf
record amr for stat
2024-09-18 14:40:12 +02:00
simon lehericey
363f70a3fc
add feature flipping, just in case
2024-09-18 14:40:11 +02:00
simon lehericey
cd2d772cd0
feature(agent_connect_2fa): add intermediate pages to improve UX
2024-09-18 14:40:11 +02:00
simon lehericey
6f5135a6b2
refactor: extract agent_connect logout_url to a agent_connect_service
2024-09-18 14:40:11 +02:00
simon lehericey
1706feec3d
feature(agent_connect_2fa): do not log AC/MonComptePro agent without 2fa
2024-09-18 14:40:10 +02:00
simon lehericey
c0fe06ceb7
refactor: simplify ZxcvbnService
2024-09-18 12:57:58 +02:00
Lisa Durand
3469eeea17
fix tests
2024-09-18 11:09:14 +02:00
LeSim
c89e60d5fa
Merge pull request #10793 from demarches-simplifiees/remove_virtual_attribute_in_code
...
Tech: retire la protection contre les colonnes virtuelles
2024-09-18 08:38:20 +00:00
simon lehericey
d3667bbd6c
remove empty value in drop_down_list in db
2024-09-18 10:26:01 +02:00
simon lehericey
061c9cc6f3
remove default empty value in drop_down_list
2024-09-18 10:26:00 +02:00
simon lehericey
b3ad237fa1
simplify drop_down_list_value
2024-09-18 10:08:12 +02:00
simon lehericey
2f64fe5e4c
one less indirection
2024-09-18 10:08:12 +02:00
simon lehericey
f046f31dcc
remove_disabled_options
2024-09-18 10:08:11 +02:00
Mathieu Magnin
bfb7b59033
[ #10813 ] When value_json of champ SIRET is nil do not crash
2024-09-17 19:05:36 +02:00
Mathieu Magnin
3a7faeaa5e
Merge pull request #10810 from demarches-simplifiees/add-test-for-jwt-field
...
Add a spec file for the JWT Administrate Field
2024-09-17 15:01:53 +00:00
Mathieu Magnin
587b79ce54
Add a spec file for the JWT Administrate Field
2024-09-17 16:45:45 +02:00
mfo
1e0391c9dc
Merge pull request #10806 from mfo/US/fix-number-not-number-in-filters
...
Correctif: ETQ instructeur, la recherche par numéro de dossier ne doit accepter que des numero
2024-09-17 14:39:08 +00:00
Eric Leroy-Terquem
969706163b
Merge pull request #10641 from demarches-simplifiees/move-image-treatment-to-jobs
...
Technique : déplace les traitements d‘images côté jobs
2024-09-17 13:43:51 +00:00
mfo
ebb51e8128
fix(filters): filter by dossier should only accept number
2024-09-17 15:18:23 +02:00
Paul Chavard
54132df77d
dossier(champ): validate presence of row_ids
2024-09-17 10:29:34 +02:00
Paul Chavard
f02ec3da82
cleanup in spec
2024-09-17 10:29:34 +02:00
