DGNum/demarches-normaliennes
14
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

[#10921] Extend error handling to cover new error codes

Browse source
This commit is contained in:
Mathieu Magnin 2024-10-11 16:13:28 +02:00
parent ba330bfa98
commit 2222b6ff2d
No known key found for this signature in database
GPG key ID: 8DCAFC82D7BA654E
4 changed files with 27 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/lib/api_entreprise/api.rb
View file

@ -141,7 +141,7 @@ class APIEntreprise::API
def service_unavailable?(response)
return true if response.code == 503
if response.code == 502 || response.code == 504
parse_response_errors(response).any? { _1.is_a?(Hash) && ["01000", "01001", "01002"].include?(_1[:code]) }
parse_response_errors(response).any? { _1.is_a?(Hash) && ["01000", "01001", "01002", "02002", "03002"].include?(_1[:code]) }
end
end

3
spec/fixtures/files/api_entreprise/error_code_02002.json vendored Normal file
View file

@ -0,0 +1,3 @@
{
"errors": [{ "code": "02002" }]
}

3
spec/fixtures/files/api_entreprise/error_code_03002.json vendored Normal file
View file

@ -0,0 +1,3 @@
{
"errors": [{ "code": "03002" }]
}

20
spec/lib/api_entreprise/api_spec.rb
View file

@ -54,6 +54,26 @@ describe APIEntreprise::API do
end
end
context 'when the service reponds with 02002 code' do
let(:siren) { '111111111' }
let(:status) { 504 }
let(:body) { Rails.root.join('spec/fixtures/files/api_entreprise/error_code_02002.json').read }
it 'raises APIEntreprise::API::Error::RequestFailed' do
expect { subject }.to raise_error(APIEntreprise::API::Error::ServiceUnavailable)
end
end
context 'when the service reponds with 03002 code' do
let(:siren) { '111111111' }
let(:status) { 504 }
let(:body) { Rails.root.join('spec/fixtures/files/api_entreprise/error_code_03002.json').read }
it 'raises APIEntreprise::API::Error::RequestFailed' do
expect { subject }.to raise_error(APIEntreprise::API::Error::ServiceUnavailable)
end
end
context 'when siren does not exist' do
let(:siren) { '111111111' }
let(:status) { 404 }