DGNum/demarches-normaliennes
14
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

Merge pull request #10793 from demarches-simplifiees/remove_virtual_attribute_in_code

Browse source 
Tech: retire la protection contre les colonnes virtuelles
This commit is contained in:
LeSim 2024-09-18 08:38:20 +00:00 committed by GitHub
commit c89e60d5fa
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 4 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/components/instructeurs/column_picker_component.rb
View file

@ -12,7 +12,7 @@ class Instructeurs::ColumnPickerComponent < ApplicationComponent
def displayable_columns_for_select
[
procedure.columns.filter(&:displayable).map { |column| [column.label, column.id] },
procedure_presentation.displayed_fields.map { Column.new(**_1.deep_symbolize_keys.except(:virtual)).id } # TODO: remove virtual after migration
procedure_presentation.displayed_fields.map { Column.new(**_1.deep_symbolize_keys).id }
]
end
end

2
app/models/procedure_presentation.rb
View file

@ -32,7 +32,7 @@ class ProcedurePresentation < ApplicationRecord
def displayed_fields_for_headers
[
Column.new(table: 'self', column: 'id', classname: 'number-col'),
*displayed_fields.map { Column.new(**_1.deep_symbolize_keys.except(:virtual)) }, # TODO: remove virtual after migration
*displayed_fields.map { Column.new(**_1.deep_symbolize_keys) },
Column.new(table: 'self', column: 'state', classname: 'state-col'),
*procedure.sva_svr_columns
]

3
spec/components/instructeurs/column_picker_component_spec.rb
View file

@ -15,9 +15,6 @@ describe Instructeurs::ColumnPickerComponent, type: :component do
subject { component.displayable_columns_for_select }
before do
procedure_presentation.displayed_fields.first['virtual'] = true
procedure_presentation.save
allow(procedure).to receive(:columns).and_return([
default_user_email,
excluded_displayable_field

8
spec/models/procedure_presentation_spec.rb
View file

@ -14,7 +14,7 @@ describe ProcedurePresentation do
assign_to: assign_to,
displayed_fields: [
{ label: "test1", table: "user", column: "email" },
{ label: "test2", table: "type_de_champ", column: first_type_de_champ_id, virtual: false }
{ label: "test2", table: "type_de_champ", column: first_type_de_champ_id }
],
sort: { table: "user", column: "email", "order" => "asc" },
filters: filters)
@ -23,11 +23,7 @@ describe ProcedurePresentation do
let(:filters) { { "a-suivre" => [], "suivis" => [{ "label" => "label1", "table" => "self", "column" => "created_at" }] } }
describe "#displayed_fields" do
it { expect(procedure_presentation.displayed_fields).to eq([{ "label" => "test1", "table" => "user", "column" => "email" }, { "label" => "test2", "table" => "type_de_champ", "column" => first_type_de_champ_id, "virtual" => false }]) }
end
describe "#displayed_fields_for_headers" do
it { expect(procedure_presentation.displayed_fields_for_headers.map(&:label)).to eq(["Nº dossier", "test1", "test2", "Statut"]) }
it { expect(procedure_presentation.displayed_fields).to eq([{ "label" => "test1", "table" => "user", "column" => "email" }, { "label" => "test2", "table" => "type_de_champ", "column" => first_type_de_champ_id }]) }
end
describe "#sort" do