Commit graph

10018 commits

Author SHA1 Message Date
Pierre de La Morinerie
2d07ee00f4
Merge pull request #3254 from betagouv/spec_a_administrateur_always_has_a_gestionnaire
Spec Factory: an administrateur always has a gestionnaire
2019-01-09 16:20:45 +01:00
simon lehericey
ac43038566 SessionControllerSpec: refactor #create tests 2019-01-09 13:49:47 +01:00
simon lehericey
b38fbc78ef SessionControllerSpec: remove specific attribut test
change user.update(log_in_with_france_connect: nil) as log_in_france_connect is an enum
2019-01-09 13:49:47 +01:00
simon lehericey
9e26b5f4d8 SessionControllerSpec: small cleaning 2019-01-09 13:49:47 +01:00
simon lehericey
f5fa0499ca SessionControllerSpec: remove duplicated tests 2019-01-09 13:49:47 +01:00
simon lehericey
9c335698f1 SessionControllerSpec: remove password syncing relating test 2019-01-09 13:49:47 +01:00
simon lehericey
f0139c5962 Spec Factory: an administrateur always has a gestionnaire 2019-01-09 13:49:47 +01:00
Pierre de La Morinerie
4fafa6e339
Merge pull request #3262 from betagouv/fix-rake-task-output
tasks: prevent logs from being output to the console during tests
2019-01-08 14:07:27 +01:00
Pierre de La Morinerie
0b4c807292 tasks: prevent logs from being output to the console during tests 2019-01-08 13:51:35 +01:00
Pierre de La Morinerie
44cc811854
Merge pull request #3205 from tchak/champ-repetable-belongs-to-dossier
Fix champ repetition belongs_to associations
2019-01-08 13:28:11 +01:00
Paul Chavard
1beefe4469 Fix champ repetition belongs_to associations 2019-01-08 11:56:33 +00:00
gregoirenovel
531feb3515
Merge pull request #3240 from betagouv/values
Champ values
2019-01-08 12:42:44 +01:00
gregoirenovel
1c2f1a715c Rely on the champs partial for annotations privées when printing 2019-01-08 12:32:27 +01:00
gregoirenovel
55419b92a8 Simplify code 2019-01-08 12:32:27 +01:00
gregoirenovel
864bb38d8a Add #for_api methods to CheckboxChamp and YesNoChamp
Otherwise, we return nil instead of “off” / “non”,
so we don’t expose the data properly
2019-01-08 12:32:27 +01:00
gregoirenovel
0846bad1c8 Mutualize code in methods
As done in YesNoChamp
2019-01-08 12:32:27 +01:00
gregoirenovel
866c74ce63 Add Champ#for_api 2019-01-08 12:32:27 +01:00
gregoirenovel
083dfb4eaa Improve ProcedureExportService 2019-01-08 12:32:27 +01:00
gregoirenovel
b4781f7440 Make dossier link clickable for users in the Demande tab 2019-01-08 12:32:27 +01:00
gregoirenovel
cc07f0d701 Add a blank line to improve readability 2019-01-08 12:32:27 +01:00
gregoirenovel
e4f10a3d2d Order a case statement alphabetically 2019-01-08 12:32:26 +01:00
gregoirenovel
66c633a1e5 Mutualize some code 2019-01-08 12:32:26 +01:00
gregoirenovel
5014e3f4c1 Move the display logic directly into the carte champ partial 2019-01-08 12:32:26 +01:00
gregoirenovel
dbbe2866d5 Extract the siret champ view in a partial 2019-01-08 12:32:26 +01:00
gregoirenovel
c1ebae3ee8 Extract the textarea champ view in a partial 2019-01-08 12:32:26 +01:00
gregoirenovel
e6e67dab35 Extract multiple_drop_down_list champ view in a partial 2019-01-08 12:32:26 +01:00
gregoirenovel
81d6e193e5 Extract the piece_justificative champ view in a partial 2019-01-08 12:32:26 +01:00
gregoirenovel
c7f2293c15 Extract the dossier_link champ view in a partial 2019-01-08 12:32:26 +01:00
gregoirenovel
004cdd4c43 Add highlights to all champs 2019-01-08 12:32:26 +01:00
gregoirenovel
20ea577a66 Remove a case that can be handled by the general case 2019-01-08 12:32:26 +01:00
gregoirenovel
f9df32d72e Use c.to_s instead of value, to avoid confusion 2019-01-08 12:32:26 +01:00
gregoirenovel
f5a31be36a Remove the now useless #formatted_value method 2019-01-08 12:32:26 +01:00
gregoirenovel
c00aac2f80 We can now replace processing in #formatted_value by #to_s calls 2019-01-08 12:32:26 +01:00
gregoirenovel
f27717ab23 Make the CheckboxChamp export similar to YesNoChamp
Previously, nil values would be returned as nil
and not as off
2019-01-08 12:32:26 +01:00
gregoirenovel
4a6930b60a Remove from EngagementChamp a method it’s inheriting 2019-01-08 12:32:26 +01:00
gregoirenovel
66d1b7ba10 Use ternary conditions 2019-01-08 12:32:26 +01:00
gregoirenovel
9e42190148 Remove the proxy value_for_export method
Overload for_export instead
2019-01-08 12:32:26 +01:00
gregoirenovel
7cd50531cf Remove the proxy string_value method
Overload to_s instead
2019-01-08 12:32:26 +01:00
gregoirenovel
9a2341c56c Remove the useless #for_display proxy method 2019-01-08 12:32:26 +01:00
gregoirenovel
2e6c91e9b0 Move #selected_options to the only relevant model 2019-01-08 12:32:26 +01:00
gregoirenovel
c4b9a0b79e Rename DropDownList#selected_options_without_decorator 2019-01-08 12:32:26 +01:00
gregoirenovel
4b4eb6d53e Simplify code 2019-01-08 12:32:26 +01:00
gregoirenovel
16bccb2386 Remove the useless #value_for_export method 2019-01-08 12:32:26 +01:00
Mathieu Magnin
5fab5106cb
Merge pull request #3260 from betagouv/fix-sign-in-layout
layouts: fix styling of the sign_in and sign_up pages
2019-01-08 10:23:59 +01:00
Pierre de La Morinerie
142b684170 layouts: fix styling of the sign_in and sign_up pages
This was broken during the shared layout refactoring
2019-01-08 08:16:55 +01:00
Pierre de La Morinerie
d9acc47562
Merge pull request #3255 from betagouv/fix-send-button
Messagerie : corrige l'affichage du bouton "Envoyer" sur mobile
2019-01-07 16:35:45 +01:00
Pierre de La Morinerie
be1567ecbd messages: improve wording of the "Send" button 2019-01-07 16:20:23 +01:00
Pierre de La Morinerie
46b4d3c46b messages: fix Send button being clipped on mobile screens 2019-01-07 16:20:23 +01:00
gregoirenovel
263c94c2b5
Merge pull request #3180 from betagouv/common-demarches-layout
layouts: use a common layout for the demarche overview
2019-01-07 16:19:44 +01:00
Pierre de La Morinerie
0a7b061e70 layouts: move the procedure_context CSS to its own stylesheet 2019-01-07 15:40:19 +01:00