DGNum/demarches-normaliennes
15
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity
8217 commits 3 branches 1166 tags 84 MiB
Commit graph

4725 commits

Author SHA1 Message Date
Paul Chavard
c75e39884e Save selection utilisateur as geo area 2019-08-01 11:38:09 +02:00
clemkeirua
f5d3818e3c remove unnecessary retransition methods 2019-08-01 10:40:08 +02:00
Keirua
2f82dd9a3d improve typography and texts 
Co-Authored-By: Nicolas Bouilleaud <nico@bou.io>
 2019-08-01 10:29:51 +02:00
clemkeirua
38b48f4217 transition from accepte to instruction as superadmin 2019-08-01 10:29:51 +02:00
Paul Chavard
b266915892 Add repetitions to api 2019-08-01 10:04:35 +02:00
Paul Chavard
fba195c0b5 Add attestation url to dossier on api 2019-07-31 18:30:40 +02:00
Paul Chavard
6cfad01d12 Stop using Flipflop as switch for weekly_overview 2019-07-31 15:15:09 +02:00
Paul Chavard
25db21467d Stop using Flipflop as switch for Fog 2019-07-31 15:15:09 +02:00
Paul Chavard
6f3fde21f2
Merge pull request #4139 from Keirua/fix/confirm-on-delete-champ 
#4137 - Ajout d'un confirm à la suppression d'un champ
 2019-07-31 12:31:44 +02:00
Paul Chavard
fc75580a3c Start using pundit 2019-07-30 18:09:28 +02:00
Paul Chavard
8c72470a6c Add default etablissement champ name 2019-07-30 17:17:36 +02:00
Paul Chavard
ab1170bcfc Fix export dossier n+1 query 2019-07-30 17:17:36 +02:00
Paul Chavard
5a9468aa95 Fix repetition data export 2019-07-30 17:17:36 +02:00
Pierre de La Morinerie
02a5234bde lib: remove FileSizeValidator 
It was only used by the PieceJustificative model.
 2019-07-30 16:11:17 +02:00
Pierre de La Morinerie
65e7489b4f uploaders: remove PieceJustificativeUploader 2019-07-30 16:11:17 +02:00
Pierre de La Morinerie
95e24392f9 models: remove old pieces justificatives 2019-07-30 16:11:17 +02:00
Pierre de La Morinerie
ea1c8ea7e3 models: remove associations to old pieces justificatives 2019-07-30 16:11:17 +02:00
Pierre de La Morinerie
f6a1c7ded3 manager: remove support for old pj 2019-07-30 16:11:17 +02:00
Pierre de La Morinerie
0da0a2b446 model: remove support for cloning procedures with old pj 2019-07-30 16:11:17 +02:00
Pierre de La Morinerie
f69f325236 api: remove export of old pieces justificatives 2019-07-30 16:11:17 +02:00
Pierre de La Morinerie
e975fe4ade tasks: remove task to migrate old pieces justificatives 2019-07-30 16:11:17 +02:00
Pierre de La Morinerie
0018f36b44 gestionnaire: remove UI for filtering pieces justificatives 2019-07-30 16:11:16 +02:00
Pierre de La Morinerie
f825f62ce5 dossier: remove UI for viewing old pieces justificatives 2019-07-30 16:11:16 +02:00
Pierre de La Morinerie
5502f2e42e dossier: remove UI for uploading old pieces justificatives 2019-07-30 16:11:16 +02:00
Pierre de La Morinerie
0c4cb3b498 admin: remove UI for managing old pj 2019-07-30 16:11:16 +02:00
Nicolas Bouilleaud
7205f4da9e L'enfer du Nord Paris-Roubaix (Tour de France, Tour de France) 2019-07-30 14:47:48 +02:00
pedong
9438f962c5 add alert for account is locked 2019-07-29 17:48:44 +02:00
pedong
0ed9c4cbd4 add check access_locked? when login 2019-07-29 17:48:44 +02:00
pedong
8d03a6747c add lockable to User, Gestionnaire, administration, Administrateur 2019-07-29 17:48:44 +02:00
Nicolas Bouilleaud
b066ccbc89 Make sure Procedure.path is not null in our data 2019-07-29 13:53:33 +02:00
Pierre de La Morinerie
bcd5182446 dossier: hide the draft explanation when already submitted 2019-07-29 10:54:19 +02:00
Pierre de La Morinerie
e99edda7b1 dossiers: hide the Edit button on the actual edit page 
Otherwise the "Edit" button may be confused for a "Save" button.
 2019-07-29 10:49:49 +02:00
Pierre de La Morinerie
7b345365fd dossiers: fix the layout of the Edit button 2019-07-29 10:45:49 +02:00
Pierre de La Morinerie
f1838f3767 dossiers: fix edit button being visible on locked dossiers 
Fix #4143
 2019-07-29 10:41:58 +02:00
clemkeirua
314b0f5dc0 fix tests 2019-07-25 17:15:19 +02:00
clemkeirua
6f47655301 rendu lien_site_web obligatoire au moment de la publication 2019-07-25 15:46:04 +02:00
clemkeirua
6b19432d47 deplacement de l'URL qui envoie vers la procédure 2019-07-25 15:46:04 +02:00
Pierre de La Morinerie
2174172e34 admin: display CTA buttons in emails preview 2019-07-25 12:25:50 +02:00
Pierre de La Morinerie
1c837eb901 mailers: improve wording of transactional emails and default templates 2019-07-25 12:25:50 +02:00
Pierre de La Morinerie
8313752663 mailers: add CTA to templated emails 2019-07-25 12:25:50 +02:00
Pierre de La Morinerie
6195ee41f3 mailers: add CTA to new_draft email 2019-07-25 12:25:50 +02:00
Pierre de La Morinerie
45c62cefb2 helpers: add vertical_margin helper for mailers 2019-07-25 12:25:50 +02:00
Pierre de La Morinerie
2c612f6448 helpers: add variants to mailer_round_button 2019-07-25 12:25:50 +02:00
Pierre de La Morinerie
3abb0a1c44 helpers: prevent information leakage from round_button links 2019-07-25 12:25:50 +02:00
clemkeirua
2ff6958ad6 better spacing 2019-07-25 11:40:46 +02:00
clemkeirua
a9708bff5d ajout d'infos pratiques pour aller chercher son siret 2019-07-25 11:39:16 +02:00
Pierre de La Morinerie
079ac3da33 invite: signal that the message is optional 2019-07-25 11:10:49 +02:00
clemkeirua
caa90613fd ajout d'un confirm à la suppression d'un champ 2019-07-25 10:46:40 +02:00
Chaïb Martinez
14192916f1 Add edit dossier link 
[fix #4114]

Signed-off-by: Chaïb Martinez <chaibax@gmail.com>
 2019-07-24 12:21:35 +02:00
pedong
4a0873c5af add quote show the message invite 2019-07-23 19:05:56 +02:00
pedong
0f957ec77b [fixe #3974] add message for invite mail 2019-07-23 18:54:58 +02:00
Chaïb Martinez
ff395b8c4b Add a triggered message in chat box for new admins 😎 
Remove useless text
[fix #4052]

Signed-off-by: Chaïb Martinez <chaibax@gmail.com>
 2019-07-23 17:08:35 +02:00
clemkeirua
af436500fd better button 2019-07-23 16:11:15 +02:00
clemkeirua
f166077f5e ajout d'un bouton de suppression des admin dans le manager 2019-07-23 16:11:15 +02:00
Pierre de La Morinerie
858b093314 mailers: use the standard view mechanism to render notifications 
Instead of rendering a view as a template, consider the view as a normal
view.
 2019-07-23 14:53:50 +02:00
Pierre de La Morinerie
5bbcd600fb mailers: extract more of the template to partials 
This will allow to re-use these partials in other emails
 2019-07-23 14:53:32 +02:00
Pierre de La Morinerie
45abb6ebc2 mailers: move default templates to a specific subdirectory 
It makes more understandable that they are templates (and not views
rendered directly by Rails).
 2019-07-22 16:22:20 +02:00
Pierre de La Morinerie
dbe03d4f74 suivi: remove link to stats dashboard 
The dashboard is currently private–and it currently contains sensitive
informations that are hard to filter out.
 2019-07-22 11:49:09 +02:00
Pierre de La Morinerie
af6172d0e8 suivi: explain how to disable tracking 2019-07-22 11:48:28 +02:00
clemkeirua
50ddf723b0 garde le bandeau bleu de navigation après MAJ 2019-07-22 10:27:33 +02:00
clemkeirua
2e107babfb meilleures marges monavis 2019-07-18 17:39:06 +02:00
clemkeirua
d62740c198 extraction de la taille max des fichiers dans une constante 2019-07-18 17:19:39 +02:00
clemkeirua
f7842fa4bd ajout d'un message lorsque le dossier fait plus de 50Mo 2019-07-18 16:39:59 +02:00
Pierre de La Morinerie
3c0ba5e698 emails: improve wording of the messagerie nudge 2019-07-18 12:38:13 +02:00
Pierre de La Morinerie
f88d7c28fa emails: add a "Read message" button to the new answer email 2019-07-18 12:38:13 +02:00
Pierre de La Morinerie
630ae06542 emails: sign the new answer email as the administration 2019-07-18 12:38:13 +02:00
Pierre de La Morinerie
8b80c48679 emails: use the notification template for more messages 
This allow to display the procedure logo and contact footer
at the bottom of these emails.
 2019-07-18 12:38:13 +02:00
Pierre de La Morinerie
b157d860d2 emails: adjust notification footer for dossiers without messagerie 2019-07-18 12:38:13 +02:00
Pierre de La Morinerie
37c93e634e emails: clarify the notify_new_draft action 2019-07-18 12:38:13 +02:00
clemkeirua
ee8a1092e4 extracted MonAvisEmbedValidator 2019-07-17 18:04:32 +02:00
clemkeirua
91d10c0cf7 added navbar for mon avis 2019-07-17 18:04:32 +02:00
clemkeirua
6d43465ee5 renammed into monavis_embed 2019-07-17 18:04:32 +02:00
clemkeirua
8d2c5cfa14 validation par regex 2019-07-17 18:04:32 +02:00
clemkeirua
d8b63cd4c9 added 'monavis' inside the procedure and for users 2019-07-17 18:04:32 +02:00
Pierre de La Morinerie
727702ad4b emails: mention the procedure name in the email title 2019-07-17 15:01:19 +02:00
Pierre de La Morinerie
71dfb38787 emails: improve typography of titles 2019-07-17 15:01:19 +02:00
Pierre de La Morinerie
bc42c90fe5 emails: make signature more compact 2019-07-17 14:55:55 +02:00
Pierre de La Morinerie
bd39eb3453 emails: remove dead code 2019-07-17 14:55:55 +02:00
clemkeirua
7eeddc0b79 using a shared example + scoped to state TERMINE 2019-07-17 11:53:16 +02:00
clemkeirua
b8fa567c81 ajout du tag 'lien document justificatif' 2019-07-17 11:53:16 +02:00
Pierre de La Morinerie
d86030fb76 dossier: add a reply icon near to "Reply to message" button 2019-07-17 11:43:21 +02:00
Pierre de La Morinerie
b4fe6e236e messagerie: improve the textarea placeholder 2019-07-17 11:43:21 +02:00
Pierre de La Morinerie
92dd91a31b messagerie: add a reply button next to the latest message 2019-07-17 11:43:21 +02:00
Pierre de La Morinerie
09efd06dff forms: add a focus indicator to focused fields 2019-07-17 11:43:21 +02:00
Pierre de La Morinerie
80efe27ff2 pj migration: retry when changing the content type fails 2019-07-16 17:51:29 +02:00
Pierre de La Morinerie
a8354bd103 dossiers: unify deletion of dossiers between manager and user 
The code paths for deleting a dossier were different, depending on
whether the dossier was deleted by the user, or from the Manager.

This commit unifies the two code paths into one.

This has the effect of:

- An operation log is now recorded when an user deletes its own dossier;
- Gestionnaires are now notified even when the dossier is deleted from
  the Manager;
- The `support:delete_user_account` task now requires the email address
  of the author.
 2019-07-16 16:22:20 +02:00
clemkeirua
25f81f1d3c download a dossier as zip with all attachments 2019-07-16 09:11:25 +02:00
Pierre de La Morinerie
76335511c8 omniauth: protect against CSRF 
See https://github.com/omniauth/omniauth/wiki/Resolving-CVE-2015-9284
 2019-07-15 18:16:00 +02:00
Pierre de La Morinerie
36eca3d059 dossier: rename the "Submit" action 2019-07-15 17:18:28 +02:00
Pierre de La Morinerie
862b08427b status_overview: remove extraneous line 2019-07-15 15:55:25 +02:00
Pierre de La Morinerie
d9c01c0af6 status_overview: improve wording 2019-07-15 15:45:16 +02:00
Benjamin-Doberset
8ea8e52431 Update _status_overview.html.haml 2019-07-15 15:45:16 +02:00
Pierre de La Morinerie
077082c381 dossier: improve estimated delay wording 2019-07-15 15:27:22 +02:00
Benjamin-Doberset
77d825ae63 Update _estimated_delay.html.haml 2019-07-15 15:27:22 +02:00
Chaïb Martinez
5cb6ba2f3b Fix tests 
Signed-off-by: Chaïb Martinez <chaibax@gmail.com>
 2019-07-15 12:10:56 +02:00
Chaïb Martinez
3f9f67eb78 admin: fix the "Valider" button being hidden by Crisp 
Fix #4021

Signed-off-by: Chaïb Martinez <chaibax@gmail.com>
 2019-07-15 12:10:56 +02:00
Chaïb Martinez
d968e7e6bd Add some admin usage info for contextual help with crisp 
Fix #4052

Signed-off-by: Chaïb Martinez <chaibax@gmail.com>
 2019-07-15 12:10:56 +02:00
Chaïb Martinez
04e204c740 Minor text fix 
Signed-off-by: Chaïb Martinez <chaibax@gmail.com>
 2019-07-15 12:10:56 +02:00
Chaïb Martinez
535d032b73 Send URL page view to Crisp to trigger contextual help 
Fix #4052

Signed-off-by: Chaïb Martinez <chaibax@gmail.com>
 2019-07-15 12:10:56 +02:00
Pierre de La Morinerie
d5f360c85f manager: fix the deletion email not being sent 
When deleting a dossier from the manager, the deletion notification
email was not being sent. This is because the returned object from
`Dossier#hide!` was invalid.
 2019-07-15 10:01:16 +02:00
Pierre de La Morinerie
619f663e1a procedure: remove individual_with_siret column 2019-07-11 15:57:46 +02:00
Pierre de La Morinerie
a047ee356b procedure: remove expects_multiple_submissions column 2019-07-11 15:57:46 +02:00
clemkeirua
6838e69986 ajout de textes explicatifs pour les instructeurs 2019-07-11 15:48:00 +02:00
Pierre de La Morinerie
35c3795f56 dossier: make messagerie available on archived procedures 
An Admin may archive a procedure to make it unavailable to
the general public, but before all dossiers are handled. In this case,
the messagerie needs to be available.

Fix #4089
 2019-07-11 15:37:04 +02:00
Pierre de La Morinerie
10065df8ce champs: put champ label in numeric fields validation messages 
Replaces

> La valeur du champ doit être un nombre entier (sans chiffres après
> la virgule)

by

> La valeur du champ « Nombre de parents » doit être un nombre entier
> (sans chiffres après la virgule)
 2019-07-11 15:12:48 +02:00
simon lehericey
768a298c2d Same for go back in instruction 2019-07-11 12:50:15 +02:00
simon lehericey
5f39d3eac8 Fix bug when instruction repasse en construction twice 2019-07-11 12:50:15 +02:00
simon lehericey
6de1e2ec58 Fix bug when an instructeur closes a dossier already closed 2019-07-11 12:50:15 +02:00
Pierre de La Morinerie
fdca7c025a procedure: ignore :expects_multiple_submissions on the correct model 2019-07-11 12:14:25 +02:00
Pierre de La Morinerie
c2c9b19b3b procedure: remove individual_with_siret 
It isn't used anymore (see #3077)
 2019-07-11 11:58:21 +02:00
Pierre de La Morinerie
7ca3d5fce2 procedure: select for_individual by default 2019-07-10 18:47:34 +02:00
Pierre de La Morinerie
9616df192d procedure: use the model value for checking the radio buttons 
Previously `checked: true` forced the checked status, disregarding the
actual value of the model.

Fix #4080
 2019-07-10 18:47:28 +02:00
Paul Chavard
3cb39c2840 Refactor message attachements to use active_storage 2019-07-10 15:35:29 +02:00
Pierre de La Morinerie
03fc555edf profile: send an email when the account is already taken 2019-07-10 11:31:09 +02:00
Pierre de La Morinerie
80074d6d82 profile: improve layout and wording of the confirmation message 2019-07-10 11:31:09 +02:00
Pierre de La Morinerie
f8a1911625 profile: display profile page even for single-role users 2019-07-10 11:31:09 +02:00
benjaminhenkel
c36b884adf Update _state_button.html.haml 
changement faute d'orthographe
 2019-07-10 10:41:13 +02:00
simon lehericey
f6c402deec better default value for linked_drop_down_list 2019-07-10 10:21:34 +02:00
clemkeirua
d29be1fe41 suppression de redouane de Pipedrive 2019-07-09 17:29:25 +02:00
clemkeirua
4c9846dcd1 Mise à jour du mail d'activation admin 2019-07-09 17:29:25 +02:00
clemkeirua
1f3015e24f suppression de camille de la liste pipedrive 2019-07-09 17:29:25 +02:00
Pierre de La Morinerie
06afc3890f france_connect: raise an error if some validation error occurs 
If a validation error occurs in `find_or_create`, an object without `id`
will be returned–and the code will crash soon after.

Ensure that we crash immediately, so that we can report the root cause
(the validation error) instead of a seemingly-unrelated crash later.
 2019-07-09 15:50:28 +02:00
Pierre de La Morinerie
6b27ac8514 france_connect: make existing user lookup case-insensitive 
Fix #4053
 2019-07-09 15:50:28 +02:00
Pierre de La Morinerie
ecfccae6f0 dossiers: remove support for Dossier#expects_multiple_submissions 2019-07-09 14:50:11 +02:00
Pierre de La Morinerie
d77a5552b7 dossiers: allow to start a new dossier after submitting one 2019-07-09 14:44:36 +02:00
Pierre de La Morinerie
b5ed74c09d dossiers: always allow to create a new dossier 
Turns out this is confusing for users (some UI elements are present for
some procedures, but not for others).

Better enable it for everyone.
 2019-07-09 14:44:30 +02:00
simon lehericey
ea79b9a595 typo: use ’ 2019-07-09 11:55:17 +02:00
simon lehericey
d36f6ebcd7 [fix #1709] A user can change its email 2019-07-09 11:55:17 +02:00
simon lehericey
d68d2be798 Profil: accessible to all roles 2019-07-09 11:55:17 +02:00
clemkeirua
39f72a2be3 courbage d'apostrophes 2019-07-09 10:59:42 +02:00
clemkeirua
44fa210e34 changement du choix particulier/entreprise lors de creation d'une procedure 2019-07-09 10:59:42 +02:00
Paul Chavard
ad0a74ea7c Fix dates in dossiers export 2019-07-09 10:02:08 +02:00
Pierre de La Morinerie
422f4b9cdb dossiers_controller: warn properly when instructing a dossier twice 
Fix #4055
 2019-07-08 17:58:45 +02:00
Nicolas Bouilleaud
930fd345de Validate messagerie_available? when creating a new Commentaire 
Commentaires bu Users and Gestionnaire need the messagerie to be available; Automatic system Commentaires can be created anytime.

This reintroduces Commentaire validation that was introduced in #3979 and disabled in #4018
 2019-07-08 16:13:43 +02:00
Nicolas Bouilleaud
3f439ac07a Add Commentaire.is_sent_by_system? and .is_sent_by(someone) 
And use it in CommentaireHelper and in the _message_icon and _message_issuer partials
 2019-07-08 16:06:44 +02:00
Nicolas Bouilleaud
2abd93d360 Display the full User email in Commentaires 
* Only redact gestionnaires’ emails
* Also, rename Commentaire.sender to Commentaire.redacted_email
 2019-07-08 16:06:44 +02:00
Nicolas Bouilleaud
3bf19de124 Remove Commentaire::columns override 
It was used for a cleanup migration a long time ago (see #233, #3033, #3043)
 2019-07-08 16:06:44 +02:00
Nicolas Bouilleaud
7e98213829 Pass the signed-in user as the commentaire author from /contact 2019-07-08 16:06:44 +02:00
Nicolas Bouilleaud
72fd5d250f Respect dossier.messagerie_available? in SupportController (/contact) 2019-07-08 16:06:44 +02:00
Nicolas Bouilleaud
12008728d2 Actually respect dossier.messagerie_available? in _messagerie.html.haml 
instead of dossier.archived?

(fixup after #3979)
 2019-07-08 16:06:44 +02:00
Chaïb Martinez
c43b0c00db minor text change [fix #4050] 
Signed-off-by: Chaïb Martinez <chaibax@gmail.com>
 2019-07-08 14:46:47 +02:00
Chaïb Martinez
94d340d25c Remove phone number 
Add chat link

Signed-off-by: Chaïb Martinez <chaibax@gmail.com>
 2019-07-08 14:32:55 +02:00
Chaïb Martinez
0fdae2456b We will not quibble 
Signed-off-by: Chaïb Martinez <chaibax@gmail.com>
 2019-07-08 14:20:49 +02:00
Nicolas Bouilleaud
4d73275bab Drop Procedure.administrateur_id 2019-07-04 17:01:12 +02:00
maatinito
fee3ef8f4f A4 output and allows large logos (headers) to take the whole width of the page 2019-07-03 15:31:34 -10:00
Paul Chavard
05987223db Avoid crashing when demarche have no service 2019-07-03 17:18:44 +02:00
Paul Chavard
e582ff729c Add aasm to dossiers state 2019-07-03 13:37:27 +02:00
Mathieu Magnin
10d3ba10f2 Before save copy body in rich_body 2019-07-03 13:15:49 +02:00
Mathieu Magnin
d13b7f953f Migrate mail body to ActionText 2019-07-03 13:15:49 +02:00
Mathieu Magnin
b34f8fbe3d Add ActionText 2019-07-03 13:15:49 +02:00