Corinne Durrmeyer
fcb868c6a8
Merge pull request #10893 from demarches-simplifiees/a11y-form-errors
...
Améliore la restitution des message d'erreur lors d'une soumission en erreur
2024-10-17 10:37:32 +00:00
Paul Chavard
4e8336ce88
Merge pull request #10897 from tchak/refactor-dossier-diff-merge
...
ETQ dev, je ne veux plus de méthode `champs_for_revision`
2024-10-17 09:54:08 +00:00
Paul Chavard
0529718c4b
refactor(dossier): the end of champs_for_revision
2024-10-17 11:33:24 +02:00
Paul Chavard
dd97c2fffd
refactor(dossier): diff and merge
2024-10-17 11:33:24 +02:00
Paul Chavard
8c8bb870fc
refactor(dossier): filled champs
2024-10-17 11:33:24 +02:00
Paul Chavard
ad7458a12f
Merge pull request #10931 from tchak/better-handle-api-entreprise-jobs
...
fix(api_entreprise): better handle api entreprise errors
2024-10-17 09:30:09 +00:00
simon lehericey
7963746ed7
fix: suggest multiple_drop_down options on the filter component
2024-10-16 18:09:52 +02:00
simon lehericey
4059bfdc11
fix: make filter works on multiple_drop_down_list
2024-10-16 18:09:51 +02:00
Colin Darie
5522efc3e5
Merge pull request #10954 from tchak/fix-dossier-merge-with-multiple-rows
...
ETQ usager, fix soumission d'un dossier en construction quand multiples lignes de champs répétables ont été modifiées
2024-10-16 15:00:26 +00:00
LeSim
6862f6c6bd
Merge pull request #10875 from demarches-simplifiees/add_id_to_column_third_part
...
Utilisation des colonnes dans l'affichage et le filtrage
2024-10-16 14:53:30 +00:00
Paul Chavard
c417614695
fix(dossier): fix apply_diff with multiple changed rows
2024-10-16 14:15:26 +02:00
Eric Leroy-Terquem
f7bd2fb68d
Merge pull request #10942 from demarches-simplifiees/fix-import-groupes-instructeurs
...
Correctif : ETQ admin je peux importer des groupes d'instructeurs
2024-10-15 19:57:50 +00:00
Mathieu Magnin
04bbf09097
Merge pull request #10939 from demarches-simplifiees/fix-10919
...
Correction bug champ carto
2024-10-15 18:13:13 +00:00
Eric Leroy-Terquem
ea27d3208f
feat(groupes management): add import component
2024-10-15 18:04:33 +02:00
simon lehericey
5621edcca8
remove unused filtered? method
2024-10-15 16:09:09 +02:00
simon lehericey
f850924dc0
remove procedure_presentation from export
2024-10-15 16:09:09 +02:00
simon lehericey
71bcbbc440
remove useless snapshot
2024-10-15 16:09:09 +02:00
simon lehericey
b5ed8c9b61
export cache_key based on column
2024-10-15 16:09:08 +02:00
simon lehericey
954d232a47
add filtered and sorted columns to export
2024-10-15 16:09:08 +02:00
simon lehericey
603c2a108e
remove useless Export.by_key procedure_presentation arg
2024-10-15 16:09:08 +02:00
simon lehericey
d1530b40a1
use the filter_service
2024-10-15 16:09:08 +02:00
simon lehericey
4d7715fbb6
extract filter and sort function to a filter_service
2024-10-15 16:09:08 +02:00
simon lehericey
16e93a217b
reset procedure_presentation if a pb occurs with a column deserialization
2024-10-15 16:09:07 +02:00
mfo
112d49cb51
tech(deadcode): remove unused constant on ProcedurePresentation
2024-10-15 16:09:07 +02:00
simon lehericey
e41326dad5
tech(clean): remove sva_columns(for_filters)
...
Co-authored-by: mfo <mfo@users.noreply.github.com>
2024-10-15 16:09:07 +02:00
simon lehericey
3677f3b2d3
tech(clean): remove Column classname: attribute
...
Co-authored-by: mfo <mfo@users.noreply.github.com>
2024-10-15 16:09:07 +02:00
simon lehericey
30fcb75da4
extract dossier_state_column
2024-10-15 16:09:07 +02:00
mfo
242ab78235
clean(deadcode): remove unused current_filters method
2024-10-15 16:09:07 +02:00
simon lehericey
14483270ba
default default_displayed_column
2024-10-15 16:09:06 +02:00
simon lehericey
0a54db6db5
remove human_to_filter
2024-10-15 16:09:06 +02:00
simon lehericey
b2754cd26c
move validations concern to filtered_column
...
Co-authored-by: mfo <mfo@users.noreply.github.com>
2024-10-15 16:09:06 +02:00
simon lehericey
6b5efbda07
remove now unused code
2024-10-15 16:09:06 +02:00
simon lehericey
14fe11b612
use displayed_columns !
2024-10-15 16:09:06 +02:00
simon lehericey
7e4ca07df2
use filtered_column to filter !
...
Co-authored-by: mfo <mfo@users.noreply.github.com>
2024-10-15 16:09:05 +02:00
simon lehericey
4c5d7e2950
remove now useless add_filters and remove_filters
2024-10-15 16:09:05 +02:00
simon lehericey
72c389161a
remove filter using generic add_filter methods
2024-10-15 16:09:05 +02:00
simon lehericey
175f303399
display filter tags
2024-10-15 16:09:05 +02:00
simon lehericey
e9c11a95f1
directly write in new filter columns
2024-10-15 16:09:05 +02:00
simon lehericey
d54ab64e40
add filtered_column type
2024-10-15 16:09:05 +02:00
simon lehericey
4e0d3c2df1
improve Column not found error message
2024-10-15 15:48:41 +02:00
simon lehericey
3e73ff0d35
small refactors
2024-10-15 15:48:41 +02:00
Mathieu Magnin
097074fdc7
Merge pull request #10865 from demarches-simplifiees/fix-10799
...
ETQ Admin / Instructeur je veux être savoir si le jeton api entreprise d'une démarche a expiré ou va expirer prochainement
2024-10-15 13:25:20 +00:00
Paul Chavard
d13c475170
fix(api_entreprise): better handle api entreprise errors
2024-10-15 15:24:37 +02:00
Benoit Queyron
c8f69283cc
Merge pull request #10713 from demarches-simplifiees/etq-admin-bug-message-info-character-limit
...
Tech : amélioration de la gestion des types_de_champ.options
2024-10-15 13:02:33 +00:00
Paul Chavard
8ddec687e6
Merge pull request #10873 from tchak/refactor-repetition-remove-parent_id
...
ETQ dev, je ne veux plus avoir de relation entre les champs et leur parent
2024-10-15 13:00:52 +00:00
Mathieu Magnin
029a75404d
[ #10799 ] Fixes after @E-L-T review's
2024-10-15 14:40:51 +02:00
Mathieu Magnin
6bdc641cdf
[ #10799 ] Fix after Marlène's review
2024-10-15 14:40:51 +02:00
Mathieu Magnin
c897893e8a
[ #10799 ] Remove dead code
2024-10-15 14:40:50 +02:00
Mathieu Magnin
e172f3ed6c
[ #10799 ] Fix tests
2024-10-15 14:40:50 +02:00
Mathieu Magnin
f26ff30538
[ #10799 ] Add maintenance task to fill api_entreprise_token_expires_at for previous data
2024-10-15 14:40:50 +02:00
Mathieu Magnin
6b326b634e
[ #10799 ] Modifications after Marlene's comments
2024-10-15 14:40:50 +02:00
Mathieu Magnin
687617cb08
[ #10799 ] Add test
2024-10-15 14:40:50 +02:00
Mathieu Magnin
64297f9ee8
[ #10799 ] Add error on procedure#show if api entreprise token is expiring
2024-10-15 14:40:50 +02:00
Mathieu Magnin
99a1b68185
[ #10799 ] reorder methods A->Z
2024-10-15 14:40:49 +02:00
Mathieu Magnin
2bf773b0b7
[ #10799 ] Add warning badges when token is expiring
2024-10-15 14:40:49 +02:00
Mathieu Magnin
ec2c913ab4
[ #10799 ] Display token error on related card
2024-10-15 14:40:49 +02:00
Mathieu Magnin
703a722c54
[ #10799 ] Handle the case when api_entreprise_token is not nil then set to nil
2024-10-15 14:40:49 +02:00
Mathieu Magnin
7009eed9d7
[ #10799 ] Move api entreprise token logic in a concern
2024-10-15 14:40:49 +02:00
Mathieu Magnin
39fdb8ddbb
[ #10799 ] Display a warning about token expiration on token form page
2024-10-15 14:40:49 +02:00
Mathieu Magnin
2d9854dc01
[ #10799 ] Declare api_entreprise_token_expires_at attribute and feed it on save
2024-10-15 14:40:49 +02:00
benoitqueyron
e88d84cf57
ajout d'un nettoyage des options des types_de_champ lors de la publication d'une procedure ou d'une nouvelle revision
2024-10-15 14:40:33 +02:00
benoitqueyron
4f62590b7a
ProcedureRevision#compare_type_de_champ: fix bug comparaison character_limit chaine vide vs nil
2024-10-15 14:40:33 +02:00
benoitqueyron
3c5749e45a
TypeDeChamp: purge notice explicative lors d'un changement de type_champ
2024-10-15 14:40:33 +02:00
simon lehericey
b588b77571
TypeDeChamp: amélioration de la gestion des drop_down_options
2024-10-15 14:40:15 +02:00
Mathieu Magnin
49c9f274e4
[ #10919 ] When data in geo_area is invalid do not crash when .label is called
2024-10-15 14:37:32 +02:00
Corinne Durrmeyer
89d31ddf11
Improve rendering of “n°” by assistive technologies
2024-10-15 12:18:23 +02:00
Corinne Durrmeyer
8ca1f82b01
Place focus on error block on page reload
2024-10-15 11:58:45 +02:00
Corinne Durrmeyer
fbb7bd7989
Adds title before error list & remove useless link
2024-10-15 11:58:45 +02:00
Paul Chavard
bd32f5693d
refactor(repetition): remove parent_id
2024-10-15 11:42:36 +02:00
Christophe Robillard
47a4f40939
destroy export_templates when destroy groupe_instructeur
2024-10-15 11:18:58 +02:00
mfo
e7080c1ad1
Merge pull request #10927 from mfo/US/renormalize_department_code_and_name
...
amelioration ETQ tech, je souhaite que les composants d'adresses soient normalisés en anglais
2024-10-15 07:49:16 +00:00
mfo
366c02dbb7
fix(typo): use english for normalized addresses component
2024-10-15 09:13:05 +02:00
Colin Darie
ed6a254135
Merge pull request #10930 from colinux/fix-dropdown-list-filter-length
...
ETQ instructeur je peux filtrer un champ "choix simple" avec un long libellé d'option
2024-10-14 19:18:35 +00:00
Colin Darie
1c32a30b80
fix(filters): drop down list filters can have much longer values.
...
Notre infra supporte des urls d'au moins 8000 caractères, probablement
plus encore, donc on est large.
2024-10-14 16:01:48 +02:00
Eric Leroy-Terquem
3ed7e7d2e0
feat(instructeurs management): update notification alert if procedure is published
2024-10-14 15:14:07 +02:00
Eric Leroy-Terquem
b75f2125de
refactor(import component): remove path duplication
2024-10-14 15:14:06 +02:00
Eric Leroy-Terquem
7af934daf5
feat(instructeurs import): display submit button only if file uploaded
2024-10-14 15:14:06 +02:00
Eric Leroy-Terquem
ec7aea50b3
style(instructeurs management): update instructeurs view
2024-10-14 15:13:58 +02:00
Eric Leroy-Terquem
ee71a8479f
refactor(instructeurs import): extract import in a component
2024-10-14 15:13:57 +02:00
Eric Leroy-Terquem
822f856ae9
feat(instructeurs management): update instructeur import for groupe instructeur page
2024-10-14 15:13:47 +02:00
Eric Leroy-Terquem
1f6d76a4dd
feat(instructeurs management): can export instructeurs if procedure not routed
2024-10-14 15:13:36 +02:00
Eric Leroy-Terquem
ec2f7c2405
feat(instructeurs import): add copy paste hint
2024-10-14 15:13:35 +02:00
Eric Leroy-Terquem
cdd9157927
feat(instructeurs import): add notification alert
2024-10-14 15:13:35 +02:00
Eric Leroy-Terquem
c68e0b5f1a
style(instructeurs import): update import card
2024-10-14 15:13:35 +02:00
Eric Leroy-Terquem
af1fd34256
feat(instructeurs import): can import instructeurs even if procedure not published
2024-10-14 15:13:35 +02:00
Eric Leroy-Terquem
59fe8b64c4
wording(instructeurs management): update translations
2024-10-14 15:13:35 +02:00
Colin Darie
df0e0e9c3e
perf(admin): remove N+1 on procedures index about instructeurs or groupe instructeurs count
2024-10-14 12:27:01 +02:00
Colin Darie
4336c444ba
style(combo): better vertical spacing between tags list and input
2024-10-14 10:30:16 +02:00
Colin Darie
ef5d196f80
fix(admin): homogeneize wording tags => thèmes/thématiques
2024-10-14 10:26:47 +02:00
Kara Diaby
2c85757289
Créé la liste de nouveaux tags en base et les associe aux démarches
2024-10-14 10:26:47 +02:00
Kara Diaby
1c651b4c93
Les admins ont la possibilité de filtrer les démarches par liste prédéfinie dans la page toutes les démarches
2024-10-14 10:26:47 +02:00
Kara Diaby
fd7dcc7048
Les admins peuvent associer une démarche à une thématique prédéfinie
2024-10-14 10:26:46 +02:00
Kara Diaby
f025e08336
Ajoute la table procedure tags et la liaison entre procedure et procedures tags
2024-10-14 10:26:46 +02:00
Paul Chavard
32d8cbfe48
Merge pull request #10923 from tchak/graphql-siret-address-optimize
...
fix(graphql): parse_etablissement_address is slow (up to 300ms) – bypasse it when possible
2024-10-14 08:14:51 +00:00
Paul Chavard
960385831e
Merge pull request #10904 from tchak/remove-some-complex-champs-from-prefill
...
chore(prefill): remove unused prefill support on complex champs
2024-10-14 08:11:30 +00:00
Paul Chavard
b027839721
fix(graphql): parse_etablissement_address is slow (300ms) – bypasse it when possible
2024-10-14 09:23:35 +02:00
Paul Chavard
8266f7ff6c
Merge pull request #10922 from demarches-simplifiees/fix_10921
...
Gestion de nouveaux codes d'erreur dans l'API Entreprise
2024-10-11 15:37:48 +00:00
Paul Chavard
f0d334ea69
Merge pull request #10916 from tchak/graphql-fix-n+1
...
fix(graphql): n+1 on procedure and france_connect_informations
2024-10-11 15:20:53 +00:00
Mathieu Magnin
2222b6ff2d
[ #10921 ] Extend error handling to cover new error codes
2024-10-11 16:16:17 +02:00
Eric Leroy-Terquem
3b054c5369
refactor(views): do not use instance variable in views
2024-10-11 13:14:20 +02:00
Paul Chavard
a3375be7c5
fix(graphql): n+1 on procedure and france_connect_informations
2024-10-11 12:20:24 +02:00
Eric Leroy-Terquem
72ae654ce7
style(pieces jointes): update UI
2024-10-11 11:20:47 +02:00
Eric Leroy-Terquem
bca2b79c70
refactor(dossier): use dossier method to set dossier
2024-10-11 11:20:47 +02:00
Eric Leroy-Terquem
838dc0a9e3
perf(dossier): cache gallery attachments
2024-10-11 11:20:47 +02:00
Eric Leroy-Terquem
c6ab05dcc5
fix(gallery): display pieces_jointes tab if any attachments
2024-10-11 11:20:46 +02:00
Eric Leroy-Terquem
4f42e00f4e
refactor(gallery): move methods in private
2024-10-11 11:20:46 +02:00
Eric Leroy-Terquem
3bc232e81e
feat(gallery): update gallery item badge class after seen
2024-10-11 11:20:46 +02:00
Eric Leroy-Terquem
d9f604e8ce
feat(gallery): notify instructeur if pieces jointes updates
2024-10-11 11:20:46 +02:00
Eric Leroy-Terquem
bc237152e7
feat(gallery): add origin tag to gallery item
2024-10-11 10:41:05 +02:00
Eric Leroy-Terquem
df08617387
feat(gallery): add badge for date of created_at or updated_at
2024-10-11 10:41:04 +02:00
Eric Leroy-Terquem
3560d73b58
refactor(gallery): use gallery component in gallery demande
2024-10-11 10:41:04 +02:00
Eric Leroy-Terquem
664ef63e74
refactor(gallery): extract gallery_link method
2024-10-11 10:41:04 +02:00
Eric Leroy-Terquem
2882af43aa
refactor(gallery): extract representation_url_for method
2024-10-11 10:41:04 +02:00
Eric Leroy-Terquem
bae752f1aa
refactor(gallery): add attachment_gallery_item component
2024-10-11 10:41:03 +02:00
mfo
7c84937c8c
ETQ tech, je souhaite que les jobs asynchrone expirés les dossiers terminés se fassent en pleinne nuit
2024-10-10 18:09:04 +02:00
Colin Darie
111ebbf20a
Merge pull request #10910 from colinux/fix-image-process-job-queue
...
ETQ opérateur, je ne veux pas que la génération de vignettes et filigranes impactent trop d'autres jobs
2024-10-10 15:24:12 +00:00
Colin Darie
0e5d77f15b
fix(job): image process => low queue
2024-10-10 17:14:57 +02:00
Colin Darie
7f18db6c91
fix(job): non crirtical mail must be sent into < 15min, not hours
2024-10-10 17:14:28 +02:00
mfo
eee9efd52e
Merge pull request #10907 from mfo/reschedule_dossier_operation_log_move_to_cold_storage_job
...
ETQ tech, je souhaite que les jobs asynchrone pour deplacer les objets dans le stockage à froid se fassent en pleinne nuit
2024-10-10 09:33:43 +00:00
Colin Darie
c48ad8c003
fix(job): missed changed queues
2024-10-10 11:24:01 +02:00
mfo
d729c2f193
tech(perf): reschedule this job at 4am when our workers does not do anything
2024-10-10 11:21:05 +02:00
mfo
fc37bbaa4a
Merge pull request #10906 from mfo/US/reword-queueing
...
amelioration : ETQ operateur j'aimerais simplifier/optimiser la gestion des tâches asynchrones
2024-10-10 07:47:59 +00:00
mfo
b8b727f06b
feat(default.queues): mailers that are not critical are low, otherwise critical. analysis is default, purge is low
2024-10-10 09:31:20 +02:00
Colin Darie
9ef445a4a1
Merge pull request #10905 from tchak/fix-api-entreprise-sentry-error
...
ETQ Usager, je veux pouvoir déposer mon dossier même si le service des SIRET n'est pas disponible
2024-10-09 14:13:47 +00:00
LeSim
163fa42007
Merge pull request #10869 from demarches-simplifiees/add_id_to_column_second_part
...
Tech: utilise les objets `SortedColumn`
2024-10-09 13:05:50 +00:00
Colin Darie
fbb9405e50
Merge pull request #10863 from colinux/maintenance-tasks-template
...
ETQ dev, je peux programmer des maintenance tasks à jouer lors de leur déploiement
2024-10-09 12:16:56 +00:00
mfo
c449892bbe
Merge pull request #10888 from demarches-simplifiees/US/exports-on-sidekiq
...
ETQ tech, on souhaite tout passer sur sidekiq
2024-10-09 12:15:38 +00:00
Colin Darie
da1bf573e3
chore(task): noop maintenance task verifying automatic run on deploy
2024-10-09 13:44:18 +02:00
Colin Darie
9eb9e80232
chore(doc): more information about many maintenance tasks
2024-10-09 13:44:17 +02:00
Colin Darie
cae5d8afed
feat(task): task enqueueing a maintenance task runnable on deploy
2024-10-09 13:44:17 +02:00
Colin Darie
d0f77d0aab
feat(task): with_statement_timeout helper for long running collection or process query
2024-10-09 13:44:17 +02:00
Paul Chavard
668aba8986
fix(api-entreprise): do not raise an error when the service is unavailable
2024-10-09 12:47:26 +02:00
Paul Chavard
e56bc9d35b
chore(prefill): remove unused prefill support on complex champs
2024-10-09 12:11:42 +02:00
simon lehericey
34b0379203
procedure.find_column raise NotFound to fit AR interface
2024-10-09 09:23:06 +02:00
simon lehericey
14809b35af
add comments
2024-10-09 09:21:44 +02:00
simon lehericey
450420aa81
cache columns per request using Current
2024-10-08 22:51:26 +02:00
simon lehericey
249ddf291f
update_displayed_fields can use sorted_column
2024-10-08 22:51:26 +02:00
simon lehericey
4f0cac251d
use sorted_column to sort dossier
2024-10-08 22:51:26 +02:00
simon lehericey
ba91f2f66e
remove now useless validation
2024-10-08 22:51:25 +02:00
simon lehericey
da98aa556b
use update(sorted_column:) and remove obsolete update_sort(column_id:, order:)
2024-10-08 22:51:25 +02:00
simon lehericey
76fee12653
remove now unused procedure_presentation.opposite_order_for
2024-10-08 22:51:25 +02:00
simon lehericey
7349dd183a
notified_toggle_component use sorted_column
2024-10-08 22:51:24 +02:00
simon lehericey
22cbf725ec
column_table_header compute update_sort_path
2024-10-08 22:51:24 +02:00
simon lehericey
b582a2afc6
column_table_header_component use sorted_column
2024-10-08 22:51:18 +02:00
simon lehericey
21533f91e3
add storted_column_type
2024-10-08 22:47:37 +02:00
simon lehericey
9652cf78c3
add default_sorted_column
2024-10-08 22:47:37 +02:00
simon lehericey
305b31e53b
add sorted_column
2024-10-08 22:47:37 +02:00
simon lehericey
693629afc8
add column type
2024-10-08 22:47:36 +02:00
Paul Chavard
d51d3fd8ad
Merge pull request #10881 from tchak/fix-graphql-api-entreprise-adresse
...
graphql(personne_morale): return full address
2024-10-08 15:36:51 +00:00
mfo
02590b3a73
Revert "clean(delayed_jobs): remove dependencies and all occurences"
...
This reverts commit 90ca937b7131575816d72e35e2c48f9d82e9a5e6.
ReRevert me in order to remove all delayed job occurences. But we keep
this dependencie for our instances at least for a year
2024-10-08 16:44:09 +02:00
