1878 commits

Author	SHA1	Message	Date
Martin	eae05b0a6f	feat(export.xslx): add code commune to geo_area.label	2022-09-17 08:59:06 +02:00
simon lehericey	c43bf2e5c9	fix(conditional): only parse user input as int if compared with a number	2022-09-09 11:28:32 +02:00
simon lehericey	ac0ac171ad	perf(dossier): remove unused row validation ... Gain, one request per champ not child	2022-09-07 15:00:40 +02:00
Colin Darie	91c735a219	chore(service): SIRET is required	2022-09-06 09:23:52 +02:00
Colin Darie	9d59a50cd4	chore(manager/services): show etablissement adresse & geopoint	2022-09-06 09:23:52 +02:00
Colin Darie	67cbc61e1e	chore(services): update etablissement adresse & geocode when siret changes	2022-09-06 09:23:52 +02:00
Colin Darie	64ce2719ed	feat(services): accept an optional SIRET ... Closes #7359	2022-09-06 09:23:52 +02:00
Colin Darie	54e7a713b4	refactor(spec): service_specs with be_valid syntax	2022-09-06 09:23:52 +02:00
Colin Darie	4e3b063b87	feat(carte/export): list geo labels	2022-09-05 11:02:51 +02:00
Martin	5f2b290407	feat(Procedure.clone): reset subject.duree_conservation_dossiers_dans_ds when procedure.duree_conservation_etendue_par_ds was extended. only extends it on demand otherwise admin could clone old procedure with higher duree_conservation_dossiers_dans_ds	2022-08-31 14:56:00 +02:00
Martin	6e31decc2d	feat(Procedure.clone): stop cloning procedure service which is confusing for some administrateurs	2022-08-31 14:56:00 +02:00
Colin Darie	4ece7c2494	fix(champ): remove null byte before save ... Les null bytes peuvent être injectés lors de c/c depuis certains documents, et ne sont pas sauvegardables en base, rendant la sauvegarde d'un dossier impossible. Closes #7656 https://sentry.io/organizations/demarches-simplifiees/issues/3194932607/activity/?project=1429550&query=is%3Aunresolved	2022-08-31 11:39:34 +02:00
Martin	dc524cf615	fix(spec): broken spec due to TDD and refacto on former code	2022-08-23 13:28:10 +02:00
simon lehericey	650c36e3e2	feat(conditional): add not eq operator	2022-08-10 11:59:09 +02:00
Paul Chavard	a24885c2ee	feat(champ): can condition on other option	2022-08-04 15:28:54 +02:00
Paul Chavard	bbca7344e5	fix(conditional): mandatory champs inside hidden repetition should not be validated	2022-08-04 14:48:40 +02:00
Paul Chavard	2d7803cd48	refactor(spec): use new procedure.types_de_champ factory	2022-08-04 12:10:32 +02:00
Colin Darie	8dc966feb4	fix(dossier_transfer): requires an actual email ... Closes #7621	2022-08-03 11:44:54 +02:00
Paul Chavard	a88390c6d3	refactor(types_de_champ): use new types_de_champ factory	2022-08-02 16:21:33 +02:00
Paul Chavard	21d47fa875	test(factory): spec new procedure.types_de_champ factory	2022-08-02 16:21:33 +02:00
Colin Darie	197fa54ea4	fix(archives): purge stuck pending archives ... Cf 0cb096b3d6440a4da05ca2902ed6fa72a93e6579	2022-07-27 15:26:59 +02:00
Colin Darie	f1957e51f8	fix(exports): purge stuck (pending) exports, not generated or failed ... Avec l'autre PR, ça reproduit le comportement d'avant, c'est à dire que quoiqu'il arrive un export est purgé : - soit 16h après sa génération (on a 16h pour le télécharger) - soit 12h après sa création, et qu'il est bloqué Auparavant, tous les exports étaient purgés au bout de 3h quelle que soit le statut.	2022-07-27 15:26:59 +02:00
Colin Darie	6845b2ed08	fix(export): fix PurgeStaledExportsJob regression with stale scope ... cc #7547	2022-07-26 14:26:22 +02:00
Martin	3e56fdd1d7	fix(export): when it takes more than 3 hours, exports are purge before being generated. make it possible to have an export that takes more than 3 hours and share this behaviour with kind of same class archive	2022-07-25 10:48:54 +02:00
simon lehericey	0d3856e84a	fix(conditional): handle incorrect user input	2022-07-22 15:55:43 +02:00
simon lehericey	72583f846b	champ value return nil if champ is hidden	2022-07-20 11:23:57 +02:00
simon lehericey	2d26ba3507	fix: binary operator computes false by default	2022-07-19 10:11:24 +02:00
Martin	24c8dc5829	feat(procedure.duree_conservation_dossiers_dans_ds): decrease max duree_conservation_dossiers_dans_ds from 36 to 12	2022-07-18 14:08:53 +02:00
Paul Chavard	0adfd92213	refactor(condition): use standard revision change ops	2022-07-13 15:32:25 +02:00
simon lehericey	2cad0e11d3	display condition change between version	2022-07-13 15:10:23 +02:00
Paul Chavard	0f9d8b6a39	feat(dossier): exclude conditionally invisible fields from mandatory check	2022-07-12 17:33:42 +02:00
Colin Darie	d805114a72	Revert "feat(revision): list updated placeholder option for generic type de champ" ... This reverts commit fe0282e904. Continue 2bd33ada45b036f73f3fc78150621092e0667693	2022-07-12 11:37:58 +02:00
simon lehericey	4a198a4c09	spec	2022-07-12 10:16:22 +02:00
Colin Darie	fe0282e904	feat(revision): list updated placeholder option for generic type de champ	2022-07-11 17:16:20 +02:00
Paul Chavard	4d48055158	feat(tags): expose used_type_de_champ_tags	2022-07-07 23:23:17 +02:00
Paul Chavard	fb37f8c5a8	fix(dossier): fix some reset draft changes edge cases	2022-07-06 16:52:12 +02:00
simon lehericey	42488419b5	add condition form model	2022-07-06 16:35:23 +02:00
Paul Chavard	9b45dcea3f	feat(demarche): add possibility to reset draft revision	2022-07-06 14:18:01 +02:00
Paul Chavard	adfc4f8cdd	test(dossier): improuve destroy spec	2022-07-06 11:12:14 +02:00
simon lehericey	b715d1f495	Revert "Add id to term" ... This reverts commit 87385d03fd.	2022-07-06 09:44:54 +02:00
simon lehericey	87385d03fd	Add id to term	2022-07-05 14:47:49 +02:00
simon lehericey	d8454d9d47	remove text from managed_type_de_champ	2022-07-05 12:07:06 +02:00
simon lehericey	c631c5cd82	Logic add_empty_condition_to	2022-07-05 12:07:06 +02:00
simon lehericey	df7acf70c8	and empty_operator compute always true	2022-07-05 12:07:06 +02:00
simon lehericey	04965ac35a	improve constant and empty to_s	2022-07-05 12:07:06 +02:00
simon lehericey	5ebaf59fdb	parent_id -> parent_stable_id	2022-07-05 11:53:18 +02:00
Paul Chavard	9a6a8411d3	feat(export): add déparctement info to commune champ export	2022-07-04 16:30:16 +02:00
simon lehericey	f8c7003192	fix drop down other	2022-07-01 16:05:31 +02:00
Martin	4ec61e58ac	feat(EditComponent): add max_file_size and content_types to upload buttons inspired by dsfr	2022-06-28 17:44:35 +02:00
Christophe Robillard	6dd27ec7ed	reset opendata to true when procedure is cloned by another admin	2022-06-23 14:11:09 +02:00
Christophe Robillard	ea59f5f260	add opendata boolean attribute for procedure ... when opendata is set to true, it means that descriptive's procedure can be public when opendata is set to false, ti means that descriptive's can not be public, because the procedure is only available for public servants, not citizens.	2022-06-23 14:11:09 +02:00
Martin	d57530e0f9	fix(spec): including Logic module broke spreadsheet architect	2022-06-20 15:12:43 +02:00
Martin	274b5eab2e	feat(invite): wrap invitation with targeted_user_links	2022-06-17 16:44:37 +02:00
simon lehericey	0db27b8718	validate conditions on revision	2022-06-17 14:54:21 +02:00
simon lehericey	758933f6f9	tdc can have condition	2022-06-17 14:53:28 +02:00
simon lehericey	9f49e8c2ea	add ensure_compatibility_from_left	2022-06-17 14:53:27 +02:00
simon lehericey	5ac3049033	add champ_value for dropdown	2022-06-17 14:53:27 +02:00
simon lehericey	809d991819	add champ_value	2022-06-17 14:53:27 +02:00
simon lehericey	daaa54b6f0	add n_ary operators	2022-06-17 14:53:27 +02:00
simon lehericey	698eff0a50	add equal operator	2022-06-17 14:53:27 +02:00
simon lehericey	ebe95b83fa	add compatibility checks	2022-06-17 14:53:27 +02:00
simon lehericey	a98a6d6d1e	add binary operators	2022-06-17 14:53:27 +02:00
simon lehericey	6ebfc505c4	add empty	2022-06-17 14:53:27 +02:00
simon lehericey	58da4805fa	add constant	2022-06-17 14:53:27 +02:00
Paul Chavard	65bd996f2a	refactor(types_de_champ_editor): remove old react editor	2022-06-17 11:04:09 +02:00
Martin	56f7133799	fix(procedure_presentation): can not present a 'virtual field' like depose_since ... fix(data): add migration to remove fields depose_since from existing procedure presentation	2022-06-14 09:02:37 +02:00
Paul Chavard	95a1ea1047	feat(procedure_presentation): add since date filters	2022-06-09 13:01:22 +01:00
Martin	d39b3b09ed	fix(webhook.perform): ensure to enqueue job with current state/updated_at for consistency reason	2022-06-01 15:54:55 +02:00
Martin	cb890343ff	feat(targeted_user_link): add targeted user link to wrap expert invitation in order to avoid access issue when the expert is connected with another account ... feat(user.merge): ensure to merge user.targeted_user_link Update app/models/targeted_user_link.rb Co-authored-by: LeSim <mail@simon.lehericey.net> Update app/models/targeted_user_link.rb Co-authored-by: LeSim <mail@simon.lehericey.net> Update app/models/targeted_user_link.rb Co-authored-by: LeSim <mail@simon.lehericey.net> feat(db/create_targeted_user_links): ensure not null with fk	2022-05-31 14:50:31 +02:00
Paul Chavard	c0a253078c	fix(revision): fix clone démarches with repetitions	2022-05-31 13:28:56 +02:00
Paul Chavard	02675a104d	fix(revision): fix tests to use new revison system	2022-05-31 08:58:53 +02:00
Paul Chavard	a36672239d	refactor(revision): rename find_or_clone_type_de_champ	2022-05-31 08:58:53 +02:00
Christophe Robillard	fd98247b48	[manager] add list of dubious procedures	2022-05-25 14:44:53 +02:00
Pierre de La Morinerie	8936461d5b	app: cache the duration estimate for published procedures	2022-05-25 10:39:18 +02:00
Pierre de La Morinerie	3e91a16895	app: display estimated fill duration on procedure description	2022-05-25 10:39:15 +02:00
simon lehericey	8ce080bd3e	updated_at pb	2022-05-24 15:38:50 +02:00
simon lehericey	db5d291acd	complete spec and alternative implem	2022-05-24 15:38:50 +02:00
simon lehericey	4c19a127d6	add rebase specs	2022-05-24 15:38:50 +02:00
simon lehericey	b3ce124aa8	move rebase spec to its own file	2022-05-24 15:38:50 +02:00
Paul Chavard	0817731d6a	refactor(dossier): rebase to use new revisions	2022-05-24 15:38:50 +02:00
Martin	51f0be1034	clean(deadcode): remove dead methods	2022-05-24 14:23:40 +02:00
Martin	d0599dd36b	bug(root): test root	2022-05-24 14:23:40 +02:00
Paul Chavard	b635952b2f	refactor(revision): types_de_champ for export	2022-05-23 18:36:18 +02:00
simon lehericey	c5a0fd4349	use children_of on validation repetition is not empty	2022-05-20 09:24:05 +02:00
Paul Chavard	24d47eb6d3	bug(revision): revising child type de champ create duplicate coordinate	2022-05-18 19:32:56 +02:00
simon lehericey	fd4d543b20	fix test	2022-05-18 15:18:17 +02:00
simon lehericey	633f0d1ce5	remove_repetition	2022-05-18 12:12:25 +02:00
simon lehericey	4d97f6aa8c	types_de_champ_for_revision	2022-05-18 11:40:34 +02:00
Paul Chavard	cdd597db19	refactor(dossier): fix champ repetition factories	2022-05-18 11:24:14 +02:00
simon lehericey	5767c9b97e	fix test	2022-05-18 10:11:31 +02:00
Paul Chavard	b6ea44f7e7	refactor(revision): remove type_de_champ#revision_id	2022-05-17 11:31:49 +02:00
simon lehericey	10fff77d69	spec: split cases	2022-05-16 16:51:49 +02:00
simon lehericey	a26a662df4	spec: move one level up	2022-05-16 16:51:49 +02:00
Paul Chavard	d7678c4389	Revert "Merge pull request #7295 from tchak/rollback-attempt" ... This reverts commit 24b37c230d, reversing changes made to 08b90b9173.	2022-05-13 17:17:23 +02:00
Paul Chavard	4c26e34c79	Revert "Merge pull request #7270 from betagouv/remove_type_de_champ_v2" ... This reverts commit 41b6f8f51b, reversing changes made to 79d5946ab6.	2022-05-11 20:03:42 +02:00
Paul Chavard	08caa122dd	Revert "Merge pull request #7280 from betagouv/move_type_de_champ_v2" ... This reverts commit 08b90b9173, reversing changes made to bc9a90bd08.	2022-05-11 20:03:33 +02:00
simon lehericey	df91fd1180	move_type_de_champ new style	2022-05-11 16:54:26 +02:00
simon lehericey	795513e093	spec: clean	2022-05-11 16:54:26 +02:00
simon lehericey	58c3b6b16a	fix spec : datetime is present in more recent revision	2022-05-11 15:59:17 +02:00
simon lehericey	b6c2aa30f4	reorder the siblings after deletion	2022-05-11 15:59:17 +02:00
simon lehericey	6bf52b1f99	remove children shared between 2 revisions	2022-05-11 15:59:16 +02:00
simon lehericey	285f402483	spec: add test case	2022-05-11 15:59:16 +02:00
simon lehericey	b889d18217	spec: use children_of	2022-05-11 15:59:16 +02:00
Martin	bf277d4802	bug(export): expect dossiers_for_export not to include dossiers brouillon ... fix(export.dossiers_for_export): add missing visible_by_administration	2022-05-10 16:09:12 +02:00
simon lehericey	d2509e7492	add procedure_revision children_of	2022-05-10 14:52:57 +02:00
simon lehericey	cb4c35e797	spec: add special case for repetition_type_de_champ	2022-05-06 12:37:59 +02:00
simon lehericey	45f5cd3f4a	spec: split procedure creation	2022-05-06 12:37:59 +02:00
simon lehericey	02fc25af23	spec: more procedure creation split	2022-05-06 11:23:10 +02:00
simon lehericey	6d38a44f1f	spec: be clear we talk about draft	2022-05-06 11:23:10 +02:00
simon lehericey	c1d0256687	spec: split procedure creation	2022-05-06 11:23:10 +02:00
simon lehericey	becdd4a0ed	spec: refactor	2022-05-06 11:23:10 +02:00
simon lehericey	d33e7c8cab	spec: another isolated type_de_champ_repetition	2022-05-06 10:34:40 +02:00
Martin	8a6c3bbec0	fixup! bug(type_de_champ.repetition): on repetition, when there is a TypeDeChamp::Commune, champs for export should contain 2 entries [one with commune (postal_code), the other for commune (code_insee)].	2022-05-06 09:38:45 +02:00
Martin	b1340586de	bug(type_de_champ.repetition): on repetition, when there is a TypeDeChamp::Commune, champs for export should contain 2 entries [one with commune (postal_code), the other for commune (code_insee)].	2022-05-06 09:38:45 +02:00
Paul Chavard	4523c0590c	fix(dossier): champs repetable in champs private	2022-05-04 15:57:25 +02:00
simon lehericey	35ae011b59	remove duplicate test case (see tdc_0)	2022-05-04 13:16:12 +02:00
simon lehericey	96eec7e566	refactor spec	2022-05-04 13:16:12 +02:00
simon lehericey	37e01ea399	re introduce revision_types_de_champ	2022-05-04 13:16:12 +02:00
simon lehericey	a2947751e2	add scope to query old admins	2022-05-03 12:14:02 +02:00
simon lehericey	ea361643be	types_de_champ -> types_de_champs_public	2022-05-03 11:05:24 +02:00
Martin	be090a1bec	feat(administrateur/procedure#create): allow admin to add a lien to the DPO, allow user to consult link to dpo. enhance spec on _procedure_footer.html ... Update spec/views/users/_procedure_footer.html.haml_spec.rb Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com>	2022-04-27 15:09:02 +02:00
Paul Chavard	23b60c87e9	fix(procedure): cloned procedure should not have auto_archive_on ... fix #7149	2022-04-22 10:48:31 +02:00
simon lehericey	9fd5219751	fix sort in procedure presentation	2022-04-15 12:21:39 +02:00
simon lehericey	23707d6033	ignore file not found error when cloning procedure	2022-04-14 13:46:16 +02:00
Paul Chavard	83a8d87e95	i18n(procedure_presentation): translate fields	2022-04-14 11:38:01 +02:00
Paul Chavard	d14e132305	feat(export): add zip format support	2022-04-12 14:54:54 +02:00
Paul Chavard	90dd5bc9c5	fix(dossiers): dossier extend_conservation actually works	2022-04-08 13:40:28 +02:00
Paul Chavard	e82dc9c8b5	feat(exports): add ability to create exports with filters	2022-04-06 17:08:38 +02:00
simon lehericey	200e8680d5	add uniq index on attestation dossier_id	2022-04-05 15:43:21 +02:00
Martin	9484c4cdf4	fix(Dossier.processed_in_month): using PG between operator with a date does not play nicely when it is compared to DateTime in postgres. meaning given a Date as 2022/03/31, when compared with a DateTime in postgres, the casting of 2022/03/31 to Datetime becomes 2022/03/31 00:00. So we skiped all dossiers from last date in month	2022-04-05 13:54:36 +02:00
Martin	c1884f231c	Revert "Merge pull request #7105 from betagouv/US/fix-dossier.processed_in_month" ... This reverts commit a0e144b9a7, reversing changes made to 49848bd150.	2022-04-05 13:39:37 +02:00
Martin	c07e0fc13e	fix(Dossier.processed_in_month): ensure proper usage via method sig instead of defensive programming style	2022-04-05 12:14:07 +02:00
Martin	ab777a790c	fix(Dossier.processed_in_month): using PG between operator with a date does not play nicely when it is compared to DateTime in postgres. meaning given a Date as 2022/03/31, when compared with a DateTime in postgres, the casting of 2022/03/31 to Datetime becomes 2022/03/31 00:00. So we skiped all dossiers from last date in month	2022-04-05 12:14:07 +02:00
Paul Chavard	6da54936b7	refactor(procedure_presentation): use internal reference to instructeur	2022-04-05 09:42:23 +02:00
Paul Chavard	706c648be8	refactor(procedure): remove unused code	2022-04-05 09:42:23 +02:00
simon lehericey	57f9e5bac3	always allow dossier pjs download (-9 queries)	2022-04-04 17:26:49 +02:00
Kara Diaby	b2bcc34cfd	tests	2022-03-31 15:48:18 +02:00
Pierre de La Morinerie	31bd05f835	models: inverse the direction of the User role associations	2022-03-22 07:58:44 +01:00
Pierre de La Morinerie	56edba37bc	specs: make the ProcedurePresentation#sorted_ids test more robust ... Before the Dossiers were already created in the correct order, so the sorting wasn't really tested.	2022-03-22 07:58:44 +01:00
Paul Chavard	c60a8970f1	perf(dossier): memoize champ.sections on dossier	2022-03-11 00:15:53 +01:00
Paul Chavard	51d7fd6190	test(dossier): update spec to use visible_by_administration	2022-03-10 14:29:40 +01:00
Pierre de La Morinerie	087e438eb6	models: delete AdministrateursInstructeur when destroying Instructeur ... By default, `has_and_belongs_to_many` properly deletes the record in the join table. However, as the association is declared manually with a `has_many / through`, it doesn't delete the joined record automatically. As we also lack a foreign-key contraint on the join table, that means a dangling record remains in the join table. To fix this, let's declare it a proper `has_and_belongs_to_many` association, which will let the join record be deleted automatically on destroy.	2022-03-02 11:26:53 +01:00
Pierre de La Morinerie	e32c9a9f94	models: don't attempt to format invalid phone numbers ... This is a defensive-programming measure, because formatting an invalid phone number may truncate some leading numbers.	2022-03-02 09:57:03 +00:00
Pierre de La Morinerie	f35d18cd5c	models: stop truncating DROM phone numbers ... Fix #6996	2022-03-02 09:57:03 +00:00
Pierre de La Morinerie	5150e33212	models: ensure DROM phone numbers are valid ... They were accepted before, because they were 'possible' – but now they are explicitely considered as valid.	2022-03-02 09:57:03 +00:00
Pierre de La Morinerie	71e1b6c973	models: delete AdministrateursProcedure when destroying Administrateur ... By default, `has_and_belongs_to_many` properly deletes the record in the join table. However, as the association is declared manually with a `has_many / through`, it doesn't delete the joined record automatically. As we also lack a foreign-key contraint on the join table, that means a dangling record remains in the join table. To fix this, let's declare it a proper `has_and_belongs_to_many` association, which will let the join record be deleted automatically on destroy.	2022-03-01 16:58:04 +01:00
Paul Chavard	2d396fcfb7	feat(dossier): rebase dossiers en construction and en instruction	2022-02-18 17:08:38 +01:00
Paul Chavard	50f095a5c6	test(user): fix unstable spec	2022-02-17 14:45:53 +01:00
Paul Chavard	76b1b85fa7	fix(attestation_template): add revision diff support	2022-02-11 08:45:32 +01:00
Paul Chavard	e269077c40	refactor(attestation_template): cleanup relationships	2022-02-11 08:45:32 +01:00
Paul Chavard	88e80e9e32	Merge pull request #6901 from adullact/feature/6859-jwt-token-expiration ... [API Entreprise] Ajout du support des jetons JWT sans clé d'expiration	2022-02-10 11:48:39 +01:00
Kara Diaby	24ff41d2c0	tests	2022-02-09 14:43:36 +01:00
Paul Chavard	12151acb99	Revert "Revert "feat(attestation): revise attestations"" ... This reverts commit 4e7733e571.	2022-02-08 16:22:59 +01:00
François Vantomme	eba9a87123	refactor(API Entreprise): raise an error on blank token	2022-02-07 15:18:16 +01:00
Pierre de La Morinerie	e6cf07b810	stats: move date formatting out of the Stat model ... Before this commit, the monthly dossiers count was serialized into the Stat record using human-formatted dates, as: ```ruby s.dossiers_in_the_last_4_months = { "octobre 2021"=>409592, "novembre 2021"=>497823, "décembre 2021"=>38170, "janvier 2022"=>0 } ``` Turns out the ordering of keys in a serialized hash is not guaranteed. After a round-trip to the database, the keys will be wrongly sorted. Instead we want to save raw Date objects, which will preserve the ordering. The date formatting can be applied at display-time by the controller. Fix #6848	2022-02-02 14:13:53 +01:00
Pierre de La Morinerie	ca58e60dc0	validators: rename revisions namespace to types_de_champ	2022-02-01 12:37:16 +01:00
Pierre de La Morinerie	d680602c84	models: validate private types_de_champ	2022-02-01 12:37:16 +01:00
Pierre de La Morinerie	e8e37cce15	models: refactor the types_de_champ validators ... Context: we want to validate public and private types_de_champ separately. Before we validated the whole revision (and then validators themselves enumerated all champs, public and private). Now we validate the actual public types_de_champ, which will let us validate separately the private types_de_champ.	2022-02-01 12:37:16 +01:00
Paul Chavard	4e7733e571	Revert "feat(attestation): revise attestations" ... This reverts commit e413872530.	2022-01-25 18:26:34 +01:00
Kara Diaby	c9f402aa5b	tests	2022-01-25 11:46:05 +01:00
Martin	47fa95a577	feat(MonAvisEmbedValidator): allow mon avis button without title	2022-01-24 15:56:29 +01:00
Paul Chavard	e413872530	feat(attestation): revise attestations	2022-01-19 18:00:37 +01:00
Paul Chavard	c1cb89bb44	fix(revision): changed? conflicts with rails method	2022-01-19 18:00:37 +01:00
Paul Chavard	403e71b41f	feat(procedure): only purge procedures without dossiers	2022-01-18 11:22:04 +01:00
Kara Diaby	bdcb0ca0e9	tests	2022-01-12 15:49:38 +01:00
Paul Chavard	4e779f445d	fix(instructeur): copy notifications settings from previous groupe instructeur ... fix #6763	2021-12-23 13:55:25 +01:00
François Vantomme	14e0c68266	feat(api particulier): add MESRI field	2021-12-16 16:45:18 +01:00
maatinito	0a31c8bc79	refactor date_trunc queries using groupdate gem	2021-12-14 08:50:11 +01:00
Martin	4b2e858a1a	fix(mon_avis_embed_validator): enhance regexp	2021-12-13 14:49:40 +01:00
Paul Chavard	c7b1dc7f87	fix(bulk_messages): destroy bulk messages with procedures	2021-12-09 16:16:40 +01:00
François Vantomme	6ab8ac0662	feat (api particulier): add Pole emploi field	2021-12-08 10:36:25 +01:00
François Vantomme	2110ef072c	feat(api particulier): add DGFiP field	2021-12-07 11:03:05 +01:00
Paul Chavard	5e0f8a5816	task(type_de_champ): migrate type_de_champ parent_id	2021-12-06 21:45:54 +01:00
Paul Chavard	2ba05bfb4f	fix(dossier): use depose_at instead of en_construction_at	2021-12-06 15:49:17 +01:00
Martin	a9413f9b12	feat(manager): add procedure_expires_when_termine_enabled to administrate	2021-12-06 07:49:59 +01:00
Martin	d8a8d1fdab	feat(instructeur/dossier/header/_expiration_banner): split trads and add dedicated expiration banner for instructeur. also enhance wording to include duree conservation + extension_conservation ... feat(expiration_banner): enhance wording of expiration feat(dossiers/expiration_banner): enhance wording regarding expiration to include duree_conservation_dossiers_dans_ds + extension_conservation, also add spec on expiration_banner for instructeur	2021-12-06 07:05:17 +01:00
Martin	1bb868714c	fix(spec/lint/review): lint and fix spec of previous commits, also fix based on tchak feedback	2021-12-06 07:05:17 +01:00
Martin	d87f8b57cc	feat(instructeurs/procedures#show): add dossier experiant in procedure#show	2021-12-06 07:05:17 +01:00
Martin	2dfbc70d41	feat(instructeur#dossiers_count_summary): add counter for expirants. ignore brouillon	2021-12-06 07:05:17 +01:00
Martin	ce87878ff0	refactor(traitement.process_expired): move process expired to procedure	2021-12-03 16:32:36 +01:00
Pierre de La Morinerie	b7d17b0989	models: validate that no drop-downs are empty on publishing ... Disallow publishing a procedure containing drop-downs with no selectable values.	2021-12-02 09:00:37 +01:00
François Vantomme	8fc14faa2a	fix(stat): enforce time travel when dealing with relative dates	2021-12-01 17:09:30 +01:00
Pierre de La Morinerie	99c77046d2	models: improve error message for invalid champs ... Avoid prepending the message with 'Draft revision '	2021-11-30 13:34:41 +01:00
Pierre de La Morinerie	52b0fbf9b7	models: validate repetitions on publishing	2021-11-30 13:34:41 +01:00
simon lehericey	5a0fb6237f	😭 AASM does not support keyword arguments ... https://github.com/aasm/aasm/issues/672	2021-11-30 09:42:45 +01:00
Martin	970e43efb8	feat(stats#index): update Stat model to also query DossierDeleted in stats computation ... tech(question): discard_and_keep_track! ; are we really keeping track with default_scope { kept } ? feat(stats): add DeletedDossier in Stat computations Revert "tech(question): discard_and_keep_track! ; are we really keeping track with default_scope { kept } ?" This reverts commit d1155b7eeaaf1a9f80189e59667e109541fcb089. feat(stats): support deleted_dossiers for last_four_months_hash and cumulative_hash. extract sanitize query & merge hashes in methdos clean(rubocop): lint with rubocop Update db/migrate/20211126080118_add_index_to_deleted_at_to_deleted_dossiers.rb Co-authored-by: LeSim <mail@simon.lehericey.net> fix(rubocop): avoid uneeded allocation fix(migration): add concurrent index with expected synthax fix(brakeman): add ignore message since group date_trunc evaluation is used by only ourself	2021-11-26 13:29:40 +01:00
Paul Chavard	d847775c68	feat(traitements): add depose_at to dossiers	2021-11-25 12:57:55 +03:00
Pierre de La Morinerie	e5f5440663	models: explicitely save procedure's new revision ... Deep-cloned objects have all their relationships stale. Thus, for a newly deep-cloned revision, `revision.types_de_champs` returns `[]`, even when it actually has associated types de champ. This causes consecutive champs creations and re-ordering to fail in subtle ways, like: ``` procedure.draft_revision.add_type_de_champ(…) procedure.publish_revision! procedure.draft_revision.add_type_de_champ(…) procedure.draft_revision.move_type_de_champ(…) # this will fail ``` As `publish_revision!` created a new stale revision, moving the type de champ fails because not all existing champs are found until the object is refreshed. We don't hit this path in production, because usually only a single operation is made in a request. To fix this, save the new revision before associating it as the draft procedure. (Another option would be to `reload` the revision after creation, but this seems better contained and matches the name of the method.)	2021-11-25 08:49:17 +01:00
mfo	e7d9d047fe	Merge branch 'main' into 6649-etq-usager-instructeur-rendre-la-suppression-plus-visible	2021-11-24 14:07:32 +01:00
Pierre de La Morinerie	970c3e4b2b	specs: avoid executing business logic in Procedure factory ... Calling business logic in a factory is a code-smell, because it usually requires the object to be saved into database, and may have unintended consequences when the business logic is changed. Also, this allows to just build a published procedure, without saving it to the database.	2021-11-23 08:07:07 +01:00
Pierre de La Morinerie	774ef00f8e	specs: improve dossier_spec#build_default_individual	2021-11-23 08:07:07 +01:00
Pierre de La Morinerie	8d89ae366b	specs: minor cleanups	2021-11-23 08:07:07 +01:00
Martin	608a85148f	feat(Dossier.close_to_expiration): add method to find any kind of dossier close to expiration [reuse previous scopes], add missing spec to termine_close_to_expiration, complement spec for each kind of expiration scope with general close_to_expiration spec	2021-11-19 14:28:54 +01:00
mfo	1d174df2ec	Merge branch 'main' into 6624/etq-instructeur-je-souhaite-supprimer-des-messages-envoyes-par-erreur	2021-11-16 16:37:15 +01:00
Martin	8bbd77f89f	refactor(mail.delay): use simplier implementation using after_action to prevent email delivery with delay	2021-11-16 15:12:05 +01:00
simon lehericey	e3c1e19424	include hidden dossier in merge	2021-11-15 23:14:41 +01:00
Martin	c68fa2d7f3	feat(Commentaire.notify_user): wait 5 minutes before sending email to user when instructor write a commentaire. leaving some space for instructor to destroy his message	2021-11-15 15:38:57 +01:00
Martin	5b72bdec7e	fix(Commentaire.sent_by?): &.email compared to nil could sent by true when nil==nil, avoid this one	2021-11-15 12:01:56 +01:00
Paul Chavard	da47f491b3	fix(dossier): nullify close to expiration notice timestamps when changing state	2021-11-11 12:52:58 +01:00
Paul Chavard	122cdacbc2	fix(avis): destroy avis for discarded en_construction dossiers	2021-11-04 10:12:44 +01:00
Paul Chavard	f6b8689a97	fix(revisions): fix repetitions export with revisions	2021-11-03 18:20:48 +01:00
Paul Chavard	da49a6447f	refactor(repetition): optimize and add a transaction around repetition add row	2021-10-28 14:54:33 +02:00
Paul Chavard	c4b93f8d4a	fix(groupe_instructeur): unfollow dossiers when removed from groupe instructeur	2021-10-28 14:45:52 +02:00
simon lehericey	7935e42109	Add merge log	2021-10-28 14:39:13 +02:00
simon lehericey	3328c9a132	merge move invite as well	2021-10-28 14:39:13 +02:00
simon lehericey	f2ccb39912	merge destroys the old role and account	2021-10-28 14:39:13 +02:00
simon lehericey	c725999582	move merge method to user	2021-10-28 14:39:13 +02:00
Paul Chavard	1393b7b07b	fix(rebase): fix repetition champ rebase	2021-10-28 13:27:53 +02:00
Pierre de La Morinerie	a2b91c8ec6	factories: cleanup Administrateur, Instructeur and Expert factories ... This changes: - avoids relying on application code to create mock objects, - allows to build Administrateur or Instructeurs without saving them.	2021-10-26 12:03:30 +02:00
Pierre de La Morinerie	0ff95df221	specs: improve speed of phone_champ_spec ... Re-use the same champ for each test. This is safe, and makes the test go from 4s to 1s.	2021-10-26 12:03:30 +02:00
Pierre de La Morinerie	fccf75710a	specs: avoid creating uneeded champs on geo_area ... It makes the test much faster.	2021-10-26 12:03:30 +02:00
Paul Chavard	1561ea82f6	fix(transfer): manually nullify staled transfers references	2021-10-21 13:54:26 +02:00
Paul Chavard	2a3a9dd822	feat(revisions): rebase dossiers brouillons	2021-10-20 17:26:09 +02:00
Paul Chavard	67e98f79c9	feat(revisions): add stable_id to changes	2021-10-20 17:25:34 +02:00
simon lehericey	866df74706	merge admin	2021-10-19 16:12:42 +02:00
simon lehericey	f6879eba60	associate_user take a target email	2021-10-14 14:47:50 +02:00
simon lehericey	09f828a6a2	create_merge_token!	2021-10-14 14:47:50 +02:00
simon lehericey	34862f41e0	Add fci valid_for_merge	2021-10-14 14:47:50 +02:00
simon lehericey	6826bf03b0	Sign in with a user linked by france connect sub (openid) ... instead of looking linked user by email because : - follows FC recommendation to fetch ds account by openid - the email is not a valid key as many user can share the same FCI email. The following scenario is now working A user A (email: 1@mail.com) uses FC to connect to DS => It is connected as 1@mail.com Another user B (email: generic@mail.com) uses FC to connect => It is connected as generic@mail.com The first user A change its FC email to generic@mail.com and connect to DS => It is still connected as 1@mail.com	2021-10-14 14:47:50 +02:00
simon lehericey	87de9e38c6	allow draft to be saved with invalid cnaf champ	2021-10-12 14:27:20 +02:00
simon lehericey	40d0cfcdc4	add champ validation	2021-10-12 14:27:20 +02:00
simon lehericey	c76d1043fa	add cnaf champ	2021-10-12 14:27:20 +02:00
simon lehericey	7c65571fca	add case when the old_expert or old_instructeur is nil	2021-10-12 11:04:06 +02:00
simon lehericey	ec8ccad465	typo	2021-10-12 11:03:34 +02:00
simon lehericey	d7e621d167	beef up the merge methods	2021-10-07 15:51:31 +02:00
Paul Chavard	9d5c5447c2	fix(dossier): do not attempt to destroy transfers when a dossier is destroyed ... we had a dependent option on both sides of a relationship which created race conditions	2021-10-06 17:51:09 +02:00
simon lehericey	1000417bc9	update notifications_for_dossier used in dossier show	2021-10-05 12:05:43 +02:00
simon lehericey	65911b7680	update with_notifications dossiers scope (used in procedure index and show)	2021-10-05 12:05:43 +02:00
Ismael MOUSSA S	bdbb4deb87	ADD FILE_MAX_SIZE constant to set allow file size limit	2021-09-21 12:04:56 -05:00
simon lehericey	6c6205e188	a cloned procedure to a different admin does not keep api_particulier token and scopes	2021-09-16 09:30:11 +02:00
Pierre de La Morinerie	586f8ec543	models: improve password complexity specs	2021-09-09 09:40:39 -05:00
Paul Chavard	d6cbdf2a48	feat(dossier): add dossier transfer models	2021-09-08 14:39:46 +02:00
Paul Chavard	74e277d0a2	feat(graphql): add an option to dossier state change mutations to disable notifications	2021-09-07 14:21:48 +02:00
simon lehericey	367f508e2e	linked_drop_down_list: empty primary => empty secondary	2021-09-07 10:09:18 +02:00
Paul Chavard	8e1bfb469f	fix(dossier): send expiration notifications 2 weeks prior to supression instead of a month	2021-08-26 11:28:57 +02:00
Christophe Robillard	8f2e0660d3	add spec for dossier with commune	2021-08-19 08:04:47 +02:00
Christophe Robillard	e06f11f33f	add code insee libelle for commune export	2021-08-19 08:04:47 +02:00
Christophe Robillard	4a6c22d6a6	export code insee for commune champ	2021-08-19 08:04:47 +02:00
simon lehericey	b29bae4707	a procedure has an encrypted api_particulier_token ... Co-authored-by: François VANTOMME <akarzim@gmail.com>	2021-07-30 11:18:44 +02:00
kara Diaby	9c976c6b71	fixup! tests	2021-07-27 19:38:21 +02:00
Paul Chavard	64cfb4d64e	Fix sort with revisions	2021-07-23 10:57:04 +02:00
Paul Chavard	388fb39eb5	Fix false positive blank champ warnings	2021-07-22 10:45:25 +02:00
Paul Chavard	ac0f50b488	Improuve champ blank check	2021-07-22 10:45:25 +02:00
Pierre de La Morinerie	32ab2f0a80	instructeur: limit the maximum size of a filter value ... This prevents the URL from exceeding the max size, and causing '414: Request-URI too large' errors.	2021-07-20 14:49:48 +02:00
Pierre de La Morinerie	40b3ea8ad6	Revert "Instructeurs : limitation de la valeur d'un filtre à 100 caractères"	2021-07-13 18:19:46 +02:00
Pierre de La Morinerie	3c8a88a660	instructeur: limit the maximum size of a filter value ... This prevents the URL from exceeding the max size, and causing '414: Request-URI too large' errors.	2021-07-08 16:17:22 +02:00
Christophe Robillard	bc07a875eb	integrate a mininum weight for the average dossier weight ... before this commit, the average dossier weight took account only pieces justificatives. With this commit, we add a minimum weight for other files included in an archive like pdf_export, log operations, attachments added to traitements. This minimum weight is set arbitrary, from the observation of some random procedures in production	2021-07-06 15:58:45 +02:00
Paul Chavard	0ca5e1abe2	Preview should reflect revision changes	2021-06-24 11:39:49 +02:00
Paul Chavard	8b2c2c6466	Handle carte layers changes	2021-06-24 11:39:49 +02:00
Paul Chavard	35eccb5630	Show separate blocks for types de champ and annotation changes	2021-06-23 09:40:07 +02:00
Paul Chavard	19195008e8	Expose removed types_de_champ in exports	2021-06-23 09:40:07 +02:00
simon lehericey	eadae7af6b	show all available tdc for procedure presentation	2021-06-23 09:40:07 +02:00
Paul Chavard	8d49b5556a	test revision changes	2021-06-23 09:40:07 +02:00
Paul Chavard	f238710044	Add last_month export	2021-06-23 09:23:10 +02:00
Christophe Robillard	7851d6b1cc	archives: count archived dossiers	2021-06-18 08:59:13 +02:00
Pierre de La Morinerie	12d17bc245	spec: fix Timecop.freeze without Timecop.return ... Time was frozen without being un-frozen at the end of the spec. This caused a spec in `Procedure#publish_or_reopen!` to fail randomly. Fixed by using the `Timecop.freeze do` form, which unfreezes after the execution of the block.	2021-06-17 17:36:43 +02:00
Christophe Robillard	896190b91e	return nil when no traitement time	2021-06-17 16:31:53 +02:00
Christophe Robillard	887c5cb4a9	correct rubocop offenses	2021-06-17 16:31:53 +02:00
Christophe Robillard	bdf2f47eb9	fix specs for procedure stats	2021-06-17 16:31:53 +02:00
Christophe Robillard	a8840faadb	move stats methods to appropriate concern class	2021-06-17 16:31:53 +02:00
Christophe Robillard	701b72494d	compute usual traitement time for specific month	2021-06-17 16:31:53 +02:00
Paul Chavard	a2c53ce7ea	format phone numbers	2021-06-15 09:14:55 +02:00
Christophe Robillard	aee8db99d0	add spec for dossier weight estimation	2021-06-09 10:52:38 +02:00
Christophe Robillard	f0b2327ec6	add spec for count dossiers termines by month	2021-06-09 10:52:38 +02:00
Paul Chavard	9819a5ff77	Update spec/models/procedure_spec.rb ... Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com>	2021-06-03 13:11:16 +02:00
Paul Chavard	a0d4c9d54c	Fix published revisions	2021-06-03 13:11:16 +02:00
Paul Chavard	05380b9520	Fix destoying discarded procedures	2021-05-27 18:48:56 +02:00
Paul Chavard	9b0dae4cc2	Fix apostrophes ‘ -> ’	2021-05-26 18:05:14 +02:00
Paul Chavard	4922bc88d6	Do not crash when properties is nil	2021-05-26 12:40:07 +02:00
Paul Chavard	21ee79669d	Better labels in test	2021-05-25 11:43:38 +02:00
Paul Chavard	179bb5a9fe	Apply suggestions from code review ... Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com>	2021-05-25 11:43:38 +02:00
Paul Chavard	acb277e650	Use stable_id when replacing tags	2021-05-25 11:43:38 +02:00
Paul Chavard	c5f2faa3d2	add tests for backward compatibility of geo_areas	2021-05-24 11:57:00 +02:00
simon lehericey	b620888597	show only dossier avis	2021-05-20 16:18:04 +02:00
kara Diaby	aaf943569a	rename avis confidential test	2021-05-20 11:13:24 +02:00
Paul Chavard	5f419954b4	Fix dossier deleted user display	2021-05-13 10:43:55 +02:00
Paul Chavard	3f7a2bea9b	Dossier without user should be valid	2021-05-11 17:50:10 +02:00
Paul Chavard	8a74438dc1	Use conservation_extension instead of en_construction_conservation_extension	2021-05-11 17:33:53 +02:00
simon lehericey	c5f6c9ae1e	fix missing state translation	2021-05-10 11:17:34 +02:00
simon lehericey	e18fb116c6	cannot create fci without user	2021-05-05 14:36:34 +02:00
simon lehericey	50f679746f	do not extract twice the same dossier_id if the dossier is followed twice	2021-05-04 16:38:34 +02:00
Paul Chavard	bcbfcdc537	Revert "Merge pull request #6142 from tchak/enable_brouillon_extend_conservation" ... This reverts commit 48eb4d9778, reversing changes made to 5539d5cb8c. # Conflicts: # app/models/dossier.rb # db/schema.rb	2021-05-04 16:03:29 +02:00
Christophe Robillard	01f180022b	prend en compte uniquement les pj pour estimer la taille d'un dossier	2021-05-04 12:50:12 +02:00
Paul Chavard	f6508899de	Refactor NotificationMailer	2021-05-04 12:05:06 +02:00
Paul Chavard	a4fd629f4a	Enable user destruction	2021-05-04 12:05:06 +02:00
Paul Chavard	b2a867266a	Allow users to extend conservation on drafts	2021-04-29 19:50:30 +02:00
Christophe Robillard	f40d96fbd2	Revert "Revert "Export de tous les dossier d'une démarche"" ... This reverts commit d9a588b52e.	2021-04-29 17:29:47 +02:00
krichtof	d9a588b52e	Revert "Export de tous les dossier d'une démarche"	2021-04-29 16:07:18 +02:00
simon lehericey	db23a853a9	fetch all notification at once	2021-04-29 11:23:41 +02:00
simon lehericey	8b73d8804c	fetch all exports at once by groupe_instructeurs_ids	2021-04-29 11:23:41 +02:00
Christophe Robillard	c25f3c79d9	add archive model	2021-04-28 11:40:58 +02:00
Paul Chavard	c20ad5ca17	Remove the link between commentaire and user	2021-04-22 15:10:47 +01:00
simon lehericey	553e1d973c	remove old methods	2021-04-22 10:46:04 +02:00
Paul Chavard	6d37e1d133	Fix discarded procedures destruction	2021-04-14 12:24:16 +01:00
Paul Chavard	5b56ec425b	Fix discarded dossiers destruction	2021-04-14 12:24:16 +01:00
simon lehericey	52c8b60419	This is why you need to add a COUNT(DISTINCT dossiers.id) to make it work	2021-04-13 09:32:48 +02:00
simon lehericey	594cda3ee3	Remove previous attempt but steal its spec	2021-04-13 09:32:48 +02:00
simon lehericey	6055fd1b0b	remove for_procedure	2021-04-13 09:32:48 +02:00
Paul Chavard	fd48b86b7f	Simplify export unicity check and use create_or_find_by	2021-04-01 21:14:16 +01:00
Pierre de La Morinerie	21356e42b8	specs: remove unused require	2021-03-25 13:24:53 +01:00
kara Diaby	18f89b0d83	adjust tests	2021-03-24 17:47:24 +01:00
Paul Chavard	0b22788d60	experts_procedure should not be optional	2021-03-23 13:46:33 +01:00
Paul Chavard	224c7ec6c3	Update spec/models/dossier_spec.rb ... Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com>	2021-03-23 10:51:55 +01:00
Paul Chavard	84214f4bd4	Do not export non exportable champs on draft procedures	2021-03-23 09:55:37 +01:00
Paul Chavard	1449fbbe67	Fix multiple_drop_down_list mandatory check	2021-03-18 15:22:28 +01:00
kara Diaby	81f5a5254b	tests	2021-03-18 11:38:52 +01:00
Paul Chavard	4f03c231a3	Add tests for GeoJSON validation	2021-03-16 12:27:28 +01:00
Pierre de La Morinerie	75a1046315	active_storage: refactor concerns ... Follow-up of #5953. Refactor the concerns with two goals: - Getting closer from the way ActiveStorage adds its own hooks. Usually ActiveStorage does this using an `Attachment#after_create` hook, which then delegates to the blob to enqueue the job. - Enqueuing each job only once. By hooking on `Attachment#after_create`, we guarantee each job will be added only once. We then let the jobs themselves check if they are relevant or not, and retry or discard themselves if necessary. We also need to update the tests a bit, because Rails' `perform_enqueued_jobs(&block)` test helper doesn't honor the `retry_on` clause of jobs. Instead it forwards the exception to the caller – which makes the test fail. Instead we use the inline version of `perform_enqueued_jobs()`, without a block, which properly ignores errors catched by retry_on.	2021-03-16 11:49:14 +01:00
Paul Chavard	70500e3d56	Groupe instructeur selector default blank	2021-03-09 14:47:23 +01:00
Pierre de La Morinerie	2f948f7e46	active_storage: fix blob update hooks ... For some reason on Rails 6.1 the `after_update_commit` hook is properly registered – but disappears from the record later, and in the end is never run. Fix it by using the general `after_commit` hook instead.	2021-03-04 14:30:38 +01:00
Paul Chavard	5d4f025be0	Rename for consistency with defaut_groupe_instructeur	2021-03-04 10:45:02 +01:00
Paul Chavard	89ec3923f2	Defaut groupe instructeur ordered by label	2021-03-04 10:35:44 +01:00
Paul Chavard	96a832bc19	Add SerializerService	2021-03-02 12:42:22 +01:00
Paul Chavard	46a839e7f7	Remove a spec that was testing bug in libgeos ... we don’t use libgeos anymore	2021-02-23 10:35:30 +01:00
Paul Chavard	75392272fb	Add champ address model	2021-02-17 19:10:16 +01:00
Paul Chavard	7eee14feef	Add ChampFetchExternalDataJob	2021-02-17 19:10:16 +01:00
Christophe Robillard	d55f156aec	admin: durée de conservation des données hors ds n'est plus demandée ... La colonne est tout de même gardée en base	2021-02-17 16:41:57 +01:00
Pierre de La Morinerie	98be7e2076	Fix new Rubocop warnings	2021-02-16 16:31:30 +00:00
kara Diaby	7b4ec486ec	change active record request to get expert list	2021-02-16 09:46:18 +00:00
Christophe Robillard	a288a13805	disable france connect authentication for admin and instructeurs	2021-02-10 18:13:47 +01:00
Paul Chavard	a591d5528e	Add job exception log methods to champ and dossier	2021-02-05 18:56:27 +01:00
kara Diaby	9b8d2f6fd3	instead of call Avis table, we now call Experts Procedure table to see the experts list	2021-01-26 13:59:10 +01:00
Paul Chavard	4452b2cf45	fix order of types de champ on procedure	2021-01-26 10:45:34 +01:00
kara Diaby	2987139dd6	Link avis to an expert	2021-01-22 14:31:02 +01:00
kara Diaby	efbff0f2e0	add expert factory	2021-01-20 18:03:06 +01:00
kara Diaby	da067597ab	Add create expert method	2021-01-20 18:03:05 +01:00
kara Diaby	e0cb0eebab	Tests : add an expert to a procedure and put give him the access to see the dossier final decision	2021-01-20 18:03:05 +01:00
simon lehericey	d409a9a6c5	Procedure and expert link	2021-01-20 18:03:05 +01:00
simon lehericey	d72f0c6dd2	Add authorized content type for pj	2021-01-18 17:23:08 +01:00
Paul Chavard	f33544f067	Fix type_de_champ repetition revision after clone ... fix #5769	2021-01-12 10:57:34 +01:00
kara Diaby	2b06ee95e1	Add a method to retrieve all invited experts for all procedure dossiers	2020-12-21 14:55:51 +01:00
simon lehericey	4960eda5cb	use stable id	2020-12-17 10:51:09 +01:00
simon lehericey	cbccdea8e0	move displayed_fields for select to procedure_controller	2020-12-17 10:51:08 +01:00
kara Diaby	f3c4040d2d	add grace period to deleted dossiers	2020-12-16 15:00:26 +01:00
Christophe Robillard	15a395fbc7	superadmin: check complexity password server side	2020-12-15 16:26:09 +01:00
simon lehericey	bc4dc22aea	spec: use real signature to avoid mocking	2020-12-14 14:09:15 +01:00
simon lehericey	5a9cd71783	fix bill signature	2020-12-11 15:49:05 +01:00
Paul Chavard	48e7822e34	Remove titres identite after a dossier is processed	2020-12-10 15:21:25 +01:00
clemkeirua	513d4f6ff1	move all the cron jobs in a dedicated directory	2020-12-08 13:22:43 +00:00
Christophe Robillard	5562e65bf3	refacto: rename administration to super_admin	2020-11-05 16:03:55 +01:00
Christophe Robillard	2a0ebd062a	enable 2FA for manager ... when trying to access manager, if superadmin did'nt enable otp, he/she is redirected to a page to enable 2FA. When superadmin is enabling 2FA, he has to to scan a qrcode with the 2FA application client. And afterwards, the superadmin has to log in with email, password and OTP code.	2020-11-05 16:03:55 +01:00
clemkeirua	89316c0689	fix counter for dossiers suivis/à suivre when unfollow	2020-10-28 13:51:35 +00:00
clemkeirua	b4910c557d	ajout de procedure.dossiers_count_for_instructeur	2020-10-28 13:51:35 +00:00
Paul Chavard	7c58f06c60	always validate geometries returned from api	2020-10-08 16:03:28 +02:00
Paul Chavard	59086cc728	Fix geo length computations	2020-10-01 15:09:38 +02:00
Paul Chavard	4dfc1c719f	Fix geo areas computations	2020-10-01 15:09:38 +02:00
Paul Chavard	1bd59c72e5	Include in exports types_de_champ from all revisions	2020-09-30 13:42:38 +02:00
clemkeirua	f3e487bd9e	replace filter+first with find	2020-09-25 12:53:11 +00:00
clemkeirua	eb46cc6425	piecejusticative file validation focus on size	2020-09-25 09:35:16 +00:00
clemkeirua	c155de1d7e	ajout de la liste des extensions	2020-09-25 09:35:16 +00:00
clemkeirua	31d48c2879	validation is enableed only for 'new' procedures	2020-09-25 09:35:16 +00:00
clemkeirua	8711e8f911	reenable validator on piece_justificative	2020-09-25 09:35:16 +00:00
Paul Chavard	26a6e18cb9	Do not crash when rgeo can’t calculate polygon area ... example are “hourglass” shaped polygons	2020-09-23 16:52:08 +02:00
Paul Chavard	61c315b276	Fix geo area point coordinates display	2020-09-23 16:52:08 +02:00
kara Diaby	cb4e91c405	Add iban type de champ	2020-09-23 15:56:26 +02:00
Paul Chavard	973973ab6a	Do not enqueue web hooks for empty urls	2020-09-22 17:03:19 +02:00
Paul Chavard	a3f3b8a8e0	procedure.dossiers through revisions	2020-09-22 10:55:17 +02:00
clemkeirua	f96377d878	refactor Dossier#with_notifications	2020-09-21 08:28:42 +00:00
clemkeirua	d01a53eb72	remove :cached_notifications gate	2020-09-21 08:28:42 +00:00
clemkeirua	d8b4cc67be	add a test scenario for users	2020-09-18 11:16:34 +02:00
clemkeirua	1e32a3c11f	add complexity check to admin account creation	2020-09-18 11:16:34 +02:00
clemkeirua	5a8fbde0e7	remove dead code in admin model	2020-09-18 11:16:34 +02:00
clemkeirua	de3118bc7b	force password reset on admin promotion or creation	2020-09-17 16:39:13 +02:00
clemkeirua	0307beecd6	Revert "Merge pull request #5576 from tchak/soft-delete-users" ... This reverts commit bf0d3914ce, reversing changes made to 503527459e.	2020-09-17 15:39:16 +02:00
Paul Chavard	a0dd3604a4	User discard_and_anonymize!	2020-09-17 11:16:56 +02:00
simon lehericey	e4de522b48	only retrieve id of procedures with notifications	2020-09-11 09:43:04 +00:00
clemkeirua	a62907f33b	add more tests for phone numbers	2020-09-09 09:00:03 +02:00
clemkeirua	c7b96d3d43	add feature-flip for instructeurs on cached notifications	2020-09-08 15:40:42 +00:00
clemkeirua	52ea5ef89a	make Dossier#with_notifications great again ... Co-authored-by: Christophe Robillard <christophe.robillard@beta.gouv.fr>	2020-09-08 15:40:42 +00:00
clemkeirua	61cf33e3ca	remove duplicate private champ	2020-09-04 15:40:23 +02:00
kara Diaby	ae61c279af	migrate emails text editor to new interface	2020-09-03 14:42:22 +02:00
Paul Chavard	1488e0964b	update models specs to use revisions	2020-09-02 11:26:26 +02:00
Judith	25a24ba7c8	removal of translation keys already present in the gem rails-i18n	2020-09-01 16:33:58 +02:00
Christophe Robillard	090a247ba9	validates phone champ server side	2020-08-20 15:33:03 +02:00
Christophe Robillard	f77cc06a91	prend en compte le nom de l'enseigne pour l'établissement	2020-08-20 14:23:02 +02:00
Pierre de La Morinerie	a7361fdbd3	models: require belong_to associations on mail templates	2020-08-18 15:57:37 +02:00
Pierre de La Morinerie	5a7bd24fba	models: require belong_to associations on type_de_champ ... - Make `type_de_champ.procedure` a requirement; - Move the procedure_id assignation to `before_validation` (otherwise the record is invalid, and never gets saved);	2020-08-18 15:57:37 +02:00
Pierre de La Morinerie	6328011f60	models: require belong_to associations on champ ... - Make `champ.dossier` a requirement; - Move the dossier_id assignation to `before_validation` (otherwise the record is invalid, and never gets saved); - Allow specs to only build the champ (instead of saving it to the database), which bypasses the requirement to have a dossier.	2020-08-18 15:57:37 +02:00
Pierre de La Morinerie	71d9774d58	models: require belong_to associations on trusted_device_token	2020-08-18 15:57:37 +02:00
Pierre de La Morinerie	ce53e219e0	models: require belong_to associations on procedure_presentation ... Some tests are still failing	2020-08-18 15:57:37 +02:00
Pierre de La Morinerie	fe8804f208	models: require belong_to associations on individual	2020-08-18 15:57:37 +02:00
Pierre de La Morinerie	afb1c33154	models: require belong_to associations on geo_area	2020-08-18 15:57:37 +02:00
Pierre de La Morinerie	32e55a6d37	models: require belong_to associations on avis	2020-08-18 15:57:36 +02:00
Pierre de La Morinerie	aefdd5d2a1	models: require belong_to associations on attestation_template	2020-08-18 15:57:36 +02:00
Pierre de La Morinerie	c1e2928ce7	models: require belong_to associations on assign_to	2020-08-18 15:57:36 +02:00
Pierre de La Morinerie	8962db38cc	models: render attestations in a simpler way ... The older method of instanciating an entire new rendering stack can be made simpler using Rails >= 5.0 methods. See https://api.rubyonrails.org/classes/ActionController/Renderer.html#method-i-render	2020-08-04 16:53:46 +02:00
Paul Chavard	1fca481c6e	Cleanup after clone	2020-07-28 17:04:06 +02:00
clemkeirua	c91e231347	spec: replace reference to ds in password	2020-07-23 16:20:16 +02:00
Paul Chavard	a08e318617	Add implicit_order_column on revisions	2020-07-22 12:25:06 +02:00
Paul Chavard	69ab2e44fb	Insert type_de_champ with correct initial position	2020-07-22 11:09:51 +02:00
Paul Chavard	58535c6a35	Add procedure revisions spec	2020-07-21 19:35:30 +02:00
Paul Chavard	0338080430	Remove unused procedure move type_de_champ code	2020-07-21 19:35:30 +02:00
Paul Chavard	d18a9c8162	Migrate procedures “on demand”	2020-07-21 19:35:30 +02:00
Paul Chavard	0a0912503b	Add type_de_champ mutation methods to revision	2020-07-21 19:35:30 +02:00
Christophe Robillard	52e8f32e19	expert can only revoke avis claimed by him/her	2020-07-16 21:07:20 +02:00
Christophe Robillard	3ea34834a7	revoke expert avis	2020-07-16 21:05:11 +02:00
Paul Chavard	b628169053	Remove unsused drop_down_list model	2020-07-16 15:29:01 +02:00
clemkeirua	8a2aa13b74	remove pending tests	2020-07-15 09:27:23 +00:00
clemkeirua	299c86141c	added before_save to PieceJustificativeChamp in order to set skip_pj_validation	2020-07-15 09:00:12 +00:00
kara Diaby	ba6b89743c	put pending testsz	2020-07-13 12:24:48 +02:00
Paul Chavard	cb8cac395b	fix spec name	2020-07-08 19:28:17 +02:00
Paul Chavard	3b9e6dba25	Update spec/models/type_de_champ_shared_example.rb ... Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com>	2020-07-08 19:28:17 +02:00
Paul Chavard	84ff75ed6b	Update spec/models/type_de_champ_shared_example.rb ... Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com>	2020-07-08 19:28:17 +02:00
Paul Chavard	a92320e246	Update spec/models/type_de_champ_shared_example.rb ... Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com>	2020-07-08 19:28:17 +02:00
Paul Chavard	d8e864a7d9	Update spec/models/type_de_champ_shared_example.rb ... Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com>	2020-07-08 19:28:17 +02:00
Paul Chavard	660c95356b	Update spec/models/type_de_champ_shared_example.rb ... Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com>	2020-07-08 19:28:17 +02:00
Paul Chavard	a74e52c828	Call remove_drop_down_list on before_save	2020-07-08 19:25:05 +02:00
Paul Chavard	3c9cc6c070	Remove repetition types_de_champ on type_champ change	2020-07-08 19:25:05 +02:00
Christophe Robillard	2c56511204	validate api_entreprise_token	2020-07-08 18:59:22 +02:00
Christophe Robillard	7fd4d46e8e	remove empty spec file	2020-07-08 18:15:15 +02:00
Christophe Robillard	1253bb5994	store instructeur_email in traitement	2020-07-08 18:15:15 +02:00
Christophe Robillard	0be4b50ade	update usual_traitement_time with traitement model	2020-07-08 18:15:15 +02:00
Christophe Robillard	a072d35211	use traitement model ... when a dossier is terminated (accepte, refuse or classe_sans_suite), we store now `processed_at` and `motivation` in a traitement instance	2020-07-08 18:15:15 +02:00
Christophe Robillard	f631acd118	update state date in aasm after callbacks ... call aasm event methods, not state methods directly	2020-07-08 18:15:15 +02:00
Paul Chavard	c9ab80c880	WIP	2020-07-07 18:03:56 +02:00
Paul Chavard	13c21d89af	Fix attestation_template spec	2020-07-07 18:03:56 +02:00
Paul Chavard	6a24c3f812	Rails app:update	2020-07-07 18:03:56 +02:00
Pierre de La Morinerie	060bf1f9ca	factories: flesh out the default etablissement for a dossier	2020-07-06 11:41:25 +02:00
Pierre de La Morinerie	43569f687e	specs: use fixture_file_upload rather than Rack::Test::UploadedFile ... This is mostly for consistency (both styles were used before). Note: we still have to use `Rack::Test::UploadedFile.new` in factories, because of https://github.com/thoughtbot/factory_bot/issues/385.	2020-07-01 11:13:45 +02:00
Paul Chavard	97f91513c8	Store drop_down_list values as jsonb	2020-06-25 13:14:17 +02:00
Judith	9be58aa012	only downcasing search values for yes_no type_de_champs	2020-06-10 15:55:25 +02:00
Judith	ad53dfa84d	Instructeurs: Changed the filters from 'true/false' to 'oui/non' for yes_no type_de_champ	2020-06-10 15:50:41 +02:00
Paul Chavard	901b6e23a8	Remove legacy carto	2020-06-04 16:03:23 +02:00
Christophe Robillard	cf9d6ccf34	export bilans in ods and xlsx	2020-06-04 15:31:16 +02:00
Christophe Robillard	d06867822b	reorder bilans bdf csv	2020-06-03 15:45:11 +02:00
Paul Chavard	20705d6e30	Do not send draft norifications to users on inactive démarches	2020-05-27 16:36:46 +02:00
clemkeirua	77101208a4	Anonymisation de l'instructeur dans la messagerie	2020-05-18 12:56:30 +00:00
Pierre de La Morinerie	190548844a	dossiers: add piece justificative filename to spreadsheet export	2020-05-14 10:18:10 +00:00
Paul Chavard	dfc004d7bb	Unarchive dossier when repasser_en_instruction	2020-05-12 19:05:18 +02:00
Christophe Robillard	f587e6600a	extract class ApiEntrepriseToken ... and check if token is expired	2020-05-06 10:57:45 +02:00
Paul Chavard	6556df2a85	Fix a crash in case of invalid geometry	2020-05-05 15:56:05 +02:00
Christophe Robillard	9de2c7c85a	improve csv generation for bilans bdf	2020-04-30 16:15:16 +02:00
Paul Chavard	843e033c38	Allow instructeurs to download a GeoJSON document for a given dossier	2020-04-30 15:49:43 +02:00
Christophe Robillard	ddd3e6bb02	don't copy api_entreprise_token when cloning ... except for an admin who owns the parent procedure	2020-04-29 17:17:20 +02:00
Paul Chavard	9cb612bb3d	Show area and length on champ carto selections utilisateur	2020-04-23 10:21:18 +02:00
Pierre de La Morinerie	1cb18e51ac	champ: return the parent dossier even when discarded ... Dossier has a `default_scope { kept }`. Because of that, when the parent dossier is discarded, `champ.dossier` will return nil. We should kill the default scope. But meanwhile, ensure that `champ.dossier` returns even a discarded dossier.	2020-04-22 11:46:42 +02:00
Paul Chavard	e512870fd2	Cleanup procedure duree_conservation_dossiers_dans_ds validations	2020-04-16 19:40:19 +02:00
Paul Chavard	bc8217e030	Carte Editor sends FeatureCollection to the server	2020-04-16 18:29:19 +02:00
Paul Chavard	22604013d0	Expose multiple user selections on champ carte	2020-04-15 18:07:09 +02:00
clemkeirua	8c2f589cbf	fix admin deletion of empty service with archived procedures	2020-04-10 20:01:40 +02:00
Paul Chavard	61eaca928f	remove WarnExpiringDossiersJob	2020-04-09 11:11:51 +02:00
clemkeirua	ed45c88bdf	do not clone groups instructeurs for admin outside the procedure	2020-04-07 09:25:40 +02:00
pedong	7806a26e2c	copy groupe_instructeurs when clone	2020-04-07 09:22:33 +02:00
Christophe Robillard	dc31f41c26	fix tests for procedure_presentation	2020-04-06 17:39:51 +02:00
Christophe Robillard	5b6044803b	forbid to create champ with same type_de_champ and same row	2020-04-06 17:39:51 +02:00
Paul Chavard	288ace2f34	Dossier on discarded procedure should have access to discarded procedure	2020-03-31 17:08:29 +02:00
Paul Chavard	bd81970f67	DeletedDossier should have access to discarded demarche	2020-03-31 17:08:29 +02:00
Paul Chavard	58c126308c	Add DiscardedProceduresDeletionJob job	2020-03-31 17:08:28 +02:00
Paul Chavard	876e05aed3	Discard demarches from manager	2020-03-31 17:08:28 +02:00
Pierre de La Morinerie	4cb747fdb6	specs: always require rails_helper ... Test helpers are separated between two files: spec_helper and rails_helper. This separation is meant to allow tests that do not require Rails (like testing standalone libs) to boot faster. The spec_helper file is always loaded, through `--require spec_helper` in the `.rspec` config file. When needed, the rails_helper file is expected to be required manually. This is fine, but: - Many test files have a redundant `require 'spec_helper'` line; - Many test files should require `rails_helper`, but don't. Not requiring `rails_helper` will cause the Rails-concerned section of the test environment not to be configured–which may cause subtle bugs (like the test database not being properly initialized). Moreover, Spring loads all the Rails files on preloading anyway. So the gains from using only `spec_helper` are thin. To streamline this process, this commit: - Configures `.rspec` to require `rails_helper` by default; - Remove all manual requires to spec_helper or rails_helper. Reference: https://stackoverflow.com/questions/24145329/how-is-spec-rails-helper-rb-different-from-spec-spec-helper-rb-do-i-need-it	2020-03-31 12:48:32 +02:00
Pierre de La Morinerie	fe13043efd	dossier: prepare validations to piece_justificative champs ... We can't yet enable the validations, because of an issue that will (hopefully) be solved with Rails 6. See https://github.com/betagouv/demarches-simplifiees.fr/issues/4926	2020-03-30 11:12:25 +02:00
Pierre de La Morinerie	245ef2befd	specs: fix an Rspec warning	2020-03-30 11:12:25 +02:00
Paul Chavard	c707a21f97	Rename delete_and_keep_track -> discard_and_keep_track	2020-03-26 14:23:23 +01:00
Paul Chavard	c086f6d580	Add a job to remove discarded dossiers	2020-03-25 17:28:25 +01:00
Paul Chavard	5b5ae5a7a5	Do not send notifications or create operation logs on brouillon demarches	2020-03-25 15:04:52 +01:00
maatinito	1af32b29fd	#4807 Use now() instead of Date.time.today (better code homogeneity)	2020-03-24 17:09:14 -10:00
maatinito	f5c2dc03c5	#4807 better method/variable naming	2020-03-24 16:46:23 -10:00
Christian Lautier	e61c53f267	Fix #4807 48h before closing a procedure, notify users their draft is not submitted	2020-03-24 16:46:23 -10:00
clemkeirua	e76870844e	update test for dossier#en_construction_close_to_expiration ... It now takes into account en_construction_conservation_extension	2020-03-24 18:10:51 +01:00
Paul Chavard	5c2eba1dd1	Always add a reason to dossier deletion	2020-03-24 09:30:11 +01:00
Paul Chavard	903cf0cef5	Keep operation logs after dossier removal	2020-03-24 09:18:45 +01:00
kara Diaby	1f27652cd3	add files validations to models	2020-03-23 11:28:13 +01:00
Paul Chavard	77018b9e2b	Add expiration scopes to dossier	2020-03-18 15:25:02 +01:00
Paul Chavard	f35ccc9d92	Move process_expired_dossiers_brouillon to a service	2020-03-18 15:25:02 +01:00
kara Diaby	395af2fbb0	instructors : receive daily emails for declarative folders	2020-03-17 15:54:50 +01:00
Christophe Robillard	d8d9b0922d	remove orphan services when destroying admin	2020-03-16 21:40:05 +01:00
Christophe Robillard	50007b2aac	highlight demande tab when groupe instructeur updated	2020-03-04 14:56:59 +01:00
Christophe Robillard	e8bef76772	fix test for procedure presentation	2020-03-03 18:07:50 +01:00
Paul Chavard	c46e012c10	Use dossier.assign_to_groupe_instructeur	2020-03-03 10:30:49 +01:00
kara Diaby	4a70a7fcc8	remove email_notifications_enabled column because of the new daily_email_notifications_enabled	2020-02-27 11:09:19 +01:00
Christophe Robillard	2bd6f01009	log changer_groupe_instructeur	2020-02-26 11:25:07 +01:00
Christophe Robillard	e0f4957dfd	notify instructeur after groupe_instructeur changed	2020-02-26 11:25:07 +01:00
Christophe Robillard	fb3d7e45ba	unfollow stale instructeurs ... when the group instructeur of a dossier is changed, unfollow the instructeurs who don't belong to the new groupe instructeur	2020-02-26 11:25:07 +01:00
kara Diaby	6102ba6039	Do not permit to upload a GIF file via javascript	2020-02-25 23:33:15 +01:00
Paul Chavard	24d237de9e	A cloned procedure should not have canonical relationship	2020-02-25 15:26:43 +01:00
Paul Chavard	be66a8986c	Activate champ integer number on all the new procedures	2020-02-25 11:26:37 +01:00
clemkeirua	48d2093577	tag 'groupe instructeur' uniquement si la procedure est routee	2020-02-20 14:48:14 +00:00
clemkeirua	059d80ea34	#4785 ajout d'une balise 'groupe instructeur'	2020-02-20 14:48:14 +00:00
Paul Chavard	b7051da278	Remove old export code	2020-02-19 18:19:17 +01:00
Pierre de La Morinerie	d6a9318d05	champ: fix siblings for repetition champs ... Fix a crash when requesting the `section_index` of a section header in a repetition champ.	2020-02-17 17:11:17 +01:00
Paul Chavard	1ce1c1e6d0	use discard	2020-02-13 12:31:59 +01:00
Pierre de La Morinerie	f8ed7ec051	form: display index of section in header	2020-02-13 11:18:46 +01:00
kara Diaby	0b8a59d5e9	Add the possibility to disable weekly email notifications (instructeur) && rename the column email_notifications_enabled to daily_email_notification_enabled	2020-02-12 13:02:31 +00:00
Pierre de La Morinerie	e3ba2ed96c	Revert "form: add number to section headers" ... This reverts commit f42977e40a.	2020-02-12 13:54:44 +01:00
Pierre de La Morinerie	3e1ba4eebc	specs: fix test failing because of unspecified types_de_champ order	2020-02-12 13:26:54 +01:00
Pierre de La Morinerie	f42977e40a	form: add number to section headers	2020-02-11 17:36:50 +01:00
Christophe Robillard	c137917396	fix typo	2020-02-04 16:07:01 +01:00
Christophe Robillard	5a46effcbc	remove useless condition to admin that can be deleted ... administrateur can be deleted only if he/she has a procedure where he/she is the only admin	2020-02-04 16:07:01 +01:00
Christophe Robillard	4bf020cb96	rend le test plus élégant	2020-02-04 16:07:01 +01:00
Christophe Robillard	6fc8a27bd7	destroys not all dossiers ... but only dossiers for a specific user	2020-02-04 16:07:01 +01:00
Christophe Robillard	cee4c5b8fb	Revert "Revert "4127 fix superadmin supprime compte usager"" ... This reverts commit 751f24f7bb.	2020-02-04 16:07:01 +01:00
clemkeirua	57a0973c99	added a test to show #4658 does not exist	2020-02-03 15:43:53 +01:00
Pierre de La Morinerie	96932faa3f	models: add a Dossier#with_hidden scope, and remove unscoped usages	2020-01-28 17:32:38 +01:00
Pierre de La Morinerie	1448d5b098	models: add a Procedure#with_hidden scope, and remove unscoped usages ... This avoids the broad use of `unscoped` to remove the `hidden_at` clause.	2020-01-28 17:32:38 +01:00
Pierre de La Morinerie	4efea77280	specs: regroup dossier scope specs together	2020-01-28 17:32:38 +01:00
clemkeirua	65b4bcf3a1	Permet de déposer un dossier lorsqu'un menu déroulant lié obligatoire n'a pas de valeur (car la liste est légitimement vide) dans le second champ.	2020-01-28 14:30:26 +01:00
Paul Chavard	67dea1ee50	Update spec/models/procedure_spec.rb ... Co-Authored-By: Pierre de La Morinerie <kemenaran@gmail.com>	2020-01-28 12:49:53 +01:00
Paul Chavard	517ab25783	Register canonical procedure when demarche republished under existing path	2020-01-28 12:49:53 +01:00
Pierre de La Morinerie	aaaf6f393b	specs: add an actual test case to the Exercice spec ... This fixes the "No timing found for 'spec/models/exercice_spec.rb'" warning message during specs.	2020-01-28 12:00:34 +01:00
Pierre de La Morinerie	751f24f7bb	Revert "4127 fix superadmin supprime compte usager"	2020-01-21 18:57:54 +01:00
Pierre de La Morinerie	0efb62f03a	factories: ensure that dossiers with_individual are consistent	2020-01-21 17:24:56 +01:00
Pierre de La Morinerie	724ff50363	factories: rename dossier for_individual to with_individual ... This clarifies the distinction between ``` create :procedure, :for_individual ``` and ``` create :dossier, :with_individual ```	2020-01-21 17:24:56 +01:00
Christophe Robillard	675bbdad15	transfere les services lors de suppression admin ... Lorsqu'un administrateur est supprimé, ses services sont transférés à un autre administrateur pour chacune de ses procédures	2020-01-21 15:05:33 +01:00
Christophe Robillard	d9570eedc6	empêche suppression d'un user qui est instructeur	2020-01-21 15:05:33 +01:00
Christophe Robillard	a6d007dbd3	supprime un instructeur	2020-01-21 15:05:33 +01:00
Christophe Robillard	d4de5769ee	empêche la suppression d'un user qui est admin	2020-01-21 15:05:33 +01:00
Christophe Robillard	d8a51f986f	supprime un utilisateur qui a des dossiers cachés	2020-01-21 15:05:33 +01:00
clemkeirua	d6e7799370	removed routing condition in weekly summary	2020-01-20 14:23:19 +01:00
clemkeirua	7e15c6a4a4	add filtering by group in procedure_overview ... The weekly overview do not work for instructeurs in procedures with multiples groups ; they see dossiers that they do not have access to. Now the correct filter is added	2020-01-20 14:23:19 +01:00
Paul Chavard	4edc7b00cf	Use geocoder	2020-01-15 15:04:04 +01:00
Paul Chavard	14295db9ad	Revert "Revert "Merge pull request #4552 from tchak/champ-communes"" ... This reverts commit 4373cb22cb.	2020-01-14 18:46:07 +01:00
clemkeirua	4373cb22cb	Revert "Merge pull request #4552 from tchak/champ-communes" ... This reverts commit 4cec26f73a, reversing changes made to 0ef25ef36c.	2020-01-13 16:26:27 +01:00
Christophe Robillard	d289c21a8b	speak english for test descriptions	2020-01-13 10:06:43 +01:00
Christophe Robillard	0f881f942b	raise if trying to del a user who can't be deleted	2020-01-13 10:06:43 +01:00
Christophe Robillard	696a058280	delete adminis with procs managed by other admins	2020-01-13 10:06:43 +01:00
Christophe Robillard	a0b4d97d08	fix rubocop offenses	2020-01-13 10:06:43 +01:00
Christophe Robillard	9a62d3fe0c	delete a user	2020-01-13 10:06:43 +01:00
Christophe Robillard	58ef36ff57	tells if a user can be deleted	2020-01-13 10:06:43 +01:00
Paul Chavard	c6326bfa77	Fix tests involving attachment urls	2020-01-08 14:46:18 +01:00
Pierre de La Morinerie	5e05556ee8	dossiers: add a validation on dossier individual ... Validate that a dossier on a `for_individual?` procedure always has an `individual` associated record. For this, the individual needs to be built before the record is validated (i.e. even before the `before_create` callback is run). This should help with #4596: now if a dossier is created without an `individual`, or if the `invividual` record is later removed, the validation will fail.	2020-01-08 10:48:22 +01:00
Paul Chavard	e61e39d345	Remove unused code and tests	2020-01-07 11:52:51 +01:00
simon lehericey	d0939ae1a4	Add Export Model	2019-12-18 13:13:15 +01:00
maatinito	a02a5edce3	Bug with time zone when testing sending of brouillon expiration notices	2019-12-11 17:34:10 +01:00
Paul Chavard	2f060fc30a	Add depubliee state to procedures	2019-12-04 16:52:41 +01:00
Christophe Robillard	4e7c779116	refuse les numéros de tel invalides ... rend facultatif les numéros de téléphone	2019-12-04 05:34:43 +01:00
simon lehericey	006e426a11	Work on deletion mail	2019-12-03 17:18:53 +01:00
simon lehericey	79bfb8b143	Delete expired dossiers	2019-12-03 17:18:53 +01:00
simon lehericey	03b7e81ca4	Send deletion notice for near expired brouillon	2019-12-03 17:18:53 +01:00
Paul Chavard	7b947feae4	Rename demarche archivée to demarche close	2019-11-28 15:07:16 +01:00
Paul Chavard	3e334a3306	Drop test_started_at ... # Conflicts: # spec/models/procedure_spec.rb	2019-11-28 14:17:47 +01:00
simon lehericey	4b62c9267a	fix flaky test	2019-11-18 17:26:28 +01:00
Paul Chavard	0562e2728f	Fix type_de_champ validation error	2019-11-06 12:54:07 +01:00
simon lehericey	395aba8bbc	Remove administrateur active notion	2019-11-05 14:10:39 +01:00
simon lehericey	b193dd1465	User get the active notion	2019-11-05 14:10:39 +01:00
simon lehericey	aeb44dd2aa	Cleaning spec	2019-11-05 10:29:39 +01:00
simon lehericey	e3d7688e66	[fix #4473] Invite_administrateur!: do not reset password if the user is active	2019-11-05 10:29:39 +01:00
simon lehericey	53c7997081	Invite_administrateur!: characterization test	2019-11-05 10:29:39 +01:00
Pierre de La Morinerie	a458693a19	specs: fix #usual_traitement_time tests when near the DST date	2019-11-04 10:56:15 +01:00
Pierre de La Morinerie	f8358b3ae9	instructeurs: create without providing the email	2019-11-04 10:44:24 +01:00
Pierre de La Morinerie	8e6930d257	instructeurs: fix ProcedurePresentation to use instructeur.user.email ... The `joins` are declared explicitely in order to associate a predictable name to the joined table. Otherwise, when the query is joined with `:users`, ActiveRecord will alias the join automatically to solve the conflict. Unfortunately, the automatic resolution means that the table name becomes unpredictable, and thus unsuitable to perform queries on.	2019-11-04 10:44:24 +01:00
Pierre de La Morinerie	a462edb9bc	instructeurs: alias instructeur.email ... This also means we need to replace instances of `pluck` on the email column.	2019-11-04 10:44:24 +01:00
Pierre de La Morinerie	cd478b489e	instructeurs: replace calls to Instructeur.find_by(email: …)	2019-11-04 10:44:23 +01:00
simon lehericey	4febf1851f	notifications_for_procedure is now based on instructeur.groupe_instructeurs	2019-10-25 09:42:17 +02:00
simon lehericey	8ae592fe25	[fix #4361] administrateur active	2019-10-24 18:32:48 +02:00
Pierre de La Morinerie	5fc88eb6a2	specs: fix a flaky repetitions test ... The test would sometime fail when the two fields are created in a different order than expected.	2019-10-24 16:52:29 +02:00
simon lehericey	1fa149575c	Add constraints to GroupeInstructeur	2019-10-23 21:47:20 +02:00
Paul Chavard	86b271997b	Invite experts to linked dossiers ... closes #3669	2019-10-23 13:10:09 +02:00
clemkeirua	43424e4f4e	merge with the work of paul, using 3 links	2019-10-22 09:51:14 +02:00
Nicolas Bouilleaud	03c950ea97	Move followed_dossiers_with_notifications to a Dossier scope ... Instead of instructeur.followed_dossiers_with_notifications, we can now write instructeur.followed_dossiers.with_notifications. Yay composition!	2019-09-25 14:10:00 +02:00
Nicolas Bouilleaud	a4166d3c57	Refactor Instructeur.notifications_* methods ... - rename `dossiers_id_with_notifications` to `followed_dossiers_with_notifications`, - rename `notifications_per_procedure` to `procedures_with_notifications`, - return an ActiveRecord::Relation instead of the result of the query, so that the call place can compose it, - `merge` with the wanted Dossier scope in the call places, don’t bother passing it as a parameter, - use the “state” (now “scope”) parameter as a scope method that can be just applied on `Dossier`.	2019-09-25 14:10:00 +02:00
Nicolas Bouilleaud	f74fde3f80	Avoid sending notification emails about archived dossiers	2019-09-20 11:06:33 +02:00
Nicolas Bouilleaud	769621de46	Explicitly pass the “state” param in notifications_*_procedure methods	2019-09-20 11:06:33 +02:00
simon lehericey	e2acb0a946	ProcedurePresentation: can use groupe instructeur	2019-09-18 15:51:02 +02:00
simon lehericey	9b16bd2037	Dossier: retrieve all dossiers for a procedure	2019-09-18 15:51:02 +02:00
simon lehericey	21577a0f0b	Instructeur: dedup procedures with multiple gi	2019-09-18 15:51:02 +02:00
Paul Chavard	8fcf1353f3	Remove duplicated attachments	2019-09-17 18:12:53 +02:00
Nicolas Bouilleaud	c26a701a17	Refactor and redesign publish modal ... * remove the autocomplete menu * use ujs to pre-validate the procedure * tweak the UI	2019-09-17 16:30:48 +02:00
Nicolas Bouilleaud	bd1e0aba38	Add Procedure path suggestion	2019-09-17 16:30:48 +02:00
Nicolas Bouilleaud	8fa630d2bb	Remove Gestionnaire.visible_procedures ... It is actually the same thing as Gestionnaire.procedures. It already included the procedures with paths as well as the archived procedures, and in production, there were no Gestionnaire for who procedures was returning a different result than visible_procedures (expect for two baddata brouillon procedures with a nil path). In addition, Procedure.path is now nonnull, which means the Procedure.avec_lien scope is pointless. Finally, the current spec showed that the only procedure not visible to the gestion was the one he was not assigned to.	2019-09-17 16:30:48 +02:00
Paul Chavard	b97cbd3402	Serialize champ repetition for tags ... closes #4272	2019-09-12 17:23:18 +02:00
Paul Chavard	3b8d3b7967	Add Style/CollectionMethods to rubocop	2019-09-12 14:48:18 +02:00
Paul Chavard	65e227c44b	Migrate to flipper	2019-09-10 16:10:14 +02:00
Paul Chavard	7ffb98e616	Remove carrierwave uploaders	2019-09-10 10:49:12 +02:00
simon lehericey	74096b6b3a	Assign Factory: automatically link to procedure.defaut_groupe_factory	2019-09-03 06:47:02 +02:00
simon lehericey	3cc8f0c792	Link Dossier and GroupeInstructeur	2019-09-03 06:47:02 +02:00
simon lehericey	caf1fbca44	Use assign_to	2019-09-02 11:41:12 +02:00
simon lehericey	b541ef0b41	Procedure has many instructeurs with defaut_groupe_instructeur	2019-09-02 11:41:12 +02:00
simon lehericey	ba24958035	Procedure add missing_instructeurs?	2019-09-02 11:41:12 +02:00
simon lehericey	85499365a0	Instructeur has_many procedures through groupe_instructeur	2019-09-02 11:41:12 +02:00
simon lehericey	25991c2892	Assign a procedure assign a group as well	2019-09-02 11:41:12 +02:00
simon lehericey	115d91387c	A procedure has a default groupe instructeur	2019-09-02 11:41:12 +02:00
Paul Chavard	a19b10b118	Migrate attestation files to active_storage	2019-08-27 17:42:52 +02:00
clemkeirua	188e0fd6b2	removed ask_birthday for new procedures & dossiers	2019-08-27 15:32:17 +02:00
simon lehericey	97d0855d47	add User.create_or_promote_to_instructeur	2019-08-20 12:20:12 +02:00
simon lehericey	d0ac1c3301	Fix manager invite administrateur	2019-08-14 16:34:50 +02:00
simon lehericey	c08e356367	Remove or fix nonsense code	2019-08-14 15:08:14 +02:00
simon lehericey	1b38d4071d	temporary remove password complexity check	2019-08-14 15:06:16 +02:00
Paul Chavard	0969b1f85f	Enable email_login_token for all gestionnaires	2019-08-14 12:53:51 +01:00
simon lehericey	ad31822a68	Spec: sign_in with instructeur.user	2019-08-13 15:15:16 +02:00
simon lehericey	65a53909e1	Update instructeur factory	2019-08-13 15:15:16 +02:00
simon lehericey	47b7dc368b	Remove or fix now nonsense code	2019-08-13 15:15:16 +02:00
simon lehericey	3fde2a6f70	Rename gestionnaire in code to instructeur	2019-08-12 13:47:01 +02:00
simon lehericey	6902f84b85	Brutally rename gestionnaire filename to instructeur	2019-08-12 13:47:01 +02:00
clemkeirua	d7105cb6f8	added spec for dossier#update_with_france_connect	2019-08-01 17:42:32 +02:00
maatinito	44efa5a1b1	#3928 administrator tests handle password constants	2019-08-01 17:12:14 +02:00
maatinito	8d3e3baabc	#3928 administrator new & edit pwd pages	2019-08-01 17:12:14 +02:00
Paul Chavard	c75e39884e	Save selection utilisateur as geo area	2019-08-01 11:38:09 +02:00
Pierre de La Morinerie	95e24392f9	models: remove old pieces justificatives	2019-07-30 16:11:17 +02:00
Pierre de La Morinerie	0da0a2b446	model: remove support for cloning procedures with old pj	2019-07-30 16:11:17 +02:00
Pierre de La Morinerie	ffe081c1f2	specs: remove old pieces_justificative from specs and factories	2019-07-30 16:11:17 +02:00
Pierre de La Morinerie	e975fe4ade	tasks: remove task to migrate old pieces justificatives	2019-07-30 16:11:17 +02:00
Pierre de La Morinerie	0018f36b44	gestionnaire: remove UI for filtering pieces justificatives	2019-07-30 16:11:16 +02:00
Nicolas Bouilleaud	b066ccbc89	Make sure Procedure.path is not null in our data	2019-07-29 13:53:33 +02:00
clemkeirua	6f47655301	rendu lien_site_web obligatoire au moment de la publication	2019-07-25 15:46:04 +02:00
clemkeirua	6d43465ee5	renammed into monavis_embed	2019-07-17 18:04:32 +02:00
clemkeirua	c8f9e3b5f8	automated test	2019-07-17 18:04:32 +02:00
Pierre de La Morinerie	71dfb38787	emails: improve typography of titles	2019-07-17 15:01:19 +02:00
clemkeirua	7eeddc0b79	using a shared example + scoped to state TERMINE	2019-07-17 11:53:16 +02:00
clemkeirua	b8fa567c81	ajout du tag 'lien document justificatif'	2019-07-17 11:53:16 +02:00
Pierre de La Morinerie	a8354bd103	dossiers: unify deletion of dossiers between manager and user ... The code paths for deleting a dossier were different, depending on whether the dossier was deleted by the user, or from the Manager. This commit unifies the two code paths into one. This has the effect of: - An operation log is now recorded when an user deletes its own dossier; - Gestionnaires are now notified even when the dossier is deleted from the Manager; - The `support:delete_user_account` task now requires the email address of the author.	2019-07-16 16:22:20 +02:00
clemkeirua	25f81f1d3c	download a dossier as zip with all attachments	2019-07-16 09:11:25 +02:00
Pierre de La Morinerie	35c3795f56	dossier: make messagerie available on archived procedures ... An Admin may archive a procedure to make it unavailable to the general public, but before all dossiers are handled. In this case, the messagerie needs to be available. Fix #4089	2019-07-11 15:37:04 +02:00
Pierre de La Morinerie	10065df8ce	champs: put champ label in numeric fields validation messages ... Replaces > La valeur du champ doit être un nombre entier (sans chiffres après > la virgule) by > La valeur du champ « Nombre de parents » doit être un nombre entier > (sans chiffres après la virgule)	2019-07-11 15:12:48 +02:00
simon lehericey	7b63ddfabb	Better champs factories	2019-07-10 16:41:34 +02:00
Pierre de La Morinerie	58a8d017f2	spec: cleanup dossier spec	2019-07-10 11:31:09 +02:00
Pierre de La Morinerie	56bc06cfbf	dossier: fix flaky spec for nearing_end_of_retention ... If the spec takes longer than 1s to run, the test would fail.	2019-07-10 11:00:49 +02:00
simon lehericey	0f9fdf3f75	Activate device email change confirmation	2019-07-09 11:55:17 +02:00
Nicolas Bouilleaud	930fd345de	Validate messagerie_available? when creating a new Commentaire ... Commentaires bu Users and Gestionnaire need the messagerie to be available; Automatic system Commentaires can be created anytime. This reintroduces Commentaire validation that was introduced in #3979 and disabled in #4018	2019-07-08 16:13:43 +02:00
Nicolas Bouilleaud	3f439ac07a	Add Commentaire.is_sent_by_system? and .is_sent_by(someone) ... And use it in CommentaireHelper and in the _message_icon and _message_issuer partials	2019-07-08 16:06:44 +02:00
Nicolas Bouilleaud	2abd93d360	Display the full User email in Commentaires ... * Only redact gestionnaires’ emails * Also, rename Commentaire.sender to Commentaire.redacted_email	2019-07-08 16:06:44 +02:00
Paul Chavard	e582ff729c	Add aasm to dossiers state	2019-07-03 13:37:27 +02:00
Mathieu Magnin	10d3ba10f2	Before save copy body in rich_body	2019-07-03 13:15:49 +02:00
simon lehericey	b2c987ff0d	[fix #3683] Dossier: add repasser_en_instruction!	2019-07-02 18:40:20 +02:00
simon lehericey	92bd382c64	[fix #4008] secured login for all gestionnaires	2019-07-01 15:06:39 +02:00
Nicolas Bouilleaud	bd47bf2691	Disable Messagerie in archived Dossiers and procedures ... * Use the existing Dossier#messagerie_available? method * Raise when attempting to build a Commentaire if not messagerie_available? * Disable the Messagerie form if not messagerie_available? * Add tests :) * Tweak the Horaires formatting while we’re here.	2019-07-01 09:39:39 +02:00
Paul Chavard	c5704fa22f	Remove unused code from Commentaire	2019-06-25 17:04:29 +02:00
Nicolas Bouilleaud	c606644902	Tweak codestyle in specs, following review	2019-06-17 16:16:28 +02:00
Nicolas Bouilleaud	f355f849a6	Add BillSignature Model	2019-06-17 16:16:28 +02:00
simon lehericey	ee296f2b44	Use default format for date and datetime champ	2019-06-12 17:48:12 +02:00
Nicolas Bouilleaud	6b90bc1ea1	Add “previously followed” dossiers and gestionnaires ... Using an “inactive” Follow scope, similar to the “active” scope. (I was tempted to use a default_scope, but this breaks when trying to `unscope` it in associations.)	2019-06-12 17:33:53 +02:00
Paul Chavard	cc4eba2b36	Less mokey patching	2019-05-21 14:21:42 +02:00
Paul Chavard	42235e81b1	Use active storage load hook to extend blob	2019-05-16 20:43:01 +02:00
Paul Chavard	dba8d65137	Track dossier operations with author and subject	2019-05-14 14:31:03 +02:00
clemkeirua	d0794f42d1	fix tag_substitution_concern links for lien attestation	2019-05-07 08:54:29 +02:00
clemkeirua	c98655be52	ellipsis on file input overflow	2019-05-07 08:54:29 +02:00
clemkeirua	0e26bda186	cleanup the tag substitution concern & uniformization	2019-05-07 08:54:29 +02:00
clemkeirua	e4259466b4	nettoyage du tag_substitution_concern	2019-05-07 08:54:29 +02:00
clemkeirua	f8a2598647	ajout du lien vers le justificatif dans la balise --lien attestation--	2019-05-07 08:54:29 +02:00
clemkeirua	747dc505cc	ajout d'un test	2019-05-07 08:54:29 +02:00
Nicolas Bouilleaud	df865e71dc	Make sure that there always is at least one administrator per Procedure	2019-05-06 16:19:08 +02:00
Paul Chavard	f113d108c9	Save virus scan status to blob metadata	2019-05-02 15:58:09 +02:00
Pierre de La Morinerie	d855468cb6	dossiers: display the estimate of the entire processing time ... Displaying separate estimations for en_construction and en_instruction doesn't really make sense for the users: they want to know how long it is going to take overall, not the petty details of our workflow.	2019-04-30 15:56:27 +02:00
Nicolas Bouilleaud	1c2e93ed41	Fix “nearing_end_of_retention” test ... The `nearing_end_of_retention` test creates a `just_expired_dossier` “six months ago”, which is 29 Oct 2018. The autumn DST change was on October 28; this is the first time this test runs under these conditions. We workaround the time offset by creating the dossier one hour earlier. This is technically a workaround, not a fix: the date arithmetics in `nearing_end_of_retention` are probably wrong. It looks like it’s comparing intervals, which seems error-prone, while it should be comparing dates. For now, I’m just making the tests pass.	2019-04-29 15:41:52 +02:00
Paul Chavard	8d093bd9ba	Fix missing dossier_id on champs inside repetition	2019-04-18 16:55:35 +02:00
simon lehericey	e65e21a72f	Email notification: use the right method for procedures	2019-04-18 15:07:01 +02:00
Nicolas Bouilleaud	c5122ee7f5	Allow filtering ProcedurePresentation by followers_gestionnaires ... fixes #3464	2019-04-10 14:32:51 +02:00
Pierre de La Morinerie	e34c556f29	procedure: fix specs ... When the time computations are done accross a Daylight Saving Time change, they may be off by one hour. It doesn't matter, as the estimated delay is counted in days, not hours.	2019-04-08 15:24:44 +02:00
Paul Chavard	639facaf2a	Add new types_de_champ#move api	2019-04-03 14:38:07 +02:00
Mathieu Magnin	71e0969bc0	[Fix #3692] Ensure SIRET is correct on server	2019-03-28 18:03:53 +01:00
Mathieu Magnin	27c8e9dcb8	Use the same clone_attachment method for all attributes on procedure.clone	2019-03-28 17:17:29 +01:00
Mathieu Magnin	4e27872a25	[Fix #3650] when cloning a procedure, do not forget pj_templates	2019-03-26 15:31:09 +01:00
Pierre de La Morinerie	b1a7018d30	procedure: ignore bad data when computing usual_instruction_time ... Fix #3655	2019-03-20 17:48:54 +01:00
Mathieu Magnin	6570bed09c	[Fix #3641] Do not change PJ value in API if PJ is safe	2019-03-20 11:37:31 +01:00
Paul Chavard	69a51e3296	Save SIRET data on search	2019-03-19 16:22:42 +01:00
Pierre de La Morinerie	ed1f6ec38d	procedure: fix verification delay ... The verification delay was ignoring all dossiers not closed yet.	2019-03-19 15:51:51 +01:00
simon lehericey	6607de4827	Notification: add service to send notifications	2019-03-18 16:37:51 +01:00
Paul Chavard	bb8ba75d22	Explicitly pass current_administrateur on publish	2019-03-12 11:59:01 +01:00
Paul Chavard	c37f649453	Update specs to use multiple administrateurs	2019-03-12 11:59:01 +01:00
Mathieu Magnin	44f28ec565	Remove feature flag for publish draft	2019-03-12 11:26:07 +01:00
Frederic Merizen	efa71284fc	[#3477] Test eager_load_displayed_fields	2019-03-11 17:14:17 +01:00