Commit graph

7920 commits

Author SHA1 Message Date
Pierre de La Morinerie
fa2d6f7b8b
[Refactor] Unify dossier deletion between manager and user (#4099)
Refactor de la suppression de dossier (#4099)
2019-07-16 16:47:23 +02:00
Pierre de La Morinerie
a8354bd103 dossiers: unify deletion of dossiers between manager and user
The code paths for deleting a dossier were different, depending on
whether the dossier was deleted by the user, or from the Manager.

This commit unifies the two code paths into one.

This has the effect of:

- An operation log is now recorded when an user deletes its own dossier;
- Gestionnaires are now notified even when the dossier is deleted from
  the Manager;
- The `support:delete_user_account` task now requires the email address
  of the author.
2019-07-16 16:22:20 +02:00
Keirua
4016b27002
Merge pull request #3673 from Keirua/feat/479-telecharger-export-pj
[#479] Ajout d'un bouton pour télécharger toutes les pièces d'un dossier
2019-07-16 09:30:35 +02:00
clemkeirua
25f81f1d3c download a dossier as zip with all attachments 2019-07-16 09:11:25 +02:00
Pierre de La Morinerie
5a70ae7a8f
omniauth: protect against CSRF (#4102)
Configure OmniAuth pour éviter de potentielles CSRF
2019-07-15 18:16:42 +02:00
Pierre de La Morinerie
76335511c8 omniauth: protect against CSRF
See https://github.com/omniauth/omniauth/wiki/Resolving-CVE-2015-9284
2019-07-15 18:16:00 +02:00
Pierre de La Morinerie
329bfd5f4d
Merge pull request #4100 from betagouv/rename-submit
Usager : l'action « Soumettre le dossier » est renommée en « Déposer le dossier »
2019-07-15 17:19:51 +02:00
Pierre de La Morinerie
36eca3d059 dossier: rename the "Submit" action 2019-07-15 17:18:28 +02:00
Pierre de La Morinerie
0d747677bc
build(deps): bump lodash from 4.17.11 to 4.17.14 (#4101)
Mise à jour de lodash vers la version 4.17.14
2019-07-15 16:35:51 +02:00
dependabot[bot]
85027a8f1e
build(deps): bump lodash from 4.17.11 to 4.17.14
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.11 to 4.17.14.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](https://github.com/lodash/lodash/compare/4.17.11...4.17.14)

Signed-off-by: dependabot[bot] <support@github.com>
2019-07-15 14:24:59 +00:00
Pierre de La Morinerie
862b08427b status_overview: remove extraneous line 2019-07-15 15:55:25 +02:00
Pierre de La Morinerie
d263a73a62
Update _status_overview.html.haml (#4090)
Usager : clarifie les explications des différents états du dossier
2019-07-15 15:52:05 +02:00
Pierre de La Morinerie
d9c01c0af6 status_overview: improve wording 2019-07-15 15:45:16 +02:00
Benjamin-Doberset
8ea8e52431 Update _status_overview.html.haml 2019-07-15 15:45:16 +02:00
Pierre de La Morinerie
bffec461f3
Merge pull request #4088 from betagouv/Benjamin-Doberset-patch-1
Usager : clarifie le sens du délai de traitement estimé
2019-07-15 15:40:38 +02:00
Pierre de La Morinerie
077082c381 dossier: improve estimated delay wording 2019-07-15 15:27:22 +02:00
Benjamin-Doberset
77d825ae63 Update _estimated_delay.html.haml 2019-07-15 15:27:22 +02:00
Pierre de La Morinerie
115a123555
Fix 4052 admin contextual help (#4094)
Administrateur : le bouton "Publier" n'est plus masqué par l'aide contextuelle
2019-07-15 12:25:12 +02:00
Chaïb Martinez
5cb6ba2f3b Fix tests
Signed-off-by: Chaïb Martinez <chaibax@gmail.com>
2019-07-15 12:10:56 +02:00
Chaïb Martinez
3f9f67eb78 admin: fix the "Valider" button being hidden by Crisp
Fix #4021

Signed-off-by: Chaïb Martinez <chaibax@gmail.com>
2019-07-15 12:10:56 +02:00
Chaïb Martinez
d968e7e6bd Add some admin usage info for contextual help with crisp
Fix #4052

Signed-off-by: Chaïb Martinez <chaibax@gmail.com>
2019-07-15 12:10:56 +02:00
Chaïb Martinez
04e204c740 Minor text fix
Signed-off-by: Chaïb Martinez <chaibax@gmail.com>
2019-07-15 12:10:56 +02:00
Chaïb Martinez
535d032b73 Send URL page view to Crisp to trigger contextual help
Fix #4052

Signed-off-by: Chaïb Martinez <chaibax@gmail.com>
2019-07-15 12:10:56 +02:00
Pierre de La Morinerie
216aabf55b
manager: fix the deletion email not being sent (#4097)
Manager : corrige l'email notifiant la suppression, qui n'était plus envoyé à l'usager
2019-07-15 11:21:26 +02:00
Pierre de La Morinerie
d5f360c85f manager: fix the deletion email not being sent
When deleting a dossier from the manager, the deletion notification
email was not being sent. This is because the returned object from
`Dossier#hide!` was invalid.
2019-07-15 10:01:16 +02:00
Pierre de La Morinerie
2c8d953bb9 db: fix missing update to schema.rb 2019-07-11 16:45:32 +02:00
Pierre de La Morinerie
ba137279d5
Suppression de colonnes dépréciées sur Procedure (#4093)
Suppression de colonnes dépréciées sur Procedure
2019-07-11 16:12:28 +02:00
Pierre de La Morinerie
619f663e1a procedure: remove individual_with_siret column 2019-07-11 15:57:46 +02:00
Pierre de La Morinerie
a047ee356b procedure: remove expects_multiple_submissions column 2019-07-11 15:57:46 +02:00
Keirua
6263a786d2
Merge pull request #4084 from Keirua/3553-explications-onglets-instructeurs
#3553 - Textes explicatifs des onglets pour les instructeurs
2019-07-11 15:48:16 +02:00
clemkeirua
6838e69986 ajout de textes explicatifs pour les instructeurs 2019-07-11 15:48:00 +02:00
Pierre de La Morinerie
420f7362fc
dossier: make messagerie available on archived procedures (#4091)
Instructeur : ré-active la messagerie sur les démarches archivées
2019-07-11 15:45:38 +02:00
Pierre de La Morinerie
35c3795f56 dossier: make messagerie available on archived procedures
An Admin may archive a procedure to make it unavailable to
the general public, but before all dossiers are handled. In this case,
the messagerie needs to be available.

Fix #4089
2019-07-11 15:37:04 +02:00
Pierre de La Morinerie
d3a7bc271e
Improve numeric field validation errors (#4076)
Usager : améliore le message d'erreur lorsque la valeur d'un champ numérique est invalide
2019-07-11 15:13:38 +02:00
Pierre de La Morinerie
10065df8ce champs: put champ label in numeric fields validation messages
Replaces

> La valeur du champ doit être un nombre entier (sans chiffres après
> la virgule)

by

> La valeur du champ « Nombre de parents » doit être un nombre entier
> (sans chiffres après la virgule)
2019-07-11 15:12:48 +02:00
Pierre de La Morinerie
56c846900b champs: improve validation message of numeric fields
Replaces

> Champs value doit être un nombre

by

> La valeur du champ doit être un nombre entier (sans chiffres après
> la virgule)
2019-07-11 15:12:48 +02:00
LeSim
29adf51a0e
Merge pull request #4085 from betagouv/avoid_wrong_aasm_transitions
Avoid wrong aasm transitions
2019-07-11 12:57:29 +02:00
simon lehericey
768a298c2d Same for go back in instruction 2019-07-11 12:50:15 +02:00
simon lehericey
5f39d3eac8 Fix bug when instruction repasse en construction twice 2019-07-11 12:50:15 +02:00
simon lehericey
6de1e2ec58 Fix bug when an instructeur closes a dossier already closed 2019-07-11 12:50:15 +02:00
Pierre de La Morinerie
01ba459b73
Bump lodash.template from 4.4.0 to 4.5.0 (#4086)
Bumpe lodash.template vers la version 4.5.0
2019-07-11 12:43:23 +02:00
dependabot[bot]
1e1ec4197c
Bump lodash.template from 4.4.0 to 4.5.0
Bumps [lodash.template](https://github.com/lodash/lodash) from 4.4.0 to 4.5.0.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](https://github.com/lodash/lodash/compare/4.4.0...4.5.0)

Signed-off-by: dependabot[bot] <support@github.com>
2019-07-11 10:38:08 +00:00
Pierre de La Morinerie
1f99df9d7e
Ignore :expects_multiple_submissions on the correct model (#4079)
Ignore la colonne `:expects_multiple_submissions` sur le bon modèle
2019-07-11 12:35:48 +02:00
Pierre de La Morinerie
fdca7c025a procedure: ignore :expects_multiple_submissions on the correct model 2019-07-11 12:14:25 +02:00
Pierre de La Morinerie
3e43ef029e
Merge pull request #4078 from betagouv/remove-individual-with-siret
Suppression du code de `individual_with_siret` sur `Procedure`
2019-07-11 12:13:13 +02:00
Pierre de La Morinerie
c2c9b19b3b procedure: remove individual_with_siret
It isn't used anymore (see #3077)
2019-07-11 11:58:21 +02:00
Pierre de La Morinerie
34cc3793a8
Corrige l'affichage du radio-button "Personne morale" (#4081)
Administrateur : corrige l'affichage du radio-button "Personne morale"
2019-07-11 11:54:19 +02:00
Pierre de La Morinerie
7ca3d5fce2 procedure: select for_individual by default 2019-07-10 18:47:34 +02:00
Pierre de La Morinerie
9616df192d procedure: use the model value for checking the radio buttons
Previously `checked: true` forced the checked status, disregarding the
actual value of the model.

Fix #4080
2019-07-10 18:47:28 +02:00
LeSim
399d1e4ac2
Merge pull request #4065 from betagouv/better_champs_factories
Better champs factories
2019-07-10 16:48:58 +02:00