Commit graph

5550 commits

Author SHA1 Message Date
gregoirenovel
0c9628c180 Fix some files according the the .editorconfig rules 2018-09-20 16:23:09 +02:00
gregoirenovel
66fcdda59b Extract some code in a helper
It makes the code clearer and will avoid some
linting issues
2018-09-20 16:23:09 +02:00
gregoirenovel
a87e79ac1f Update a test to comply with Rubocop rules 2018-09-20 16:23:09 +02:00
gregoirenovel
a9da6047c3 Add eclint to package.json 2018-09-20 16:23:09 +02:00
gregoirenovel
a1c1bacce7
Merge pull request #2634 from tchak/reset-flipflop
Reset Flipflop before each test
2018-09-20 16:21:31 +02:00
Paul Chavard
f2139552c2 Reset Flipflop before each test 2018-09-20 16:13:34 +02:00
gregoirenovel
49113e8112
Merge pull request #2632 from tchak/fix-dossier-link
Fix dossier link
2018-09-20 16:13:04 +02:00
Paul Chavard
905a715e16 Fix dossier link 2018-09-20 16:05:40 +02:00
Mathieu Magnin
591e6f25c3 Change ssh key for deploy 2018-09-20 14:11:39 +02:00
gregoirenovel
e10781dc08
Merge pull request #2637 from betagouv/clean
Clean the deploy script
2018-09-20 13:31:19 +02:00
gregoirenovel
90e7a5d276 Improve error messages 2018-09-20 13:03:42 +02:00
gregoirenovel
c445de9f83 Regroup definitions at the top of deploy.rb 2018-09-20 11:37:04 +02:00
gregoirenovel
6dbb916c6a Remove useless comments from deploy.rb 2018-09-20 11:37:04 +02:00
gregoirenovel
fd13f9dbb2 Remove default fallback on staging for the deploy destination
Explicit > implicit
2018-09-20 11:28:58 +02:00
gregoirenovel
ec545758c3 Improve deploy.rb readability 2018-09-20 11:26:25 +02:00
gregoirenovel
276cb55d9a Remove a useless instruction from deploy.rb 2018-09-20 11:25:40 +02:00
gregoirenovel
2f940eed6d Remove a useless comment from deploy.rb 2018-09-20 11:25:25 +02:00
gregoirenovel
516860c92e deploy_ha → deploy 2018-09-20 11:20:57 +02:00
gregoirenovel
e2b09df049 Extract the deploy_ha task in a dedicated file 2018-09-20 11:20:23 +02:00
gregoirenovel
fa2afe6820 Extract the lint task in a dedicated file 2018-09-20 11:19:55 +02:00
gregoirenovel
6e867bb9ee Remove unused tasks from Rakefile 2018-09-20 11:17:34 +02:00
gregoirenovel
77e477486c
Merge pull request #2629 from betagouv/fix-wording
Fix wording
2018-09-20 10:50:54 +02:00
gregoirenovel
b317b49b3d Confirmation → activation 2018-09-20 10:43:07 +02:00
gregoirenovel
f86cc835f8 courriel → email / adresse email 2018-09-20 10:43:07 +02:00
gregoirenovel
acaf7ff5a7 Adresse électronique → adresse email 2018-09-20 10:43:07 +02:00
Paul Chavard
73581d0bdb
Merge pull request #2626 from tchak/fix-new-lines
Fix new lines in confirm dialogs
2018-09-19 14:55:42 +02:00
Paul Chavard
539f15af92 Fix new lines in confirm dialogs 2018-09-19 14:45:10 +02:00
Pierre de La Morinerie
0f4a75ac89
Merge pull request #2491 from betagouv/fix_import_db_task
Import DB: fix location
2018-09-19 14:26:22 +02:00
simon lehericey
46c29465a2 Import DB: fix location 2018-09-19 14:19:31 +02:00
Pierre de La Morinerie
272701f148
Merge pull request #2615 from betagouv/fix-invite-email-prefill
Fix invite email prefill
2018-09-19 12:42:25 +02:00
Pierre de La Morinerie
e5f4056fe2 invite: fix prefilling the invited user email 2018-09-19 12:41:09 +02:00
Pierre de La Morinerie
bfa2a4b89d invite: refactor the syntax of the submit_login_form helper 2018-09-19 12:41:09 +02:00
Pierre de La Morinerie
1a6a643dc9 invite: refactor the generation of the invitation URL 2018-09-19 12:41:09 +02:00
Pierre de La Morinerie
bc55afba51 invite: clarify logic of sign-up redirection 2018-09-19 12:41:09 +02:00
Pierre de La Morinerie
a63e035daf spec: fix Flipflop state not being reseted after test
This would cause the Support specs to fail randomly with an unexpected
redirection.
2018-09-19 12:41:09 +02:00
gregoirenovel
c98ec1c746
Merge pull request #2616 from betagouv/show-instruction-time
Show instruction time
2018-09-19 12:39:08 +02:00
gregoirenovel
8ea021fb69 Factorize code in a method 2018-09-19 12:31:59 +02:00
gregoirenovel
6b98c36dad Add Dossier#mean_traitement_time for the upcoming page de garde 2018-09-19 12:31:59 +02:00
gregoirenovel
f3a257d81d Show the mean verification time in the Résumé tab 2018-09-19 12:31:59 +02:00
gregoirenovel
d55c9dff4d Show the mean instruction time in the Résumé tab 2018-09-19 12:31:59 +02:00
Pierre de La Morinerie
faff741bf2
Merge pull request #2624 from betagouv/refactor-after-confirmation-callback
invite: move invites link to the `after_confirmation` callback
2018-09-19 12:20:15 +02:00
Pierre de La Morinerie
082ef92a99 invite: move invites link to the after_confirmation callback
Refactored from 6a69d958da

The `after_confirmation_path_for` isn't really made to be a callbback.
For instance, it is not executed during tests.

Moving the invitations linking to a proper documented callback allows
the linking to work in a testing environment, when invoking `user.confirm`.
2018-09-19 12:08:28 +02:00
gregoirenovel
cceb88539d
Merge pull request #2608 from tchak/fix-demarche-brouillon-label
Change how we format brouillon démarche label
2018-09-19 11:36:06 +02:00
Paul Chavard
9a338ec140 Change how we format brouillon démarche label 2018-09-19 11:27:55 +02:00
gregoirenovel
2af0fe7c30
Merge pull request #2619 from betagouv/fix-2618
Fix #2618
2018-09-19 10:40:44 +02:00
gregoirenovel
a0660d17eb Refactor SiretFormatValidator#luhn_checksum 2018-09-19 10:32:43 +02:00
gregoirenovel
9d18f4187c Simplify SiretFormatValidator
We can remove nil checks as we never get nil
values
2018-09-19 10:32:43 +02:00
gregoirenovel
4e4b7c617f [Fix #2618] Do not enforce Luhn for La Poste SIRET numbers 2018-09-19 10:29:43 +02:00
gregoirenovel
940dfe422b Further refactor SiretFormatValidator#validate_each 2018-09-19 10:28:07 +02:00
gregoirenovel
36950b985b Refactor SiretFormatValidator#validate_each 2018-09-19 10:15:44 +02:00